[Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Aleisha,
seems that your second patch needs the first!
You need to un-obsolete first patch

fatal: sha1 information is lacking or useless (C4/XSLT.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

Comments:
1) You wrote

my $itemtypes = "" unless GetItemTypes();

here I think you can use //

my $itemtypes = GetItemTypes() // "";

2) About ~~, as per Bug 12151 we can't use smartmatch operator

3) Which Linux/Perl/Apache version are you using?
I don't see those warnings, but on Debian weezy there are warnings
that do not appear on Ubuntu 14.04

-- 
You are receiving this mail because:
You are watching all bug changes.