[Koha-bugs] [Bug 12176] Remove HTML from additem.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176

--- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Marcel de Rooy from comment #20)
> Thanks Bernardo for reviving this one.

Thank you!!

> 
> [1] Remove .hidden after [% avalue %] in additem.tt. (Typo)
a leftover from my debugging 

> [2] A closer look revealed that mv.avalue is useless too. An input element
>     does not contain any content. Putting it after the hidden element
>     in a non-visible context has no meaning.
Ok!
> [3] Change handling of select attributes readonly and disabled.

I was worried about this, since i think select can't have readonly
attribute, only disabled. But if disabled, it's content is not sent
back to GET/POST, so perhaps a hidden attribute with same name and
old value is needed.
Or may be now select can have readonly, but then we need to remove disabled.
I left both to not change old behavior

> [4] Remove unused variable $attributes_no_value_textarea
Good! I forgot them
But in my first patch i also removed "my $attributes_no_value"

> 
> Sorry that this small list kept growing :)
Perfect, thanks again!

-- 
You are receiving this mail because:
You are watching all bug changes.