[Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39321|0                           |1
        is obsolete|                            |

--- Comment #14 from Indranil Das Gupta <indradg at gmail.com> ---
Created attachment 39353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39353&action=edit
Bug 14206 Adds two tests to t/db_dependent/Letters.t

C4::Letters::getletter is called in tools/letter.pl by the function
delete_confirm() to display the selected notice for deletion. Due to
current implementation of getletter(), a notice that does not use
the 'email' template (but uses any/all of the other templates - sms,
print or phone) can't be deleted from the staff client.

This patch adds 2 tests to t/db_dependent/Letters.t to test the bug.

Test plan
=========

1/ Apply the patch and run prove -v t/db_dependent/Letters.t
2/ Test 38 should FAIL - getletter() fails when message_transport_type
   is not passed by caller function i.e. delete_confirm() in letter.pl

     #   Failed test 'Bug 14206 - message_transport_type not passed, correct
mtt detected'
     #   at t/db_dependent/Letters.t line 179.
     #          got: undef
     #     expected: 'print'

   Test 39 should pass - getletter() functions correctly when passed
   message_transport_type param by caller function i.e. add_validate()

(Test plan continues in the second commit)

-- 
You are receiving this mail because:
You are watching all bug changes.