[Koha-bugs] [Bug 14113] Silence warnings t/Date.t

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 38904
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38904
[SIGNED-OFF] Bug 14113: Silence t/Dates.t warnings and cleanup output.

Review of attachment 38904:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14113&attachment=38904)
-----------------------------------------------------------------

::: t/Dates.t
@@ +59,3 @@
>  foreach ( @{ $thash{'iso'} } ) {
> +    if ($_ =~ /1952/) {
> +        warning_like { $val = format_date($_); } qr/Illegal date/,

This is confusing I think.
The date is not illegal because it contains 1952, but because the day or month
is 0.
Maybe should we test all cases (list all the illegal dates), or be explicit
somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.