[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri May 22 14:25:54 CEST 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #34191|0 |1
is obsolete| |
Attachment #34192|0 |1
is obsolete| |
Attachment #34193|0 |1
is obsolete| |
Attachment #34195|0 |1
is obsolete| |
Attachment #39100|0 |1
is obsolete| |
Attachment #39101|0 |1
is obsolete| |
Attachment #39102|0 |1
is obsolete| |
--- Comment #214 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 39392
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39392&action=edit
[PASSED QA] Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm
- Subroutine prototypes used at line 82, column 1. See page 194 of PBP.
(Severity: 5)
- "return" statement with explicit "undef" at line 102, column 28. See page
199 of PBP. (Severity: 5)
- Expression form of "eval" at line 108, column 20. See page 161 of PBP.
(Severity: 5)
- Variable declared in conditional statement at line 126, column 5. Declare
variables outside of the condition. (Severity: 5)
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list