From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 11:48:35 +0000 Subject: [Koha-bugs] [Bug 15097] New: Update MARC21 de-DE frameworks to Update 21 (September 2015) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Bug ID: 15097 Summary: Update MARC21 de-DE frameworks to Update 21 (September 2015) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Update translated German MARC21 frameworks to the latest version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:48:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 11:48:57 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 13:31:22 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 13:31:25 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44249|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 44270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44270&action=edit [PASSED QA] Bug 14773: Move help link back out of the dropdown menu This moves the help link back out of the dropdown menu like it used to be. To test: 1. Notice that in intra the help link is inside the dropdown menu. 2. Apply the patch 3. Notice that the help link is now clearly visible in the top right corner of the page. Sponsored-by: Vaara-kirjastot Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 13:32:45 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Tiny change, thinking of this more as a bug fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:44:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 13:44:17 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 13:44:20 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44267|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 44271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44271&action=edit [PASSED QA] Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:06:45 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:06:48 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44257|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44272&action=edit [PASSED QA] Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:33:31 +0000 Subject: [Koha-bugs] [Bug 15098] New: Itemtype description missing from facets for itypes hidden in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Bug ID: 15098 Summary: Itemtype description missing from facets for itypes hidden in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If the itemtype is marked as hidden in OPAC, only the itype code is shown in the facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:45:32 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:46:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:46:37 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 --- Comment #1 from Katrin Fischer --- Created attachment 44273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44273&action=edit Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015) Updates the framework files using the po file based mechamism provided by Bernardo. To test: - Check that changes make sense - Run the Koha web installer for de-DE - Confirm all 4 files changed here load without errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 14:47:06 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net, | |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:01 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #12 from Katrin Fischer --- Created attachment 44274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44274&action=edit [PASSED QA] Bug 14333: Update MARC21 frameworks to Update No. 20 and 21 Default frameworks updated to update 20 (April 2015) and 21 (September 2015) Update No. 20 Bibliographic New field 884 New subfields 037$3, 037$5 and 382$e Authority New field 884 New subfields 046$q, 046$r and 382$e Update No. 21 Bibliographic New tag 348 New subfields 336$0, 337$0 and 338$0 Authority New field 348 New sufields 336$0 and 670$w To test: 1) Remove all your frameworks 2) Check mandatory bibliographic and authority files load without problem 3) Check new fields/subfields Signed-off-by: Zeno Tajoli Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:05 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #13 from Katrin Fischer --- Created attachment 44275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44275&action=edit [PASSED QA] Bug 14333: followup - Fix labels This patch fixes same labels on bibliographic and authority frameworks, and one typo. To test: 1) Remove all your frameworks 2) Check mandatory bibliographic and authority files load without problem 3) Check fixed labels Signed-off-by: Zeno Tajoli Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:09 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #14 from Katrin Fischer --- Created attachment 44276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44276&action=edit [PASSED QA] Bug 14333: followup 2 - split line to ease translation This patch only put in its own line inserted values. This is necessary in order to translate this files. To test: 1) Just check that files load normally. http://bugs.koha-community.org/show_bug.cgi?id=14333 Signed-off-by: Zeno Tajoli Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:30 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:32 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:34 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:04:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:04:36 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:09:27 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:10:36 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44127|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44277&action=edit [PASSED QA] Bug 15063: Update MARC21 es-ES frameworks to Update 21 (September 2015) This patch put in sync es-ES marc21 fields/subfields with english ones. To test: 1) Apply the patch 2) Remove all bib/auth frameworks 3) Load all files, check they load without errors Signed-off-by: Zeno Tajoli Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:23:18 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:23:21 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44261|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44278&action=edit [PASSED QA] Bug 15094: Update link to Windows Offline Circ This patch updates the link on the main circulation page to point to the newest release of the offline circulation tool. To test: * Go to Circulation * Click 'Get desktop application' * Confirm the link goes to github Signed-off-by: Bernardo Gonzalez Kriegel Link Ok No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:31:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:31:55 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:31:58 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44258|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 44279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44279&action=edit [PASSED QA] Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:34:28 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #173 from Katrin Fischer --- I think last comment is fixed with bug 15090. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:37:35 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system - first steps In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove deprecated module |Remove deprecated module |C4::Dates from system |C4::Dates from system - | |first steps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:49:08 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 16:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 15:49:14 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44273|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 44280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44280&action=edit [SIGNED-OFF] Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015) Updates the framework files using the po file based mechamism provided by Bernardo. To test: - Check that changes make sense - Run the Koha web installer for de-DE - Confirm all 4 files changed here load without errors Signed-off-by: Bernardo Gonzalez Kriegel All files load without errors, pass marc bibliographic fw test No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 17:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 16:48:18 +0000 Subject: [Koha-bugs] [Bug 12054] Don't allow to create orders for inactive vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|It?s possible to make order |Don't allow to create |from an inactive vendor |orders for inactive vendors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 17:50:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 16:50:24 +0000 Subject: [Koha-bugs] [Bug 13993] Set correct orderstatus when order is transferred from one vendor to another In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transfer order from one |Set correct orderstatus |vendor to another vendor |when order is transferred |previous orderstatus is not |from one vendor to another |changed. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 19:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 18:56:28 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option to hide and group |Advanced search: Hide |itemtypes from advanced |itemtypes from search form |search |& Group itemtypes together | |into one search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:04:37 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:09:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:09:00 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I am failing to reproduce the problem - not sure what I am missing :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:09:35 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:48:23 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |critical --- Comment #1 from Katrin Fischer --- Data is lost.. upgrading severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:50:39 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 44281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44281&action=edit Bug 15081: Take transaction handling out from TestBuilder This patch removes transaction handling code from TestBuilder. It fixes the TestBuilder.t to handle the transaction on its own. Verify that t/db_dependent/TestBuilder.t passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:50:43 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 44282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44282&action=edit Bug 15081: (followup) Make test files using TestBuilder handle their transactions This trivial patch introduces the code needed on the test files so they handle the DB transaction instead of relying on the (removed) transaction started/rolled back by TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:51:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:51:17 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 20:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 19:51:47 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:10:37 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40853|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 44283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44283&action=edit Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices The patch changes the sequence of cronjobs in the crontab example file and in the cron.daily file of the packages. This is why: 1) Renew automatically ... only when we can't renew, we want to 2) Calculate fines ... once the fine are calculated and charged we can print the amount into the 3) Overdue notices Before the change it could happen that you'd charge for an item, that would then be renewed. Or that you'd try to print fine amounts into the overdue notices, when they would only be charged moments later. To test: - configure your system so you have items that should - be charged with fines - renew automatically - configure your crontabs according to the example file or switch the cron.daily in your package installation with the new one - configure your overdue notices so that one should be generated <> - Wait for the cronjobs or schedule them to run earlier - Verify all is well and as it should be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:11:16 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #12 from Katrin Fischer --- Rebased on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:12:42 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:13:04 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #13 from Katrin Fischer --- Calculating fines and then renewing an item can make patrons unhappy, updating severity a little bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:13:05 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:13:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:13:29 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:13:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:13:57 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:15:47 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:17:51 +0000 Subject: [Koha-bugs] [Bug 15099] New: Fix file name: categorie.pl should be either category.pl or categories.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Bug ID: 15099 Summary: Fix file name: categorie.pl should be either category.pl or categories.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I keep stumbling over categorie.pl... it would be nice to fix the file name to be either category.pl or categories.pl :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:23:15 +0000 Subject: [Koha-bugs] [Bug 15100] New: MARC21: Display of $d for 7xx and 1xx fields should be optional Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Bug ID: 15100 Summary: MARC21: Display of $d for 7xx and 1xx fields should be optional Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With some of the changes done for 3.22 we have started displaying $d for 7xx and 1xx fields in the OPAC. $d - Dates associated with a name (NR) Example: Record: 700 1 _aMustermann, Karin _d1909-2002 Display: Contributor(s): Mustermann, Karin 1909-2002 There is no way to hide the $d. We should at least add a span with a class to make this possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:26:46 +0000 Subject: [Koha-bugs] [Bug 15101] New: Don' display system preference AllowPkiAuth below heading CAS Authentication Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Bug ID: 15101 Summary: Don' display system preference AllowPkiAuth below heading CAS Authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We should not display system preference AllowPkiAuth below heading CAS Authentication, because it's a different thing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 21:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 20:35:57 +0000 Subject: [Koha-bugs] [Bug 15102] New: Fix capitalization for some strings on XSLT detail pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Bug ID: 15102 Summary: Fix capitalization for some strings on XSLT detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This applies to OPAC and staff: - Contained Works - Related Works - Media Type - Content Type - Carrier Type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 23:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 22:30:23 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- Re-writing the search history sounds like a very bad idea to me. If we want to have a more explicit list in the search history, it would be a better idea to change the qualifiers/aliases used in the Advanced Search and the masthead search. That way, the search history (and the search result pages) would be more user-friendly, but we wouldn't be re-writing anything. This also means advanced users would have their queries stored in the search history unaltered. As an advanced user, it would make me happy not to have my searches mangled after the fact. Honestly, changing the qualifiers/aliases used in the Advanced Search and masthead search to something more user-friendly might actually lower the barrier to entry for people who see things like "au" and "wrdl" in the code and get intimidated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 23:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 22:31:04 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 --- Comment #6 from David Cook --- P.S. That's not me saying that I want to work on this though :p. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 00:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 23:39:42 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15103 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 [Bug 15103] Import Borrowers Performance Improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 00:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 23:39:42 +0000 Subject: [Koha-bugs] [Bug 15103] New: Import Borrowers Performance Improvement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 Bug ID: 15103 Summary: Import Borrowers Performance Improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cnorthcott.work at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 7923 Import Borrowers has a long run/load time to import batch of borrowers. I have attempted to improve the runtime of the import borrowers tool and my enhancement reduces the time to import by an average of 22%. I discovered the extended runtime was mostly due to the intentionally expensive password hashing algorithm used by Koha which is largely unavoidable, but I was able to save some time by switching calls to DBIx::Class::ResultSet to reduce the import of 5000 patrons from 242.2 seconds to 187.8 seconds, saving almost a whole extra minute (54.4 seconds) of database calls. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 00:49:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 23:49:52 +0000 Subject: [Koha-bugs] [Bug 15074] build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15074 --- Comment #2 from Robin Sheat --- Yeah, because the packaging is part of the source, you can't have packaging revisions because it doesn't make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 00:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2015 23:58:20 +0000 Subject: [Koha-bugs] [Bug 15089] koha-dump set permissions correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15089 --- Comment #1 from Robin Sheat --- This deliberately isn't done as there's no reason to have the webserver able to read these files, generally. They contain server configs and database passwords, and so on so exposure of them should be kept very limited. The reason it's done for the database dump is that this permits users of hosted solutions to download their data at any time, but the $metadump file isn't really data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:20:36 +0000 Subject: [Koha-bugs] [Bug 15104] New: Batch Record Modification Performance Improvement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 Bug ID: 15104 Summary: Batch Record Modification Performance Improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: cnorthcott.work at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7923 Batch Record Modification has an unreasonably long run/load time. I have attempted to improve the runtime of the Batch Record Modification tool and my enhancement reduces the time to modify a batch of records by an average of 71.44% I discovered the extended runtime was mostly due to the serialisation and de-serialisation of success messages for every modified record. I have changed the reporting on this feature to only record and display messages for errors which improved the time of modification for x records from 233.2 seconds to 66.6 seconds, saving 166.6 seconds. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:20:36 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15104 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 [Bug 15104] Batch Record Modification Performance Improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:26:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:26:51 +0000 Subject: [Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 --- Comment #1 from cnorthcott.work at gmail.com --- The modification test case was for 2300 records, sorry forgot to update the value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:36:11 +0000 Subject: [Koha-bugs] [Bug 15105] New: Batch Item Modification Performance Improvement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105 Bug ID: 15105 Summary: Batch Item Modification Performance Improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: cnorthcott.work at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 7923 Batch Item Modification has a fairly long run/load time. I have attempted to improve the runtime of the Batch Item Modification tool and my enhancement reduces the time to modify a batch of items by an average of 84.24% I discovered the extended runtime was mostly due to the unoptimised cacheing of GetMarcStructure. I was able to save some time by using Memoize (http://search.cpan.org/~mjd/Memoize-1.01/Memoize.pm) to cache GetMarcStructure function calls using the same parameters, on top of the current caching system. In addition I was able to save a significant amount of time by decreasing the update rate of the progress bar which displays completeness of the process as items are modified. In the end my test case of 986 items originally took 65.36 seconds after optimisation it took 10.3 seconds, saving 55.06 seconds. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:36:11 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15105 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105 [Bug 15105] Batch Item Modification Performance Improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:49:49 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15106 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 [Bug 15106] Batch Patron Modification Performance Improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:49:49 +0000 Subject: [Koha-bugs] [Bug 15106] New: Batch Patron Modification Performance Improvement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 Bug ID: 15106 Summary: Batch Patron Modification Performance Improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cnorthcott.work at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 7923 Batch Patron Modification has a fairly long run/load time. I have attempted to improve the runtime of the Batch Patron Modification tool and my enhancement reduces the time to modify a batch of patrons by an average of 44.02% I discovered the extended runtime was mostly due to detailed data retrieval in preparation for display. The overhead for a batch of 1000 patrons was enough that I have changed functionality so that if there are more than 20 patrons in the batch to simply display a success message instead of the details of every changed patron. There are other small code logic improvements also included to prevent unnecessary function calls. In the end my test case of 1000 patrons originally took 59.02 seconds to modify, after optimisation it took 33.04 seconds saving 25.98 seconds. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:55:13 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 --- Comment #1 from cnorthcott.work at gmail.com --- Sorry, looks like I didn't proofread my description very well it should read: I saved time by switching calls from DBIx::Class::ResultSet to basic SQL to $dbh which reduced the import of 5000 patrons from 242.2 seconds to 187.8 seconds, saving almost a whole extra minute (54.4 seconds) of database calls. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:57:54 +0000 Subject: [Koha-bugs] [Bug 15107] New: Batch Patron Deletion (Trash) Performance Improvement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 Bug ID: 15107 Summary: Batch Patron Deletion (Trash) Performance Improvement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cnorthcott.work at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 7923 Batch Patron Deletion (Trash) has a fairly long run/load time compared to Batch Patron Deletion (Permanent). I have attempted to improve the runtime of the Batch Patron Deletion (Trash) tool and my enhancement reduces the time to modify a batch of patrons by an average of 78.21% I discovered the extended runtime was mostly due to the overhead DBIx::Class::ResultSet which I switched to basic SQL calls to the $dbh which reduced the trashing of 1000 patrons from 24.84 seconds to 5.41 seconds, saving 19.43 seconds of resultset calls. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 01:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 00:57:54 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15107 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 04:12:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 03:12:44 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #98 from Robin Sheat --- (In reply to Jonathan Druart from comment #50) > On Jessie: > dh-make-perl --pkg-perl --build --cpan Test::DBIx::Class > build a wonderfull libtest-dbix-class-perl_0.45-1_all.deb package without > any error. I suspect you had an unclean environment. The dh-make-perl says: Needs the following modules for which there are no debian packages available: - Test::mysqld - MooseX::Attribute::ENV - Test::PostgreSQL - DateTime::Format::Pg - DBIx::Class::Schema::PopulateMore - DBIx::Class::UUIDColumns - DBIx::Class::TimeStamp - Data::Visitor The build (wheezy in a pbuild env) refuses to go anywhere: The following packages have unmet dependencies: pbuilder-satisfydepends-dummy : Depends: libdbix-class-schema-populatemore-perl (>= 0.16) which is a virtual package. Depends: libdbix-class-timestamp-perl (>= 0.13) but it is not going to be installed. Depends: libdbix-class-uuidcolumns-perl (>= 0.02005) which is a virtual package. Depends: libmoosex-attribute-env-perl (>= 0.01) which is a virtual package. Depends: libmoosex-types-perl (>= 0.23) but it is not going to be installed. Depends: libossp-uuid-perl (>= 1.215) but it is not going to be installed. Depends: libsql-translator-perl (>= 0.11006) but it is not going to be installed. Depends: libtest-deep-perl (>= 0.106) but it is not going to be installed. Depends: libtest-mysqld-perl (>= 0.14) which is a virtual package. Depends: libtest-postgresql-perl (>= 0.09) which is a virtual package. Depends: perl (>= 5.15.2) but 5.14.2-21+deb7u2 is installed. I don't think it's possible to make this work in a supported environment. There's no way I'm backporting a new perl version, for one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:06:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #214 from Julian Maurice --- Required versions of dependencies are now in Debian Sid https://packages.debian.org/sid/libswagger2-perl https://packages.debian.org/sid/libjson-validator-perl Now we need to re-package them for debian.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:11:07 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44281|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 44284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44284&action=edit Bug 15081: Take transaction handling out from TestBuilder This patch removes transaction handling code from TestBuilder. It fixes the TestBuilder.t to handle the transaction on its own. Verify that t/db_dependent/TestBuilder.t passes. Followed test plan, TestBuilder.t passes Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:11:47 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #215 from Julian Maurice --- Created attachment 44285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44285&action=edit Bug 13799: Update dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:19:35 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44282|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 44286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44286&action=edit Bug 15081: (followup) Make test files using TestBuilder handle their transactions This trivial patch introduces the code needed on the test files so they handle the DB transaction instead of relying on the (removed) transaction started/rolled back by TestBuilder. Tested all of the files before and after applying the patch, resultes are the same. (Pass exept of t/db_dependent/Barcodes_ValueBuilder.t, this has the same error). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:20:35 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:24:04 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #5 from Marc V?ron --- Note: With and without patch, t/db_dependent/Barcodes_ValueBuilder.t fails with: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for Statement "DELETE FROM items"] at t/db_dependent/Barcodes_ValueBuilder.t line 35. not ok 2 - incremental barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 07:55:37 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- Created attachment 44287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44287&action=edit Steps to reproduce error message (without plack) I can reproduce the issue in two steps (without plack): 1) Call /cgi-bin/koha/rotating_collections/addItems.pl without param Result: Screen to add items. Warning in intranet-error.log: Use of unitialized value in string eq at (...)adItems.pl line 42 Expected result: Should display an error message 2) Try to add an item Result: Displays error message: Failed to add item with barcode XXXX: NO_ID See screenshots attached. See screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 09:27:03 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 10:22:33 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #7 from paxed --- ...And whoever works on this, also remember to consider translation. (These cryptic search prefixes are one of the things both patrons and staff have complained about...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:13:08 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #6 from M. Tompsett --- Comment on attachment 43954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43954 Bug 14946 - Remove C4::Dates from files acqui/*.pl Review of attachment 43954: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14946&attachment=43954) ----------------------------------------------------------------- Some of these comments happen multiple times in this patch. I just picked on a couple. ::: acqui/finishreceive.pl @@ +63,5 @@ > my $new_ordernumber = $ordernumber; > > +$datereceived = eval { output_pref( { dt => dt_from_string( $datereceived) , dateonly => 1, dateformat => 'iso' } ); }; > +$datereceived = output_pref( { dt => dt_from_string( $datereceived) , dateonly => 1, dateformat => 'iso' } ) > + if (! $datereceived ); Either both lines will succeed or both will fail. Why is there $datereceived in the second line call to dt_from_string? ::: acqui/histsearch.pl @@ +101,2 @@ > } > +if ( $d = $input->param('to') ) { Why is this 'to' and the other is 'iso'? I don't see a template change in this patch. ::: acqui/invoice.pl @@ +84,5 @@ > + my $billingdate = ''; > + > + if ( $input->param('shipmentdate') ) { > + $shipmentdate = eval { dt_from_string( $input->param('shipmentdate') ) }; > + $shipmentdate = output_pref( { dt => $shipmentdate, dateformat => 'iso', dateonly => 1 } ) if ( $shipmentdate ); Post-fix if required because param('shipmentdate') could be a bad date? ::: acqui/orderreceive.pl @@ +222,4 @@ > invoiceid => $invoice->{invoiceid}, > invoice => $invoice->{invoicenumber}, > datereceived => $datereceived, > + datereceived_iso => output_pref( { dt => $datereceived, dateonly => 1, dateformat => 'iso' } ), Formatting a date to ISO seems like a GUI issue. Is there not a way to format dates ISO in the Template? If not, ignore this. :) ::: acqui/parcels.pl @@ +146,5 @@ > my @parcels = GetInvoices( > supplierid => $booksellerid, > invoicenumber => $code, > + ( $datefrom ? ( eval { shipmentdatefrom => output_pref({ dt => dt_from_string($datefrom), dateformat => 'iso' }); } ) : () ), > + ( $dateto ? ( eval { shipmentdateto => output_pref({ dt => dt_from_string($dateto), dateformat => 'iso' }); } ) : () ), Nested code like this is difficult to read, and the ? makes it worse. Please set some local variables outside the parameter list to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:37:16 +0000 Subject: [Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:38:32 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:39:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:39:00 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:39:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:39:24 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 14:45:16 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 --- Comment #5 from Kyle M Hall --- Looks like the issue is related to deleteditems having the same itemnumber is an item that is going to be deleted: http://screencast.com/t/jTd5b2DcB3A After clearing out duplicate itemnumber from deleteditems: http://screencast.com/t/PJxpEkf1DP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:15:55 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:27:30 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #16 from Tom?s Cohen Arazi --- Please rebase against master, urgently :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:31:12 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #79 from Tom?s Cohen Arazi --- Please rebase against master. Better put the updatedatabase.pl entry on an atomicupdate file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:42:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:42:15 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Parche aplicado en master. Gracias Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:43:42 +0000 Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:50:06 +0000 Subject: [Koha-bugs] [Bug 15108] New: OAI-PMH provider improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Bug ID: 15108 Summary: OAI-PMH provider improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org - Fixed date handling to use UTC as specs require. - Added support for deleted records. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in biblionumber order. - Improved performance of database queries especially for large collections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:50:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:50:15 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 15:56:26 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Does this one really depend on 14955? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:04:31 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:05:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:05:19 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:44:16 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3206 Blocks| |14939 CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Do you plan to work on this? Support for deleted record is already there in master. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 [Bug 3206] OAI repository deleted record support http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 [Bug 14939] OAI Server classes must be modularized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:44:16 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15108 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 [Bug 15108] OAI-PMH provider improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:44:16 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15108 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 [Bug 15108] OAI-PMH provider improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:46:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:46:18 +0000 Subject: [Koha-bugs] [Bug 15109] New: Regression in patron search results ordering Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Bug ID: 15109 Summary: Regression in patron search results ordering Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:46:25 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:48:17 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com --- Comment #5 from Nicole Engard (ByWater) --- This is one that we probably want to backport to any versions we're still supporting. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:48:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:48:29 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:48:31 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #1 from Kyle M Hall --- Created attachment 44288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44288&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 16:50:10 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #2 from Olli-Antti Kivilahti --- Hi! We got somebody from the national library to take a look at the OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot in deciphering what features have been implemented since 3.16. I will provide the commit as soon as I receive the improved version of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:04:00 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #38 from Nicole Engard (ByWater) --- 11:02 ~/kohaclone (master % u=)$ git qa 10067 >From git://git.koha-community.org/koha * branch master -> FETCH_HEAD Branch bug10067-qa set up to track remote branch master from origin. Switched to a new branch 'bug10067-qa' Bug 10067 - decreaseLoanHighHolds messes with specify due date 42794 - Bug 10067 - decreaseLoanHighHolds messes with specify due date Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10067 - decreaseLoanHighHolds messes with specify due date Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Failed to merge in the changes. Patch failed at 0001 Bug 10067 - decreaseLoanHighHolds messes with specify due date When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10067---decreaseLoanHighHolds-messes-with-spec-ly2_w7.patch 11:03 ~/kohaclone (bug10067-qa *+%|AM u=)$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:04:15 +0000 Subject: [Koha-bugs] [Bug 15110] New: decreaseHighHolds unclear Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15110 Bug ID: 15110 Summary: decreaseHighHolds unclear Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When the decreaseHighHolds system preference is enabled. The message that appears in circulation is clear. However, it mentions "High Demand Item Loan Period...". If you search 'High Demand' in system preferences no results are found. Is it possible to add language to the description to include the words "high Demand' so it can be found easily by librarians. Thanks, joy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:13:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:13:43 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com --- Comment #9 from Nicole Engard (ByWater) --- I don't see a test plan on this - can you add one and then I'll happily test. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:25:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:25:05 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #3 from Fr?d?ric Demians --- > We got somebody from the national library to take a look at the > OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot > in deciphering what features have been implemented since 3.16. > 11 > I will provide the commit as soon as I receive the improved version of this > patch. Please work on the top of bug 14939. Signing it would even been better. Having a modularized OAI server will help a lot in term of maintainability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:31:54 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42794|0 |1 is obsolete| | --- Comment #39 from Eivin Giske Skaaren --- Created attachment 44290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44290&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:33:32 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:52:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:52:50 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #40 from Nicole Engard (ByWater) --- Created attachment 44291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44291&action=edit warning appears The behavior hasn't changed. It still uses the set due date and so the date is filled in so the next check out I do, which has no holds on it is automatically due in 2 days instead of the original loan period. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:53:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:53:10 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #41 from Nicole Engard (ByWater) --- Created attachment 44292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44292&action=edit specify due date filled in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:53:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 17:53:18 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 18:27:29 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #21 from Olli-Antti Kivilahti --- Created attachment 44293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44293&action=edit Bug 13906 - TestObjectFactory(ies) for Koha objects. Holds test factory for v3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 18:28:21 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44134|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 44294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44294&action=edit Bug 10744 - ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 18:29:06 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13906 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 18:29:06 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 19:23:25 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |jweaver at bywatersolutions.co | |m, | |nicole at bywatersolutions.com Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jweaver at bywatersolutions.co | |m --- Comment #4 from Jesse Weaver --- We have received sponsorship for the following approach: a) Add a new system preference "PatronQuickAddFields" b) In this new preference we would list the fields to be in the quick add form ( similar to the list of required fields system preference ) c) When displaying the "new patron" form in quick add mode, all fields that are not mandatory or not listed in PatronQuickAddFields will be hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:16:01 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43954|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 44295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44295&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor Amended to make patch apply 25.10.2015/mv Amended following comment #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:36:45 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44288|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44296&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Followed test plan. Worked as expecting (after a browser reload). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:46:55 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:46:58 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44150|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44297&action=edit Bug 15080 - ./translate tool should tell if xgettext executable is missing Just upgraded our Koha container to 14.04 and noticing the misc/translator/translate doesn't work. This is because of a missing package gettext. This patch makes ./translate die with a helpful suggestion to install gettext if xgettext-program is missing. Signed-off-by: Frederic Demians I can reproduce the bug by desinstalling 'gettext' package on a Debian box. I confirm that without this patch, 'translate' command fails miserably. Suggesting to install gettext package is welcomed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:47:45 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 20:47:47 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43092|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 44298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44298&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:00:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:00:17 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #20 from Liz Rea --- Pushed to 3.18.x is in 3.18.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:00:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:00:40 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #19 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:00:56 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 --- Comment #8 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:01:27 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 --- Comment #14 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. Note that I left off the tests for 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:02:16 +0000 Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success in anonymous patron not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756 --- Comment #16 from Liz Rea --- Pulled the tests out of 3.18.x for 3.18.12. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:02:38 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:02:53 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:03:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:03:10 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #14 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:03:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:03:24 +0000 Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not listed in the system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #7 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:03:56 +0000 Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:04:22 +0000 Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #13 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:04:54 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #29 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:05:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:05:30 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:05:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:05:57 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:08:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:08:05 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:08:08 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43380|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44299&action=edit Bug 15004: Allow to change amounts of duplicated budgets When duplicating a budget we now have the possibility to change amounts of budget and funds by a given percentage. Additionally, we can configure how to round the amounts. Test plan: 1. Create a budget and several funds with different amounts 2. Duplicate it using the 2 new options 3. Check that the amounts are correct Signed-off-by: Frederic Demians It works exactly as advertised. Was happy to see that decimal point can be used: for example, increase a budget by 2.6%, and round the amound to 0.5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:13:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:13:11 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:13:30 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #17 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:13:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:13:55 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:14:26 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #9 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:14:39 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #9 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:14:57 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:15:13 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44290|0 |1 is obsolete| | --- Comment #42 from Eivin Giske Skaaren --- Created attachment 44300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44300&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:22:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:22:34 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:22:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:22:37 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44300|0 |1 is obsolete| | --- Comment #43 from Nicole C. Engard --- Created attachment 44301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44301&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:27:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:27:33 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #5 from Liz Rea --- The patch for 13628 is in 3.18.11, and would fix this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:28:03 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 --- Comment #6 from Liz Rea --- That is, this patch is in 3.18.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:44:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:44:04 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |nengard at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:50:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:50:42 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:50:56 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:52:05 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:53:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #216 from Robin Sheat --- (In reply to Julian Maurice from comment #214) > Required versions of dependencies are now in Debian Sid > > https://packages.debian.org/sid/libswagger2-perl > https://packages.debian.org/sid/libjson-validator-perl > > Now we need to re-package them for debian.koha-community.org (In reply to Julian Maurice from comment #215) > Created attachment 44285 [details] [review] > Bug 13799: Update dependencies Is it necessary to update those versions? Because the older versions are in the repo as it is. I haven't tried yet, but I suspect that JSON::Validator will be hard to port to wheezy, as it requires packaging a newer mojolicious, and I fear we'll end up in a bit of dependency hell. I'll give it a go though, maybe it'll be surprisingly easy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:54:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:54:52 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36511|0 |1 is obsolete| | Attachment #36512|0 |1 is obsolete| | Attachment #36513|0 |1 is obsolete| | Attachment #36818|0 |1 is obsolete| | --- Comment #19 from Bouzid --- Created attachment 44302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44302&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:55:16 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 --- Comment #6 from H?ctor Eduardo Castro Avalos --- (In reply to Kyle M Hall from comment #5) > Looks like the issue is related to deleteditems having the same itemnumber > is an item that is going to be deleted: > > http://screencast.com/t/jTd5b2DcB3A > > After clearing out duplicate itemnumber from deleteditems: > > http://screencast.com/t/PJxpEkf1DP How itemnumber is corrupted in the table? I mean it is a unique Id even though if you execute something like this UPDATE items SET itemnumber='1' WHERE itemnumber='2'; ERROR 1062 (23000): Duplicate entry '1' for key 'PRIMARY' MYSQL doesn't let to do this kind of operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:57:01 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44146|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 44303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44303&action=edit [SIGNED-OFF]Bug 15079 - Batch Delete Records Error When using the batch deletion tool, if the script attempts to delete an undeletable item, the script will die with the error: Label not found for "next BIBLIONUMBER" at /usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172. Test Plan: 1) Attempt to batch delete a record with an item that cannot be deleted 2) Note error 3) Apply this patch 4) Repeat step 1 5) Note the error no longer occurs Signed-off-by: Hector Castro Works as advertised. Follow comment 5 to reproduce the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 21:57:39 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 23:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 22:05:56 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Bouzid --- I redone all patch because it's necessary, I create one good patch work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 00:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2015 23:48:22 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off --- Comment #3 from H?ctor Eduardo Castro Avalos --- Marc you forgot to change bug status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:22:12 +0000 Subject: [Koha-bugs] [Bug 15112] New: Make greybox consistent size across label and patron card creator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Bug ID: 15112 Summary: Make greybox consistent size across label and patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org They should all be 400, 800. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:30:01 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:30:05 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 --- Comment #1 from Liz Rea --- Created attachment 44304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44304&action=edit bug 15112 - Make greybox consistent size across label/card creator Also fixes minor issue with buttons stacking on patroncards/edit-batch and labels/label-manage To test: Export a batch every way you can: multiple together from label/label-manage individual items from labels/label-edit-batch selected items from labels/label-edit-batch export full batch from labels/label-edit-batch multiple together from patroncards/manage individual cards from patroncards/manage individual cards from patroncards/edit-batch selected cards from patroncards/edit-batch export full batch from patroncards/edit-batch Also notice that before this patch, the delete and export buttons were stacking on the table rows, and that now they are not doing that anymore. It may take a force refresh to see the behaviour and the change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:46:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39166|0 |1 is obsolete| | Attachment #39168|0 |1 is obsolete| | Attachment #39827|0 |1 is obsolete| | Attachment #41181|0 |1 is obsolete| | Attachment #41193|0 |1 is obsolete| | Attachment #41686|0 |1 is obsolete| | Attachment #41687|0 |1 is obsolete| | Attachment #41706|0 |1 is obsolete| | Attachment #43017|0 |1 is obsolete| | Attachment #43183|0 |1 is obsolete| | Attachment #43576|0 |1 is obsolete| | --- Comment #130 from Liz Rea --- Created attachment 44305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44305&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:46:35 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #131 from Liz Rea --- Created attachment 44306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44306&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:46:57 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #132 from Liz Rea --- Created attachment 44307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44307&action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:47:14 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #133 from Liz Rea --- Created attachment 44308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44308&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:47:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:47:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #134 from Liz Rea --- Created attachment 44309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44309&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:47:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #135 from Liz Rea --- Created attachment 44310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44310&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:48:01 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #8 from M. Tompsett --- Comment on attachment 44295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44295 Bug 14946 - Remove C4::Dates from files acqui/*.pl Review of attachment 44295: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14946&attachment=44295) ----------------------------------------------------------------- You missed a point. I'm assuming that your lack of comment about "Post-fix if required because param('shipmentdate') could be a bad date?" is because this is true. ::: acqui/histsearch.pl @@ +95,4 @@ > } > ); > > +my ( $from_iso, $to_iso ); Nice improvement removing the $d. @@ +102,2 @@ > } > +if ( $input->param('to') ) { ... and yet this says 'to'. You didn't explain why the change, or correct it. @@ -102,2 @@ > } > -if ( $d = $input->param('iso') ) { This says 'iso'... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:48:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #136 from Liz Rea --- Created attachment 44311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44311&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 00:49:51 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #137 from Liz Rea --- I just squashed my followups to make this a bit tidier, where I could. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 01:05:17 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 01:05:21 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41219|0 |1 is obsolete| | --- Comment #14 from Liz Rea --- Created attachment 44312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44312&action=edit Bug13287 - Add a system preference to define the number of days used in purge_suggestions.pl The system preferences value is used whenever purge_suggestions.pl is called without the 'days' parameter. This patch uses the preference description suggested by comment #9. This version should now be cleanly applicable. I Apply the patch II Run updatedatabase.pl a) Run purge_suggestions.pl without the days parameter - validate that there is an error message b) Run purge_suggestions.pl with the days parameter - validate that there is no error message c) Insert a number of days in the system variable PurgeSuggestionsOlderThan d) Run purge_suggestions.pl without the days parameter - validate that there is no error message Signed-off-by: Liz Rea Tested per plan, all tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:49:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 01:49:48 +0000 Subject: [Koha-bugs] [Bug 15113] New: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Bug ID: 15113 Summary: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 01:49:55 +0000 Subject: [Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 04:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 03:54:31 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #217 from Robin Sheat --- Created attachment 44313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44313&action=edit Dependency tree for Swagger2 0.60 (In reply to Julian Maurice from comment #214) > Required versions of dependencies are now in Debian Sid > > https://packages.debian.org/sid/libswagger2-perl > https://packages.debian.org/sid/libjson-validator-perl > > Now we need to re-package them for debian.koha-community.org I had a look, and I don't think it's going to happen. Attached is the dependency tree that I worked out I'd need to build. The red edge is where the process becomes difficult, and I'm not going to backport a new Perl version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:10:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 04:10:11 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #218 from Robin Sheat --- (In reply to Robin Sheat from comment #217) > I had a look, and I don't think it's going to happen. Attached is the > dependency tree that I worked out I'd need to build. The red edge is where > the process becomes difficult, and I'm not going to backport a new Perl > version. Actually, it's possible I spoke too soon. But it's still going to be a bit of work, so in the interests of laziness, how important are these new versions? There's still no guarantee that it'll work overall, but I may have found a way around the perl version issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 06:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 05:46:48 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 06:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 05:46:50 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42755|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 44314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44314&action=edit Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Fr?d?ric Demians The issue is there, and this patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:26:41 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:26:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:26:44 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44266|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44315&action=edit Bug 15095: marc_modificacation_template_actions DB not consistent between fresh and updated DB A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. To test: 1) have a v3.20.00 DB: > CREATE DATABASE koha_master_upgraded; $ git checkout v3.20.00 $ mysql koha_master_upgraded < installer/data/mysql/kohastructure.sql 2) upgrade it to latest master by running: $ git checkout origin/master $ perl installer/data/mysql/updatedatabase.pl 3) Create a new DB > CREATE DATABASE koha_master_fresh; $ mysql koha_master_fresh < installer/data/mysql/kohastructure.sql 4) Run mysqldbcompare (you need mysql-utilities installed for that) $ mysqldbcompare --difftype=differ --server1=root at localhost \ --skip-data-check --skip-table-options \ --run-all-tests koha_master_upgraded:koha_master_fresh => FAIL: You will notice the marc_modification_template_actions discrepancy - Repeat from 1), but apply this patch on 2) before the upgrade. => SUCCESS: The DB's discrepancies are now irrelevant [1] - Sign off :-D [1] Only KEY definition order is 'wrong', but it is not relevant. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:49:14 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians --- Wouldn't it be better to avoid allowing entering invalid values in the first place? Using 'multiple' syspref would allow that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:52:02 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15019 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:52:02 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15061 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 [Bug 15061] Can't add item to rotating collection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:52:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:52:49 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #5 from Fr?d?ric Demians --- Created attachment 44316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44316&action=edit Bug 12721 Prevent entering invalid values in StatisticsFields Using 'multiple' type for StatisticsFields syspref avoid having invalid values in, and so prevent a bug in statistics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 07:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 06:54:54 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #6 from Fr?d?ric Demians --- Marc, feel free to sign my counter patch and obsolete yours if it make sense for you, or if it doesn't, obsolete my patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 07:01:04 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 08:41:25 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #7 from Marc V?ron --- Fr?d?ric, Thanks for the counter patch. I considered your solution as well, but it would restrict the fields on location,itype and ccode only. But the description says: Show the following fields from the items database table as columns on the statistics tab on the patron record (...) I understand this as 'any' colums, not only location,itype and ccode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 08:59:12 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:04:25 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #8 from Fr?d?ric Demians --- > But the description says: > Show the following fields from the items database table as columns on the > statistics tab on the patron record (...) > > I understand this as 'any' colums, not only location,itype and ccode Sorry, you're correct! My patch would be a severe regression for libraries using other fields from 'items' table. What prevents me from signing your patch is that I don't like the idea of checking the existence of items field (by calling DESCRIBE items) each time the statistics fields are required. Have you explored the possibility using the column setting tool? Here: /cgi-bin/koha/admin/columns_settings.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:04:50 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 44317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44317&action=edit Bug 15108 - OAI-PMH provider improvements - Fixed date handling to use UTC as specs require. - Added support for deleted records. - Added support for second precision in time stamps. - Added support for marc21 metadata prefix as recommended in the guidelines (synonym for marcxml). - ListIdentifiers and ListRecords always return records in biblionumber order. - Improved performance of database queries especially for large collections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:05:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:05:05 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 44318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44318&action=edit Bug 15108 - OAI-PMH provider improvements. AtomicUpdate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:05:49 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43193|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud --- Created attachment 44319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44319&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:05:56 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44091|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud --- Created attachment 44320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44320&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:07:22 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Olli-Antti Kivilahti --- (In reply to Fr?d?ric Demians from comment #3) > > We got somebody from the national library to take a look at the > > OAI-PMH-implementation of Koha, and the Bugzilla entries didn't help a lot > > in deciphering what features have been implemented since 3.16. > > 11 > > I will provide the commit as soon as I receive the improved version of this > > patch. > > Please work on the top of bug 14939. Signing it would even been better. > Having a modularized OAI server will help a lot in term of maintainability. I agree. Modularity is awesome. Having complete test coverage is even better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:07:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:07:37 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Olli-Antti Kivilahti --- Failing QA because of missing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:08:07 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Status|Needs Signoff |Failed QA --- Comment #3 from Olli-Antti Kivilahti --- Failing QA because of insufficient testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:10:13 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #12 from Alex Arnaud --- Nicole, I have added the test plan to the commit message of the first commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:12:34 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #9 from Marc V?ron --- Thanks again M.Tompsett for reviewing the code. Sorry for any missing comments from my part. I comment in below. Could you already test the functionality? (In reply to M. Tompsett from comment #8) > Comment on attachment 44295 [details] [review] > Bug 14946 - Remove C4::Dates from files acqui/*.pl > > Review of attachment 44295 [details] [review]: > ----------------------------------------------------------------- > > You missed a point. I'm assuming that your lack of comment about "Post-fix > if required because param('shipmentdate') could be a bad date?" is because > this is true. MV: Yes. > > ::: acqui/histsearch.pl > @@ +95,4 @@ > > } > > ); > > > > +my ( $from_iso, $to_iso ); > > Nice improvement removing the $d. MV: Thanks. BTW my aim is to remove C4:Dates for finally have our official date format dd.mm.yyyy (it is really important) - and not to make the code more elegant. In my very long journey through Koha files I saw a lot of places where such improvements could be done :-) > > @@ +102,2 @@ > > } > > +if ( $input->param('to') ) { > > ... and yet this says 'to'. You didn't explain why the change, or correct it. > > @@ -102,2 @@ > > } > > -if ( $d = $input->param('iso') ) { > > This says 'iso'... MV: It's a fix - there is no incoming param 'iso'. We have a param 'from' and a param 'to' resulting in $from_iso and $to_iso. I tested several times to make sure that my change does not break the behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:16:32 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 44321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44321&action=edit Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:31:25 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #8 from Fr?d?ric Demians --- > I agree. Modularity is awesome. > Having complete test coverage is even better. Now, there isn't any test at all now. So modularizing is a first step. If you want tests, add them. And don't forget UT for you own patch which modify a lot of OAI server code without guaranty it won't something somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:34:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:34:24 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #9 from Olli-Antti Kivilahti --- (In reply to Fr?d?ric Demians from comment #8) > > I agree. Modularity is awesome. > > Having complete test coverage is even better. > > Now, there isn't any test at all now. So modularizing is a first step. If > you want tests, add them. And don't forget UT for you own patch which modify > a lot of OAI server code without guaranty it won't something somewhere. Just sharing the code here in hopes of it being helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:40:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:40:16 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #10 from Olli-Antti Kivilahti --- And you should make tests before you refactor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:44:10 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #9 from Marc V?ron --- Fr?d?ric, Thanks for the hint about the column setting tool. BTW: This bug has no high for me at the moment. I'd rather like to see the C4::Dates removal finished to finally have the dd.mm.yyyy date format. There are 8 patches left to sign-off at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:57:46 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #11 from Fr?d?ric Demians --- (In reply to Olli-Antti Kivilahti from comment #10) > And you should make tests before you refactor. You're welcome. It's modularizing not refactoring. The existing classes are split from oai.pl into individual .pm files, one per class. It doesn't change a line of code. So coding a full UT for OAI server would be awesome, I can't disagree, but it isn't a requirement for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 09:59:12 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Fr?d?ric Demians --- (In reply to Olli-Antti Kivilahti from comment #3) > Failing QA because of insufficient testing. I disagree. It's modularizing not refactoring. The existing classes are split from oai.pl into individual .pm files, one per class. It doesn't change a line of code. So coding a full UT for OAI server would be awesome, I can't disagree, but it isn't a requirement for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 10:32:43 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #219 from Julian Maurice --- (In reply to Robin Sheat from comment #218) > Actually, it's possible I spoke too soon. But it's still going to be a bit > of work, so in the interests of laziness, how important are these new > versions? The newer version of Swagger2 module is useful to be able to split the swagger.json specification file into multiple pieces (so we don't have a single huge unreadable file) I don't know if there are others benefits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:43:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 10:43:38 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #220 from Martin Renvoize --- We jumped on the Swagger2 Plugin way too early basically. I've been developing an app based around it for a few months now... and have been working closely with the plugin author to write tests, fix issues and make it stable.. it's only just hitting the point where it's a stable and reliable platform for us to work atop so I wouldn't suggest using earlier versions. (Unless we wan't to fork it and maintain that fork.. which I think is a terrible idea). For further info, I wouldn't even consider using Mojolicious in a package environment if we could avoid it.. I've voiced this before though ;). Mojolicious is a state of the art library that's pretty fast moving. I use it in our companies apps, but we're running in a Carton + Plenv environment and I wouldn't really advocate running a Mojo stack under much else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 10:49:59 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41192|0 |1 is obsolete| | --- Comment #138 from Marc V?ron --- Comment on attachment 41192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41192 Stray text appears above header This is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:55:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 10:55:11 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 10:55:14 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44062|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 44322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44322&action=edit Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:04:43 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44305|0 |1 is obsolete| | --- Comment #139 from Marc V?ron --- Created attachment 44323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44323&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron New sign-off after testing all patches together Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:06:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:06:42 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44306|0 |1 is obsolete| | --- Comment #140 from Marc V?ron --- Created attachment 44324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44324&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:07:44 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44307|0 |1 is obsolete| | --- Comment #141 from Marc V?ron --- Created attachment 44325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44325&action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:08:43 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44308|0 |1 is obsolete| | --- Comment #142 from Marc V?ron --- Created attachment 44326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44326&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:09:45 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44309|0 |1 is obsolete| | --- Comment #143 from Marc V?ron --- Created attachment 44327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44327&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:18:11 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:18:13 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #10 from Fr?d?ric Demians --- Created attachment 44328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44328&action=edit Bug 14673 Work around change to AddIssue return Return from AddIssue used to be due date or undef. Now it is less straightforward returning am issue object if an issue row is created or undef. If the issue is a renewal undef is returned. As that case was not handled properly it caused the server site to crash the listener causing a communications error on the client. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:21:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:21:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44310|0 |1 is obsolete| | --- Comment #144 from Marc V?ron --- Created attachment 44329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44329&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message Problems with Math/Random/Secure.pm, is solved in following patch, signing off Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:22:41 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44311|0 |1 is obsolete| | --- Comment #145 from Marc V?ron --- Created attachment 44330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44330&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:23:17 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:54:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 11:54:52 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40720|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 44331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44331&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 12:29:59 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 12:30:02 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41307|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 44332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44332&action=edit Bug 14632 - Fix alert message for single item batch Fixes the incorrect msg "Please select at least label to delete." for attempts to delete from single patron batches. Notifies the user that doing so will delete the batch. It disallows direct deletion, instead suggests the users to use the 'Delete batch' option assuming the users know what they are doing. Test plan ========= 1/ Load a single patron batch in edit mode and attempt to delete the single record. The JS alert message will inform that "Please select at least label to delete." 2/ Apply patch and refresh page and try to delete the single record again. 3/ This time the alert will inform the user that doing so will delete the batch and should that be desired action to choose the 'Delete batch' option from the toolbar. Signed-off-by: Frederic Demians It works as before but with an understantable warning message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 12:46:40 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #221 from Olli-Antti Kivilahti --- Being able to split the swagger.json to many files is really important. The single file will become too big too soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 12:50:45 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #222 from Tom?s Cohen Arazi --- (In reply to Olli-Antti Kivilahti from comment #221) > Being able to split the swagger.json to many files is really important. > The single file will become too big too soon. Yeah, but we can leave that for the next release; at that point we won't have the compromise to suport Wheezy or Trusty at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 13:45:37 +0000 Subject: [Koha-bugs] [Bug 15114] New: warning on purchase suggestions is inaccurate Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Bug ID: 15114 Summary: warning on purchase suggestions is inaccurate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 44333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44333&action=edit error When on the purchase suggestions page in the OPAC if there are no suggestions you get a warning "You are not authorized to see pending purchase suggestions." But once you add a suggestion that goes away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 13:49:27 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 13:49:29 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44319|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard --- Created attachment 44334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44334&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 13:49:38 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44320|0 |1 is obsolete| | --- Comment #14 from Nicole C. Engard --- Created attachment 44335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44335&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 13:50:39 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #15 from Nicole C. Engard --- This is neat, it's not super powerful, but I see how one day it could be. I'll note in the documentation that it only works if the title and the name are exact - so if I enter author Barbara Kingsolver it doesn't find her, but if I put in Kingsolver, Barbara it does. Still a good feature that doesn't break anything that I can see :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:24:21 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 44336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44336&action=edit Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:27:03 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:27:34 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:50:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:50:20 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44336|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 44337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44337&action=edit Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:51:00 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 15:59:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #223 from Julian Maurice --- (In reply to Tom?s Cohen Arazi from comment #222) > (In reply to Olli-Antti Kivilahti from comment #221) > > Being able to split the swagger.json to many files is really important. > > The single file will become too big too soon. > > Yeah, but we can leave that for the next release; at that point we won't > have the compromise to suport Wheezy or Trusty at all. So, what should we do ? Moving the patches that need more recent versions of Perl modules into their own bug and push remaining patches into master now (so they go in 3.22) ? Or wait for 3.22 to be released and then push the whole bug's patches for 3.24 ? Backporting Perl to oldstable doesn't seem to be the way to go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:35:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 16:35:26 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #2 from Alex Arnaud --- This patch is quite not esay to test because lot of things remain "db dependent". Jonathan, i did the following (tell me if i'm wrong): - I get the database content provided in bug 10337 (to satisfy all db dependent things), - i created a branchcode 'FOO' on my database and change all borrowers branchcodes with this one, - i deleted all other branches - launch tests on all changed files and get errors on t/db_dependent/Members.t and t/db_dependent/Serials_2.t t/db_dependent/Members.t: Failed test 'Member Changed' (Mismatching member details) t/db_dependent/Serials_2.t: A mysql error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 16:51:05 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes hidden in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Hi Katrin, I do not know how to reproduce the issue. What I did: - Mark a item type as hidden in Opac - This item type no longer appears in Opac on advanced search, as advertised near "Hide in Opac": "(if checked, items of this type will be hidden as filters in OPAC's advanced search)" - Go to Opac. Do a search. - Item Types appear at teh left in facets. They all have their names ( Books, E-Book ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 16:57:56 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 16:58:08 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 16:58:21 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 17:01:48 +0000 Subject: [Koha-bugs] [Bug 15057] Exporting Default Framework results in empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15057 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- I can't produce this bug on my box: default framework export works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 17:02:21 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes hidden in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- For me the problem is not when hideinopac is set, but when the item type is assigned to a search group (talking about Item types in facets) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 17:15:42 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:28:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 17:28:18 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 --- Comment #3 from Tom?s Cohen Arazi --- This one is in conflict with bug 15081, that aims to let the test files handle the transactions on their own. I think the transaction should be started/rolled back when the test writer considers it needs to. An example: if we want each subtest to rollback when it finish, DBIx::Class will complain about nested transactions. And if it doesn't rollback explicitly there would be side effects between tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 18:23:40 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 44338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44338&action=edit Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 18:24:44 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 18:25:44 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Bernardo Gonzalez Kriegel --- Added followup to display search categories description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 18:26:57 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:24:46 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #3 from Marc V?ron --- Created attachment 44340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44340&action=edit Bug 15091: Batch Checkout: Set titles above result tables This patch is to clarify the results that are displayed while performing a batch checkout. It is not the full solution for what is described in the video in comment #2, but it tells the user what the information in the table is about. A second patch is planned to address the case where the issues are confirmed but not can be fulfilled because the user's fines reach the threshold while checking out the items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:45:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:45:14 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 --- Comment #1 from Kyle M Hall --- Created attachment 44341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44341&action=edit Bug 12544 - Send scheduled reports as an attachment This patch adds the ability to add the report as an attached file to the sent email. Test Plan: 1) Email yourself a test report 2) Apply this patch 3) Repeat step 1, note there is no difference 4) Add the -a parameter, note your also recieve the report as an attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:45:11 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:46:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:46:29 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44341|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 44342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44342&action=edit Bug 12544 - Send scheduled reports as an attachment This patch adds the ability to add the report as an attached file to the sent email. Test Plan: 1) Email yourself a test report 2) Apply this patch 3) Repeat step 1, note there is no difference 4) Add the -a parameter, note your also recieve the report as an attachment Sponsored-by: Briar Cliff University Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:46:35 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 19:59:14 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Itemtype description |Itemtype description |missing from facets for |missing from facets for |itypes hidden in OPAC |itypes in a search group --- Comment #3 from Katrin Fischer --- I think Bernardo is right - I had testd those 2 new features and probably named the wrong cause. Changing bug title - thx for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 20:54:58 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #4 from Marc V?ron --- Created attachment 44343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44343&action=edit Bug 15091: Batch Checkout: Tell the user what happens while checking out This patch slightly changes the behaviour of Batch checkout. - If an item is successfully checked out, it is marked as such in column "Information" - If checkouts are confirmed and an item can not be checked out because e.g. the user reaches the fines threshold, an information is displayed in column "Information" To test: - Watch video from comment #2 - Apply both patches - Set sysprefs to allow override while checking out - Prepare a batch with invalid barcodes, with valid barcodes and with enough items that the user will reach the threshold while checking out all items - Verify that a title appears above the tables while performing the batch checkout - The first table "Batch checkout confirmation" should show - Items that could be checked out - Items that are not checked out (e.g. invalid barcode) - Items that need confirmation (e.g. debt) - After confirmation, more items should be checked out (as long the threshold is not reached - Items above the threshold will have a message "The patron has a debt..." Maybe a more sophisticated solution could be possible, but this patch should address the main concerns from comment #2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 20:55:45 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:56:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 20:56:05 +0000 Subject: [Koha-bugs] [Bug 15115] New: Editing item information on active course reserves should not be allowed. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15115 Bug ID: 15115 Summary: Editing item information on active course reserves should not be allowed. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When an item is put on active reserve in course reserves, the item's data is copied into a row in the course_items table. Taking the item off active reserve swaps the data in course_items and items. This means that editing item level data will have unexpected consequences. Item level data should be ghosted when items are on active reserve. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:05:45 +0000 Subject: [Koha-bugs] [Bug 15116] New: show circ buttons at the top of batch circ page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Bug ID: 15116 Summary: show circ buttons at the top of batch circ page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 15091 The new batch circulation page should have the usual buttons at the top. From those the librarian can print the receipt for the checkouts and perform other functions. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 [Bug 15091] Batch Checkout Doesn't Tell You it Failed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:05:45 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15116 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 [Bug 15116] show circ buttons at the top of batch circ page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:06:17 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15091 |11759 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 [Bug 15091] Batch Checkout Doesn't Tell You it Failed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:06:17 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15116 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 [Bug 15116] show circ buttons at the top of batch circ page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:06:17 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15116 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 [Bug 15116] show circ buttons at the top of batch circ page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:11:44 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44343|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 44344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44344&action=edit Bug 15091: Batch Checkout: Tell the user what happens while checking out This patch slightly changes the behaviour of Batch checkout. - If an item is successfully checked out, it is marked as such in column "Information" - If checkouts are confirmed and an item can not be checked out because e.g. the user reaches the fines threshold, an information is displayed in column "Information" To test: - Watch video from comment #2 - Apply both patches - Set sysprefs to allow override while checking out - Prepare a batch with invalid barcodes, with valid barcodes and with enough items that the user will reach the threshold while checking out all items - Verify that a title appears above the tables while performing the batch checkout - The first table "Batch checkout confirmation" should show - Items that could be checked out - Items that are not checked out (e.g. invalid barcode) - Items that need confirmation (e.g. debt) - After confirmation, more items should be checked out (as long the threshold is not reached - Items above the threshold will have a message "The patron has a debt..." Maybe a more sophisticated solution could be possible, but this patch should address the main concerns from comment #2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:18:42 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:18:44 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44340|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 44345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44345&action=edit Bug 15091: Batch Checkout: Set titles above result tables This patch is to clarify the results that are displayed while performing a batch checkout. It is not the full solution for what is described in the video in comment #2, but it tells the user what the information in the table is about. A second patch is planned to address the case where the issues are confirmed but not can be fulfilled because the user's fines reach the threshold while checking out the items. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:18:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:18:48 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44344|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 44346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44346&action=edit Bug 15091: Batch Checkout: Tell the user what happens while checking out This patch slightly changes the behaviour of Batch checkout. - If an item is successfully checked out, it is marked as such in column "Information" - If checkouts are confirmed and an item can not be checked out because e.g. the user reaches the fines threshold, an information is displayed in column "Information" To test: - Watch video from comment #2 - Apply both patches - Set sysprefs to allow override while checking out - Prepare a batch with invalid barcodes, with valid barcodes and with enough items that the user will reach the threshold while checking out all items - Verify that a title appears above the tables while performing the batch checkout - The first table "Batch checkout confirmation" should show - Items that could be checked out - Items that are not checked out (e.g. invalid barcode) - Items that need confirmation (e.g. debt) - After confirmation, more items should be checked out (as long the threshold is not reached - Items above the threshold will have a message "The patron has a debt..." Maybe a more sophisticated solution could be possible, but this patch should address the main concerns from comment #2 Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:21:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:21:16 +0000 Subject: [Koha-bugs] [Bug 15117] New: There is no translation of confirm dialog when transfering a basket Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Bug ID: 15117 Summary: There is no translation of confirm dialog when transfering a basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: genevieve.plantin at inlibro.com QA Contact: testopia at bugs.koha-community.org The popup confirm dialog that shows "Do you want to transfer order [% ordernumber %] from basket [% basketfromname %] ([% booksellerfromname %]) to basket [% basket.basketname %] ([% booksellertoname %]) ?" in the transferorder.tt file is not translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:23:53 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Genevieve Plantin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |genevieve.plantin at inlibro.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:24:26 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Genevieve Plantin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |genevieve.plantin at inlibro.c | |om, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:58:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:58:17 +0000 Subject: [Koha-bugs] [Bug 15088] Note in koha-remove help that --keep-mysql is how you remove instances with remote databases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:58:20 +0000 Subject: [Koha-bugs] [Bug 15088] Note in koha-remove help that --keep-mysql is how you remove instances with remote databases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #2 from Liz Rea --- Created attachment 44347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44347&action=edit Bug 15088 - notice when koha has been installed with --request-db instead of --create-db Patch does 2 major things - * creates an options file during koha-create that lets us know what database option was used when the instance was created /etc/koha/sites/$name/createoptions * when an instance is removed, we assume we can do things to the database, per usual. If we have a createoptions, we'll read it and find out if our instance was created with create-db or request-db. If it was requested, we don't do anything with the database because we assume we don't have rights to, and print a message. If it was created, we do the same thing we've always done - remove the database and users (unless we've specified --keep-mysql) To test: create a throwaway instance with --create-db remove that instance, all should happen as normal. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=0 in it. create another throwaway instance with --request-db remove that instance, you should see a message alerting you to the fact that you may still have database work to do after Koha is removed. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=1 in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 21:59:01 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Note in koha-remove help |Notice when koha has been |that --keep-mysql is how |installed with --request-db |you remove instances with |instead of --create-db |remote databases | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 22:00:27 +0000 Subject: [Koha-bugs] [Bug 15118] New: Accidental Branch transfer on hold is not handled gracefully. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15118 Bug ID: 15118 Summary: Accidental Branch transfer on hold is not handled gracefully. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If an item is accidentally transferred to another branch after it fills a hold, the item will be checked in as 'local use' at the second branch, but will show as being held at the original branch. To reproduce: Place a hold for item X at branch ABC Check item X in at branch ABC, thereby filling the hold. Check the item in at branch DEF. This will produce a message like Hold found: ... Hold for ... Hold at ABC This will also give the following check in message: Check in message Not checked out Local use recorded Viewing the item's status will now show that the item's location is DEF, but the item is waiting for pickup at ABC. The expectation is that a branch transfer should have been created to send the item back to ABC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:38:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 22:38:59 +0000 Subject: [Koha-bugs] [Bug 15119] New: Hide search header text boxes on render Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Bug ID: 15119 Summary: Hide search header text boxes on render Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The whole multiple textboxes in the search header showing while the page is rendering is getting old. Could someone please set all forms except for the first form in the search header to hidden initially, rather than waiting for the page to load before hiding them? That would be wonderful! Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 22:48:05 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 --- Comment #4 from Marc V?ron --- Following findings: opac/opac-search.pl line 213 calls GetItemTypesCategorized and then resolves the codes to the descriptions But C4/Koha.pm, GetItemTypesCategorized, line 303 has: SELECT itemtype, description, imageurl, hideinopac, 0 as 'iscat' FROM itemtypes WHERE ISNULL(searchcategory) or length(searchcategory) = 0 (...) If I remove the WHERE clause, the label appears in the facet as expected (Books isntead of BK in my test case). I think this is the place for some more digging. Where is GetItemTypesCategorized used, is it possible to remove the where clause without side effects (No, I'm afraid), do we need a variant without where clause for the facets? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:08:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 23:08:04 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Marc V?ron from comment #4) > > If I remove the WHERE clause, the label appears in the facet as expected > (Books isntead of BK in my test case). > > I think this is the place for some more digging. Where is > GetItemTypesCategorized used, is it possible to remove the where clause > without side effects (No, I'm afraid), do we need a variant without where > clause for the facets? I'm afraid not.GetItemTypesCategorized is used to get item types and search groups. But as you said, we need to dig a little more :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:32:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 23:32:38 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |katrin.fischer at bsz-bw.de Component|Acquisitions |I18N/L10N Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:46:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 23:46:54 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2015 23:46:57 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44337|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 44348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44348&action=edit [PASSED QA] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 00:08:38 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Would it be possible to unit test this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 00:17:56 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 00:17:59 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44322|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 44350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44350&action=edit [PASSED QA] Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:25:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 00:25:45 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Can we please get unit tests and a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 00:31:25 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- This removes the empty entry and the test plan for this works. But under which conditions would the entry show up again? Since the sort categories can be different for each fund I wonder if this can work. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 02:16:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 01:16:51 +0000 Subject: [Koha-bugs] [Bug 15120] New: runreport.pl doesn't allow custom subjects anymore Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Bug ID: 15120 Summary: runreport.pl doesn't allow custom subjects anymore Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz There's an option for it in the docs, but it doesn't work (and the code isn't there for it anyway). We should fix it or remove the option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 02:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 01:17:36 +0000 Subject: [Koha-bugs] [Bug 15121] New: runreport.pl cronjob ought to let you specify multiple addresses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Bug ID: 15121 Summary: runreport.pl cronjob ought to let you specify multiple addresses Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Just in case more than one person needs to receive a copy of a report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:54:20 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:54:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:54:23 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 --- Comment #1 from Liz Rea --- Created attachment 44351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44351&action=edit Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore To test, well do something like misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you at youraddress.com 1 where 1 is the number of your favourite saved report. Success is your email arrives with the subject "My fancy subject!" Failure is (with --subject defined) you get either the description of the report, or "Koha saved report" as the subject. This is success without --subject defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:57:04 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15108 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:57:04 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14939 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:57:55 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 02:57:55 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14939 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 04:35:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 03:35:09 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #3 from Liz Rea --- (I had a bit of a change of heart on how to handle this, after consulting with the most excellent Robin.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 06:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 05:16:00 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43356|0 |1 is obsolete| | --- Comment #13 from H?ctor Eduardo Castro Avalos --- Created attachment 44352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44352&action=edit [SIGNED-OFF]Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 06:16:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 05:16:14 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43408|0 |1 is obsolete| | --- Comment #14 from H?ctor Eduardo Castro Avalos --- Created attachment 44353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44353&action=edit [SIGNED-OFF]Bug 14956 - (follow) Validate incoming birth date This patch validates the birthdate and resets it to empty if date is not valid. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 06:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 05:19:50 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from H?ctor Eduardo Castro Avalos --- After long, long test, finally signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 07:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 06:25:34 +0000 Subject: [Koha-bugs] [Bug 15122] New: Allow styling the Items available for loan -list in OPAC search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15122 Bug ID: 15122 Summary: Allow styling the Items available for loan -list in OPAC search results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org When you search the OPAC, the search results lists the "Items available for loan", with a list of all the branches where that particular item is available. The branches in that list cannot be styled separately at all. The list should have span class with the branch short name, and the count of items in that branch should also have a class or a tag to allow styling that separately from the branch name, for example: Items available for loan: Centerville(1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 08:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 07:02:16 +0000 Subject: [Koha-bugs] [Bug 14919] Reserves history for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:37:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 09:37:49 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 --- Comment #1 from Marc V?ron --- Created attachment 44354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44354&action=edit Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 09:38:14 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 09:43:08 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43072|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 44355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44355&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:44:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 09:44:36 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #6 from Fr?d?ric Demians --- Redefining naming in order not to overlap with bug 10662. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 10:03:12 +0000 Subject: [Koha-bugs] [Bug 15123] New: Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 Bug ID: 15123 Summary: Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 44356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44356&action=edit Wrong translation of "Transferred" in basket In German, the word "Transfer" can be translated to "Transfer" or "Transport". Transfer would be used e.g. for transferring an order, transport is for transportation of e.g. books. This ambiguity leads to a wrong translation for transferred orders in Home > Acquisitions > [a vendor ] > [a basket] e.g. /cgi-bin/koha/acqui/basket.pl?basketno=14 See screenshot attached. The reason is that the word "Basket" is detached from the string "Transferred to" by the tag. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 10:11:00 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 10:11:49 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 --- Comment #1 from Marc V?ron --- Created attachment 44357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44357&action=edit Bug 15123: Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation This patch moves the word "basket" out of the tags to have a better context for translation. To test: - Transfer an order from one basket to another basket - Verify that "basket" is detached from the strings "Transferred to" rsp "Transferred from" by th tag (See screenshot) - Apply patch - Verify that the word "basket" is now otuside the tags -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 10:12:08 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 10:44:25 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #10 from Joonas Kylm?l? --- Do we need this patch? The funds are in sorted order even without this patch in acqui/acqui-home.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:02:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 11:02:00 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 11:02:03 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42765|0 |1 is obsolete| | --- Comment #17 from Joonas Kylm?l? --- Created attachment 44358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44358&action=edit Bug 14805: Replace generic 'items' with the specific ones Signed-off-by: Joonas Kylm?l? Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:03:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 11:03:39 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 --- Comment #18 from Joonas Kylm?l? --- (In reply to Tom?s Cohen Arazi from comment #16) > Please rebase against master, urgently :-D Done! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:25 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:28 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41579|0 |1 is obsolete| | Attachment #41580|0 |1 is obsolete| | Attachment #41581|0 |1 is obsolete| | Attachment #41582|0 |1 is obsolete| | Attachment #41583|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 44359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44359&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:45 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #48 from Kyle M Hall --- Created attachment 44360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44360&action=edit [SIGNED-OFF] Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:49 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #49 from Kyle M Hall --- Created attachment 44361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44361&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:52 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #50 from Kyle M Hall --- Created attachment 44362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44362&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:35:56 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #51 from Kyle M Hall --- Created attachment 44363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44363&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:38:28 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 44364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44364&action=edit Bug 15098: Itemtype description missing from facets for itypes in a search group This patch adds a second variable to hold item types info just for facets. In case we have an item type in a search category, it's description is removed from GetItemTypesCategorized, which is good for advanced search, but no for facets A second var is needed which holds all item type info. To test: On top of Bug 15092 patches (no really needed, but I write this on top of them) 1) Add an item type to a search group 2) Do a search in opac, in facets will see only item type code, no description, for that item type 3) Apply the patch 4) Repeat search, now description must be present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:39:08 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:39:23 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Depends on| |15092 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 [Bug 15092] item type descriptions not showing if no logo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:39:23 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15098 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 [Bug 15098] Itemtype description missing from facets for itypes in a search group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:39:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:39:27 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44304|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44365&action=edit bug 15112 - Make greybox consistent size across label/card creator Also fixes minor issue with buttons stacking on patroncards/edit-batch and labels/label-manage To test: Export a batch every way you can: multiple together from label/label-manage individual items from labels/label-edit-batch selected items from labels/label-edit-batch export full batch from labels/label-edit-batch multiple together from patroncards/manage individual cards from patroncards/manage individual cards from patroncards/edit-batch selected cards from patroncards/edit-batch export full batch from patroncards/edit-batch Also notice that before this patch, the delete and export buttons were stacking on the table rows, and that now they are not doing that anymore. It may take a force refresh to see the behaviour and the change. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:40:07 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:47:46 +0000 Subject: [Koha-bugs] [Bug 15124] New: Allow SIP2 passwordless operation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 Bug ID: 15124 Summary: Allow SIP2 passwordless operation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some SIP self check machines allow the use of a "passwordless" mode where the patron does not need to enter a pin or password to use the SC. Koha cannot handle this situation. Koha will assume an empty password field is an invalid password unless the patron's password is NULL in the database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:47:51 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:57:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:57:53 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44338|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 44366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44366&action=edit Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:58:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:58:28 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 44367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44367&action=edit Bug 14723 - Additional delivery notes to messages - fixed missing kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 12:59:33 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Marc V?ron --- Signed-off on second patch: Bug 15092: (followup) Descriptions not show for search categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:08:38 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44364|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 44368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44368&action=edit Bug 15098: Itemtype description missing from facets for itypes in a search group This patch adds a second variable to hold item types info just for facets. In case we have an item type in a search category, it's description is removed from GetItemTypesCategorized, which is good for advanced search, but no for facets A second var is needed which holds all item type info. To test: On top of Bug 15092 patches (no really needed, but I write this on top of them) 1) Add an item type to a search group 2) Do a search in opac, in facets will see only item type code, no description, for that item type 3) Apply the patch 4) Repeat search, now description must be present Followed test plan including translated descriptions. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:09:03 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:14:10 +0000 Subject: [Koha-bugs] [Bug 15125] New: Fix link to Kohacon 10 videos Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15125 Bug ID: 15125 Summary: Fix link to Kohacon 10 videos Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org The website[1] links to blip.tv for Kohacon 10 videos, but that site does not work. There has been a discussion on the mailing list before[2]. There is a working link at archive.org[3] which should be used instead. [1] http://koha-community.org/kohacon10-videos/ [2] http://koha.katipo.co.narkive.com/V4iZenr2/kohacon10-videos-unavailable [3] https://archive.org/details/KohaCon10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:43:35 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:56:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:56:52 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14955 Depends on|14955 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 [Bug 14955] "Show more" link contains double encoded characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:56:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 13:56:52 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15059 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15059 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 [Bug 15059] Line break in html attribute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:00:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:00:39 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 --- Comment #1 from Kyle M Hall --- Created attachment 44369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44369&action=edit Bug 15124 - Tidy relevent code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:00:45 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 --- Comment #2 from Kyle M Hall --- Created attachment 44370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44370&action=edit Bug 15124 - Allow SIP2 passwordless operation Some SIP self check machines allow the use of a "passwordless" mode where the patron does not need to enter a pin or password to use the SC. Koha cannot handle this situation. Koha will assume an empty password field is an invalid password unless the patron's password is NULL in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:01:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:01:46 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:02:08 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:02:15 +0000 Subject: [Koha-bugs] [Bug 15126] New:=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Bug ID: 15126 Summary: REST?API: Use newer version of Swagger2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13799 As asked by Tom?s on IRC, I will remove patches of bug 13799 that requires a newer version (> 0.31) of Swagger2 module, and put them here. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:02:15 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15126 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:03:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:03:40 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44355|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 44371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44371&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:04:48 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #1 from Julian Maurice --- Created attachment 44372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44372&action=edit Bug 15126: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:04:54 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #3 from Julian Maurice --- Created attachment 44374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44374&action=edit Bug 15126: Update dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:04:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:04:51 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #2 from Julian Maurice --- Created attachment 44373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44373&action=edit Bug 15126: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:06:29 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:06:52 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43989|0 |1 is obsolete| | --- Comment #224 from Julian Maurice --- Created attachment 44375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44375&action=edit Bug 13799: RESTful API with Mojolicious and Swagger2 Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:07:08 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #216 from Tom?s Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:07:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:07:14 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43990|0 |1 is obsolete| | --- Comment #225 from Julian Maurice --- Created attachment 44376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44376&action=edit Bug 13799: Add cookie-based authentication to REST API Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:10:48 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43991|0 |1 is obsolete| | --- Comment #226 from Julian Maurice --- Created attachment 44377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44377&action=edit Bug 13799: Add missing license notices Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:11:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:11:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43992|0 |1 is obsolete| | --- Comment #227 from Julian Maurice --- Created attachment 44378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44378&action=edit Bug 13799: Fix API unit tests Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:12:02 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43993|0 |1 is obsolete| | --- Comment #228 from Julian Maurice --- Created attachment 44379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44379&action=edit Bug 13799: (QA followup) make tests use random data Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:12:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43994|0 |1 is obsolete| | --- Comment #229 from Julian Maurice --- Created attachment 44380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44380&action=edit Bug 13799: Change Mojolicious default mode to 'production' Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:12:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43995|0 |1 is obsolete| | --- Comment #230 from Julian Maurice --- Created attachment 44381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44381&action=edit Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:13:06 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43996|0 |1 is obsolete| | --- Comment #231 from Julian Maurice --- Created attachment 44382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44382&action=edit Bug 13799: Change 'required' value type from string to boolean Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:13:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:13:28 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43997|0 |1 is obsolete| | --- Comment #232 from Julian Maurice --- Created attachment 44383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44383&action=edit Bug 13799: Reword 'borrower' to 'patron' Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:13:54 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44185|0 |1 is obsolete| | --- Comment #233 from Julian Maurice --- Created attachment 44384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44384&action=edit Bug 13799: Rename t/.../v1/borrowers.t to t/.../v1/patrons.t Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:14:17 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #234 from Julian Maurice --- Created attachment 44385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44385&action=edit Bug 13799: Add types for patron's fields in Swagger spec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:15:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:15:14 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43998|0 |1 is obsolete| | --- Comment #235 from Julian Maurice --- Comment on attachment 43998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43998 [PASSED QA] Bug 13799 - Followup: x-mojo-controller deprecation Patch moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:15:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43999|0 |1 is obsolete| | --- Comment #236 from Julian Maurice --- Comment on attachment 43999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43999 [PASSED QA] Bug 13799 - Followup: Refactor spec file Patch moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:15:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:15:24 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44000|0 |1 is obsolete| | --- Comment #237 from Julian Maurice --- Comment on attachment 44000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44000 [PASSED QA] Bug 13799: Followup of "Followup: Refactor spec file" Patch moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:15:29 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44001|0 |1 is obsolete| | --- Comment #238 from Julian Maurice --- Comment on attachment 44001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44001 [PASSED QA] Bug 13799: Followup of "Followup: x-mojo-controller deprecation" Patch moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:15:35 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44285|0 |1 is obsolete| | --- Comment #239 from Julian Maurice --- Comment on attachment 44285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44285 Bug 13799: Update dependencies Patch moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:16:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:16:45 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #4 from Julian Maurice --- Created attachment 44386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44386&action=edit Dependency tree for Swagger2 0.60 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:17:09 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44313|0 |1 is obsolete| | --- Comment #240 from Julian Maurice --- Comment on attachment 44313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44313 Dependency tree for Swagger2 0.60 Moved to bug 15126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:18:36 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #241 from Julian Maurice --- Re-tested with Swagger2 0.31, Mojolicious 0.54. Tests pass, all is working well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:19:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:19:24 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #242 from Julian Maurice --- I meant: Mojolicious 5.54 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:20:33 +0000 Subject: [Koha-bugs] [Bug 15127] New: (Plack on packages) plack.psgi should check for changed files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 Bug ID: 15127 Summary: (Plack on packages) plack.psgi should check for changed files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The shipped file should be checking for updated files for reloading them automatically. This is documented on the Wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:20:39 +0000 Subject: [Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:21:19 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:24:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:24:53 +0000 Subject: [Koha-bugs] [Bug 15128] New: Add ability to limit the number of open purchase suggestions a patron can make Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Bug ID: 15128 Summary: Add ability to limit the number of open purchase suggestions a patron can make Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries are finding that some patrons have a tendency to "spam" the purchase suggestions with dozens of requests at a time. It would be nice if we could limit the number of purchase suggestions a patron can place that are neither Accepted or Rejected. Idea: 1) Add new system preference "MaxOpenSuggestions" 2) Modify opac-suggestions.pl to count the number of suggesions the patron has that are not Accepted or Rejected 3) If that count has reached the number specified in MaxOpenSuggestions, deny the ability to place another suggestion with the message: "You have reached your limit of suggestions you can place at this time. Once the library has processed those suggestions you will be able to place more" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:25:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:25:00 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:27:03 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:27:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:27:16 +0000 Subject: [Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:28:59 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #256 from Tom?s Cohen Arazi --- I'm sorry, could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:30:07 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:30:47 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #27 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:31:18 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Joonas and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:31:47 +0000 Subject: [Koha-bugs] [Bug 8438] Allow staff only to only claim serial issues of their own branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #46 from Tom?s Cohen Arazi --- Patch pushed to master. Nice one Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:34:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:34:49 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:34:52 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44284|0 |1 is obsolete| | Attachment #44286|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 44387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44387&action=edit [PASSED QA] Bug 15081: Take transaction handling out from TestBuilder This patch removes transaction handling code from TestBuilder. It fixes the TestBuilder.t to handle the transaction on its own. Verify that t/db_dependent/TestBuilder.t passes. Followed test plan, TestBuilder.t passes Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:35:02 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #7 from Kyle M Hall --- Created attachment 44388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44388&action=edit [PASSED QA] Bug 15081: (followup) Make test files using TestBuilder handle their transactions This trivial patch introduces the code needed on the test files so they handle the DB transaction instead of relying on the (removed) transaction started/rolled back by TestBuilder. Tested all of the files before and after applying the patch, resultes are the same. (Pass exept of t/db_dependent/Barcodes_ValueBuilder.t, this has the same error). Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:35:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:35:04 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #8 from Kyle M Hall --- Created attachment 44389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44389&action=edit Bug 15081 [QA Followup] - Fix issue with Barcodes_ValueBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:55:18 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #10 from Koha Team Lyon 3 --- Katrin, I haven't test as explained by Jonathan but I have a similar problem : You perform a search with several pages of results. You go on the second page, click on "show more" the URL contains space characters (I don't really know what sort of characters..) and if you click you don't have any result. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:58:00 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #14 from Josef Moravec --- I have this setup: First day of week monday Date format dd/mm/rrrr When I try to add a range holiday from 01/01/2015 to 10/01/2015 and I end with this days set close: 01/01/2015 02/01/2015 03/01/2015 04/01/2015 05/01/2015 06/01/2015 07/01/2015 08/01/2015 09/01/2015 10/01/2015 01/11/2015 02/11/2015 03/11/2015 04/11/2015 24/12/2015 25/12/2015 26/12/2015 27/12/2015 28/12/2015 29/12/2015 30/12/2015 31/12/2015 The dates for exceptions are formatted in ISO, not in right date format (see attachment) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 14:58:36 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #15 from Josef Moravec --- Created attachment 44390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44390&action=edit Exception dates formatted in ISO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:07:08 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 --- Without the patch : I have added a new baskest with 2 orders, closed this basket, received one of the order. Orders status for this basket are "complete" and "ordered". I have re-opened the basket : ordered status are both "new". With the patch : I redone exactly the same stages, but afer reopening the basket, ordered status are "complete" and "ordered". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:12:19 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #142 from Kyle M Hall --- Created attachment 44391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44391&action=edit Bug 11431 [QA Followup] - Make audio alerts sql top level Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:14:37 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 --- Comment #4 from Katrin Fischer --- Koha Team Lyon3 - is this a 'sign off'? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:11 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43887|0 |1 is obsolete| | Attachment #43888|0 |1 is obsolete| | Attachment #43889|0 |1 is obsolete| | Attachment #43890|0 |1 is obsolete| | Attachment #43891|0 |1 is obsolete| | Attachment #43892|0 |1 is obsolete| | Attachment #43893|0 |1 is obsolete| | Attachment #43894|0 |1 is obsolete| | Attachment #43895|0 |1 is obsolete| | Attachment #43896|0 |1 is obsolete| | Attachment #43897|0 |1 is obsolete| | Attachment #43898|0 |1 is obsolete| | Attachment #43899|0 |1 is obsolete| | Attachment #43900|0 |1 is obsolete| | Attachment #43901|0 |1 is obsolete| | Attachment #43902|0 |1 is obsolete| | Attachment #43903|0 |1 is obsolete| | Attachment #44391|0 |1 is obsolete| | --- Comment #143 from Kyle M Hall --- Created attachment 44392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44392&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:22 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #144 from Kyle M Hall --- Created attachment 44393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44393&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:26 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #145 from Kyle M Hall --- Created attachment 44394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44394&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:33 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #146 from Kyle M Hall --- Created attachment 44395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:38 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #147 from Kyle M Hall --- Created attachment 44396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44396&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:44 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #148 from Kyle M Hall --- Created attachment 44397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44397&action=edit Bug 11431 [QA Followup] - Fix POD Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:50 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #149 from Kyle M Hall --- Created attachment 44398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44398&action=edit Bug 11431 - Update UsageStats.pm Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:15:56 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #150 from Kyle M Hall --- Created attachment 44399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44399&action=edit Bug 11431 [QA Followup] - Fix js error Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:02 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #151 from Kyle M Hall --- Created attachment 44400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44400&action=edit Bug 11431 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:08 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #152 from Kyle M Hall --- Created attachment 44401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44401&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:13 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #153 from Kyle M Hall --- Created attachment 44402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44402&action=edit Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:14 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #16 from Marc V?ron --- Created attachment 44403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44403&action=edit Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:20 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #154 from Kyle M Hall --- Created attachment 44404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44404&action=edit Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #155 from Kyle M Hall --- Created attachment 44405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44405&action=edit Bug 11431 [QA Followup] - Fix alter precedences on delete Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:30 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44321|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 44406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44406&action=edit Bug 14616 - Introducing Koha::Object subclasses. Fixed Biblioitems result source naming typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:30 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #156 from Kyle M Hall --- Created attachment 44407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44407&action=edit Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:43 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #158 from Kyle M Hall --- Created attachment 44409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44409&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:36 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #157 from Kyle M Hall --- Created attachment 44408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44408&action=edit Bug 11431 [QA Followup] - Update help Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:48 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #21 from Olli-Antti Kivilahti --- Created attachment 44410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44410&action=edit Bug 14536 - PageObject squashable - Waitingreserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:49 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #159 from Kyle M Hall --- Created attachment 44411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44411&action=edit Bug 11431: QA follow-up: Typo in help file / variable name Fixes the variable name to avoid a double-up that made it impossible to turn off the sounds in general. If AudioAlerts are turned off, they will only work on the audio administration page now so you can set up and test the different sounds there. Also fixes a little typo in the help file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:16:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:16:55 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #160 from Kyle M Hall --- Created attachment 44412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44412&action=edit Bug 11431 [QA Followup] - Make audio alerts sql top level Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:17:06 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44367|0 |1 is obsolete| | --- Comment #20 from Olli-Antti Kivilahti --- Created attachment 44413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44413&action=edit Bug 14723 - Additional delivery notes to messages - fixed missing kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:17:21 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 44414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44414&action=edit Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report Hold(s) over -report at circ/waitingreserves.pl doesn't work because ExpireReservesMaxPickup removes reserves from the koha.reserves-table to the koha.old_reserves-table. This patch adds a new column koha.reserves.pickupexpired telling when/if the reserve has got it's pickup duration expired. This date is used to pull old reserves to the waitingreserves-view. syspref 'PickupExpiredHoldsOverReportDuration' controls how many days after expiration old reserves are displayed on the report, and the values respect Koha::Calendar holidays Web tests included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:17:57 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ExpireReservesMaxPickUpDela |ExpireReservesMaxPickUpDela |y has minor workflow |y works with hold(s) over |conflicts with hold(s) over |report |report | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:18:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:18:14 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:19:36 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:19:36 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:20:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:20:10 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:20:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:20:10 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13995 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:20:35 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 --- Comment #5 from Koha Team Lyon 3 --- Yes, this is signed off but I tried to sign it with a sandbox 15 mn ago and nothing happens so far... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:23:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:23:35 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43316|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 44415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44415&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up Signed-off-by: Frederic Demians Code OK. Tested updatedatabase.pl with an old DB backup: OK. fix_accountlines_date.pl still working after the patch. Could be removed from master IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:23:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:23:33 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:26:53 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:26:55 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44315|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44416&action=edit [PASSED QA] Bug 15095: marc_modificacation_template_actions DB not consistent between fresh and updated DB A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. To test: 1) have a v3.20.00 DB: > CREATE DATABASE koha_master_upgraded; $ git checkout v3.20.00 $ mysql koha_master_upgraded < installer/data/mysql/kohastructure.sql 2) upgrade it to latest master by running: $ git checkout origin/master $ perl installer/data/mysql/updatedatabase.pl 3) Create a new DB > CREATE DATABASE koha_master_fresh; $ mysql koha_master_fresh < installer/data/mysql/kohastructure.sql 4) Run mysqldbcompare (you need mysql-utilities installed for that) $ mysqldbcompare --difftype=differ --server1=root at localhost \ --skip-data-check --skip-table-options \ --run-all-tests koha_master_upgraded:koha_master_fresh => FAIL: You will notice the marc_modification_template_actions discrepancy - Repeat from 1), but apply this patch on 2) before the upgrade. => SUCCESS: The DB's discrepancies are now irrelevant [1] - Sign off :-D [1] Only KEY definition order is 'wrong', but it is not relevant. Signed-off-by: Frederic Demians Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:31:19 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer --- I will switch the status - we can add the line in QA if it doesn't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:34:41 +0000 Subject: [Koha-bugs] [Bug 15129] New: Koha::object for issuing rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Bug ID: 15129 Summary: Koha::object for issuing rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We should add a new Koha::Object(s) for issuing rule because it makes the code hopefully in the future more usable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:37:34 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #11 from Koha Team Lyon 3 --- I try Jonathan's patch. I confirm that it solves the problem described on the "show more" link (bad characters in the URL). But for me, the problem occurs only from the second page of results and it's not related to the fact of having a facet already selected. The problem exists whatever you have already selected a facet or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:39:45 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:39:48 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44154|0 |1 is obsolete| | --- Comment #10 from Fr?d?ric Demians --- Created attachment 44417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44417&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 http://bugs.koha-community.org/show_bug.cgi?id=14965 Signed-off-by: Frederic Demians Code OK. The 4 reports works for me as before (same results). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:45:06 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 --- Comment #1 from Joonas Kylm?l? --- Created attachment 44418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44418&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:48:12 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:55:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:55:39 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks for the followup, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:56:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:56:14 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #161 from Tom?s Cohen Arazi --- Patches pushed to master. Great job Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:57:02 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:57:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 15:57:28 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #66 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:05:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:05:27 +0000 Subject: [Koha-bugs] [Bug 15130] New: useless unitialization warnings when updating authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Bug ID: 15130 Summary: useless unitialization warnings when updating authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org When importing records (in the present case through the french Sudoc program) the following warning displays when updating linked biblios is not necessary : Use of uninitialized value $update in numeric eq (==) at /home/kohaadmin/src/C4/AuthoritiesMarc.pm line 1554. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:14 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42857|0 |1 is obsolete| | Attachment #42858|0 |1 is obsolete| | Attachment #42859|0 |1 is obsolete| | Attachment #42860|0 |1 is obsolete| | Attachment #42861|0 |1 is obsolete| | Attachment #42862|0 |1 is obsolete| | Attachment #42863|0 |1 is obsolete| | Attachment #42864|0 |1 is obsolete| | Attachment #42865|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall --- Created attachment 44419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44419&action=edit Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal This patch adds the ability for a logged in user to pay fines and fees from the OPAC via PayPal. Test Plan: 1) Apply this patch 2) Create a paypal developer account 3) Create two test accounts, a Personal account and a Business account 4) Enable PayPal in Sandbox mode via the system preferences. 5) Enter the business account API credentials into the new system preferences. 6) Create a new patron, add some fines/fees 7) Log in as that patron in the OPAC 8) Choose to pay via PayPal, log in as the sandbox Personal account 9) Complete the transaction 10) Note the fee is now paid Signed-off-by: Carol Corrales Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:22 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #52 from Kyle M Hall --- Created attachment 44420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44420&action=edit Bug 11622 [QA Followup] Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:26 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #53 from Kyle M Hall --- Created attachment 44421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44421&action=edit Bug 11622 [QA Followup] - Show amount to be paid near make payment button Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:31 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #54 from Kyle M Hall --- Created attachment 44422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44422&action=edit Bug 11622 [QA Followup] - Display payment messages directly on opac account view Fixed spelling of "Receive" in preferences. Signed-off-by: David Kuhn Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:38 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #56 from Kyle M Hall --- Created attachment 44424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44424&action=edit Bug 11622 [QA Followup] - Use Koha's active currency for PayPal Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:34 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #55 from Kyle M Hall --- Created attachment 44423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44423&action=edit Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:43 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #57 from Kyle M Hall --- Created attachment 44425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44425&action=edit Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:48 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #58 from Kyle M Hall --- Created attachment 44426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44426&action=edit Bug 11622 [QA Followup] - Fix currency issue, add error template Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:06:52 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #59 from Kyle M Hall --- Created attachment 44427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44427&action=edit Bug 11622 [QA Follouwp] - Display payment block only if there is something to pay Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:11:44 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 44428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44428&action=edit Bug 15130 useless unitialization warnings when updating authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:11:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:11:56 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:14:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:14:28 +0000 Subject: [Koha-bugs] [Bug 15131] New: Give SCO separate control for AllowItemsOnHoldCheckout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Bug ID: 15131 Summary: Give SCO separate control for AllowItemsOnHoldCheckout Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries would like the ability to allow items on hold to be checked out to other patrons ( due to parents/kids with permission who pick up someone else's holds and other situations ) but not via the SCO module where librarians cannot verify the checkout should be allowed. Idea: 1) Create new system preference AllowItemsOnHoldCheckoutSCO that will default to the current value of AllowItemsOnHoldCheckout 2) For the Koha SCO module, update all references to AllowItemsOnHoldCheckout to AllowItemsOnHoldCheckoutSCO 3) Add a notice to patrons attempting to check out items that are waiting for another patron when the checkout is denied -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:14:37 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:19:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:19:54 +0000 Subject: [Koha-bugs] [Bug 15132] New: Add a search type pulldown to the staff catalog search like the public catalog has Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15132 Bug ID: 15132 Summary: Add a search type pulldown to the staff catalog search like the public catalog has Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Many librarians would like to see the staff quick catalog search have a pulldown of search types similar to what the OPAC has. We should add new system preference IntranetCatalogSearchPulldown to control the feature which if enabled, would include search_indexes.inc to left of catalog search text box. We could also forgo the system preference and instead give the search box a class or id so it would be hidden easily with css. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:20:02 +0000 Subject: [Koha-bugs] [Bug 15132] Add a search type pulldown to the staff catalog search like the public catalog has In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15132 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:21:09 +0000 Subject: [Koha-bugs] [Bug 15132] Add a search type pulldown to the staff catalog search like the public catalog has In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15132 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14902 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:21:09 +0000 Subject: [Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- *** Bug 15132 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:33:59 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:34:02 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43800|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 44429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44429&action=edit Bug 15014: Returns 0 if everything went fine Be kind and return 0 if the sample file has been generated correctly. Otherwise you are a bad guy and you make Plack returns an internal error (exited nonzero: 1 at /home/vagrant/kohaclone/tools/import_borrowers.pl line 390.) Signed-off-by: Josef Moravec Works as expected Signed-off-by: Tomas Cohen Arazi Works as expected here too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:43:35 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:52:08 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #243 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks everyone, specially Julian and Martin! Things will get interesting for sure :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:57:01 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:58:51 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:58:56 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39817|0 |1 is obsolete| | Attachment #39818|0 |1 is obsolete| | Attachment #39819|0 |1 is obsolete| | Attachment #39820|0 |1 is obsolete| | Attachment #39821|0 |1 is obsolete| | Attachment #39822|0 |1 is obsolete| | Attachment #39823|0 |1 is obsolete| | --- Comment #257 from Kyle M Hall --- Created attachment 44430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44430&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #258 from Kyle M Hall --- Created attachment 44431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44431&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:14 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #259 from Kyle M Hall --- Created attachment 44432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44432&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:26 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #261 from Kyle M Hall --- Created attachment 44434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44434&action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:20 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #260 from Kyle M Hall --- Created attachment 44433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44433&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #262 from Kyle M Hall --- Created attachment 44435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44435&action=edit Bug 9303 [QA Followup] - Restore ability for patron to control setting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 16:59:37 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #263 from Kyle M Hall --- Created attachment 44436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44436&action=edit Bug 9303 [QA Followup] - Restore missing svc script Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 17:26:16 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 19:18:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 18:18:45 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 44437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44437&action=edit Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 19:19:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 18:19:45 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|3.18 |master CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 19:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 18:20:19 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 19:42:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 18:42:21 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #23 from Tom Misilo --- Is there any chance of this getting into the next version? Just curious as this would be very beneficial with automating our weeding procedures base on being missing for a set time period. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 20:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 19:55:49 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44371|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 44438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44438&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 21:05:47 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 21:33:02 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:39:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 21:39:32 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hm, I am surprised by this as we have libraries operating self checks without a pin/password entry from the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 21:57:41 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #60 from Robin Sheat --- (In reply to Kyle M Hall from comment #1) > Created attachment 24753 [details] [review] > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal > > This patch adds the ability for a logged in user to pay fines and > fees from the OPAC via PayPal. Kyle, if you're adding a dependency, you need to read this: http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_Guidelines or the email equivalent that went out in May: http://lists.koha-community.org/pipermail/koha-devel/2015-May/041464.html This won't be able to go into master until I package URL::Encode and Debian allows it to be added, which may (or may not) take some time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:09:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:09:48 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #4 from Marc V?ron --- Hmm, signed-off but no signed-off patch attached? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:26:49 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Marc - my fault - got distracted half way through the sign-off - I will send a patch up in a minute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:29:06 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43285|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher --- Created attachment 44439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44439&action=edit Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:37:57 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 44440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44440&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply ( 04.11.2015 / mv :-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:46:36 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #24 from Katrin Fischer --- Hi Tom, this patch has missed the feature slush, which means it was not 'passed QA' by a certain date. It won't be included in 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:57:41 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43182|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 44441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44441&action=edit Bug 14969 - Remove C4::Dates from serials/*.pl files Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions Amended to make it apply ( serials/checkexpiration.pl ) 04.11.2015 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 22:59:55 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Marc V?ron --- As of today depending on: Need Sign-off: 14954 14946 14960 14969 Signed-off 14985 14965 14998 14956 I switch to "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:01:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 23:01:05 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #61 from Robin Sheat --- Would URI::Escape work, which is already a Koha dependency? https://metacpan.org/pod/URI::Escape -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 23:18:20 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2015 23:18:23 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41098|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 44442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44442&action=edit Bug 14532: Add --exclude-indexes switch to koha-dump This patch changes the default behaviour of koha-dump to make the inclusion of Zebra indexes on the dump optional. It does so by introducing a new option switch that allows to have the previous behaviour in place. To test: - Run $ koha-dump your_instance - Save a copy of the dump files - Apply the patch / extract the koha-dump script - Run the new one: $ koha-dump your_instance => SUCCESS: Verify the contents of the dump are the same (i.e. it includes /var/lib/koha/your_instance) - Run with the new switch: $ koha-dump --exclude-indexes your_instance => SUCCESS: The dump does not contain stuff from /var/lib/koha/your_instance - Go through the rest of the new option switches -h | --help -q | --quiet => SUCCESS: They work as expected. - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:11:16 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:11:18 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 --- Comment #2 from cnorthcott.work at gmail.com --- Created attachment 44443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44443&action=edit Bug 15103: Import Borrowers Performance Improvement Improves the performance of importing borrowers in batches from file by by switching out resultset calls for more direct SQL queries and using hash lookups instead of repeated DB lookups. Test Plan: 1) Prepare NTYprof (http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf) or procure a stopwatch (stopwatch will be simpler but less accurate). 2) Download the PatronDataCSV1.csv and PatronDataCSV2.csv attachements from the bug page or organise your own csv's with data for 1000 or more patrons to import. 3) Navigate to Home > Tools > Import Patrons in the Koha Intranet (http://demo-intra.mykoha.co.nz/cgi-bin/koha/tools/import_borrowers.pl) 4) Click the "Browse..." button and select PatronDataCSV1.csv or your equilient. 5) If you are using a stopwatch, prepare your stopwatch so that you will start counting seconds from the point you click the button in the next step. 6) Scroll to the bottom of the page and click the "Import" button (simultaneously start your stopwatch if using one) 7) When the page appears showing completion of the import, stop your stopwatch and check the time or navigate to the folder you have set NYTProf to output. 8) Record the runtime. This is the pre-optimisation time. 9) Apply this patch. 9) Repeat steps 2-7 of this testplan with the patch applied and use the PatronDataCSV2.csv this time around. This will yield the post-optimisation time. 10) Compare the pre-optimisation time and post optimisation time. The second post-optimisation time should be faster. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:15:31 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 --- Comment #3 from cnorthcott.work at gmail.com --- Created attachment 44444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44444&action=edit CSV file containing patron data for import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:15:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:15:48 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 --- Comment #4 from cnorthcott.work at gmail.com --- Created attachment 44445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44445&action=edit CSV file containing patron data for import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:30:42 +0000 Subject: [Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:30:44 +0000 Subject: [Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 --- Comment #2 from cnorthcott.work at gmail.com --- Created attachment 44446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44446&action=edit Bug 15104: Batch Record Modification Performance Improvement Performance improvements to speed of the Modify Records by decreasing unnecessary progress reporting of success messages and data fetching while logging. Test Plan: 1) Prepare NTYprof (http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf) or procure a stopwatch (stopwatch will be simpler but less accurate). 2) Ensure you have a decent number of records in your Koha system (>500) if you are lacking records to modify in your database you can import some from files found here: http://wiki.koha-community.org/wiki/Free_sample_MARC_data 3) Prepare a file with biblionumbers to modify. You can create a file containing all record called ItemBarcodes.txt in the current folder using the following command from the machine running Koha: echo 'select biblionumber from biblio' | sudo koha-mysql kohadev >> BiblioNums.txt 4) Navigate to Home > Tools > MARC modification templates in the Koha Intranet. 5) Create a new template called ModRec1. 6) Add a new action using: Select 'Add/Update' from the drop down box and in the field(s) boxes enter '090' (in the first box) and 'a' (in the second box) and 'Mod1' in the value field. Then click 'Add Action' 7) Create a new template called ModRec2. 8) Add a new action using: Select 'Add/Update' from the drop down box and in the field(s) boxes enter '090' (in the first box) and 'a' (in the second box) and 'Mod2' in the value field. Then click 'Add Action' 9) Navigate to Home > Tools > Batch Modify Records in the Koha Intranet 10) Click the 'Browse...' button and select BiblioNums.txt or your equilient. 11) Select ModRec1 under Use MARC Modification Template. 12) Click the 'Continue' button and scroll to the bottom of the page. 13) If you are using a stopwatch, prepare your stopwatch so that you will start counting seconds from the point you click the button in the next step. 14) Click the 'Modify Selected Records' button (simultaneously start your stopwatch if using one) 15) When the page appears showing completion of the change, stop your stopwatch and check the time or navigate to the folder you have set NYTProf to output. 16) Record the runtime. This is the pre-optimisation time. 17) If this is the pre-patch test then you should see lots of messages like: "The biblio #### has successfully been modified." If this is the post-patch test then you should see only: "All records have successfully been modified!" and a link to do another record modification. 18) Apply this patch. 19) Repeat steps 9-12 of this testplan with the patch applied, replacing ModRec1 in step 11 with ModRec2. This will yield the post-optimisation time. If you are using NYTProf you will need to apply the -d:NYTProf shebang to the file again. 20) Compare the pre-optimisation time and post optimisation time. The second post-optimisation time should be faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:36:22 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:36:24 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #1 from cnorthcott.work at gmail.com --- Created attachment 44447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44447&action=edit Bug 15107: Batch Patron Deletion (Trash) Performance Improvement Batch Patron Modification has a fairly long run/load time. I have attempted to improve the runtime of the Batch Patron Modification tool by switching out more expensive resultset calls for faster more direct SQL queries. Test Plan: 1) Prepare NTYprof (http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf) or procure a stopwatch (stopwatch will be simpler but less accurate). 2) Ensure you have a decent number of patrons in your Koha system (>500) if you are lacking patrons to modify in your database you can import 1000 using the PatronDataCSV.csv attachement and the Import Patrons tool before moving to step 3. 4) Navigate to Home > Tools > Batch Patrons Deletion in the Koha Intranet 5) Check the box beside the "Verify you want to delete patrons" box 6) Under "who have not borrowed since" enter todays date 7) You should get a message saying: "1000 patrons will be deleted 0 checkout history will be anonymized" If not please go back to step 2 and import patrons using the PatronDataCSV.csv 8) Select the radio button option beside "Move these patrons to the trash" 9) If you are using a stopwatch, prepare your stopwatch so that you will start counting seconds from the point you click the button in the next step. 10) Click the "Finsh" button (simultaneously start your stopwatch if using one) 11) When the page appears showing completion of the change, stop your stopwatch and check the time or navigate to the folder you have set NYTProf to output. 12) Record the runtime. This is the pre-optimisation time. 13) Apply this patch. 14) Repeat steps 2-12 of this testplan with the patch applied. This will yield the post-optimisation time. 15) Compare the pre-optimisation time and post optimisation time. The second post-optimisation time should be faster. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 02:37:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 01:37:19 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #2 from cnorthcott.work at gmail.com --- Created attachment 44448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44448&action=edit Patron data to import for testing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 03:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 02:42:20 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44357|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44449&action=edit [SIGNED-OFF]Bug 15123: Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation This patch moves the word "basket" out of the tags to have a better context for translation. To test: - Transfer an order from one basket to another basket - Verify that "basket" is detached from the strings "Transferred to" rsp "Transferred from" by th tag (See screenshot) - Apply patch - Verify that the word "basket" is now otuside the tags Signed-off-by: Hector Castro Works as advertised. Tested with es-ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 03:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 02:43:06 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:31:32 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44437|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44450&action=edit Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:32:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:32:03 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:41:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:41:27 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41004|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44451&action=edit Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians Plugin still working, with a valid pop-pup window id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:42:04 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:51:32 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:51:35 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44428|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44452&action=edit Bug 15130 useless unitialization warnings when updating authorities Signed-off-by: Frederic Demians Fixes a trivial coding error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:51:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:51:36 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:54:25 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:54:28 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44366|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 44453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44453&action=edit [PASSED QA] Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:55:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:55:20 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #11 from Katrin Fischer --- This is better, but still one small glitch - if you have no OPAC description set, it should fall back to the staff description like we usually do. But maybe this should go on a separate bug, so this can go in as is as fixing the bigger problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:59:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:59:42 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 06:59:45 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44110|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 44454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44454&action=edit [PASSED QA] Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:00:45 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #13 from Katrin Fischer --- I still have a bit of a problem reproducing the issue, but I can verify the change in the URL now and things seem to work like they should. Also trusting the other testers here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:03:38 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:03:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:03:41 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44368|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 44455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44455&action=edit [PASSED QA] Bug 15098: Itemtype description missing from facets for itypes in a search group This patch adds a second variable to hold item types info just for facets. In case we have an item type in a search category, it's description is removed from GetItemTypesCategorized, which is good for advanced search, but no for facets A second var is needed which holds all item type info. To test: On top of Bug 15092 patches (no really needed, but I write this on top of them) 1) Add an item type to a search group 2) Do a search in opac, in facets will see only item type code, no description, for that item type 3) Apply the patch 4) Repeat search, now description must be present Followed test plan including translated descriptions. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:05:01 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:05:04 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44449|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44456&action=edit [PASSED QA] Bug 15123: Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation This patch moves the word "basket" out of the tags to have a better context for translation. To test: - Transfer an order from one basket to another basket - Verify that "basket" is detached from the strings "Transferred to" rsp "Transferred from" by th tag (See screenshot) - Apply patch - Verify that the word "basket" is now otuside the tags Signed-off-by: Hector Castro Works as advertised. Tested with es-ES Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:06:56 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:06:59 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44450|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44457&action=edit [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:08:07 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- This is a small change in behaviour, but as we have no preference for "UsesOverdueNotices" it's a quick fix. The tab can still be hidden with jQuery. It would be nice to have a follow up adding an id to the element, to make it even easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:08:47 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 --- Comment #5 from Katrin Fischer --- Hm, I see it also checkes for "sentnotices". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:12:52 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hm, wondering - why not remove the semicolon from the search term as we do in other places? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:16:36 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:16:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:16:39 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44158|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44458&action=edit [PASSED QA] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel No more ModeCurrencies, no call to acqui/currency.pl No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:20:19 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Testing with "All libraries" selected. Test 1: ------- - In dropdown box select a patron category that not yet has a rule e.g. Teacher (T) - Fill in some fields - Click "Save" Result: New row with values for this category, values saved OK Test 2: ------ - Click on "Edit" for a I want to change (at the right) - Fill in and/or change some fields - Save Result for editing category from Test 1: DBIx::Class::Row::update_or_insert(): Duplicate entry '*-T-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 Same error with other categories, e.g. for Juvenile (J) DBIx::Class::Row::update_or_insert(): Duplicate entry '*-J-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 Same error while editing "All" DBIx::Class::Row::update_or_insert(): Duplicate entry '*-*-*' for key 'PRIMARY' at /usr/share/kohaclone/Koha/Object.pm line 109 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:24:03 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:24:06 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44002|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 44459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44459&action=edit [PASSED QA] Bug 14781 - Creation of barcode types 2of5 not functional This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. To test: - Create a label layout with COOP2of5 barcode type - Create labels (make sure that the items's barcode values are numeric only!) - Export batch and download PDF. Without patch: - No barcodes rendered With patch - Barcodes should render as expected. Test for both barcode types. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, tested both formats. Non digit barcode is not printed. No koha-qa errors, no t/ & xt/ errors Signed-off-by: Katrin Fischer Note: To be printed, barcode should be numerical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:27:47 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:30:36 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:30:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:30:39 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44365|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44460&action=edit [PASSED QA] bug 15112 - Make greybox consistent size across label/card creator Also fixes minor issue with buttons stacking on patroncards/edit-batch and labels/label-manage To test: Export a batch every way you can: multiple together from label/label-manage individual items from labels/label-edit-batch selected items from labels/label-edit-batch export full batch from labels/label-edit-batch multiple together from patroncards/manage individual cards from patroncards/manage individual cards from patroncards/edit-batch selected cards from patroncards/edit-batch export full batch from patroncards/edit-batch Also notice that before this patch, the delete and export buttons were stacking on the table rows, and that now they are not doing that anymore. It may take a force refresh to see the behaviour and the change. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:33:41 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:53:32 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:53:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:53:35 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44351|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44461&action=edit Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore To test, well do something like misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you at youraddress.com 1 where 1 is the number of your favourite saved report. Success is your email arrives with the subject "My fancy subject!" Failure is (with --subject defined) you get either the description of the report, or "Koha saved report" as the subject. This is success without --subject defined. Signed-off-by: Frederic Demians Bug repeatable and fixed by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:56:08 +0000 Subject: [Koha-bugs] [Bug 15133] New: runreport.pl badly encode accented characters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Bug ID: 15133 Summary: runreport.pl badly encode accented characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz /misc/cronjobs/runreport.pl send badly encoded email in text/csv (ok in HTML): both subject & message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:56:31 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15120 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 [Bug 15120] runreport.pl doesn't allow custom subjects anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:56:31 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15133 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 [Bug 15133] runreport.pl badly encode accented characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:59:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:59:18 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 07:59:20 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 --- Comment #1 from Fr?d?ric Demians --- Created attachment 44462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44462&action=edit Bug 15133: encode correctly email generated by runreport.pl /misc/cronjobs/runreport.pl send badly encoded email in text/csv (partially ok in HTML). TEST: 1. Send by email a report containing a subject with accented characters and resultset with accented characters. For example: ./runreport.pl --subject="???" --to=me at home.org 1 ./runreport.pl --format=html --subject="???" --to=me at home.org 1 The first email contains badly encoded subject & message. The second email contains badly encoded subject, but correct message. 2. Apply the patch 3. Repeat 1 => No more strange characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 08:18:21 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43318|0 |1 is obsolete| | --- Comment #37 from Marc V?ron --- Created attachment 44463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44463&action=edit Bug 12072 - Add system preference for New dateformat dd.mm.yyyy (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 08:22:02 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #38 from Marc V?ron --- Addition to test plan: Run DateUtils.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:54:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 08:54:51 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ablewicz at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 09:19:59 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #16 from Olli-Antti Kivilahti --- Hi! I just implemented Bug 10744. This created special holidays for Koha::Calendar to use with the test cases. Oh boy how much fun it would be to be able to remove special holidays calling an internal module instead of writing direct SQL-code in the test script. I wonder where could we find one patch which would introduce such an internal API call? You guys have so many years of Koha development under your hood, I am sure you both know what is best for Koha, and won't fail to keep developing Koha, just as it was developed 10 years ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 09:27:47 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44414|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 44464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44464&action=edit Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 09:48:23 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- I don't think the second patch is the right way to fix this problem. It seems that the complete tool should be blocked if the patron is not able to check out. I will try to provide a counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:57:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 09:57:14 +0000 Subject: [Koha-bugs] [Bug 15134] New: How to install Restful web services for KOHA Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15134 Bug ID: 15134 Summary: How to install Restful web services for KOHA Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: fridayjune at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, I am newbie to KOHA and Linux. I have tried to install Restful webservices for KOHA using the following link: https://github.com/biblibre/koha-restful But, I am not able to run prove t/rest. Can please someone help me to show how to install it. Thanks, June -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 09:58:07 +0000 Subject: [Koha-bugs] [Bug 15134] How to install Restful web services for KOHA In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15134 --- Comment #1 from june --- Sorry, though I know this site is for bugs reporting. I don't know where to ask regarding of KOHA restful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:01:22 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13049 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 [Bug 13049] Merge selfreg cron jobs into cleanup_database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:01:22 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:01:33 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:01:33 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10744 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:01:33 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13049 |13409 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 [Bug 13049] Merge selfreg cron jobs into cleanup_database http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:03:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:03:10 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:03:13 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44346|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 44465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44465&action=edit Bug 15091: Do not allow to use batch checkout if checkout is not allowed If the noissue param is passed to the template, the batch checkout should not be allowed. This patch globally fixes the problem raised by bug 15091. A generic message "cannot check out" is displayed and some more specific ones could be added later. For now it only trigger the "fine balance is over the limit" message. Test plan: Confirm there is no regression on the original behavior and that the issue raised on bug 15091 is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:04:09 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #10 from Jonathan Druart --- Marc and Nicole, Could you please test this patch, I think it's a global fix for this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:06:33 +0000 Subject: [Koha-bugs] [Bug 15135] New: Remove Warning Subroutine HasOverdues redefined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Bug ID: 15135 Summary: Remove Warning Subroutine HasOverdues redefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To reproduce: - Go to Home > Patrons > Patron details for.... - Search for warning above in log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:07:51 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #11 from Jonathan Druart --- (In reply to Joonas Kylm?l? from comment #10) > Do we need this patch? The funds are in sorted order even without this patch > in acqui/acqui-home.pl. No, they are not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:13:06 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:14:09 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > Would it be possible to unit test this? Yes, it would, but it's kind of mental torture to provide a test, the subroutine is not tested at all. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:14:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:14:14 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #1 from Marc V?ron --- Created attachment 44466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44466&action=edit Bug 15135: Remove Warning Subroutine HasOverdues redefined In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To test: - Go to Home > Patrons > Patron details for.... - Search for warning above in log - Apply patch - Verify that no more warnings appear - Verify that patron pages behave as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:15:44 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:38:49 +0000 Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple URLs (856) in cart |Multiple URLs (856) in |email are broken |cart/list email are broken Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:54:33 +0000 Subject: [Koha-bugs] [Bug 15136] New: Display item's homebranch in patron's fines list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Bug ID: 15136 Summary: Display item's homebranch in patron's fines list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: contact at kanellov.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Displaying the item's homebranch for item in "Description of charges" would be useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:57:59 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #1 from Vassilis Kanellopoulos --- I've submitted a pull request for this enhancement. https://github.com/Koha-Community/Koha/pull/10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:58:09 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Jonathan Druart --- I have asked Martin to give his opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 10:59:07 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |contact at kanellov.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43464|0 |1 is obsolete| | --- Comment #217 from Jonathan Druart --- Created attachment 44467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44467&action=edit Bug 14544: Make the intranet side independent of Page.pm Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43465|0 |1 is obsolete| | --- Comment #218 from Jonathan Druart --- Created attachment 44468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44468&action=edit Bug 14544: Get rid of GetBibliosShelves Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:32 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43466|0 |1 is obsolete| | --- Comment #219 from Jonathan Druart --- Created attachment 44469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44469&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:38 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43467|0 |1 is obsolete| | --- Comment #220 from Jonathan Druart --- Created attachment 44470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44470&action=edit Bug 14544: Make the OPAC side independent of Page.pm Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). Bug 14544: Cosmetic: › should be a class divider Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:43 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43469|0 |1 is obsolete| | --- Comment #221 from Jonathan Druart --- Created attachment 44471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44471&action=edit Bug 14544: Get rid of ShelfPossibleAction Bug 14544: (follow-up) Get rid of ShelfPossibleAction Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:49 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43470|0 |1 is obsolete| | --- Comment #222 from Jonathan Druart --- Created attachment 44472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44472&action=edit Bug 14544: Get rid of GetShelfContent Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:07:55 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43471|0 |1 is obsolete| | --- Comment #223 from Jonathan Druart --- Created attachment 44473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44473&action=edit Bug 14544: Get rid of GetSomeShelfNames Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:00 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43472|0 |1 is obsolete| | --- Comment #224 from Jonathan Druart --- Created attachment 44474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44474&action=edit Bug 14544: Move HandleDelBorrower to C4::Members Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:06 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43473|0 |1 is obsolete| | --- Comment #225 from Jonathan Druart --- Created attachment 44475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44475&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:11 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43474|0 |1 is obsolete| | --- Comment #226 from Jonathan Druart --- Created attachment 44476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44476&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43475|0 |1 is obsolete| | --- Comment #227 from Jonathan Druart --- Created attachment 44477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44477&action=edit Bug 14544: Fix regression on adding a new list The user should not be allowed to create a new list and get a friendly error message if he tries. The "New list" links are removed. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43476|0 |1 is obsolete| | --- Comment #228 from Jonathan Druart --- Created attachment 44478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44478&action=edit Bug 14544: DB Changes: Set a default value for sortfield Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43477|0 |1 is obsolete| | --- Comment #229 from Jonathan Druart --- Created attachment 44479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44479&action=edit Bug 14544 - Handle database error when creating a shelf with DB admin account Signed-off-by: Jonathan Druart I don't think this is useful, it will be a mess if we have to check this case everywhere. But it works! I let the cut to the QAer or RM. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:32 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43478|0 |1 is obsolete| | --- Comment #230 from Jonathan Druart --- Created attachment 44480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44480&action=edit Bug 14544: [QA Follow-up] Fix warning about transaction When running Virtualshelves.t, you have this warning: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. By moving the DBI lines after creating the TestBuilder object, the warning will be gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:37 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43479|0 |1 is obsolete| | --- Comment #231 from Jonathan Druart --- Created attachment 44481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44481&action=edit Bug 14544: Add missing biblio <=> biblioitems <=> items relationships to the schema Signed-off-by: Marcel de Rooy Adjusted by a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:43 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43480|0 |1 is obsolete| | --- Comment #232 from Jonathan Druart --- Created attachment 44482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44482&action=edit Bug 14544: QA fixes - some minor bug fixes See comment 171 and 172 for more details. This patch mainly fixes typo or silly error in templates. It also uses the relationships added by previous patch to join the biblioitems and items tables (changes in opac-shelves.pl and shelves.pl). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:48 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43481|0 |1 is obsolete| | --- Comment #233 from Jonathan Druart --- Created attachment 44483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44483&action=edit Bug 14544: [QA Follow-up] Added some test descriptions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:54 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43482|0 |1 is obsolete| | --- Comment #234 from Jonathan Druart --- Created attachment 44484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44484&action=edit Bug 14544: [QA Follow-up] DBIx::Class changes One of the follow-ups added a belongs_to from Biblioitem to Item just as biblioitemnumber was a foreign key to Item. The relation goes the other way. As a temporary measure, I added set_primary_key in the local section of Virtualshelfcontent. Should be moved later with a real db rev. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:08:59 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43485|0 |1 is obsolete| | --- Comment #235 from Jonathan Druart --- Created attachment 44485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44485&action=edit Bug 14544: Fix 'back to lists' link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:09:04 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43486|0 |1 is obsolete| | --- Comment #236 from Jonathan Druart --- Created attachment 44486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44486&action=edit Bug 14544: Fixes regression: display author and dateadded on the list view [intranet] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:09:09 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43487|0 |1 is obsolete| | --- Comment #237 from Jonathan Druart --- Created attachment 44487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44487&action=edit Bug 14544: Fix 'Back to lists' links on sharing a shelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:09:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:09:54 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #11 from Marc V?ron --- Jonathan, I tested yout counter patch with following setting: a) Set loan fee for an item to 5.01 b) Set threshold to 10 c) Do a batch checkout (6 items) for a patron with 0 fines d) The 'Confirm checkout' dialog shows first item with no Information, following intems with information "The patron has a debt of 5.01" e) Click 'Checkout or renew' f) Message appears: "Cannot check out! Checkouts are BLOCKED because fine balance is OVER THE LIMIT." g) Go to Checkout page. 2 of the 6 items are checked out, charges now are on 10.02 This is almost the same confusing situation as described and screencasted by Nicole. With the patch I proposed and signed-off by Nicole, the user sees what happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:22:49 +0000 Subject: [Koha-bugs] [Bug 15137] New: List email send froms taff is missing author information Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Bug ID: 15137 Summary: List email send froms taff is missing author information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When sending a list email from the staff client, the "Author(s):" information is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:30:41 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:30:43 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44417|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 44488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44488&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 http://bugs.koha-community.org/show_bug.cgi?id=14965 Signed-off-by: Frederic Demians Code OK. The 4 reports works for me as before (same results). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:31:44 +0000 Subject: [Koha-bugs] [Bug 15138] New: typo in reports/borrowers_out.pl - issues.timestamap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Bug ID: 15138 Summary: typo in reports/borrowers_out.pl - issues.timestamap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14426 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14426 [Bug 14426] SQL Injection in Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:31:44 +0000 Subject: [Koha-bugs] [Bug 14426] SQL Injection in Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15138 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:32:23 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #12 from Jonathan Druart --- Comment on attachment 44488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44488 Remove C4::Dates from 'lists' in folder reports Review of attachment 44488: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14965&attachment=44488) ----------------------------------------------------------------- ::: reports/borrowers_out.pl @@ +232,4 @@ > } > $strcalc .= " AND NOT EXISTS (SELECT * FROM issues WHERE issues.borrowernumber=borrowers.borrowernumber "; > if ( @$filters[1] ) { > + $strcalc .= " AND issues.timestamp > ?"; I have opened bug 15138 for this typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:34:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:34:48 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:34:50 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 --- Comment #1 from Jonathan Druart --- Created attachment 44489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44489&action=edit Bug 15138: Fix typo timestamap Introduced by bug 14426, should be backported to all supported stable version (3.14, 3.16, 3.18 and 3.20). Test plan: got on Home ? Reports ? Patrons with no checkouts Fill the Not checked out since, you will never get any result, a sql error is in the log Unknown column 'issues.timestamap' in 'where clause' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:35:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:35:21 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |fridolin.somers at biblibre.co | |m, liz at catalyst.net.nz, | |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:39:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 11:39:31 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- Define a date of birth at the opac, validate the changes. Clear the date, go and see the changes: the new date is today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:06:03 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 --- Comment #22 from Olli-Antti Kivilahti --- Created attachment 44490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44490&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager. Recover from changed userid mid-session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:10:37 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44465|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 44491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44491&action=edit Bug 15091: Do not allow to use batch checkout if checkout is not allowed If the noissue param is passed to the template, the batch checkout should not be allowed. This patch globally fixes the problem raised by bug 15091. A generic message "cannot check out" is displayed and some more specific ones could be added later. For now it only trigger the "fine balance is over the limit" message. Test plan: Confirm there is no regression on the original behavior and that the issue raised on bug 15091 is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:10:45 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #13 from Jonathan Druart --- Created attachment 44492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44492&action=edit Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:11:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:11:19 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #14 from Jonathan Druart --- Could you please try again with the last patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:16:11 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Ping Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:17:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:17:52 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:17:59 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #10 from Jonathan Druart --- Created attachment 44494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44494&action=edit Bug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl Test plan: Add/edit/remove biblio frameworks from the administration module (admin/biblio_framework.pl). You should get message feedback after each action. Signed-off-by: Bernardo Gonzalez Kriegel No problems found. Tested add/edit/delete No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:17:56 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43775|0 |1 is obsolete| | Attachment #43776|0 |1 is obsolete| | Attachment #43944|0 |1 is obsolete| | Attachment #43974|0 |1 is obsolete| | Attachment #43975|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 44493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44493&action=edit Bug 14889: Add Koha::BiblioFramework[s] classes Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:18:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:18:04 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #11 from Jonathan Druart --- Created attachment 44495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44495&action=edit Bug 14889: QA Follow-up - Removes unused package from BiblioFramework.pm - Makes framework table sortable - Some small changes in wording of error messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:18:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:18:07 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #12 from Jonathan Druart --- Created attachment 44496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44496&action=edit Bug 14889: Fix error msg on duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:18:10 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #13 from Jonathan Druart --- Created attachment 44497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44497&action=edit Bug 14889: Add tests for Koha::BiblioFramework[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:21:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:21:15 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:21:23 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #25 from Jonathan Druart --- Created attachment 44499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44499&action=edit Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:21:27 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #26 from Jonathan Druart --- Created attachment 44500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44500&action=edit Bug 4502: Changing wording again... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:21:18 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39083|0 |1 is obsolete| | Attachment #39084|0 |1 is obsolete| | Attachment #42771|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 44498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44498&action=edit Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:32:01 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:32:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:32:03 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44055|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44501&action=edit [PASSED QA] Bug 15066: Make transfer rotating collection works under Plack This patch the 2 following errors: Undefined subroutine &C4::RotatingCollections::transferbook called at C4/RotatingCollections.pm line 451. Undefined subroutine &C4::RotatingCollections::GetTransfers called at C4/RotatingCollections.pm line 450. And this warning: "my" variable $colId masks earlier declaration in same scope at /home/koha/src/rotating_collections/transferCollection.pl line 75. Test plan: Create a rotating collection Transfer it to another branch It should work with this patch Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:36:50 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44489|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44502&action=edit Bug 15138: Fix typo timestamap Introduced by bug 14426, should be backported to all supported stable version (3.14, 3.16, 3.18 and 3.20). Test plan: got on Home ? Reports ? Patrons with no checkouts Fill the Not checked out since, you will never get any result, a sql error is in the log Unknown column 'issues.timestamap' in 'where clause' Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:37:47 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:38:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:38:27 +0000 Subject: [Koha-bugs] [Bug 15139] New: Show nonpublic note in overdues report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Bug ID: 15139 Summary: Show nonpublic note in overdues report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The nonpublic note would be useful in the overdues report as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:38:39 +0000 Subject: [Koha-bugs] [Bug 15139] Show nonpublic note in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13024 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:38:39 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15139 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:54:12 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:54:32 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:54:54 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:55:13 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:55:34 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thansk Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:55:56 +0000 Subject: [Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:56:09 +0000 Subject: [Koha-bugs] [Bug 15134] How to install Restful web services for KOHA In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- The developers' list is a good place to start: http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:56:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 12:56:42 +0000 Subject: [Koha-bugs] [Bug 15140] New: Add MARC21 776 to OPAC and staff display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Bug ID: 15140 Summary: Add MARC21 776 to OPAC and staff display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org 776 - Additional Physical Form Entry http://www.loc.gov/marc/bibliographic/bd776.html is currently not displayed in OPAC or staff and should be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:00:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:00:39 +0000 Subject: [Koha-bugs] [Bug 15141] New: Add MARC21 772 to OPAC and staff display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15141 Bug ID: 15141 Summary: Add MARC21 772 to OPAC and staff display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org 772 - Supplement Parent Entry (R) http://www.loc.gov/marc/bibliographic/bd772.html is currently not displayed in OPAC or staff and should be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:23:58 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:24:36 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- Can u please rebase it ASAP? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:27:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:27:12 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 --- Comment #2 from Kyle M Hall --- Created attachment 44503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44503&action=edit Bug 14743 - addorder.pl redirect problems under plack behind apache 2.4.10 I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! Test Plan: 1) Using plack, add an order to a basket from an external source 2) Note the error 3) Apply this patch 4) Add an order to a basket from an external source 5) Note you get no error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:27:09 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:27:32 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:27:39 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #56 from Tom?s Cohen Arazi --- Can u please rebase ASAP? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:36:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:36:53 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:37:33 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #238 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:37:57 +0000 Subject: [Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:38:17 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:38:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:38:35 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:42:40 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:42:43 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41936|0 |1 is obsolete| | Attachment #41937|0 |1 is obsolete| | Attachment #41938|0 |1 is obsolete| | Attachment #41939|0 |1 is obsolete| | Attachment #41940|0 |1 is obsolete| | Attachment #41941|0 |1 is obsolete| | Attachment #41942|0 |1 is obsolete| | Attachment #41943|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall --- Created attachment 44504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44504&action=edit Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Amended patch: Remove OPAC prog file Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:42:55 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #58 from Kyle M Hall --- Created attachment 44505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44505&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:42:58 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #59 from Kyle M Hall --- Created attachment 44506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44506&action=edit Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:43:02 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #60 from Kyle M Hall --- Created attachment 44507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44507&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:43:06 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #61 from Kyle M Hall --- Created attachment 44508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44508&action=edit Bug 9468 [QA Followup] Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:43:10 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #62 from Kyle M Hall --- Created attachment 44509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44509&action=edit Bug 9468: followup insert ignore Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:43:14 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #63 from Kyle M Hall --- Created attachment 44510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44510&action=edit Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:45:35 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44353|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:45:55 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44353|0 |1 is patch| | Attachment #44353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:51:55 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #21 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #20) > Can u please rebase it ASAP? The rebase is required because of bug 13943. Also noticed that ampersand parameters were added in poor HTML form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:54:49 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #121 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:55:18 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #64 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 13:57:37 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #62 from Kyle M Hall --- (In reply to Robin Sheat from comment #61) > Would URI::Escape work, which is already a Koha dependency? > > https://metacpan.org/pod/URI::Escape I'm afraid not. The note only uses url_encode, but also url_params_mixed which URI::Escape does not provide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:00:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:00:18 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:03:48 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44430|0 |1 is obsolete| | Attachment #44431|0 |1 is obsolete| | Attachment #44432|0 |1 is obsolete| | Attachment #44433|0 |1 is obsolete| | Attachment #44434|0 |1 is obsolete| | Attachment #44435|0 |1 is obsolete| | Attachment #44436|0 |1 is obsolete| | --- Comment #264 from Kyle M Hall --- Created attachment 44511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44511&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #265 from Kyle M Hall --- Created attachment 44512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44512&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #266 from Kyle M Hall --- Created attachment 44513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44513&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:32 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #267 from Kyle M Hall --- Created attachment 44514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44514&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:38 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #268 from Kyle M Hall --- Created attachment 44515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44515&action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:43 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #269 from Kyle M Hall --- Created attachment 44516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44516&action=edit Bug 9303 [QA Followup] - Restore ability for patron to control setting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:04:48 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #270 from Kyle M Hall --- Created attachment 44517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44517&action=edit Bug 9303 [QA Followup] - Restore missing svc script Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:05:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:05:46 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #17 from Marc V?ron --- Created attachment 44518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44518&action=edit Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:06:24 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:09:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:09:21 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 44519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44519&action=edit Bug 14836: (QA followup) Add missing transaction Bug 15081 removed transaction handling from t::lib::TestBuilder so this patchset had to be ammended to handle it on its own. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:10:01 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:17:47 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #5 from Mirko Tietgen --- When adding a suscription, after "Add a new subscription (2/2)" (where dates are entered) I get > Software error: > > Can't call method "ymd" without a package or object reference at /home/mirko/koha/Koha/DateUtils.pm line 206. Works without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:24:57 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14321 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:24:57 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14893 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 [Bug 14893] Separate temporary storage per instance in Upload.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:34:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:34:06 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #15 from Marc V?ron --- Hi Jonathan, If the patron is over the limit the message appears now as appropriate when going to tab "Batch checkout". One thing remains: There is no info in the information column about items that sucsessfully were checked out (like it was in my patch "Batch Checkout: Tell the user what happens while checking out"). The column "Information" now remains empty for sucessfully checked out items. See discussion with Nicole on IRC around: http://irc.koha-community.org/koha/2015-11-03#i_1750313 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:34:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:34:17 +0000 Subject: [Koha-bugs] [Bug 15142] New: Titles facet does not work in UNIMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Bug ID: 15142 Summary: Titles facet does not work in UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org There is a "Titles" facet using in UNIMARC 500$a, 501$a and 503$a : In etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml su-ut:0 su-ut:0 su-ut:0 In etc/zebradb/ccl.properties : su-ut Subject The problem is that 500$a, 501$a and 503$a are not indexed as Subject : In etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml Title:w Title:p Title:w Title:p Title:w Title:p How should we change this configuration ? In MARC21, this facet uses field 630 that is indexed as Subject. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:34:25 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 14:46:10 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #129 from Paul Poulain --- Functionality question: is there an EDIFACT way for a vendor to cancel an order line (ie: the vendor cannot deliver an item that was ordered) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:27:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 15:27:04 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #16 from Jonathan Druart --- (In reply to Marc V?ron from comment #15) > Hi Jonathan, > > If the patron is over the limit the message appears now as appropriate when > going to tab "Batch checkout". > > One thing remains: There is no info in the information column about items > that > sucsessfully were checked out (like it was in my patch "Batch Checkout: Tell > the user what happens while checking out"). The column "Information" now > remains empty for sucessfully checked out items. > > See discussion with Nicole on IRC around: > http://irc.koha-community.org/koha/2015-11-03#i_1750313 That is the expected behavior: if the item has been checked out, nothing in the information column. But Nicole and you agree that it's better, we could add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:18:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:18:14 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #6 from Zeno Tajoli --- Marc, this bug cover also misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl ? Because I see modification also on those two scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:28:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:28:20 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 --- Comment #1 from Martin Stenberg --- Created attachment 44520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44520&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page, places focus on the barcode text field and adds a discrete shortcut link for printing receipts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:41:01 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:41:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:41:03 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44342|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44521&action=edit Bug 12544 - Send scheduled reports as an attachment This patch adds the ability to add the report as an attached file to the sent email. Test Plan: 1) Email yourself a test report 2) Apply this patch 3) Repeat step 1, note there is no difference 4) Add the -a parameter, note your also recieve the report as an attachment Sponsored-by: Briar Cliff University Signed-off-by: Kyle M Hall Signed-off-by: Julius Fleschner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:50:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:50:28 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #6 from Marc V?ron --- Without the patch, invalid dates like 33/33/2099 produced some fantays dates in the future. It is rather difficult to introduce a good date validation here. I'm trying, but if in the meantime soebody presents a valid solution I would not oppose :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:57:09 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:57:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:57:12 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #22 from Nick Clemens --- Created attachment 44522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44522&action=edit Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 16:57:18 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #23 from Nick Clemens --- Created attachment 44523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44523&action=edit Bug 7369 - Use dropdown buttons for item actions NOTE: Tested both patches together. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 18:42:40 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #24 from M. Tompsett --- Comment on attachment 44523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44523 Bug 7369 - Use dropdown buttons for item actions Review of attachment 44523: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7369&attachment=44523) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +188,2 @@ > [% ELSE %] > +
  • Delete
    • This is the only point I'd question in the rebase: confirm_deletion has parameters here, but not in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 18:51:41 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:51:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 18:51:58 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 18:57:43 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44522|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 44524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44524&action=edit Bug 7369 - duplicate item and add dropdown buttons for item actions This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 18:59:27 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #26 from Nick Clemens --- Thanks Mark! Rebased and squashed > This is the only point I'd question in the rebase: confirm_deletion has > parameters here, but not in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 21:05:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 20:05:57 +0000 Subject: [Koha-bugs] [Bug 15143] New: Removing a Guarantee from a Guarantors account Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143 Bug ID: 15143 Summary: Removing a Guarantee from a Guarantors account Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If the Guarantee is changed to an Adult without removing it from the Guarantors account first it gets stuck on the Guarantors account. -Jesse -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 22:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 21:50:02 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-dump shouldn't back |koha-dump shouldn provide a |backup Zebra indexes by |way to exclude Zebra |default |indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 22:50:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 21:50:40 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44462|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 44525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44525&action=edit Bug 15133: encode correctly email generated by runreport.pl /misc/cronjobs/runreport.pl send badly encoded email in text/csv (partially ok in HTML). TEST: 1. Send by email a report containing a subject with accented characters and resultset with accented characters. For example: ./runreport.pl --subject="???" --to=me at home.org 1 ./runreport.pl --format=html --subject="???" --to=me at home.org 1 The first email contains badly encoded subject & message. The second email contains badly encoded subject, but correct message. 2. Apply the patch 3. Repeat 1 => No more strange characters. Signed-off-by: Liz Rea Characters are correctly encoded now, thanks for that good spot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 22:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 21:50:56 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 22:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 21:56:50 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #7 from Marc V?ron --- (In reply to Zeno Tajoli from comment #6) > Marc, this bug cover also misc/cronjobs/overdue_notices.pl and > misc/cronjobs/staticfines.pl ? > Because I see modification also on those two scripts. Yes, as mentioned in teh latest commit message. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 23:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 22:13:08 +0000 Subject: [Koha-bugs] [Bug 13435] OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to a branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13435 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nengard at gmail.com Component|OPAC |Documentation --- Comment #2 from Liz Rea --- Nicole would you make sure that we say something about this notice in the manual please? Let me know if you need more explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 23:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 22:13:58 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- A side note from a non-UNIMARC guy: when I wrote the facets section for biblio-koha-indexdefs.xml (UNIMARC) I just grabbed the facet creation information from C4::Koha->getFacets(). So the Zebra facets are defined exactly as to old ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:13:00 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #7 from Marc V?ron --- Created attachment 44526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44526&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page Note: Before C4::Dates removal, wrong dates like 33/33/2033 created valid fantasy dates in the future. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:26:16 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44526|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 44527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44527&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future. - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:26:49 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Marc V?ron --- Without the patch, invalid dates like 33/33/2099 produced some fantays dates in the future. It is rather difficult to introduce a good date validation here. I'm trying, but if in the meantime soebody presents a valid solution I would not oppose :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:54:49 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44527|0 |1 is obsolete| | --- Comment #10 from Marc V?ron --- Created attachment 44528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44528&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future, e.g. 32/22/2099 resulted in 03/11/2100 - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:58:21 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:58:24 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 --- Comment #1 from cnorthcott.work at gmail.com --- Created attachment 44529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44529&action=edit Bug 15106:: Batch Patron Modification Performance Improvement Batch Patron Modification has a fairly long run/load time. I have attempted to improve the runtime of the Batch Patron Modification tool by removing unecessary reporting detail after large batch patron changes and altering some logic to avoid fetching and checking data that won't be needed. Test Plan: 1) Prepare NTYprof (http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf) or procure a stopwatch (stopwatch will be simpler but less accurate). 2) Ensure you have a decent number of patrons in your Koha system (>500) if you are lacking patrons to modify in your database you can import 1000 using the PatronDataCSV.csv attachement and the Import Patrons tool before moving to step 3. 3) Prepare a file with the cardnumber of borrowers to modify. If you imported patrons using PatronDataCSV.csv you can use the attached PatronCardNums.txt 4) Navigate to Home > Tools > Batch Patrons Modification in the Koha Intranet. 5) Click the "Browse..." button and select PatronCardNums.txt 6) Click the "Continue" button and scroll to the bottom of the page. 7) Enter text into the "Country" field box. 8) Enter text into the "Circulation note" field box. 9) If you are using a stopwatch, prepare your stopwatch so that you will start counting seconds from the point you click the button in the next step. 10) Click the "Save" button (simultaneously start your stopwatch if using one) 11) When the page appears showing completion of the change, stop your stopwatch and check the time or navigate to the folder you have set NYTProf to output. 12) Record the runtime. This is the pre-optimisation time. 13) If this is your pre-patch test, the success page will show all the patrons with the data changed, if this is your post-patch test it should only show a "Successfully changed patrons" message. 13) Apply this patch. 14) Repeat steps 2-12 of this testplan with the patch applied. This will yield the post-optimisation time. 15) Compare the pre-optimisation time and post optimisation time. The second post-optimisation time should be faster. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 00:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2015 23:58:52 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 --- Comment #2 from cnorthcott.work at gmail.com --- Created attachment 44530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44530&action=edit CSV file containing patron data for import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 01:01:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 00:01:35 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 --- Comment #3 from cnorthcott.work at gmail.com --- Created attachment 44531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44531&action=edit Card Numbers txt file for identifying patrons to modify -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:35:28 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Resolution|--- |WORKSFORME Status|Needs Signoff |RESOLVED --- Comment #9 from Liz Rea --- I can't make this happen in Firefox 41, that's 3 Works for me's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:37:20 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- This needs a test plan please, before we can test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:41:56 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #30 from Liz Rea --- Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t CONFLICT (content): Merge conflict in t/db_dependent/Holds.t Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:45:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:45:01 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:45:04 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41553|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 44532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44532&action=edit Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:56:39 +0000 Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one of the fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Status|Needs Signoff |In Discussion CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- I'd love to see these bugs fixed, I think we should put our attention into bug 13618 rather than fixing all of these independent occurrences of the same-ish problem. 13618 will need heaps of testing. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:56:39 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 [Bug 14744] Cannot select guarantor when quote in one of the fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:59:28 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 02:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 01:59:31 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41451|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 44533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44533&action=edit y# Attachment to Bug 12748 - Serials - two issues with status of "Expected" Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 03:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 02:10:31 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- Hi Jonathan, On your last patch here, I got: fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 03:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 02:15:15 +0000 Subject: [Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- I get this when applying on 3.20.05: Bug 14846 - Items with no holdingbranch causes user's holds display to freeze 42691 - Bug 14846 - Items with no holdingbranch causes svc/holds to crash Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14846 - Items with no holdingbranch causes svc/holds to crash Using index info to reconstruct a base tree... M svc/holds Falling back to patching base and 3-way merge... Auto-merging svc/holds CONFLICT (content): Merge conflict in svc/holds Failed to merge in the changes. Patch failed at 0001 Bug 14846 - Items with no holdingbranch causes svc/holds to crash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 04:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 03:08:07 +0000 Subject: [Koha-bugs] [Bug 15144] New: Fix dashboard font to be Arial, Helvetica, sans-serif for all text Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15144 Bug ID: 15144 Summary: Fix dashboard font to be Arial, Helvetica, sans-serif for all text Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: francescalamoore at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org To match koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 04:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 03:09:37 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44518|0 |1 is obsolete| | --- Comment #18 from H?ctor Eduardo Castro Avalos --- Created attachment 44534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44534&action=edit [SIGNED-OFF]Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. Signed-off-by: Hector Castro Works as advertised. Wrong today corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 04:10:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 03:10:24 +0000 Subject: [Koha-bugs] [Bug 15145] New: Fix hover state on bugzilla theme header so it doesn't jump on hover Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15145 Bug ID: 15145 Summary: Fix hover state on bugzilla theme header so it doesn't jump on hover Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: francescalamoore at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The new theme is very cheerful, it would be nice if the header didn't jump when you hovered over the header text. Also possibly consider setting the fonts from serif to Arial, Helvetica, sans-serif in the bugzilla theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 04:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 03:19:15 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #19 from H?ctor Eduardo Castro Avalos --- Just one comment, Marc The Patrons requesting modification (Home > Patrons > Update patron records) does not follow dateformat syspref. file: members/members-update.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 07:44:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 06:44:58 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 07:45:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 06:45:01 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44354|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44535&action=edit Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Frederic Demians Dialog box with readable & translatable info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 07:50:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 06:50:28 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 07:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 06:50:31 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44466|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44536&action=edit Bug 15135: Remove Warning Subroutine HasOverdues redefined In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To test: - Go to Home > Patrons > Patron details for.... - Search for warning above in log - Apply patch - Verify that no more warnings appear - Verify that patron pages behave as before Signed-off-by: Frederic Demians Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 08:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 07:34:56 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 08:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 07:34:58 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44418|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? --- Created attachment 44537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44537&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 08:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 07:49:33 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #12 from Joonas Kylm?l? --- Created attachment 44538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44538&action=edit Budget order without the patch Jonathan, isn't it here ordered by budget code? Is the patch trying to have the list in this order as shown in the picture? If not, could you please explain me what it tries to do. (I understand that the patch changes the order in the html level (before JS)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 08:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 07:57:05 +0000 Subject: [Koha-bugs] [Bug 15146] New: Format date of birth on patrons requesting modification page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Bug ID: 15146 Summary: Format date of birth on patrons requesting modification page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: - Log in to Opac - Go to "your personal details" - Request a change of the date of birth - Log in to Staff client - Follow link to Patrons requesting modifications (/koha/members/members-update.pl) => The date is not formatted in syspref format This is independent from C4::Dates removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:02:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:02:59 +0000 Subject: [Koha-bugs] [Bug 15105] Batch Item Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105 --- Comment #1 from cnorthcott.work at gmail.com --- I have removed the caching portion and will add it to a separate patch, this will have the effect of drastically reducing the direct improvement in this patch, but there is still value in the small non-cache improvements so I have opted to submit it here anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:16:38 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 --- Comment #1 from Marc V?ron --- Created attachment 44539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44539&action=edit Bug 15146 - Format date of birth on patrons requesting modification page To reproduce / test - Log in to Opac - Go to "your personal details" - Request a change of the date of birth - Log in to Staff client - Follow link to Patrons requesting modifications (/koha/members/members-update.pl) => The date is not formatted in syspref format - Apply patch, reload members-update.pl => The date is formatted in syspref format - Approve changes - Verify that changes are saved This is independent from C4::Dates removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:20:25 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14956 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch --- Comment #2 from Marc V?ron --- Related to but not depending from Bug 14956 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:20:25 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15146 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:22:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:22:23 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #20 from Marc V?ron --- (In reply to H?ctor Eduardo Castro Avalos from comment #19) > Just one comment, Marc > > The Patrons requesting modification (Home > Patrons > Update patron records) > does not follow dateformat syspref. > > file: members/members-update.pl Thanks, H?ctor, I filed Bug14956 (needs sign-off) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:24:37 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #21 from Marc V?ron --- Sorry, mistaked: Bug 15146 (Need a double espresso) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 09:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 08:37:18 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Assignee|veron at veron.ch |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 10:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 09:26:24 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44537|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 44540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44540&action=edit Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 10:27:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 09:27:18 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:03:06 +0000 Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not listed in the system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820 --- Comment #8 from Jonathan Druart --- Liz, there is a problem when you have fixed the conflict on commit 6bc08252b4753b31cd73558bf492c03294a83592 Bug 14820: DBRev 3.18.11.001 You have taken the "DEVELOPER PROCESS" part, which is not in 3.18.x yet. So now 2 sql atomicupdate files are executed (oai_sets.sql and hourlyloans.sql). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:09:31 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #13 from Jonathan Druart --- (In reply to Joonas Kylm?l? from comment #12) > Created attachment 44538 [details] > Budget order without the patch > > Jonathan, isn't it here ordered by budget code? Is the patch trying to have > the list in this order as shown in the picture? If not, could you please > explain me what it tries to do. (I understand that the patch changes the > order in the html level (before JS)) You have only 1 fund per budget, so you cannot see the sort issue :) Try and create 4 funds: fund_1_1, fund_0_1, fund_1_0, fund_0_0 (in this order) for the same budget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:11:47 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #14 from Jonathan Druart --- And keep in mind: A budget is related to the aqbudgetperiods table and the $budget_period variable, a fund is related to the budgets table and the $budget variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:14:27 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:14:30 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42407|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 44541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44541&action=edit Bug 14575: Fix OPACURLOpenInNewWindow There are some type fixed with this patch. This patch creates a TT var "target" to avoid c/p links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:17:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:17:39 +0000 Subject: [Koha-bugs] [Bug 15147] New: Blocking Calls in Patron Search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15147 Bug ID: 15147 Summary: Blocking Calls in Patron Search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Patron search is just plain slow since the whole converting datatables to ajax. This is because the main route into searching for patrons is the top search box, and that search in fact fires a series of blocking requests instead of asynchronous ones. This can be seen clearly from the chrome dev tools networks tab. One long running request to members.pl followed by a non-trivial call to svc/search. This is fine once, but if you then change the search term inside that top box, the whole procedure is fired again. We were better off before the Async work as the search was done as part of the initial members.pl piece. The page was slow to load, but at least it yielded results straight away rather than having to fire a second request only after the page had loaded. The best solution would be to do it properly asynchronously. Load member.pl only once in the lifetime of a session perhaps and utilise caches to keep it clientside.. then a search would always just fire the svc call and thus yield a much faster search experience. There are a bunch of places were doing async totally wrong, but this to me is the most obvious and the one that's hurting our customers the most. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:18:02 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:18:05 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38484|0 |1 is obsolete| | Attachment #38540|0 |1 is obsolete| | Attachment #38541|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 44542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44542&action=edit Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:18:13 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #9 from Jonathan Druart --- Created attachment 44543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44543&action=edit Bug 14060: Add OnClose event on missing datepicker The "suspend until" inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:18:20 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #10 from Jonathan Druart --- Created attachment 44544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44544&action=edit Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:34:29 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- (In reply to Joonas Kylm?l? from comment #10) > With the follow-up version of the patch the unit test might fail if the test > is run at 12 +- 0.0001s AM/PM. What shall we do with this? It would be great > to keep those unit tests. Maybe we could change the function > GetTodaysReturnsForBorrower to accept a day from which the returns should be > retrieved, and also function CheckInSlip to accept a day from which to > retrieve the slip. Then in the unit test we could specify the day.. And I > think in this way the code would be more generalized. I have fixed the same kind of problem on bug 15029. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:35:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:35:19 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #12 from Jonathan Druart --- Actually it's the same script :) You should provide a patch on top of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:36:18 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Actually it's the same script :) > You should provide a patch on top of it. Or just rebase since it's pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:40:53 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Everything works fine, but I would prefer to see a css class defined to use everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:42:00 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:42:03 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44298|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 44545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44545&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:42:32 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > Everything works fine, but I would prefer to see a css class defined to use > everywhere. Let's say do it later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:49:38 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44541|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 44546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44546&action=edit Bug 14575: Fix OPACURLOpenInNewWindow There are some type fixed with this patch. This patch creates a TT var "target" to avoid c/p links. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:49:58 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 11:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 10:55:56 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- I don't want to spent too much time on this script, but I don't think it will work as before. C4::Dates->new($1, 'us')->output() and output_pref( { dt => dt_from_string( $1 ), dateonly => 1, dateformat => 'us' } are different I think, it should be output_pref( { dt => dt_from_string( $1, 'us' ), dateonly => 1 } I would prefer to see this script deleted :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:00:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:00:17 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Marc, we are using eval compulsively. It should only be used for user inputs, not when the data comes from the DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:13:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:13:09 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:13:12 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44535|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 44547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44547&action=edit Bug 15117: Transfer Order: Better user information and translation handling While transferring an order, a untranslatable JavaScript confirmation dialog pops up. This patch moves the information about the order to be transferred to the top of the screen to better inform the user what order is to be transferred, and simplifies the confirmation dialog. To test: - Apply patch - Transfer an order from a basket to another basket - Verify, that on top of the screen an information is displayed about which order from which vendor and basket is to be transferred - Verify that the transfer works OK - Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Frederic Demians Dialog box with readable & translatable info. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:14:24 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #8 from Marc V?ron --- (In reply to Jonathan Druart from comment #7) > Marc, we are using eval compulsively. > It should only be used for user inputs, not when the data comes from the DB. Jonathan, maybe I was to anxious / wanted to be on the "save side". Does it harm functionality and/or does it slow down to much everything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:14:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:14:28 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal --- Comment #4 from Jonathan Druart --- Marc, why did not you keep the original wording? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:18:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:18:54 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #4) > Marc, why did not you keep the original wording? For the JS confirmation? - Because the information about "from where / where to" now is displayed on the screen. But I'm not against it if you restore it in a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:20:34 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12933 Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- The plugin use a C4::Members subroutine, you should not remove this line. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 [Bug 12933] Add ability to print overdue slip from staff intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:20:34 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15135 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 [Bug 15135] Remove Warning Subroutine HasOverdues redefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:21:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:21:52 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #67 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > QA comment: > 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues > subroutine in C4::Overdues. Was valid for HasOverdues too. See bug 15135. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:27:10 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 --- Comment #6 from Jonathan Druart --- I am sure we could improve it, even if the info are on the page "Transfer order to this basket" sounds a bit rude :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:28:30 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #9 from Jonathan Druart --- (In reply to Marc V?ron from comment #8) > (In reply to Jonathan Druart from comment #7) > > Marc, we are using eval compulsively. > > It should only be used for user inputs, not when the data comes from the DB. > > Jonathan, maybe I was to anxious / wanted to be on the "save side". > Does it harm functionality and/or does it slow down to much everything? It could hide future bugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:49:27 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > The plugin use a C4::Members subroutine, you should not remove this line. Yes, you are right,there is a soubroutine called in line 57: return C4::Members::HasOverdues($borrowernumber); Because of the way it is called I supposed it is save to remove line 26: use C4::Members qw(HasOverdues); My mistake if that is wrong. What would be an alternative to get rid of the warning? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:55:29 +0000 Subject: [Koha-bugs] [Bug 15148] New: Serials: Test prediction pattern starts at First issue date, not Subscription start date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Bug ID: 15148 Summary: Serials: Test prediction pattern starts at First issue date, not Subscription start date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To reproduce: add or edit a serial, Set dates for First issue, Subscription length Subscripton start Test prediction pattern. You will get a list with the number of issues matching 'subscription length' value, but starting from First issue date, not Subscription start date. Expected: use subscription start and end date to determine the range of issues to show in prediction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:57:46 +0000 Subject: [Koha-bugs] [Bug 15149] New: Serials: Test prediction pattern does not consider Subscription start and end date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Bug ID: 15149 Summary: Serials: Test prediction pattern does not consider Subscription start and end date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To reproduce: add or edit a serial, Set dates for First issue, Subscripton start Subscription end do not set Subscription length. Test prediction pattern. You will get a list of 1000 issues, starting from first issue date (not subscription start date) and going well beyond subscripton end date. Expected: show only the issues within the date range. If subscription length is set to a number of issues, you only get these in the pattern. Also expected: start at subscription start date, not first issue date. I opened an extra bug for that, see Bug 15148 (Numbering pattern in my tests was set to 'Number') -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:58:13 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 12:58:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 11:58:26 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:11 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15148 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:11 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15149 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:24 +0000 Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15149 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:24 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13877 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:35 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10450 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:04:35 +0000 Subject: [Koha-bugs] [Bug 10450] Editing serials predicts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10450 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15149 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:15:58 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #43014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:18:23 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:18:25 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44328|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 44548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44548&action=edit [PASSED QA] Bug 14673 Work around change to AddIssue return Return from AddIssue used to be due date or undef. Now it is less straightforward returning am issue object if an issue row is created or undef. If the issue is a renewal undef is returned. As that case was not handled properly it caused the server site to crash the listener causing a communications error on the client. Signed-off-by: Frederic Demians Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:25:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:25:40 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44441|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen --- Created attachment 44549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44549&action=edit Bug 14969 - Remove C4::Dates from serials/*.pl files Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions Amended to make it apply ( serials/checkexpiration.pl ) 04.11.2015 / mv Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:25:48 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44528|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen --- Created attachment 44550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44550&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future, e.g. 32/22/2099 resulted in 03/11/2100 - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:26:07 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:31:10 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala at gmail.com |veron at veron.ch --- Comment #8 from Marc V?ron --- Joonas, are you working on this bug? It was assigned to you since this morning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:35:35 +0000 Subject: [Koha-bugs] [Bug 15150] New: t/ tests should pass if Test::DBIx::Class is not available Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Bug ID: 15150 Summary: t/ tests should pass if Test::DBIx::Class is not available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com We need t/ to be skipped if they rely on Test::DBIx::Class and it is not available (this happens on the build environment, so we cannot build current master without fixing this). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:45:41 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 13:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 12:45:44 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43682|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 44551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44551&action=edit [PASSED QA] Bug 15036: Do not overwrite complete status in basket ops Reopening or closing a basket should preserve the completed status for receipted orders. This patch excludes orderlines with the completed status from having their status rewritten as a result of the change in basket status Made the subroutines involved more efficient by removing an unnecessary loop and by not fetching a large amount of superfluous data Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:00:31 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:00:33 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44532|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44552&action=edit [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:05:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:05:51 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42795|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 44553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44553&action=edit Bug 14878: Tests - Create the branchcodes when needed Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB. If they need them, they should create them. Test plan: Execute the differente test files on a DB without any branchcode or at least without CPL/MPL branches. Confirm that the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:06:41 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15081 --- Comment #5 from Jonathan Druart --- Conflicts with bug 15081 fixed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 [Bug 15081] TestBuilder should not handle the transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:06:41 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14878 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 [Bug 14878] Tests - Create the branchcodes if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:08:06 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:08:08 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44314|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44554&action=edit [PASSED QA] Bug 14867 - userid not generated when defined in BorrowerUnwantedField When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Fr?d?ric Demians The issue is there, and this patch fixes it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:21:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:21:06 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:21:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:21:08 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44461|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44555&action=edit [PASSED QA] Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore To test, well do something like misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you at youraddress.com 1 where 1 is the number of your favourite saved report. Success is your email arrives with the subject "My fancy subject!" Failure is (with --subject defined) you get either the description of the report, or "Koha saved report" as the subject. This is success without --subject defined. Signed-off-by: Frederic Demians Bug repeatable and fixed by this patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:23:47 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #10 from Marc V?ron --- Created attachment 44556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44556&action=edit Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:25:48 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #45 from Jonathan Druart --- Created attachment 44557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44557&action=edit Bug 14045: Fix failing tests if issuing rules exist If there is issuing rules defined, one test does not pass as it assumes there is none defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:26:55 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:26:58 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44452|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44558&action=edit [PASSED QA] Bug 15130 useless unitialization warnings when updating authorities Signed-off-by: Frederic Demians Fixes a trivial coding error. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:36:23 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:36:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:36:26 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 44559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44559&action=edit Bug 15150: Make t/ tests skip if Test::DBIx::Class absent Tests in t/ should always pass for building the Debian packages for Koha. But we've started using Test::DBIx::Class for writing mocked tests, and that lib is not (yet) packaged fro Debian 7+. This means build is failing. Devs and jenkins use the lib from CPAN. This patch makes the tests skip if the lib is absent. To test: - Install Test::DBIx::Class $ sudo cpanm Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests pass - Uninstall Test::DBIx::Class $ sudo cpan -U Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests still pass (those needing the lib are skipped) - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:36:57 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |katrin.fischer at bsz-bw.de, | |kyle.m.hall at gmail.com Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:37:45 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12544 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 [Bug 12544] Send scheduled reports as an attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:37:45 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15133 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 [Bug 15133] runreport.pl badly encode accented characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:38:56 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44521|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44560&action=edit Bug 12544 - Send scheduled reports as an attachment This patch adds the ability to add the report as an attached file to the sent email. Test Plan: 1) Email yourself a test report 2) Apply this patch 3) Repeat step 1, note there is no difference 4) Add the -a parameter, note your also recieve the report as an attachment Sponsored-by: Briar Cliff University Signed-off-by: Kyle M Hall Signed-off-by: Julius Fleschner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:41:53 +0000 Subject: [Koha-bugs] [Bug 15151] New: t/Circulation_barcodedecode.t fails if no DB present Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Bug ID: 15151 Summary: t/Circulation_barcodedecode.t fails if no DB present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com It should be mocking the DB, but... To reproduce: - Run the test: $ prove t/Circulation_barcodedecode.t => SUCCESS: Tests pass - Shut mysql down $ sudo service mysql stop - Run the test: $ prove t/Circulation_barcodedecode.t => FAIL: Tests fail due to missing DB connection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:41:56 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44525|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44561&action=edit [PASSED QA] Bug 15133: encode correctly email generated by runreport.pl /misc/cronjobs/runreport.pl send badly encoded email in text/csv (partially ok in HTML). TEST: 1. Send by email a report containing a subject with accented characters and resultset with accented characters. For example: ./runreport.pl --subject="???" --to=me at home.org 1 ./runreport.pl --format=html --subject="???" --to=me at home.org 1 The first email contains badly encoded subject & message. The second email contains badly encoded subject, but correct message. 2. Apply the patch 3. Repeat 1 => No more strange characters. Signed-off-by: Liz Rea Characters are correctly encoded now, thanks for that good spot. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:42:16 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Fr?d?ric Demians --- Get this: fatal: sha1 information is lacking or useless (C4/Letters.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:42:34 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |kyle.m.hall at gmail.com, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:42:51 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:45:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:45:03 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44560|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 44562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44562&action=edit Bug 12544 - Send scheduled reports as an attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:45:09 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44440|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Comment on attachment 44440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44440 Bug 14960 - Remove C4::Dates from files in misc/cronjobs Hmm, something is wrong with the latest patch when I amended to make it apply. Going back... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 14:45:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 13:45:58 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|1 |0 is obsolete| | --- Comment #10 from Marc V?ron --- Comment on attachment 43310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43310 Bug 14960 - Remove C4::Dates from files in misc/cronjobs Reactivating... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:15:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:15:54 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43310|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 44563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44563&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:18:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:18:40 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #15 from Joonas Kylm?l? --- (In reply to Jonathan Druart from comment #13) > You have only 1 fund per budget, so you cannot see the sort issue :) > Try and create 4 funds: fund_1_1, fund_0_1, fund_1_0, fund_0_0 (in this > order) for the same budget. Oh, I see. I thought all this time that it was about sorting the different budgets... And now I see that even the title says funds :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:26:19 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:26:21 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44332|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44564&action=edit [PASSED QA] Bug 14632 - Fix alert message for single item batch Fixes the incorrect msg "Please select at least label to delete." for attempts to delete from single patron batches. Notifies the user that doing so will delete the batch. It disallows direct deletion, instead suggests the users to use the 'Delete batch' option assuming the users know what they are doing. Test plan ========= 1/ Load a single patron batch in edit mode and attempt to delete the single record. The JS alert message will inform that "Please select at least label to delete." 2/ Apply patch and refresh page and try to delete the single record again. 3/ This time the alert will inform the user that doing so will delete the batch and should that be desired action to choose the 'Delete batch' option from the toolbar. Signed-off-by: Frederic Demians It works as before but with an understantable warning message. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:27:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:27:24 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44564|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 44565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44565&action=edit [PASSED QA] Bug 14632 - Fix alert message for single item batch Fixes the incorrect msg "Please select at least label to delete." for attempts to delete from single patron batches. Notifies the user that doing so will delete the batch. It disallows direct deletion, instead suggests the users to use the 'Delete batch' option assuming the users know what they are doing. Test plan ========= 1/ Load a single patron batch in edit mode and attempt to delete the single record. The JS alert message will inform that "Please select at least label to delete." 2/ Apply patch and refresh page and try to delete the single record again. 3/ This time the alert will inform the user that doing so will delete the batch and should that be desired action to choose the 'Delete batch' option from the toolbar. Signed-off-by: Frederic Demians It works as before but with an understantable warning message. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:28:28 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 --- Comment #6 from Kyle M Hall --- Created attachment 44566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44566&action=edit [PASSED QA] Bug 14632 [QA Followup] - Restore missing "Delete batch" button. This button was removed by accident in bug 14676 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:29:09 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Upping severity due to missing "Delete batch" button. Patch could be split into a separate bug if need be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:34:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:34:57 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44539|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44567&action=edit [SIGNED-OFF]Bug 15146 - Format date of birth on patrons requesting modification page To reproduce / test - Log in to Opac - Go to "your personal details" - Request a change of the date of birth - Log in to Staff client - Follow link to Patrons requesting modifications (/koha/members/members-update.pl) => The date is not formatted in syspref format - Apply patch, reload members-update.pl => The date is formatted in syspref format - Approve changes - Verify that changes are saved This is independent from C4::Dates removal. Signed-off-by: Hector Castro Works as advertised. Changes saved Ok, Update patron record follows dateformat syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:35:17 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:35:56 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:35:59 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 --- Comment #1 from Jonathan Druart --- Created attachment 44568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44568&action=edit Bug 15151: Make t/Circulation_barcodedecode.t pass Test plan: prove t/Circulation_barcodedecode.t should return green even if your DBMS is stopped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:39:49 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44568|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 44569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44569&action=edit Bug 15151 [Alternate] - t/Circulation_barcodedecode.t fails if no DB present Test Plan: 1) Shut down database 2) prove t/Circulation_barcodedecode.t should fail 3) Apply this patch 4) prove t/Circulation_barcodedecode.t should not fail! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:40:03 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #44568|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:40:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:40:51 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 44570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44570&action=edit Bug 15151: (counter patch) Avoid DB access to load C4::Members In order to avoid loading Koha::NorwegianPatronDB a DB query was used. Instead, a require should be used. This causes non-db_dependent tests that load C4::Members to fail. To test: - Shut mysql down $ sudo service mysql stop - Run the tests: prove t/Circulation_barcodedecode.t => FAIL: DB connection is expected, tests fail - Apply the patch - Run the tests: prove t/Circulation_barcodedecode.t => SUCCESS: Tests pass - Sign off .-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:41:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:41:55 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44569|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44571&action=edit Bug 15151 [Alternate] - t/Circulation_barcodedecode.t fails if no DB present Test Plan: 1) Shut down database 2) prove t/Circulation_barcodedecode.t should fail 3) Apply this patch 4) prove t/Circulation_barcodedecode.t should not fail! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:42:20 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > What would be an alternative to get rid of the warning? Rename the subroutine or no warnings 'redefine'; But the no warnings is not a good solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:45:02 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15151 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:45:02 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14778 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 [Bug 14778] DBIC should create/own the DB handler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:51:43 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:51:46 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44567|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 44572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44572&action=edit Bug 15146 - Format date of birth on patrons requesting modification page To reproduce / test - Log in to Opac - Go to "your personal details" - Request a change of the date of birth - Log in to Staff client - Follow link to Patrons requesting modifications (/koha/members/members-update.pl) => The date is not formatted in syspref format - Apply patch, reload members-update.pl => The date is formatted in syspref format - Approve changes - Verify that changes are saved This is independent from C4::Dates removal. Signed-off-by: Hector Castro Works as advertised. Changes saved Ok, Update patron record follows dateformat syspref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:59:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:59:57 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 15:59:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 14:59:59 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44568|0 |1 is obsolete| | Attachment #44571|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 44573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44573&action=edit [SIGNED-OFF] Bug 15151: (counter patch) Avoid DB access to load C4::Members In order to avoid loading Koha::NorwegianPatronDB a DB query was used. Instead, a require should be used. This causes non-db_dependent tests that load C4::Members to fail. To test: - Shut mysql down $ sudo service mysql stop - Run the tests: prove t/Circulation_barcodedecode.t => FAIL: DB connection is expected, tests fail - Apply the patch - Run the tests: prove t/Circulation_barcodedecode.t => SUCCESS: Tests pass - Sign off .-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:00:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:00:03 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|0 |1 is obsolete| | --- Comment #14 from Joonas Kylm?l? --- Created attachment 44574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44574&action=edit Bug 12224: Allow easy printing of patron check-ins for today Rebased to master This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:00:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:00:18 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44570|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:05:21 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44559|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44575&action=edit [SIGNED-OFF] Bug 15150: Make t/ tests skip if Test::DBIx::Class absent Tests in t/ should always pass for building the Debian packages for Koha. But we've started using Test::DBIx::Class for writing mocked tests, and that lib is not (yet) packaged fro Debian 7+. This means build is failing. Devs and jenkins use the lib from CPAN. This patch makes the tests skip if the lib is absent. To test: - Install Test::DBIx::Class $ sudo cpanm Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests pass - Uninstall Test::DBIx::Class $ sudo cpan -U Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests still pass (those needing the lib are skipped) - Sign off :-D Signed-off-by: Hector Castro Works as advertised. All test pass successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:05:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:05:38 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:11:49 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #46 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:12:11 +0000 Subject: [Koha-bugs] [Bug 15152] New: Try and make Guided Reports related tests pass Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Bug ID: 15152 Summary: Try and make Guided Reports related tests pass Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Jenkins is currently failing on t_db_dependent_Reports_Guided_t.filter takes report id (393) Failing for the past 1 build (Since Unstable#190 ) Took 2 ms. Error Message not ok 8 - filter takes report id Standard Output 1..19 ok 1 - use C4::Reports::Guided; ok 2 - Not breaking subqueries ok 3 - Returns correct default offset ok 4 - Returns correct default LIMIT ok 5 - Correctly removes only final LIMIT ok 6 - Returns correct default offset ok 7 - Returns correct extracted LIMIT ok 8 - Correctly removes only final LIMIT (with offset) ok 9 - Returns correct extracted offset ok 10 - Returns correct extracted LIMIT ok 11 - Not breaking simple queries ok 12 - Returns correct default offset ok 13 - Returns correct default LIMIT ok 14 - Correctly removes LIMIT in simple case ok 15 - Returns correct default offset ok 16 - Returns correct extracted LIMIT ok 17 - Correctly removes LIMIT in simple case (with offset) ok 18 - Returns correct extracted offset ok 19 - Returns correct extracted LIMIT Which does not make sense. I suspect that there is a mismatch with the different filenames. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:12:18 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:12:19 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:12:54 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:13:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:13:03 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44574|0 |1 is obsolete| | --- Comment #15 from Joonas Kylm?l? --- Created attachment 44576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44576&action=edit Bug 12224: Allow easy printing of patron check-ins for today Last rebase wasn't good, now let's try again. Rebased to master This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:13:22 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Indranil and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:14:08 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Lyon3 Team! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:15:47 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:16:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:16:50 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:16:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:16:59 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:17:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:17:02 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #1 from Jonathan Druart --- Created attachment 44577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44577&action=edit Bug 15152: Try and make Guided Reports related tests pass Jenkins is currently failing on t_db_dependent_Reports_Guided_t.filter takes report id (393) Failing for the past 1 build (Since Unstable#190 ) Took 2 ms. Error Message not ok 8 - filter takes report id Standard Output 1..19 ok 1 - use C4::Reports::Guided; ok 2 - Not breaking subqueries ok 3 - Returns correct default offset ok 4 - Returns correct default LIMIT ok 5 - Correctly removes only final LIMIT ok 6 - Returns correct default offset ok 7 - Returns correct extracted LIMIT ok 8 - Correctly removes only final LIMIT (with offset) ok 9 - Returns correct extracted offset ok 10 - Returns correct extracted LIMIT ok 11 - Not breaking simple queries ok 12 - Returns correct default offset ok 13 - Returns correct default LIMIT ok 14 - Correctly removes LIMIT in simple case ok 15 - Returns correct default offset ok 16 - Returns correct extracted LIMIT ok 17 - Correctly removes LIMIT in simple case (with offset) ok 18 - Returns correct extracted offset ok 19 - Returns correct extracted LIMIT Which does not make sense. I suspect that there is a mismatch with the different filenames. This patch groups the different tests for Guided reports into the same file. The goal is to make Jenkins happy going all-in with this assumption. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:20:33 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:20:36 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44575|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44578&action=edit [PASSED QA] Bug 15150: Make t/ tests skip if Test::DBIx::Class absent Tests in t/ should always pass for building the Debian packages for Koha. But we've started using Test::DBIx::Class for writing mocked tests, and that lib is not (yet) packaged fro Debian 7+. This means build is failing. Devs and jenkins use the lib from CPAN. This patch makes the tests skip if the lib is absent. To test: - Install Test::DBIx::Class $ sudo cpanm Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests pass - Uninstall Test::DBIx::Class $ sudo cpan -U Test::DBIx::Class - Run the tests: $ prove t/ => SUCCESS: Tests still pass (those needing the lib are skipped) - Sign off :-D Signed-off-by: Hector Castro Works as advertised. All test pass successful Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:24:54 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:24:57 +0000 Subject: [Koha-bugs] [Bug 15129] Koha::object for issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44540|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 44579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44579&action=edit [PASSED QA] Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it Test plan: 1. Make sure that in koha/admin/smart-rules.pl you can still create new rules and that the new rules have all their values remained after saving the rule (so put to every field something). 2. Make sure you can edit that rule 3. Make sure you can delete that rule Sponsored-by: Vaara-kirjastot Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:27:26 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:27:41 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Hector and Kyle for fast testing this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:28:09 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:35:25 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:35:28 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44200|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 44580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44580&action=edit [PASSED QA] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:41:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:41:59 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.20 CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:42:28 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:42:31 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44502|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44581&action=edit [PASSED QA] Bug 15138: Fix typo timestamap Introduced by bug 14426, should be backported to all supported stable version (3.14, 3.16, 3.18 and 3.20). Test plan: got on Home ? Reports ? Patrons with no checkouts Fill the Not checked out since, you will never get any result, a sql error is in the log Unknown column 'issues.timestamap' in 'where clause' Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:42:32 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41819|0 |1 is obsolete| | --- Comment #16 from Joonas Kylm?l? --- Created attachment 44582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44582&action=edit Bug 12224: Allow easy printing of patron check-ins for today Let's try rebasing for the third time ! :) This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print checked-in today -slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:50:29 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:50:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:50:32 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44451|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44583&action=edit [PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians Plugin still working, with a valid pop-pup window id. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:54:11 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41820|0 |1 is obsolete| | --- Comment #17 from Joonas Kylm?l? --- Created attachment 44584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44584&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today Rebased version This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print check-in slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. 8) Run unit test t/db_dependent/Members/IssueSlip.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 16:56:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 15:56:43 +0000 Subject: [Koha-bugs] [Bug 15147] Blocking Calls in Patron Search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15147 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- (In reply to Martin Renvoize from comment #0) > Patron search is just plain slow since the whole converting datatables to > ajax. > > This is because the main route into searching for patrons is the top search > box, and that search in fact fires a series of blocking requests instead of > asynchronous ones. I see only 1 request to svc/search, what are the others? > This can be seen clearly from the chrome dev tools networks tab. One long > running request to members.pl followed by a non-trivial call to svc/search. > > This is fine once, but if you then change the search term inside that top > box, the whole procedure is fired again. > > We were better off before the Async work as the search was done as part of > the initial members.pl piece. The page was slow to load, but at least it > yielded results straight away rather than having to fire a second request > only after the page had loaded. The idea was to use the top box to launch the first search, then use the filters on the left when you are on the result page to refine the search. > The best solution would be to do it properly asynchronously. Load member.pl > only once in the lifetime of a session perhaps and utilise caches to keep it > clientside.. then a search would always just fire the svc call and thus > yield a much faster search experience. What do you want to cache here? There is no need to cache. What I understand from your need is to make the box on top behaves the same as the filters. > There are a bunch of places were doing async totally wrong, but this to me > is the most obvious and the one that's hurting our customers the most. I don't see any other. We only have the lists and the checkouts using DT + Ajax -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:05:03 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Joonas Kylm?l? --- These patches should be now ready to push to master. But maybe one more sign-off would be in place! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:05:12 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:05:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:05:15 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44077|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 44585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44585&action=edit [SIGNED OFF] Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv Signed-off-by: Mirko Tietgen http://bugs.koha-community.org/show_bug.cgi?id=14945 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:05:26 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44136|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 44586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44586&action=edit [SIGNED OFF] Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:05:33 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44403|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 44587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44587&action=edit [SIGNED OFF] Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:07:29 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44586|0 |1 is obsolete| | --- Comment #20 from Mirko Tietgen --- Created attachment 44588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44588&action=edit Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:07:48 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44587|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen --- Created attachment 44589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44589&action=edit Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:10:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:10:23 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #22 from Mirko Tietgen --- Woops, Nick was a little faster. I'll restore the patches and add my signoff there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:11:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:11:15 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:11:41 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:12:07 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44587|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:12:19 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44586|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:15:41 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:15:43 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44577|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 44590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44590&action=edit [SIGNED OFF] Bug 15152: Try and make Guided Reports related tests pass Jenkins is currently failing on t_db_dependent_Reports_Guided_t.filter takes report id (393) Failing for the past 1 build (Since Unstable#190 ) Took 2 ms. Error Message not ok 8 - filter takes report id Standard Output 1..19 ok 1 - use C4::Reports::Guided; ok 2 - Not breaking subqueries ok 3 - Returns correct default offset ok 4 - Returns correct default LIMIT ok 5 - Correctly removes only final LIMIT ok 6 - Returns correct default offset ok 7 - Returns correct extracted LIMIT ok 8 - Correctly removes only final LIMIT (with offset) ok 9 - Returns correct extracted offset ok 10 - Returns correct extracted LIMIT ok 11 - Not breaking simple queries ok 12 - Returns correct default offset ok 13 - Returns correct default LIMIT ok 14 - Correctly removes LIMIT in simple case ok 15 - Returns correct default offset ok 16 - Returns correct extracted LIMIT ok 17 - Correctly removes LIMIT in simple case (with offset) ok 18 - Returns correct extracted offset ok 19 - Returns correct extracted LIMIT Which does not make sense. I suspect that there is a mismatch with the different filenames. This patch groups the different tests for Guided reports into the same file. The goal is to make Jenkins happy going all-in with this assumption. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:17:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:17:30 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Test plan used: 1 - prove t/db_dependent/Reports_Guided.t - Fail test 8 2 - apply patches 3 - prove -v t/db_dependent/Reports/Guided.t 4 - all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:18:35 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44586|0 |1 is obsolete| | --- Comment #23 from Mirko Tietgen --- Created attachment 44591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44591&action=edit Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:18:50 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44587|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen --- Created attachment 44592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44592&action=edit Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:31:54 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:31:56 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44352|0 |1 is obsolete| | Attachment #44534|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 44593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44593&action=edit [PASSED QA] Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:32:05 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #23 from Kyle M Hall --- Created attachment 44594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44594&action=edit [PASSED QA] Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. Signed-off-by: Hector Castro Works as advertised. Wrong today corrected Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:32:29 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #4 from Jonathan Druart --- (In reply to Nick Clemens from comment #3) > Test plan used: > 1 - prove t/db_dependent/Reports_Guided.t - Fail test 8 Oh, really? What is the error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:39:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:39:41 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 44595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44595&action=edit Bug 14870 - Remove C4/Dates.pm from Koha Remove C4/Dates.pm form Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:41:38 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #7 from H?ctor Eduardo Castro Avalos --- Hi Marc I attached the patch for the near future. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 17:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 16:48:23 +0000 Subject: [Koha-bugs] [Bug 15153] New: Koha::DateUtils sub dt_from_string has two different functions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15153 Bug ID: 15153 Summary: Koha::DateUtils sub dt_from_string has two different functions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org Koha::DateUtils sub dt_from_string has two different functions: get date from string and return DateTime->now(). I think it would be better to seperate to other subroutine or remove fully the DateTime->now() because if someone uses dt_from_string in code to generate the date now it would be really hard for others to understand what is happening because the subroutine's name doesn't give any clues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:22:01 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott at bywatersolutions.co | |m --- Comment #6 from Kyle M Hall --- *** Bug 9614 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:22:01 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #7 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14390 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:24:51 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #20 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14778 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:24:51 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #99 from Tom?s Cohen Arazi --- *** Bug 14375 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:27:20 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44295|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen --- Created attachment 44596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44596&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor Amended to make patch apply 25.10.2015/mv Amended following comment #6 Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:27:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:27:36 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:38:51 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #5 from Nick Clemens --- Well...I got it before, but can no longer reproduce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:50:38 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44553|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 44597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44597&action=edit Bug 14878: Tests - Create the branchcodes when needed Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB. If they need them, they should create them. Test plan: Execute the differente test files on a DB without any branchcode or at least without CPL/MPL branches. Confirm that the tests pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:50:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:50:44 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 44598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44598&action=edit Bug 14878: (QA followup) Remove useless diag Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 18:51:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 17:51:19 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off --- Comment #8 from Tom?s Cohen Arazi --- Nice job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:11:46 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #162 from Tom?s Cohen Arazi --- Created attachment 44599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44599&action=edit Bug 11431: (QA followup) remove diags Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:13:41 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:14:08 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:14:30 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:21:28 +0000 Subject: [Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5264 Status|Needs Signoff |In Discussion CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- I can reproduce the issue you describe, and I confirm that your patch solves it. But a) your code leaves a variable ($exclude) which isn't used anymore, and b) you remove a portion of code which was introduced by bug 5264 (see also bug 5572). Have you tried solving your issue with bug 5572? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:21:29 +0000 Subject: [Koha-bugs] [Bug 5264] Retain additional bibliographic subfields when merging authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5264 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14583 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:23:26 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #27 from Fr?d?ric Demians --- Janusz, do you still use your patch for your library? Have you seen bug 14583? IMO your patch is required in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:24:07 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:24:10 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #7 from Kyle M Hall --- Created attachment 44600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44600&action=edit Bug 14390 - On renewal, the last fine is not marked as accounttype 'F' when item is checked in. Test Plan: 1) Find an overdue checkout with a fine 2) Renew item, note fine is not closed out (Account type F) 3) Apply this patch 4) Find another overdue checkout with a fine 5) Renew item, note fine is now correctly closed out 6) Backdate a checkout to be already overdue ( but not have a fine since fines.pl hasn't run yet ) 7) Renew item, note a closed out fine is created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:27:54 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- (In reply to Marc V?ron from comment #9) [SNIP] > > @@ +102,2 @@ > > > } > > > +if ( $input->param('to') ) { > > > > ... and yet this says 'to'. You didn't explain why the change, or correct it. > > > > @@ -102,2 @@ > > > } > > > -if ( $d = $input->param('iso') ) { > > > > This says 'iso'... > > MV: It's a fix - there is no incoming param 'iso'. We have a param 'from' > and a param 'to' resulting in $from_iso and $to_iso. I tested several times > to make sure that my change does not break the behaviour. That's all I was looking for. :) Since, Mirko has signed off. I'll let it progress to Needs QA. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:30:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:30:38 +0000 Subject: [Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 --- Comment #4 from Fr?d?ric Demians --- > Have you tried solving your issue with bug 5572? I have. It make it. You should use it, sign, and obsolete your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:45:09 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:49:43 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #8 from bondiurbano --- (In reply to Galen Charlton from comment #2) > I don't think that renewing a loan actually converts accrued overdue fines > to committed/closed ones. Rather, I think the sequence of events is this: > > - make loan > - loan becomes overdue > - accrued fines start getting calculated (accounttype = FU) > - loan is renewed > - accrued fine record is not changed (and while the fine itself shouldn't go > away, the accounttype *ought* to be changed to F and the description updated > to indicate that the loan was renewed while overdue) > - loan becomes overdue again > - accrued fines start getting calculated on a second accountlines row > - loan gets returned > > During the return processing, _FixOverduesOnReturn will change the > accounttype of accrued fines from FU to F. However, it currently assumes > that there is exactly one such fine; if there are multiple ones, only one > gets its accounttype changed. Galen, It seems that the problem described by you in the last paragraph of comment 2 is not fixed in this ticket. Do you think it would be appropriate to open a new ticket to address this problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:51:28 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:51:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:51:31 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44597|0 |1 is obsolete| | Attachment #44598|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 44601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44601&action=edit [PASSED QA] Bug 14878: Tests - Create the branchcodes when needed Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB. If they need them, they should create them. Test plan: Execute the differente test files on a DB without any branchcode or at least without CPL/MPL branches. Confirm that the tests pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:51:42 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 --- Comment #10 from Kyle M Hall --- Created attachment 44602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44602&action=edit [PASSED QA] Bug 14878: (QA followup) Remove useless diag Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:54:29 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:55:09 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:55:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:55:11 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44600|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 44603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44603&action=edit Bug 14390 - On renewal, the last fine is not marked as accounttype 'F' when item is checked in. Test Plan: 1) Find an overdue checkout with a fine 2) Renew item, note fine is not closed out (Account type F) 3) Apply this patch 4) Find another overdue checkout with a fine 5) Renew item, note fine is now correctly closed out 6) Backdate a checkout to be already overdue ( but not have a fine since fines.pl hasn't run yet ) 7) Renew item, note a closed out fine is created Signed-off-by: Sean Minkel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 19:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 18:59:33 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 --- Comment #6 from Martin Renvoize --- Created attachment 44604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44604&action=edit Bug 15151: (counter patch) Avoid DB access to load C4::Members In order to avoid loading Koha::NorwegianPatronDB a DB query was used. Instead, a require should be used. This causes non-db_dependent tests that load C4::Members to fail. To test: - Shut mysql down $ sudo service mysql stop - Run the tests: prove t/Circulation_barcodedecode.t => FAIL: DB connection is expected, tests fail - Apply the patch - Run the tests: prove t/Circulation_barcodedecode.t => SUCCESS: Tests pass - Sign off .-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:00:10 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #44573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:00:31 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44604|Bug 15151: (counter patch) |[PASSED QA] Bug 15151: description|Avoid DB access to load |(counter patch) Avoid DB |C4::Members |access to load C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:00:52 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Passed all tests, code looks good.. go for it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:01:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:01:05 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #12 from M. Tompsett --- Eyeballs well. Have yet to test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:12:29 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #10 from bondiurbano --- (In reply to Galen Charlton from comment #2) > I don't think that renewing a loan actually converts accrued overdue fines > to committed/closed ones. Rather, I think the sequence of events is this: > > - make loan > - loan becomes overdue > - accrued fines start getting calculated (accounttype = FU) > - loan is renewed > - accrued fine record is not changed (and while the fine itself shouldn't go > away, the accounttype *ought* to be changed to F and the description updated > to indicate that the loan was renewed while overdue) > - loan becomes overdue again > - accrued fines start getting calculated on a second accountlines row > - loan gets returned > > During the return processing, _FixOverduesOnReturn will change the > accounttype of accrued fines from FU to F. However, it currently assumes > that there is exactly one such fine; if there are multiple ones, only one > gets its accounttype changed. Galen, I will think this problem all over again. May be it works. Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:44:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:44:11 +0000 Subject: [Koha-bugs] [Bug 15154] New: Allow correct translation for upload local cover image Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Bug ID: 15154 Summary: Allow correct translation for upload local cover image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org CC: bgkriegel at gmail.com, frederic at tamil.fr On intranet catalog detail in tab Image, the way in which the the link is displayed for "Please upload one" for some languages (Spanish my case) does not allow translate properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:51:43 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from H?ctor Eduardo Castro Avalos --- Sorry my mistake, the string really works well for translation purpose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:55:53 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 20:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 19:56:03 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44503|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 44605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44605&action=edit Bug 14743 - addorder.pl redirect problems under plack behind apache 2.4.10 I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! Test Plan: 1) Using plack, add an order to a basket from an external source 2) Note the error 3) Apply this patch 4) Add an order to a basket from an external source 5) Note you get no error! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 22:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 21:09:41 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 22:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 21:09:52 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44463|0 |1 is obsolete| | --- Comment #39 from Josef Moravec --- Created attachment 44606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44606&action=edit Bug 12072 - Add system preference for New dateformat dd.mm.yyyy (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 6 22:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Nov 2015 21:11:32 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 06:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 05:40:57 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #8 from Marc V?ron --- Hi H?ctor, Thanks for the patch for removing C4/Dates.pm With all the patches applied, we can finally use the new date format from Bug 12072 However, before we remove C4/Dates.pm we have to make sure that the file really no longer is used or referenced. See my comment #1: > To be removed: > > C4/Dates.pm > t/Dates.t > > To be changed: > > debian/templates/plack.psgi > misc/plack/koha.psgi Additionally, we should do a final global search for C4::Dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 06:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 05:44:54 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #2 from H?ctor Eduardo Castro Avalos --- Still can use for a better context in translation The phrase "Please, %upload% one" isn't a good phrase for translation. It is much better something like "Select the image file to upload" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 06:54:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 05:54:22 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #9 from Marc V?ron --- As of today, with following patches applied: 14960 (nso) 14969 (nqa) 14985 (nqa) 14954 (nqa) 14946 (nqa) 14998 (nqa) Rusults from: git grep 'C4::Dates': Form comment #1: C4/Dates.pm (remove) t/Dates.t (remove) debian/templates/plack.psgi (change to remove C4::Dates) misc/plack/koha.psgi (change to remove C4::Dates) Some stray C4::Dates found in: C4/Debug.pm (follow up) C4/Overdues.pm (follow up) C4/Serials.pm (follow up) circ/returns.pl (follow up) reports/borrowers_stats.pl (follow up) reports/guided_reports.pl (follow up) t/DateUtils.t (OK, it's in a comment only) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl (remove? follow up?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:17:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:17:16 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44607&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:18:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:18:01 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:26:14 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44607|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 44608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44608&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Select a bib record without a local cover image -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:45:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:45:57 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:59:14 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 07:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 06:59:16 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44608|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 44609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44609&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians A native English speaker could confirm that the wording is ok: Please select the image file to upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 08:52:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 07:52:21 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 08:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 07:53:23 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 09:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 08:15:56 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED CC| |josef.moravec at gmail.com --- Comment #29 from Josef Moravec --- *** This bug has been marked as a duplicate of bug 14811 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 09:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 08:15:56 +0000 Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811 --- Comment #12 from Josef Moravec --- *** Bug 13540 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 09:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 08:16:16 +0000 Subject: [Koha-bugs] [Bug 12142] option to automatically add a processing fee when an item is marked lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12142 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 09:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 08:30:31 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #26 from Martin Renvoize --- I'm in agreement with Jonathan that adding subs needlessly is a bad thing and therefore I do tend towards the transaction idea. More and more I'm of the opinion that data integrity lies firmly within the remit of the database. We really aught to get the constraints correct there first and not rely on lots of additional code logic all over the place doing it instead :| It's a hard thing to say, but I would prefer to have some of the foundations cleaned up rather than just adding yet more code to koha to compensate for your poor foundations. Sorry if this sounds really negative, but it's something I've felt for a while and I totally understand the want to get new and exciting features in quicker and quicker but I feel this is really leading to obfuscation and code bloat that becoming unmanageable.. where do we drawer the line? I won't complain if this is pushed.. but I don't think it's the most forward thinking solution I'm afraid. Also, as we've missed feature slush now it may be worth mentioning a few other queries: 1) Why use a dbh over using the dbic objects? (By using C4::Context to get your handle, you are already going through the pain of instantiating all the dbic class objects I believe anyway, so I don't see that using the handle directly here is of any benefit - Jonathan let me know if this is wrong?) 2) Line 928 in the final patch.. appears to have a double $$ (C4/ImportBatch.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 09:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 08:40:13 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 11:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 10:01:32 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 16:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 15:37:30 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 16:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 15:37:34 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18387|0 |1 is obsolete| | --- Comment #28 from Fr?d?ric Demians --- Created attachment 44610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44610&action=edit Bug 5572 Improve C4::AuthoritiesMarc->merge() function A new syspref AuthCleanBiblios allows to control how modified info in a modified authority are propagated to the attached biblio records. By default, the merge() behavior isn't changed. When AuthCleanBiblio is set to yes, the subfields of the authority heading are copied to biblio field. If the biblio field contains subfields that are not anymore in the authority, they are removed (this is true only for the authority subfields that are neither ignored nor hidden in the authority editor) This patch do some code refactoring: - New function C4::AuthoritiesMarc::GetBibliosByAuthid - New function C4::Biblios::GetBiblionumber($record) - Minimizing SQL queries, and caching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 16:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 15:56:25 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44563|0 |1 is obsolete| | --- Comment #13 from Zeno Tajoli --- Created attachment 44611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44611&action=edit Remove C4 Dates from files in misc/cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 16:58:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 15:58:41 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 17:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 16:57:03 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 44612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44612&action=edit Bug 14870 - Remove t/Dates.t from Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 18:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 17:04:05 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #11 from H?ctor Eduardo Castro Avalos --- Hi Marc. Please help me out with koha.psgi and plack.psgi I don't want to screw up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 18:31:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 17:31:29 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #14 from Mirko Tietgen --- Zeno: you forgot to set the bug to "signed off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 18:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 17:58:48 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- (In reply to H?ctor Eduardo Castro Avalos from comment #11) > Hi Marc. > Please help me out with koha.psgi and plack.psgi I don't want to screw up. Just remove it. It is only used for preloading it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 20:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 19:25:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jenny Dallas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |limbozel at gmail.com --- Comment #111 from Jenny Dallas --- Thought-provoking comments , Just to add my thoughts , if someone have been needing to merge PDF or PNG files , my business partner saw a service here http://www.altomerge.com and also here http://pdf.ac/5NrqIN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 21:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 20:32:01 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Zeno Tajoli --- Sorry, I forgot to change the status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 7 21:33:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 20:33:08 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44611|Remove C4 Dates from files |[SIGNED-OFF] Remove C4 description|in misc/cronjob |Dates from files in | |misc/cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 00:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Nov 2015 23:32:07 +0000 Subject: [Koha-bugs] [Bug 15125] Fix link to Kohacon 10 videos In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15125 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |FIXED --- Comment #1 from Liz Rea --- Updated the links, thanks for pointing that out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 03:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 02:35:25 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jenny Dallas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |limbozel at gmail.com --- Comment #80 from Jenny Dallas --- Invaluable writing - Apropos , if others is interested in merging of some PDF files , I encountered a tool here http://www.altomerge.com and also here http://pdf.ac/3v1u8M -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 04:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 03:30:05 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #112 from H?ctor Eduardo Castro Avalos --- (In reply to Jenny Dallas from comment #111) > Thought-provoking comments , Just to add my thoughts , if someone have been > needing to merge PDF or PNG files , my business partner saw a service here > http://www.altomerge.com and also here http://pdf.ac/5NrqIN Hi Jenny Thank you for your comment. I don't know whether I'm wrong or I misunderstand you, but the intention of this bug is about RDF to serialize Dublin Core Metadata Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 04:50:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 03:50:13 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #13 from H?ctor Eduardo Castro Avalos --- Created attachment 44613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44613&action=edit Bug 14870 - Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 05:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 04:01:15 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #14 from H?ctor Eduardo Castro Avalos --- (In reply to Tom?s Cohen Arazi from comment #12) > Just remove it. It is only used for preloading it. Done. But I place instead Koha::DateUtils, correct me if I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 06:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 05:15:55 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 44614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44614&action=edit Bug 15100 - MARC21: Display of $d for 7xx and 1xx fields should be optional Remove $d - Dates associated with a name for Main entries (1XX) and Added entries (7XX) To test: -Download and stage marc records with $d subfield for 1XX and 7XX or download from this attchment -Reindex zebra -Search whichever or all records -Notice that subfield $d is present in all 1XX and 7XX -Apply patch -Search again and see that the subfield $d is not shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 06:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 05:16:28 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 06:17:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 05:17:32 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 06:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 05:28:34 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44614|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44615&action=edit Bug 15100 - MARC21: Display of $d for 7xx and 1xx fields should be optional Remove $d - Dates associated with a name for Main entries (1XX) and Added entries (7XX) To test: -Download and stage marc records with $d subfield for 1XX and 7XX or download from this attchment -Reindex zebra -Search whichever or all records -Notice that subfield $d is present in all 1XX and 7XX in results and detail record page -Apply patch -Search again and see that the subfield $d is not shown in results and detail record page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 07:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 06:03:34 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 44616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44616&action=edit Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Apply on top bug 15100 -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type) in both OPAC and Intranet for records detail pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 07:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 06:04:53 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Depends on| |15100 Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 07:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 06:04:53 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15102 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 [Bug 15102] Fix capitalization for some strings on XSLT detail pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 10:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 09:05:37 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #13 from Marc V?ron --- Created attachment 44617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44617&action=edit Bug 14969: (followup) Remove C4::Dates from C4/Serials.pm This is a follow-up removing stray C4::Dates The patch removes C4::Dates from file C4/Serials.pm. To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 10:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 09:15:39 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44617|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 44618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44618&action=edit Bug 14969: (followup) Remove C4::Dates from C4/Serials.pm This is a follow-up removing stray C4::Dates The patch removes C4::Dates from file C4/Serials.pm. To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 10:17:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 09:17:45 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #15 from Marc V?ron --- (In reply to Marc V?ron from comment #9) (...) > Some stray C4::Dates found in: (...) > C4/Serials.pm (follow up) (...) Fixed in follow up to Bug 14969 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 10:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 09:21:02 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #16 from Marc V?ron --- I will fix some remaining stray C4::Dates in follow-ups and/or a separate bug. Some stray C4::Dates found in: C4/Debug.pm (follow up) C4/Overdues.pm (follow up) circ/returns.pl (follow up) reports/borrowers_stats.pl (follow up) reports/guided_reports.pl (follow up) t/DateUtils.t (OK, it's in a comment only) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl (remove? follow up?) Switching to "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 17:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 16:10:58 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 18:29:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 17:29:23 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #113 from Katrin Fischer --- Hi Hector and others, I have marked the last 2 comments 'private' as I think the links in them are spam. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 19:07:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 18:07:28 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Vassilis, thx for your contribution! Can you please attach a patch file to this bug? The Koha community is not using github pull requests in its development workflow. Some additional information can be found on the wiki: http://wiki.koha-community.org/wiki/Development_workflow http://wiki.koha-community.org/wiki/SubmitingAPatch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 19:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 18:21:49 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44619&action=edit Bug 15102-(follow-up)Fix capitalization of multiples fields on XSLT Intranet/OPAC To test: -Search records with 508, 264Ind=4, 246, 856, and 008LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Reindex zebra if you stage some new records (avoid if not) -Search again and get notice about the capitalization following Koha coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 19:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 18:32:21 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #16 from Joonas Kylm?l? --- (In reply to M. Tompsett from comment #12) > Eyeballs well. Have yet to test it. I can say also that the code looks good. Haven't ran the scripts thoroughly, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 19:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 18:33:21 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #114 from H?ctor Eduardo Castro Avalos --- (In reply to Katrin Fischer from comment #113) > I have marked the last 2 comments 'private' as I think the links in them are > spam. Thanks Katrin, I did not realize it was spam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 20:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 19:16:20 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44619|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44620&action=edit Bug 15102-(follow-up)Fix capitalization of multiples fields on XSLT Intranet/OPAC To test: -Search records with 508, 264Ind=4, 246, 856, and 008LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Reindex zebra if you stage some new records (avoid if not) -Search again and get notice about the capitalization following Koha coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 20:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 19:24:55 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Holdings or Item information is still in capitalization (Visual Materials, Non Fiction, Continuing Resources) but this need changes in SQL statements. I think IMHO this need to file another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 20:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 19:26:05 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #27 from Martin Renvoize --- s/your poor foundations/our poor foundations/ s/that becoming/that are becoming/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 20:39:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 19:39:30 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #11 from Marc V?ron --- Created attachment 44621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44621&action=edit Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 21:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 20:02:12 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 21:35:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 20:35:42 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:12:33 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #17 from Marc V?ron --- C4/Overdues.pm fixed in followup in Bug 14985 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:30:53 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #18 from Marc V?ron --- Created attachment 44623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44623&action=edit Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:34:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:34:33 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Some tests are failing: perl xt/tt_valid.t 1..3 not ok 1 - TT syntax: not using TT directive within HTML tag # Failed test 'TT syntax: not using TT directive within HTML tag' # at xt/tt_valid.t line 91. # Files list: # opac-tmpl/bootstrap/en/modules/opac-detail.tt: 347, 349, 518, 1276, 1278 ok 2 - tag with id and class attributes ok 3 - Token received same as original put on stack # Looks like you failed 1 test of 3. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:36:00 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #15 from Katrin Fischer --- Changing this to enh - it's a good one, but not a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:41:45 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Interestingly, the test did fail the first time for me as well, and always after that: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. 3/18 # Failed test 'filter takes report id' # at t/db_dependent/Reports_Guided.t line 70. # got: '2' # expected: '1' # Looks like you failed 1 test of 18. Test Summary Report ------------------- t/db_dependent/Reports_Guided.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=18, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.09 cusr 0.05 csys = 1.17 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:45:48 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #7 from Katrin Fischer --- That should have read: ... and passed always after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:57:47 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 22:57:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 21:57:50 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44248|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 44624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44624&action=edit [PASSED QA] Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 23:00:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 22:00:02 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 23:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 22:30:54 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #19 from Marc V?ron --- Created attachment 44625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44625&action=edit Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 23:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 22:36:27 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #20 from Marc V?ron --- Created attachment 44626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44626&action=edit Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 8 23:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Nov 2015 22:55:10 +0000 Subject: [Koha-bugs] [Bug 15152] Try and make Guided Reports related tests pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #7) > That should have read: ... and passed always after that. Yeah, jenkins loads a fresh 3.20.0 db each time, that's why it always fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 03:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 02:07:40 +0000 Subject: [Koha-bugs] [Bug 15155] New: Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Bug ID: 15155 Summary: Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fabreupeixoto at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hello everyone? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 03:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 02:09:58 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Francisco Peixoto changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal Priority|P5 - low |P3 --- Comment #1 from Francisco Peixoto --- Hi Everyone. This software error message come up when performing items checkin? Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 Thank very much in advance for any help. Kind regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 03:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 02:12:59 +0000 Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 --- Comment #3 from Francisco Peixoto --- DO we have any changes on this on Koha 3.20? Thanks! Kind regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 06:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 05:23:50 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43548|0 |1 is obsolete| | Attachment #43549|0 |1 is obsolete| | Attachment #43586|0 |1 is obsolete| | Attachment #43612|0 |1 is obsolete| | --- Comment #115 from H?ctor Eduardo Castro Avalos --- Created attachment 44627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44627&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. NOTE: This new feature implement the XSLT transformation for OAI-DC, SRW-DC and RDF-DC Test plan --------------- 1) Download Dublin Core file from record detail page. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 06:31:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 05:31:34 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #116 from H?ctor Eduardo Castro Avalos --- Hi Fr?d?ric and all devs This is the new patch using XSLTs for OAIDC, SRWDC, and RDFDC. The bug is not complete yet! Needs Unit test, changes to opac.cs (I need to install LESS) and maybe add 264 field to XSLTs. Fr?d?ric, please test it and QAing and tell me how looks this wheter i'm wrong or I go in the right way. Thanks Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 06:35:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 05:35:53 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #117 from H?ctor Eduardo Castro Avalos --- I forgot it, test with MARC21, UNIMARC and NORMARC, this patch takes in consideration syspref marcflavour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 06:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 05:48:31 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44610|0 |1 is obsolete| | --- Comment #29 from Fr?d?ric Demians --- Created attachment 44628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44628&action=edit Bug 5572 Improve C4::AuthoritiesMarc->merge() function A new syspref AuthCleanBiblios controls how modified info in a modified authority are propagated to the attached biblio records. By default, the merge() behavior isn't changed. When AuthCleanBiblio is set to yes, the subfields of the authority heading are copied to biblio field. If the biblio field contains subfields that are not anymore in the authority, they are removed (this is true only for the authority subfields that are neither ignored nor hidden in the authority editor) This patch does some code refactoring: - New function C4::AuthoritiesMarc::GetBibliosByAuthid - New function C4::Biblios::GetBiblionumber($record) - Minimizing SQL queries, and caching - Code cleaning + doc http://bugs.koha-community.org/show_bug.cgi?id=1572 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 07:44:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 06:44:29 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #118 from Fr?d?ric Demians --- > Fr?d?ric, please test it and QAing and tell me how looks this wheter i'm > wrong or I go in the right way. Seems good to me. I've tested: it works in intra interface, but it doesn't at OPAC (I will attach a screen capture) ; the dialog box seems mixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 07:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 06:45:44 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #119 from Fr?d?ric Demians --- Created attachment 44629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44629&action=edit OPAC dialog box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 07:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 06:47:32 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #120 from Fr?d?ric Demians --- Reading the code, I'd also suggest to simplify the way you construct the XSL filename in marc2dcxml: my $xsl = C4::Context->config('intrahtdocs') . '/prog/en/xslt/slim2' . uc $format . '.xsl'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 09:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 08:39:43 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 09:55:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 08:55:07 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 10:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 09:56:24 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #3 from Vassilis Kanellopoulos --- Created attachment 44630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44630&action=edit add homebranch of borrowed items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 10:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 09:57:55 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact at kanellov.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:00:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:00:30 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- This is not what Katrin is asking for. Some libraries may want to display author dates, some others may not want. Your patch just remove $d. The idea is to display the dates in an identified html in order to allow libraries to hide author dates easily with css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:20:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:20:16 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #4 from Katrin Fischer --- Thx Vassilis! Once the patch file is attached, you can switch the bug status to "Needs Signoff". This way it shows up on the queues for things to be tested. One tiny thing about your patch: + Item Homebranch We only have the first term in capitals, also please check the term we use in the normal item view or in the checkouts list for comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:30:15 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk --- Comment #10 from sally.healey at cheshirewestandchester.gov.uk --- (In reply to Joonas Kylm?l? from comment #8) > (In reply to Katrin Fischer from comment #7) > > I think this could be something for the mailing lists - wonder if people are > > aware of current behaviour and if someone can explain "why". > > Now it is: https://lists.katipo.co.nz/pipermail/koha/2015-August/043527.html > :) This question was asked again: https://lists.katipo.co.nz/pipermail/koha/2015-November/044052.html We would be extremely keen to see a behaviour change, for the reasons outlined on the e-mail list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:39:26 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41951|0 |1 is obsolete| | --- Comment #31 from Julian Maurice --- Created attachment 44631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44631&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:39:36 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41952|0 |1 is obsolete| | --- Comment #32 from Julian Maurice --- Created attachment 44632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44632&action=edit Bug 11999: Check for age restriction in CanBookBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:39:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:39:56 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:41:48 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- Could you submit a single patch rather than two? This would help the proof reading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:44:14 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to fund owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sent an email to budget |Sent an email to fund owner |owner when a suggestion can |when a suggestion can be |be treated |treated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:44:25 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to the fund owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sent an email to fund owner |Sent an email to the fund |when a suggestion can be |owner when a suggestion can |treated |be treated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:48:36 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35900|0 |1 is obsolete| | --- Comment #81 from Julian Maurice --- Created attachment 44633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44633&action=edit [PASSED QA] Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:48:58 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35901|0 |1 is obsolete| | --- Comment #82 from Julian Maurice --- Created attachment 44634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44634&action=edit [PASSED QA] Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:49:14 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35902|0 |1 is obsolete| | --- Comment #83 from Julian Maurice --- Created attachment 44635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44635&action=edit [PASSED QA] Bug 8064: Fix issues with control fields and non-repeatable check Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:49:30 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35903|0 |1 is obsolete| | --- Comment #84 from Julian Maurice --- Created attachment 44636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44636&action=edit [PASSED QA] Bug 8064: Little fix for 003, 005, 008 in MARC21 Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:49:45 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35904|0 |1 is obsolete| | --- Comment #85 from Julian Maurice --- Created attachment 44637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44637&action=edit [PASSED QA] Bug 8064: Fix unit tests for createMergeHash Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:50:02 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35905|0 |1 is obsolete| | --- Comment #86 from Julian Maurice --- Created attachment 44638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44638&action=edit [PASSED QA] Bug 8064 [QA Followup] - Remove trailing whitespace Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:50:29 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:51:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:51:08 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #87 from Julian Maurice --- updatedatabase.pl entry moved into atomicupdate/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:59:23 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40647|0 |1 is obsolete| | --- Comment #42 from Julian Maurice --- Created attachment 44639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44639&action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Rebased on master updatedatabase entry moved into atomicupdate/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 11:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 10:59:48 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:00:08 +0000 Subject: [Koha-bugs] [Bug 15156] New: Get all Borrowers with pending/unpaid fines/accountlines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Bug ID: 15156 Summary: Get all Borrowers with pending/unpaid fines/accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:00:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:00:41 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 44640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44640&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:00:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:00:54 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:01:17 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:01:20 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44546|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 44641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44641&action=edit Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:02:32 +0000 Subject: [Koha-bugs] [Bug 15157] New: Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Bug ID: 15157 Summary: Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If your library wants to debar all Borrower who haven't paid their fines by the end of the year, this script will do that trick :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:02:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:02:46 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15156 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:02:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:02:46 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15157 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:18:46 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44640|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 44642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44642&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:19:47 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 44643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44643&action=edit Bug 15157 - Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines If your library wants to debar all Borrower who haven't paid their fines by the end of the year, this script will do that trick :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:19:58 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:20:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:20:15 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti --- Failing QA because of no integration tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:25:41 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44630|0 |1 is obsolete| | --- Comment #5 from Vassilis Kanellopoulos --- Created attachment 44644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44644&action=edit add homebranch of borrowed items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:28:38 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Vassilis Kanellopoulos --- Thanks Kartin. I've changed table heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:41:35 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 44645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44645&action=edit Bug 15157 - Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 12:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 11:49:17 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin at bugs.koha-community. | |org.xinxidi.net Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 13:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 12:49:23 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44643|0 |1 is obsolete| | Attachment #44645|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 44646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44646&action=edit Bug 15157 - Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines If your library wants to debar all Borrower who haven't paid their fines by the end of the year, this script will do that trick :) You can give the message from a file if the cronjob runner doesn't deal with quotes, or as a command-line parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 14:47:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 13:47:19 +0000 Subject: [Koha-bugs] [Bug 15158] New: t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Bug ID: 15158 Summary: t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: gmcharlt at gmail.com t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null [for Statement "..."] at /srv/jenkins/workspace/Koha_Master_U14/C4/Items.pm line 2205. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 14:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 13:47:52 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 --- Comment #1 from Julian Maurice --- Created attachment 44647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44647&action=edit Bug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t create_biblio was returning biblioitemnumber instead of biblionumber. This can cause problems when biblionumber and biblioitemnumber are not the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 14:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 13:48:01 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:11:06 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to the fund owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #49 from Katrin Fischer --- The sample notice subject says "budget owner" - but I think it should be "fund owner"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:16:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:16:21 +0000 Subject: [Koha-bugs] [Bug 15159] New: TestBuilder behaviour on AI values should be tested Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Bug ID: 15159 Summary: TestBuilder behaviour on AI values should be tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com Currently, there is no test on TestBuilder's handling of AI values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:16:26 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:20:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:20:30 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:20:33 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 44648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44648&action=edit Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:24:43 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:24:46 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44647|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 44649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44649&action=edit Bug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t create_biblio was returning biblioitemnumber instead of biblionumber. This can cause problems when biblionumber and biblioitemnumber are not the same. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:35:58 +0000 Subject: [Koha-bugs] [Bug 15160] New: GetTopIssues.t should create random data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Bug ID: 15160 Summary: GetTopIssues.t should create random data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com GetTopIssues.t currently creates fixed-value objects on the DB. If the id's it tries to use already exist on the DB it would fail. TestBuilder should take care of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:42:27 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:42:30 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 44650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44650&action=edit Bug 15160: GetTopIssues.t should create random data This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it creates its own data with random values. It does so by replacing (legacy) SQL inserts and fixed value data inserting by TestBuilder generated data. There is no expected behaviour change. To test: - Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST'); - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => FAIL: The insert line fails - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => SUCCESS: tests pass due to random data usage. - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:50:22 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Why is this marked as an enhancement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:56:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:56:00 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39129|0 |1 is obsolete| | Attachment #39130|0 |1 is obsolete| | Attachment #39131|0 |1 is obsolete| | --- Comment #96 from Julian Maurice --- Created attachment 44651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44651&action=edit Bug 7683: Cataloguing statistics wizard improvements Squash of 3 first patches, rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:56:22 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39132|0 |1 is obsolete| | --- Comment #97 from Julian Maurice --- Created attachment 44652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44652&action=edit Bug 7683: Remove dead code about dewey and lccn filters Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:56:38 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39133|0 |1 is obsolete| | --- Comment #98 from Julian Maurice --- Created attachment 44653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44653&action=edit Bug 7683: Fix a shift in date filter indexes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:56:56 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41829|0 |1 is obsolete| | --- Comment #99 from Julian Maurice --- Created attachment 44654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44654&action=edit Bug 7683: Catalog statistics wizard: QA fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 15:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 14:57:04 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #100 from Julian Maurice --- Created attachment 44655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44655&action=edit Bug 7683: Relabel "acquired date" and "removed date" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:03:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:03:01 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #101 from Julian Maurice --- (In reply to Katrin Fischer from comment #95) > 1) Hm, something strange, I see > Removed date in the code, but it doesn't show up on the form for > me? > I was looking for it, as I wanted to suggest a change: Date deleted (item). It shows up only when you select "Count deleted items" for "Cell value" "Removed date" changed by the last patch > > 2) Similarly, I would use "Date acquired (item)" for "Acquired date". > Because someone might question if this is about the record or the item and > it's what the field in the item is labelled. "Acquired date" changed by the last patch > > 3) Can you please update and post the initial commit message? For example it > still lists a items.statisticvalue that doesn't exist. So a bit hard to see > what actually happens now as this has been going back and forth a bit. Maybe > we should also upate the actual commit message? I squashed the 3 first commits and removed reference to items.statisticvalue in the initial commit message. Is that ok ? > > X) the ... characters in the second line seems to belong to a lccn related > feature and has no label at all :( But this is an old problem, so out of > scope here. I don't see what you are talking about, lccn related feature should be gone thanks to patch "Remove dead code about dewey and lccn filters" Where are the "..." characters ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:08:31 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:09:41 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #102 from Katrin Fischer --- I meant the second line in the report - a pull down labelled characters in hte second column. I have no idea what it does - it's referred to as cotedigits(?) in the HTML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:11:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:11:59 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #1 from Martin Persson --- Created attachment 44656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44656&action=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:15:41 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:49:17 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #70 from Julian Maurice --- 3) For the tests to pass you need to run misc/devel/update_dbix_class_files.pl after updatedatabase.pl 4) I don't really know what to do here... Is there another modal window that we can take as an example ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:51:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:51:29 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:51:32 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44649|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 44657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44657&action=edit Bug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t create_biblio was returning biblioitemnumber instead of biblionumber. This can cause problems when biblionumber and biblioitemnumber are not the same. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:52:29 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:52:55 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:53:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:53:21 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:53:43 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 16:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 15:54:11 +0000 Subject: [Koha-bugs] [Bug 15158] t/db_dependent/Circulation/GetTopIssues.t is failing in Jenkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15158 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:00:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:00:46 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #71 from Katrin Fischer --- 4) I think using the standard font and font-size would already help - it looked very different than the page in the background to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:02:29 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44627|0 |1 is obsolete| | --- Comment #121 from H?ctor Eduardo Castro Avalos --- Created attachment 44658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44658&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. NOTE: This new feature implement the XSLT transformation for OAI-DC, SRW-DC and RDF-DC Test plan --------------- 1) Download Dublin Core file from record detail page. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) Test with all marc flavours. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:04:37 +0000 Subject: [Koha-bugs] [Bug 14391] Granular permissions for the administration module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|admin permissions |Granular permissions for | |the administration module CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:22:28 +0000 Subject: [Koha-bugs] [Bug 15161] New: Sorting by Title does not include volume/part information from $p and $n Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15161 Bug ID: 15161 Summary: Sorting by Title does not include volume/part information from $p and $n Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When sorting by title in the OPAC/staff interface multiple parts/volumes don't sort correctly or are sorted nonsensically. I am not sure if it's possible to sort on multiple subfields, but it seems like only $a is included. $p and $n are currently not included in a Title:s index - but have to investigate more to see if that woudl fix the problem. Help appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:24:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:24:14 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44658|0 |1 is obsolete| | --- Comment #122 from H?ctor Eduardo Castro Avalos --- Created attachment 44659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44659&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. NOTE: This new feature implement the XSLT transformation for OAI-DC, SRW-DC and RDF-DC Test plan --------------- 1) Download Dublin Core file from record detail page. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) Test with all marc flavours. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:28:33 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #123 from H?ctor Eduardo Castro Avalos --- Created attachment 44660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44660&action=edit Bug 13642 - Changes LESS opac.less > to opac.css Changes LESS opac.less > to opac.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 17:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 16:45:45 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #124 from Fr?d?ric Demians --- Comment on attachment 44659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44659 Bug 13642 [ENH] Adding new features for Dublin Core metadata Review of attachment 44659: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13642&attachment=44659) ----------------------------------------------------------------- Otherwise it works for me both pro/opac interface, with a MARC21. I will test later with an UNIMARC catalog. ::: C4/Record.pm @@ +293,5 @@ > + carp "\t". $warn; > + }; > + } elsif ( $record =~ /^MARC::Record/ ) { # if OK makes xslt transformation > + my $xslt_engine = Koha::XSLT_Handler->new; > + if ( $format eq 'oaidc' || 'srwdc' || 'rdfdc' ) { This test will always be true. I don't think it's what you want. You may want: if ( $format =~ /oaidc|srwdc|rdfdc/ ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:09:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:09:01 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #125 from H?ctor Eduardo Castro Avalos --- Created attachment 44661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44661&action=edit Bug 13642 - Add 264 field to MARC21*DC.xsl Modify MARC21*DC.xsl to add RDA 264 field To test: -Copy from LOC z39.50 the Maxwell's handbook for RDA (ISBN 9780838911723) -Look the field 264 -In datail for the record, export or save to Dublin Core (the three options) -Open the xml generated, notice that and are not present -Apply this patch -Reload and export again -Open the xml, you will see the tags publisher and date taken from 264 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:20:19 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #126 from H?ctor Eduardo Castro Avalos --- Created attachment 44662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44662&action=edit Bug 13642 (follow-up) Adding new features for Dublin Core metadata Correct if clasue according with comment 124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:20:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:46:28 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43107|0 |1 is obsolete| | Attachment #43108|0 |1 is obsolete| | Attachment #43109|0 |1 is obsolete| | --- Comment #53 from Nick Clemens --- Created attachment 44663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44663&action=edit [3.18.x rewrite] Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:53:56 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42997|0 |1 is obsolete| | --- Comment #35 from Barton Chittenden --- Created attachment 44664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44664&action=edit Bug 14402: - QA Followup Added notes to usage in misc/cronjobs/cleanup_database.pl that --fees DAYS requires DAYS to be greater than or equal to 1. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 18:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 17:55:54 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44629|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:01:43 +0000 Subject: [Koha-bugs] [Bug 15089] koha-dump set permissions correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15089 Muri Nicanor changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Muri Nicanor --- ah, oke, good to know. i use rsync to backup those files to another server (logging in using the webserver user) but i can find another way to get the backups or set the permission ; ) marking as resolved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:04:13 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #127 from Fr?d?ric Demians --- It works in intra/opac. But in intra, it only works on 'Normal' detail page, it doesn't in ISBD/MARC/Item tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:05:02 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:05:28 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:13:59 +0000 Subject: [Koha-bugs] [Bug 15162] New: Add for Unimarc transformation to new metadata formats Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Bug ID: 15162 Summary: Add for Unimarc transformation to new metadata formats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org MARC21/NORMARC have XSL files to transform marcxml biblio records into various metadata formats: mods, mod3, oai-dc, rdfdc, rss2, srw_dc. Those XSL are located in 'intranet-tmpl/prog/en/xslt' directory. For Unimarc, there is just one XSL to transform record into OAI-DC format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:16:20 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #128 from Fr?d?ric Demians --- For Unimarc, it will only work for OAI-DC format. XSL for RDF-DC and SRW-DC format are missing. See bug 15162. In my opinion, it shouldn't prevent accepting this enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:16:35 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15162 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:16:35 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:16:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:16:51 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Closeing and reopening a |Closing and reopening a |basket should not alter |basket should not alter |status of completed orders |status of completed orders CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:43:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:43:33 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #88 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 19:59:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 18:59:03 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 20:57:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 19:57:15 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41627|0 |1 is obsolete| | --- Comment #29 from Tom?s Cohen Arazi --- Created attachment 44665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44665&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 20:57:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 19:57:26 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41628|0 |1 is obsolete| | --- Comment #30 from Tom?s Cohen Arazi --- Created attachment 44666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44666&action=edit Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 20:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 19:57:36 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41629|0 |1 is obsolete| | --- Comment #31 from Tom?s Cohen Arazi --- Created attachment 44667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44667&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 20:57:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 19:57:45 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42177|0 |1 is obsolete| | --- Comment #32 from Tom?s Cohen Arazi --- Created attachment 44668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44668&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:22:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:22:08 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #33 from Tom?s Cohen Arazi --- Patches rebased to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:24:23 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Bug 13554 depends on bug 13275, which changed state. Bug 13275 Summary: (OMNIBUS) Tests on t/ should pass without a DB http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:24:23 +0000 Subject: [Koha-bugs] [Bug 13275] (OMNIBUS) Tests on t/ should pass without a DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15151 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Tom?s Cohen Arazi --- Bug 15151 was the last one Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:24:23 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13275 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275 [Bug 13275] (OMNIBUS) Tests on t/ should pass without a DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:25:44 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Try and make Guided Reports |Refactor Guided Reports |related tests pass |related tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 21:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 20:26:12 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #9 from Tom?s Cohen Arazi --- Can we have this tests split so non-db_dependent tests are in t/? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 22:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 21:02:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44662|0 |1 is obsolete| | --- Comment #129 from H?ctor Eduardo Castro Avalos --- Created attachment 44669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44669&action=edit Bug 13642 (follow-up) Adding new features for Dublin Core metadata This patch fix the following: -Correct if clasue according with comment 124 (C4::Record::marc2dcxml) -Move modal from detail.tt to cat-toolbar.inc to work with Normal|MARC|ISBD|Items view tabs. -Add css style to delelete border (in modal) in h3 for "exportLabelexportModal_" id in moredetail.tt this because local style for h3 tag. To test: -Apply patch 15162 on top -Apply patches -Follow the test plan of previous commits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 22:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 21:06:13 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15162 --- Comment #130 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #128) > For Unimarc, it will only work for OAI-DC format. XSL for RDF-DC and SRW-DC > format are missing. See bug 15162. In my opinion, it shouldn't prevent > accepting this enhancement. Hi Fr?d?ric I will try to attach a patch for bug 15162 as soon as posible to apply on top of this one. Regards Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 [Bug 15162] Add for Unimarc transformation to new metadata formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 22:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 21:06:13 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 [Bug 13642] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 23:03:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 22:03:49 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 44670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44670&action=edit Bug 15162 - Add for Unimarc transformation to new metadata formats This patch add: -UNIMARCslim2SRWDC.xsl -UNIMARCslim2RDFDC.xsl To test: -In UNIMARC envarioment -Apply patch -Apply patch 13642 -Follow test plan for bug 13642 -Check for any data loss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 23:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 22:04:48 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hector.hecaxmmx at gmail.com Assignee|gmcharlt at gmail.com |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 23:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 22:11:51 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 23:11:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 22:11:53 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #7 from Nick Clemens --- Created attachment 44671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44671&action=edit Add homebranch of borrowed items to patron accounts tab http://bugs.koha-community.org/show_bug.cgi?id=15136 Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 9 23:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 22:14:35 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Hi Vassilis, I signed off, works as expected. I added a test plan to the commit message, you should always include one with the patch submission to make testing easier (and so you can be sure that you and the tester agree on what the results should be :-) ) -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 00:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 23:12:52 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #131 from H?ctor Eduardo Castro Avalos --- Created attachment 44672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44672&action=edit Bug 13642 - Add Unit test for C4::Record::marc2dcxml Add Unit test for C4::Record::marc2dcxml To test: Prove t/db_dependent/Record.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 00:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Nov 2015 23:27:02 +0000 Subject: [Koha-bugs] [Bug 15163] New: Patron attributes with branch limiits are not saved when invisible Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Bug ID: 15163 Summary: Patron attributes with branch limiits are not saved when invisible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, hbraum at nekls.org, kyle.m.hall at gmail.com Because only the patron attributes that are visible are saved when editing a patron, any attributes that are hidden from the member entry screen by a branch limitation will be erased when saving. This could be solved one of two ways: a) Show all extended attributes when editing or b) Only delete the borrower attributes that are not limited or are visible at the current branch as the first step in C4::Members::Attributes::SetBorrowerAttributes. (Marking critical because data is lost.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 01:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 00:17:03 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #9 from Vassilis Kanellopoulos --- (In reply to Nick Clemens from comment #8) > Hi Vassilis, > > I signed off, works as expected. I added a test plan to the commit message, > you should always include one with the patch submission to make testing > easier > (and so you can be sure that you and the tester agree on what the results > should be :-) ) > > -Nick Hi Nick, Thanks for the advice. It's my first contribution to Koha and I'm still learning the process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:24:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:24:25 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44616|0 |1 is obsolete| | Attachment #44620|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 44673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44673&action=edit Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:29:55 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15100 | --- Comment #7 from H?ctor Eduardo Castro Avalos --- HI Fr?d?ric The two commits squashed Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:29:55 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15102 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 [Bug 15102] Fix capitalization for some strings on XSLT detail pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:45:39 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #3) > This is not what Katrin is asking for. Some libraries may want to display > author dates, some others may not want. Your patch just remove $d. The idea > is to display the dates in an identified html in order to allow > libraries to hide author dates easily with css. Does this need a syspref? or how to control the class to hide or show the span tag? Please explain to me? Exist information about or one bug to take as example Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:47:44 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #4 from Robin Sheat --- $ ./koha-dump test ./koha-dump: 87: ./koha-dump: Syntax error: "fi" unexpected (expecting "then") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 03:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 02:51:26 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #5 from Robin Sheat --- $ sudo ./koha-dump --exclude-indexes test Dumping Koha site test: * DB to /var/spool/koha/test/test-2015-11-10.sql.gz * configs, logs to /var/spool/koha/test/test-2015-11-10.tar.gz tar: Substituting `.' for empty member name tar: : Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 04:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 03:18:35 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #6 from Robin Sheat --- Created attachment 44674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44674&action=edit Bug 14532 - fix syntax error in script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 04:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 03:18:46 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #7 from Robin Sheat --- Created attachment 44675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44675&action=edit Bug 14532: fixed the "empty member" problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 04:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 03:21:47 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44675|0 |1 is obsolete| | --- Comment #8 from Robin Sheat --- Created attachment 44676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44676&action=edit Bug 14532: fixed the "empty member" problem PS: thanks to Olly Betts for knowing weird bash constuctions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 07:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 06:02:40 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #244 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #243) > Patches pushed to master. > > Thanks everyone, specially Julian and Martin! > Things will get interesting for sure :-D Whoa! You can say that again! Is there going to be some documentation for using and developing the REST APIs? Super intrigued by this!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 07:06:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 06:06:57 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 07:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 06:11:43 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #132 from David Cook --- Not sure about the state of this patch, but I just wanted to say that I agree with Fr?d?ric: "It's far beyond the scope of this patch. Open a new bug if you want, and name it Semantic-Koha, or Sekoa." I think it would be interesting to be able to publish any record using RDF, and maybe even set up a SPARQL endpoint. I noticed that in DSpace 5.0 or 6.0 they've added support for publishing their records using RDF. However, I think that's outside the scope of this bug. It would make sense as its own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 07:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 06:37:28 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #133 from H?ctor Eduardo Castro Avalos --- Created attachment 44677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44677&action=edit Bug 13642 - Add NORMARCslim2RDFDC.xsl and NORMARCslim2SRWDC.xsl Add missing xsls for NORMARC flavour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 08:02:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 07:02:50 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 08:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 07:02:53 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44673|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 44678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44678&action=edit Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 08:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 07:09:28 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 --- Comment #5 from Fr?d?ric Demians --- > Does this need a syspref? or how to control the class to hide or show the > span tag? No syspref. You'd just need to enclose 100/70x date subfield into html with a class identifying it precisely. For example: 1802-1885 You have an example with author $4 subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 08:38:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 07:38:01 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #134 from Fr?d?ric Demians --- (In reply to David Cook from comment #132) > I think it would be interesting to be able to publish any record using RDF, > and maybe even set up a SPARQL endpoint. I noticed that in DSpace 5.0 or 6.0 > they've added support for publishing their records using RDF. This is a huge subject. A very interesting and promising one. I'd be pleased to be included in a discussion on this matter, whatever the form it takes: bug umbrella, task force... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 08:41:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 07:41:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #135 from Fr?d?ric Demians --- H?ctor, would you allow me to simplify this bug? I propose to just keep 3 patches attached to this one (and sign them): the enhancement, the UT & the less to css conversion. And I would open two new patches: (1) 264 field, (2) NORMARC new XSL. It won't touch the patches themselves nor your credit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:14:43 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #10 from Jonathan Druart --- I need someone to send me a DB (or a way to create it) where I can reproduce the failure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:26:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:26:23 +0000 Subject: [Koha-bugs] [Bug 15164] New: Allow editing of the invoice number after initial saving Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164 Bug ID: 15164 Summary: Allow editing of the invoice number after initial saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When you notice a typo in your invoice number after finishing with the receiving process, the only way to correct it right now is in the database - or by undoing all the steps and starting over. It would be nice if the invoice number could be edited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:35:00 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:35:02 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44670|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44679&action=edit Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:49:34 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44678|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 44680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44680&action=edit Bug 15102 - Fix capitalization for some strings on XSLT detail pages To test: -Search records with 336, 337, 338, 700$i, and 7XXind=2 -Search records with 508, 264Ind=4, 246, 856, and LDR/6 and LDR/7 (BK, VM, CR, CF) -Notice the capitalization (Contained Works, Related Works, Media Type, Content Type, and Carrier Type, Production Credits, Copyright Date, Other Title, Online Access, Continuing Resource, Mixed Materials, Computer File, Visual Material) in both OPAC and Intranet for records detail pages and results pages -Apply this patch -Search again and get notice about the capitalization following Koha coding guidelines Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:49:32 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:51:35 +0000 Subject: [Koha-bugs] [Bug 15165] New: REST API routes to list, edit and pay borrower's accountlines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug ID: 15165 Summary: REST API routes to list, edit and pay borrower's accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org Add routes on RESTful API to: - list all accountlines, - list accountlines for a specific borrower, - edit accountlines, - pay accountlines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:51:56 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:52:02 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 09:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 08:53:25 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #44644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:01:24 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:01:27 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44671|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 44681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44681&action=edit Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:02:08 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #11 from Jonathan Druart --- Created attachment 44682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44682&action=edit Bug 15136: Use TT plugin to display the branch's name Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:03:12 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:03:14 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44650|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44683&action=edit Bug 15160: GetTopIssues.t should create random data This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it creates its own data with random values. It does so by replacing (legacy) SQL inserts and fixed value data inserting by TestBuilder generated data. There is no expected behaviour change. To test: - Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST'); - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => FAIL: The insert line fails - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => SUCCESS: tests pass due to random data usage. - Sign off Signed-off-by: Frederic Demians Test plan produces the expected result, failing, then OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:03:34 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15165 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 [Bug 15165] REST API routes to list, edit and pay borrower's accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:03:34 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15126 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:07:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:07:33 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:07:36 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42405|0 |1 is obsolete| | Attachment #44641|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 44684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44684&action=edit Bug 14575 - OPACURLOpenInNewWindow should apply to item-level urls too This patch applies the OPACURLOpenInNewWindow system preference to item-level urls (in addition to the pre-existing bib-level url handling). _TEST PLAN_ Before applying: 1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url 2) Note that the current tab changes to that url 3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url 4) Note that the current tab changes to that url Apply the patch. After applying: 5) Click on an item-level url 6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow should be set to "do") 7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url 8) Note that the url opens in the current tab 9) Repeat the above steps 5-8 alternating "TrackClicks" between "Don't track" and either "Track" or "Track anonymously". Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:07:39 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 --- Comment #12 from Jonathan Druart --- Created attachment 44685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44685&action=edit Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:07:43 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 --- Comment #13 from Jonathan Druart --- Created attachment 44686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44686&action=edit Bug 14575: Fix typo in opac-basket.tt No more typo in the codebase. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:08:13 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 --- Comment #14 from Jonathan Druart --- I have reduced the complexity of my followup, no need for another pair of eyes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:15:16 +0000 Subject: [Koha-bugs] [Bug 15038] Move BatchCheckoutsValidCategories into the categories table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:35:02 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- > This patch adds the user interaction menu to the top of the batch checkout > page, > places focus on the barcode text field and adds a discrete shortcut link for > printing receipts. OK for top menu which is very useful, but I don't understand the bottom link usage. It's confusing. Could you explain? When you arrive on the Batch checkout page, the link is there while you haven't yet done any checkout. The link won't work. You do some checkouts. You arrive on a page displaying the checkout items. The link isn't there anymore, but the top menu is there if you want to print a receipt. You can go back to the batch checkout page. Then the shortcut link works, but it seems disconnected from the previously done batch checkout... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:47:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:47:36 +0000 Subject: [Koha-bugs] [Bug 15147] Blocking Calls in Patron Search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15147 --- Comment #2 from Martin Renvoize --- We're doing some further investigation here at PTFS Europe. We've found that none of our customers do a search and then alter the search with the filters on the left.. they usually use the top box again.. "It's up front and centre". I'd put money on most libraries doing the same ;) It's the call to members.pl followed by svc/search I was not happy about. That's the blocking sequence, there are no further calls to /search.. but any secondary search (executed from the top bar as is nearly always the case) results in that same blocking sequence. (Meaning you have the startup cost of cgi twice, the startup cost of DBIx::Class twice). Regarding caching, the Patron Search Results page is pretty much static. Thus the response from members.pl should be eminently cachable in my mind. This certainly needs investigation though as I'm not sure without digging what else that call does.. but basically I feel that page should pretty much be in memory so any subsequent calls to member.pl use the local copy (i.e are instant) and then only the /svc/search call is fired from the ajax request and datatables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 10:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 09:53:19 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 --- Comment #3 from Martin Stenberg --- If you are in single item checkout, you can press enter in the barcode textbox to print a receipt. In batch checkout, this is not possible due to the nature of the textarea (which when pressing enter will add a newline). Having the link there makes it possible to print a receipt by pressing tab twice, followed by enter, instead of having to grab the mouse and click your way through the menu to the "print slip"-link. So it is there to improve the workflow. An alternative could be to hide the link, but still allow for the dubble-tab-enter key combo. I tried this during development, but found it a bit confusing since there was no way to see that this was possible, the shortcut link makes it more intuitive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:02:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:02:04 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:02:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:02:07 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44683|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 44687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44687&action=edit Bug 15160: GetTopIssues.t should create random data This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it creates its own data with random values. It does so by replacing (legacy) SQL inserts and fixed value data inserting by TestBuilder generated data. There is no expected behaviour change. To test: - Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST'); - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => FAIL: The insert line fails - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetTopIssues.t => SUCCESS: tests pass due to random data usage. - Sign off Signed-off-by: Frederic Demians Test plan produces the expected result, failing, then OK. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:12:49 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Without the option, /var/lib/koha/$instance/plugins was dumped, with the option it's not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:26:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:26:08 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #10 from Robin Sheat --- (In reply to Jonathan Druart from comment #9) > Without the option, /var/lib/koha/$instance/plugins was dumped, with the > option it's not. Good point! Can we just do excludes on tar? That'd be safer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:41:04 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 11:52:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 10:52:41 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 --- Comment #4 from Fr?d?ric Demians --- (In reply to Martin Stenberg from comment #3) > If you are in single item checkout, you can press enter in the barcode > textbox to print a receipt. In batch checkout, this is not possible due to > the nature of the textarea (which when pressing enter will add a newline). > > Having the link there makes it possible to print a receipt by pressing tab > twice, followed by enter, instead of having to grab the mouse and click your > way through the menu to the "print slip"-link. So it is there to improve the > workflow. For me, the quick 'Print slip' link should be displayed on the checkout summary page (the one displayed after clicking 'Check out' button), not on the initial 'Batch checkout' page. Otherwise this gives the impression that the barcode you're entering in the 'Barcode list' textarea will be present in the receipt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:08:16 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #12 from Jonathan Druart --- Comment on attachment 44596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44596 Bug 14946 - Remove C4::Dates from files acqui/*.pl Review of attachment 44596: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14946&attachment=44596) ----------------------------------------------------------------- ::: acqui/finishreceive.pl @@ +63,5 @@ > my $new_ordernumber = $ordernumber; > > +my $datereceived_dt = eval { dt_from_string( $datereceived) }; > +$datereceived_dt = dt_from_string unless ( $datereceived_dt ); > +$datereceived = output_pref( { dt => $datereceived_dt , dateonly => 1, dateformat => 'iso' } ) ; I don't understand how this change could be useful. ::: acqui/histsearch.pl @@ +126,5 @@ > ); > } > > +my $from_date = output_pref( { dt => $from_placed_on, dateformat => 'iso', dateonly => 1 } ); > +my $to_date = output_pref( { dt => $to_placed_on, dateformat => 'iso', dateonly => 1 } ); This is wrong, why do you want to display in iso format? Prefer to do that on TT side. ::: acqui/invoice.pl @@ +90,5 @@ > + > + if ( $input->param('billingdate') ) { > + $billingdate = eval { dt_from_string( $input->param('billingdate') ) }; > + $billingdate = output_pref( { dt => $billingdate, dateformat => 'iso', dateonly => 1 } ) if ( $billingdate ); > + } This is not exactly the same as before but is an improvement. If the date is wrong, don't set it as today, but keep is undef (not important atm, the input is readonly). ::: acqui/invoices.pl @@ +68,5 @@ > + > +my $shipmentdatefrom_iso = ''; > +my $shipmentdateto_iso = ''; > +my $billingdatefrom_iso = ''; > +my $billingdateto_iso = ''; prefer my ($var1, $var2, ..., $varN). No need to assign them an empty string. @@ +162,5 @@ > + suppliername => $suppliername, > + shipmentdatefrom => $shipmentdatefrom_iso, > + shipmentdateto => $shipmentdateto_iso, > + billingdatefrom => $billingdatefrom_iso, > + billingdateto => $billingdateto_iso, This is wrong, the dates are displayed in iso format. ::: acqui/orderreceive.pl @@ -74,4 @@ > use C4::Biblio; > use C4::Suggestions; > > -use Koha::Acquisition::Bookseller; Why do you remove it? @@ +193,5 @@ > > my $datereceived = $order->{datereceived} ? dt_from_string( $order->{datereceived} ) : dt_from_string; > > +my $orderentrydate = eval{ dt_from_string( $order->{entrydate} ); }; > +$orderentrydate = output_pref( { dt => $orderentrydate, dateonly => 1 } ) if ( $orderentrydate ); I don't understand these changes. ::: acqui/parcels.pl @@ +169,5 @@ > my @parcels = GetInvoices( > + supplierid => $booksellerid, > + invoicenumber => $code, > + shipmentdatefrom => $datefrom_iso, > + shipmentdateto => $dateto_iso, I'd keep the previous behavior, don't pass shipmentdateto/from if no need to pass them. Why did you change this part of code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:08:25 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:11:16 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:39:02 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:39:05 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 --- Comment #5 from Fr?d?ric Demians --- Created attachment 44688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44688&action=edit Bug 12923 Improve error logging for advance_notices.pl Show borrowernumber when no letter of type is found and force utf8 output when running advance_notices.pl with -n flag, diacritics run awol in the console output! Also when debugging which borrower requests undefined letter templates, it is very handy to log the borrowernumber so we catch and fix bad borrower message transport settings. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. ::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922:: TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found. Please see sample_notices.sql at ./advance_notices.pl line 366." 4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found for borrowernumber 1104659. Please see sample_notices.sql at ./advance_notices.pl line 368." Makes life more worth living for! Also diacritics printed on screen are displayed properly. Signed-off-by: Frederic Demians I confirm the diacritics issue and solution. borrowernumber is displayed with warning when the 'no letter...' message is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:43:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:43:36 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- 1/ " = " => Useless spaces. 2/ $tmpPlannedDate is not necessary, don't use this tmp var. 3/ my $date = ''; my $date; #is enough 4/ + $expirationdate = eval { output_pref( { dt => dt_from_string( $expirationdate ), dateonly => 1, dateformat => 'iso' }); } + if ( $expirationdate ); + + next unless ( $expirationdate ); + $subscription->{expirationdate} = $expirationdate; - next if $expirationdate !~ /\d{4}-\d{2}-\d{2}/; # next if not in ISO format. This change is not needed. 5/ - Date_to_Days(split "-",$expirationdate) > Date_to_Days(&Today) && I don't understand why you removed this line. There are still other some inconsistencies, I would like to know what methodology you use to replace these occurrences. For instance format_date always expect an iso formatted date, but you replace these occurrences with output_pref( { dt => dt_from_string( $date ), dateonly => 1 }) you should specify the dateformat param to dt_from_string. And sometimes you replace them with $date = eval { dt_from_string( $date ) } if $date; $date = output_pref( { dt => $date, dateonly => 1 } ) if $date; The changes are coming complicated and more and more errors are found on the QA step. I would like to see a migration plan with a test file to highlight the changes you are doing. If I remember correctly, I have attached a file doing that some weeks ago (but don't find it anymore). We need to test several values: undef, empty string, valid date, invalid date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 12:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 11:54:17 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #1 from Katrin Fischer --- For example: - Turn on the AuthorityFile plugin for the OPAC in the "Did you mean" section of the administration module - Search a term in your OPAC where some authorities exist for it - like a name or a place. My example search is: Deutschland or Germany - Verify that there are suggestions displayed on top of the result list - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:01:42 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:01:45 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44605|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 44689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44689&action=edit Bug 14743 - addorder.pl redirect problems under plack behind apache 2.4.10 I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! Test Plan: 1) Using plack, add an order to a basket from an external source 2) Note the error 3) Apply this patch 4) Add an order to a basket from an external source 5) Note you get no error! Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:02:18 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Nice catch Kyle! We absolutely need to keep that in mind! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:02:43 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13791 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 [Bug 13791] Plack - Out of the box support on packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:02:43 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14743 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:04:28 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12648 --- Comment #6 from Jonathan Druart --- The duplication has been introduced by bug 12648 (sorry about that!). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 [Bug 12648] Link patrons to an order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:04:28 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14743 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:08:40 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:08:43 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43678|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 44690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44690&action=edit Bug 7895: Test for PSGI-related env to report in about.pl This patch introduces a test for psgi/plack in %ENV and uses that data to report in the about page. To test: - On current master (without Plack), go to about.pl - Notice no mention of Plack - Apply the patch - Reload the about page => SUCCESS: No change - Enable plack, and access the about page through Plack => SUCCESS: There is a PSGI label, showing that you are running Plack - Sign off :-D Regards PS: I haven't tested the mod_perl scenario, I just grabbed the MOD_PERL env var from the docs. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:12:19 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Plack/FastCGI/mod_perl |Add Plack/FastCGI/mod_perl |server configuration and |server configuration to |Zebra info to about |about QA Contact|koha.sekjal at gmail.com |testopia at bugs.koha-communit | |y.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|dpavlin at rot13.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:17:44 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #8 from Josef Moravec --- Created attachment 44691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44691&action=edit Bug 13931 - Fix patron search result table heading, fix member.pl template params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:18:02 +0000 Subject: [Koha-bugs] [Bug 14718] Documentation/screenshot update for label creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major Depends on| |14667 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Liz Rea from comment #0) > Assuming bug 14467 gets in, the screenshots for the label creator, the > online help, and the manual will need to be updated with the new UI layout. > > Please and thank you! Was certainly bug 14667. Lowering the severity to major. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 [Bug 14667] Label creator UI/UX revamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:18:02 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14718 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 [Bug 14718] Documentation/screenshot update for label creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:19:28 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #33 from Fr?d?ric Demians --- - The patch doesn't apply anymore on master. There is a conflict on .pref template. - I'd personally prefer a unique patch rather than 3 consecutive patches. - The UT doesn't work with a Unimarc DB. It fails because the biblio record constructed in the test has a title in 245 tag. In Unimarc, title is in 200. I don't know it is considered problematic by QAers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:19:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:19:32 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37811|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 44692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44692&action=edit Bug 13931 - Implemented date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:19:39 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44691|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 44693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44693&action=edit Bug 13931 - Fix patron search result table heading, fix member.pl template params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:20:39 +0000 Subject: [Koha-bugs] [Bug 15026] Staged authority records diff wrongly compares auth to biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15026 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you provide steps to reproduce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:22:03 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Josef Moravec --- I've rebased patchs on top of current master and made followup to fix the error in patron search results table heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:25:14 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #34 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #33) > - The UT doesn't work with a Unimarc DB. It fails because the biblio record > constructed in the test has a title in 245 tag. In Unimarc, title is in > 200. I > don't know it is considered problematic by QAers. No it's not. The requirement is that the tests must pass on a "fresh" MARC21 DB with all sample data. We tend to ask for the tests to create their own data (using t::lib::TestBuilder for instance) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:27:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:27:36 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:35:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:35:45 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11867 --- Comment #5 from Jonathan Druart --- This has certainly been caused by 3.15.00.041 (bug 11867). The structure of the letter table is not ideal, it should be split into 2 tables to normalised it. I don't know how we could fix this issue as a script cannot know what is the correct name of the letter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:35:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:35:45 +0000 Subject: [Koha-bugs] [Bug 11867] Multi transport types: Manage *_PHONE notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12752 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:37:02 +0000 Subject: [Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12812 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:37:02 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:42:01 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #16 from Marc V?ron --- Created attachment 44694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44694&action=edit Bug 14969:(followup) Remove C4::Dates from serials Follow up for comment #15 - 1/ Useless spaces removed (I used them to better align the code for readability - 2/ $tmpPlannedDate removed. I used it for better readibility. - 3/ Initializition of $date to '' removed - 4/ and 5/ Changes removed (they beloged together). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:44:39 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40630|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 44695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44695&action=edit Bug 13930 - Created NCIP svc to effectively parse data from database to JSON in order to query those from xcncip2toolkit koha's connector Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:44:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:44:47 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40631|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 44696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44696&action=edit Bug 13931 - Fixed Licence & Copyright statements & refactored the code http://bugs.koha-community.org/show_bug.cgi?id=13930 Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:44:54 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40632|0 |1 is obsolete| | --- Comment #22 from Josef Moravec --- Created attachment 44697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44697&action=edit Bug 13930 Followup: fixing 'undefined subroutine' errors Fixing the errors Undefined subroutine &C4::Reserves::GetReserveCountFromItemnumber called at /koha/C4/NCIP/LookupItemSet.pm line 90. Undefined subroutine &C4::Reserves::GetReservesFromBorrowernumber called at /koha/C4/NCIP/LookupUser.pm line 80 Undefined subroutine &C4::Items::GetItem called at /koha/C4/NCIP/LookupItem.pm line 77. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:45:00 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40633|0 |1 is obsolete| | --- Comment #23 from Josef Moravec --- Created attachment 44698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44698&action=edit Bug 13930 Followup: fix subroutine call Fixing error 'Undefined subroutine &C4::NCIP::RequestItem::print409 called at /home/mirko/koha/C4/NCIP/RequestItem.pm line 86.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:46:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:46:29 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #24 from Josef Moravec --- I've rebased the patches on top of current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:46:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:46:38 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:49:34 +0000 Subject: [Koha-bugs] [Bug 15160] GetTopIssues.t should create random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15160 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:49:55 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:50:17 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > If I remember correctly, I have attached a file doing that some weeks ago > (but don't find it anymore). We need to test several values: > undef, empty string, valid date, invalid date I was thinking about bug 13813 comment 82 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:50:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:50:23 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch and followups pushed to master. Thanks David and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:53:19 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #38 from bondiurbano --- (In reply to Holger Mei?ner from comment #36) > Here you go, bondiurbano. Have a nice weekend :) Holger, the next release is ahead and it seems we have no lucky... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 13:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 12:57:37 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- I can't apply this patch on master: fatal: sha1 information is lacking or useless (C4/Accounts.pm). error: could not build fake ancestor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:30:23 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44439|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 44699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44699&action=edit Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:32:09 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44556|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 44700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44700&action=edit Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:32:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:32:56 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44621|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 44701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44701&action=edit Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:33:48 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:48:53 +0000 Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- You also see the patron names in the list of pending on-site checkouts and the link from checked out books in staff leads directly to the patron account, even with HidePatronName turned on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:55:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:55:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #274 from Tom?s Cohen Arazi --- Created attachment 44702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44702&action=edit Bug 7143: Updates for the 3.22 release This patch adds the new devs missing from the history.txt file that contributed patches during the 3.22 release cycle. It fixes the missing ones on the about page too. Bonus: Adds Olli, who was missing, so numbering shift was needed too. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:56:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:56:47 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 14:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 13:56:56 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:03:02 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:03:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:03:16 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:03:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44702|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:03:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:03:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:11:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:11:28 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #17 from Lari Taskula --- Created attachment 44703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44703&action=edit Bug 14620 - Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:13:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:13:13 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:22:12 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42464|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 44704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44704&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. Fixing category messaging preferences broken by previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:39:58 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44703|0 |1 is obsolete| | --- Comment #18 from Lari Taskula --- Created attachment 44705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44705&action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. Test plan: 1. Apply the patches (and run updatedatabase.pl). 2. Set system preferences ValidateEmailAddress to "Enable" and ValidatePhoneNumber to "International Phone Numbers". 3. Make sure JavaScript is enabled. 4. Navigate to edit user contact informations in Staff client and OPAC. 5. Clear email and phone fields. 6. Insert whitespaces to email and phone fields and submit the form. 7. Edit patron. 8. Observe that there are no longer whitespaces in email and phone fields. 9. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 10. Confirm that form will not be submitted and errors will be given. 11. Disable JavaScript. 12. Insert invalid email and invalid phone number 13. Try sending the form again. 14. Confirm that form will be submitted but errors will be given on top of the form. 15. Observe that none of the changes are accepted. 16. Set system preferences ValidateEmailAddress to "Disable" and ValidatePhoneNumber to "none". 17. Repeat step 3-9 but observe that errors will not be given and changes will be submitted and saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 15:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 14:48:27 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Jessie, Could you explain the workflow to get this issue? It looks like a configuration issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:09:15 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44520|0 |1 is obsolete| | --- Comment #5 from Martin Stenberg --- Created attachment 44706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44706&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page, places focus on the barcode text field and adds a discrete shortcut link for printing receipts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:11:58 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 --- Comment #6 from Martin Stenberg --- I agree Fr?d?ric, that makes more sense. I have moved the link to the summary page, and also added an auto-focus to the "Checkout or renew"-button on the confirmation-page, so that you can just hit enter to continue the process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:15:31 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44656|0 |1 is obsolete| | --- Comment #2 from Martin Persson --- Created attachment 44707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44707&action=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&show_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:15:29 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:18:17 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #13 from Marc V?ron --- Created attachment 44708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44708&action=edit Bug 14946: (followup) Remove C4::Dates from files acqui... Followup for comment #12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:18:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:18:45 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 --- Comment #2 from Jonathan Druart --- Created attachment 44709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44709&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:18:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:18:57 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:19:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:19:56 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38130|0 |1 is obsolete| | --- Comment #23 from Fridolin SOMERS --- Created attachment 44710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44710&action=edit Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:20:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:20:04 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:20:07 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38146|0 |1 is obsolete| | --- Comment #24 from Fridolin SOMERS --- Created attachment 44711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44711&action=edit Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:20:24 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38667|0 |1 is obsolete| | --- Comment #25 from Fridolin SOMERS --- Created attachment 44712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44712&action=edit Bug 11122: Follow up Based on comment #21, this patch corrects the failings in the t/db_dependent/Acquisition.t tests. When two fields were added to the query, the corresponding array in the the test file was not updated to match. TEST PLAN --------- 1) Apply the first two patches 2) prove -v t/db_dependent/Acquisition.t -- fails 2 tests 3) Apply this patch 4) prove -v t/db_dependent/Acquisition.t -- passes 5) Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:23:04 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from Fridolin SOMERS --- Patches rebased : no real conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:31:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:31:34 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.20 |master --- Comment #2 from Jonathan Druart --- How important is this one? Should we completely remove itemnotes_nonpublic from the indexed fields? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:31:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:31:55 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36170|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS --- Created attachment 44713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44713&action=edit Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:34:54 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #2) > > I think it would be better to use the existing class 'noprint' for elements > that are not intended to appear in print. > > E.g. in catalogue/results.tt line 309 for div selection_ops: > class="cartlist noprint" instead of class="cartlist" > > What do you think about? 100% agree, in fact this bug only manages list page. Here is the new patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:39:43 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #3 from Mirko Tietgen --- I think we should not index it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:47:00 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #8 from Marc V?ron --- (In reply to Jonathan Druart from comment #7) > I don't want to spent too much time on this script, but I don't think it > will work as before. > > C4::Dates->new($1, 'us')->output() > and > output_pref( { dt => dt_from_string( $1 ), dateonly => 1, dateformat => > 'us' } > are different I think, it should be > output_pref( { dt => dt_from_string( $1, 'us' ), dateonly => 1 } > > I would prefer to see this script deleted :) Delete +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:47:17 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #11 from Jonathan Druart --- This looks like more than an enhancement than a bug fix, at least from my developer point of view. Does a quick fix could do the job? Something like a pref: - charge any holds - charge any holds if all items are issued - charge any holds if all items are issued and at least one hold already exists on this record # default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 16:58:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 15:58:28 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 --- Comment #5 from Marc V?ron --- Sorry, patch does not apply. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 17:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 16:03:02 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 17:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 16:03:26 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 17:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 16:36:46 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 17:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 16:36:48 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44706|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 44714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44714&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page, places focus on the barcode text field and adds a discrete shortcut link for printing receipts. Signed-off-by: Frederic Demians Works as promised. Improve batch checkout general UI workflow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 18:25:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 17:25:31 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 18:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 17:25:34 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44709|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 44715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44715&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. Signed-off-by: Frederic Demians Repeatable bug. Solved with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 18:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 17:46:03 +0000 Subject: [Koha-bugs] [Bug 15166] New: Make output_pref takes a string in parameter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Bug ID: 15166 Summary: Make output_pref takes a string in parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org To simplify the management of dates, it would be great that output_pref takes a string in parameter. my $date = $input->param('my_date'); $date = eval { dt_from_string( $date ) } if $date; $date = output_pref({dt => $date}) if $date; Could be replace with: my $date = output_pref({ str => $input->param('my_date') }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 18:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 17:47:17 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref takes a string in parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 18:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 17:47:20 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref takes a string in parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 --- Comment #1 from Jonathan Druart --- Created attachment 44716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44716&action=edit Bug 15166: Make output_pref takes a string in parameter To simplify the management of dates, it would be great that output_pref takes a string in parameter. my $date = $input->param('my_date'); $date = eval { dt_from_string( $date ) } if $date; $date = output_pref({dt => $date}) if $date; Could be replace with: my $date = output_pref({ str => $input->param('my_date') }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:00:26 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:00:29 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44596|0 |1 is obsolete| | Attachment #44708|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 44717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44717&action=edit Bug 14946: Remove C4::Dates from acqui/* files This patch replaces all use of C4::Dates with Koha::DateUtils, which is the best practice to follow. It also fixes a bug on the invoice search, the shipment date (from and to) were not passed correctly from one page to the other. Test plan: 1/ Search for orders using the different filters 2/ Create an invoice, try with setting and leaving empty the date fields. Default should be an undefined value (not today) 3/ Search for invoices and use the 4 different filters. Close and reopen invoices. The filters should be kept from one page to the other (not that it does not work with shipment date before this patch). 4/ Receive an order, on creating the invoice, the default date should be today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:01:00 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref takes a string in parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14946 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 [Bug 14946] Remove C4::Dates from files acqui/*.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:01:00 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref takes a string in parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:03:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:03:43 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:19:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:19:07 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:20:19 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:20:43 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44690|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 44718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44718&action=edit Bug 7895: Test for PSGI-related env to report in about.pl This patch introduces a test for psgi/plack in %ENV and uses that data to report in the about page. To test: - On current master (without Plack), go to about.pl - Notice no mention of Plack - Apply the patch - Reload the about page => SUCCESS: No change - Enable plack, and access the about page through Plack => SUCCESS: There is a PSGI label, showing that you are running Plack - Sign off :-D Regards PS: I haven't tested the mod_perl scenario, I just grabbed the MOD_PERL env var from the docs. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:22:32 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:22:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:22:36 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44715|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 44719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44719&action=edit Bug 14735: Save cache_expiry on modifying a report The cache_expiry is not saved when updating a SQL report. Test plan: 0/ Enable memcached 1/ Create a sql report 2/ Edit it and change the cache expiry value 3/ Edit again => The value should have been updated. Signed-off-by: Frederic Demians Repeatable bug. Solved with this patch. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:24:37 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:24:59 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Good idea, Dobrica! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:25:39 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Enjoy your beer Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:46:16 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sitemap.pl -- Generate a |sitemap.pl -- Generate a |Catalog sitemap |catalog sitemap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:48:37 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_catalogue.pl instead) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:50:12 +0000 Subject: [Koha-bugs] [Bug 13962] Add vendor to the acq tab on the details page in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add vendor to new acq tab |Add vendor to the acq tab |in staff client |on the details page in | |staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:50:58 +0000 Subject: [Koha-bugs] [Bug 10933] Merge PurgeSearchHistory into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|PurgeSearchHistory should |Merge PurgeSearchHistory |be merged into the |into the |C4::Search::History module |C4::Search::History module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 19:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 18:52:02 +0000 Subject: [Koha-bugs] [Bug 13967] Add package for System preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|System preferences need a |Add package for System |package |preferences CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:02:03 +0000 Subject: [Koha-bugs] [Bug 7369] Ability to duplicate existing items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|duplicate item |Ability to duplicate | |existing items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:03:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:03:42 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Installation and upgrade | |(web-based installer) CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:05:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:05:16 +0000 Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin - Add display of volume info and link to biblio record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|unimarc_field_4XX plugin |unimarc_field_4XX plugin - |doesn't display volume |Add display of volume info |info, neither link to |and link to biblio record |biblio | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:08:00 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Cataloging |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:08:47 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out an on hold item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a new button to the |Add a new button to the |checkout confirmation |checkout confirmation |dialog when checking out a |dialog when checking out an |reserved item. |on hold item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:12:24 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|koha-indexer tab completion |koha-indexer tab-completion |in bash |in bash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:13:00 +0000 Subject: [Koha-bugs] [Bug 14840] Add new cronjob to send membership expiry reminder notices in crontab.example file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Added new cron script send |Add new cronjob to send |membership expiry reminder |membership expiry reminder |notices in crontab.example |notices in crontab.example |file |file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:14:09 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default when searching for label items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Select the barcode index by |Select the barcode index by |default then searching for |default when searching for |label items. |label items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:14:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:14:56 +0000 Subject: [Koha-bugs] [Bug 11325] Focus on "Add item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Focus not on "Add Item" in |Focus on "Add item" in |Lists |Lists CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:15:53 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:16:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:16:59 +0000 Subject: [Koha-bugs] [Bug 13622] Add option to display datetimes as dates in notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display a datetime without |Add option to display |time in a notice |datetimes as dates in | |notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:17:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:17:22 +0000 Subject: [Koha-bugs] [Bug 14240] Add '(All libraries)' to notice deletion confirmation page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:17:40 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced search: Hide |Advanced search: Hide |itemtypes from search form |itemtypes from search form |& Group itemtypes together |& Group itemtypes together |into one search |into one search option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:18:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:18:07 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Small improvements in OPAC |Small improvements in OPAC |results list. |results list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:18:52 +0000 Subject: [Koha-bugs] [Bug 14607] Make Baker & Taylor cover images accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Baker & Taylor cover images |Make Baker & Taylor cover |should be accessible by UPC |images accessible by UPC as |as well as ISBN |well as ISBN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:19:53 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Validation of email address |Validation of email address |field |fields -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:20:39 +0000 Subject: [Koha-bugs] [Bug 10904] Limit patron modification request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit patron update request |Limit patron modification |management by branch |request management by | |branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:22:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:22:57 +0000 Subject: [Koha-bugs] [Bug 14249] Improve discharge letter sample notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:23:27 +0000 Subject: [Koha-bugs] [Bug 14280] Add branches fields to discharges letters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Patrons |Notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:25:24 +0000 Subject: [Koha-bugs] [Bug 8438] Allow staff to only claim serial issues of their own branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow staff only to only |Allow staff to only claim |claim serial issues of |serial issues of their own |their own branch |branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:26:12 +0000 Subject: [Koha-bugs] [Bug 13972] Include fields from subscription and serial table in serial notification email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Serials |Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:26:30 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:26:52 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:29:24 +0000 Subject: [Koha-bugs] [Bug 10363] Move authorised value related code into its own package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:30:40 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Command-line Utilities CC| |katrin.fischer at bsz-bw.de, | |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:32:46 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:32:51 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:33:14 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:33:19 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:33:26 +0000 Subject: [Koha-bugs] [Bug 14054] 246 XSLT Improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:33:31 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:33:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:33:35 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:36:11 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Additional fields for |Custom fields for |subscriptions |subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:36:59 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Web services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:37:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:37:09 +0000 Subject: [Koha-bugs] [Bug 3206] OAI-PMH repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAI repository deleted |OAI-PMH repository deleted |record support |record support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:37:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:37:39 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Command-line Utilities CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:38:56 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - activate cronjob by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HEA - Cronjob Setup |HEA - activate cronjob by | |default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:39:33 +0000 Subject: [Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Label/patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:40:28 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:40:53 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server: Add handling of time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|OAI-PMH repository/server |OAI-PMH repository/server: |not handling time in "from" |Add handling of time in |argument |"from" argument -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:41:58 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |Searching |Servers | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:42:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:42:36 +0000 Subject: [Koha-bugs] [Bug 14031] Make itemnumber a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Itemnumber should be a |Make itemnumber a numeric |numeric search in |search in ccl.properties |ccl.properties | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:45:26 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:45:42 +0000 Subject: [Koha-bugs] [Bug 14339] Installer broken by bug 13967 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:51:53 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | Component|Architecture, internals, |Test Suite |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:52:06 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:52:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:52:32 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Architecture, internals, |Acquisitions |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:52:55 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Back-button in OPAC shows |Back-button in OPAC shows |previous user's details, |previous user's details, |after LOGOUT |after logout -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:53:16 +0000 Subject: [Koha-bugs] [Bug 14509] Don't allow spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha still allows spaces at |Don't allow spaces at the |the end, beginning or as |end, beginning or as your |your password |password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:53:45 +0000 Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted will fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reverting a batch where a |Reverting a batch where a |record overlaid is now |record overlaid is now |deleted record will fail |deleted will fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:54:49 +0000 Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted will fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |MARC Bibliographic record | |staging/import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:55:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:55:05 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 20:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 19:58:48 +0000 Subject: [Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |Packaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:00:10 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Authority data support |Searching CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:01:43 +0000 Subject: [Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Packaging |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:01:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:01:59 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Packaging |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:02:56 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf.xml paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-conf paths to zebra |koha-conf.xml paths to |libraries are wrong in |zebra libraries are wrong |jessie |in jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:03:36 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Architecture, internals, |Command-line Utilities |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:03:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:03:42 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Command-line Utilities |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:04:24 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:08:40 +0000 Subject: [Koha-bugs] [Bug 14592] Fix encoding in data exports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Export data bad encoding |Fix encoding in data | |exports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:09:02 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Command-line Utilities CC| |katrin.fischer at bsz-bw.de, | |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:12:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:12:21 +0000 Subject: [Koha-bugs] [Bug 11431] Custom sound alerts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add additional sound |Custom sound alerts |options for warnings | Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:12:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:12:38 +0000 Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in receive shipment list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Links to results pages |Links to results pages |don't work in Receive |don't work in receive |Shipment list |shipment list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:13:49 +0000 Subject: [Koha-bugs] [Bug 11458] Improve description for syspref gist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11458 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confusing description for |Improve description for |syspref gist |syspref gist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:14:24 +0000 Subject: [Koha-bugs] [Bug 11804] Merge circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|there should not be both a |Merge circ-menu.tt and a |circ-menu.tt and a |circ-menu.inc |circ-menu.inc | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:15:25 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Test Suite |and plumbing | QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:16:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:16:15 +0000 Subject: [Koha-bugs] [Bug 15146] Format date of birth on patrons requesting modification page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15146 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de, | |kyle.m.hall at gmail.com Component|Architecture, internals, |Patrons |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:16:36 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Authentication |I18N/L10N CC| |frederic at tamil.fr, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:17:43 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Component|Cataloging |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:18:59 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |MARC Bibliographic data | |support CC| |katrin.fischer at bsz-bw.de Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:20:25 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|'Cancel Hold' check box on |'Cancel Hold' check box on |check-out confirmation does |check-out confirmation does |not cancel the hold when |not cancel the hold when |item is checked out. |item is checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:20:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:20:42 +0000 Subject: [Koha-bugs] [Bug 14361] koha-restart-zebra fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-restart-zebra fails |koha-restart-zebra fails |and probably breaks upgrade | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:22:04 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Make output_pref takes a |Make output_pref accept a |string in parameter |string as parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:23:44 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Component|Patrons |I18N/L10N CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:24:59 +0000 Subject: [Koha-bugs] [Bug 14002] Show patron expiry date in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:28:00 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:28:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:28:12 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44280|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 44720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44720&action=edit Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015) Updates the framework files using the po file based mechamism provided by Bernardo. To test: - Check that changes make sense - Run the Koha web installer for de-DE - Confirm all 4 files changed here load without errors Signed-off-by: Bernardo Gonzalez Kriegel All files load without errors, pass marc bibliographic fw test No errors Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:28:13 +0000 Subject: [Koha-bugs] [Bug 14157] Show notices tab with EnhancedMessagingPreferences deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|EnhancedMessagingPreference |Show notices tab with |s and Notices tab |EnhancedMessagingPreference | |s deactivated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:29:14 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron's transaction |Patron's transaction |history changes items' |history changes items' |order after paying fines. |order after paying fines CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:29:39 +0000 Subject: [Koha-bugs] [Bug 13632] Make permission descriptions translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use a translatable file |Make permission |instead of the database for |descriptions translatable |managing permission | |descriptions | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:30:09 +0000 Subject: [Koha-bugs] [Bug 14130] Update column.def with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|column.def should be |Update column.def with |updated with descriptions |descriptions for new |for new columns |columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:30:41 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:37:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:37:01 +0000 Subject: [Koha-bugs] [Bug 14285] Bengali locale needs to be re-defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|translate.koha-community.or |I18N/L10N |g | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 21:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 20:47:59 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:00:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:00:47 +0000 Subject: [Koha-bugs] [Bug 10886] Hide patron information in item history if intranetreadinghistory is set to not allow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|When intranetreadinghistory |Hide patron information in |is set to not allow - staff |item history if |can still view patron's |intranetreadinghistory is |history in item history |set to not allow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:03:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:03:08 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #15 from Marc V?ron --- Tests: 1/ Search for orders using the different filters => OK 2/ Create an invoice, try with setting and leaving empty the date fields. Default should be an undefined value (not today) => OK 4/ Receive an order, on creating the invoice, the default date should be today. => OK 3/ Search for invoices and use the 4 different filters. Close and reopen invoices. The filters should be kept from one page to the other (not that it does not work with shipment date before this patch). => Not OK I have invoices with shipment dates 02/11/2015, 11/11/2015,10/11/2015 Set filter for shipment date from 01/11/2015 to 11/11/2015 Result: Line with "Shipment date: From 01/11/2015 To 11/11/2015 ", but no results. Same with billing dates: one with 30/09/2015, three with 02/10/2015 If I set the filter for billing date from 30/09/2015 to 02/10/2015 I get a line with "Billing date: From 30/09/2015 To 02/10/2015", but no results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:20:35 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #136 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #135) > H?ctor, would you allow me to simplify this bug? I propose to just keep 3 > patches attached to this one (and sign them): the enhancement, the UT & the > less to css conversion. And I would open two new patches: (1) 264 field, (2) > NORMARC new XSL. It won't touch the patches themselves nor your credit. Sorry for my late reply Okidoki Fr?d?ric, do the necessary and the more adequate with this bug. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:49:03 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44716|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44721&action=edit Bug 15166: Make output_pref takes a string in parameter To simplify the management of dates, it would be great that output_pref takes a string in parameter. my $date = $input->param('my_date'); $date = eval { dt_from_string( $date ) } if $date; $date = output_pref({dt => $date}) if $date; Could be replace with: my $date = output_pref({ str => $input->param('my_date') }); Tested with t/DateUtils.t, passed OK. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:49:21 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:49:44 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:53:36 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #16 from Marc V?ron --- 3/ Search for invoices and use the 4 different filters. Close and reopen invoices. The filters should be kept from one page to the other (not that it does not work with shipment date before this patch). => Works OK (With 15166 applied, sorry I was not aware). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:56:22 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 22:57:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 21:57:53 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44717|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 44722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44722&action=edit Bug 14946: Remove C4::Dates from acqui/* files This patch replaces all use of C4::Dates with Koha::DateUtils, which is the best practice to follow. It also fixes a bug on the invoice search, the shipment date (from and to) were not passed correctly from one page to the other. Test plan: 1/ Search for orders using the different filters 2/ Create an invoice, try with setting and leaving empty the date fields. Default should be an undefined value (not today) 3/ Search for invoices and use the 4 different filters. Close and reopen invoices. The filters should be kept from one page to the other (not that it does not work with shipment date before this patch). 4/ Receive an order, on creating the invoice, the default date should be today. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 10 23:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Nov 2015 22:01:03 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #9 from Marc V?ron --- See Bug 15076 - Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 01:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 00:08:41 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #137 from David Cook --- (In reply to Fr?d?ric Demians from comment #134) > This is a huge subject. A very interesting and promising one. I'd be pleased > to be included in a discussion on this matter, whatever the form it takes: > bug umbrella, task force... Yeah, I'd like to be involved as well. I think Magnus Enger has already started doing prototype work on this with SemantiKoha, so it'll be interesting. Certainly something to discuss with the whole group, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 03:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 02:39:58 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #138 from H?ctor Eduardo Castro Avalos --- (In reply to David Cook from comment #137) > Yeah, I'd like to be involved as well. I think Magnus Enger has already > started doing prototype work on this with SemantiKoha, so it'll be > interesting. > > Certainly something to discuss with the whole group, I think. Hi David Where is placed Magnus' works? I'm really interested in this kind of subjects too. Another think is -as explain me Bernardo- the plack environment needs to be complete to use modules with Moose support, this is because some packages like RDF::Trine and RDF::Query need it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:22:48 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |jweaver at bywatersolutions.co | |m --- Comment #2 from Jonathan Druart --- commit bf4a39d7ce3d7618d6afe1cec6cc5d5b55885abe Author: Jesse Weaver Date: Mon Jul 14 12:15:14 2008 -0500 new script to fix date code in accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:33:30 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- The print slip link is not put at the right place. For instance if the patron is restricted, you will see the link at the confirmation step. Since this action is easily accessible from the menu, I am not sure it's consistent to display it again there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:42:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:42:57 +0000 Subject: [Koha-bugs] [Bug 15167] New: Remove unused script serials/acqui-search-result.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Bug ID: 15167 Summary: Remove unused script serials/acqui-search-result.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This script does not seem to be used. It has not been updated usefully since 2006. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:44:21 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:44:24 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 --- Comment #1 from Jonathan Druart --- Created attachment 44723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44723&action=edit Bug 15167; Remove unused script serials/acqui-search-result.pl This script does not seem to be used. It has not been updated usefully since 2006. Test plan: git grep acqui-search-result should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:45:19 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:45:19 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15167 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 [Bug 15167] Remove unused script serials/acqui-search-result.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:48:24 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #18 from Jonathan Druart --- Comment on attachment 44618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44618 Bug 14969: (followup) Remove C4::Dates from C4/Serials.pm Review of attachment 44618: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14969&attachment=44618) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +468,5 @@ > my @res; > while ( my $subs = $sth->fetchrow_hashref ) { > + $subs->{startdate} = output_pref( { dt => dt_from_string( $subs->{startdate}), dateonly => 1 } ); > + $subs->{histstartdate} = output_pref( { dt => dt_from_string( $subs->{startdate}), dateonly => 1 } ); > + $subs->{histenddate} = output_pref( { dt => dt_from_string( $subs->{startdate}), dateonly => 1 } ); Compulsive c/p :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 09:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 08:55:14 +0000 Subject: [Koha-bugs] [Bug 15168] New: Remove C4::Serials::ItemizeSerials which is not used anymore Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Bug ID: 15168 Summary: Remove C4::Serials::ItemizeSerials which is not used anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:00:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:00:30 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 --- Comment #1 from Jonathan Druart --- Created attachment 44724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44724&action=edit Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:00:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:00:28 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:00:52 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #12 from Katrin Fischer --- Hi Jonathan, I am not sure the second option is needed - but the 1 and 3 would be good I think. Preserving the current behaviour and adding what I think is the more expected scenario. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:01:03 +0000 Subject: [Koha-bugs] [Bug 15169] New: Add for Unimarc transformation to new metadata formats Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Bug ID: 15169 Summary: Add for Unimarc transformation to new metadata formats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org NORMARC doesn't have XSL file to transform biblio records into RDF-DC and SRW-DC format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:01:29 +0000 Subject: [Koha-bugs] [Bug 15169] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:03:09 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:03:09 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15168 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:03:34 +0000 Subject: [Koha-bugs] [Bug 15169] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:05:17 +0000 Subject: [Koha-bugs] [Bug 15170] New: Add 264 field to MARC21*DC.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Bug ID: 15170 Summary: Add 264 field to MARC21*DC.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:06:27 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |hector.hecaxmmx at gmail.com Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:06:27 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15170 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:10:01 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add for Unimarc |Add for NORMARC |transformation to new |transformation to new |metadata formats |metadata formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:10:37 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:10:40 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #1 from Fr?d?ric Demians --- Created attachment 44725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44725&action=edit Bug 13642 - Add NORMARCslim2RDFDC.xsl and NORMARCslim2SRWDC.xsl Add missing xsls for NORMARC flavour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:13:02 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #2 from Fr?d?ric Demians --- Hector: this is you parch, with Magnus as assignee since he's in the best position to sign it. To test with an NORMARC Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:14:37 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:14:39 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 --- Comment #1 from Fr?d?ric Demians --- Created attachment 44726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44726&action=edit Bug 13642 - Add 264 field to MARC21*DC.xsl Modify MARC21*DC.xsl to add RDA 264 field To test: - Copy from LOC z39.50 the Maxwell's handbook for RDA (ISBN 9780838911723) - Look the field 264 - In datail for the record, export or save to Dublin Core (the three options) - Open the xml generated, notice that and are not present - Apply this patch - Reload and export again - Open the xml, you will see the tags publisher and date taken from 264 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:15:21 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:15:21 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15169 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:21:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:21:33 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44659|0 |1 is obsolete| | Attachment #44661|0 |1 is obsolete| | Attachment #44669|0 |1 is obsolete| | Attachment #44677|0 |1 is obsolete| | --- Comment #139 from Fr?d?ric Demians --- Created attachment 44727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44727&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. NOTE: This new feature implement the XSLT transformation for OAI-DC, SRW-DC and RDF-DC Test plan --------------- 1) Download Dublin Core file from record detail page. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) Test with all marc flavours. Sponsored-by: Universidad de El Salvador Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:21:49 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44660|0 |1 is obsolete| | --- Comment #140 from Fr?d?ric Demians --- Created attachment 44728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44728&action=edit Bug 13642 - Changes LESS opac.less > to opac.css Changes LESS opac.less > to opac.css Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:21:58 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44672|0 |1 is obsolete| | --- Comment #141 from Fr?d?ric Demians --- Created attachment 44729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44729&action=edit Bug 13642 - Add Unit test for C4::Record::marc2dcxml Add Unit test for C4::Record::marc2dcxml To test: Prove t/db_dependent/Record.t Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:31:05 +0000 Subject: [Koha-bugs] [Bug 15171] New: Searching serials expiring after today should be allowed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Bug ID: 15171 Summary: Searching serials expiring after today should be allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The checkexpiration script let the user choose an expiration date > today, but the serial which will expire later than today won't be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:40:13 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:40:15 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #1 from Jonathan Druart --- Created attachment 44730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44730&action=edit Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:43:55 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:43:55 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15171 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 [Bug 15171] Searching serials expiring after today should be allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 10:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 09:44:03 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 --- Comment #9 from Fr?d?ric Demians --- Martin, you may limit your patch to the scope of this bug as stated by its title: show circ buttons at the top of batch circ page. And then, open another bug report to propose a way to improve the workflow regarding printing receipt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:01:43 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44714|0 |1 is obsolete| | --- Comment #10 from Martin Stenberg --- Created attachment 44731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44731&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:26:33 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44723|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44732&action=edit Bug 15167; Remove unused script serials/acqui-search-result.pl This script does not seem to be used. It has not been updated usefully since 2006. Test plan: git grep acqui-search-result should not return any result. Searched for file acqui-search-result*.*, vanished. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:26:53 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:29:38 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44724|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44733&action=edit Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result Followed test plan, no results found. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:30:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:30:12 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:41:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:41:06 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44730|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 44734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44734&action=edit Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. Followed testplan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 11:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 10:42:03 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:10:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:10:21 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:10:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:10:24 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44549|0 |1 is obsolete| | Attachment #44550|0 |1 is obsolete| | Attachment #44618|0 |1 is obsolete| | Attachment #44694|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 44735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44735&action=edit Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:27:02 +0000 Subject: [Koha-bugs] [Bug 15172] New: Serial enumchron/sequence not visible when returning/checking in Items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Bug ID: 15172 Summary: Serial enumchron/sequence not visible when returning/checking in Items Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Displays the items.enumchron-column in returns.pl when checking in Items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:27:08 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:28:03 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 44736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44736&action=edit Bug 15172 - Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Pending web testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:28:15 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:28:32 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti --- Failed QA because of missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:39:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:39:21 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:39:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:39:24 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44731|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 44737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44737&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 12:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 11:55:51 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 --- Comment #3 from Jonathan Druart --- Created attachment 44738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44738&action=edit Bug 15166: Carp if an invalid date is passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:08:31 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:08:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:08:33 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44699|0 |1 is obsolete| | Attachment #44700|0 |1 is obsolete| | Attachment #44701|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 44739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44739&action=edit Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions http://bugs.koha-community.org/show_bug.cgi?id=14985 Signed-off-by: Brendan Gallagher Bug 14985: (followup) Remove eval if dates come from database This patch removes some evals from date-formatting where the dates come from the database. See comments #7 - #9 Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete). Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm Ths patch removes a stray C4::Dates from C4/Overdues.pm - To test got to a patron who has overdues (Home > Circulation > Checkouts > [Patron]) - Print overdues Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:08:38 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #16 from Jonathan Druart --- Created attachment 44740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44740&action=edit Bug 14985: Fix regression on patron search This patch fixes 2 major errors introduced by last patch: 1/ Undefined subroutine &C4::Utils::DataTables::Members::dt_from_string called when searching for patrons 2/ Display the dates on the patron search in the pref format, not iso Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:08:41 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #17 from Jonathan Druart --- Created attachment 44741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44741&action=edit Bug 14985: Simplify the date management in AddReserve The code is much more readable using the str param of output_pref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:09:31 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #18 from Jonathan Druart --- Marc, I have squashed your 3 patches to make the log more readable. There were too many changes for the same lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:33:22 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44611|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 44742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44742&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:33:30 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #18 from Jonathan Druart --- Created attachment 44743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44743&action=edit Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:36:38 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44738|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 44744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44744&action=edit Bug 15166: Carp if an invalid date is passed Sign-off on second patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:37:40 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:37:40 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:43:55 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:44:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:44:01 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #11 from Jonathan Druart --- Created attachment 44746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44746&action=edit Bug 14998: Restore previous behavior We want to convert a us or metric date formatted to the format defined in the pref. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:43:58 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44415|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 44745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44745&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up Signed-off-by: Frederic Demians Code OK. Tested updatedatabase.pl with an old DB backup: OK. fix_accountlines_date.pl still working after the patch. Could be removed from master IMO. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:44:32 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14998 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:44:32 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15076 | --- Comment #12 from Jonathan Druart --- Continue without waiting for 15076. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:45:35 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- A complete test plan, working on master, should be proposed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:53:03 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44606|0 |1 is obsolete| | --- Comment #40 from Marc V?ron --- Created attachment 44747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44747&action=edit Bug 12072 - Add system preference for New dateformat dd.mm.yyyy (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected Amended to apply on top of Bug 15166 11.11.2015/mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:54:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:54:40 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41114|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44748&action=edit Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians Can see the warning in logs, and its disappearance with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:54:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:54:40 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref accept a string as parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:54:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:54:40 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12072 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 [Bug 12072] New dateformat dd.mm.yyyy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 13:54:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 12:54:38 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:01:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:01:46 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44585|0 |1 is obsolete| | Attachment #44591|0 |1 is obsolete| | Attachment #44592|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 44749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44749&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv Signed-off-by: Mirko Tietgen http://bugs.koha-community.org/show_bug.cgi?id=14945 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:01:49 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #26 from Jonathan Druart --- Created attachment 44750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44750&action=edit Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:01:54 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #27 from Jonathan Druart --- Created attachment 44751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44751&action=edit Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:02:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:02:00 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #28 from Jonathan Druart --- Created attachment 44752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44752&action=edit Bug 14954: Remove unused C4::Calendar::addDate subroutine Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:07:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:07:03 +0000 Subject: [Koha-bugs] [Bug 14551] Warns when sending a list via email on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- I don't see any warning. The patch itself does nothing to my eyes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:07:21 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 Bug 14375 depends on bug 14374, which changed state. Bug 14374 Summary: dont use mysql_auto_reconnect with DBIx::Connector http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:07:21 +0000 Subject: [Koha-bugs] [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14778 Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #5 from Jonathan Druart --- DBIx::Connector is now gone, see bug 14778. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:07:21 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:07:58 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #20 from Marc V?ron --- Jonathan, I wanted to sign-off on top of 15167 15168 15171 but patch does not apply: Auto-merging serials/checkexpiration.pl CONFLICT (content): Merge conflict in serials/checkexpiration.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:08:44 +0000 Subject: [Koha-bugs] [Bug 14600] MySQL server has gone away In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- Olli, with bug 14778, this issue should be fixed. Please reopen if it persists after 3.22. *** This bug has been marked as a duplicate of bug 14778 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:08:44 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #100 from Jonathan Druart --- *** Bug 14600 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:12:08 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:12:10 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41032|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44753&action=edit Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:12:47 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 44754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44754&action=edit Bug 9525 - group floating rules, floating rule tester :) Implemented a tester to floating-matrix.pl to more easily test the changes in the floating rules matrix "FloMax". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:13:02 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:13:05 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44737|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 44755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44755&action=edit Bug 15116: Show menu at the top of batch circ page This patch adds the user interaction menu to the top of the batch checkout page. Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:14:30 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44754|0 |1 is obsolete| | --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 44756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44756&action=edit Bug 9525 - group floating rules, floating rule tester :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:14:41 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:14:43 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44753|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 44757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44757&action=edit Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as ’ in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code ’ instead of the unicode character) - Without the patch - Create a record with title : L’avion d’argile - Index this record - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You do not find the record - Apply patch - Search for "L’avion d’argile" => You find the record - Search for "L'avion d'argile" => You find the record - Search for "L avion d argile" => You find the record Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:15:08 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Can be considered as a bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:19:51 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #239 from Jonathan Druart --- Created attachment 44758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44758&action=edit Bug 14544: Remove debug line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:21:10 +0000 Subject: [Koha-bugs] [Bug 15173] New: SubfieldsToAllowForRestrictedEditing not working properly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Bug ID: 15173 Summary: SubfieldsToAllowForRestrictedEditing not working properly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have found an issue where the system preference "SubfieldsToAllowForRestrictedEditing" is not properly restricting permissions. Based on what we are seeing, I suspect it has something to do with drop down vs. free text fields. Drop down fields are locked from editing, free text fields are not being locked properly. We are trying to disable editing on 952$2, 952$a, 952$b, 952$e, 952$h, 952$o. The first three fields (which are all drop downs) are locked properly. The last three fields (which are free text) are still editable by users with the restricted editing permission. This system preference is identical in set-up with 'SubfieldsToAllowForRestrictedBatchmod' and that system preference is working properly with the same input values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:29:19 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:29:22 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44748|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 44759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44759&action=edit Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians Can see the warning in logs, and its disappearance with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:29:40 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:42:14 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15166 --- Comment #21 from Jonathan Druart --- I have missed bug 15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref accept a string as parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:42:14 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:42:52 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #16 from Olli-Antti Kivilahti --- Created attachment 44760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44760&action=edit Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. instead of DELETE we GET the delete request so CGI works with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:54:29 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- Wouldn't it better to detect in JavaScript the protocol used to serve the page? using window.location.protocol. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 14:57:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 13:57:14 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:05:35 +0000 Subject: [Koha-bugs] [Bug 15174] New: Allow borrowers to be members of additional categories Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 Bug ID: 15174 Summary: Allow borrowers to be members of additional categories Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin at bugs.koha-community.org.xinxidi.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Make it possible for borrowers to be members of more than one category. When doing checkouts the librarian should be able to choose which category to use for the borrower for the specific checkout. If useful, this could later be extended to other areas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:06:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:06:21 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |martin at bugs.koha-community. |ity.org |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:07:00 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #22 from Marc V?ron --- Jonathan, on top of 15166 15167 15168 15171 I get still: Auto-merging serials/checkexpiration.pl CONFLICT (content): Merge conflict in serials/checkexpiration.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt I is related to checkexpiration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:07:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:07:45 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #19 from Tom?s Cohen Arazi --- Please, check this patchset breaks: $ prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:11:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #240 from Tom?s Cohen Arazi --- Thanks for the followup, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:11:44 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:12:10 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:12:32 +0000 Subject: [Koha-bugs] [Bug 15102] Fix capitalization for some strings on XSLT detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15102 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:16:35 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- Vitor, your patch uses GetBorrowerAttributes which has been moved from C4::Member to C4::Members::Attributes. Could you add this to export_borrowers.pl? use C4::Members::Attributes qw(GetBorrowerAttributes); And add the test plan to the patch itself as suggested by Johnatan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:16:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:16:46 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 --- Comment #1 from Zeno Tajoli --- Created attachment 44761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44761&action=edit Update MARC21 it-IT frameworks to Update 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:17:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:17:05 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:17:18 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 --- Comment #1 from Martin Stenberg --- Created attachment 44762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44762&action=edit Bug 15174: Member of multiple categories This patch makes it possible for borrowers to be members of more than one category. On checkout, librarian can choose which category to do checkout as. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client and modify a patron 4. Under "Library managenet" a new field "Additional categories" should be visible 5. Select one or more additional catogaries for the patron 6. Save 7. Make a checkout for the modified patron 8. A new dropdown box labled "Choose category for this checkout:" should be visible on the checkout page 9. Choose one of the additional categories in the dropdown box and checkout 10.Confirm that appropriet circulation rules for the category was applied to the checkout Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:21:17 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44735|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 44763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44763&action=edit Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:22:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:22:23 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #24 from Jonathan Druart --- It seems that I messed something up with 15171. It should apply cleanly now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:27:06 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #20 from Jonathan Druart --- Created attachment 44764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44764&action=edit zsh:1: command not found: q Bug 14985: dbms expects a iso formatted date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:27:41 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #21 from Jonathan Druart --- I missed this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:27:52 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44764|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 44765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44765&action=edit Bug 14985: dbms expects a iso formatted date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:28:21 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic at tamil.fr --- Comment #16 from Fr?d?ric Demians --- It looks good. Minor merge conflict on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:42:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:42:21 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44679|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44766&action=edit [SIGNED-OFF]Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 Signed-off-by: Hector Castro Works as advertised. Both XML formats generated successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:42:44 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:51:11 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:51:15 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42196|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 44767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44767&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:53:12 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- Created attachment 44768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44768&action=edit Same MARC21 biblio record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:59:33 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 15:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 14:59:35 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39870|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 44769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44769&action=edit Skip articles in MARC21 using indicator n.2 of field 245 Only in MARC21 is possible to use ind2 of tag 245 to skip articles. This patch is based on inserting a special template in koha-indexdefs-to-zebra.xsl With this patch you must not insert index Title:s in biblio-koha-indexdefs.xml, it is defined in koha-indexdefs-to-zebra.xsl. It is not the best setup, but I find very difficult to use biblio-koha-indexdefs.xml. To test it in a english MARC21 setup: Insert same records with titles and correct values in ind2 of 245. If you have articles not in the skiping list of sort-string-utf.chr (The|the|a|A|an|An) you can see that the sort by articles use also articles. Insert the patch Rebuilt indexes from scratch Now all articles of titles are skipped TO TEST WITHOUT INDEXING: 1. Go to etc/zebradb/marc_defs/marc21/biblios directory. 2. Put the sample MARCXML file in this directory. 3. Transform the file into Zebra indexes: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: 01 Business and Technologies 4. Apply the patch. 5. Repeat: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: Business and Technologies Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:00:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:00:53 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44768|Same MARC21 biblio record |One MARC21 biblio record to description| |test the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:12:24 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:19:40 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:19:44 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #1 from Jonathan Druart --- Created attachment 44770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44770&action=edit Bug 13592: Add an option to charge for any hold placed Currently the fee is applied on if all items for the record are issued and at least one hold already exists on the record. This patch does not give a complete answer to the problem (see discussion on bug 13592 for the other user's expectations). It only adds the ability to charge for any hold placed regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:20:22 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #44770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:20:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:20:42 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Jonathan Druart --- Oops, typo in the bug number, sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:21:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:21:12 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:21:17 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #13 from Jonathan Druart --- Created attachment 44771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44771&action=edit Bug 13592: Add an option to charge for any hold placed Currently the fee is applied on if all items for the record are issued and at least one hold already exists on the record. This patch does not give a complete answer to the problem (see discussion on bug 13592 for the other user's expectations). It only adds the ability to charge for any hold placed regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:21:31 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:25:26 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15162 |15169 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 [Bug 15162] Add for Unimarc transformation to new metadata formats http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 [Bug 15169] Add for NORMARC transformation to new metadata formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:25:26 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13642 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 [Bug 13642] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:25:26 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 [Bug 13642] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:26:25 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15162, 15170 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 [Bug 15162] Add for Unimarc transformation to new metadata formats http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 [Bug 15170] Add 264 field to MARC21*DC.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:26:25 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 [Bug 13642] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:26:25 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 [Bug 13642] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:30:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:30:11 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- Implementation note: Some code seems to be repeated in various places: my @allowedipranges = split(' ', C4::Context->preference('SelfCheckAllowByIPRanges')); if (scalar @allowedipranges > 0) { unless (Net::CIDR::cidrlookup($ENV{'REMOTE_ADDR'}, Net::CIDR::range2cidr(@allowedipranges))) { # action exit; } } Couldn't it be a good candidate to a new function in C4::Auth? Or even a new parameter to C4::Auth::get_template_and_user()? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:33:59 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #4 from Jonathan Druart --- Are you sure it happens with the current zebra config? I get the problem with a UNIMARC install, but there is: 1437 1438 1439 item:w 1440 In etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml I don't see anything similar for MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:36:30 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:40:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:40:44 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #2) > Hector: this is you parch, with Magnus as assignee since he's in the best > position to sign it. > > To test with an NORMARC Catalog: > > - Open this URL > > /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml > > And play with id & format parameters > Test format=rdfdc and format=srw_dc > > - Or try with bug 13642 Just one question, Fr?d?ric. Does this bug need to apply bug 15162 on top? This is because changes to unapi are made it only on bug 15162. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:47:06 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #18 from Fr?d?ric Demians --- Thnaks for the rebase. It works as described. A new column in the 'Saved report' may be one too many. We can imagine scenario where librarian will run a report once a day. The 'Saved result' will be overcrowded. A simple tick in a column may be enough with detailed information reported to another page, or the 'run' page. There is a bug is the result page after you run any report. After the table containing the result, there is a section called 'Saved report results' displaying a table populated with "HASH(....)". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:48:30 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marc V?ron --- Oh, it is used... Sorry, I missed that while signing-off. To verify: - Home > Serials > New subscription - Click on "Search for a vendor" - You get a pop up window (...cgi-bin/koha/serials/acqui-search.pl) - Enter a search term, click OK => result 404 page (...cgi-bin/koha/serials/acqui-search-result.pl) It is used in ...serials/acqui-search.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:49:59 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #4 from Fr?d?ric Demians --- > Just one question, Fr?d?ric. Does this bug need to apply bug 15162 on top? > This is because changes to unapi are made it only on bug 15162. No, it's not necessary. It seems that opac/unapi were wrong for NORMARC, referencing XSL files that didn't exist, and that your patch introduces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:51:49 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15167 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15167 --- Comment #25 from Marc V?ron --- Moved 15167 from "Depends on" to "See also" Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 [Bug 15167] Remove unused script serials/acqui-search-result.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:51:49 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14969 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:55:21 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #5 from Mirko Tietgen --- IIRC it is in items.more_subfields_xml and ends up in the index that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 16:57:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 15:57:00 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Fr?d?ric I will change the commit message. Reproduce test isn't clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:08:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:08:30 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- > Could you give that a look? That should be a lot better now... thanks for > looking at this bug! Comment 6 is solved. When items.ccode isn't linked to a populated AV list, the collection code selection list isn't displayed in Inventory. I see that in the inventory result table, there is a new columun 'Collection code' which is displayed even when there isn't CCODE AV. Do you think there is a way to display or not this column? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:15:23 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:15:25 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40958|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 44772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772&action=edit Bug 14393 - Add collection code filter to inventory This patch adds the ability to do inventory by collection. _TEST PLAN_ Before applying: 1) Go to "Tools > Inventory/stocktaking" 2) Note that there is no "Collection code:" option Optionally: 2b) You can create a Barcode file with a single barcode 2c) Don't select anything from "Select items you want to check" (or filter if you know how to filter to make it faster... doesn't matter) 2d) Click "Submit" at the bottom of the screen 2e) Note that there is no "Collection code" column in the screen output or CSV output (ie with/without the "Export to CSV file" box ticked before submitting) Apply the patch. After applying: 3) Note that there is a "Collection code" filter on the main inventory screen 4) Create a Barcode file with a single barcode for an item with a collection and upload it using the "Choose file" button. 5) Select that item's collection code from the "Collection code" filter 6) Click "Submit" 7) Note that the screen output and the CSV output contains a "Collection code" column (ie with/without the "Export to CSV file" box ticked before submitting) Note: Collection code isn't displayed on Inventory filter & result if ccode isn't used in items. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:16:35 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44726|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44773&action=edit Bug 15170 - Add 264 field to MARC21*DC.xsl Modify MARC21*DC.xsl to add RDA 264 field To test: -Apply on top bug 15162 this introduce changes to unapi -Copy from LOC z39.50 the Maxwell's handbook for RDA (ISBN 9780838911723) -Look the field 264 in framework, save record - Open this URL in OPAC /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id (the number of new record for Maxwell book) & format parameters Test format=rdfdc, format=srw_dc and format=oai_dc -Notice that and are not present -Apply this patch -Reload the URL for the three formats -You will see the tags publisher and date are taken from 264 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:17:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:17:23 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #12 from Fr?d?ric Demians --- (In reply to Fr?d?ric Demians from comment #10) > I see that in the inventory result table, there is a new columun 'Collection > code' which is displayed even when there isn't CCODE AV. Do you think there > is a way to display or not this column? Forget this. I've added a [% IF %] in your patch that I've signed off in order to not display this column when unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:18:35 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15162 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 [Bug 15162] Add for Unimarc transformation to new metadata formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:18:35 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15170 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 [Bug 15170] Add 264 field to MARC21*DC.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:28:05 +0000 Subject: [Koha-bugs] [Bug 15167] Remove unused script serials/acqui-search-result.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #4 from Jonathan Druart --- How can I missed that?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:28:50 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15170 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 [Bug 15170] Add 264 field to MARC21*DC.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:28:50 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15162 | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Sorry, my mistake this patch no need bug 15162. Correcting attachment... Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 [Bug 15162] Add for Unimarc transformation to new metadata formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:30:51 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44773|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 44774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44774&action=edit Bug 15170 - Add 264 field to MARC21*DC.xsl Modify MARC21*DC.xsl to add RDA 264 field To test: -Copy from LOC z39.50 the Maxwell's handbook for RDA (ISBN 9780838911723) -Look the field 264 in framework, save record - Open this URL in OPAC /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id (the number of new record for Maxwell book) & format parameters Test format=rdfdc, format=srw_dc and format=oai_dc -Notice that and are not present -Apply this patch -Reload the URL for the three formats -You will see the tags publisher and date are taken from 264 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:34:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:34:35 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44763|0 |1 is obsolete| | --- Comment #26 from Marc V?ron --- Created attachment 44775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44775&action=edit Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. Tested on top of 15166 15168 15171, full browser reload for date pickers. Note for 4/: It is the link in tab planning on subscription detail page, near "Manual history" (if manual history is enabled). Works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:35:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:35:21 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:44:40 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #5 from H?ctor Eduardo Castro Avalos --- Hi Fr?d?ric Just one comment NORMARC use MARC21 instead 'NORMARC' => { 'marcxml' => 'identity.xsl', 'marcxml-full' => 'identity.xsl', 'mods' => 'MARC21slim2MODS.xsl', 'mods-full' => 'MARC21slim2MODS.xsl', 'mods3' => 'MARC21slim2MODS3-1.xsl', 'mods3-full' => 'MARC21slim2MODS3-1.xsl', 'oai_dc' => 'MARC21slim2OAIDC.xsl', 'rdfdc', => 'MARC21slim2RDFDC.xsl', 'rss2' => 'MARC21slim2RSS2.xsl', 'rss2-full' => 'MARC21slim2RSS2.xsl', 'srw_dc' => 'MARC21slim2SRWDC.xsl', }, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:53:08 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #6 from Jonathan Druart --- It should not if it's mapped with a DB field (bug 13023). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 17:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 16:58:38 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 --- Comment #6 from Fr?d?ric Demians --- > Just one comment NORMARC use MARC21 instead You're correct! I'd leave Magnus Enger decide whether it has to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:12:18 +0000 Subject: [Koha-bugs] [Bug 15175] New: IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Bug ID: 15175 Summary: IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty: the link on cover images in search.pl result page goes always to detail.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:12:40 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:12:40 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:14:33 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:14:35 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40851|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 44776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44776&action=edit Bug 14259: OPAC system preference BiblioDefaultView is ignored Cover image links ignore the BiblioDefaultView value for non-XSLT. XSLT was corrected in 12574. TEST PLAN --------- 1) Back up your database 2) drop you db and do a fresh install of the sample data 3) set koha admin to a super librarian, and set up a username and password for it. 4) catalog "The Road To Character" by David Brooks. 5) using koha admin import a small set of data. 6) stop zebra and do a full reindex then restart it. 7) Change the 'OPACXSLTDetailsDisplay' and 'OPACXSLTResultsDisplay' system preferences to blank! -- This corrects the non-XSLT things missed by 12574. 7) Change the 'GoogleJackets' system preference to 'Add'. 8) Change the 'BiblioDefaultView' system preference to 'in their MARC form'. 9) Change the 'IDreamBooksResults' system preference to 'Add'. 10) Search for something that will find "The Road To Character" and something else in the OPAC. 11) Run your mouse over the title text in the search results. -- Link will be to opac-MARCdetail.pl 12) Run your mouse over the cover image or lack thereof. -- Link will be to opac-detail.pl -- This will fail for both "The Road to Character" and the non-"The Road to Character" entries. 13) Apply this patch 14) Refresh the OPAC page -- Links under the cover images will be corrected. 15) In the staff client, change 'IDreamBooksReviews' to 'Add'. 16) Refresh the OPAC page -- "The Road to Character" will be correct, but have a '#idb_critic_reviews' appended. 17) run koha qa test tools Signed-off-by: Frederic Demians All combinations tested without/with this patch. Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 18:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 17:26:14 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|IntranetDefaultView syspref |IntranetBiblioDefaultView |is not respected when |syspref is not respected |XSLTResultsDisplay is empty |when XSLTResultsDisplay is | |empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 19:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 18:01:27 +0000 Subject: [Koha-bugs] [Bug 11431] Custom notification sounds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Custom sound alerts |Custom notification sounds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 19:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 18:03:57 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 19:03:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 18:03:59 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 --- Comment #1 from Fr?d?ric Demians --- Created attachment 44777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44777&action=edit Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 19:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 18:08:59 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Tom?s Cohen Arazi --- It fails now, on a different way but it fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 19:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 18:14:58 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- There is a inconsitency in the name of the syspref - ReserveFee (in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref) - HoldFeeMode (in all other files) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 20:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 19:25:35 +0000 Subject: [Koha-bugs] [Bug 15176] New: Add a sanity check when starting SIP2 (permissions) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15176 Bug ID: 15176 Summary: Add a sanity check when starting SIP2 (permissions) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: brendan at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Would be nice if when we start SIP2 that it checks that you have a user with permissions in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:04:15 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15166 --- Comment #24 from Marc V?ron --- Test passes OK with patch applied on top of Bug 15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref accept a string as parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:04:15 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14985 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:17:29 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:17:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:17:32 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44733|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44778&action=edit [PASSED QA] Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result Followed test plan, no results found. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:22:33 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Failed QA |Needs Signoff --- Comment #3 from Katrin Fischer --- Tests for template changes in .pl files are not required? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:27:28 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Martin, I am not sure about this change - Koha uses the patron's home category in a lot of places. Can you describe the use case for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 22:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 21:29:59 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:08:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:08:05 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44721|0 |1 is obsolete| | Attachment #44744|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 44779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44779&action=edit [PASSED QA] Bug 15166: Make output_pref takes a string in parameter To simplify the management of dates, it would be great that output_pref takes a string in parameter. my $date = $input->param('my_date'); $date = eval { dt_from_string( $date ) } if $date; $date = output_pref({dt => $date}) if $date; Could be replace with: my $date = output_pref({ str => $input->param('my_date') }); Tested with t/DateUtils.t, passed OK. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:08:02 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:08:22 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 --- Comment #6 from Katrin Fischer --- Created attachment 44780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44780&action=edit [PASSED QA] Bug 15166: Carp if an invalid date is passed Sign-off on second patch. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:08:47 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #275 from Tom?s Cohen Arazi --- Created attachment 44781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44781&action=edit Bug 7143: Add Marc Veron to the release team During this release cycle he worked really hard looking for things to fix. He's a brave bug wrangler and his name should be on the credits for 3.22. Period. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:12:51 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44781|0 |1 is obsolete| | --- Comment #276 from Katrin Fischer --- Created attachment 44782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44782&action=edit [PASSED QA] Bug 7143: Add Marc Veron to the release team During this release cycle he worked really hard looking for things to fix. He's a brave bug wrangler and his name should be on the credits for 3.22. Period. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Well deserved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:25:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:25:23 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:25:26 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44734|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44783&action=edit [PASSED QA] Bug 15171: Display subscriptions which will expire in the future Since the form on the subscription check expiration page let the user choose an expiration date > today, there is no sense to hide subscriptions which will expire in the future. Test plan: 0/ Make sure you have at least subscription with an expiration date > today 1/ Start a seach on the check expiration page (serials/checkexpiration.pl) with a date < today, = today and > today => The subscription won't never be displayed without this patch. With this patch, it will. Note that you will get a "No results for your query" message only if you have search for something. Followed testplan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:47:46 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #27 from Katrin Fischer --- I am sorry, but this page seems to break 'test prediction pattern'. Test: Add a new subscription This is what was sent: add1 1 add2 1 add3 1 custompattern 0 every1 48 every2 4 every3 1 firstacquidate 01/11/2015 frequency 4 lastvalue1 2015 lastvalue2 1 lastvalue3 1 numberingmethod Vol. {X}, Number {Y}, Issue {Z} setto1 1 setto2 1 setto3 1 sublength 15 subtype weeks to 31/12/2015 whenmorethan1 99999 whenmorethan2 12 whenmorethan3 4 This is the error I could extract from Firebug:

    Software error:

    Usage: Date::Calc::XS::Day_of_Week(year, month, day) at
/home/katrin/kohaclone/serials/showpredictionpattern
.pl line 115.
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:48:50 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #28 from Katrin Fischer --- Ah, and I tested this one on top of 15166 and 15171 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 11 23:51:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 22:51:10 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Katrin Fischer --- ... or I thought I did *sigh*... but of course I was missing 15166. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:09:12 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:09:14 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44609|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 44784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44784&action=edit [PASSED QA] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians A native English speaker could confirm that the wording is ok: Please select the image file to upload Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:02:06 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #30 from Katrin Fischer --- I think I found a real, but tiny bug now: - When switching the issue status from expected to arrived from the serials-edit page, today's page is shown including the time - but should only be a date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:13:48 +0000 Subject: [Koha-bugs] [Bug 15177] New: Sample notice TO_PROCESS confuses budget and fund Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Bug ID: 15177 Summary: Sample notice TO_PROCESS confuses budget and fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:20:51 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Depends on| |13014 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 [Bug 13014] Sent an email to the fund owner when a suggestion can be treated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:20:51 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to the fund owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15177 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 [Bug 15177] Sample notice TO_PROCESS confuses budget and fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:23:18 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 --- Comment #1 from Katrin Fischer --- Created attachment 44785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44785&action=edit Bug 15177: Sample notice TO_PROCESS confuses budget and fund Changes budget to fund in all TO_PROCESS notices but the German sample file. The German sample file will be dealt with in a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:47:38 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:47:48 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 --- Comment #2 from Katrin Fischer --- Created attachment 44786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44786&action=edit Bug 15058: Update German web installer sample files for 3.22 - Completes translations in German web installer sample files. - Adds AddressFormat = German to the default system preference settings. To test: - Run the web installer in German with all sample files selected - Confirm no error messages are shown - Bonus: if you speak German, check spelling and translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:49:22 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 00:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Nov 2015 23:49:25 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44785|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 44787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44787&action=edit Bug 15177: Sample notice TO_PROCESS confuses budget and fund Changes budget to fund in all TO_PROCESS notices but the German sample file. The German sample file will be dealt with in a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 02:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 01:57:27 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44648|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44788&action=edit [SIGNED-OFF]Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards Signed-off-by: Hector Castro All tests successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 02:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 01:57:55 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 03:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 02:39:46 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #26 from H?ctor Eduardo Castro Avalos --- Hi Genevieve Sorry but patch fails This is when invalid date is enter in both dates. Marc can help you with this kind of issues. Or see bugs related with Remove C4::Dates. Software error: The 'month' parameter ("32") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/lib/i386-linux-gnu/perl5/5.20/DateTime.pm line 197. DateTime::new(undef, "month", 32, "minute", 0, "hour", 0, "year", 2015, ...) called at /var/koha/koha/Koha/DateUtils.pm line 164 Koha::DateUtils::dt_from_string("12/32/2015", "metric") called at /var/koha/koha/reports/cash_register_stats.pl line 75 Another think is patch does not follow dateformat sypref at all I can see "Cash Register statistics 2015-11-12 to 2015-11-12" in form title but in interval from 12/11/2015 to 12/11/2015, both most display equal. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 03:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 02:49:38 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #27 from H?ctor Eduardo Castro Avalos --- Fix capitalization in form title "Cash Register statistics 2015-11-12 to 2015-11-12" Patch still apply, cvs exported successful data in screen display OK. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 03:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 02:57:37 +0000 Subject: [Koha-bugs] [Bug 14130] Update columns.def with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update column.def with |Update columns.def with |descriptions for new |descriptions for new |columns |columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 04:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 03:24:18 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:32:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:32:26 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:48:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:48:16 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:48:18 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 --- Comment #3 from Fr?d?ric Demians --- Created attachment 44789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44789&action=edit Bug 15177 TO_PROCESS notice for fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:48:35 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44789|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 44790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44790&action=edit Bug 15177 TO_PROCESS notice for fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:49:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:49:36 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 07:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 06:49:39 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44787|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 44791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44791&action=edit Bug 15177: Sample notice TO_PROCESS confuses budget and fund Changes budget to fund in all TO_PROCESS notices but the German sample file. The German sample file will be dealt with in a separate patch. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 08:17:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 07:17:34 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- Comment 7 issue is solved. Could you merge your 2 patches in one single patch? and include your test plan into the patch itself? Remarque: Admin > Column settings > Patrons > memberresultst is respected in normal patron search result table: you can hide the new column dateofbirth if necessary. But this is not respected by the autocompletion search result. From my point of view, it's an issue. But it's worth noting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 08:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 07:17:51 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 08:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 07:31:49 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |frederic at tamil.fr --- Comment #19 from Fr?d?ric Demians --- You add the new CHECKINSLIP to : installer/data/mysql/en/mandatory/sample_notices.sql As suggested by Katrin in comment 5, you should add this also in other languages samples notices: a cut-and-paste of the English version is enough. t/db_dependent/Members/IssueSlip.t raises warning about masking variables earlier declaration, and the test fails (for me). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 08:37:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 07:37:22 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #28 from Marc V?ron --- (In reply to H?ctor Eduardo Castro Avalos from comment #26) (...) > Marc can help you with this kind of issues. Or see bugs related with Remove > C4::Dates. (...) - Jonathan introduced Bug 15166 - Make output_pref accept a string as parameter. An example is to be found in acqui/invoice.pl line 84 (with Bug 14946 applied). - Todays date as dt: dt_from_string without any params. See example from Bug 14946, acqui/histsearch.pl, line 81: my $from_placed_on = eval { dt_from_string( $input->param('from') ) } || dt_from_string; -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 08:54:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 07:54:02 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Status|Needs Signoff |Failed QA --- Comment #21 from Fr?d?ric Demians --- In opac-messaging.pl, you should remove 'Authorized' parameter, and use in opac-messaging.tt: [% IF Koha.Preference( 'OPACEnhancedMessagingPreferences' ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 10:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 09:33:50 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #29 from Paul Poulain --- according to comment #26 it's more failed QA than need discussion -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 10:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 09:34:00 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42447|0 |1 is obsolete| | --- Comment #20 from Julian Maurice --- Created attachment 44792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44792&action=edit Bug 10662 - Build OAI-PMH Harvesting Client Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 10:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 09:34:12 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42448|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 44793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44793&action=edit Bug 10662 - DBIx::Class ResultSets for Testing Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 10:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 09:58:58 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #31 from Marc V?ron --- Created attachment 44794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44794&action=edit Bug 14969: (followup) Today's date withoute time when receiving To test: Change status of a serial from Expected to Received, today's date in column "Expected" should appear without time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:10:07 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #32 from Jonathan Druart --- (In reply to Marc V?ron from comment #31) > Created attachment 44794 [details] [review] > Bug 14969: (followup) Today's date withoute time when receiving > > To test: Change status of a serial from Expected to Received, > today's date in column "Expected" should appear without time. I was going to submit exactly the same patch. Thanks Marc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:25:48 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:25:51 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44767|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 44795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44795&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:28:37 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #20 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #18) > Thnaks for the rebase. It works as described. > > A new column in the 'Saved report' may be one too many. We can imagine > scenario where librarian will run a report once a day. The 'Saved result' > will > be overcrowded. A simple tick in a column may be enough with detailed > information reported to another page, or the 'run' page. Yes agreed, I have just tried to rescue this feature as quickly as possible. > There is a bug is the result page after you run any report. After the table > containing the result, there is a section called 'Saved report results' > displaying a table populated with "HASH(....)". The same variable name was used, I have changed one for 'saved_results'. I should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:49:06 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #3 from Martin Stenberg --- Hi Katrin, thanks for the feedback. The primary/home category is left unchanged with this patch, so that shouldn't be a problem. One use case would be a teacher who wish to make a personal loan and a loan for his/her class during the same session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 11:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 10:51:30 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Laurence Lefaucheur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.lefaucheur at biblibr | |e.com --- Comment #22 from Laurence Lefaucheur --- I am trying to test OAI harvest on a biblibre Marc21 sandbox following the test plan. I want to import oai_dc records, but the koha records created are always empty (only the leader field is present) I tried with Path to xslt = default, or set empty Record type : biblio Marc Framework : default What kind of metadata is allowed ? I see only this xslt file : MARC21slimFromOAI.xsl Should I previously create a specific oai to marc xslt stylesheet ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:16:40 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 --- Comment #4 from Katrin Fischer --- Hm, what about handling the overdues? Isn't the "chosen patron category" lost after checking out? So it would only be used for the loan period? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:28:55 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 --- Comment #5 from Martin Stenberg --- Hm, yes, looking at the overdue code, that seem to be the case. That must also mean that if you change a patrons category, all loans made while the patron belonged to the old category will be overdue-ruled according to the new category. But perhaps this is a desired effect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:52:06 +0000 Subject: [Koha-bugs] [Bug 15178] New: Update Italian web installer sample files for 3.22 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Bug ID: 15178 Summary: Update Italian web installer sample files for 3.22 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr - Completes translations in Italian of web installer sample files exept notices.sql becouse there is a bug on it [BUG 15177] - Some change in Italian default system preference settings. To test: - Run the web installer in Italian with all sample files selected - Confirm no error messages are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:52:40 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:53:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:53:14 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15177 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:53:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:53:14 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 12:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 11:53:29 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:01:00 +0000 Subject: [Koha-bugs] [Bug 15179] New: Marc field 084 does not show on bibliographic record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Bug ID: 15179 Summary: Marc field 084 does not show on bibliographic record Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: itu.bibl at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 44796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44796&action=edit Marc preview and bibliographic record. 084 is shown in Marc but not on the bibliographic record. In Sweden we use field 084 in marc to store the classification code. In Koha the 084 field does not show on the bibliographic record. This pertains both the staff client and the opac. I tried to leave the XSLTDetailsDisplay-field blank in administration, but it's the same result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:18:47 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 --- Comment #1 from Zeno Tajoli --- Created attachment 44797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44797&action=edit Update italian web istall sql files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:19:03 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:31:07 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #6 from Jonathan Druart --- Created attachment 44798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44798&action=edit Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:38:47 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44794|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 44799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44799&action=edit Bug 14969: (followup) Today's date withoute time when receiving To test: Change status of a serial from Expected to Received, today's date in column "Expected" should appear without time. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:39:48 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|blocker |critical --- Comment #7 from Jonathan Druart --- This is not "blocker". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:55:42 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:55:45 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44790|0 |1 is obsolete| | Attachment #44791|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 44800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44800&action=edit Bug 15177: Sample notice TO_PROCESS confuses budget and fund Changes budget to fund in all TO_PROCESS notices but the German sample file. The German sample file will be dealt with in a separate patch. Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:55:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:55:48 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 --- Comment #7 from Jonathan Druart --- Created attachment 44801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44801&action=edit Bug 15177 TO_PROCESS notice for fr-FR Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 13:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 12:55:51 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 --- Comment #8 from Jonathan Druart --- Created attachment 44802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44802&action=edit Bug 15177: Add missing coma in ru-RU Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:15:35 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:15:37 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44797|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44803&action=edit Update of Italian web installer .sql files for 3.22 - Not worked on notices.sql becouse there is a bug on it (Bz 15177) - Some change in Italian default system preference settings. To test: - Run the web installer in Italian with all sample files selected - Confirm no error messages are shown http://bugs.koha-community.org/show_bug.cgi?id=15178 Signed-off-by: Frederic Demians Proofreading OK. Web installer OK. Tutto bene, grazie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:17:54 +0000 Subject: [Koha-bugs] [Bug 15177] Sample notice TO_PROCESS confuses budget and fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15177 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina, Frederic and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:42:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:42:45 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #8 from Jonathan Druart --- Were not they going to be deprecated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:49:34 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #1 from Alex Arnaud --- Created attachment 44804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44804&action=edit Bug 15165 - Add API route to list accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:49:42 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #3 from Alex Arnaud --- Created attachment 44806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44806&action=edit Bug 15165 - Add API routes to pay accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:49:38 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #2 from Alex Arnaud --- Created attachment 44805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44805&action=edit Bug 15165 - Add API route to edit accoulines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:51:15 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:54:15 +0000 Subject: [Koha-bugs] [Bug 13935] Add API route to list borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13935 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Julian Maurice --- Duplicate of bug 15165, which do more than this bug's patch *** This bug has been marked as a duplicate of bug 15165 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 14:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 13:54:15 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- *** Bug 13935 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:08:28 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement Version|3.20 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Krister, thx for filing a bug report. I am changing this to enh, because it's not a bug per definition. But it's certainly worth adding to the XSLT displays. The normal view that you see when you leave the XSLT prefs empty is no longer actively maintained and missing a lot of information - I'd recommend sticking with the default XSLT. Btw - not only in Sweden :) 084 is used whenever you have something that didn't end up having it's own field, like DDC or UDC have. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:23:30 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44786|0 |1 is obsolete| | --- Comment #3 from Zeno Tajoli --- Created attachment 44807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44807&action=edit [SIGN-OFF] Update German web installer sample files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:23:44 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:24:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:24:11 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:25:06 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #4 from Zeno Tajoli --- Signed-off: It works on web installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:46:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:46:54 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 --- Comment #5 from Mirko Tietgen --- Created attachment 44808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44808&action=edit Bug 15058: Update German web installer sample files for 3.22 - Completes translations in German web installer sample files. - Adds AddressFormat = German to the default system preference settings. To test: - Run the web installer in German with all sample files selected - Confirm no error messages are shown - Bonus: if you speak German, check spelling and translations Signed-off-by: Zeno Tajoli Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:47:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:47:27 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 15:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 14:47:47 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Mirko Tietgen --- Checked translations and spelling too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 16:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 15:18:16 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44777|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44809&action=edit [SIGNED-OFF]Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro Link to right display according with IntranetBiblioDefaultView is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 16:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 15:18:39 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 16:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 15:45:48 +0000 Subject: [Koha-bugs] [Bug 15180] New: Update Italian web installer sample files for 3.20 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Bug ID: 15180 Summary: Update Italian web installer sample files for 3.20 Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 16:46:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 15:46:07 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:17:36 +0000 Subject: [Koha-bugs] [Bug 15181] New: Rename fast add framework sql file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Bug ID: 15181 Summary: Rename fast add framework sql file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Testing install (en,it,es) results in FastAdd framework empty! New version of this file depends on loading default framework first, but currently it's loaded before default. SQL files are loaded in alphabetical order (without path) as stated on load_sql_in_order sub in C4/Installer.pm mysql/en/marcflavour/marc21/optional/marc21_fastadd_framework.sql mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql A name change is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:24:38 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:24:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:24:52 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44761|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 44810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44810&action=edit [SIGNED-OFF] Bug 15070: Update MARC21 it-IT frameworks to Update 21 (September 2015) To test it: - drop and recrate Koha DB - Run the Koha web installer for it-IT - Run MARC bibliographic framework test http://bugs.koha-community.org/show_bug.cgi?id=15070 Signed-off-by: Bernardo Gonzalez Kriegel Tested with it-IT installer All files load without problem, save for FastAdd (see Bug 15181) but the file loads Ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:31:35 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #1 from Zeno Tajoli --- Probably it is enough chage mysql/en/marcflavour/marc21/optional/marc21_fastadd_framework.sql into mysql/en/marcflavour/marc21/optional/marc21_framework_fastadd.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:42:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:42:15 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #21 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:43:49 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |z.tajoli at cineca.it |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:43:58 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44736|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 44811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44811&action=edit [SIGNED-OFF]Bug 15172 - Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:44:27 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:45:22 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 44812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44812&action=edit Bug 15181: Rename marc21 fast add framework sql file This patch simply renames fast add sql file in order to load this file before default framework. To test: 1) Do a marc21 install (de,en,es,it) load all sample files check Fast Add framework is empty (no fields/subfields) 2) Apply the patch 3) Do an install again, this time FastAdd must have values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:46:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:46:47 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch --- Comment #3 from Bernardo Gonzalez Kriegel --- Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 17:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 16:54:06 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Or when a basket was closed and opened to track if this is done multiple times. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:09:17 +0000 Subject: [Koha-bugs] [Bug 15182] New: make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Bug ID: 15182 Summary: make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org Created attachment 44813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44813&action=edit make test output Running on openSUSE Leap 42.1 Run perl Makefile.PL --prev-install-log /usr/share/koha/misc/koha-install-log make make test make test fails on t/00-load.t while trying to use Crypt::GCrypt in NorwegianPatronDB.pm See the attached file. Crypt::GCrypt is not marked as required and in fact does not work with libgcrypt 1.6.1. This was reported in 2014. Deleting libgcrypt 1.6.1 would cause 794 other modules including systemd to be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:09:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:09:25 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:18:09 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44812|0 |1 is obsolete| | --- Comment #4 from Zeno Tajoli --- Created attachment 44814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44814&action=edit [SIGN_OFF]Rename marc21 fast add framework sql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:18:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:18:24 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:19:39 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|z.tajoli at cineca.it |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:35:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44729|0 |1 is obsolete| | --- Comment #142 from H?ctor Eduardo Castro Avalos --- Created attachment 44815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44815&action=edit Bug 13642 - Add Unit test for C4::Record::marc2dcxml Add Unit test for C4::Record::marc2dcxml To test: prove t/db_dependent/Record.t prove t/db_dependent/Record/Record.t Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:45:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:45:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #143 from H?ctor Eduardo Castro Avalos --- Created attachment 44816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44816&action=edit Bug 13642 - Remove MARC::Crosswalk::DublinCore from Koha To test: 1) git grep "MARC::Crosswalk::DublinCore" C4/Installer/PerlDependencies.pm: 'MARC::Crosswalk::DublinCore' => { INSTALL.fedora7:MARC::Crosswalk::DublinCore 2) git grep "libmarc-crosswalk-dublincore-perl" debian/control: libmarc-crosswalk-dublincore-perl, debian/control: libmarc-crosswalk-dublincore-perl, install_misc/debian.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.10.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.12.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.packages:libmarc-crosswalk-dublincore-perl install 3) Repeat step 1 and 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:51:04 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #144 from H?ctor Eduardo Castro Avalos --- Hi Fr?d?ric Please sign-off the last two patches, I found another Unit Test (t/db_dependent/Record/Record.t) that affect the marc2dxml method; and finally remove the MARC::Crosswalk::DublinCore module (libmarc-crosswalk-dublincore-perl) Thanks in advance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 18:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 17:51:21 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 19:46:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 18:46:39 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #6 from Viktor Sarge --- > I am not sure about this change - Koha uses the patron's home category in a > lot of places. Can you describe the use case for this? We developed this one as a bit of a favor to Lule? who have been in need of this feature (though I think they will change their rules now instead). It's quite common for libraries here to have multiple accounts for the same patron depending on in which role they use the library. We have lots of integrated libraries that are both the school and community library at the same time. That means that the same library will serve the same patrons as both students/teachers and as ordinary child/adult accounts. One solution might be to switch library but that will mess up shelving since there's actually only one library and is also impractical when the public can access the library during school hours. This patch would mean that it's a bit easier to handle that type of problems without ugly hacks. When discussing this development Martin did identify a whole lot of places expecting a single code (73 I think), but we suspect that checkout and overdue notices/fees may be enough for the scope of this problem. Before doing further development I think that we need to see that others would find this useful and that it has a fighting chance to get accepted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 20:00:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 19:00:05 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com, | |tomascohen at gmail.com --- Comment #1 from H?ctor Eduardo Castro Avalos --- This is launched becuase C4::Accounts depends from C4::Members and C4::Members depends on Koha::NorwegianPatronDB. All modules required by "Norwegian national library card" are not required: 'SOAP::Lite' => { 'usage' => 'Norwegian national library card', 'required' => '0', 'min_ver' => '0.712', }, 'Crypt::GCrypt' => { 'usage' => 'Norwegian national library card', 'required' => '0', 'min_ver' => '1.24', }, 'Convert::BaseN' => { 'usage' => 'Norwegian national library card', 'required' => '0', 'min_ver' => '0.01', }, 'Digest::SHA' => { 'usage' => 'Norwegian national library card', 'required' => '0', 'min_ver' => '5.61', }, In debian this is not a problem, since package in available sudo apt-get install libcrypt-gcrypt-perl. I add here Tom?s (RM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 20:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 19:48:12 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #13 from Josef Moravec --- Created attachment 44817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44817&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 20:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 19:50:03 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44692|0 |1 is obsolete| | Attachment #44693|0 |1 is obsolete| | Attachment #44817|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 44818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44818&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 20:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 19:55:42 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #15 from Josef Moravec --- Thanks for testing Fr?d?ric. I squashed the commits and again rebased on master. I think the autocomplete is not configurable at all, so we could open new bug, if somebody need it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:12:32 +0000 Subject: [Koha-bugs] [Bug 6069] Multiple level budget list on suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:18:05 +0000 Subject: [Koha-bugs] [Bug 14815] Different leader values per framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:25:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:25:09 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:25:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:25:13 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44816|0 |1 is obsolete| | --- Comment #145 from Fr?d?ric Demians --- Created attachment 44819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44819&action=edit Bug 13642 - Remove MARC::Crosswalk::DublinCore from Koha To test: 1) git grep "MARC::Crosswalk::DublinCore" C4/Installer/PerlDependencies.pm: 'MARC::Crosswalk::DublinCore' => { INSTALL.fedora7:MARC::Crosswalk::DublinCore 2) git grep "libmarc-crosswalk-dublincore-perl" debian/control: libmarc-crosswalk-dublincore-perl, debian/control: libmarc-crosswalk-dublincore-perl, install_misc/debian.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.10.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.12.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.packages:libmarc-crosswalk-dublincore-perl install 3) Repeat step 1 and 2 Signed-off-by: Frederic Demians Ripping out any mention to MARC::Crosswalk::DublinCore can't hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:31:38 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #16 from Fr?d?ric Demians --- > I think the autocomplete is not configurable at all, so we could open new > bug, if somebody need it. The other option would be to not add the date of birth to the autocompletion. I wrote earlier by mistake: "From my point of view, it's an issue." I think exactly the contrary, IMO it's NOT an issue. The date of birth doesn't take that much space, and add a valuable information on the autocompletion search result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:43:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #146 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #145) > Signed-off-by: Frederic Demians > Ripping out any mention to MARC::Crosswalk::DublinCore can't hurt. Getting rid really can't hurt, IMHO git grep "marc2dcxml" C4/Record.pm: &marc2dcxml C4/Record.pm:=head2 marc2dcxml - Convert from ISO-2709 to Dublin Core C4/Record.pm: my dcxml = marc2dcxml ($marc, $xml, $biblionumber, $format); C4/Record.pm: my dcxml = marc2dcxml (undef, undef, 1, "oaidc"); C4/Record.pm:sub marc2dcxml { catalogue/export.pl: $marc = marc2dcxml(undef, undef, $biblionum opac/opac-export.pl: $marc = marc2dcxml(undef, undef, $biblionumber, $format t/db_dependent/Record.t:my $marcsrwdc=marc2dcxml( $marc, undef, undef, "srwdc" t/db_dependent/Record.t:my $marcoaidc=marc2dcxml( $marc, undef, undef, "oaidc" t/db_dependent/Record.t:my $marcrdfdc=marc2dcxml( $marc, undef, undef, "rdfdc" t/db_dependent/Record/Record.t:ok (eval{marc2dcxml($marc21_utf8, undef, undef, All files affected has been changed to the new marc2dcxml method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:46:24 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:49:20 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44302|0 |1 is obsolete| | --- Comment #22 from Bouzid --- Created attachment 44820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44820&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:49:24 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com --- Comment #17 from Nicole Engard (ByWater) --- I feel there are many improvements we could make here, but as it stands it's usable whereas before it was way too unclear. I'm okay with it going in this way and then us doing some improvements on look and feel and notifications. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:51:07 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:51:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:51:10 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44818|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Created attachment 44821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44821&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:56:04 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:56:07 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44766|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 44822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44822&action=edit Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Fix also, marginaly, OAI-DC XSL file which were using 090$a as biblionumber rather than 001. To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 21:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 20:58:40 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44822|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 44823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44823&action=edit Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Fix also, marginaly, OAI-DC XSL file which were using 090$a as biblionumber rather than 001. To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:00:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:00:05 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44823|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 44824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44824&action=edit Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Fix also, marginaly, OAI-DC XSL file which were using 090$a as biblionumber rather than 001. To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:00:33 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #23 from Bouzid --- I removed 'Authorized' parameter in opac-messaging.pl and used in opac-messaging.tt [% IF Koha.Preference( 'OPACEnhancedMessagingPreferences' ) %]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:09:23 +0000 Subject: [Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bouzid.fergani at inlibro.com |ity.org | CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:13:01 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:15:25 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44824|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 44825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44825&action=edit [SIGNED-OFF]Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Fix also, marginaly, OAI-DC XSL file which were using 090$a as biblionumber rather than 001. To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 Signed-off-by: Hector Castro Works as advertised. Both XML formats generated successfully. Also fix problem with OPACBaseURL in UNIMARC environment. Tested with Sandbox too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:15:47 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:25:18 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #24 from Fr?d?ric Demians --- (In reply to Bouzid from comment #23) > I removed 'Authorized' parameter in opac-messaging.pl > and used in opac-messaging.tt [% IF Koha.Preference( > 'OPACEnhancedMessagingPreferences' ) %]. Thanks. The code seems OK now. I realize that the wording of the 2 sysprefs are not that clear. The two together. And it's not your syspref which sound strange bug the initial: EnhancedMessagingPreferences: Allow/Don't allow patrons to choose which notices they receive and when they receive them. Note that this only applies to certain kinds of notices. This give the feeling that the patron will be allowed to change their notifications themselves. Anyway your patch works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:28:59 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:29:03 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44820|0 |1 is obsolete| | --- Comment #25 from Fr?d?ric Demians --- Created attachment 44826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44826&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 22:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 21:53:43 +0000 Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- I'll have a look into this thank you for your report. CHeers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 12 23:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 22:20:36 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 00:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 23:18:22 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #147 from David Cook --- (In reply to H?ctor Eduardo Castro Avalos from comment #138) > (In reply to David Cook from comment #137) > > > Yeah, I'd like to be involved as well. I think Magnus Enger has already > > started doing prototype work on this with SemantiKoha, so it'll be > > interesting. > > > > Certainly something to discuss with the whole group, I think. > > Hi David > > Where is placed Magnus' works? I'm really interested in this kind of > subjects too. Another think is -as explain me Bernardo- the plack > environment needs to be complete to use modules with Moose support, this is > because some packages like RDF::Trine and RDF::Query need it. Hi H?ctor, The blog post about it is here http://libriotech.no/blogs/semantikoha and it includes links to the source code. It's been a few years since Magnus has worked on it, I think, but I think he might be interested in reviving it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 00:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 23:25:48 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #23 from David Cook --- (In reply to Laurence Lefaucheur from comment #22) > I am trying to test OAI harvest on a biblibre Marc21 sandbox following the > test plan. > > I want to import oai_dc records, but the koha records created are always > empty (only the leader field is present) > > I tried with Path to xslt = default, or set empty > Record type : biblio > Marc Framework : default > > What kind of metadata is allowed ? > I see only this xslt file : MARC21slimFromOAI.xsl > Should I previously create a specific oai to marc xslt stylesheet ? Hi Laurence: Yes, you'll need to create a OAIDC2MARC XSLT in order to transform the metadata into MARC21. Since Koha only supports MARC, the record the OAI-PMH harvester passes to Koha's internal code must also be in MARC. Long ago, I thought about creating a XSLT to convert from oai_dc into MARCXML, but I found it to be a very error-prone process, since oai_dc is such a simple metadata format and MARC is quite complex. I was never happy with the conversion from oai_dc to MARC. With DSpace, I plan to create a DIM to MARC XSLT which I'll probably use on DSpace itself so that I don't have to do anything special on the harvester end. DIM is DSpace's internal metadata format, and I found that to be much better than oai_dc for converting to MARC. So my recommendation is to harvest in MARC, but where that's impossible and you still want access to the record... you'll have to point "Path to XSLT" at a different stylesheet which can convert oai_dc to MARCXML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 00:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Nov 2015 23:27:09 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #24 from David Cook --- I've received a lot of feedback from the National Library of Sweden, so there will probably be more comments going up soon on Bugzilla regarding our discussions about changes to the code that I've posted here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 01:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 00:21:41 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hm, patch doesn't apply for me, am I missing a dependency? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15181: Rename marc21 fast add framework sql file fatal: sha1 information is lacking or useless (installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_fastadd_framework.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 01:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 00:27:22 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 --- Comment #3 from Katrin Fischer --- Created attachment 44827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44827&action=edit [PASSED QA] Update of Italian web installer .sql files for 3.22 - iNot worked on notices.sql becouse there is a bug on it (Bz 15177) - Some change in Italian default system preference settings. To test: - Run the web installer in Italian with all sample files selected - Confirm no error messages are shown http://bugs.koha-community.org/show_bug.cgi?id=15178 Signed-off-by: Frederic Demians Proofreading OK. Web installer OK. Tutto bene, grazie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 01:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 00:31:20 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 01:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 00:31:22 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 03:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 02:44:27 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #2 from Tom?s Cohen Arazi --- Bob, I've tested this on Jessie and I cannot reproduce. So it seems your openSuSE box doesn't have all the dependencies installed in order to run make test. Can you just install it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:10:26 +0000 Subject: [Koha-bugs] [Bug 15183] New: Workflow to duplicate orders for serials from one year to the next Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15183 Bug ID: 15183 Summary: Workflow to duplicate orders for serials from one year to the next Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For a library with a lot of serials subscriptions it's a lot of work at the end of the year to create orders for all their serials at the end of the year so the expected amount is accounted for in the budgets and funds. It would be nice if there was a way to duplicate all subscription orders for active subscriptions from one year into the next. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:14:08 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7349 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:14:08 +0000 Subject: [Koha-bugs] [Bug 7349] Sorting patron search result by cardnumber doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15109 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:15:49 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #4 from Jonathan Druart --- There is already a DT sort parameter in the template: 'aaSorting': [[1, 'asc']], This one should be modified. Moreover this script does not check for the existence of the checkboxes in the first column ([% IF CAN_user_tools_manage_patron_lists %]), which places the cardnumber in 0 or 1. I will provide a counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:16:04 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:16:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:16:54 +0000 Subject: [Koha-bugs] [Bug 15183] Workflow to duplicate orders for serials from one year to the next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15183 --- Comment #1 from Katrin Fischer --- Hm, alternatively: instead of duplicating all in a batch, we could maybe add an option for a 'continuing order' that will automatically be duplicated when you do the financial rollover at the end of your budget term. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:22:41 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:22:44 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44296|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 44829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44829&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:22:49 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #6 from Jonathan Druart --- Created attachment 44830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44830&action=edit Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:28:47 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44303|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 44831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44831&action=edit Bug 15079 - Batch Delete Records Error When using the batch deletion tool, if the script attempts to delete an undeletable item, the script will die with the error: Label not found for "next BIBLIONUMBER" at /usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172. Test Plan: 1) Attempt to batch delete a record with an item that cannot be deleted 2) Note error 3) Apply this patch 4) Repeat step 1 5) Note the error no longer occurs Signed-off-by: Hector Castro Works as advertised. Follow comment 5 to reproduce the issue Signed-off-by: Jonathan Druart I have not tested this patch, but looking at the code it is obviously a mistake. If an error occured, we rollback and skip this record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:28:44 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:35:00 +0000 Subject: [Koha-bugs] [Bug 15183] "Continuing" orders for serials, databases and similar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Workflow to duplicate |"Continuing" orders for |orders for serials from one |serials, databases and |year to the next |similar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:35:57 +0000 Subject: [Koha-bugs] [Bug 15184] New: Ability to duplicate an existing order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Bug ID: 15184 Summary: Ability to duplicate an existing order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In some cases it would be nice if it was possible to duplicate an order easily (serials, databases, etc.). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:45:09 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:45:13 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44807|0 |1 is obsolete| | Attachment #44808|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 44832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44832&action=edit Bug 15058: Update German web installer sample files for 3.22 - Completes translations in German web installer sample files. - Adds AddressFormat = German to the default system preference settings. To test: - Run the web installer in German with all sample files selected - Confirm no error messages are shown - Bonus: if you speak German, check spelling and translations Signed-off-by: Zeno Tajoli Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:45:53 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44832|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 44833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44833&action=edit Bug 15058: Update German web installer sample files for 3.22 - Completes translations in German web installer sample files. - Adds AddressFormat = German to the default system preference settings. To test: - Run the web installer in German with all sample files selected - Confirm no error messages are shown - Bonus: if you speak German, check spelling and translations Signed-off-by: Zeno Tajoli Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:48:35 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- Does it affect 3.18.x only? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 10:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 09:54:31 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #10 from Jonathan Druart --- Comment on attachment 44533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44533 y# Attachment to Bug 12748 - Serials - two issues with status of Review of attachment 44533: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12748&attachment=44533) ----------------------------------------------------------------- 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted Would be good to have a test for this step too. ::: C4/Serials.pm @@ +1172,5 @@ > } > } > > + # create new expected entry if needed (ie : was "expected" and has changed) > + # BUG 12748: Check if there are no other expected issues. No need to set the bug# in the code, we use git. @@ +2810,5 @@ > +=head2 findSerialByStatus > + > + @serials = findSerialByStatus($status, $subscriptionid); > + > + Returns an array of serials matching a given status and subscription id. findSerialsByStatus sounds more appropriate, do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 11:00:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 10:00:35 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 --- Comment #9 from Jonathan Druart --- http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated """ As of 2014-07-02, use of the XSLT search results and bib details display templates for the staff interface and public catalog is now the preferred option. Consequently, the non-XSLT option is now deprecated and it will not be maintained. """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 11:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 10:44:25 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #12 from bondiurbano --- Same problem in 3.20.04 and 3.20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:34:54 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #13 from Fridolin SOMERS --- An example contained in sample, the 38th record : Without patch : Mexique, le nouveau ?tigre azt?que? ? Shannon K. O'Neil (0032-9304) With patch : Mexique, le nouveau ?tigre azt?que? ? Shannon K. O'Neil (0032-9304) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:39:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:39:07 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:39:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:39:10 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44052|0 |1 is obsolete| | Attachment #44053|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 44834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44834&action=edit Bug 14078 - converting from ISO5426 is not complete Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This patch changes some odd actual conversions. In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater : ($char >= 0xC0 && $char <= 0xDF) So conversion like "$chars{0x81d1}=0x00b0" will never be used. Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5. See http://www.gymel.com/charsets/MAB2.html Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:39:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:39:15 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #15 from Jonathan Druart --- Created attachment 44835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44835&action=edit Bug 14078 - converting from ISO5426 is not complete - followup1 Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This patch adds missing conversions. See http://www.gymel.com/charsets/MAB2.html Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:43:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:43:27 +0000 Subject: [Koha-bugs] [Bug 15185] New: 3 subroutines are unused in C4::Circulation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Bug ID: 15185 Summary: 3 subroutines are unused in C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:45:50 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 12:45:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 11:45:54 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 --- Comment #1 from Jonathan Druart --- Created attachment 44836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44836&action=edit Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:21:34 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44814|0 |1 is obsolete| | --- Comment #6 from Zeno Tajoli --- Created attachment 44837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44837&action=edit [SIGN_OFF] Remove MARC21 fast add framewors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:21:47 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:23:26 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 --- Comment #7 from Zeno Tajoli --- Probably in my sign-off I have done something work. In fact the patch does only a massive rename but, as I see on Google, it is prone-error operation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:24:40 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 --- Comment #8 from Zeno Tajoli --- Probably in my previous sign-off I have done something WRONG. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:41:56 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44771|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 44838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44838&action=edit Bug 13592: Add an option to charge for any hold placed Currently the fee is applied on if all items for the record are issued and at least one hold already exists on the record. This patch does not give a complete answer to the problem (see discussion on bug 13592 for the other user's expectations). It only adds the ability to charge for any hold placed regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 13:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 12:42:28 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #16 from Jonathan Druart --- (In reply to Marc V?ron from comment #14) > There is a inconsitency in the name of the syspref Sorry about that, last minute change :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 14:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 13:42:04 +0000 Subject: [Koha-bugs] [Bug 15186] New: lack of select records on 3.22 in staff admin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15186 Bug ID: 15186 Summary: lack of select records on 3.22 in staff admin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 44839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44839&action=edit screenshot of the potential bug After a search in staff client no select options for the records are available Ubuntu 14.04 Same results with and without plack enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 14:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 13:57:56 +0000 Subject: [Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42691|0 |1 is obsolete| | --- Comment #4 from Bouzid --- Created attachment 44840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44840&action=edit Bug 14846 - Items with no holdingbranch causes svc/holds to crash When trying to display the holds for a user, if an item has no holdingbranch, it causes the svc/holds service to crash and the display to freeze. Tentative steps to reproduce on any DB: 1) put 1 or more items on hold for a given user. 2) go into the database and set the item.holdingbranch to NULL 3) In the user's page, in checkouts (circulation.pl), click the tab that should be written 1 Hold(s) 4) It will be "Processing" indefinitely. The cause is the svc/holds code that crashes. The fix will validate that there's an holdingbranch before proceding with the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 14:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 13:59:07 +0000 Subject: [Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:09:56 +0000 Subject: [Koha-bugs] [Bug 15186] lack of select records on 3.22 in staff admin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15186 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you confirm that you get the issue even on the non-translated interface (English/en)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:10:41 +0000 Subject: [Koha-bugs] [Bug 15186] lack of select records on 3.22 in staff admin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15186 --- Comment #2 from Jonathan Druart --- Ok, I reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:14:24 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |bouzid.fergani at inlibro.com CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:17:47 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #26 from Jonathan Druart --- Created attachment 44841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44841&action=edit Bug 14915: (follow-up) [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o Reported on bug 15186. Test plan: Do a search on the staff interface You will get an error in the console and the image + checkboxes are not display. With this patch it will be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:18:39 +0000 Subject: [Koha-bugs] [Bug 15186] lack of select records on 3.22 in staff admin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15186 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Druart --- I have submited a patch on bug 14915, it will certainly be pushed quickly by Tomas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:23:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:23:33 +0000 Subject: [Koha-bugs] [Bug 15186] lack of select records on 3.22 in staff admin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15186 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Bug fixed, thanks for reporting, Hugo! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:27:29 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15182 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:27:29 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |15151 --- Comment #3 from Jonathan Druart --- Caused by commit f25fe6ddb4a340f12613784dc841ab5bfd672d6b Date: Fri Nov 6 11:21:56 2015 -0300 Bug 15151: Avoid DB access to load C4::Members Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:33:30 +0000 Subject: [Koha-bugs] [Bug 15166] Make output_pref accept a string as parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:34:23 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:34:55 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:06 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:09 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 --- Comment #1 from Zeno Tajoli --- Created attachment 44843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44843&action=edit Update italian web install 3.20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:09 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #4 from Jonathan Druart --- Created attachment 44842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44842&action=edit Bug 15182: Continue to consider Crypt::GCrypt optional Caused by commit f25fe6ddb4a340f12613784dc841ab5bfd672d6b Date: Fri Nov 6 11:21:56 2015 -0300 Bug 15151: Avoid DB access to load C4::Members Make Koha::NorwegianPatronDB requires on loading C4::Members. But Koha::NorwegianPatronDB uses Crypt::GCrypt which is marked as optional in the deps list. This patch suggest to load the module only if it can be loaded and does not explode otherwise. Another solution would be to surround the require with an eval, to avoid to load Module::Load when C4::Members is used. Test plan: uninstall Crypt::GCrypt and try to access the staff interface. Without this patch, you will get a software error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:26 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:29 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:39:38 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:40:21 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:47:04 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #32 from Jonathan Druart --- Fixed in 3.22 by bug 14544. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:47:20 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44842|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 44844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44844&action=edit [SIGNED-OFF]Bug 15182: Continue to consider Crypt::GCrypt optional Caused by commit f25fe6ddb4a340f12613784dc841ab5bfd672d6b Date: Fri Nov 6 11:21:56 2015 -0300 Bug 15151: Avoid DB access to load C4::Members Make Koha::NorwegianPatronDB requires on loading C4::Members. But Koha::NorwegianPatronDB uses Crypt::GCrypt which is marked as optional in the deps list. This patch suggest to load the module only if it can be loaded and does not explode otherwise. Another solution would be to surround the require with an eval, to avoid to load Module::Load when C4::Members is used. Test plan: uninstall Crypt::GCrypt and try to access the staff interface. Without this patch, you will get a software error. Signed-off-by: Hector Castro Works as advertised. No software error without optional module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:47:39 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:51:26 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:51:42 +0000 Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13669, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14637 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:51:42 +0000 Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:51:42 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14952 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:52:51 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #25 from Andreas Hedstr?m Mace --- The National Library of Sweden have together with Stockholm University Library provided the funding required for David to finalize his work on the harvester. Stockholm University Library has been testing the OAI-PMH harvester extensively of late, and have provided feedback and been in discussion with Dave about the development of the harvester. Here I?ll try to summarize our discussions. David will probably have to fill in the gaps where needed, and provide further detail! Our use case We are harvesting records from the Swedish union catalogue LIBRIS, which provides records in Marcxml. Today only bibliographic records are harvested, but we hope to add functionality in the future to also allow holdings to be harvested (but this is a separate development and won?t be discussed further here.) We would want to harvest repeatedly and often, preferably every 5 seconds or so, to always have up-to-date records in our local system. Cataloging is done in LIBRIS. Core functionality * The harvester works as intended, where we have tried harvesting record, editing/deleting them at the source and then reharvesting them. All works as intended. * We also tried to delete a record in Koha and then do a harvest ? the intended error message is displayed (?Harvested records in error state?). * It?s very good that the HTTP and OAI-PMH parameters for the OAI server target can be tested directly! (I was trying to set up LIBRIS SRU server in Koha the other day and was frustrated that I had to go to cataloging to test whether or not I had set-up correct parameters?) All in all, the harvester works as intended! Major issues Repeated harvests The harvester as built today is made to run one-time harvest or repeating harvest that are long in between ? like once every night. For those use cases, performing the scheduling in the GUI and then running the job with the cronjob (the download and the import parameters) is not a problem. But for repeated tasks, this divided responsibility is highly problematic. We would like to have all harvests (or tasks) set from the GUI! To facilitate this, David has proposed to change the functionality of the harvester to work as a daemon instead. The reasons for these is as follows: * Using the daemon, all scheduling can be handled by the GUI * Using the daemon, you could harvest every few seconds. The original intent with the cronjob was that it would be set once and never looked at again. The harvesting would just happen in the background. But since you want more control and to run the harvest every few seconds, a daemon is the way to go. * The key benefit of using the daemon is that you can control it from the GUI and that it can manage the harvests. Trying to set/schedule a cronjob from the GUI would be a bad idea. * If you?re trying to re-harvest every few seconds, a cronjob could easily get out of control. You could easily have competing processes and no way to control them at all. A daemon couldn?t be a communications centre in the way described. The way I envision it, the daemon will communicate with the Web GUI. You could start, stop, and pause harvests. The daemon would also be in charge of the actual harvest, as it could control its own activity. You can?t really control a cronjob. The cron daemon starts cronjobs based on its own unique syntax and that?s it. It?s just a scheduler. It?s not a controller. The daemon I?m talking about would be a controller. You could tell it ?STOP 1? and it would stop running the harvest with the 1 identifier. David could preferably provide more detail on the proposed daemon approach. We had some initial reservations about the use of a daemon for the harvester, mainly as this would be a background process that might be hard to evaluate/work with for a systems administrator, to which David replied: * Why would it be hard for a systems administrator to evaluate/work with a daemon? It seems to me that it would actually be easier for sysadmins to evaluate/work with a daemon, as it can be monitored and controlled as a separate process. It?s much easier to control than a cronjob. It would be good to have input from others in the community on the merits of having the harvester run as a daemon! Matching rules At the moment there are not matching rules for the harvester per se. The only matching that is done is based on the OAI-PMH unique identifier. If there?s already a record in Koha with the same title, but not the same OAI-PMH unique identifier, you will get a duplicate. Not having matching rules will essentially make the harvester useless for us, and I would guess anyone harvesting from a union catalogue. We don?t want to add a lot of unnecessary duplicates to our local catalogue. In case of libraries who are already running Koha and would want to start using the harvester, there would be a lot of duplicates (possibly everything!). Also, we do not want to limit libraries to use one source to harvest from ? there might be a need in the future to harvest from multiple sources. We suggest that the ?Staged Marc Management? tool should be used to actually import the records into Koha ? then the matching rules that apply there would be used. Or copying/mirroring this functionality for the harvester. Small issues * Viewing a server target, the page doesn?t have a back button or working breadcrumbs. David has suggested that he might not add a back-button but will fix the breadcrumbs. * The reset repository harvest button should have a warning or a help text next to it, explaining that all harvested records will be removed. * A help text should be added next to the Until parameter, detailing that this should not be set for repeated harvest. Otherwise, as the From parameter is auto-updated with each harvest, Until might be set before From, which will cause to harvester to fail. * More detailed information should be presented under ?View?, preferably lists of records imported (where you can click on the bib-id to go to the actual record), lists of deleted records, updated records etc. We will draw up what we would like to see in terms of details and send to David. We can also post it here, if others are interested? * It would be great if multiple sets could be provided for one OAI server. The first time a new server is added, pressing the ?Test HTTP and OAI-PMH parameters? will send you back to the OAI-PMH server targets (oai_client.pl) page, like you would expect the save button to do. David has confirmed that this is a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:54:13 +0000 Subject: [Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.18 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:56:12 +0000 Subject: [Koha-bugs] [Bug 11594] store both item type and document type in statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11594 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 15:56:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 14:56:36 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Could you report the borrowers.debarred value for the patron you are checkin the item out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:02:45 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:03:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:03:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #241 from Jonathan Druart --- Created attachment 44845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44845&action=edit Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:04:17 +0000 Subject: [Koha-bugs] [Bug 15178] Update Italian web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15178 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Zeno! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:04:43 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:05:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:05:05 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:05:35 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Without this patch and Crypt::GCrypt, Patron module launches an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:11:00 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:11:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:11:35 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:21:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:21:21 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:21:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:21:24 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 --- Comment #1 from Jonathan Druart --- Created attachment 44846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44846&action=edit Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:22:43 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #2 from Jonathan Druart --- It would be worth having it in 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:22:49 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15137 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:22:49 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:23:32 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Genevieve Plantin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42565|0 |1 is obsolete| | --- Comment #30 from Genevieve Plantin --- Created attachment 44847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44847&action=edit Bug 6934 - Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:23:57 +0000 Subject: [Koha-bugs] [Bug 15187] New: Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Bug ID: 15187 Summary: Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) Change sponsored?: --- Product: Koha Version: 3.20 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jesse at meta21st.com QA Contact: testopia at bugs.koha-community.org We have found that after we turned on ICU indexing to index Arabic in our catalogue (using these steps: http://wiki.koha-community.org/wiki/Correcting_Search_of_Arabic_records), we get results from searches in Arabic but NOT in specific search-limits such as "title," "author" or "series." This is 880 isn't INDEXED SPECIFICALLY TO DELIVER SEARCH RESULTS. We would very much like to add this functionality to our Koha instance. We have tried our hand at these steps (to add new field to the indexing list): http://wiki.koha-community.org/wiki/How_to_add_new_zebra_index to no avail. A friendly listserver suggested something like this: > > select="substring(marc:subfield[@code='6']",1,3)"/> > > But then suggested that we try something like this: > condition="substring(marc:subfield[@code='6']",1,3) = 245"> > Title-cover:w > Title-cover:p > Title-cover:s > Title:w > Title:p > Title:s > But that this required a specific block of edits to be made FOR EVERY LINKED FIELD to get 880 indexed "properly." Thank you. I have attached a few records from or catalogue. Jesse Lambertson jlambertson at sqcc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:26:28 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Jesse Lambertson changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:27:55 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #31 from Genevieve Plantin --- Thanks for the tips, I obsoleted the previous patch and I fix the rest in it. I understood the KohaDates better, thanks really. There are some features and improvements that I need to add, it will come in another path soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:46:44 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:46:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:46:47 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 --- Comment #1 from Jonathan Druart --- Created attachment 44848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44848&action=edit Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:46:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:46:52 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:49:03 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 16:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 15:58:39 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #7 from Bob Ewart --- In answer to Tomas I installed it and opened the intranet login. It immediately crashed because NorwegianPatronDB couldn't find Crypt::GCrypt The patch worked for me Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:00:45 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com --- Comment #4 from Nicole Engard (ByWater) --- I have asked the librarian who reported the issue to be clearer on location. Sorry about that. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:26:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:26:31 +0000 Subject: [Koha-bugs] [Bug 15188] New: remove_unused_authorities.pl will delete all authorities if zebra is not running Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Bug ID: 15188 Summary: remove_unused_authorities.pl will delete all authorities if zebra is not running Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org The script misc/migration_tools/remove_unused_authorities.pl will delete all authorities if zebra is not running. Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:28:55 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major --- Comment #1 from Jonathan Druart --- This a major one and blocker for the 3.22 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:29:39 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Status|NEW |ASSIGNED Depends on| |11395 --- Comment #2 from Jonathan Druart --- Actually it's in 3.20.x already, so raising again the severity. Lost of data possible! Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 [Bug 11395] Batch modifications for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:29:39 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14795 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 [Bug 14795] Batch record modification tool removes framework code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:30:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:30:06 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Jonathan Druart --- Ccing Chris as 3.20.x RM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:33:27 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:33:30 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 --- Comment #4 from Jonathan Druart --- Created attachment 44849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44849&action=edit Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:35:14 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #1 from Jesse Lambertson --- Created attachment 44850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44850&action=edit Zipped file of MARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:36:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:36:06 +0000 Subject: [Koha-bugs] [Bug 15189] New: The batch records modification tool should not close STDERR when running in background mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Bug ID: 15189 Summary: The batch records modification tool should not close STDERR when running in background mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:37:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:37:49 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:37:51 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 --- Comment #1 from Jonathan Druart --- Created attachment 44851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44851&action=edit Bug 15189: Do not close STDERR when running in background mode The batch records modification tool close STDERR, it's useless and hide warnings/errors. Like the other processes using the BackgroundJob module, this one should let it open. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:38:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:38:25 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |11395 --- Comment #2 from Jonathan Druart --- No need for a test plan here. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 [Bug 11395] Batch modifications for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:38:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:38:25 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15189 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 [Bug 15189] The batch records modification tool should not close STDERR when running in background mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:44:32 +0000 Subject: [Koha-bugs] [Bug 14780] Datetime format picker error in Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Eugene, What version of Koha are you using? With is the value of the dateformat system preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:46:57 +0000 Subject: [Koha-bugs] [Bug 14802] About page (about.pl) throwing errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14802 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |tomascohen at gmail.com Status|NEW |RESOLVED --- Comment #1 from Tom?s Cohen Arazi --- You seem to have a broken setup. Probably due to /etc/apache2/sites-enabled/cathlamet.conf pointing to a deleted configuration file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:50:25 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44845|0 |1 is obsolete| | --- Comment #242 from Jonathan Druart --- Created attachment 44852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44852&action=edit Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:50:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #32 from Genevieve Plantin --- Created attachment 44853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44853&action=edit Bug 6934 - New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:51:11 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Genevieve Plantin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Genevieve Plantin --- Thanks for the tips, I obsoleted the previous patch and I fix the rest in it. I understood the KohaDates better, thanks really. There are some features and improvements that I need to add, it will come in another path soon. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 17:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 16:58:13 +0000 Subject: [Koha-bugs] [Bug 13467] acq tab still says ordered even if completed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13467 --- Comment #1 from Marjorie Barry-Vila --- (In reply to Nicole C. Engard from comment #0) > Created attachment 34426 [details] > ordered instead of completed > > When an order is completed it's still saying that it's ORDERED in the acq > details tab in the staff client. In the attached image you can see the > received date and when I look at the invoice everything is received and > done. It should say completed but does not. Hi Nicole, I notice that status of a received order is changing when basket is reopened. Test plan: 1. receive an item X of basket A, status in acq details tab is Complete 2. reopen basket A, status in acq details tab is now New for item X 3. close basket A, status in acq details tab is Ordered for item X Is it the same in your case? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 18:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 17:27:34 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi Jesse, may be I don't know which is the best solution to your problem, but as far as I understand 880 is not only to titles, but for any field that needs another graphical representation. I did a test with and Arabic title in a 246 field as parallel title, and I can found it from staff/opac as title without modifications. BTW, your zip file have a zero byte record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 18:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 17:33:43 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #26 from Viktor Sarge --- > Our use case > We are harvesting records from the Swedish union catalogue LIBRIS, which > provides records in Marcxml. Today only bibliographic records are harvested, > but we hope to add functionality in the future to also allow holdings to be > harvested (but this is a separate development and won?t be discussed further > here.) We have (as many others) the same use case. Getting holdings would be very great! > All in all, the harvester works as intended! Great news! > Matching rules > At the moment there are not matching rules for the harvester per se. The > only matching that is done is based on the OAI-PMH unique identifier. If > there?s already a record in Koha with the same title, but not the same > OAI-PMH unique identifier, you will get a duplicate. > > Not having matching rules will essentially make the harvester useless for > us, and I would guess anyone harvesting from a union catalogue. We don?t > want to add a lot of unnecessary duplicates to our local catalogue. In case > of libraries who are already running Koha and would want to start using the > harvester, there would be a lot of duplicates (possibly everything!). Also, > we do not want to limit libraries to use one source to harvest from ? there > might be a need in the future to harvest from multiple sources. > > We suggest that the ?Staged Marc Management? tool should be used to actually > import the records into Koha ? then the matching rules that apply there > would be used. Or copying/mirroring this functionality for the harvester. Using the existing import tool sounds like a good plan - then there is a single point to work with for import rules even though we add a new import flow. Much better than building another place to poke around with it's own quirks. > Small issues > * Viewing a server target, the page doesn?t have a back button or working > breadcrumbs. David has suggested that he might not add a back-button but > will fix the breadcrumbs. Breadcrumbs is good enough if they work correctly and brings you one step up and not two-three steps up in the hierarchy. > * Using the daemon, all scheduling can be handled by the GUI A GUI is a selling point in my eyes! Everything that lets the library handle their Koha installation by themselves when they don't themselves have the Linux know how is great! Not having to bug the server people about changes is a big plus. > It would be good to have input from others in the community on the merits of > having the harvester run as a daemon! GUI and short intervals for harvesting gets daemon my vote. But that is without a deeper analysis of technical details. Although I know Zebra indexing can now as a daemon which is viewed as a plus so it can't be all that alien a concept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 18:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 17:50:34 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #3 from Jesse Lambertson --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > Hi Jesse, > may be I don't know which is the best solution to your problem, but as far > as I understand 880 is not only to titles, but for any field that needs > another graphical representation. > > I did a test with and Arabic title in a 246 field as parallel title, and I > can found it from staff/opac as title without modifications. > > BTW, your zip file have a zero byte record. I will reupload the MARC file then just for examples from our records. Thank you. Strange, Regarding the Arabic searching. You are correct that the issue affects all Arabic script in 880 fields. 245 and 246 will search because they are ALREADY indexed. 880s are not indexed separately from "keyword" searching so we can't search Arabic in any other way than in "keyword." Thank you, Jesse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 19:05:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 18:05:23 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 19:06:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 18:06:18 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44829|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 44854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44854&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 19:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 18:06:24 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44830|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard --- Created attachment 44855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44855&action=edit Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 19:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 18:16:16 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 19:16:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 18:16:21 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44849|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 44856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44856&action=edit [SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel Tested framework is lost using tool without patch Problem gone with patch No qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 20:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 19:02:08 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44836|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44857&action=edit [SIGNED-OFF]Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. Signed-off-by: Hector Castro Subroutines removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 20:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 19:02:23 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 20:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 19:04:21 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44851|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44858&action=edit [SIGNED-OFF]Bug 15189: Do not close STDERR when running in background mode The batch records modification tool close STDERR, it's useless and hide warnings/errors. Like the other processes using the BackgroundJob module, this one should let it open. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 20:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 19:04:32 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 20:54:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 19:54:51 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Hi, on current master I get "Can't call method "get_contents" on an undefined value at $home/kohaclone/virtualshelves/sendshelf.pl line 74" when sending a list from staff >From opac I can send the list with authors and isbn without patch This patch is for opac, staff or both? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 21:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 20:53:20 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #31 from Blou --- We have a hard time figuring a good name for publicdir. Bouzid will do all the fixes you asked, but I expect someone will come with another patch just to change the config name, eventually. Regarding the multidir suggestion, we like it. But that's outside of the sponsored work, and I must say would be really easy to add once this is accepted. Making this harder to accept from the start is probably not where we want to be. Further hint as to what is looked for as for documentation would be a great help. Not sure where to start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:18:05 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #32 from Bouzid --- Created attachment 44859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44859&action=edit Test case : Preparation : * Add the "filesaccess" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:18:53 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:29:51 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44859|0 |1 is obsolete| | --- Comment #33 from Bouzid --- Created attachment 44860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44860&action=edit Bug 11317: translate date with datetime format preference,replace in tools and rename preference in Koha-config.xml. Test case : Preparation : * Add the "filesaccess" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:46:41 +0000 Subject: [Koha-bugs] [Bug 15190] New: Bad utf8 decode to unapi and fixing blank screen error status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Bug ID: 15190 Summary: Bad utf8 decode to unapi and fixing blank screen error status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:54:13 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 44861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44861&action=edit 15190 - Bad utf8 decode to unapi and fixing blank screen error status Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ To test 1) Copy from LOC (Z39.50) ISBN 8467020113 2) Open URL cgi-bin/koha/unapi?id=koha:biblionumber:4&format=marcxml 3) (enter the new biblionumber for ISBN 8467020113) 4) A marcxml record will display, notice about the bad utf8 decoding characters 5) Search the record in opac and try to save in Zotero (see bad decoding) delete record from Zotero. 6) To reproduce blank screen (error status) play with: cgi-bin/koha/unapi?id=koha:biblionumber:4 cgi-bin/koha/unapi?id=koha:biblionumber:4&format= cgi-bin/koha/unapi?id=koha:biblionumber:4&format=none cgi-bin/koha/unapi?id=koha:biblionumber:&format=marcxml cgi-bin/koha/unapi?&format=oai_dc cgi-bin/koha/unapi? 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 and redirection to one of the error pages in /cgi-bin/koha/errors/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 13 22:55:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Nov 2015 21:55:06 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 04:04:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 03:04:04 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- All this columns are used by module Koha/Schema/Result/Statistic.pm Inside the file it read # Created by DBIx::Class::Schema::Loader # DO NOT MODIFY THE FIRST PART OF THIS FILE and # Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-10-14 20:56:21 # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:THELVmdFFi1RCI4DfqwGIw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 12:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 11:35:16 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 --- Comment #4 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > Hi, on current master I get > "Can't call method "get_contents" on an undefined value at > $home/kohaclone/virtualshelves/sendshelf.pl line 74" > when sending a list from staff > > From opac I can send the list with authors and isbn without patch > > This patch is for opac, staff or both? For staff only, it works without this patch at the OPAC. The error you reported should have been fixed by the patch I have submitted yesterday on bug 14544 comment 242. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 14:58:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 13:58:04 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 14:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 13:58:07 +0000 Subject: [Koha-bugs] [Bug 15137] List email send froms taff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44846|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 44862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44862&action=edit [SIGNED-OFF] Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info Signed-off-by: Bernardo Gonzalez Kriegel On top of last patch of Bug 14544 Works ok, mail with authors and ISBN No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 15:00:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 14:00:00 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44852|0 |1 is obsolete| | --- Comment #243 from Bernardo Gonzalez Kriegel --- Created attachment 44863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44863&action=edit [SIGNED-OFF] Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. Signed-off-by: Bernardo Gonzalez Kriegel Whith patch mail is sent. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 16:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 15:26:07 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #7 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #0) > Don't know if this qualifies as a security risk. No, I would not call it like that :) Please have a look at bug 12872. It is broader but covers this bug too. The problem is that DOM indexes all under the Any keyword via the following lines: Look at the first obsolete patch too. As discussed before on some older reports too, it would be nice to have an optional Anywhere (just like Any now), and a more restricted Any (only include the defined indexes as we were used too under GRS1). If you would not like Anywhere for various reasons (index size or hidden fields etc.), disable it some way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 16:27:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 15:27:12 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12872 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 16:27:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 15:27:12 +0000 Subject: [Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15050 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 16:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 15:35:39 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hm, my impression was that Any includes everything that is included in one of the other indexes - could there be another reason for the phenomenon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 18:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 17:22:41 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from H?ctor Eduardo Castro Avalos --- Hi Frederick Test Unit fail because module missing Capture::Tiny I think you need to include in C4::Installer::PerlDependencies and debian/control (libcapture-tiny-perl) Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 19:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 18:12:27 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44707|0 |1 is obsolete| | --- Comment #3 from Martin Persson --- Created attachment 44864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44864&action=edit Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 19:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 18:15:22 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #4 from Martin Persson --- Created attachment 44865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44865&action=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&show_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 20:05:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 19:05:07 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #10 from Fr?d?ric Demians --- > Test Unit fail because module missing Capture::Tiny Thanks Hector. I add it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 20:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 19:06:09 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 14 20:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Nov 2015 19:06:12 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44438|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 44866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44866&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 01:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 00:26:21 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #12 from H?ctor Eduardo Castro Avalos --- Sorry Fr?d?ric But I got: # Failed test 'ListMetadataFormats' # at t/db_dependent/OAI/Server.t line 84. # got: ' # # 2015-11-15T00:11:11Zhttp://localhostoai_dchttp://www.openarchives.org/OAI/2.0/oai_dc.xsdhttp://www.openarchives.org/OAI/2.0/oai_dc/marcxmlhttp://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim.xsdhttp://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim' # expected: ' # # 2015-11-15T00:11:11Zhttp://localhostoai_dchttp://www.openarchives.org/OAI/2.0/oai_dc.xsdhttp://www.openarchives.org/OAI/2.0/oai_dc/marcxmlhttp://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim.xsdhttp://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim' # Failed test 'ListIdentifiers without metadaPrefix argument' # at t/db_dependent/OAI/Server.t line 96. # got: ' # # 2015-11-15T00:11:11Zhttp://localhostRequired argument 'metadataPrefix' was undefined' # expected: ' # # 2015-11-15T00:11:11Zhttp://localhostRequired argument 'metadataPrefix' was undefined' # Looks like you failed 2 tests of 13. Also i noticed that this happen when you got OAI-PMH:AutoUpdateSets to "Disable", if you enable all works succefully. I play with cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:1&metadataPrefix=marcxml And is working succefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 01:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 00:36:35 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #13 from H?ctor Eduardo Castro Avalos --- Another thing that i could see is: in debian/control when a library is placed, goes in two places and you put it in one. I don't know much about that, tell me if I'm wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 08:38:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 07:38:43 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #14 from Fr?d?ric Demians --- Thanks Hector for testing. Two responses: (1) UT don't work for you because you may use a MARC21 DB. I've tested with Unimarc. I have to change the UT to be marcflavour agnostic. (2) Debian packaging: I will remove my debian/control modification, and let the packaging manager (Robin Sheat) add the correct info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 08:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 07:56:02 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #15 from Fr?d?ric Demians --- Failing tests seem to be due to HTTP::OAI version variation. Which version do you use? You can get it with: perl -MHTTP::OAI -e 'print $HTTP::OAI::VERSION, "\n"' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 14:56:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 13:56:51 +0000 Subject: [Koha-bugs] [Bug 15191] New: Serials display improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191 Bug ID: 15191 Summary: Serials display improvements Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Displaying 500 Serial Items in the staff client's detail.pl takes ~15+ seconds. This is awkward. Placing Item-level holds for the aforementioned Items is also very clumsy. This huge modification dabbles with front-end javascript Object-driven SPA-type approach to the solution utilizing the brand new Beta-REST API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 16:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 15:39:22 +0000 Subject: [Koha-bugs] [Bug 15192] New: sanitize_records.pl Unknown option: auto_search (should be auto-search) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15192 Bug ID: 15192 Summary: sanitize_records.pl Unknown option: auto_search (should be auto-search) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Trivial: On sanitize_records.pl help and perldoc say the option is --auto_search, but on usage we can find that the real option is with slash, not underscore: --auto-search. BTW, is not clear what does this script, what errors look for, if only "&" (without looking the code, of course). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 21:36:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 20:36:26 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 22:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 21:57:49 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 22:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 21:57:52 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44837|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 44867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44867&action=edit [PASSED QA] Bug 15181: Rename marc21 fast add framework sql file This patch simply renames fast add sql file in order to load this file before default framework. To test: 1) Do a marc21 install (de,en,es,it) load all sample files check Fast Add framework is empty (no fields/subfields) 2) Apply the patch 3) Do an install again, this time FastAdd must have values. Signed-off-by: Zeno Tajoli Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:23:55 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- This patch breaks the staff start page for me? Can't locate object method "load" via package "Koha::NorwegianPatronDB" at /home/katrin/kohaclone/C4/Members.pm line 46. Compilation failed in require at /home/katrin/kohaclone/C4/Letters.pm line 27. BEGIN failed--compilation aborted at /home/katrin/kohaclone/C4/Letters.pm line 27. Compilation failed in require at /home/katrin/kohaclone/C4/Suggestions.pm line 29. BEGIN failed--compilation aborted at /home/katrin/kohaclone/C4/Suggestions.pm line 29. Compilation failed in require at /home/katrin/kohaclone/mainpage.pl line 29. BEGIN failed--compilation aborted at /home/katrin/kohaclone/mainpage.pl line 29. All works well without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:36:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:36:20 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:36:23 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44856|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 44868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44868&action=edit [PASSED QA] Bug 14795: Prevent modifying a record without using the original framework The origin framework is not passed on modifying the records and so the default one is used. This can caused data lost. Test plan: - Create a bibliographic record and specify a framework (not the default one). - Use the Batch records modification tools to modify it. => Without this patch, the default framework (framework code "") is used and can deteriorate the record => With this patch, the record is saved using the original framework Signed-off-by: Bernardo Gonzalez Kriegel Tested framework is lost using tool without patch Problem gone with patch No qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:47:00 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #10 from Katrin Fischer --- The patch works as described, but I notice that the biblioitemnumber still duplicates. I think it would be good to fix that as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:48:10 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:48:13 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44199|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 44869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44869&action=edit [PASSED QA] Bug 6657: Prevent biblionumber to be duplicated If the biblionumber field is displayed in the framework, on editing a biblio the field/subfield will be duplicated. To prevent that this patch adds a check when building the field list. Test plan: 1/ map biblio.biblionumber with 999$c 2/ Display 999$c in a framework 3/ Edit a biblio using this framework 4/ Save => The field should not have been duplicated 5/ map biblio.biblionumber with 001 6/ Display 001 in a framework 7/ Edit a biblio using this framework 8/ Save => The field should not have been duplicated Signed-off-by: Bernardo Gonzalez Kriegel Works as described, aldo removes duplicate values. No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:51:23 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:51:26 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44857|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44870&action=edit [PASSED QA] Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. Signed-off-by: Hector Castro Subroutines removed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:52:18 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|List email send froms taff |List email sent from staff |is missing author |is missing author |information |information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 15 23:52:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 22:52:42 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|List email sent from staff |List email sent from staff |is missing author |is missing ISBN and author |information |information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 00:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 23:04:20 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 00:04:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 23:04:23 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44862|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 44871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44871&action=edit [PASSED QA] Bug 15137: Display ISBN and author info when sending list by email Disclaimer: this is not caused by bug 14544 :) And can be backported! Both isbn and author information are missing when a list is sent by email. Emails sent from OPAC and staff should be (almost) the same. Test plan: 1/ Sent a list by email (Button "Send list") 2/ The email you will receive should contain the isbn and author info Signed-off-by: Bernardo Gonzalez Kriegel On top of last patch of Bug 14544 Works ok, mail with authors and ISBN No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 00:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 23:05:34 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44863|0 |1 is obsolete| | --- Comment #244 from Katrin Fischer --- Created attachment 44872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44872&action=edit [PASSED QA] Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. Signed-off-by: Bernardo Gonzalez Kriegel Whith patch mail is sent. No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 00:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 23:05:56 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #245 from Katrin Fischer --- Last patch needs to be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 00:06:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Nov 2015 23:06:05 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 02:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 01:36:45 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #183 from Robin Sheat --- FYI, this is my last week at Catalyst and hence working on this. I'm going to get the docs finished off to make it easy for everyone, but if you've got any questions, best get them in soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:34:00 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #184 from David Cook --- (In reply to Robin Sheat from comment #183) > FYI, this is my last week at Catalyst and hence working on this. I'm going > to get the docs finished off to make it easy for everyone, but if you've got > any questions, best get them in soon. On that note, where are all the patches for this development? All I see is "Bug 12478: Display facet terms ordered by number of occurrences". Were the rest accidentally marked as obsolete or are they on different bugs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:38:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:38:58 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea --- I'm going to take a guess and say on the results page, when you list out all available copies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:40:57 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #185 from Robin Sheat --- (In reply to David Cook from comment #184) > On that note, where are all the patches for this development? All I see is > "Bug 12478: Display facet terms ordered by number of occurrences". Were the > rest accidentally marked as obsolete or are they on different bugs? They've all been pulled into the branch on the catalyst repo. It was my plan to break them up into functional patches afterwards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:43:00 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #186 from David Cook --- (In reply to Robin Sheat from comment #185) > > They've all been pulled into the branch on the catalyst repo. It was my plan > to break them up into functional patches afterwards. Ahhh sounds good. I'll look there if/when I get to checking out. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:43:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:43:19 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #6 from Liz Rea --- Created attachment 44873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44873&action=edit Possible location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 04:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 03:43:54 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #7 from Liz Rea --- Not sure why you couldn't apply a different style to span class='unavailable' there though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 07:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 06:08:03 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #27 from David Cook --- The first time I started working on this feature, I thought about using ?Staged Marc Management?, but there were problems with this which I don't recall 100% (as it was over 2 years ago). I do have some memories though: 1. I wouldn't want the harvests accessible via the "Staged Marc Management" tool, because selective "import"/"undo import" of harvests would be highly problematic. You could import 100 records, unimport 100 records, import 50 records, and then try to re-import those original 100 records which include that 50 record subset. In this case, you might overwrite the newer 50 records with the older 100 records. Of course, you could opt not to overwrite matches... but that relies on there being a good matcher, which there very well might not be. Plus, if you don't overwrite matches and have that setting defined at a OAI-PMH server level, you're never going to get newer records updating older records, which is also bad. 2. The "Staged Marc Management" record matcher relies on Zebra which makes it prone to not always matching correctly. If something hasn't been indexed correctly, you'll get duplicate records. It also relies on that Koha's indexing configuration. In some tests, I've forced the unique OAI-PMH identifier to be placed in the 035$a field... but that field isn't indexed by default. So it would be useless for matching without an update to the Zebra indexing... which can be achieved but it's another point of failure. The matching also relies on import rules defined in Koha. If you have a staff member accidentally delete your OAI-PMH matching rule, you're going to quickly get many many duplicate records. -- I chose to do my own import rules - using only the unique OAI-PMH identifier - because it was the most reliable way of making sure that harvested records weren't duplicated against themselves/each other. In the event that you're harvesting holdings, you also need to have the original bibliographic record in the Koha. That means that if you're having duplicate matching, it must 100% of the time overwrite local bibliographic records. Otherwise, your holdings won't know which bibliographic record to which to bind. If you're using "Staged Marc Management", it's easy to accidentally misconfigure so that you're not overwriting local bibliographic records, and then you have problems again. Another reason I chose to do my own import rules is because I don't think you can trust the user to manage the OAI-PMH harvester configuration completely. -- That all said, I think perhaps the "Staged Marc Management" system might be able to be leveraged... I just don't want it to be configurable by end users, since it needs very particular settings in order to work correctly. Unfortunately, this means that you're going to lose some of the functionality you want, like being able to look at all the records in a harvest. However, the idea of a "harvest" doesn't really make sense if you're using the harvester every few seconds. Each "harvest" might only have 1-2 records in it, so the concept of harvests becomes a bit unhelpful. -- Ultimately, I think we'll need to discuss the import and duplication part of the feature more... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 07:11:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 06:11:55 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #28 from David Cook --- We're also hoping to make the harvester/importer asynchronous which also makes the "harvest" or "batch" concept a bit useless, since it'll be doing lots of individual activities all at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 07:41:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 06:41:16 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #29 from David Cook --- I've been thinking a bit about the connexion_import_daemon.pl, and how it uses /cgi-bin/koha/svc/import_bib. This uses the "Staged Marc Management" backend without exposing it to users. Unfortunately, I think that service is hard-coded just to work with connexion_import_daemon.pl... so I might need to alter /cgi-bin/koha/svc/import_bib a bit... but that might be an option. I actually quite like that idea overall as it provides a more loosely coupled system. I'm also tempted to change the existing system so that you define OAI-PMH servers, and then create OAI-PMH tasks for those servers. This information would all be stored in the database. Then, when you wanted to run a task, you could click "Run" on the Web UI, and it would send the task to the daemon. I haven't 100% thought out how the Web UI and the daemon will communicate yet. While that above paragraph sounds good, what happens if the daemon dies for some reason? If it requires a message from the Web UI, it'll need a human to restart it. Another thought is to let it access the MySQL database... in that case the Web UI would change a field in the database (like "state" to indicate that it should be running), and then tell the daemon something like "READ 15" to read the task from the database with an ID of 15. That way... if the daemon crashes, a server-side process could detect the crash and then tell the daemon to re-start itself... and when the daemon is re-starting, it could just look in the database for any tasks that it should be running, and get back on track. If it has database access, it's not really that loosely coupled which would be unfortunate... Actually, another idea... the Web UI could send the task, and the daemon could write it away to a temporary file which it cleans up after it's finished a task. If it crashes and gets restarted, it can check its temporary files to see what it was in the middle of doing. Yeah... that's probably a better idea. Another idea would be to use shared memory... but I would need to do some more research into that one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 10:07:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 09:07:42 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 11:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 10:59:38 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 12:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 11:49:20 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #3 from Martin Renvoize --- Comment on attachment 44447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44447 Bug 15107: Batch Patron Deletion (Trash) Performance Improvement Review of attachment 44447: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15107&attachment=44447) ----------------------------------------------------------------- Great to see someone working on performance! I realise that dropping DBIC, especially in background scripts where a startup cost is clearly a bad thing, does lead to a performance increase but I am a little apprehensive to do an about turn on dbic's use as it's only jsut picking up momentum in the project as a whole. i wonder if there is a dbic friendly way to improve performance rather than just ditching it? ::: C4/Members.pm @@ +1772,3 @@ > =cut > > sub MoveMemberToDeleted { Seems you've highlighted a bad API choice here (not your fault). This sub does not 'Move' at all.. it 'Copies'! I would prefer to see it actually do a 'Move', i.e. do the insert from select, followed by a delete wrapped in a transaction. Would you be willing to look into this as part of this piece? @@ +1773,5 @@ > > sub MoveMemberToDeleted { > + my ($borrowernumber) = shift or return; > + my $dbh = C4::Context->dbh; > + my $borrower_columns = q{ I'm not especially happy with adding a list of fields here, it means increased maintenance cost going forward as would require this script to be altered upon any db change on this table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 12:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 11:54:33 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #4 from Martin Renvoize --- Comment on attachment 44447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44447 Bug 15107: Batch Patron Deletion (Trash) Performance Improvement Review of attachment 44447: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15107&attachment=44447) ----------------------------------------------------------------- ::: C4/Members.pm @@ +1772,4 @@ > =cut > > sub MoveMemberToDeleted { > + my ($borrowernumber) = shift or return; I missed this one the first time around.. Have you actually checked that all calls to MoveMoverToDeleted are actually passing a borrowernumber int as a posed to a member hashref? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 12:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 11:58:54 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |gmc at esilibrary.com, | |katrin.fischer at bsz-bw.de, | |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:06:34 +0000 Subject: [Koha-bugs] [Bug 15193] New: Perl scripts missing exec permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Bug ID: 15193 Summary: Perl scripts missing exec permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl but others are incorrect for no reason : $ find . -name '*.pl' -exec ls -l {} \; | grep -v "rwx" -rw-rw-r-- 1 fsomers fsomers 4679 oct. 29 15:12 ./misc/cronjobs/nl-sync-from-koha.pl -rw-rw-r-- 1 fsomers fsomers 5697 oct. 29 15:12 ./misc/cronjobs/nl-sync-to-koha.pl -rw-rw-r-- 1 fsomers fsomers 13064 oct. 29 15:12 ./misc/load_testing/benchmark_staff.pl -rw-rw-r-- 1 fsomers fsomers 913 juil. 28 15:17 ./selenium/PERL/Members/AddMember.pl -rw-rw-r-- 1 fsomers fsomers 1287 juil. 28 15:17 ./selenium/PERL/Members/FilterMembers.pl -rw-rw-r-- 1 fsomers fsomers 1020 juil. 28 15:17 ./selenium/PERL/Members/Searchmember.pl -rw-rw-r-- 1 fsomers fsomers 10593 oct. 29 15:12 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl -rw-r--r-- 1 fsomers fsomers 266 nov. 13 12:28 ./kohaversion.pl -rw-r--r-- 1 fsomers fsomers 1529 nov. 10 16:54 ./install-CPAN.pl -rw-r--r-- 1 fsomers fsomers 3455 nov. 10 16:54 ./cataloguing/value_builder/unimarc_field_100_authorities.pl -rw-r--r-- 1 fsomers fsomers 11552 nov. 13 12:28 ./cataloguing/value_builder/marc21_linking_section.pl -rw-r--r-- 1 fsomers fsomers 5082 nov. 10 16:54 ./cataloguing/value_builder/EXAMPLE.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:06:45 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:08:34 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:08:36 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 --- Comment #1 from Fridolin SOMERS --- Created attachment 44874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44874&action=edit Bug 15193 - Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:14:37 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Hi Catherine, What sort of appetite do you have for expanding the scope of this as hinted above? I feel koha is in a somewhat transitional stage at the moment regarding performance/coding standards.. I certainly don't wan't to put you off this important work but would like to see some alternatives that actually attempt to fix up the api's rather than make 'fixes' on top of old design decisions. For instance, the 'Move' routine not being a Move at all, but rather a Copy.. this is leading to bugs elsewhere. Also, the routine not being clear as to whether it requires a borrowernumber or a member hashref is likely to lead to bugs. I also think there could be an improvement to allow for passing lists of borrowernumber as a posed to single borrowers which could lead to performance gains too. This is all skirting the issue of data integrity and the lack of good db constraints meaning that objects could well become orphans after running this routine :( Any thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:16:30 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:23:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:23:10 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 13:34:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 12:34:38 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #6 from Martin Renvoize --- I seem to be on a comment mission today, sorry ;) The routine you've optimised is called in three places: misc/cronjobs/delete_patrons.pl tools/cleanborrowers.pl members/deletemem.pl Could you verify there are no adverse effects resulting from these changes for those scripts.. and perhaps profile profiles for running with and without plack as this will effect the performance metrics greatly. Pretty please :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 14:56:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 13:56:45 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- I agree with Martin. I would prefer we don't move backwards. If we can find a way to improve the speed while retaining DBIC that would be best. Maybe we could cache the result set as a package variable ( use vars )? Or maybe re-engineer the subroutine to accept a list of patrons to copy? I also think Martin is correct in that it would be great if you would be willing to fix the semantic issues with the code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 15:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 14:05:35 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #28 from Kyle M Hall --- (In reply to Martin Renvoize from comment #26) I think I must disagree on this one. I think the logic to determine if an item is safe to delete should definitely be divorced from the actual deletion. I think these changes along with the provided unit tests are a good improvement! I guess I don't see how using transactions in this situation is anything but a band-aid so to speak. If you think I've missed your point, please let me know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 15:26:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 14:26:23 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #16 from H?ctor Eduardo Castro Avalos --- I have 3.27 I don't know why fail me in my laptop with Debian Jessie. In my work does not fail with Dian wheezy, both Distros have the same version () Maybe I did something wrong. Well I will sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 15:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 14:28:37 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44866|0 |1 is obsolete| | --- Comment #17 from H?ctor Eduardo Castro Avalos --- Created attachment 44875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44875&action=edit [SIGNED-OFF]Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 15:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 14:28:59 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 15:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 14:58:39 +0000 Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:11:51 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #4 from Jesse Lambertson --- Created attachment 44876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44876&action=edit MARC upload with a few examples with 880s Faulty upload before, this file has a few records in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:21:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:21:43 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Attachment #44850|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:23:25 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Keywords|rel_3_22_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:23:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:23:35 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:23:52 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to increase Search or RTL Script (Arabic) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All OS|Windows |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:55:16 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:55:41 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:56:23 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:56:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:56:54 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:57:25 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Hector! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:57:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:57:50 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 16:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 15:58:14 +0000 Subject: [Koha-bugs] [Bug 15116] show circ buttons at the top of batch circ page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:20:26 +0000 Subject: [Koha-bugs] [Bug 15194] New: Drop-down menu 'Actions' has problem in 'Used Saved' page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Bug ID: 15194 Summary: Drop-down menu 'Actions' has problem in 'Used Saved' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:23:27 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop-down menu 'Actions' |Drop-down menu 'Actions' |has problem in 'Used Saved' |has problem in 'Saved |page |reports' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:30:42 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- Since it's a small patch, it would be better to package it in a single patch. And could you use the capitalized version of the new syspref in SQL? ClaimsBccCopy rather than claimsbcccopy. Here: VALUES ('claimsbcccopy','0','','bcc the claimacquisition and clamissues alerts','YesNo'); ('claimsbcccopy','0','','bcc the claimacquisition and clamissues alerts','YesNo'), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:34:11 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:36:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:36:31 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 17:43:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 16:43:23 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- Can't apply this patch to master: fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/js/commons.js). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:14:06 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language botton bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop-down menu 'Actions' |Drop-down menu 'Actions' |has problem in 'Saved |has problem in 'Saved |reports' page |reports' page with language | |botton bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:16:32 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language botton bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 --- Comment #1 from Zeno Tajoli --- Created attachment 44877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44877&action=edit drop-down menu with lang in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:17:06 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language botton bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 --- Comment #2 from Zeno Tajoli --- Created attachment 44878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44878&action=edit drop-down menu without lang in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:25:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:25:22 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop-down menu 'Actions' |Drop-down menu 'Actions' |has problem in 'Saved |has problem in 'Saved |reports' page with language |reports' page with language |botton bar |bottom bar --- Comment #3 from Zeno Tajoli --- In the page of 'Saved reports', module Reports, there are problem beetwen the drop-down menus 'Actions' and the language bar at the botton. If you have only one language (and so you don't have anguage bar at the botton), you don't have any problem. See image ' drop-down menu without lang in staff'. But if you two or more languge in your install, you have active language bar at the botton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:29:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:29:12 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 --- Comment #4 from Zeno Tajoli --- [...] But if you have two or more languge in your install, you have active the language bar at the bottom. And the 'Actions' drop down menus do not have enough space to expand. Around the 17th menu, you don't see all options. I think it is a problem of layers in the web page. The languege bar needs to stay in background in every case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:41:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:41:05 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:42:42 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #10) > I need someone to send me a DB (or a way to create it) where I can reproduce > the failure. Here you go: [To set the failure scenario] $ vagrant up jessie $ vagrant ssh jessie $ sudo -s $ mysql > DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; \q $ zcat /vagrant/koha_3_20_00.sql.gz | mysql koha_kohadev $ exit $ sudo koha-shell kohadev $ cd kohaclone $ cat /vagrant/reports_guided_sequence.txt | xargs prove now run the tests: $ prove t/db_dependent/Reports_Guided.t => FAIL: The tests fail like this: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. 3/18 # Failed test 'filter takes report id' # at t/db_dependent/Reports_Guided.t line 70. # got: '2' # expected: '1' # Looks like you failed 1 test of 18. t/db_dependent/Reports_Guided.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/18 subtests Test Summary Report ------------------- t/db_dependent/Reports_Guided.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=18, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.86 cusr 0.39 csys = 1.29 CPU) Result: FAIL run them again => SUCCESS: They now pass (i.e. side effects). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 18:48:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 17:48:33 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 --- Comment #12 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #11) > (In reply to Jonathan Druart from comment #10) > > I need someone to send me a DB (or a way to create it) where I can reproduce > > the failure. I forgot the updatedatabase.pl step: $ sudo koha-shell kohadev $ cd kohaclone $ perl installer/data/mysql/updatedatabase.pl Also, the needed file can be grabbed like this: (on your kohadevbox dir) (kohadevbox)$ wget https://theke.io/static/reports_guided_sequence.txt (kohadevbox)$ wget https://theke.io/static/koha_3_20_00.sql.gz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:01:10 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44135|0 |1 is obsolete| | --- Comment #4 from Eivin Giske Skaaren --- Created attachment 44879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44879&action=edit Bug 10154 Add Call number in the filter of most circulated items This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library Fixed patch did not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:01:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:01:37 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:15:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:15:30 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44879|0 |1 is obsolete| | --- Comment #5 from Eivin Giske Skaaren --- Created attachment 44880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44880&action=edit Bug 10154 Add Call number in the filter of most circulated items This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library Fixed patch did not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:33:50 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:33:54 +0000 Subject: [Koha-bugs] [Bug 15152] Refactor Guided Reports related tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44590|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 44881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44881&action=edit Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data The current implementation relies on existing borrowers on the DB. Even when the DB itself doesn't have a FK constraint, the function that retrieves the reports from the DB relies on get_saved_reports_base_query which creates a query that JOINs the full query with the 'borrowers' table, on the borrowernumber. So it is doomed to fail on some scenarios. Specially because the current tests expect specific borrowernumber values to be present (1, 2 and 3). To test: [To set the failure scenario] $ vagrant up jessie $ vagrant ssh jessie $ wget https://theke.io/static/reports_guided_sequence.txt -O /vagrant/reports_guided_sequence.txt $ wget https://theke.io/static/koha_3_20_00.sql.gz -O /vagrant/koha_3_20_00.sql.gz $ sudo -s $ mysql > DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; \q $ zcat /vagrant/koha_3_20_00.sql.gz | mysql koha_kohadev $ exit $ sudo koha-shell kohadev $ cd kohaclone $ cat /vagrant/reports_guided_sequence.txt | xargs prove - now run the tests: $ prove t/db_dependent/Reports_Guided.t => FAIL: The tests fail - Apply the patch - [re create the scenario] - Run the test: $ prove t/db_dependent/Reports_Guided.t => SUCCESS: Tests now pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:34:26 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:34:29 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44880|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 44882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44882&action=edit Bug 10154 Add Call number in the filter of most circulated items This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library Signed-off-by: Fr?d?ric Demians It works as described. Valid results, tested in various combinations. Follows the coding (awful) style of the original script, without introducing any regression. It would have been great to have callnumber interval, but anyway... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:37:10 +0000 Subject: [Koha-bugs] [Bug 15152] t/db_dependent/Reports_Guided.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refactor Guided Reports |t/db_dependent/Reports_Guid |related tests |ed.t should not depend on | |existing data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:40:01 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:40:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:40:04 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44848|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 44883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44883&action=edit Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:52:31 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:52:31 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15137 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 [Bug 15137] List email sent from staff is missing ISBN and author information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:53:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:53:04 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #7 from Eivin Giske Skaaren --- Thanks for the signoff Fr?d?ric. Let me tell you that I am no fan of the style with magic numbers etc either but the alternative would be a complete rewrite of this script I think :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:33 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:36 +0000 Subject: [Koha-bugs] [Bug 15152] t/db_dependent/Reports_Guided.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44881|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 44884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44884&action=edit Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data The current implementation relies on existing borrowers on the DB. Even when the DB itself doesn't have a FK constraint, the function that retrieves the reports from the DB relies on get_saved_reports_base_query which creates a query that JOINs the full query with the 'borrowers' table, on the borrowernumber. So it is doomed to fail on some scenarios. Specially because the current tests expect specific borrowernumber values to be present (1, 2 and 3). To test: [To set the failure scenario] $ vagrant up jessie $ vagrant ssh jessie $ wget https://theke.io/static/reports_guided_sequence.txt -O /vagrant/reports_guided_sequence.txt $ wget https://theke.io/static/koha_3_20_00.sql.gz -O /vagrant/koha_3_20_00.sql.gz $ sudo -s $ mysql > DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; \q $ zcat /vagrant/koha_3_20_00.sql.gz | mysql koha_kohadev $ exit $ sudo koha-shell kohadev $ cd kohaclone $ cat /vagrant/reports_guided_sequence.txt | xargs prove - now run the tests: $ prove t/db_dependent/Reports_Guided.t => FAIL: The tests fail - Apply the patch - [re create the scenario] - Run the test: $ prove t/db_dependent/Reports_Guided.t => SUCCESS: Tests now pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:46 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:46 +0000 Subject: [Koha-bugs] [Bug 10056] Styling Issue - Div does not grow. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10056 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Martin Renvoize --- Going through some of my oldest bugs, this isn't an issue any more :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:49 +0000 Subject: [Koha-bugs] [Bug 15152] t/db_dependent/Reports_Guided.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:54:56 +0000 Subject: [Koha-bugs] [Bug 15152] t/db_dependent/Reports_Guided.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:58:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #246 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Jonathan, again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:59:12 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 19:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 18:59:44 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:00:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:00:07 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:00:38 +0000 Subject: [Koha-bugs] [Bug 15152] t/db_dependent/Reports_Guided.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:16:52 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:20:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:20:05 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #8 from Fr?d?ric Demians --- > Let me tell you that I am no fan of the style with magic numbers etc either > but the alternative would be a complete rewrite of this script I think :) IMO, your choice not to refactor the script is a good choice. It helps avoiding regression yet increasing this report usefulness. Thks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:26:14 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- We have formally deprecated the non-XSLT views a while ago: DEPR1: non-XSLT search results and bib display templates deprecated As of 2014-07-02, use of the XSLT search results and bib details display templates for the staff interface and public catalog is now the preferred option. Consequently, the non-XSLT option is now deprecated and it will not be maintained. Template files used by the non-XSLT bib and results displays need not be touched in future staff interface and public catalog enhancements; it is necessary only to update XSLT. --- As this is more of a bug fix, I have tested it. Leaving the final decision to our RM ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:26:49 +0000 Subject: [Koha-bugs] [Bug 14175] Update explanation of publication and expiration dates in newstool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 --- Comment #3 from Katrin Fischer --- Created attachment 44885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44885&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:27:27 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44809|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 44886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44886&action=edit [PASSED QA] Bug 15175 Respect IntranetBiblioDefaultView syspref Respect IntranetBiblioDefaultView on intra search result page, on cover image link, when XSLTResultsDisplay is empty. TO TEST: 1. Empty XSLTResultsDisplay 2. Activate intranet local and Amazon cover images 3. Play changing IntranetBiblioDefault, and observe the links respectively on biblio record title and cover image. Title's link is OK, cover image link goes to detail.pl page independently of IntranetBiblioDefault. 4. Apply the patch. 5. Repeat 3. Signed-off-by: Hector Castro Link to right display according with IntranetBiblioDefaultView is fixed. Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=14175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:28:01 +0000 Subject: [Koha-bugs] [Bug 14175] Update explanation of publication and expiration dates in newstool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #44885|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Comment on attachment 44885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44885 k Wrong bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:31:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:31:39 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Marcel, can you please fix the patches to work with the renamed files from bug 15181? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:35:33 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi Zeno, is this still valid? Bug 15178 have been pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:36:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:36:53 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Bernardo, I think this is especially for 3.20. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:38:24 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44861|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44887&action=edit Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ To test 1) Copy from LOC (Z39.50) ISBN 8467020113 2) Open URL cgi-bin/koha/unapi?id=koha:biblionumber:4&format=marcxml 3) (enter the new biblionumber for ISBN 8467020113) 4) A marcxml record will display, notice about the bad utf8 decoding characters 5) Search the record in opac and try to save in Zotero (see bad decoding) 6) To reproduce blank screen (error status) play with: cgi-bin/koha/unapi?id=koha:biblionumber:4 cgi-bin/koha/unapi?id=koha:biblionumber:4&format= cgi-bin/koha/unapi?id=koha:biblionumber:4&format=none cgi-bin/koha/unapi?id=koha:biblionumber:&format=marcxml cgi-bin/koha/unapi?&format=oai_dc cgi-bin/koha/unapi? 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 and redirection to one of the error pages in /cgi-bin/koha/errors/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:46:25 +0000 Subject: [Koha-bugs] [Bug 15195] New: patron details should open in tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Bug ID: 15195 Summary: patron details should open in tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 44888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44888&action=edit patron modifications When looking at patron modification requests the 'view record' link opens in a new tab, but the 'patron details' link doesn't. I'm not sure we need both links anyway, but if we have them both they should open in a new tab. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:46:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:46:45 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 --- Comment #4 from Zeno Tajoli --- Hi Bernado and Katrin, In confirm that this patch is ONLY for 3.20. Thank you -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:47:17 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- I still find some scripts without execute permissions, is that ok? -rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl -rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 ./selenium/PERL/Members/FilterMembers.pl -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 ./selenium/PERL/Members/AddMember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 ./selenium/PERL/Members/Searchmember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl -rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 ./misc/load_testing/benchmark_staff.pl -rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 ./cataloguing/value_builder/EXAMPLE.pl -rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:47:59 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Comment on attachment 44888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44888 patron modifications I think we accidentally added the same feature twice there - one could be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:56:22 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 20:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 19:56:26 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44843|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 44889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44889&action=edit [SIGNED-OFF] Bug 15180: Update Italian web installer sample files for 3.20 This patch is ONLY FOR 3.20.x, so you need to install 3.20.x to test it. - Completes translations in Italian of web installer sample files in 3.20.x - Some change in Italian default system preference settings. To test: - Run the web installer in Italian with all sample files selected - Confirm no error messages are shown http://bugs.koha-community.org/show_bug.cgi?id=15180 Signed-off-by: Bernardo Gonzalez Kriegel Tested on 3.20, italian installer, all sample files No errors detected Koha version: 3.20.05.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:05:06 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:05:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:05:09 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44883|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44890&action=edit [PASSED QA] Bug 15114: Fix typo in opac-suggestion template There is a $ in front of the loggedinusername variable, which is obviously not what is expected here. It fixes the wrong warning message "You are not authorized to see pending purchase suggestions." when it should be "There are no pending purchase suggestions." Signed-off-by: Fr?d?ric Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:08:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:08:17 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:08:20 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44858|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 44891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44891&action=edit [PASSED QA] Bug 15189: Do not close STDERR when running in background mode The batch records modification tool close STDERR, it's useless and hide warnings/errors. Like the other processes using the BackgroundJob module, this one should let it open. Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:11:18 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:18:03 +0000 Subject: [Koha-bugs] [Bug 15196] New: Order patrons on patron lists by name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15196 Bug ID: 15196 Summary: Order patrons on patron lists by name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The patron lists patron list seems to be unordered. It would be nice if it was ordered by name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:18:31 +0000 Subject: [Koha-bugs] [Bug 15196] Order patrons on patron lists by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15109 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:18:31 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:19:18 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:19:21 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44854|0 |1 is obsolete| | Attachment #44855|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 44892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44892&action=edit [PASSED QA] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:19:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:19:32 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #10 from Katrin Fischer --- Created attachment 44893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44893&action=edit [PASSED QA] Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:22:44 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:42:49 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- Hi Kyle and all, 1) some problem noted by the QA script: FAIL C4/Circulation.pm OK critic OK forbidden patterns OK pod OK spelling FAIL valid "my" variable $borrower masks earlier declaration in same scope 2) Also: can you please shorten the bug title a bit and explain what the consequence of the fine not changed is in the commit message? 3) I'd really like to see a regression test highlighting the changed behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 21:45:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 20:45:59 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Lucio Moraes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoraes at catalyst.net.nz --- Comment #8 from Lucio Moraes --- Hi, could you be more specific with test plan? Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:28:59 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Hi R?mi, thx a lot for your patch - can you please take a look at Jonathan's comment#10? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:41:58 +0000 Subject: [Koha-bugs] [Bug 15197] New: Multiple special characters () not escaped correctly in Rancor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bug ID: 15197 Summary: Multiple special characters () not escaped correctly in Rancor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Due to a slight regex issue, multiple special characters will not be correctly escaped when saving a record, and data loss may occur. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:42:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:42:09 +0000 Subject: [Koha-bugs] [Bug 15197] Multiple special characters () not escaped correctly in Rancor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:49:09 +0000 Subject: [Koha-bugs] [Bug 15197] Multiple special characters () not escaped correctly in Rancor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:49:12 +0000 Subject: [Koha-bugs] [Bug 15197] Multiple special characters () not escaped correctly in Rancor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #1 from Jesse Weaver --- Created attachment 44894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44894&action=edit Bug 15197: In Rancor, multiple &/ characters not escaped on saving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:54:10 +0000 Subject: [Koha-bugs] [Bug 15197] Multiple special characters () not escaped correctly in Rancor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44894|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver --- Created attachment 44895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44895&action=edit Bug 15197: In Rancor, multiple &/) not escaped correctly in Rancor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #3 from Jesse Weaver --- Test plan: 1) On current master, create a record in Rancor containing multiple <, > or & characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:55:27 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple special characters |In Rancor, multiple &/) not escaped |characters not escaped on |correctly in Rancor |saving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:56:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:56:44 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #4 from Jesse Weaver --- (In reply to Jesse Weaver from comment #3) > Test plan: > > 1) On current master, create a record in Rancor containing multiple <, > > or & characters ("A & B & C", for example). > 2) Try to save the record, it will silently fail. > 3) Apply this patch. > 4) The record should now save correctly. Ugh, I shouldn't comment when tired. The characters in question are <, & and ". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 22:58:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 21:58:35 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44895|0 |1 is obsolete| | --- Comment #5 from Jesse Weaver --- Created attachment 44896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44896&action=edit Bug 15197: In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- 1) Please copy the current ISBD into OPACISBD to keep the same behaviour as before the patch for an installation with a modified ISBD view. 2) Please amend the ISBD preference description to include "staff", so it's more clear about the new difference. 3) The tests output some warnings, please take a look to see if they can be fixed: ok 1 - use C4::Biblio; Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 926. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 998. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 1010. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 998. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 1010. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 23:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 22:13:36 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC : using OPACISBD |Add separate OPACISBD |systempreference to display |system preference |link | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 23:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 22:15:29 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #22 from Katrin Fischer --- Hm, also a question: if we have separate preferences, do we really still need 4 preferences? Could we have only 2 preferences and deactivate the feature by emptying them out? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 23:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 22:17:24 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #71 from Katrin Fischer --- Sorry, but this patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Using index info to reconstruct a base tree... M C4/Koha.pm M koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt M opac/opac-suggestions.pl M suggestion/suggestion.pl Falling back to patching base and 3-way merge... Auto-merging suggestion/suggestion.pl CONFLICT (content): Merge conflict in suggestion/suggestion.pl Auto-merging opac/opac-suggestions.pl CONFLICT (content): Merge conflict in opac/opac-suggestions.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Auto-merging C4/Koha.pm Failed to merge in the changes. Patch failed at 0001 Bug 9223: Multiple values of AdvancedSearchTypes in suggestions The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9223-Multiple-values-of-AdvancedSearchTypes-in-GRz_gw.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 23:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 22:35:12 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 16 23:35:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Nov 2015 22:35:15 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44896|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 44897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44897&action=edit [SIGNED-OFF] Bug 15197: In Rancor, multiple &/ Works well, record saved No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 01:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 00:05:04 +0000 Subject: [Koha-bugs] [Bug 15198] New: Make OpacSuppression work even if there are no records suppressed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Bug ID: 15198 Summary: Make OpacSuppression work even if there are no records suppressed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, if you turn on OpacSuppression and try to search for records without having at least one record with 942$n = 1 indexed, you'll get zero results back. However, the special Zebra attribute 14 allows you to get around this problem. Attribute 14: "Specifies whether un-indexed fields should be ignored. A zero value (default) throws a diagnostic when an un-indexed field is specified. A non-zero value makes it return 0 hits." (http://www.indexdata.com/zebra/doc/querymodel-zebra.html) Now the description is a bit vague... you can't try something like "@attr 14=1 @attr 1=9999 1" to work. You'll still get a diagnostic error. However, you can try something like "@attr 14=1 @attr 1=9011 1" to work as 9011 is a valid use attribute in bib1.att. Anyway, by adding 14=1 to the Suppress qualifier in ccl.properties, we can make it so that OpacSuppression queries still work even when there are no suppressed records in Zebra. Cool, n'est-ce pas? No... it's not cool, but it's handy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 01:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 00:07:39 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #187 from Peter Zhao --- Es can not "edit record" or "edit items" in UNIMARC structure. (But it works well in USMARC.) It can show results, but when I click "Edit record", it shows "Add MARC record "--blank MARC. http://127.0.1.1:8080/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber= If I click "Edit items" , it shows http://127.0.1.1:8080/cgi-bin/koha/cataloguing/additem.pl?biblionumber= Software error: Can't call method "fields" on an undefined value at /home/koha/kohaclone/cataloguing/additem.pl line 703. For help, please send mail to the webmaster (webmaster at koha), giving this error message and the time and date of the error. I think it can not get the " biblionumber= ". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 01:33:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 00:33:55 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #1 from David Cook --- Unfortunately, I can't currently install the dependencies for master, namely Crypt::GCrypt which despite being marked as not required is required to even visit mainpage.pl, so I'll just be posting something here for someone else to do: -- ccl.properties: Replace: Suppress 1=9011 With: Suppress 1=9011 14=1 -- opac-search.pl: Replace: $query = '@not '.$query.' @attr 1=9011 1'; and $query = '@not '.$query.' @attr 1=9011 1'; #PQF syntax With: $query = '@not '.$query.' @attr 14=1 @attr 1=9011 1'; and $query = '@not '.$query.' @attr 14=1 @attr 1=9011 1'; #PQF syntax -- You'll need to test the opac-search.pl stuff, but I've already tested the ccl.properties change and it works a treat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:14:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:14:14 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- Hi all: I noticed that the author of Crypt::GCrypt is active on Github, so I reported the errors there: https://github.com/alexrj/Crypt-GCrypt/issues/2. Hopefully it's just a matter of him being unaware of the issue reported on CPAN back in 2014 and he'll move to fix the problem. Tomas && Hector: the reason it works on Debian is that the Debian team have patched the original Crypt::GCrypt module. You can see that here: https://anonscm.debian.org/cgit/pkg-perl/packages/libcrypt-gcrypt-perl.git/log/ Bob: I use openSUSE 13.2, so I just ran into this problem myself when trying to load master. Hopefully alexrj will fix the problem upstream and then we can download a working module. I was unable to install Crypt::GCrypt from CPAN as it was failing too many tests. It seems to me that without an updated Crypt::GCrypt or without this patch working, no one will be able to use Koha 3.22+ except on Debian-based systems... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:18:33 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #10 from David Cook --- Comment on attachment 44844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44844 [SIGNED-OFF]Bug 15182: Continue to consider Crypt::GCrypt optional Review of attachment 44844: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15182&attachment=44844) ----------------------------------------------------------------- ::: C4/Members.pm @@ +42,5 @@ > use Koha::Database; > + > +use Module::Load::Conditional qw( can_load ); > +if ( can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ) ) { > + load Koha::NorwegianPatronDB, qw( NLUpdateHashedPIN NLEncryptPIN NLSync ); Perhaps "load" should be replaced with "Module::Load::load". I don't know why it's working for others, but I'm guessing that will fix it for her... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:28:34 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #11 from David Cook --- Module::Load and Module::Load::Conditional are both core modules, so I don't know why Katrin was getting that error... I'm guessing that "load" is exported in Module::Load::Conditional but that it doesn't get exported into Members.pm via Module::Load::Conditional. But that doesn't really matter. As Chris Cormack pointed out in IRC, "can_load" already loads the module. There's no point trying to do it twice. You also don't need to import NLUpdateHashedPIN, NLEncryptPIN, and NLSync into the main namespace, as they're being referred to via the Koha::NorwegianPatronDB namespace. What you could do is this: if ( ! can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ) ) { warn "Unable to load Koha::NorwegianPatronDB"; } instead of require Koha::NorwegianPatronDB; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:43:39 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:43:42 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #12 from David Cook --- Created attachment 44898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44898&action=edit Bug 15182 - [alternate] - Conditionally load Koha::NorwegianPatronDB This patch loads Koha::NorwegianPatronDB if it can, or adds a warning to the log if it can't load it. Since the Koha::NorwegianPatronDB functionality in C4::Members is wrapped in system preferences, the loading of the module is irrelevant unless one actually wants to use the module and its associated functionality. NOTE: This patch fixes a problem where we were getting errors saying Crypt::GCrypt couldn't be loaded even though it's not a required dependency. This patch will likely only affect people not using Debian-based systems where libcrypt-gcrypt-perl is available. The current version of Crypt::GCrypt doesn't build so it's not an option for most non-Debian users to install this not required dependency in order to work around this issue... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 02:45:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 01:45:56 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #13 from David Cook --- Changing this back to "Needs Signoff". I just realized I forgot a test plan... _TEST PLAN_ After applying patch: Debian Users: 1) Check to make sure libcrypt-gcrypt-perl is installed 2) visit mainpage.pl 3) Confirm that the page loads correctly 4) Uninstall libcrypt-gcrypt-perl 5) visit mainpage.pl 6) Confirm that the page loads correctly 7) Reinstall libcrypt-gcrypt-perl as you probably want to keep it Non-Debian Users: 1) visit mainpage.pl 2) Confirm that the page loads correctly 3) Profit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:04:37 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #14 from Bob Ewart --- Crypt::GCrypt can be made to work on openSUSE. Download the source for libgcrypt 1.5.4 from ftp://ftp.gnupg.org/gcrypt/libgcrypt/ It will install into /usr/local/lib64 where cpan doesn't find it. cp /usr/local/lib64/libgcrypt.so.11 /usr/lib64 Then cpan install Crypt::GCrypt will work It would be best if alexrj would update Crypt::GCrypt with the debian patch. Otherwise I've been trying to update INSTALL.opensuse which is sadly out of date (it's for openSUSE 11.3). It's a moving target. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:20:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:20:27 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #15 from H?ctor Eduardo Castro Avalos --- In debian Jessie if you uninstall $ dpkg -r libcrypt-gcrypt-perl An error is launched: Software error: Can't locate Crypt/GCrypt.pm in @INC (you may need to install the Crypt::GCrypt module) (@INC contains: /var/koha/koha /var/koha/koha-perl/lib/perl5 /etc/perl /usr/local/lib/i386-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/i386-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/i386-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /var/koha/koha/Koha/NorwegianPatronDB.pm line 58. BEGIN failed--compilation aborted at /var/koha/koha/Koha/NorwegianPatronDB.pm line 58. Compilation failed in require at /var/koha/koha/C4/Members.pm line 43. Compilation failed in require at /var/koha/koha/C4/Letters.pm line 27. BEGIN failed--compilation aborted at /var/koha/koha/C4/Letters.pm line 27. Compilation failed in require at /var/koha/koha/C4/Suggestions.pm line 29. BEGIN failed--compilation aborted at /var/koha/koha/C4/Suggestions.pm line 29. Compilation failed in require at /var/koha/koha/mainpage.pl line 29. BEGIN failed--compilation aborted at /var/koha/koha/mainpage.pl line 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:22:22 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:22:25 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #2 from David Cook --- Created attachment 44899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44899&action=edit Bug 15198 - Make OpacSuppression work even if there are no records suppressed This patch adds the Zebra special attribute 14 to ccl.properties and opac-search.pl, so that we can turn on OpacSuppression and still return results even if there are no records in Zebra for the Suppress index. _TEST PLAN_ Before applying: 1) Make sure that you have no suppressed records indexed in Zebra 2) Turn on OpacSuppression system preference 3) Search using a keyword which should bring up records 4) Note that no records are returned in the results 5) Change UseQueryParser system preference to "Try" 6) Repeat steps 3-4 Apply the patch. After applying: 7) Repeat step 3 (ie search using a keyword which should bring up records) 8) Confirm that records are appearing in the results! 9) Change UseQueryParser system preference to "Do not try" 10) Repeat step 3 11) Confirm that records are appearing in the results! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:26:00 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:27:59 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #16 from H?ctor Eduardo Castro Avalos --- The patch does not apply, last patch needs to be obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:37:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:37:09 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- Neato! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:37:51 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44898|0 |1 is obsolete| | --- Comment #17 from H?ctor Eduardo Castro Avalos --- Created attachment 44900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44900&action=edit [SIGNED-OFF]Bug 15182 - [alternate] - Conditionally load Koha::NorwegianPatronDB This patch loads Koha::NorwegianPatronDB if it can, or adds a warning to the log if it can't load it. Since the Koha::NorwegianPatronDB functionality in C4::Members is wrapped in system preferences, the loading of the module is irrelevant unless one actually wants to use the module and its associated functionality. NOTE: This patch fixes a problem where we were getting errors saying Crypt::GCrypt couldn't be loaded even though it's not a required dependency. This patch will likely only affect people not using Debian-based systems where libcrypt-gcrypt-perl is available. The current version of Crypt::GCrypt doesn't build so it's not an option for most non-Debian users to install this not required dependency in order to work around this issue... Signed-off-by: Hector Castro Works as advertised for Debian-based systems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:38:50 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 04:59:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 03:59:04 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #18 from David Cook --- (In reply to Bob Ewart from comment #14) > Crypt::GCrypt can be made to work on openSUSE. > > Download the source for libgcrypt 1.5.4 from > ftp://ftp.gnupg.org/gcrypt/libgcrypt/ > > It will install into /usr/local/lib64 where cpan doesn't find it. > > cp /usr/local/lib64/libgcrypt.so.11 /usr/lib64 > > Then cpan install Crypt::GCrypt will work > > It would be best if alexrj would update Crypt::GCrypt with the debian patch. > > > Otherwise I've been trying to update INSTALL.opensuse which is sadly out of > date (it's for openSUSE 11.3). It's a moving target. Interesting... yeah I already have libgcrypt 1.6.1 installed. I don't know if I'd really want to have two installs alongside each other... Good on you for looking at INSTALL.opensuse, although if you look at the listserv, there's talk about alternatives to INSTALL.debian, so you might want to follow what's being down with the INSTALL files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 05:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 04:00:01 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #19 from David Cook --- (In reply to H?ctor Eduardo Castro Avalos from comment #16) > The patch does not apply, last patch needs to be obsolete. You can use git bz interactively to only apply the patches you want to apply :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 05:04:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 04:04:07 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #20 from H?ctor Eduardo Castro Avalos --- (In reply to David Cook from comment #19) > You can use git bz interactively to only apply the patches you want to apply > :) Thanks for the tip, David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 05:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 04:36:18 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #30 from David Cook --- Thinking more about matching and how complex or even impossible it is. Consider that you have 2 different OAI-PMH servers with 2 matching records and also 1 matching record locally on Koha. Which is the source of truth? You might argue that the harvested records have a higher priority than the local record... so you can overwrite the local record. However, what about the 2 harvested records? Which one takes precedence? What about if they have holdings records? The National Library of Sweden requires that holdings records be partially merged into bibliographic records... that becomes difficult in this scenario. Every time there is a holding record update, you would need to re-create the bibliographic record from the last harvested bibliographic record (otherwise the holding-bibliographic merge would quite quickly get duplicated or otherwise incorrect fields). I suppose you could choose the most recent bibliographic record as the highest priority, and you could blindly merge holdings into that bibliographic record on each update... You'd have to set up a relationship somewhere between the holdings and the bibliographic record though and this gets tough because the holdings from one OAI-PMH server aren't going to map to that bibliographic record using the 004/001 mechanism. That is... Holdings A 004 refers to Bibliographic A 001, so there is a link there. However, Holdings B 004 refers to Bibliographic B 001 which we're discarding as it's a "duplicate". So we need to have a linkage somewhere between Holdings B and Bibliographic A 001 or preferably Bibliographic A 999$c. I think that might be possible, but certainly not with Koha's existing import mechanisms. -- Importing holdings are going to have other issues as well like how to enforce barcode uniqueness... and how to manage values in records that don't exist in Koha. I also need to use my special OAI import system for managing holdings imports, because there will be no reference to the OAI-PMH unique identifier in the Koha item MARXML, so there's no way to use the existing import system to check if that item already exists. I also don't think there's any way to replace an item record using this system unless it shares the same 952$9. I might be wrong, I haven't investigated that issue thoroughly, but I bet I'm right, as it's a tough one. It's also worth reviewing the section marked "Embedded Holdings Information" in http://www.loc.gov/marc/holdings/hd852.html or http://www.loc.gov/marc/bibliographic/bd852.html. Part of the difficulty with the holdings is the fact that Koha doesn't support MARC21 Format for Holdings Data (MFHD). It would be much easier if it did, although there would still be the problems with the source of truth when merging bibliographic records. Merging records and de-duplicating is one thing when your system is relatively static or updated semi-manually, but when you're importing and auto-merging records at a speed of X records every 2 seconds, you're probably going to run into problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 06:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 05:19:53 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44899|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 44901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44901&action=edit [SIGNED-OFF]Bug 15198: Make OpacSuppression work even if there are no records suppressed This patch adds the Zebra special attribute 14 to ccl.properties and opac-search.pl, so that we can turn on OpacSuppression and still return results even if there are no records in Zebra for the Suppress index. _TEST PLAN_ Before applying: 1) Make sure that you have no suppressed records indexed in Zebra 2) Turn on OpacSuppression system preference 3) Search using a keyword which should bring up records 4) Note that no records are returned in the results 5) Change UseQueryParser system preference to "Try" 6) Repeat steps 3-4 Apply the patch. After applying: 7) Repeat step 3 (ie search using a keyword which should bring up records) 8) Confirm that records are appearing in the results! 9) Change UseQueryParser system preference to "Do not try" 10) Repeat step 3 11) Confirm that records are appearing in the results! Signed-off-by: Hector Castro Works as advertised. No more, won't need to have at least one record with the value "1" in the field mapped with this index. All records in OPAC returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 06:20:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 05:20:03 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #31 from David Cook --- _HOLDINGS_ Diagramming this now... OAI ID -> Koha ID -> Original 001 -> Parent 001 oai::1 -> bib1 -> 1a -> null oai::2 -> bib1 -> 1b -> null oai::3 -> item 3 -> 3a -> 1a oai::4 -> item 4 -> 4a -> 1b So here we've downloaded oai::1 and added it as bib1. We've downloaded oai::2 and determined that it is a duplicate of bib1. We can either overwrite bib1 or we can simply link to it. We've downloaded oai::3. It's original parent 001 is 1a, so we can link oai::3 to bib1. We've downloaded oai::4. It's original parent is 1b, so we can link oai::4 to the entry for oai::2, which is bib1. In this case, the only problems we have are determining what makes a match, and determining whether oai::1 or oai::2 should provide the metadata for bib1. We probably need another field to say which OAI record is the source of truth for bib1. I might be able to use the existing C4::Matcher() for this... It's worth noting that the downloaded metadata will need to be used every time there's an item update, because the National Library of Sweden requires that item-level data be merged into the host bibliographic record... and the only way to do that cleanly is to start with a virgin bibliographic record each time. (Otherwise, when you change a 863 in a holdings record, you won't be updating a 863 in the bib record, you'll be adding a new one and the old one will stay there incorrectly.) Every holdings record will also need to be merged in as well, which could probably cause load problems with records with lots of holdings... Actually, I'm not sure how that's even possible now that I think about it... since you're harvesting from the holdings endpoint every 2 seconds... I suppose you could queue updates to a bibliographic record from the holdings records... but that wouldn't make sense as every updated holdings record would require a full update of the bibliographic record from all holdings records... so any update would need to be processed. I suppose you could queue updates in terms of... if there's a holdings-bibliographic merge in progress, don't start another one as things will explode... still seems like a potentially intensive operation. -- Problems to consider and solve (anyone can chime in here): 1) Precedence of bibliographic-bibliographic merges 2) Merging holdings records into bibliographic records (e.g. 852 and 863 into the bibliographic record... not 952 into bibliographic record) 3) Any local changes to a record will be erased by future downloaded updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 06:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 05:28:32 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com, | |nengard at gmail.com Status|Needs Signoff |Signed Off --- Comment #4 from H?ctor Eduardo Castro Avalos --- I think, IMHO, you need to send another patch rewording the syspref OpacSuppression "Hide/Don't hide items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed biblio record, or your searches will be broken." I also add Documentation Manager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:14:31 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #5 from David Cook --- (In reply to H?ctor Eduardo Castro Avalos from comment #4) > I think, IMHO, you need to send another patch rewording the syspref > OpacSuppression "Hide/Don't hide items marked as suppressed from OPAC > search results. Note that you must have the Suppress index set up in Zebra > and at least one suppressed biblio record, or your searches will be broken." > > I also add Documentation Manager Yes, excellent point! I was thinking of that earlier today, but I totally forgot by the time I was writing the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:17:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:17:15 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #6 from David Cook --- I suppose some of the wording might be accurate... "att 9011 Suppress" does need to exist in bib1.att... but that's fairly obvious and it's a default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:17:37 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #7 from David Cook --- I suppose you also have to have Suppress in ccl.properties... but again that's a default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:18:53 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:18:55 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #8 from David Cook --- Created attachment 44902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44902&action=edit Bug 15198 - Change wording of OpacSuppression system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 07:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 06:19:13 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au --- Comment #9 from David Cook --- Marking this back to "Needs Signoff" for the second patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:00:43 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:07:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:07:45 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #90 from Julian Maurice --- Hi Katrin, I made this assumption by looking at the code, but the code is wrong, and you are right ;) I will submit a followup, replacing the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:24:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:24:14 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #23 from Alex Arnaud --- (In reply to Katrin Fischer from comment #22) > Hm, also a question: if we have separate preferences, do we really still > need 4 preferences? Could we have only 2 preferences and deactivate the > feature by emptying them out? Hello Katrin, We have 3 preferences. 2 for staff (ISBD, viewISBD) and 1 for OPAC (OPACISBD). I agree that we don't need 2 preferences for staff as we do the same job with 1 on opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:27:25 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41842|0 |1 is obsolete| | --- Comment #91 from Julian Maurice --- Created attachment 44903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44903&action=edit Bug 10858: Show checkbox if OpacBrowseResult is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:27:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:27:40 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 09:28:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 08:28:42 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Julian Maurice --- Patch still applies well on master, but you need to apply patches from bug 10858 first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 10:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 09:05:00 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44875|0 |1 is obsolete| | --- Comment #18 from Fr?d?ric Demians --- Created attachment 44904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44904&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 10:07:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 09:07:35 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #19 from Fr?d?ric Demians --- (In reply to H?ctor Eduardo Castro Avalos from comment #16) > I don't know why fail me in my laptop with Debian Jessie. In my work does > not fail with Dian wheezy, both Distros have the same version > () I've reproduced your UT error on a Jessie box. I've fixed it, and reattached your signed path, with the corrected UT. Please confirm it also works for you on Jessie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 11:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 10:24:00 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #32 from Andreas Hedstr?m Mace --- Just a quick note: the idea of having a harvest running every 2 or 3 seconds is my personal preference. If it is not possible due to potential conflicts or heavy loads, then this could be revised. I would be ok with an harvest once every 10 seconds, every 30 seconds or even once a minute. But preferably not much slower than that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 12:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 11:37:17 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 12:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 11:37:20 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44897|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 44905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44905&action=edit [PASSED QA] Bug 15197: In Rancor, multiple &/ Works well, record saved No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 12:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 11:51:45 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 12:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 11:51:48 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44900|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 44906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44906&action=edit [PASSED QA] Bug 15182 - [alternate] - Conditionally load Koha::NorwegianPatronDB This patch loads Koha::NorwegianPatronDB if it can, or adds a warning to the log if it can't load it. Since the Koha::NorwegianPatronDB functionality in C4::Members is wrapped in system preferences, the loading of the module is irrelevant unless one actually wants to use the module and its associated functionality. NOTE: This patch fixes a problem where we were getting errors saying Crypt::GCrypt couldn't be loaded even though it's not a required dependency. This patch will likely only affect people not using Debian-based systems where libcrypt-gcrypt-perl is available. The current version of Crypt::GCrypt doesn't build so it's not an option for most non-Debian users to install this not required dependency in order to work around this issue... Signed-off-by: Hector Castro Works as advertised for Debian-based systems Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 12:59:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 11:59:18 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Leif Andersson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leif.andersson at sub.su.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:00:22 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:01:32 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44810|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44907&action=edit [PASSED QA] Bug 15070: Update MARC21 it-IT frameworks to Update 21 (September 2015) To test it: - drop and recrate Koha DB - Run the Koha web installer for it-IT - Run MARC bibliographic framework test http://bugs.koha-community.org/show_bug.cgi?id=15070 Signed-off-by: Bernardo Gonzalez Kriegel Tested with it-IT installer All files load without problem, save for FastAdd (see Bug 15181) but the file loads Ok Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:48:40 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer --- I am sorry, I have tested this up and down, but it doesn't work for me. The specified due date always gets set to the shortened due date and my previously specified date is lost :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:54:06 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:54:10 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44301|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 44908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44908&action=edit [PASSED QA] Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:54:58 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #46 from Katrin Fischer --- Ok, I tested again and after logging in and out again it started to work... I think my previous testing was flawed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:56:28 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:56:56 +0000 Subject: [Koha-bugs] [Bug 15197] In Rancor, multiple &/ References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:57:21 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:57:46 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 13:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 12:59:32 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #47 from Eivin Giske Skaaren --- (In reply to Katrin Fischer from comment #46) > Ok, I tested again and after logging in and out again it started to work... > I think my previous testing was flawed. Great, this has been redone and rebased a lot so I got a little bit worried there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:00:08 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:00:31 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:00:52 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Items with no holdingbranch |[3.20] Items with no |causes user's holds display |holdingbranch causes user's |to freeze |holds display to freeze -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:00:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:00:53 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:03:31 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:05:01 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Failed QA |Needs Signoff --- Comment #4 from Katrin Fischer --- Hi Hector, those files are generated from the database - so all the columns will appear there, but it doesn't indicate that they are used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:06:28 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:06:52 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #48 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Eivin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:07:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:07:13 +0000 Subject: [Koha-bugs] [Bug 15185] 3 subroutines are unused in C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:15:56 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer --- Please make the small fixes suggested by Frederic! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:18:59 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 --- Comment #7 from Katrin Fischer --- Hi Viktor, currently the patron category would be only used at checkout time - so overdues/notices, renewals, etc. would still be those of the initial category as after the checkout there is no trace of the switched category. That's why I feel quite uncomfortable with the idea to be honest. The only thing it will work for is determining the initial loan period. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:20:44 +0000 Subject: [Koha-bugs] [Bug 15199] New: t/db_dependent/Review.t should not depend on existing data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Bug ID: 15199 Summary: t/db_dependent/Review.t should not depend on existing data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com It currently depends on existing patrons and categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:24:06 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:24:09 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 44909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44909&action=edit Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:24:40 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:34:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:34:21 +0000 Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Francisco, no patch has been submitted for this yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:37:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:37:06 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:37:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:37:08 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44788|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44910&action=edit [PASSED QA] Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards Signed-off-by: Hector Castro All tests successful. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:44:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:44:19 +0000 Subject: [Koha-bugs] [Bug 15159] TestBuilder behaviour on AI values should be tested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 14:59:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 13:59:15 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #130 from Colin Campbell --- (In reply to Paul Poulain from comment #129) > Functionality question: is there an EDIFACT way for a vendor to cancel an > order line (ie: the vendor cannot deliver an item that was ordered) ? Yes its a separate message an Order Response it can cancel an order also report on orders that cannot be immediately fulfilled (e.g. reprinting ) I have the code which reads them I just need to add the resulting updates to the koha files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:02:58 +0000 Subject: [Koha-bugs] [Bug 14869] Show barcode instead of itemnumber on fines summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Please keep in mind we will need a fallback for items without barcodes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:04:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:04:46 +0000 Subject: [Koha-bugs] [Bug 14869] Show barcode instead of itemnumber on fines summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14869 --- Comment #2 from Katrin Fischer --- ... ok, that might be a bit theoretical, as for a checkout you need to have a barcode assigned currently, even when not using it for the checkout itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:10:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:10:03 +0000 Subject: [Koha-bugs] [Bug 15057] Exporting Default Framework results in empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15057 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Frederic, you are right - this appears to be fixed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:12:57 +0000 Subject: [Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 --- Comment #8 from Viktor Sarge --- > currently the patron category would be only used at checkout time - so > overdues/notices, renewals, etc. would still be those of the initial > category as after the checkout there is no trace of the switched category. > That's why I feel quite uncomfortable with the idea to be honest. The only > thing it will work for is determining the initial loan period. I knew we would not be able to ignore all the other places the category is used :) You are quite right of course Katrin - renewals is another place that we would have to take into account to make this happen. Since there is no desperate need for this patch and the scope is growing to include all those places we suspected I propose that we leave this in discussion for the time being. There?s other development that needs to happen, but if someone would find it highly useful we might pick it up again. I think the current patch is great for trying out the concept and get a feel of the proposed change if anyone would want to try the suggested workflow. I still think the idea is worthwhile, but the development cost is currently looking to high for us compared to the payoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:19:29 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #24 from Katrin Fischer --- Hi Alex, you are right, sorry - I think I misread last night. I think deduplicating the 2 staff preferences would be good, but on a separate bug :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:19:55 +0000 Subject: [Koha-bugs] [Bug 14100] Make item types, branch names, sysprefs value and authorised values translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Generic solution for |Make item types, branch |language overlay |names, sysprefs value and | |authorised values | |translatable CC| |paul.poulain at biblibre.com --- Comment #66 from Paul Poulain --- updating summary for release notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:21:55 +0000 Subject: [Koha-bugs] [Bug 14100] Make item types translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make item types, branch |Make item types |names, sysprefs value and |translatable |authorised values | |translatable | --- Comment #67 from Katrin Fischer --- I am not sure if this is not confusing for the release notes - we only implemented itemtypes so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:22:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:22:30 +0000 Subject: [Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make item types |Add base to make item |translatable |types, branch names, | |sysprefs values and | |authorised values | |translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:26:55 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44902|0 |1 is obsolete| | --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 44911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44911&action=edit [SIGNED-OFF]Bug 15198: Change wording of OpacSuppression system preference Signed-off-by: Hector Castro Paragraph rewording successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:27:14 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:37:30 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:51:15 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #33 from Katrin Fischer --- I was told recently that 2-3 seconds is quite standard for OAI-PMH harvests. I think a problem could occur if Zebra is involved in matching as you have to make sure the indexes have caught up before you can reliably match. Say a record is changed at the source twice in a very short timeframe... or added and then changed again, included in 2 harvests... but not yet indexed when the second runs, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 15:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 14:53:13 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #34 from Katrin Fischer --- Sorry Marc - a recent change causes a merge conflict in checkexpiration.pl. Can you please take a look and fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 16:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 15:06:10 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #34 from Andreas Hedstr?m Mace --- Yes, if we can avoid using Zebra for matching that would probably be for the best. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 16:14:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 15:14:53 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #35 from Marc V?ron --- (In reply to Katrin Fischer from comment #34) > Sorry Marc - a recent change causes a merge conflict in checkexpiration.pl. > Can you please take a look and fix? Hi Katrin, thanks for taking care of this bug :-) I tested, both patches apply on my server. (I did a git pull some minutes ago, HEAD is at 72d0dc6 Bug 15159: TestBuilder behaviour on AI values should be tested.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:20:31 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44909|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 44912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44912&action=edit [SIGNED-OFF]Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off Signed-off-by: Hector Castro All test pass successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:20:48 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:23:41 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44904|0 |1 is obsolete| | --- Comment #20 from Fr?d?ric Demians --- Created attachment 44913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44913&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:49:21 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44913|0 |1 is obsolete| | --- Comment #21 from H?ctor Eduardo Castro Avalos --- Created attachment 44914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44914&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:51:18 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44914|0 |1 is obsolete| | --- Comment #22 from H?ctor Eduardo Castro Avalos --- Created attachment 44915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44915&action=edit [SIGNED-OFF]Bug 14939: Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully Works for Debian Jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 17:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 16:57:24 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:02:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:02:55 +0000 Subject: [Koha-bugs] [Bug 15200] New: t/Creators.t fails when using build-git-snapshot Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Bug ID: 15200 Summary: t/Creators.t fails when using build-git-snapshot Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mirko at abunchofthings.net QA Contact: gmcharlt at gmail.com When trying to build a Debian package from git with build-git-snapshot, t/Creators.t fails and packages won't build. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. # Failed test 'testing StrWidth() returns correct point width' # at t/Creators.t line 55. # got: '19.344' # expected: '23.044921875' # Failed test 'testing Text() writes to the correct x-value' # at t/Creators.t line 59. # got: '29.344' # expected: '33.044921875' ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /tmp/buildd/koha-3.22~beta+20151117174350.71ed2e4f/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 123. Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820. # Looks like you planned 41 tests but ran 39. # Looks like you failed 2 tests of 39 run. # Looks like your test exited with 25 just after 39. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44231|0 |1 is obsolete| | Attachment #44232|0 |1 is obsolete| | Attachment #44233|0 |1 is obsolete| | Attachment #44234|0 |1 is obsolete| | Attachment #44235|0 |1 is obsolete| | Attachment #44236|0 |1 is obsolete| | Attachment #44237|0 |1 is obsolete| | Attachment #44239|0 |1 is obsolete| | Attachment #44240|0 |1 is obsolete| | Attachment #44241|0 |1 is obsolete| | Attachment #44242|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall --- Created attachment 44916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44916&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:13 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #67 from Kyle M Hall --- Created attachment 44917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44917&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:20 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #69 from Kyle M Hall --- Created attachment 44919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44919&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:16 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #68 from Kyle M Hall --- Created attachment 44918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44918&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:23 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #70 from Kyle M Hall --- Created attachment 44920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44920&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:27 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #71 from Kyle M Hall --- Created attachment 44921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44921&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:34 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #73 from Kyle M Hall --- Created attachment 44923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44923&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:31 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #72 from Kyle M Hall --- Created attachment 44922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44922&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:37 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #74 from Kyle M Hall --- Created attachment 44924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44924&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #75 from Kyle M Hall --- Created attachment 44925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44925&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:04:44 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #76 from Kyle M Hall --- Created attachment 44926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44926&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:13:44 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:13:47 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44742|0 |1 is obsolete| | Attachment #44743|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 44927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44927&action=edit [PASSED QA] Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:13:54 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #20 from Kyle M Hall --- Created attachment 44928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44928&action=edit [PASSED QA] Bug 14960: Simplify the date management in staticfines There is no need to create a DT objcet, then display in string/iso then recreate a DT object from this string. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:41:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:41:15 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:41:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:41:20 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41789|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 44929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44929&action=edit [SIGNED-OFF] Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel Not a complete list but is a start Lots of new strings to translate :) No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:49:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:49:46 +0000 Subject: [Koha-bugs] [Bug 15201] New: Managing serial numbering patterns requires full serials module permissions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15201 Bug ID: 15201 Summary: Managing serial numbering patterns requires full serials module permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Only staff members with full serial module permissions can access the numbering patterns. It would be nicer if this was a separate permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:59:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:59:00 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:59:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:59:03 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44775|0 |1 is obsolete| | Attachment #44799|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer --- Created attachment 44930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44930&action=edit [PASSED QA] Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. Tested on top of 15166 15168 15171, full browser reload for date pickers. Note for 4/: It is the link in tab planning on subscription detail page, near "Manual history" (if manual history is enabled). Works as advertised. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 18:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 17:59:16 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #37 from Katrin Fischer --- Created attachment 44931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44931&action=edit [PASSED QA] Bug 14969: (followup) Today's date withoute time when receiving To test: Change status of a serial from Expected to Received, today's date in column "Expected" should appear without time. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:08:53 +0000 Subject: [Koha-bugs] [Bug 14953] Adlibris (Swedish supplier) cover image support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:09:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #77 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #76) > Remote branch rebased. Needs a new rebase, there are some conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:23:36 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Patch does not apply. Besides, there are other places that reference some of this values e.g. proccode koha-tmpl/intranet-tmpl/prog/en/columns.def:Type of procedure t/db_dependent/Stats.t:is ($params-> {accountno}, $line->{proccode}, "UpdateStats save accountno param in proccode field of statistics table"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:29:31 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44500|0 |1 is obsolete| | --- Comment #27 from Bernardo Gonzalez Kriegel --- Created attachment 44932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44932&action=edit [SIGNED-OFF] Bug 4502: Changing wording again... Signed-off-by: Bernardo Gonzalez Kriegel Just a string patch, others are signed. No errors -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:30:10 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:31:59 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #9 from Katrin Fischer --- Argh, ignore my last comment. I think this is a difference between GRS1 and DOM indexing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:39:42 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- There is something very weird on the invoices and invoice pages - see screenshots attached. The dates in the database are correct and the dateformat setting is set to DD/MM/YYYY. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:40:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:40:20 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #19 from Katrin Fischer --- Created attachment 44933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44933&action=edit Screenshot of invoices page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:40:52 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #20 from Katrin Fischer --- Created attachment 44934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44934&action=edit Screenshot of invoice page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:43:24 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:43:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:43:50 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:43:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:43:56 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:44:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:44:52 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #21 from Katrin Fischer --- ... what seemed so weird is just another dateformat setting - I had just reloaded an older database *sigh*. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:51:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:51:10 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 44935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44935&action=edit Bug 15168: (followup) remove useless diags While testing this bug I noticed the tests printed useless diags. This patch removes them for good. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:52:33 +0000 Subject: [Koha-bugs] [Bug 15168] Remove C4::Serials::ItemizeSerials which is not used anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:53:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:53:21 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #38 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 19:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 18:53:56 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #21 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 21:36:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 20:36:51 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Mirko, Are you using a most up-to-date koha-conf.xml when you are building your git snapshot? If you don't have these font values in there (or you don't have your KOHA_CONF env exported) this test will fail. If they are in there, then yeah, you've got a problem. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 21:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 20:45:25 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 22:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 21:06:48 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #43 from Nick Clemens --- Small conflict in a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt (from addition of audio alerts) Bigger issue, I can't get it to save the chosen SMS provider on the borrower screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:02:30 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Nick Clemens --- simple notice conflicts, less simple Reserves.pm conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:05:04 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #15 from Nick Clemens --- fatal: sha1 information is lacking or useless (Koha/Service.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:18:32 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 --- Comment #2 from Mirko Tietgen --- The font stuff is in the koha-conf.xml > /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf etc. I will check the KOHA_CONF tomorrow, but I suspect more things would fail without that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:23:49 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14695 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:23:49 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5144 | Status|Needs Signoff |Patch doesn't apply CC| |nick at bywatersolutions.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:24:09 +0000 Subject: [Koha-bugs] [Bug 15200] t/Creators.t fails when using build-git-snapshot In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 --- Comment #3 from Liz Rea --- Generating PDF's without encoding issues would be a problem, for sure. This is kind of an ongoing problem, how to make sure we've got the latest stuff in koha-conf.xml as we pass through versions. I think Magnus had a solution for it at one point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 17 23:40:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 22:40:41 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Lucio Moraes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoraes at catalyst.net.nz --- Comment #4 from Lucio Moraes --- Hi Joonas, if you have a staged file to test, could you share with me? Thank you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 00:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 23:33:12 +0000 Subject: [Koha-bugs] [Bug 15202] When transferring an order, date displays incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 00:33:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 23:33:06 +0000 Subject: [Koha-bugs] [Bug 15202] New: When transferring an order, date displays incorrectly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Bug ID: 15202 Summary: When transferring an order, date displays incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When transferring an order to another vendor on of the dates is shown as yyyy-mm-dd instead of being formatted according to the dateformat system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 00:39:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 23:39:03 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 00:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 23:39:06 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44722|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 44936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44936&action=edit [PASSED QA] Bug 14946: Remove C4::Dates from acqui/* files This patch replaces all use of C4::Dates with Koha::DateUtils, which is the best practice to follow. It also fixes a bug on the invoice search, the shipment date (from and to) were not passed correctly from one page to the other. Test plan: 1/ Search for orders using the different filters 2/ Create an invoice, try with setting and leaving empty the date fields. Default should be an undefined value (not today) 3/ Search for invoices and use the 4 different filters. Close and reopen invoices. The filters should be kept from one page to the other (not that it does not work with shipment date before this patch). 4/ Receive an order, on creating the invoice, the default date should be today. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 00:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Nov 2015 23:59:56 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- It appears a few are missing. I tested this on top of: 14954 14946 I found those references outside the release notes: C4/Serials.pm:$planneddate is a C4::Dates object. misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl:use C4::Dates; serials/acqui-search-result.pl:use C4::Dates qw/format_date/; t/DateUtils.t:# C4::Dates allowed 00th of the month 2 of those appear to be comments - but please check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:40:40 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:40:40 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15076 --- Comment #23 from Katrin Fischer --- Looked a bit further: 1) C4/Serials.pm:$planneddate is a C4::Dates object. - POD, should be corrected 2) misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl:use C4::Dates; - Covered by bug 15076. We need to make a decision there. 3) serials/acqui-search-result.pl:use C4::Dates qw/format_date/; - This one needs to be fixed, has a few date_format. 4) t/DateUtils.t:# C4::Dates allowed 00th of the month - I think that can probably be ignored Looking for format_date I find one more ocurrence: 5) C4/Log.pm: $data->{day} = format_date($data->{timestamp}); - Looks like this was missed. format_date_in_iso: 6) C4/Items.pm: $datelastseen = format_date_in_iso($datelastseen); 7) t/db_dependent/Items/GetItemsForInventory.t: $datelastseen = format_date_in_iso($datelastseen); 8) tools/koha-news.pl: #$new->{'expirationdate'}=format_date_in_iso($new->{'expirationdate'}); Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:50:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:50:28 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:50:31 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42869|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 44937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44937&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:58:33 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:58:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:58:35 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44749|0 |1 is obsolete| | --- Comment #29 from Brendan Gallagher --- Created attachment 44938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44938&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv Signed-off-by: Mirko Tietgen http://bugs.koha-community.org/show_bug.cgi?id=14945 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:58:42 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44750|0 |1 is obsolete| | --- Comment #30 from Brendan Gallagher --- Created attachment 44939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44939&action=edit Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:58:46 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44751|0 |1 is obsolete| | --- Comment #31 from Brendan Gallagher --- Created attachment 44940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44940&action=edit Bug 14954: (followup) Display exceptions in syspref format This patch fixes the display of exceptions (was iso, is now syspref). See comment #14 and attachment #15 Signed-off-by: Nick Clemens Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 01:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 00:58:52 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44752|0 |1 is obsolete| | --- Comment #32 from Brendan Gallagher --- Created attachment 44941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44941&action=edit Bug 14954: Remove unused C4::Calendar::addDate subroutine Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 02:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 01:29:31 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 02:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 01:29:34 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44912|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 44942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44942&action=edit [PASSED QA] Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off Signed-off-by: Hector Castro All test pass successful Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 03:46:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 02:46:38 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #23 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 03:47:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 02:47:11 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #33 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 03:47:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 02:47:36 +0000 Subject: [Koha-bugs] [Bug 15199] t/db_dependent/Review.t should not depend on existing data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 03:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 02:54:37 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 --- Comment #3 from Francisco Peixoto --- Hello Jonathan, thanks. The value is NULL. And we got the same value for all patrons. I think this is how it should be right? Thank you very much Kind regards Francisco -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 04:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 03:51:56 +0000 Subject: [Koha-bugs] [Bug 15203] New: select all -> add to list from a result page in the OPAC gives you double ups in your list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15203 Bug ID: 15203 Summary: select all -> add to list from a result page in the OPAC gives you double ups in your list Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To replicate: Do a search. Click "Select all" to select all records In the table header, click Add to -> New list (or choose an existing list, it does the same for both) Look at your list, notice it has double ups of everything you selected to add. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 08:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 07:08:51 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #10 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #9) > Argh, ignore my last comment. I think this is a difference between GRS1 and > DOM indexing? Right: as we were used too under GRS1... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:22:28 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #24 from Marc V?ron --- Created attachment 44943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44943&action=edit Bug 14969: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:29:22 +0000 Subject: [Koha-bugs] [Bug 15204] New: Auth.pm does too much Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204 Bug ID: 15204 Summary: Auth.pm does too much Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org As a first step to re-factoring Auth.pm for bug 7174 we need to limit the scope of what Auth.pm does. Currently C4::Auth.pm handles both Authentication and Authorization which is the maximum of what it should do. Unfortunately it also handles in part the Context, the Session, and the Templates. For proper separation of concerns it should do none of these things! This bug should act as a central point for building a dependency tree of work required to factor out these supplementary roles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:29:50 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:30:02 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #25 from Marc V?ron --- Created attachment 44944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44944&action=edit Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:30:28 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:31:32 +0000 Subject: [Koha-bugs] [Bug 15205] New: Factor 'SyndeticsEnabled' out of Auth.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 Bug ID: 15205 Summary: Factor 'SyndeticsEnabled' out of Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, gmcharlt at gmail.com, testopia at bugs.koha-community.org Depends on: 15204 Auth.pm should not handle Syndetics related template variables, they have absolutely nothing to do with Authentication or Authorization! Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204 [Bug 15204] Auth.pm does too much -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:31:32 +0000 Subject: [Koha-bugs] [Bug 15204] Auth.pm does too much In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15205 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:32:05 +0000 Subject: [Koha-bugs] [Bug 15204] Auth.pm does too much In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15205 | Depends on| |15205 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:32:05 +0000 Subject: [Koha-bugs] [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15204 Depends on|15204 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204 [Bug 15204] Auth.pm does too much -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:43:58 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:44:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:44:01 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44498|0 |1 is obsolete| | Attachment #44499|0 |1 is obsolete| | Attachment #44932|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 44945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44945&action=edit [PASSED QA] Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:44:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:44:17 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #29 from Katrin Fischer --- Created attachment 44946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44946&action=edit [PASSED QA] Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:44:21 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #30 from Katrin Fischer --- Created attachment 44947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44947&action=edit [PASSED QA] Bug 4502: Changing wording again... Signed-off-by: Bernardo Gonzalez Kriegel Just a string patch, others are signed. No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:50:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:50:00 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This appears similar to bug 15030 - which I think tries to fix the behaviour. Liz, could you maybe take a look at the other bug too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:51:28 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #7 from Katrin Fischer --- Or Joonas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:51:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:51:34 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 09:51:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 08:51:34 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:08:01 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|j.kylmala at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #8 from Joonas Kylm?l? --- (In reply to Katrin Fischer from comment #7) > Or Joonas? I'm not working on this bug anymore, so someone else feel free to assign this to him- or herself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:15:37 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Joonas Kylm?l? --- (In reply to Lucio Moraes from comment #4) > Hi Joonas, > if you have a staged file to test, could you share with me? > Thank you Unfortunately I don't have one. And now I'm thinking if the patch I supplied here is obsolete because this might only apply for the https://github.com/KohaSuomi/kohasuomi version of Koha. I'll change the status to "In Discussion" for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:29:43 +0000 Subject: [Koha-bugs] [Bug 15206] New: Show patron's age when filling date of birth in memberentry.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Bug ID: 15206 Summary: Show patron's age when filling date of birth in memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When creating a new patron and filling the "dateofbirth" datepicker element, a message under the element shows the patron's age. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:29:49 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43808|0 |1 is obsolete| | --- Comment #28 from Holger Mei?ner --- Created attachment 44948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44948&action=edit Bug 14101: Automatic renewals exactly on due date If no value for 'no renewal before' is specified, automatic renewal now falls back on the due date. Also 'no renewal before' can now be zero, so both automatic and manual renewals can be delayed until due date. Test plan: 1) Create some circulation rules with different settings for 'No renewal before' and 'Automatic renewal'. Both daily and hourly loans should work. 2) Try to renew both manually and automatically before and after a renewal should be possible. You can run misc/cronjobs/automatic_renewals.pl for automatic renewal. 3) Confirm that: * Both automatic and manual renewal with 'No renewal before' set to 0 do not happen before the due date (exact DateTime). * Manual renewal with 'No renewal before' set to undef (enter empty string) is unrestricted. * Automatic renewal with 'No renewal before' set to undef does not happen before the due date. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:29:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:29:53 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43809|0 |1 is obsolete| | --- Comment #29 from Holger Mei?ner --- Created attachment 44949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44949&action=edit Bug 14101: Unit tests This patch adds new test cases to check if CanBookBeRenewed provides correct return values and error codes for premature renewals. Both manual and automatic renewals and different settings for 'No renewal before' are tested. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:30:49 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43810|0 |1 is obsolete| | --- Comment #39 from Holger Mei?ner --- Created attachment 44950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44950&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:30:52 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43811|0 |1 is obsolete| | --- Comment #40 from Holger Mei?ner --- Created attachment 44951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44951&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:30:55 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43812|0 |1 is obsolete| | --- Comment #41 from Holger Mei?ner --- Created attachment 44952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44952&action=edit Bug 14395: Unit tests This patch adds test cases for the new syspref NoRenewalBeforePrecision. Tests if GetSoonestRenewDate returns correct values for both 'date' and 'exact_time' settings. Also adds a few comments related to bugs 7413 and 14101. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:32:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:32:28 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #30 from Holger Mei?ner --- Rebased on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:32:58 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #35 from Andreas Hedstr?m Mace --- (In reply to David Cook from comment #29) > I'm also tempted to change the existing system so that you define OAI-PMH > servers, and then create OAI-PMH tasks for those servers. This information > would all be stored in the database. Then, when you wanted to run a task, > you could click "Run" on the Web UI, and it would send the task to the > daemon. To me, this sounds like the way to go! In our case, we would set the task of repeated harvest - and not look at it again unless there are problems. =) > I haven't 100% thought out how the Web UI and the daemon will communicate > yet. While that above paragraph sounds good, what happens if the daemon dies > for some reason? If it requires a message from the Web UI, it'll need a > human to restart it. > > Actually, another idea... the Web UI could send the task, and the daemon > could write it away to a temporary file which it cleans up after it's > finished a task. If it crashes and gets restarted, it can check its > temporary files to see what it was in the middle of doing. Yeah... that's > probably a better idea. This too sounds like good approach to me. Some sort of fail-safe to have the harvester pick up and continue what it was doing if it has crashed - but it should be set from the UI to begin with! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:33:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:33:23 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #42 from Holger Mei?ner --- Rebased on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:38:33 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #1 from Alex Arnaud --- Created attachment 44953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44953&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create a new patron (members/memberentry.pl), enter a date of birth, patron'a age should be shown under -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:38:51 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:38:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:38:59 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:44:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:44:04 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #26 from Zeno Tajoli --- Hi, I found that in reports/guided_reports.pl C4:Dates is still present: 359 # If the range values are dates 360 if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ C4::Dates->regexp('syspref')) { 361 $fromvalue = C4::Dates->new($fromvalue)->output("iso"); 362 $tovalue = C4::Dates->new($tovalue)->output("iso"); 363 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:46:50 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #27 from Zeno Tajoli --- Hi, I found that in reports/guided_reports.pl C4:Dates is still present. >From lines 359 to 363: # If the range values are dates if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ C4::Dates->regexp('syspref')) { $fromvalue = C4::Dates->new($fromvalue)->output("iso"); $tovalue = C4::Dates->new($tovalue)->output("iso"); } A new bug or you fix here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 10:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 09:47:52 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 11:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 10:20:29 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #28 from Marc V?ron --- Hi Zeno, thakns for testing. I can not find C4::Dates in reports/guided_reports.pl Git grep 'C4::Dates' only gives results only in misc/release_notes/release_notes_3_22_0.txt I applyed the patches after a recent git pull: HEAD is now at 87e7d55 Bug 15199: t/db_dependent/Review.t should not depend on existing data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 11:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 10:24:24 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #29 from Marc V?ron --- Switching back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 11:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 10:58:27 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #30 from Marc V?ron --- Created attachment 44954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44954&action=edit Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 12:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 11:20:40 +0000 Subject: [Koha-bugs] [Bug 15207] New: Error on upgrade from 3.20.5 to 3.22 beta Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bug ID: 15207 Summary: Error on upgrade from 3.20.5 to 3.22 beta Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 12:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 11:24:40 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #1 from Zeno Tajoli --- Hi, I try to do an update from 3.20.5 to master (3.22 beta at db level). I have done a standard marc21 english install using all sql files, mandatory and optional. I receive two errors: updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha.#sql-3a4_7f' (errno: 121) [for Statement " updatedatabase.pl: ALTER IGNORE TABLE course_reserves updatedatabase.pl: add CONSTRAINT course_reserves_ibfk_2 updatedatabase.pl: FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) updatedatabase.pl: ON DELETE CASCADE ON UPDATE CASCADE updatedatabase.pl: "] at /production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line 10804. updatedatabase.pl: DBD::mysql::db do failed: Duplicate entry '1-self_checkout' for key 'PRIMARY' [for Statement " updatedatabase.pl: INSERT INTO permissions (module_bit, code, description) updatedatabase.pl: VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID') updatedatabase.pl: "] at /production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line 10871. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 12:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 11:27:58 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- I'd be inclined to remove it at this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 12:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 11:53:24 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #2 from Zeno Tajoli --- The first problem (about change in table course_reserves, bug 14205) is not a real problem for y test situation. Course Reserve is not active and the new costraint, course_reserves_ibfk_2, it was added without problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 12:57:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 11:57:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #36 from Andreas Hedstr?m Mace --- (In reply to David Cook from comment #30) > Thinking more about matching and how complex or even impossible it is. > > Consider that you have 2 different OAI-PMH servers with 2 matching records > and also 1 matching record locally on Koha. > > Which is the source of truth? > > You might argue that the harvested records have a higher priority than the > local record... so you can overwrite the local record. > > However, what about the 2 harvested records? Which one takes precedence? I would think that this could be solved by adding a "priority option" when adding new servers. Then the user would decide which source should be ranked higher in terms of conflict/duplicates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 13:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 12:15:35 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #3 from Zeno Tajoli --- The second error is present because the update 3.21.00.027 starts so: dbh->do(q| INSERT INTO permissions (module_bit, code, description) VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID') |); But in 3.20.5 in file installer/data/mysql/en/mandatory/userpermissions.sql I see: INSERT INTO permissions (module_bit, code, description) VALUES [...] ( 1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for the patron matching the AutoSelfCheckID'), So in 3.20.x the code 'self_checkout' could be present. I don't know if it is better to 'INSERT IGNORE' or other statement. A discussion on the topic here: http://stackoverflow.com/questions/548541/insert-ignore-vs-insert-on-duplicate-key-update Tecnaly speaking also this error is not blocking, the code 'self_checkout' is present in the table permissions with a correct value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 13:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 12:15:53 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:06:49 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |z.tajoli at cineca.it |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:12:49 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #4 from Marc V?ron --- Created attachment 44955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44955&action=edit Bug 15076: Remove file misc/maintenance/fix_accountlines_date.pl This patch removes the file misc/maintenance/fix_accountlines_date.pl To test: - Verify that the file is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:13:17 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #37 from Viktor Sarge --- > > You might argue that the harvested records have a higher priority than the > > local record... so you can overwrite the local record. > > > > However, what about the 2 harvested records? Which one takes precedence? > > I would think that this could be solved by adding a "priority option" when > adding new servers. Then the user would decide which source should be ranked > higher in terms of conflict/duplicates. Relevant to this discussion might be the fact that we built both tracking of changes to MARC-records with the possibility to roll back changes + a system for setting rules for who can change what fields in MARC records. I'll dig up the relevant threads. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:17:33 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15076 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:17:33 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14870 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14870 --- Comment #5 from Marc V?ron --- Independently on removal, the file does no longer block 14870, moved from "Blocks" to "See also" Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:17:58 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #38 from Viktor Sarge --- Write protecting MARC fields based on source of import http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 History for MARC records. Roll back changes on a timeline or per field. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 I'm not quite certain if this should be "See also" connections - what say ye? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:27:43 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #4 from Zeno Tajoli --- About the first error: The motivation of the error is that in 3.20.5 the second constraint on the table course_reserves is present in its version onf kohastructure.sql: `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE in http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=52eb88d1c35a3cfd825cd16412b49929ab6153ae;hb=refs/heads/3.20.x#l627 We can see here: http://stackoverflow.com/questions/12623651/error-error-1005-cant-create-table-errno-121 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:37:20 +0000 Subject: [Koha-bugs] [Bug 15208] New: Ease translation for shelves messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Bug ID: 15208 Summary: Ease translation for shelves messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Shelves messages give us a 'big' string to translate. We need to split it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:39:05 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 44956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44956&action=edit Bug 15208: Ease translation for shelves messages This string patch only puts ... around shelves messages. It split a monster translation string into its components. This kind of string to translate is error-prone. Also fixed a typo on opac, 'deleteing' To test: 1) Search for 'An error occurred when updating this list' on your preferred language translation file for staff or opac (xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po) You will see a 'big' string to translate 2) Apply the patch 3) Update translation files for your language 4) Search again, big one is gone and there are new individual strings to translate. Sorry for not spotting this before string freeze -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:39:38 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:47:45 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 44957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44957&action=edit Bug 15208: Followup to reorder words It think it's better to put the shelf name first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 14:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 13:58:36 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Alex, I like thsi feature. I played around with a 10 year old kid. Today we have 18/11/2015 This are my results: 18/11/2005 -> Age: 10 year(s) 2 day(s) 18/11/2005 -> Age: 10 year(s) 1 day(s) 20/11/2005 -> Age: 10 year(s) 21/11/2005 -> Age: 9 year(s) 11 month(s) 30 day(s) 22/11/2005 -> Age: 9 year(s) 11 month(s) 29 day(s) There seems to be an offset of some days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:37:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:37:39 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44491|0 |1 is obsolete| | --- Comment #18 from Marc V?ron --- Created attachment 44958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44958&action=edit Bug 15091: Do not allow to use batch checkout if checkout is not allowed If the noissue param is passed to the template, the batch checkout should not be allowed. This patch globally fixes the problem raised by bug 15091. A generic message "cannot check out" is displayed and some more specific ones could be added later. For now it only trigger the "fine balance is over the limit" message. Test plan: Confirm there is no regression on the original behavior and that the issue raised on bug 15091 is fixed. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:38:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:38:53 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44492|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Created attachment 44959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44959&action=edit Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:43:07 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #5 from Zeno Tajoli --- Created attachment 44960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44960&action=edit patch for fix update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:43:08 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Signed Off --- Comment #20 from Marc V?ron --- Set Jonathan as assibnee because he made patches #2 and #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:43:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:43:23 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:43:37 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:44:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:44:11 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:52:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:52:00 +0000 Subject: [Koha-bugs] [Bug 15209] New: C4::Koha routines expecting a MARC::Record object should check it is defined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Bug ID: 15209 Summary: C4::Koha routines expecting a MARC::Record object should check it is defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This came to light when trying to get plack opac running. A number of routines in C4::Koha return various identifiers from the marc record but do not check it is valid before calling methods on it. The resulting errors cause the plack instance to abort. It is good practice to handle these errors with minimum inconvenience to the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:57:47 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44956|0 |1 is obsolete| | Attachment #44957|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 44961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44961&action=edit [SIGNED-OFF] Bug 15208: Ease translation for shelves messages This string patch only puts ... around shelves messages. It split a monster translation string into its components. This kind of string to translate is error-prone. Also fixed a typo on opac, 'deleteing' To test: 1) Search for 'An error occurred when updating this list' on your preferred language translation file for staff or opac (xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po) You will see a 'big' string to translate 2) Apply the patch 3) Update translation files for your language 4) Search again, big one is gone and there are new individual strings to translate. Sorry for not spotting this before string freeze Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:57:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:57:45 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 15:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 14:58:06 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 --- Comment #4 from Kyle M Hall --- Created attachment 44962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44962&action=edit [SIGNED-OFF] Bug 15208: Followup to reorder words It think it's better to put the shelf name first Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 16:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 15:13:59 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 44963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44963&action=edit Proposed patch routines now return undef rather than aborting if undefined record is passed to them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 16:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 15:22:05 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Alex Arnaud --- (In reply to Marc V?ron from comment #2) > Hi Alex, I like thsi feature. > > I played around with a 10 year old kid. > > Today we have 18/11/2015 > > This are my results: > 18/11/2005 -> Age: 10 year(s) 2 day(s) > 18/11/2005 -> Age: 10 year(s) 1 day(s) > 20/11/2005 -> Age: 10 year(s) > 21/11/2005 -> Age: 9 year(s) 11 month(s) 30 day(s) > 22/11/2005 -> Age: 9 year(s) 11 month(s) 29 day(s) > > There seems to be an offset of some days. Hello Marc, Tanks for testing. Indeed there's a problem and i understand why. Patch is coming soon... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:05:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:05:52 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #31 from H?ctor Eduardo Castro Avalos --- (In reply to Zeno Tajoli from comment #27) > Hi, I found that in reports/guided_reports.pl C4:Dates is still present. > > From lines 359 to 363: > > # If the range values are dates > if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ > C4::Dates->regexp('syspref')) { > $fromvalue = C4::Dates->new($fromvalue)->output("iso"); > $tovalue = C4::Dates->new($tovalue)->output("iso"); > } > > A new bug or you fix here ? A previous attachment in this bug fixed it up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:09:36 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Very nice catch. I had seen this attribute type and had the same idea once (but then I forgot). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:09:47 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:40:18 +0000 Subject: [Koha-bugs] [Bug 9762] way to track overrides In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:48:51 +0000 Subject: [Koha-bugs] [Bug 15210] New: Novelist js throws an error if no ISBN Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Bug ID: 15210 Summary: Novelist js throws an error if no ISBN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If novelist is enabled and a record has no ISBN the js throws an error which subsequently breaks any custom code from opacuserjs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:56:12 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #41 from Marc V?ron --- Created attachment 44964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44964&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 17:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 16:59:25 +0000 Subject: [Koha-bugs] [Bug 15210] Novelist js throws an error if no ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 --- Comment #1 from Nick Clemens --- Created attachment 44965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44965&action=edit Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 18:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 17:13:33 +0000 Subject: [Koha-bugs] [Bug 10102] don't show empty novelist tab if no data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- Tricky with the fact that Novelist is all js and loaded after the page, but adding the below to OPACUserJS seems to accomplish it. Something cleaner would be nice but this works as a quick fix: $(window).load(function(){ if( !$('#NovelistSelect').find('img').length ){ $("a[href=#NovelistSelect]").remove(); $("#NovelistSelect").remove(); } }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 18:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 17:27:27 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44964|0 |1 is obsolete| | --- Comment #42 from Marc V?ron --- Created attachment 44966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44966&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 18:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 17:39:08 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 18:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 17:40:27 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Jenny Dallas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |limbozel at gmail.com --- Comment #96 from Jenny Dallas --- I love it! Excellent article. I need help with this too! If you ever need to fill out a form, here is or www.tax.ny.gov a really useful tool. Very easy to navigate and use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 18:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 17:50:17 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #2 from Jesse Weaver --- Steps to reproduce: 1) Log in at library "A". 2) Create a patron attribute type that is limited to only library "A". 3) Edit a patron, and add data for that attribute type. 4) Log in at library "B". 5) Edit the same patron. The attribute should, of course, not be visible. Save. 6) Log in at library "A". 7) Edit the same patron. The attribute data has disappeared. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 19:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 18:52:54 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #14 from Kyle M Hall --- > I agree about consistency, but from the other direction: namely, Bootstrap > modals are only used in a couple places currently, but if folks generally > think that they're a good direction to go in, then circulation is a good > place to get started with adding more use of them: it's faster for a circ > operator to dismiss a modal than to wait for a round-trip to the server with > the current approach for dealing with blocking alerts during circ operations. I concur! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 19:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 18:54:26 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 19:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 18:54:29 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23511|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 44967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44967&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 21:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 20:04:21 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #3 from Heather Braum --- Jonathan, Jesse's description is the behavior that I have seen also happen on my system. Additionally, I have seen this same behavior happen with patron categories that are limited to only certain branches (and maybe this needs to be a separate bug), but it seems to be the same type of problematic behavior: 1. Login at Library A. 2. Set a patron category to be visible to only Library A. 3. Edit a patron and change the patron category to one that is only visible to Library A. 4. Login at Library B. 5. Edit the same patron, and note that the patron category is now the first one on the list, not the one set in step 3. 6. Login at Library A. 7. Edit the same patron again; note that the patron category is not set to what was set in step 3. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:33:51 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:33:54 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44961|0 |1 is obsolete| | Attachment #44962|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 44968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44968&action=edit Bug 15208: Ease translation for shelves messages This string patch only puts ... around shelves messages. It split a monster translation string into its components. This kind of string to translate is error-prone. Also fixed a typo on opac, 'deleteing' To test: 1) Search for 'An error occurred when updating this list' on your preferred language translation file for staff or opac (xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po) You will see a 'big' string to translate 2) Apply the patch 3) Update translation files for your language 4) Search again, big one is gone and there are new individual strings to translate. Sorry for not spotting this before string freeze Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:34:16 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 --- Comment #6 from Katrin Fischer --- Created attachment 44969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44969&action=edit [PASSED QA] Bug 15208: Followup to reorder words It think it's better to put the shelf name first Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:46:20 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hm, wondering: 1) The changes for the library type don't match up: societyAssoc: "society or association" vs societyAssociation 2) How can we handle installations that already have the preference set up, but the setting doesn't match one of the provided countries? 3) Please correct bug title and commit message - UsageStatsLibraryType already is a pull down on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:49:53 +0000 Subject: [Koha-bugs] [Bug 15203] select all -> add to list from a result page in the OPAC gives you double ups in your list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15203 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Liz Rea --- I'm so sorry, this was my data. >.< -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 22:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 21:59:55 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- Created attachment 44970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44970&action=edit Warnings after patch Got rid of second error, but just pushed the first down a few lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:00:08 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:03:03 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- I am sorry, but this isn't working for me. I checked that no 942$n != "" existed in my database. I did a full reindex (-b -v -r). I checked that "de" returned results on master, then turned on OpacSuppression. As expected, the search did not return any results after. Applied patch. Search is still not returning any results. What could be wrong? something I can check? Running my git installation in Ubuntu 14.04 LTS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:05:35 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Katrin Fischer --- ... ok, I know what happened... ccl.properties... gah. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:10:48 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #34 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #23) > Tom?s, you have marked this bug as a duplicate of bug 9351 but you don't > take care of the CanBookBeIssued subroutine. > Do you plan to update it as well? When I wrote this patches I wasn't aware of bug 9351. That bug lacked tests, and I considered my approach a better one. This patches don't cover the "localuse" use case, but they fix a bug, and have regression tests. Someone could write a followup, but I didn't find the time to do it myself. Maybe the mistake was to mark the original as duplicate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:21:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:21:43 +0000 Subject: [Koha-bugs] [Bug 15211] New: Label/patron card creators need to have Tools sidebar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Bug ID: 15211 Summary: Label/patron card creators need to have Tools sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org As tools, it would be nice to have the tools sidebar on these pages. Especially since there is currently nothing there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:36:45 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #14 from David Cook --- (In reply to Katrin Fischer from comment #13) > ... ok, I know what happened... ccl.properties... gah. It'll get you every time. Testing Zebra changes are a bit of a pain... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:42:00 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:42:03 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44901|0 |1 is obsolete| | Attachment #44911|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 44971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44971&action=edit [PASSED QA] Bug 15198: Make OpacSuppression work even if there are no records suppressed This patch adds the Zebra special attribute 14 to ccl.properties and opac-search.pl, so that we can turn on OpacSuppression and still return results even if there are no records in Zebra for the Suppress index. _TEST PLAN_ Before applying: 1) Make sure that you have no suppressed records indexed in Zebra 2) Turn on OpacSuppression system preference 3) Search using a keyword which should bring up records 4) Note that no records are returned in the results 5) Change UseQueryParser system preference to "Try" 6) Repeat steps 3-4 Apply the patch. After applying: 7) Repeat step 3 (ie search using a keyword which should bring up records) 8) Confirm that records are appearing in the results! 9) Change UseQueryParser system preference to "Do not try" 10) Repeat step 3 11) Confirm that records are appearing in the results! Signed-off-by: Hector Castro Works as advertised. No more, won't need to have at least one record with the value "1" in the field mapped with this index. All records in OPAC returned. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:42:16 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #16 from Katrin Fischer --- Created attachment 44972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44972&action=edit [PASSED QA] Bug 15198: Change wording of OpacSuppression system preference Signed-off-by: Hector Castro Paragraph rewording successfully Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:51:21 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Kyle, can you please add a regression test for this scenario? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 18 23:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 22:58:19 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- The two patches conflict, and Mark's question could use an answer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 00:11:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 23:11:23 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #16 from Nick Clemens --- So, I don't have a barcode scanner at my desk, but if I simulate just typing in a barcode and pressing enter while the modal is up I can still just check in the next item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 00:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 23:16:13 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Nick Clemens --- Small conflict in the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 00:49:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 23:49:13 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #7 from M. Tompsett --- Comment on attachment 44960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44960 patch for fix update Review of attachment 44960: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15207&attachment=44960) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +10816,5 @@ > + add CONSTRAINT course_reserves_ibfk_2 > + FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) > + ON DELETE CASCADE ON UPDATE CASCADE > + }); > + }; What if someone created it incorrectly? Why not leave the do logic as it was, but insert a delete foreign key if the count>0? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 00:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Nov 2015 23:51:24 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #16 from M. Tompsett --- (In reply to Jonathan Druart from comment #14) > Everything looks fine, but the import tool is still broken (no progress bar). Don't ask me to duplicate it, but I have had instances where the javascript didn't trigger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 01:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 00:05:49 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 01:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 00:07:53 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Mason James --- (In reply to Nick Clemens from comment #5) > The two patches conflict, I have marked my patch obsolete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 02:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 01:31:28 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 02:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 01:31:31 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 --- Comment #1 from Liz Rea --- Created attachment 44973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44973&action=edit Bug 15211 - adding Tools section sidebar to label creator The label creator had a very sad sidebar, it needed to have the Tools area sidebar on it. To test: Click through all "New" pages, verify that the sidebar appears Click through all "Manage" pages, verify that the sidebar appears. Also verify that "Label creator" is bolded in the toolbar while the label creator is active. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 02:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 01:45:25 +0000 Subject: [Koha-bugs] [Bug 15212] New: Patron lists tool page needs Tools area sidebar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 Bug ID: 15212 Summary: Patron lists tool page needs Tools area sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The patron lists tool doesn't have a "tools" area sidebar. We should add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:16:30 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 --- Comment #2 from Liz Rea --- Created attachment 44974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44974&action=edit Bug 15211 - Patron card creator needs tools sidebar The patron card creator should have the Tools area sidebar on its pages. This patch adds it. To test: Go to More -> Tools -> Patron card creator The home page should have the tools sidebar Click through all of the "New" pages - they should all have the tools sidebar Click through all of the "Manage" pages - they should all have the tools sidebar Also verify that on each page, the Patron card creator link in the sidebar is bolded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:17:24 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 --- Comment #3 from Liz Rea --- Note that the 2nd patch depends on the first one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:40:03 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky at gmail.com --- Comment #7 from Winona Salesky --- Sorry for the lack of communication. We actually submitted the patches at nearly the same time. The only difference is my patch uses the named template subfieldSelectSubject not subfieldSelect. The subfieldSelectSubject template was developed to address issues with parentheses in subject searches. The subfieldSelectSubject template strips parentheses from the search string. RE: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Hope that helps clarify. -Winona (In reply to Mason James from comment #6) > (In reply to Nick Clemens from comment #5) > > The two patches conflict, > > I have marked my patch obsolete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:55:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:55:08 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44973|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 44975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44975&action=edit [SIGNED-OFF]Bug 15211: adding Tools section sidebar to label creator The label creator had a very sad sidebar, it needed to have the Tools area sidebar on it. To test: Click through all "New" pages, verify that the sidebar appears Click through all "Manage" pages, verify that the sidebar appears. Also verify that "Label creator" is bolded in the toolbar while the label creator is active. Signed-off-by: Hector Castro Sidebar displayed Ok. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:55:23 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44974|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 44976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44976&action=edit [SIGNED-OFF]Bug 15211: Patron card creator needs tools sidebar The patron card creator should have the Tools area sidebar on its pages. This patch adds it. To test: Go to More -> Tools -> Patron card creator The home page should have the tools sidebar Click through all of the "New" pages - they should all have the tools sidebar Click through all of the "Manage" pages - they should all have the tools sidebar Also verify that on each page, the Patron card creator link in the sidebar is bolded Signed-off-by: Hector Castro Sidebar displayed Ok. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:55:52 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 03:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 02:59:39 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hector.hecaxmmx at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 04:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 03:26:24 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43767|0 |1 is obsolete| | --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 44977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44977&action=edit [SIGNED-OFF]Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro Works as advertised. 655 field clickable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 04:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 03:26:55 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 04:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 03:37:28 +0000 Subject: [Koha-bugs] [Bug 15213] New: Fix tools sidebar to highlight Patron lists when in that module Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Bug ID: 15213 Summary: Fix tools sidebar to highlight Patron lists when in that module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Patron lists has some subpages within it, so special handling is needed for bolding the sidebar when that tool is the active one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 08:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 07:45:45 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #43 from paxed --- I think all that repeated if (dateformat == "us") blah elseif (dateformat == "metric") blah elseif (dateformat == ... code in multiple places is fragile and errorprone, and therefore should be replaced with perl code that gets the date format string to the templating system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 09:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 08:12:28 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #8 from Zeno Tajoli --- (In reply to Nick Clemens from comment #6) > Created attachment 44970 [details] > Warnings after patch > > Got rid of second error, but just pushed the first down a few lines Nick, can you try to understand why in your set up those instructions: my $count_course_reserves_ibfk_2 = $dbh->selectrow_arrayref(q| + SELECT COUNT(*) + FROM information_schema.table_constraints + WHERE table_schema = schema() + AND table_name = 'course_reserves' + AND CONSTRAINT_NAME = 'course_reserves_ibfk_2' + |); did not retreive the presence of FK "course_reserves_ibfk_2" ? Because I don't have idea how to repoduce your situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 09:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 08:43:03 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44953|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud --- Created attachment 44978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44978&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create a new patron (members/memberentry.pl), enter a date of birth, patron'a age should be shown under -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 09:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 08:47:17 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Alex Arnaud --- I removed the number of days because it's quite imprecise since months haven't the same number of days. If anyone can do better or knows a javascript library that can do it with more accurate feel free to tell me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 09:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 08:51:25 +0000 Subject: [Koha-bugs] [Bug 15214] New: bulkmarcimport should log if an authority has been updated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214 Bug ID: 15214 Summary: bulkmarcimport should log if an authority has been updated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When importing with bulkmarcimport, authorities may or may not be updated based on which authority is newer (005 are compared). It could be useful to keep track of which authority has been updated or not in the result yaml file. This patch does that. Test plan: 1) Import an authority file with -yaml. The resulting yaml file looks like this: --- 027226794: authid: 41759 subfields: - France 02722709X: authid: 44782 subfields: - Femmes - Travail [...] 2) Apply the patch. 3) Import an authority file with -yaml. The resulting yaml file should look like this: --- 027226794: authid: 41759 subfields: - France updated: 1 02722709X: authid: 44782 subfields: - Femmes - Travail updated: 0 [...] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 09:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 08:58:13 +0000 Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority has been updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214 --- Comment #1 from Matthias Meusburger --- Created attachment 44979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44979&action=edit Bug 15214: bulkmarcimport should log if an authority has been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 10:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 09:32:09 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44966|0 |1 is obsolete| | --- Comment #44 from Marc V?ron --- Created attachment 44980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44980&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 10:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 09:40:17 +0000 Subject: [Koha-bugs] [Bug 15022] Add support for holds to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15022 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:07:54 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- I think there is a room for improvement here - I'd think to be really clear a positive messsage "checked out" and a negative message "not checked out" would really make things easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:11:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:11:26 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #22 from Katrin Fischer --- I will pass this as a partial improvement - please keep the patches coming (on new bugs of course :)) ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:11:51 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #23 from Katrin Fischer --- Created attachment 44981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44981&action=edit [PASSED QA] Bug 15091: Batch Checkout: Set titles above result tables This patch is to clarify the results that are displayed while performing a batch checkout. It is not the full solution for what is described in the video in comment #2, but it tells the user what the information in the table is about. A second patch is planned to address the case where the issues are confirmed but not can be fulfilled because the user's fines reach the threshold while checking out the items. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:11:54 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #24 from Katrin Fischer --- Created attachment 44982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44982&action=edit [PASSED QA] Bug 15091: Do not allow to use batch checkout if checkout is not allowed If the noissue param is passed to the template, the batch checkout should not be allowed. This patch globally fixes the problem raised by bug 15091. A generic message "cannot check out" is displayed and some more specific ones could be added later. For now it only trigger the "fine balance is over the limit" message. Test plan: Confirm there is no regression on the original behavior and that the issue raised on bug 15091 is fixed. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:11:58 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #25 from Katrin Fischer --- Created attachment 44983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44983&action=edit [PASSED QA] Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:13:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:13:11 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:13:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:13:13 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:13:15 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:13:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:13:18 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:21:30 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:21:33 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44977|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 44984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44984&action=edit [PASSED QA] Bug 15047: 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. Signed-off-by: Hector Castro Works as advertised. 655 field clickable Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:43:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:43:10 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #14 from Katrin Fischer --- Created attachment 44985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44985&action=edit [PASSED QA] Bug 14889: Add Koha::BiblioFramework[s] classes Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:43:14 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #15 from Katrin Fischer --- Created attachment 44986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44986&action=edit [PASSED QA] Bug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl Test plan: Add/edit/remove biblio frameworks from the administration module (admin/biblio_framework.pl). You should get message feedback after each action. Signed-off-by: Bernardo Gonzalez Kriegel No problems found. Tested add/edit/delete No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:43:17 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #16 from Katrin Fischer --- Created attachment 44987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44987&action=edit [PASSED QA] Bug 14889: QA Follow-up - Removes unused package from BiblioFramework.pm - Makes framework table sortable - Some small changes in wording of error messages Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:43:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:43:20 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #17 from Katrin Fischer --- Created attachment 44988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44988&action=edit [PASSED QA] Bug 14889: Fix error msg on duplicate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:43:24 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #18 from Katrin Fischer --- Created attachment 44989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44989&action=edit [PASSED QA] Bug 14889: Add tests for Koha::BiblioFramework[s] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:15 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:18 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:20 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:22 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:24 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 11:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 10:44:26 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 12:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 11:15:39 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Laurence Lefaucheur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.lefaucheur at biblibr | |e.com --- Comment #4 from Laurence Lefaucheur --- Tested OK on biblibre sandbox following test plan (french translation) : the csv first line only contains the headers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 12:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 11:37:34 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 12:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 11:40:25 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 12:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 11:40:27 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44948|0 |1 is obsolete| | Attachment #44949|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 44990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44990&action=edit [PASSED QA] Bug 14101: Automatic renewals exactly on due date If no value for 'no renewal before' is specified, automatic renewal now falls back on the due date. Also 'no renewal before' can now be zero, so both automatic and manual renewals can be delayed until due date. Test plan: 1) Create some circulation rules with different settings for 'No renewal before' and 'Automatic renewal'. Both daily and hourly loans should work. 2) Try to renew both manually and automatically before and after a renewal should be possible. You can run misc/cronjobs/automatic_renewals.pl for automatic renewal. 3) Confirm that: * Both automatic and manual renewal with 'No renewal before' set to 0 do not happen before the due date (exact DateTime). * Manual renewal with 'No renewal before' set to undef (enter empty string) is unrestricted. * Automatic renewal with 'No renewal before' set to undef does not happen before the due date. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 12:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 11:40:35 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #32 from Kyle M Hall --- Created attachment 44991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44991&action=edit [PASSED QA] Bug 14101: Unit tests This patch adds new test cases to check if CanBookBeRenewed provides correct return values and error codes for premature renewals. Both manual and automatic renewals and different settings for 'No renewal before' are tested. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:00:59 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #9 from Nick Clemens --- Sure, my test plan on kohadevbox: 1 - Checkout 3.20.x 2 - drop db, create db, 3 - run web installer (upgrade) 4 - checkout master 5 - run webinstaller 6 - got errors described 7 - checkout 3.20.x 8 - drop db, create db 9 - run web installer 10- - checkout master 11 - apply patch 12 - run websintaller (upgrade) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:04:40 +0000 Subject: [Koha-bugs] [Bug 15215] New: Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bug ID: 15215 Summary: Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Compiling C4/SIP/Sip/MsgType.pm generates the warning UNIVERSAL->import is deprecated and will be removed in a future perl in perl 5.22 this is now a fatal error causing compilation to abort with the message 'UNIVERSAL does not export anything'. (And e.g. crashing Koha's test suite fairly early on) replace invalid call to UNIVERSAL with a use UNIVERSAL::can to avoid this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:27:28 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 44992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44992&action=edit Proposed patch Easy to test Without patch compiling MsgType.pm (perl -wc C4/SIP/Sip/MsgType.pm) will give a depreciation warning about calling UNIVERSAL's methods or with perl 5.22 will abort compilation with message that UNIVERSAL does not export any methods With patch applied module should compile without the warning/error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:30:21 +0000 Subject: [Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import breaks in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plack testing -- Stage MARC |(Plack) Stage MARC records |records for import -- |for import breaks in Plack |Internal Server | |Error/Stalled Staged Import | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:45:32 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44202|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 44993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44993&action=edit Bug 15062 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:45:39 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 --- Comment #5 from Kyle M Hall --- Created attachment 44994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44994&action=edit Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:45:48 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:46:44 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:55:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:55:05 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 --- Comment #6 from Kyle M Hall --- Created attachment 44995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44995&action=edit Bug 15062 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:55:12 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44994|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 44996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44996&action=edit Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 13:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 12:58:15 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #10 from Zeno Tajoli --- Nick, can you tell us your version of MySQL ? Or do you use MariaBD ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:29:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:29:47 +0000 Subject: [Koha-bugs] [Bug 15216] New: Display Branch names and itemtype descriptions on the returns page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Bug ID: 15216 Summary: Display Branch names and itemtype descriptions on the returns page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When returning an item, the itemtype and branchcodes for current and holding are displayed as codes instead of the descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:51:46 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:52:04 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:53:28 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #32 from Katrin Fischer --- Created attachment 44997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44997&action=edit [SIGNED OFF] remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:05 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44997|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 44998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44998&action=edit [SIGNED OFF] remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:09 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #34 from Katrin Fischer --- Created attachment 44999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44999&action=edit [SIGNED OFF] Bug 14870 - Remove t/Dates.t from Koha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:12 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #35 from Katrin Fischer --- Created attachment 45000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45000&action=edit [SIGNED OFF] Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:16 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #36 from Katrin Fischer --- Created attachment 45001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45001&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:20 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #37 from Katrin Fischer --- Created attachment 45002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45002&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:23 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #38 from Katrin Fischer --- Created attachment 45003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45003&action=edit [SIGNED OFF] Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:27 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #39 from Katrin Fischer --- Created attachment 45004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45004&action=edit [SIGNED OFF] Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer serials/acqui-search-results.pl looks like it should be revisited, containing code that might not be needed. Searching a vendor in serials still works witout a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:30 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #40 from Katrin Fischer --- Created attachment 45005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45005&action=edit [PASSED QA] Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:54:34 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #41 from Katrin Fischer --- Created attachment 45006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45006&action=edit Bug 14870: QA follow-up - fixing tiny typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:21 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:24 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:26 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:29 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:32 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:35 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:38 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:43 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 14:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 13:55:41 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:01:45 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #42 from Martin Renvoize --- Created attachment 45007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45007&action=edit Bug 14870: Remove C4/Dates.pm from Koha http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:01:48 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #43 from Martin Renvoize --- Created attachment 45008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45008&action=edit Bug 14870: Remove t/Dates.t from Koha Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:01:52 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #44 from Martin Renvoize --- Created attachment 45009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45009&action=edit Bug 14870: Remove C4::Dates from plack.psgi and koha.psgi Remove C4::Dates from .psgi files from preloaded modules, placing Koha::DateUtils instead http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:01:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:01:56 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #45 from Martin Renvoize --- Created attachment 45010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45010&action=edit Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl This patch removes 1 remaining / stray occurence of C4::Dates from circ/returns.pl To test: - Apply patch - Go to Home > Circulation > Check in - Verfiy that check-ins with overriding return dates work as before. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:01:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:01:59 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #46 from Martin Renvoize --- Created attachment 45011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45011&action=edit Bug 14870: (followup) Remove stray C4::Dates from reports files This patch removes stray C4::Dates from following files: reports/borrowers_stats.pl To test: Verify that C4::Dates is not used in the file reports/guided_reports.pl: To test: - Run a saved report with date input and with date range input, e.g. - Verify that you are asked for date range or date and that the results are the same as without patch Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:02 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #47 from Martin Renvoize --- Created attachment 45012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45012&action=edit Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:06 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #48 from Martin Renvoize --- Created attachment 45013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45013&action=edit Bug 14870: (followup) Remove stray C4::Dates (See comment #23) This patch removes stray C4::Dates (date_fromat...) from C4/Items.pm C4/Log.pm C4/Serials.pm serials/acqui-search-result.pl t/DateUtils.t t/db_dependent/Items/GetItemsForInventory.t tools/koha-news.pl Some of them were inside comments etc. To test: - git grep 'C4::Dates' should give no result - git grep 'format_d' should give no result Exception: in one cron job there exists an own sub format_date, and occurences not related to C4::Dates - Search for regressions http://bugs.koha-community.org/show_bug.cgi?id=14870 Signed-off-by: Katrin Fischer serials/acqui-search-results.pl looks like it should be revisited, containing code that might not be needed. Searching a vendor in serials still works witout a problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:13 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45006|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 45015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45015&action=edit Bug 14870: QA follow-up - fixing tiny typo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:09 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #49 from Martin Renvoize --- Created attachment 45014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45014&action=edit Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl To test: - Apply patch - Check code for uses of C4::Dates (date_format) Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:48 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #44998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:02:56 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:04 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:13 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:21 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:29 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:38 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:03:46 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:04:06 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45007|Bug 14870: Remove |[PASSED QA] Bug 14870: description|C4/Dates.pm from Koha |Remove C4/Dates.pm from | |Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:04:20 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45008|Bug 14870: Remove t/Dates.t |[PASSED QA] Bug 14870: description|from Koha |Remove t/Dates.t from Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:04:34 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45009|Bug 14870: Remove C4::Dates |[PASSED QA] Bug 14870: description|from plack.psgi and |Remove C4::Dates from |koha.psgi |plack.psgi and koha.psgi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:04:50 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45010|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates from |(followup) Remove stray |circ/returns.pl |C4::Dates from | |circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:05:04 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45011|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates from |(followup) Remove stray |reports files |C4::Dates from reports | |files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:05:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:05:18 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45012|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove mention of C4::Dates |(followup) Remove mention |from C4/Debug.pm |of C4::Dates from | |C4/Debug.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:05:34 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45013|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove stray C4::Dates |(followup) Remove stray | |C4::Dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:05:49 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45014|Bug 14870: (followup) |[PASSED QA] Bug 14870: description|Remove superfluous |(followup) Remove |C4::Dates from |superfluous C4::Dates from |fix_accountlines_rmdupfines |fix_accountlines_rmdupfines |_bug8253.pl |_bug8253.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:06:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:06:04 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45015|Bug 14870: QA follow-up - |[PASSED QA] Bug 14870: QA description|fixing tiny typo |follow-up - fixing tiny | |typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:07:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:07:05 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #51 from Martin Renvoize --- In the words of cait: Die C4::Dates, die! Code all checks out, tests all pass and my testing also showed nothing untoward.. passing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:16:02 +0000 Subject: [Koha-bugs] [Bug 15217] New: variables declared twice in in catalogue/search.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Bug ID: 15217 Summary: variables declared twice in in catalogue/search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org template borrowernumber and cookie are declared before use then declared again on first usage creating 3 unused variables that are almost immediately hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:22:38 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 45016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45016&action=edit Proposed Patch Simple test: applying the patch removes the compile-time warnings displayed on perl -wc catalogue/search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 15:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 14:36:11 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45016|0 |1 is obsolete| | --- Comment #2 from Colin Campbell --- Created attachment 45017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45017&action=edit Amended patch Added removal of declarations of two unused variables to patch to aid in decluttering the source -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:08:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:08:50 +0000 Subject: [Koha-bugs] [Bug 15218] New: (Plack) background-job-process.pl should be run in CGI mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Bug ID: 15218 Summary: (Plack) background-job-process.pl should be run in CGI mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org On starman, the background-job-process.pl script dies as shown in bug 15032. For the 3.22 release (due in a week) we should make it run in CGI mode, until we fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:10:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:10:08 +0000 Subject: [Koha-bugs] [Bug 15219] New: Load checkouts table incrementally Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Bug ID: 15219 Summary: Load checkouts table incrementally Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. Following patches will prevent that by loading checkouts in the table by batches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:11:22 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #1 from Julian Maurice --- Created attachment 45018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45018&action=edit Bug 15219: Load checkouts table incrementally Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by loading checkouts in the table by batches of 100. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds a global filter text input on all tables - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:11:52 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:13:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:13:24 +0000 Subject: [Koha-bugs] [Bug 15218] (Plack) background-job-process.pl should be run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 45019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45019&action=edit Bug 15218: (Plack) background-job-process.pl should be run in CGI mode This patch adds an entry to the plack-related apache configuration so the tools/background-job-process.pl is run in CGI mode. To test: - Follow the setup steps from bug 15032 - Add the line from this patch to /etc/koha/apache-shared-intranet-plack.conf (if you are on kohadevbox you should probably change the filesystem path to /home/vagrant/kohaclone/tools/background-job-process.pl) - Do the full import process of MARC data. => SUCCESS: It works as expected. - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:13:20 +0000 Subject: [Koha-bugs] [Bug 15218] (Plack) background-job-process.pl should be run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:16:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:16:24 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:16:28 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44747|0 |1 is obsolete| | Attachment #44980|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 45020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45020&action=edit [PASSED QA] Bug 12072 - Add system preference for New dateformat dd.mm.yyyy (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected Amended to apply on top of Bug 15166 11.11.2015/mv Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:20:40 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Nick Clemens --- To be more clear: Failing QA because the input box is still selected and active while the modal is up. Typing a barcode and pressing enter (i.e. scanning the next book) will check in the next item without taking any action on the hold which is the same behavior as before patch. The modal does look very nice though and buttons seem to work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:23:41 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44960|0 |1 is obsolete| | --- Comment #11 from Zeno Tajoli --- Created attachment 45021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45021&action=edit New version of patch for fix update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:23:49 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #46 from Katrin Fischer --- Created attachment 45022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45022&action=edit [PASSED QA] Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:23:56 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:25:25 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #12 from Nick Clemens --- On Debian Jessie: mysql Ver 14.14 Distrib 5.5.46, for debian-linux-gnu (x86_64) using readline 6.3 Perl 5.020002 Server version: Apache/2.4.10 (Debian) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:28:16 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #13 from Zeno Tajoli --- Exactly my enviroment (Debian, MySQL and Apache versions). Try the new version !! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:28:59 +0000 Subject: [Koha-bugs] [Bug 15220] New: typo in circ rules help Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Bug ID: 15220 Summary: typo in circ rules help Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In the circulation and fine rules help file there is a typo: MaxFinesystem should be MaxFine system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:32:14 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:32:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:32:16 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 --- Comment #1 from Nicole C. Engard --- Created attachment 45023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45023&action=edit Bug 15220: Fix typo in circ rules help MaxFinesystem should be MaxFine system To test: * visit circ & fine rules * click help * confirm typo fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:32:54 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Nicole C. Engard --- This is in master, 3.20, and 3.18.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:33:02 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:48:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:48:43 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45023|0 |1 is obsolete| | CC| |misilot at fit.edu --- Comment #3 from Tom Misilo --- Created attachment 45024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45024&action=edit Sign off of Bug 15220 Sign off on patch, works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:49:14 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45024|0 |1 is obsolete| | --- Comment #4 from Tom Misilo --- Created attachment 45025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45025&action=edit Bug 15220: Fix typo in circ rules help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 16:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 15:49:24 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 17:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 16:30:50 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45025|0 |1 is obsolete| | --- Comment #5 from Tom Misilo --- Created attachment 45026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45026&action=edit Bug 15220: Fix typo in circ rules help Added the Sign Off part to the subject per the guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 17:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 16:31:31 +0000 Subject: [Koha-bugs] [Bug 15221] New: SIP server always sets the alert flag Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Bug ID: 15221 Summary: SIP server always sets the alert flag Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Here is a checkin with the item checked out to a patron SEND: 09N20151015 07240220151015 072402APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072402AOCPL|AB0140620125|AQMY|AJWuthering heights /|AA23529000035676|CSPZ3.B7902 W36|CV04| Here is a checkin of the same item without it being checked out: SEND: 09N20151015 07222220151015 072222APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072222AOCPL|AB0140620125|AQMY|AJWuthering heights /|CSPZ3.B7902 W36|CV04| Here is the same checkin with a checkout on master: SEND: 09N20151015 07271820151015 072718APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072719AOCPL|AB0140620125|AQMY|AJWuthering heights /|AA23529000035676|CSPZ3.B7902 W36|CV04| And on master without a checkout: SEND: 09N20151015 07280320151015 072803APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 100YNY20151015 072803AOCPL|AB0140620125|AQMY|AJWuthering heights /|CSPZ3.B7902 W36|CV04|AFItem not checked out| So it appears that Koha always sets the alert flag no matter what! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 17:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 16:31:59 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15221 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 [Bug 15221] SIP server always sets the alert flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 17:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 16:31:59 +0000 Subject: [Koha-bugs] [Bug 15221] SIP server always sets the alert flag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13411 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 20:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 19:18:33 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 20:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 19:42:34 +0000 Subject: [Koha-bugs] [Bug 15222] New: Add to cart option/other list options missing from OPAC lists display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15222 Bug ID: 15222 Summary: Add to cart option/other list options missing from OPAC lists display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you view a list in the OPAC, you do not have an option to select item(s) and add to cart or another existing list. The staff side list area has both options. To recreate: 1) Go to Staff side of Koha 2) Create a list 3) View list 4) Note that the options to Add to Cart/other lists is available. 5) Go to OPAC 6) View list previously created 7) Note that the options to Add to Cart/other lists is not available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 20:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 19:50:14 +0000 Subject: [Koha-bugs] [Bug 15222] Add to cart option/other list options missing from OPAC lists display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15222 --- Comment #1 from Heather Braum --- And I'll clarify -- these options appear under individual items in the OPAC list view, but not at the type, so you can add multiple items at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:14:42 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:14:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:14:45 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43590|0 |1 is obsolete| | --- Comment #38 from Brendan Gallagher --- Created attachment 45027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45027&action=edit [SIGNED-OFF] Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth Signed-off-by: Brendan A Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:15:08 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43591|0 |1 is obsolete| | --- Comment #39 from Brendan Gallagher --- Created attachment 45028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45028&action=edit [SIGNED-OFF] Bug 13411 [QA Followup] - Add logging Signed-off-by: Brendan A Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:16:58 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:17:01 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45021|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 45029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45029&action=edit [SIGNED-OFF] Bug 15207: To not show errors on update from 3.20.x to 3.22.x Two update of db, 3.21.00.027 and 3.21.00.022, are partialy done also on 3.20.x. This patch modify updatedatabase.pl to cover those partial changes in db done in 3.20.x To test: 1)Install a 3.20.4 or more 2)Dump the db 2)Update to master and see the error 3)Installe the patch 4)Reload the db 5)Update to master and see no more error 6)Check the coerence at sql structure level More check: a)Reload the db b)Change db to delete the effect of those two commit in 3.20: bug 14205: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c158f9e27e9e283523a5070ae4e4c718627374d2 bug 14298: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e0c926e0104e3fb73d80d8bea07ea8b6f90807b3 c)Redone update d)With patch no errors http://bugs.koha-community.org/show_bug.cgi?id=15207 Signed-off-by: Bernardo Gonzalez Kriegel Update now Ok finish with 'Everything went OK, update done.' No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:48:06 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15211, 15212 --- Comment #1 from Liz Rea --- Depends on 15211 and 15212 because both of them bring this issue forward. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 [Bug 15211] Label/patron card creators need to have Tools sidebar http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 [Bug 15212] Patron lists tool page needs Tools area sidebar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:48:06 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15213 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 21:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 20:48:06 +0000 Subject: [Koha-bugs] [Bug 15212] Patron lists tool page needs Tools area sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15213 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 19 22:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 21:15:33 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #35 from Brendan Gallagher --- Created attachment 45030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45030&action=edit Bug 14598 - QA Followup touching CanBookBeIssued subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:17:43 +0000 Subject: [Koha-bugs] [Bug 15208] Ease translation for shelves messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:18:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:18:12 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #52 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Hector and Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:18:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:18:58 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #47 from Tom?s Cohen Arazi --- Enhancement pushed to master. Well done, Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:25:02 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #40 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:25:30 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:25:59 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 00:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Nov 2015 23:26:30 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #31 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Mark! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:22:12 +0000 Subject: [Koha-bugs] [Bug 15223] New: Buttons on patron list main page funny after font awesome Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Bug ID: 15223 Summary: Buttons on patron list main page funny after font awesome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The table doesn't stretch for the new icons for whatever reason. We should make it look nice again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:24:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:24:52 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:24:55 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 --- Comment #2 from Liz Rea --- Created attachment 45031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031&action=edit Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:29:56 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 --- Comment #1 from Liz Rea --- See patch for 15213 for fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:30:46 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15223 --- Comment #3 from Liz Rea --- This patch will also fix bug 15223. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 [Bug 15223] Buttons on patron list main page funny after font awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:30:46 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15213 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:32:12 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #45030|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer --- Comment on attachment 45030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45030 Bug 14598 - QA Followup touching CanBookBeIssued subroutine I think this is not quite right yet considering item-level_itypes. I have another solution that I think is correct... but while the tests in Koha look great I totally fail on writing patches that pass :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:32:52 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 45032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45032&action=edit Bug 15207: (followup) add collate info to sound alerts table Only missing bit is some collate info in sound alerts table. To test: 1) With previous patch applied, do an upgrade (3.20 -> 3.22) 2) Dump database structure (mysqldump -d) save 3) Do a clean install (3.22), dump db structure, compare (diff) Note collate info missing in sound alerts table 4) With patch applied do again an upgrade, dump db struct, compare again Now sound alerts table have collate info Don't know if this is relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:42:28 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Comment on attachment 45031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031 Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module Actually I don't want 15223 included in this patch, in case this one doesn't get in, so I'll send a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 02:45:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 01:45:21 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 --- Comment #5 from Liz Rea --- Created attachment 45033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45033&action=edit Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 03:09:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 02:09:46 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 03:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 02:09:49 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 --- Comment #2 from Liz Rea --- Created attachment 45034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45034&action=edit Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 04:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 03:15:29 +0000 Subject: [Koha-bugs] [Bug 15218] (Plack) background-job-process.pl should be run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 04:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 03:15:32 +0000 Subject: [Koha-bugs] [Bug 15218] (Plack) background-job-process.pl should be run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45019|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 45035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45035&action=edit Bug 15218: (Plack) Make processes that rely on background jobs run in CGI mode This patch adds an entry to the plack-related apache configuration so the problematic scripts (that fail under plack/starman) are not processed through Plack but in CGI mode instead. To test: - Follow the setup steps from bug 15032 - Add the line from this patch to /etc/koha/apache-shared-intranet-plack.conf (if you are on kohadevbox you should probably change the filesystem path to /home/vagrant/kohaclone/tools/background-job-process.pl) - Do the full import process of MARC data. => SUCCESS: It works as expected. - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 04:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 03:27:34 +0000 Subject: [Koha-bugs] [Bug 15218] (Plack) background-job-process.pl should be run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 04:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 03:31:08 +0000 Subject: [Koha-bugs] [Bug 15032] (Plack) Stage MARC records for import breaks in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #17 from Tom?s Cohen Arazi --- Bug 15218 provides a workaround to this bug. Reading the scripts that fork, they look buggy and should probably be rewritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 08:41:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 07:41:06 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Josef Moravec --- There is conflict in t/db_dependent/Serials.t, could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 10:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 09:36:16 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #2 from Julian Maurice --- Created attachment 45036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45036&action=edit Bug 15219: Fix content of "Export" column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 11:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 10:04:53 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #10 from Sophie MEYNIEUX --- Could this one be in 3.18 ? Because it could result in severe loss of data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 12:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 11:50:01 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 12:50:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 11:50:04 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44992|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 45037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45037&action=edit [SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel No more worning/error No qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 13:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 12:22:19 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 13:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 12:22:22 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44967|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 45038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45038&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 13:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 12:23:04 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #19 from Kyle M Hall --- (In reply to Nick Clemens from comment #17) > To be more clear: > > Failing QA because the input box is still selected and active while the > modal is up. > > Typing a barcode and pressing enter (i.e. scanning the next book) will check > in the next item without taking any action on the hold which is the same > behavior as before patch. > > The modal does look very nice though and buttons seem to work as expected Good catch! This new version should take care of that issue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 13:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 12:36:30 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Katrin Fischer --- (In reply to Sophie MEYNIEUX from comment #10) > Could this one be in 3.18 ? Because it could result in severe loss of data. Adding Liz to the CC list :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 13:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 12:47:16 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 45039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45039&action=edit Proposed Patch Testing - without patch an active sip connection will be timed out after timeout seconds without receiving a request from the client. With patch applied connection will remain open until client closed. Time out can be reinstated by adding a client_timeout parameter as per the sample config, the separate name allows this to be defined at a different duration from the login timeout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:19:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:19:43 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #33 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Holger! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:28:32 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:32:39 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:32:42 +0000 Subject: [Koha-bugs] [Bug 15220] typo in circ rules help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45026|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 45040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45040&action=edit [PASSED QA] Bug 15220: Fix typo in circ rules help MaxFinesystem should be MaxFine system To test: * visit circ & fine rules * click help * confirm typo fixed Signed-off-by: Thomas Misilo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:49:09 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:49:12 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44995|0 |1 is obsolete| | Attachment #44996|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 45041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45041&action=edit Bug 15062 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 14:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 13:49:26 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 --- Comment #9 from Katrin Fischer --- Created attachment 45042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45042&action=edit [PASSED QA] Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:00:26 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45037|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 45043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45043&action=edit [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel No more worning/error No qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:00:23 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:13:16 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Plack) |Make processes that rely on |background-job-process.pl |background jobs run in CGI |should be run in CGI mode |mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:13:42 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:13:45 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45035|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 45044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45044&action=edit [PASSED QA] Bug 15218: (Plack) Make processes that rely on background jobs run in CGI mode This patch adds an entry to the plack-related apache configuration so the problematic scripts (that fail under plack/starman) are not processed through Plack but in CGI mode instead. To test: - Follow the setup steps from bug 15032 - Add the line from this patch to /etc/koha/apache-shared-intranet-plack.conf (if you are on kohadevbox you should probably change the filesystem path to /home/vagrant/kohaclone/tools/background-job-process.pl) - Do the full import process of MARC data. => SUCCESS: It works as expected. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:13:54 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 --- Comment #4 from Kyle M Hall --- Created attachment 45045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45045&action=edit [PASSED QA] Bug 15218 [QA Followup] - Fix wording of comment Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:19:55 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:20:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:20:15 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40177|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 45046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45046&action=edit [PASSED QA] Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers. Signed-off-by: Laurence Lefaucheur Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:20:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:20:12 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:20:41 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:24:30 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #37 from Kyle M Hall --- Created attachment 45047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45047&action=edit Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:25:02 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:26:05 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks for the followup, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:31:45 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #42 from Katrin Fischer --- This is a bit of a mixed bag of things - can you please add test plans to the 2nd and 3rd patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:01 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:04 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40968|0 |1 is obsolete| | Attachment #40969|0 |1 is obsolete| | Attachment #40970|0 |1 is obsolete| | Attachment #40971|0 |1 is obsolete| | Attachment #40972|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 45048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45048&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:14 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45048|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 45049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45049&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:18 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #45 from Kyle M Hall --- Created attachment 45050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45050&action=edit Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:21 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #46 from Kyle M Hall --- Created attachment 45051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45051&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:25 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #47 from Kyle M Hall --- Created attachment 45052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45052&action=edit Bug 11700: Add description to unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:43:29 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #48 from Kyle M Hall --- Created attachment 45053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45053&action=edit Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:46:02 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Assignee|philippe.blouin at inlibro.com |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:48:14 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #1 from Eugene Espinoza --- Not only in the first indicator but also in the second indicator, if the system can let the users put default values in the indicators. This can addressed either: 1) In edit field of the MARC Bibliographic framework, there should be another option for the first indicator and second indicator, or 2) In the subfields where a particular subfield affects the indicators (e.g. When 650$2 is filled up, then the indicator should be 7). In no. 2, there should probably be a mechanism of "if and then" much like the MARC modification template we already have in Koha. No. 2 is kind of difficult to implement unlike 1, where you outright assign the indicators. But no. 1 has some problems too, like assigning indicators that are based on the number of characters (e.g. in 245 indicator 2). These are just my thoughts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:48:28 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #3 from Julian Maurice --- Created attachment 45054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45054&action=edit Bug 15219: Fix column settings in table moremember/issues-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:56:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:56:14 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:56:17 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44937|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 45055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45055&action=edit Bug 14895: Removes the ability to edit already added item's info from serials-edit.pl page Test plan: 1. In serials create a new subscription with the option "create an item record when receiving this serial" selected. You can choose the other properties. 2. Find the newly created serial subscription by using the top bar's search. 3. Click from the 'Actions' drop-down menu 'Serial receive'. 4. Change the status to 'Arrived'. Add something to the barcode field. Save. 4.1 (Optional step) Open a new tab in your browser and go see that there is in the catalogue the item you just added and it has a barcode. 5. Now you should have arrived to the page serials-collection.pl. Here, select the very same serial item you just edited and click 'Edit serials' 6. Now click just save button without doing any changes. 7. Go to find that item from the biblio record. Notice its barcode is missing now. 8. Apply the patch 9. Put there some barcode to the item manually. 9. Go back to the serials-collection.pl page and select the item and click 'Edit serials'. 10. Click save on the edit-serials.pl page without changing any information. 11. Go and check that the item has still its barcode. 12. Find out if this patch's changes to edit-serials.pl has caused some problems in other parts of the system. Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 15:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 14:56:24 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 --- Comment #10 from Kyle M Hall --- Created attachment 45056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45056&action=edit Bug 14895 [QA Followup] - Fix indentation for readability Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:00:26 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #12 from Sophie MEYNIEUX --- Sorry I didn't check before, but apparently it is in 3.18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:32:58 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #39 from Katrin Fischer --- I think the discussion is very interesting, but I am a bit worried about the handling of a record from multiple sources. Maybe it would be good to agree on a basic version of the harvester for a first implementation and then enhance it for more complicated scenarios step by step? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:35:59 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Considering bug 15030 is in active development, we should probably wait to see if that one takes care of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:36:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:36:03 +0000 Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:36:45 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:36:49 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 16:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 15:58:08 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #16 from Kyle M Hall --- I would like to see this script die with errors if both the command line switch and the system preference are set. I can see a scenario where a sysadmin changes the value on the switch but it doesn't change the purge days! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:00:43 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:00:45 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44297|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 45057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45057&action=edit Bug 15080 - ./translate tool should tell if xgettext executable is missing Just upgraded our Koha container to 14.04 and noticing the misc/translator/translate doesn't work. This is because of a missing package gettext. This patch makes ./translate die with a helpful suggestion to install gettext if xgettext-program is missing. Signed-off-by: Frederic Demians I can reproduce the bug by desinstalling 'gettext' package on a Debian box. I confirm that without this patch, 'translate' command fails miserably. Suggesting to install gettext package is welcomed. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:04:29 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:04:32 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44143|0 |1 is obsolete| | Attachment #44144|0 |1 is obsolete| | Attachment #44145|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 45058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45058&action=edit Bug 14695 - Tidy CanItemBeReserved and CanBookBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:04:41 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #5 from Kyle M Hall --- Created attachment 45059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45059&action=edit Bug 14695 - Add new issuing rule This patch fines a new issuing rule 'holds_per_record' which defines the number of holds a given patron can place on a given record. The default is 1 to retain Koha's current behavior as the default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:04:44 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #6 from Kyle M Hall --- Created attachment 45060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45060&action=edit Bug 14695 - - Add ability to place multiple item holds on a given record per patron Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Edit your circulation rules to allow 3 holds per record 4) In the staff client, test the ability to place multiple holds per patron per record. You should be able to place any combination of 3 holds per patron per record, with the exception that you cannot place multiple item level holds for the same item for the same patron. 5) Repeat step 4 for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:24:35 +0000 Subject: [Koha-bugs] [Bug 15224] New: Typo: Leave empty to add via item search (itemnunber). Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Bug ID: 15224 Summary: Typo: Leave empty to add via item search (itemnunber). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Typo 'itemnunber' Location: intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt:204 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:27:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:27:46 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:41:13 +0000 Subject: [Koha-bugs] [Bug 15225] New: Make HTML5Media work with file upload feature Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Bug ID: 15225 Summary: Make HTML5Media work with file upload feature Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Koha::Upload allows files to be attached to bibliographic records. HTML5Media streaming in Koha does not work with these files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:41:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:41:29 +0000 Subject: [Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:53:59 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:54:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:54:01 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45058|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 45061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45061&action=edit [SIGNED-OFF] Bug 14695 - Tidy CanItemBeReserved and CanBookBeReserved Signed-off-by: Jason M. Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:54:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:54:02 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:54:06 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44821|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 45062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45062&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:54:15 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45059|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard --- Created attachment 45063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45063&action=edit [SIGNED-OFF] Bug 14695 - Add new issuing rule This patch fines a new issuing rule 'holds_per_record' which defines the number of holds a given patron can place on a given record. The default is 1 to retain Koha's current behavior as the default. Signed-off-by: Jason M. Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:54:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:54:24 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45060|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard --- Created attachment 45064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45064&action=edit [SIGNED-OFF] Bug 14695 - - Add ability to place multiple item holds on a given record per patron Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Edit your circulation rules to allow 3 holds per record 4) In the staff client, test the ability to place multiple holds per patron per record. You should be able to place any combination of 3 holds per patron per record, with the exception that you cannot place multiple item level holds for the same item for the same patron. 5) Repeat step 4 for the OPAC. Signed-off-by: Jason M. Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 17:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 16:56:06 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #19 from Kyle M Hall --- Created attachment 45065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45065&action=edit Bug 13931 [QA Followup] - Fix whitespace error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 18:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 17:09:32 +0000 Subject: [Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- Marked as blocked, but does not say what it depends on. Is the status correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 18:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 17:14:30 +0000 Subject: [Koha-bugs] [Bug 15226] New: Broken link in staff client for files attached to records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 Bug ID: 15226 Summary: Broken link in staff client for files attached to records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a files is attached to a record via upload.pl, the link 'Click here to access online' is broken (uses opac-retrieve-file.pl which is not available in staff client). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 18:21:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 17:21:13 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Nick Clemens --- Checking out 1 item on hold for the patron resolved all the other waiting holds on that record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:09:20 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat at punsarn.asia --- Comment #25 from Pongtawat --- As a note, this change cause print window pop-up to be blocked by default by both Firefox and Chrome. In previous behavior, a print window pop-up is created when the print button is clicked so most browsers will allow it. In the new behavior, a print pop-up is created when the page reload, hence most browsers will block it by default. So now we have to explicitly set the browser to allow pop-up from Koha staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:23:55 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Hm, I think it doesn't work for me. I created a brand new database on a branch running 3.20.5. Then I switched back to master, applied the patches and ran the database update. This is the result: [Fri Nov 20 19:22:16 2015] updatedatabase.pl: DBD::mysql::db do failed: Can't create table 'koha.#sql-5b5_3f2' (errno: 121) [for Statement " [Fri Nov 20 19:22:16 2015] updatedatabase.pl: ALTER IGNORE TABLE course_reserves [Fri Nov 20 19:22:16 2015] updatedatabase.pl: add CONSTRAINT course_reserves_ibfk_2 [Fri Nov 20 19:22:16 2015] updatedatabase.pl: FOREIGN KEY (ci_id) REFERENCES course_items (ci_id) [Fri Nov 20 19:22:16 2015] updatedatabase.pl: ON DELETE CASCADE ON UPDATE CASCADE [Fri Nov 20 19:22:16 2015] updatedatabase.pl: "] at /home/katrin/kohaclone/installer/data/mysql/updatedatabase.pl line 10814. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:26:24 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #17 from Katrin Fischer --- This is my 'before' course_reserves table copied from the mysqldump: DROP TABLE IF EXISTS `course_reserves`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `course_reserves` ( `cr_id` int(11) NOT NULL AUTO_INCREMENT, `course_id` int(11) NOT NULL, `ci_id` int(11) NOT NULL, `staff_note` mediumtext COLLATE utf8_unicode_ci, `public_note` mediumtext COLLATE utf8_unicode_ci, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, PRIMARY KEY (`cr_id`), UNIQUE KEY `pseudo_key` (`course_id`,`ci_id`), KEY `course_id` (`course_id`), KEY `course_reserves_ibfk_2` (`ci_id`), CONSTRAINT `course_reserves_ibfk_1` FOREIGN KEY (`course_id`) REFERENCES `courses` (`course_id`), CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:30:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:30:26 +0000 Subject: [Koha-bugs] [Bug 15226] Broken link in staff client for files attached to records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15225 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:30:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:30:26 +0000 Subject: [Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15226 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:56:57 +0000 Subject: [Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hm, no dependency either - Marcel set the status himself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 20 19:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Nov 2015 18:59:01 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 01:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 00:45:17 +0000 Subject: [Koha-bugs] [Bug 15227] New: Small typo: itemnunber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15227 Bug ID: 15227 Summary: Small typo: itemnunber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: "Leave empty to add via item search (itemnunber)." labels/label-edit-batch.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 02:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 01:15:38 +0000 Subject: [Koha-bugs] [Bug 15228] New: Remove \n from translated strings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Bug ID: 15228 Summary: Remove \n from translated strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: "Deletion of item from a batch with only one item will delete the batch.\\n \\n If this is what you want, select 'Delete batch' option from toolbar" \n should not be inside translated strings as the translation process breaks them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 02:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 01:28:17 +0000 Subject: [Koha-bugs] [Bug 15227] Small typo: itemnunber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15227 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from H?ctor Eduardo Castro Avalos --- *** This bug has been marked as a duplicate of bug 15224 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 02:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 01:28:17 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from H?ctor Eduardo Castro Avalos --- *** Bug 15227 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 02:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 01:37:10 +0000 Subject: [Koha-bugs] [Bug 15229] New: Tiny typo:This patrons is ... Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Bug ID: 15229 Summary: Tiny typo:This patrons is ... Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: This patrons is from a different library (%s)" circulation/circulation_batch_checkouts.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 02:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 01:56:12 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #6 from H?ctor Eduardo Castro Avalos --- Hi Liz (In reply to Liz Rea from comment #1) > Depends on 15211 and 15212 because both of them bring this issue forward. 15212 doesn't have patch attached. (In reply to Liz Rea from comment #5) > Created attachment 45033 [details] [review] > Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module > To test: > > Add some patron lists, navigate through the lists interface and make sure > that while you are in the module, that Patron lists is highlighted on the > sidebar. > > Depends on 15211 and 15213 Do I need to apply bug 15211 on top? Test plan isn't clear for me, please reword/clarify the message :) Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 08:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 07:52:31 +0000 Subject: [Koha-bugs] [Bug 15230] New: Remove unused file circ/stats.pl from system Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Bug ID: 15230 Summary: Remove unused file circ/stats.pl from system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org circ/stats.pl and koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt seem not to be used. To verify: git grep '/stats.pl' koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45066&action=edit Bug 15207: Follow-up - change check for existing index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 12:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 11:45:06 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Katrin Fischer --- I have attached a follow-up - with this patch no errors show for me. But can someone please double-check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 13:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 12:41:02 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 14:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 13:21:44 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45029|0 |1 is obsolete| | Attachment #45032|0 |1 is obsolete| | Attachment #45066|0 |1 is obsolete| | --- Comment #22 from Zeno Tajoli --- Created attachment 45067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45067&action=edit Not show errors on update from 3.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 14:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 13:25:20 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #23 from Zeno Tajoli --- Hi to all, I cherry-pick the code of Katrin and Bernardo and I write a new version of the patch. Now the check is based on presence of index, not on FK in the INFORMATION_SCHEMA of mysql. So probalby it is more robust. New cycle of sign-off/QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 14:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 13:31:36 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #24 from Katrin Fischer --- Hi Zeno, thx for your work on this. We usually try to keep authorship of code. The other option here would be to sign off the 2 follow-ups from Bernardo and me - and move this to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:22:00 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #25 from Zeno Tajoli --- Hi Katrin, Infact I'outsite my standard pc and so I need to rewrite the patch from scratch. I think the second option is the more easy to do. Clearly we need that others person do sign-off and QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:29:34 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45067|0 |1 is obsolete| | --- Comment #26 from Zeno Tajoli --- Created attachment 45068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45068&action=edit Not show errors on update from 3.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:30:51 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #27 from Zeno Tajoli --- I upload a new version of the patch more correct about authorship of the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:55:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:55:30 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:57:02 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 --- Comment #1 from Marc V?ron --- Created attachment 45069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45069&action=edit Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 16:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 15:57:59 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 21:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 20:40:30 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #1 from Katrin Fischer --- *** Bug 14823 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 21:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 20:40:30 +0000 Subject: [Koha-bugs] [Bug 14823] Item search publication year search appears to be broken for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14636 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 22:46:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 21:46:26 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #2 from Katrin Fischer --- Created attachment 45070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45070&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 22:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 21:46:28 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #3 from Katrin Fischer --- Created attachment 45071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45071&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 22:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 21:47:06 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 22:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 21:52:16 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal --- Comment #3 from Katrin Fischer --- I think this could be quite problematic and we should fix it: To test: - Log into Koha, allow the browser to save the password. - Create a new patron. - Verify that your saved password and username have been added to the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 21 23:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 22:37:29 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #4 from Katrin Fischer --- Hm, http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:01:48 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Katrin Fischer --- It seems like this is a known problem, but I haven't found a really good fix yet. One way I found to 'fix' it is adding additional hidden input fields of the password type to the form. As the stackoverflow entry mentions, 3+ password fields on a page keep Firefox from filling them in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:04:41 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:04:48 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:43:42 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:43:45 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44615|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 45072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45072&action=edit Bug 15100: MARC21 - make display of "Dates associated with a name" optional With the changes for RDA now more subfields for the fields 100, 110, 111, and 700, 710, 711 are displayed. One of them is $d - Dates associated with a name This patch adds separate treatment of the $d subfield and wraps it in a span with the class "authordates". This makes it possible to hide the information with CSS. To test: - Make sure you have several records with $d catalogued - Check the display in result list and detail page with and without the page. - Check, if there is a difference in display - Check if the dates are correctly wrapped in a span - Try to hide the information, using the following entry in your *UserCSS preferences: .authordates { display: none; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 00:45:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Nov 2015 23:45:23 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 --- Comment #7 from Katrin Fischer --- Hi H?ctor, thx for taking a look at this! Hope it's ok, I have attached another patch that treats $d separately from the other subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:23:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:23:19 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:23:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:23:22 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 --- Comment #1 from Katrin Fischer --- Created attachment 45073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45073&action=edit Bug 9184: Acq - Don't show authority batches when ordering from staged file When ordering from a staged file, the list of files should only include imports of bilbiographic and no authority data. To test - start without the patch: 1) Stage an authority file 2) Stage a bilbiographic file 3) Create a new basked in acquisitions 4) Create a new order line selecting "From a staged file" 5) Verify that both files are shown 6) Apply patch 7) Verify that only the bibliographc file shows in the list now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:23:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:23:38 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:36:09 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45073|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 45074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45074&action=edit Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:37:41 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45073|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:37:51 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:40:17 +0000 Subject: [Koha-bugs] [Bug 8085] reserve slip should be hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:40:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:40:20 +0000 Subject: [Koha-bugs] [Bug 8085] reserve slip should be hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #5 from Katrin Fischer --- Created attachment 45075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45075&action=edit Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:40:40 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|reserve slip should be hold |Rename 'Reserve slip' to |slip |'Hold slip' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:51:12 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:51:15 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 --- Comment #1 from Katrin Fischer --- Created attachment 45076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45076&action=edit Bug 15229: Fix tiny typos in error messages of batch checkout page Patch fixes some small spelling errors on the batch checkouts page. Also switches 'reserves' to 'holds'. To test: - Read the patch and verify that the changes are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 01:55:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 00:55:15 +0000 Subject: [Koha-bugs] [Bug 15228] Remove \n from translated strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:05:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:05:15 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove \n from translated |Patron card batches - |strings |Improve translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:09:52 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:09:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:09:54 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #1 from Katrin Fischer --- Created attachment 45077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45077&action=edit Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:16:01 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:16:04 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 --- Comment #2 from Katrin Fischer --- Created attachment 45078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45078&action=edit Bug 15224: Label creator - fix tiny typo 'itemnunber' To test: - Go to Tools > Label creator > New > Label batch - Check text displayed in grey next to the text input field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:16:35 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |katrin.fischer at bsz-bw.de |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:24:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:24:45 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:24:48 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 --- Comment #1 from Katrin Fischer --- Created attachment 45079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45079&action=edit Bug 15216: Returns - Show branch names and item type description Changes the table with returned items to display the branch names for home and holding branch and the itemtype description instead of the codes. To test: - Check out some items - Return the items - Verify the changes in the table of returned items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:25:08 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:26:19 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When transferring an order, |Fix date display when |date displays incorrectly |transferring an order QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:35:32 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:35:34 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 --- Comment #1 from Katrin Fischer --- Created attachment 45080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45080&action=edit Bug 15202: Fix date display when transferring an order The date a basket was created was not displayed according to the dateformat system preference. Also fixes wording of the message shown when there are no baskets for a chosen vendor. To test: - Create an order with an order line - Click on the "Transfer" link on the basket summary page - Search for a vendor without open baskets - Verify change of message shown: "There are no open baskets for this vendor." - Choose another vendor with open baskets - Verify the creation date of the basket is displayed correctly formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:39:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:39:15 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|Don' display system |Don't display system |preference AllowPkiAuth |preference AllowPkiAuth |below heading CAS |under heading CAS |Authentication |Authentication -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:45:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:45:28 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:45:31 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 --- Comment #1 from Katrin Fischer --- Created attachment 45081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45081&action=edit Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading The system preference AllowPkiAuth display under the heading CAS authentication, but is actually a separate authentication option. Patch creates a separate heading for it. To test: - Go to Administration > System preferences > Tab Administration - Verify that AllowPkiAuth is now displayed separately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:49:58 +0000 Subject: [Koha-bugs] [Bug 14853] Shipping Fund Label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:50:56 +0000 Subject: [Koha-bugs] [Bug 14853] Change "Fund" to "Shipping fund" where appropriate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shipping Fund Label |Change "Fund" to "Shipping | |fund" where appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:54:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:54:19 +0000 Subject: [Koha-bugs] [Bug 14853] Change "Fund" to "Shipping fund" where appropriate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 02:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 01:54:21 +0000 Subject: [Koha-bugs] [Bug 14853] Change "Fund" to "Shipping fund" where appropriate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14853 --- Comment #2 from Katrin Fischer --- Created attachment 45082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45082&action=edit Bug 14853: Change 'Fund' to 'Shipping fund' Changes the 'Fund' to 'Shipping fund' so it's clear what the fund setting is used for. To test: - Receive a new shipment - Verify that 'Shipping cost' displays on the parcels page - Search for your invoice - View invoice details - Verify that 'Shipping cost' displays on the invoice page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:02:21 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:02:25 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 --- Comment #2 from Katrin Fischer --- Created attachment 45083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45083&action=edit Bug 14397: Fix tiny typo in database documentation Fixes Foriegn to Foreign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:02:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:02:42 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |katrin.fischer at bsz-bw.de Component|Database |Developer documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:27:57 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:28:01 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 --- Comment #1 from Katrin Fischer --- Created attachment 45084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45084&action=edit Bug 14349: Checkouts and Fines tab missing category description on the left When navigating the tabs in the patron account, for 2 tabs the patron category description is missing above the tabs. To test: - Go to a patron account in staff - Click through the tabs - Verify that for Checkouts and Fines the category description is missing above the tabs - Apply patch - Verify the description is now shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:28:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:28:10 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:41:04 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:41:07 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 --- Comment #4 from Katrin Fischer --- Created attachment 45085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45085&action=edit Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 03:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 02:41:17 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 04:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 03:19:10 +0000 Subject: [Koha-bugs] [Bug 13555] Encoding problems on the vendor summary and edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 15:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 14:47:21 +0000 Subject: [Koha-bugs] [Bug 15226] Broken link in staff client for files attached to records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 --- Comment #1 from Marcel de Rooy --- Could you please verify if your OPACBaseURL is filled in correctly? The link that upload puts in MARC 856 depends on a working base url.. Secondly, if the file is not marked public, it will not be downloadable via opac-retrieve-file either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 17:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 16:39:49 +0000 Subject: [Koha-bugs] [Bug 15226] Broken link in staff client for files attached to records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 --- Comment #2 from Mirko Tietgen --- Marcel: it is the same problem with OPACBaseURl and the staff equivalent filled in. catalogue/detail.pl in the staff client uses the staff base URL to link to online resources, eg. http://192.168.2.55:8080/cgi-bin/koha/opac-retrieve-file.pl?id=a57f99e63c861bfdbc9cd63d64cf3352 but opac-retrieve-file.pl is on OPAC side and can't be accessed from the link in the staff client. The file is public, it works fine in OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 18:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 17:56:03 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45080|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45086&action=edit Bug 15202: Fix date display when transferring an order The date a basket was created was not displayed according to the dateformat system preference. Also fixes wording of the message shown when there are no baskets for a chosen vendor. To test: - Create an order with an order line - Click on the "Transfer" link on the basket summary page - Search for a vendor without open baskets - Verify change of message shown: "There are no open baskets for this vendor." - Choose another vendor with open baskets - Verify the creation date of the basket is displayed correctly formatted. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 18:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 17:56:16 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 19:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 18:17:09 +0000 Subject: [Koha-bugs] [Bug 15231] New: Import patrons: Remove string splitting by html tags to avoid weird translations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Bug ID: 15231 Summary: Import patrons: Remove string splitting by html tags to avoid weird translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Example from 3.20: English: The fields 'branchcode' and 'categorycode' are required and must match valid entries in your database. ('required' and 'must match' are bold) German translation: Die Felder 'branchcode' und 'categorycode' sind verpflichtend und muss ?bereinstimmen erlaubte Eingaben in Ihre Datenbank. (Very weird). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 20:23:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 19:23:31 +0000 Subject: [Koha-bugs] [Bug 15226] Broken link in staff client for files attached to records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 --- Comment #3 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #2) > Marcel: it is the same problem with OPACBaseURl and the staff equivalent > filled in. > > catalogue/detail.pl in the staff client uses the staff base URL to link to > online resources, eg. > > http://192.168.2.55:8080/cgi-bin/koha/opac-retrieve-file. > pl?id=a57f99e63c861bfdbc9cd63d64cf3352 > > but opac-retrieve-file.pl is on OPAC side and can't be accessed from the > link in the staff client. > > The file is public, it works fine in OPAC. The URL should already contain the OPAC base URL as copied by the plugin. Note that the URL should be okay BEFORE using upload. I am not sure if I interpret your example correctly. But 8080 looks like a port for staff; it should not be in OPACBaseURL. (You did not change it after the upload?) And are you sure this is not a networking configuration problem btw? You are using local ip addresses here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 21:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 20:12:25 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #1 from Marc V?ron --- Created attachment 45087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45087&action=edit Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 21:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 20:14:37 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 21:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 20:17:43 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15231 CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 21:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 20:17:43 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 21:56:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 20:56:00 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #28 from Katrin Fischer --- I'd be happier with the 3 separate patches from before - I had tested them all together with my changes and they seemed to work really well now. I also think no additional changes are included in the new unified patch - so there should be no difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 22:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 21:11:46 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #34 from Katrin Fischer --- Hi Bouzid, thx for the new patches! For documentation I have following ideas: - Add a help page to the new page containing information on how to set this up. - Show a message on the About page of Koha and/or on the page itself, if the directory is not set up correctly - Show some kind of warning that people should set this up carefully because the files can include patron/sensitive information and what to look out for? Could we set up a safe (not accessible by URL) default directory for people to use? (normal installation... packages?) I am not sure how this could best be done technically, but someone else might be able to help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 22:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 21:37:10 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #6 from Katrin Fischer --- I think the problem might be here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/updatedatabase.pl;h=6ba8e4d88b90acf6512458ae2448fddc81b15308;hb=5574a2fc4952322219892bcff3ea2525fec41949#l8361 $name is explicitly set for the HOLD messages, but never updates for the other messages later on: 8363 my $name = $dbh->selectcol_arrayref(q| 8364 SELECT name FROM letter WHERE code="HOLD" 8365 |); 8366 $name = $name->[0]; So $name is also used for PREDUE and OVERDUE Maybe we could fix that database update - and then also do a database update looking at the code/module and change accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 22:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 21:44:28 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #36 from Katrin Fischer --- Hi Gaetan, I just read your last comment and I can think of different use cases for both developments: - Charge a postage fee for notices you sent out as print or a fee for a text message, as the library has to pay for those. In this case it could make sense to set the fee on notice level, but also on message transport level. - A overdue fee independent on the number of items overdue - a static overdue fee. I think this could work well from the overdue notice triggers page. So maybe both options have merit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 22:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 21:51:21 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #27 from Katrin Fischer --- (In reply to Viktor Sarge from comment #26) > I love this patch a lot, but am I the only one who seems to get nothing in > the [% issue.item.biblio.title %]? I only get the barcode and due date > (both production server and my dev-install). Since I seem to remember this > one working fine I'd just like to hear from others before I do any really > extensive testing on my setup. I Viktor - I just checked, the title, barcode and due date display nicely in my tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 23:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 22:00:23 +0000 Subject: [Koha-bugs] [Bug 13467] acq tab still says ordered even if completed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I think this has been fixed by: Bug 15036 - Closing and reopening a basket should not alter status of completed orders I also checked on my installation that it's not a general problem. If you follow all the steps, the order is shown as 'complete' at the end. *** This bug has been marked as a duplicate of bug 15036 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 23:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 22:00:23 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #9 from Katrin Fischer --- *** Bug 13467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 22 23:43:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 22:43:11 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 00:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 23:34:29 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I did some tests and research, looking at the examples provided by the LOC: http://www.loc.gov/marc/bibliographic/bd245.html Overall it seems that the correct sequence is not fixed and some subfields can be repated in different positions: a k p h 245 00$aPL 17 Hearing Files$kCase Files$f1974$pDistrict 6$hmicrofilm (jacketted in fiche). a p b p c 245 10$aInternationale Strassenkarte.$pEurope 1:2.5 Mio. :$bmit Register = International road map.$pEurope, 1:2.5 mio : with index /$cRV Reise- und Verkehrsverlag. So the ideal would be to make sure that the subfields can be cataloged in a certain sequence and will also display in this sequence... and actually that is exactly how it works now. I tested by changing my sequence in the record to a n... and the normal displays in staff and OPAC reflected that change perfectly. (I didn't expect it :) ) I think we probably can't just hardcode the sequence of subfields, as that would actually break the correct behaviour. Maybe it could be an option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 00:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 23:52:30 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45078|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 45088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45088&action=edit [SIGNED-OFF]Bug 15224: Label creator - fix tiny typo 'itemnunber' To test: - Go to Tools > Label creator > New > Label batch - Check text displayed in grey next to the text input field Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 00:53:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Nov 2015 23:53:18 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:04:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:04:27 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I think the order is hard-coded in the XSLTs at the moment... I agree with what Nicole has said as well. I much prefer: a, n, p, h, b, c over the alternatives. At the moment, I think it goes "b" then "h", but it appears that "h" should be before "b": $h - Medium Medium designator used in the title statement. In records formulated according to ISBD principles, the medium designator appears in lowercase letters and is enclosed within brackets. It follows the title proper (subfields $a, $n, $p) and precedes the remainder of the title ($b), subsequent titles (in items lacking a collective title), and/or statement(s) of responsibility ($c). http://www.loc.gov/marc/bibliographic/bd245.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:07:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:07:34 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:07:08 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45076|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45089&action=edit [SIGNED-OFF]Bug 15229: Fix tiny typos in error messages of batch checkout page Patch fixes some small spelling errors on the batch checkouts page. Also switches 'reserves' to 'holds'. To test: - Read the patch and verify that the changes are correct. Signed-off-by: Hector Castro Changes are correct, patch fixes capitalization and typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:23:55 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #2 from David Cook --- Comment on attachment 41642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642 Bug 14367: Add MARC record history Review of attachment 41642: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14367&attachment=41642) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +3531,4 @@ > sub ModBiblioMarc { > # pass the MARC::Record to this function, and it will create the records in > # the marc field > + my ( $record, $history, $biblionumber, $frameworkcode ) = @_; Why would you add $history as a 2nd positional parameter here? Wouldn't it make more sense to add it as the 4th, so that you wouldn't affect any existing calls to ModBiblioMarc that don't require the history? I notice $history was added as the last positional parameter on other functions which use history, so doing that here would be more consistent as well... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:25:54 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #3 from David Cook --- Comment on attachment 41642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642 Bug 14367: Add MARC record history Review of attachment 41642: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14367&attachment=41642) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +141,5 @@ > &TransformHtmlToXml > prepare_host_field > ); > + > + # History functions Are we adding new functions to C4::Biblio, or should these have gone into something like Koha::Metadata::History? ::: cataloguing/addbiblio.pl @@ +299,5 @@ > my $index_subfield = CreateKey(); # create a specifique key for each subfield > > + my $taghistory = $history->{$tag}->{$subfield}; > + if (defined $taghistory ) { > + warn "TAG HIST: $tag/$subfield", Dumper($taghistory); This looks like debugging code, no? @@ +523,4 @@ > my @BIG_LOOP; > my %seen; > my @tab_data; # all tags to display > + #print STDERR "usedTagsLibs: ", Dumper(@$usedTagsLib); Also looks like debugging code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 01:46:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 00:46:32 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #40 from David Cook --- (In reply to Katrin Fischer from comment #39) > I think the discussion is very interesting, but I am a bit worried about the > handling of a record from multiple sources. Maybe it would be good to agree > on a basic version of the harvester for a first implementation and then > enhance it for more complicated scenarios step by step? I'm inclined to agree with Katrin. I think it makes more sense to have a solid basic version before we try to over-complicate things. I've actually thought of another problem with the OAI-PMH import... and that's merging bibliographic records. If you were to merge a local record and a OAI-PMH record, and choose for the local record to be the destination record, the OAI-PMH import would be broken for that record... because the merge functionality has no concept of the OAI-PMH harvest. I like the idea of locking records that have been imported via certain mechanisms, although having that locking be effective across the board would require some rigorous checks in place throughout the code. I wish that there were some sort of tracking to show the source of all records (e.g. original, Z39.50, OAI-PMH, REST API, etc) to help out with that. -- The only problem I can see with providing a basic version is that a basic version might not capture all the data that we need for more complicated future scenarios... and it might make it 10 times harder to implement more complicated code in the future as a result... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 02:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 01:11:05 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #41 from David Cook --- (In reply to Katrin Fischer from comment #33) > I was told recently that 2-3 seconds is quite standard for OAI-PMH harvests. > > I think a problem could occur if Zebra is involved in matching as you have > to make sure the indexes have caught up before you can reliably match. Say a > record is changed at the source twice in a very short timeframe... or added > and then changed again, included in 2 harvests... but not yet indexed when > the second runs, etc. I agree once again with Katrin. I think I've said before (either here or via email) that using Zebra for matching can be very unreliable. Currently, I use the unique OAI-PMH identifiers to handle all harvested records, and that's quite robust, since that identifier should be persistent. However, that obviously doesn't help with matching OAI-PMH harvested records against local records created via other methods. In the short-term, perhaps merging bibliographic records would have to occur manually. Or maybe a deduplication tool could be created to semi-automate that task... although I think that tool would have to prevent any deletion of OAI-PMH harvested records. Actually, this hearkens back to my previous comment. It would be good if each record had a simple way of identifying its origin. So you couldn't delete a record obtained via OAI-PMH unless its parent repository was deleted from Koha or unless you used a OAI-PMH management tool to delete records for that repository. I think providing this "source" or "origin" would need to be done consistently or rather... extensibly. I wouldn't want it to be OAI-PMH specific as that would be short-sighted. At the moment, everything that goes through svc/import_bib uses a webservices import_batch... but that's not very unique. It would be interesting to have unique identifiers for import sources. So you might use the svc/import_bib with the connexion_import_daemon.pl, or with MARCEdit, or your home-grown script, or whatever. It would be interesting to distinguish those separately... and maybe prevent writes/deletions for records that are entered via connexion_import_daemon.pl and home-grown script XYZ, while leaving ones imported via MARCEdit to be managed however since you just exported some original records and re-imported them via MARCEdit after making some changes. One way of doing that would actually be to use developer keys... so a developer would need to get a key from Koha before using the web service and then the Koha sysadmin could handle the interaction between that service and Koha's internals using that key (e.g. if records are imported via Webservice A, prevent Koha users from doing anything with them). I suppose that's a bit tougher to do with OAI-PMH... but not necessarily. When a new OAI-PMH repository is added, the system could generate a key for it, and use that key for handling the permissions for Koha users... I think that element of the discussion would relate a lot to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 02:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 01:45:48 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45077|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45090&action=edit [SIGNED-OFF]Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 03:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 02:06:17 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 45091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45091&action=edit Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 04:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 03:04:00 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45087|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45092&action=edit [SIGNED-OFF]Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro Split html tags removed, notes at right side it displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 04:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 03:04:35 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 04:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 03:52:08 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45072|0 |1 is obsolete| | --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 45093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45093&action=edit [SIGNED-OFF]Bug 15100: MARC21 - make display of "Dates associated with a name" optional With the changes for RDA now more subfields for the fields 100, 110, 111, and 700, 710, 711 are displayed. One of them is $d - Dates associated with a name This patch adds separate treatment of the $d subfield and wraps it in a span with the class "authordates". This makes it possible to hide the information with CSS. To test: - Make sure you have several records with $d catalogued - Check the display in result list and detail page with and without the page. - Check, if there is a difference in display - Check if the dates are correctly wrapped in a span - Try to hide the information, using the following entry in your *UserCSS preferences: .authordates { display: none; } Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 04:52:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 03:52:42 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 06:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 05:55:42 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 07:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 06:26:16 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 --- Comment #1 from Marc V?ron --- (In reply to Katrin Fischer from comment #0) (...) > I think for now I'd like to suggest to only use bold formatting on full > sentences or single words, but not within a string. We have such rule in the Coding Guidelines, but for JS only: http://wiki.koha-community.org/wiki/Coding_Guidelines#JS3:_Avoid_strings_which_mix_text_and_markup JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags. I agree that the guidelines should be adapted to cover examples as above as well. See: http://irc.koha-community.org/koha/2015-11-22#i_1759100 20:16 there is a bug for not having bold /italic etc lke that 20:16 i tend to ask to make it a coding guideline 20:17 'avoid formatting single words bold in sentences or link single words out of a sentence' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 07:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 06:42:01 +0000 Subject: [Koha-bugs] [Bug 15232] New: Advanced Cataloging Editor: Fix translation and display issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Bug ID: 15232 Summary: Advanced Cataloging Editor: Fix translation and display issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The advanced cataloging editor contains strings that do not conform to http://wiki.koha-community.org/wiki/Coding_Guidelines#JS3:_Avoid_strings_which_mix_text_and_markup "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." That makes translations errorprone. Additionally, the fav icon is not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 07:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 06:57:03 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced Cataloging Editor: |Advanced Cataloging Editor: |Fix translation and display |Fix translation issues |issues | --- Comment #1 from Marc V?ron --- Fav icon issue seems to be browser dependent (FF only); removed from this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:05:36 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #2 from Marc V?ron --- Created attachment 45094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45094&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:06:58 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:12:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:12:06 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15232 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:12:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:12:06 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:37:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:37:09 +0000 Subject: [Koha-bugs] [Bug 15233] New: Cataloging subfield editors: Clean up html and streamline text for better translatability Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Bug ID: 15233 Summary: Cataloging subfield editors: Clean up html and streamline text for better translatability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Remove bold markup from explanatory text in auth_subfields_structure.tt and make it the same as in marc_subfields_structure.tt for better translatibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:39:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:39:54 +0000 Subject: [Koha-bugs] [Bug 15234] New: Administrative interface timeout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234 Bug ID: 15234 Summary: Administrative interface timeout Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The administrative interface seems not to honour the timeout set in preferences. Having set Administration > Login options > timeout to 7d ("Automatically log out users after 7d seconds of inactivity. Adding d will specify it in days, e.g. 1d is timeout of one day"), I discover that timeout comes within hours rather than days. In cataloguing Z3950 searches for example (addbooks.pl z3950_search.pl), any search involving a large number of targets (servers) ends up in a window stating "Error: Session timed out. Please log in again". Is that normal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:41:53 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #1 from Marc V?ron --- Created attachment 45095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45095&action=edit Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:44:09 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15233 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:44:09 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:51:28 +0000 Subject: [Koha-bugs] [Bug 15235] New: Add column filters to checkouts table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Bug ID: 15235 Summary: Add column filters to checkouts table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When dealing with a large number of checkouts, it could be useful to filter them (before using renew/checkin/export checkboxes for instance). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:52:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:52:07 +0000 Subject: [Koha-bugs] [Bug 15235] Add column filters to checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 --- Comment #1 from Julian Maurice --- Created attachment 45096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45096&action=edit Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:52:22 +0000 Subject: [Koha-bugs] [Bug 15235] Add column filters to checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |15219 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 [Bug 15219] Load checkouts table incrementally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:52:22 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15235 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 [Bug 15235] Add column filters to checkouts table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 08:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 07:59:44 +0000 Subject: [Koha-bugs] [Bug 15236] New: Better translatibility in "Connect biblio.biblionumber to a MARC subfield" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 Bug ID: 15236 Summary: Better translatibility in "Connect biblio.biblionumber to a MARC subfield" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Move html markup out of explanatory sentence in koha2marclinks.tt ("Connect biblio.biblionumber to a MARC subfield") for better translatability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:04:25 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #113 from Manos PETRIDIS --- Is there any functional UNIMARC to MARC21 MARC conversion xslt available? In other words, how may one search UNIMARC z39.50 targets in order to populate a MARC21 library? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:05:02 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 --- Comment #1 from Marc V?ron --- Created attachment 45097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45097&action=edit Bug 15236 - Better translatibility in "Connect biblio.biblionumber to a MARC subfield" This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect biblio.biblionumber to a MARC subfield") for better translatability. To test: - Apply patch - Go to Home > Administration < Koha to MARC mapping and edit a tag - Verify that text change makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:06:12 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15236 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:06:12 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:11:41 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45097|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45098&action=edit Bug 15236 - Better translatibility in "Connect biblio.biblionumber to a MARC subfield" This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect biblio.biblionumber to a MARC subfield") for better translatability. To test: - Apply patch - Go to Home > Administration < Koha to MARC mapping and edit a tag - Verify that text change makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:17:59 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #6 from Fridolin SOMERS --- I've found using a disabled input between loggin and password disables autocompletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:24:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:24:15 +0000 Subject: [Koha-bugs] [Bug 15237] New: Quote of the day: Better translatibility for editor and help Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Bug ID: 15237 Summary: Quote of the day: Better translatibility for editor and help Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Remove html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:26:17 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:26:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:26:20 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #7 from Fridolin SOMERS --- Created attachment 45099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45099&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:42:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:42:06 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 --- Comment #1 from Marc V?ron --- Created attachment 45100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45100&action=edit Bug 15237 - Quote of the day: Better translatibility for editor and help This patch moves html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). To test: - Apply patch - Go to Home > Tools > Quote Editor and related Help - Verify that text changes make sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:42:43 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15237 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:42:43 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:53:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:53:05 +0000 Subject: [Koha-bugs] [Bug 15238] New: Better translatability for Installer Step 1 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 Bug ID: 15238 Summary: Better translatability for Installer Step 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr This Bug streamlines html in installer/step1.tt for better translatibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:55:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:55:39 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 --- Comment #1 from Marc V?ron --- Created attachment 45101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45101&action=edit Bug 15238 - Better translatability for Installer Step 1 This Bug streamlines html in installer/step1.tt for better translatibility. To test: Reviwe code and verify that changes in text make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:56:13 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:56:13 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15238 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:57:56 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 --- Comment #3 from Katrin Fischer --- By moving the subfields in cataloguing I can do 'a n p h b c k s'. The fields show in the sequence they appear in the record for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 09:59:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 08:59:36 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45100|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45102&action=edit Bug 15237 - Quote of the day: Better translatibility for editor and help This patch moves html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). To test: - Apply patch - Go to Home > Tools > Quote Editor and related Help - Verify that text changes make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 10:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 09:00:45 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45102|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 45103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45103&action=edit Bug 15237 - Quote of the day: Better translatibility for editor and help This patch moves html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). To test: - Apply patch - Go to Home > Tools > Quote Editor and related Help - Verify that text changes make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 10:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 09:49:34 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 12:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 11:44:06 +0000 Subject: [Koha-bugs] [Bug 15239] New: Add multiple items fail on barcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Bug ID: 15239 Summary: Add multiple items fail on barcode Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 45104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45104&action=edit screenshot of items list we have identified that at least koha 3.20 on ubuntu 14.04 when you try to add multiple items and you have configured autoBarcode to '?<>yymmdd it only applies to the first item, the rest are just yymmdd It only happens with <>yymmdd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 12:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 11:44:32 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 --- Comment #1 from Hugo Agud --- It also happens in koha 3_22 beta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 13:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 12:30:41 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #28 from Viktor Sarge --- (In reply to Katrin Fischer from comment #27) > (In reply to Viktor Sarge from comment #26) > > I love this patch a lot, but am I the only one who seems to get nothing in > > the [% issue.item.biblio.title %]? I only get the barcode and due date > > (both production server and my dev-install). Since I seem to remember this > > one working fine I'd just like to hear from others before I do any really > > extensive testing on my setup. > > I Viktor - I just checked, the title, barcode and due date display nicely in > my tests. Thanks for the feedback Katrin! It was gone for a while, but it was patched with some later release and I had already forgotten about commenting on this thread by then. Sorry for the extra work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 13:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 12:39:13 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:19:40 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:22:53 +0000 Subject: [Koha-bugs] [Bug 15240] New: Performance issue running overdue_notices.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Bug ID: 15240 Summary: Performance issue running overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org Since introduction of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529#add_comment "Overdue notices respect holidays" feature, there is a big problem of performance running overdue_notices.pl For one of our client, where it used to take less than one hour, it now takes more than 7 hours. And this should be rune every day... This is due to date criteria that were removed from SQL queries, so all current issues are parsed 3 times (once for each level of overdue) rather than just overdue issues concerning one given level. Dealing with holidays should be done before quering issues, so that date criteria could be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:23:27 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:23:27 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15240 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:31:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:31:48 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #19 from Sophie MEYNIEUX --- Performance problem found, see bug 15240 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:42:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:42:37 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #29 from Bernardo Gonzalez Kriegel --- No problem for my part about authorship, we need to solve this :) What we do: 3 patches or one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 14:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 13:44:21 +0000 Subject: [Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #8 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #6) > Marked as blocked, but does not say what it depends on. Is the status > correct? Yes, I changed it. I will come back to this dev, as soon as time permits :) It certainly will need rebasing since I gave priority to bug 14321.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:01:58 +0000 Subject: [Koha-bugs] [Bug 15241] New: Allow lowercase letters in spine labels Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15241 Bug ID: 15241 Summary: Allow lowercase letters in spine labels Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: theod at lib.auth.gr QA Contact: testopia at bugs.koha-community.org There are cases[*] when one might want to have LOWERCASE letters in a spine label. These include 'a','b','c','d',... and 'z' after the date. Although in the items table, itemcallnumber already allows (and in our system already has) lowercase letters in such cases, when printing the spine label PDF, all these are converted to UPPERCASE. I believe that call numbers should not be converted to uppercase prior to PDF export. [*] For example: PS 3603 .L548 R43 2011a <--- meaning the item is a Photocopy PS 3603 .L548 R43 2011b <--- meaning the second edition or PS 3603 .L548 R43 2011z <--- meaning the year is uncertain (You may find more such cases here: https://sites.smu.edu/cul/cip/docs/CAT/cpm-050-090.htm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:04:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:04:42 +0000 Subject: [Koha-bugs] [Bug 15226] Broken link in staff client for files attached to records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15226 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Mirko Tietgen --- You are correct. Setting the base URL parameter _before_ uploading fixes my problem. Closing the report, thanks for your help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:17:25 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:32:45 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:33:13 +0000 Subject: [Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:45:17 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 15:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 14:58:32 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:32:02 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:33:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:33:18 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:35:58 +0000 Subject: [Koha-bugs] [Bug 14953] Adlibris (Swedish supplier) cover image support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|oleonard at myacpl.org |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:41:24 +0000 Subject: [Koha-bugs] [Bug 15242] New: Missing subroutine in overdue_notices.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Bug ID: 15242 Summary: Missing subroutine in overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When parse_letter was renamed to parse_overdue_letter on bug 12933 an error was introduced so that overdue_notices.pl cannot find the subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:43:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:43:18 +0000 Subject: [Koha-bugs] [Bug 14551] Warns when sending a list via email on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:44:44 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #1 from Nick Clemens --- Created attachment 45105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45105&action=edit Bug 15242 - Missing subroutine in overdue_notices.pl This patch changes the call to parse_overdues_letter to use the full namespace to ensure the subroutine can be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:44:42 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:45:26 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12933 Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:45:26 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:48:52 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45098|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 45106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45106&action=edit [SIGNED-OFF]Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield" This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect biblio.biblionumber to a MARC subfield") for better translatability. To test: - Apply patch - Go to Home > Administration < Koha to MARC mapping and edit a tag - Verify that text change makes sense Signed-off-by: Hector Castro Rewording Ok for translation purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:49:08 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:54:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:54:59 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45103|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 45107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45107&action=edit [SIGNED-OFF]Bug 15237: Quote of the day: Better translatibility for editor and help This patch moves html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). To test: - Apply patch - Go to Home > Tools > Quote Editor and related Help - Verify that text changes make sense. Signed-off-by: Hector Castro Rewording Ok for translation purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:55:10 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:58:29 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Chris Nighswonger --- *** This bug has been marked as a duplicate of bug 12201 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 16:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 15:58:29 +0000 Subject: [Koha-bugs] [Bug 12201] Add the ability for the user to supply a callnumber splitting regexp for custom CN systems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12201 --- Comment #4 from Chris Nighswonger --- *** Bug 5302 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:00:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:00:28 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45101|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45108&action=edit [SIGNED-OFF]Bug 15238: Better translatability for Installer Step 1 This Bug streamlines html in installer/step1.tt for better translatibility. To test: Reviwe code and verify that changes in text make sense. Signed-off-by: Hector Castro To reproduce in Debian environment, remove a required module with dpkg -r. Rewording Ok for translation purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:00:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:00:40 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:12:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:12:05 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45095|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45109&action=edit [SIGNED-OFF]Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro Rewording Ok for translation purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:12:18 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:33:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:33:34 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Failed QA --- Comment #3 from H?ctor Eduardo Castro Avalos --- Sorry, Marc But not a good solution If you trick a macro for example 500=?aEdited with Rancor and you change for 500?aEdited with Rancor, the message displayed is: h3Failed to run macro: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:38:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:38:15 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 45110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45110&action=edit Bug 15232: (follow-up) Advanced Cataloging Editor: Fix translation issues Change JS 'h3' for

    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:38:50 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:49:24 +0000 Subject: [Koha-bugs] [Bug 15241] Allow lowercase letters in spine labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15241 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9370, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10821 --- Comment #1 from Chris Nighswonger --- This issue was addressed in bug 10821 and has since been fixed in Library::Callnumber::LC (https://github.com/libraryhackers/library-callnumber-lc/commit/1b42bed2a42ce73679739edce6586339b192dc5b) Two things to consider here: 1. Are you using the latest release of Library::Callnumber::LC? 2. Are you using a localized variation of the LCCN system? (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821#c32) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:49:24 +0000 Subject: [Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 17:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 16:49:24 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 20:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 19:24:26 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 --- Comment #5 from Marc V?ron --- Thanks H?ctor for fixiing my error, I commited a little bit to fast... :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:07:46 +0000 Subject: [Koha-bugs] [Bug 15243] New: Place a hold on... Fix display issue and improve translatability Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Bug ID: 15243 Summary: Place a hold on... Fix display issue and improve translatability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Fix translatiblity issues with strings splited by html markup in reserve/request.tt Additionally, fix the display of the maximum number of holds a patron can have. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:14:05 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 --- Comment #1 from Marc V?ron --- Created attachment 45111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45111&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability Temporary patch, will need more work 23.11.2015/mv -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:14:42 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:21:32 +0000 Subject: [Koha-bugs] [Bug 15244] New: t/db_dependent/Reserves.t fails with test 14 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Bug ID: 15244 Summary: t/db_dependent/Reserves.t fails with test 14 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Running t/db_dependent/Reserves.t results in: not ok 14 - for generous library, its items fill first hold request in line (bug 10272) # Failed test 'for generous library, its items fill first hold request in line (bug 10272)' # at t/db_dependent/Reserves.t line 284. # got: '276' # expected: '277' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:22:31 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15244 Severity|trivial |minor Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 [Bug 15244] t/db_dependent/Reserves.t fails with test 14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:22:31 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15243 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 [Bug 15243] Place a hold on... Fix display issue and improve translatability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:23:26 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15243 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:23:26 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 21:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 20:57:03 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hector.hecaxmmx at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 22:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 21:21:14 +0000 Subject: [Koha-bugs] [Bug 15245] New: bug Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15245 Bug ID: 15245 Summary: bug Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: gugeldrusilla at yahoo.com QA Contact: testopia at bugs.koha-community.org Created attachment 45112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45112&action=edit file bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 23 22:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 21:21:34 +0000 Subject: [Koha-bugs] [Bug 15245] bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15245 Michael Sowders changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Michael Sowders --- fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:08:25 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:08:28 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #30 from Brendan Gallagher --- Created attachment 45113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45113&action=edit To not show errors on update from 3.20.x to 3.22.x Two update of db, 3.21.00.027 and 3.21.00.022, are partialy done also on 3.20.x. This patch modify updatedatabase.pl to cover those partial changes in db done in 3.20.x To test: 1)Install a 3.20.4 or more 2)Dump the db 2)Update to master and see the error 3)Installe the patch 4)Reload the db 5)Update to master and see no more error 6)Check the coerence at sql structure level More check: a)Reload the db b)Change db to delete the effect of those two commit in 3.20: bug 14205: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c158f9e27e9e283523a5070ae4e4c718627374d2 bug 14298: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e0c926e0104e3fb73d80d8bea07ea8b6f90807b3 c)Redone update d)With patch no errors Signed-off-by: Bernardo Gonzalez Kriegel Added COLLATE to audio_alerts Signed-off-by: Katrin Fischer Insert check based on INDEX instead of FK http://bugs.koha-community.org/show_bug.cgi?id=15207 Signed-off-by: Brendan A Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:35:13 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > By moving the subfields in cataloguing I can do 'a n p h b c k s'. > The fields show in the sequence they appear in the record for me. Even with the XSLT instead of the normal display? Hmm, I'll have to take a look. I had someone complaining about this recently and I switched the order of "bh" to "hb" and that seemed to fix it... First, I'm going to sign off one of your other bugs then I'll look at it again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:37:33 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 --- Comment #5 from Katrin Fischer --- Sounds like a plan - but yes, I tested with XSLT :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:54:33 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 00:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Nov 2015 23:54:35 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45085|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 45114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45114&action=edit Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown Signed-off-by: David Cook Works as described, although as Magnus mentioned, Locations still use codes instead of descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 01:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 00:03:36 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > Sounds like a plan - but yes, I tested with XSLT :) And right you are! It looks like I was thinking of the XSLTs in 3.14. It appears they've changed since then... yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 01:33:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 00:33:39 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 --- Comment #31 from Katrin Fischer --- Thx Bernardo and Brendan, I will try to retest this tomorrow for QA - but not sad at all if someone beats me to it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 01:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 00:55:45 +0000 Subject: [Koha-bugs] [Bug 15246] New: adding new patron results in branchcode foreign key error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15246 Bug ID: 15246 Summary: adding new patron results in branchcode foreign key error Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: lauraerinmann at gmail.com QA Contact: testopia at bugs.koha-community.org I volunteer at a small library that wants to make available it's rare books. Another volunteer has taken the time to enter our collection. I am tasked with adding our patrons, but unable to do so. For context, our koha installation predates me, so I don't know the history of it. Steps to reproduce: 1. Go to patrons, choose "New Patron", and select "Guest/Casual User" 2. Fill out all required fields in the patron form 3. Submit the form Then I end up on: `/members/moremember.pl?borrowernumber=0` And see this message: "This patron does not exist." Just to double check, when I go back to review the patrons list for the patron I attempted to create, I can't find them. Steps I have taken: 1. updated to the (latest) package in Precise (Ubuntu 12.04) "last" repository (Koha V 3.18.12). I inherited this installation, so I can't say if this function ever worked for our library. Here is a dump of the relevant log entries from `intranet-error.log` ``` [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/C4/SQLHelper.pm line 184., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UP) at /usr/share/koha/lib/C4/Members/Messaging.pm line 169., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UP) at /usr/share/koha/lib/C4/Members/Messaging.pm line 169., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UP) at /usr/share/koha/lib/C4/Members/Messaging.pm line 169., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_transport_preferences`, CONSTRAINT `borrower_message_transport_preferences_ibfk_1` FOREIGN KEY (`borrower_message_preference_id`) REFERENCES `borrower_message_) at /usr/share/koha/lib/C4/Members/Messaging.pm line 185., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UP) at /usr/share/koha/lib/C4/Members/Messaging.pm line 169., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY [Mon Nov 23 16:38:17 2015] [error] [client 192.168.0.5] [Mon Nov 23 16:38:17 2015] memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_library`.`borrower_message_preferences`, CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UP) at /usr/share/koha/lib/C4/Members/Messaging.pm line 169., referer: http://192.168.0.19:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=DAY ``` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 02:52:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 01:52:43 +0000 Subject: [Koha-bugs] [Bug 15246] adding new patron results in branchcode foreign key error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15246 --- Comment #1 from Laura --- I was able to get past this by changing my Home > Administration > System Preferences > Patrons. I noticed that the "BorrowerUnwantedField was set to "title|dateofbirth|branchcode" This was causing the field not to render (even as a hidden field). By removing branchcode from BorrowerUnwantedField, the branchcode field now renders, and chooses as it's only option our library branch code (our koha instance only has one libary). As for solutions, instead of getting the database error and having to chase through mysql logs, I would have ideally been met with a more understandable "Branch code is required" or better yet, the branch code, being a required field, should be rendered as a hidden input or computed server side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 05:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 04:14:20 +0000 Subject: [Koha-bugs] [Bug 15247] New: mysql_auto_reconnect do not reconnect with UTF8 connection Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Bug ID: 15247 Summary: mysql_auto_reconnect do not reconnect with UTF8 connection Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: pongtawat at punsarn.asia QA Contact: testopia at bugs.koha-community.org Summary: Since Koha switch to mysql_auto_reconnect (#10611), when MySQl connection drop and has to be auto-reconnect, the reconnected connection will use MySQL default character encoding. The original connection is always UTF8 as explicitly set by "set names utf8" in _new_dbh, but the reconnected connection seems to depend on MySQL configuration (in our case latin1). In our case, the reconnected connection will change all non-latin characters into "?". How to reproduce: 1) Use default my.cnf from Debian or Ubuntu. 2) Create a bib/item with non-latin UTF8 characters, let's say barcode "001" has title "?????????" 3) Start Koha SIP2 server (since it could hold MySQL connection long enough that it will have to be reconnected) 4) Connect to SIP2 server and send command to get item detail for "001". You will get the correct information (title = "?????????") 5) Do not close the connection, wait for about 15-20 mins (so that the MySQL connection drop) 6) Send command to get item detail for "001". You will now get title = "?????????". Possible fix: In our case, we switch back to old code that use DBIx ping(). Changing my.cnf should also work. However the behavior of the first connection and the reconnected one should be the same regardless of MySQL configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 05:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 04:16:02 +0000 Subject: [Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 07:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 06:26:42 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #42 from David Cook --- I did some more thinking today... The daemon, which I'm going to call Icarus as it's way easier to say that OAI-PMH harvester daemon, is going to be the focal point. Clients, such as the Koha web staff client or an icarus-client tool, will send "harvesting tasks" to the daemon as JSON messages via a Unix socket. The daemon will process those JSON messages, periodically perform the tasks to download the records, and then hand the records off to a record processor plugin. The plugin can then do whatever. It can hook directly into Koha, it can send the record to a REST API, or whatever. The JSON message is going to have an "extras" object that can contain data for the plugin, such as the URL of an API to send to. The plan at the moment is to leave it up to individuals to add the plugin to @INC when starting up the daemon. That said, I think about adding some sort of default plugin, so that out of the box users can use Icarus (ie the OAI-PMH harvester) without any additional configuration. I think the plugin approach should allow me to build 90% of the infrastructure we need for the harvester while leaving 10% up to libraries to have custom implementations. In theory, this could also help people with different timelines for their desired implementation. That is, I can provide the core functionality, but you might consider developing your own plugins to handle the record. Anyway, I have to run, but that's where my thoughts (and diagrams) have led me. Oh, the daemon will also be based on the POE module. While it was recently removed from Koha's dependencies as it wasn't being used anyway, I imagine it will be trivial to add it back in. We'll have to ask Galen who was the one who removed it, I think, and who will be the package manager going forward... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 07:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 06:40:53 +0000 Subject: [Koha-bugs] [Bug 15241] Allow lowercase letters in spine labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15241 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Theodoros Theodoropoulos --- Chris you are right! We had Library-CallNumber-LC v0.22 installed. We upgraded to 0.23 and the problem was solved! Having said that, with the new version, new problems with callnumber splitting were found, but they are not related to this case. Thanks again for such a prompt reply! I will close this case right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 08:19:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 07:19:25 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45105|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45115&action=edit Bug 15242 - Missing subroutine in overdue_notices.pl This patch changes the call to parse_overdues_letter to use the full namespace to ensure the subroutine can be found. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 08:19:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 07:19:49 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 09:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 08:56:09 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 10:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 09:24:37 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- QA Style note, we tend to import routines over adding full namespaces.. I'd prefer to stick to that standard unless you can come up with a good/valid reason against doing so? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 10:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 09:32:30 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- We have this line at the top of the script: 43 use C4::Overdues qw(GetFine GetOverdueMessageTransportTypes); I think adding the new routine the same way would be more consistent. Can you please provide a new patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 10:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 09:58:07 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #5 from Marc V?ron --- (In reply to Martin Renvoize from comment #3) > QA Style note, we tend to import routines over adding full namespaces.. (...) There is one more full name space in line 323: my @overduebranches = C4::Overdues::GetBranchcodesWithOverdueRules(); I think this should be fixed as well to be consistent. Ah, is it necessary that the subs are exported in C4/Overdues.pm? Line 47 following: GetBranchcodesWithOverdueRules is not listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 11:14:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 10:14:34 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 11:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 10:25:51 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #5 from Katrin Fischer --- Hm, I think -n might make most send for testing, not for production use. So if you want to see which patrons would be notified and how the notices would look like. 91 92 =item B<-n> 93 94 Do not send any email. Overdue notices that would have been sent to 95 the patrons or to the admin are printed to standard out. CSV data (if 96 the -csv flag is set) is written to standard out or to any csv 97 filename given. Using the print template in the email send to staff for patrons without email addresses etc. makes sense for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 11:28:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 10:28:19 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #6 from Martin Renvoize --- Oh man we're inconsistent in this script :(. Well spotted Marc, reading C4::Overdues I note it's using EXPORT instead of EXPORT_OK too :(. Personally, I believe if a routine is intended to be used in another module it should appears in the EXPORT_OK block not the EXPORT block, and that it should be explicitly imported into the using module with a use statement. So.. if I were being picky I'd say.. convert the EXPORT to EXPORT_OK (but this may break modules that expect to have access to the routines without explicitly importing them :( ), add the routine your found to the EXPORT_OK block also, and then clean up here to match. Perhaps split the work into two bugs.. one clean up and one just fixing the initial bug.. thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 11:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 10:39:42 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #7 from Martin Renvoize --- s/this script/these scripts/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 12:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 11:06:10 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Julian Maurice --- Changed status to ASSIGNED, the patches still need some work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 12:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 11:31:35 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #8 from Katrin Fischer --- I think best to fix the one problem identified here ... and do general cleanup separately :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 13:36:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 12:36:40 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #9 from Marc V?ron --- (In reply to Katrin Fischer from comment #8) > I think best to fix the one problem identified here ... and do general > cleanup separately :) +1 :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:37:30 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:37:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:37:32 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45091|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 45116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45116&action=edit [SIGNED-OFF] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:46:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:46:01 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:46:03 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45084|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 45117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45117&action=edit [SIGNED-OFF] Bug 14349: Checkouts and Fines tab missing category description on the left When navigating the tabs in the patron account, for 2 tabs the patron category description is missing above the tabs. To test: - Go to a patron account in staff - Click through the tabs - Verify that for Checkouts and Fines the category description is missing above the tabs - Apply patch - Verify the description is now shown Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:50:34 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 14:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 13:50:36 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45081|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 45118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45118&action=edit [SIGNED-OFF] Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading The system preference AllowPkiAuth display under the heading CAS authentication, but is actually a separate authentication option. Patch creates a separate heading for it. To test: - Go to Administration > System preferences > Tab Administration - Verify that AllowPkiAuth is now displayed separately Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:02:52 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:02:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:02:54 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45075|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 45119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45119&action=edit [SIGNED-OFF] Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. http://bugs.koha-community.org/show_bug.cgi?id=8085 Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:18:09 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45070|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 45120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45120&action=edit [SIGNED-OFF] Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:25:47 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45071|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 45121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45121&action=edit [SIGNED-OFF] Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:26:54 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #6 from Owen Leonard --- I left this as 'needs signoff' because I think it requires a test by a UNIMARC user as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:27:54 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #43 from Andreas Hedstr?m Mace --- I think your thoughts for Icarus (oh, the name!) are well thought out and promising. Building a core functionality, with a plugin system on top makes sense to me as it will allow for plenty of customization for individual libraries! But adding a default plugin is probably a good idea too... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:30:04 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 15:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 14:33:50 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz --- Comment #3 from Owen Leonard --- Can you please attach a screen shot or provide more information about how to trigger this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:42:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:42:48 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #16 from Paul Poulain --- I agree it's not super-powerfull, and I also agree with Alex about using FindDuplicate. The next step is probably to improve FindDuplicate. idea : using the matching points system. Opening a ticket for that now ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:45:07 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard --- If a checkin triggers the modal, any messages or alerts which were also triggered by the checkin will be hidden by the modal and will disappear after clearing the modal. For instance: A warning that the item was not checked out, or a checkin message which has been configured for that particular item type. If libraries are concerned about seeing the "not checked out" message this is problematic since Bug 14821 now blocks those transactions from appearing in the table of scanned items. And while I don't personally know what the checkin message option is used for, I don't think it's acceptable that it disappears. Perhaps those messages should not be cleared when the modal is dismissed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:46:48 +0000 Subject: [Koha-bugs] [Bug 15248] New: Improve FindDuplicate Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Bug ID: 15248 Summary: Improve FindDuplicate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: paul.poulain at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently, FindDuplicate tries to find a duplicate by doing a search, that cannot be tuned by the library. It would be better to have the opportunity to use the matching points system. A "FindDuplicate" matching point entry could be added, set to title/author -current behaviour of FindDuplicate-, that the library can update/change to fit it's needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:47:12 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15248 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:47:12 +0000 Subject: [Koha-bugs] [Bug 15248] Improve FindDuplicate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 16:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 15:57:57 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #21 from Owen Leonard --- Created attachment 45122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45122&action=edit Screenshot of layout issues This screenshot highlights a few markup/layout issues: - The list which displays the patron information is missing the enclosing
      - The list shouldn't be centered. There is CSS at line 1225 of staff-global.css which aligns lists which are displayed in a message div. It should be expanded to include '.modal-body ul' - The layout of the buttons doesn't work, but I'm not sure what to do about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 17:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 16:06:49 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 17:14:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 16:14:18 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 17:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 16:14:20 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45069|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 45123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45123&action=edit [SIGNED-OFF] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:20:07 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard --- Testing with date format "MM/DD/YYYY": In the "specify due date" field I was able to enter "11/1/2015" without any error. When I checked out the item it ignored the invalid date and used the default due date. In the "Renewal due date" field I was able to enter "11/1/2015" without any error. When I clicked the renew button the AJAX renewal process was started but never finished. Firebug reveals the error in the AJAX response: "The given date (11/1/2007) does not match the date format (us) at /home/oleonard/kohaclone/Koha/DateUtils.pm line 153." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:25:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:25:12 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:25:15 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45115|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 45124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45124&action=edit Bug 15242 - Missing subroutine in overdue_notices.pl This patch changes the call to parse_overdues_letter to use the full namespace to ensure the subroutine can be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:30:20 +0000 Subject: [Koha-bugs] [Bug 15249] New: barcode duplicate warning missing during adding multiple copy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249 Bug ID: 15249 Summary: barcode duplicate warning missing during adding multiple copy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Koha bug : Suppose a barcode number "1234" has been already entered in the koha system and if by mistake someone assigns again the same number system says barcode must be unique, but in case of entering multiple copy instead of warning system assigns next series of barcodes. For example there are 04 copy of the same title and user/staff enters barcode of first book say "1234" in barcode field and in number of copy 4 than system assigns 1234, 1235,1236 and 1237 but if 1234 is already available in the system than instead of warning it assigns automatically next available numbers i.e. it drops the first number (1234) and assigns 1235, 1236, 1237 ans 1238. My view is even we are entering multiple copy and if barcode is duplicate than koha should warn the system instead of assigning next available numbers ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:49:04 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Nick Clemens --- Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 20:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 19:58:24 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:12:32 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- I can't trigger the error, though searches don't seem to include the $x either before or after the patch. Are there any sysprefs to check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:14:30 +0000 Subject: [Koha-bugs] [Bug 15250] New: Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Bug ID: 15250 Summary: Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To re-create Go to reports -> Acquisitions statistics Populate with the following values: Acquisitions statistics Received on. Row: checked Column: checked From: 01/01/2015 To: Un-selected Cell value Count items Output: To screen into the browser: checked Running the report will trigger the following error: Software error: Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293. For help, please send mail to the webmaster (staff at bywatersolutions.com), giving this error message and the time and date of the error. Inspecting reports/acquisitions_stats.pl The error is at line 293 of /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl 282 elsif ( $_ =~ /received/ ) { 283 $filter{$_}->[0] = @$filters[2]; 284 $filter{$_}->[1] = @$filters[3]; 285 my $a = $_; 286 if ( $rodsp == 1 ) { 287 $field{$a} = "concat(hex(weekday($a)+1),'-',dayname($a))"; 288 } elsif ( $rodsp == 2 ) { 289 $field{$a} = "concat(hex(month($a)),'-',monthname($a))"; 290 } elsif ( $rodsp == 3 ) { 291 $field{$a} = "Year($a)"; 292 } else { 293 field{$a} = $a; 294 } 295 } Line 293 field{$a} = $a; should instead read $field{$a} = $a; The line numbers have shifted slightly in master, but the bug remains: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=reports/acquisitions_stats.pl;h=58e3fd9a634bb37c96d9ef12239dab38ceecb0f7;hb=HEAD#l287 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:16:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:16:55 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:20:53 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:20:55 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45099|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 45125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45125&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:27:55 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 --- Comment #4 from Liz Rea --- Created attachment 45126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45126&action=edit Buttons gone funky -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:37:34 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40806|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 45127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45127&action=edit Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:37:56 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Internal sign off only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:56:03 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:56:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:56:05 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45079|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 45128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45128&action=edit Bug 15216: Returns - Show branch names and item type description Changes the table with returned items to display the branch names for home and holding branch and the itemtype description instead of the codes. To test: - Check out some items - Return the items - Verify the changes in the table of returned items Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 21:56:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 20:56:34 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- It'd be nice to see collection code resolved too, but this is nice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 22:19:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 21:19:17 +0000 Subject: [Koha-bugs] [Bug 2124] Moving MARC Fields Around When Cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 22:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 21:21:09 +0000 Subject: [Koha-bugs] [Bug 2124] Moving MARC Fields Around When Cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124 --- Comment #2 from J Schmidt --- Does this issue get resolved with the new professional cataloger's interface? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 24 22:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Nov 2015 21:54:54 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #44 from Andreas Hedstr?m Mace --- (In reply to David Cook from comment #41) > I agree once again with Katrin. I think I've said before (either here or via > email) that using Zebra for matching can be very unreliable. > > Currently, I use the unique OAI-PMH identifiers to handle all harvested > records, and that's quite robust, since that identifier should be > persistent. However, that obviously doesn't help with matching OAI-PMH > harvested records against local records created via other methods. That potential matching rules should not rely on Zebra I think we can all agree on. But only matching via OAI-PMH identifiers I do not think would work for harvests from union catalogs. If I understand it correctly, it would force all libraries who want to start using Koha with OAI-PMH harvests to migrate using OAI-PMH or having a duplicate of all its records (since none of the local records will have OAI-PMH identifiers). In our case that would be about 1,2 million duplicates. > In the short-term, perhaps merging bibliographic records would have to occur > manually. Or maybe a deduplication tool could be created to semi-automate > that task... although I think that tool would have to prevent any deletion > of OAI-PMH harvested records. Handling 1,2 million duplicates manually, or even semi-automatically will most likely not be possible. Although it might be difficult technically, I still think some sort of matching rules is necessary. > Actually, this hearkens back to my previous comment. It would be good if > each record had a simple way of identifying its origin. So you couldn't > delete a record obtained via OAI-PMH unless its parent repository was > deleted from Koha or unless you used a OAI-PMH management tool to delete > records for that repository. > > I think providing this "source" or "origin" would need to be done > consistently or rather... extensibly. I wouldn't want it to be OAI-PMH > specific as that would be short-sighted. Marking the source/origin of a record sounds like a good idea to me, if it can be easily incorporated. > At the moment, everything that goes through svc/import_bib uses a > webservices import_batch... but that's not very unique. It would be > interesting to have unique identifiers for import sources. So you might use > the svc/import_bib with the connexion_import_daemon.pl, or with MARCEdit, or > your home-grown script, or whatever. It would be interesting to distinguish > those separately... and maybe prevent writes/deletions for records that are > entered via connexion_import_daemon.pl and home-grown script XYZ, while > leaving ones imported via MARCEdit to be managed however since you just > exported some original records and re-imported them via MARCEdit after > making some changes. I was going to ask how this would tie in with the development of the REST API, but Davids comment #42 explains that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 07:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 06:44:30 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 07:44:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 06:44:33 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45094|0 |1 is obsolete| | Attachment #45110|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 45129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45129&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 08:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 07:44:32 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- Code review: You have: function CalculateAge(dateofbirth) { Then, you don't use "dateofbirth". You have: You rather should use jQuery: $( "#dateofbirth" ).change(CalculateAge); >From an UI point of view, it seems awkward to have displayed firstly "DD/MM/YYYY" under the Date of birth text box, and then having this info replaced by the age. This way, it's not possible to see the age without modifying the date of birth. Wouldn't it be better/simpler to display the age on the detail page (moremember.pl), rather than on the editing page (memberentry.pl)? Have you seen that there is already a Perl function calculating age in Koha? C4::Members::GetAge(). There is a risk that your javascript code and Perl GetAge() produce a different age. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 08:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 07:50:10 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 08:50:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 07:50:13 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44774|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 45130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45130&action=edit Bug 15170 - Add 264 field to MARC21*DC.xsl Modify MARC21*DC.xsl to add RDA 264 field To test: - Copy from LOC z39.50 the Maxwell's handbook for RDA (ISBN 9780838911723) - Look the field 264 in framework, save record - Open this URL in OPAC /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id (the number of new record for Maxwell book) & format parameters Test format=rdfdc, format=srw_dc and format=oai_dc - Notice that and are not present - Apply this patch - Reload the URL for the three formats - You will see the tags publisher and date are taken from 264 Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 09:31:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 08:31:09 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 Than H. S. (Punsarn.asia) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thanhtutsoetgi at gmail.com --- Comment #12 from Than H. S. (Punsarn.asia) --- I have tried upgrading to latest Zebra version available (2.0.61). I have also performed forced re-building of the index after upgrade. It doesn't seem to fix this bug at all. Does anyone has some leads on how to fix this problem? It affects not only "Begins with" search but it also affects "Is exactly" search as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 09:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 08:51:40 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14544 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 09:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 08:51:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15137 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 [Bug 15137] List email sent from staff is missing ISBN and author information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 09:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 08:54:28 +0000 Subject: [Koha-bugs] [Bug 15251] New: Request for addition of ISO-8859-7 encoding support in Z39.50 searches. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15251 Bug ID: 15251 Summary: Request for addition of ISO-8859-7 encoding support in Z39.50 searches. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Please consider adding support for ISO-8859-7 encoding in Z39.50 searches (cataloguing/z3950_search.pl and elsewhere). Info on the various Greek character sets can be found at http://www.dmst.aueb.gr/dds/sw/greek/grconv/grconv.txt and https://en.wikipedia.org/wiki/ISO/IEC_8859-7 and http://www.ascii.ca/iso8859.7.htm ISO-8859-7 is/was also defined as ELOT_928, ISO-IR-126, ISO-IR-227, ECMA-118, CP28597 and is quite close to CP1253, WINDOWS-1253. Tests may be performed against the UNIVERSITY OF ATHENS, GREECE target, at 195.134.90.84:210 with db name "UOA_Library" (in UNIMARC). An ISBN that is known to appear in search results is 960-236-152-2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 10:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 09:37:47 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #78 from Jonathan Druart --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 11:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 10:17:00 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #6) > Yes we could, if nobody uses the --fix option: > > 243 -f --fix Replace biblioitems.marcxml from data in marc field, > default OFF The script was added in 2009 and not touched since: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=84ff3747b80d42914a8d570b6b4ff5667eab663b >From the commit message: "When marcxml cannot be parsed into a MARC::Record object, the biblio is undisplayable and it obviously breaks many features in Koha. This script can test to parse every marcxml, and alert on failures. Optionally, the marcxml can be replaced from the marc field." Didn't we at some point switch from treating marc (ISO2709) as the authoritative format, to treating marcxml as the authoritative format? I'd say loosing the ability to recreate marcxml from marc is no big deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:00:10 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #12 from Jonathan Druart --- Hi Owen, Could you detail how you managed to insert an invalid date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:04:40 +0000 Subject: [Koha-bugs] [Bug 15249] barcode duplicate warning missing during adding multiple copy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:07:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:07:07 +0000 Subject: [Koha-bugs] [Bug 15249] barcode duplicate warning missing during adding multiple copy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:12:07 +0000 Subject: [Koha-bugs] [Bug 15252] New: Patron search on start with does not work with several terms Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Bug ID: 15252 Summary: Patron search on start with does not work with several terms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When searching a patron, search type can be 'start with' and 'contain'. If the search text contains a space (or a coma), this text is splitted into several terms. Actually, the search on 'start with' with several terms never returns a result. It is because the search composes an "AND" SQL query on terms. For example (I display only the surname part) : search type = contain : 'jean paul' => surname like '%jean% AND %paul%' search type = start with : 'jean paul' => surname like 'jean% AND paul%' The query for 'start with' is impossible. I propose, for search with start with, to not split terms : jean paul => surname like 'jean paul%' One can always use '*' to add more truncation : jea* pau* => surname like 'jea% pau%' This bug affects a lot surnames with several terms like 'LE GUELEC' or 'MAC BETH'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:15:15 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:27:06 +0000 Subject: [Koha-bugs] [Bug 2124] Moving MARC Fields Around When Cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124 --- Comment #3 from Katrin Fischer --- I think it(In reply to J Schmidt from comment #2) > Does this issue get resolved with the new professional cataloger's interface? Yes, it's possible to change the sequence of fields - I just cataloged 650 648 for testing. But be aware that the new cataloguing interface doesn't support authority linking yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 12:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 11:30:23 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- I tend to agree with Magnus - I am not sure that this script makes that much sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:12:02 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:12:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:12:04 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 --- Comment #1 from Fridolin SOMERS --- Created attachment 45131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45131&action=edit Bug 15252 - Patron search on start with does not work with several terms When searching a patron, search type can be 'start with' and 'contain'. If the search text contains a space (or a coma), this text is splitted into several terms. Actually, the search on 'start with' with several terms never returns a result. It is because the search composes an "AND" SQL query on terms. For example (I display only the surname part) : search type = contain : 'jean paul' => surname like '%jean% AND %paul%' search type = start with : 'jean paul' => surname like 'jean% AND paul%' The query for 'start with' is impossible. I propose, for search with start with, to not split terms : jean paul => surname like 'jean paul%' One can always use '*' to add more truncation : jea* pau* => surname like 'jea% pau%' This bug affects a lot surnames with several terms like 'LE GUELEC' or 'MAC BETH'. Note that the patch moves : $searchmember =~ s/,/ /g; It removes the test "if $searchmember" because $searchmember is tested and set to empty string previously : unless ( $searchmember ) { $searchmember = $dt_params->{sSearch} // ''; } Test plan : ========== - Create two patrons with firstname "Jean Paul" - Go to Patrons module - Choose "Starts with" in "Search type" filter - Perform a search on "Jean Paul" => without patch : you get no result => with this patch : you get the two results - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you do not get results for search on "Jea Paul" - Choose "Contains" in "Search type" filter - Check you get the two results for search on "Jean Paul" - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you get the two results for search on "Jea Paul" - Check you get the two results for search on "Paul Jean" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:12:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:12:17 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 --- Comment #2 from Fridolin SOMERS --- Created attachment 45132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45132&action=edit Bug 15252 - Patron search on start with does not work with several terms - followup 1 'start_with' is the default value of $searchtype, it can be explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:24:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:24:52 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #188 from Jonathan Druart --- (In reply to Peter Zhao from comment #187) > Es can not "edit record" or "edit items" in UNIMARC structure. (But it > works well in USMARC.) > > It can show results, but when I click "Edit record", it shows "Add MARC > record "--blank MARC. > http://127.0.1.1:8080/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber= > > > > If I click "Edit items" , it shows > > http://127.0.1.1:8080/cgi-bin/koha/cataloguing/additem.pl?biblionumber= > > Software error: > > Can't call method "fields" on an undefined value at > /home/koha/kohaclone/cataloguing/additem.pl line 703. > > For help, please send mail to the webmaster (webmaster at koha), giving this > error message and the time and date of the error. > > I think it can not get the " biblionumber= ". I suspect that it comes from the fact that biblionumber is not indexed in a specific field (see comment 148). Moreover I don't think the following comment is correct http://git.catalyst.net.nz/gw?p=koha.git;a=blob;f=Koha/ElasticSearch/Indexer.pm;h=06dcb1d3e0b57633652d4cb70ed46ac59f0f802e;hb=refs/heads/elastic_search#l176 167 sub _sanitise_records { 168 my ($self, $biblionums, $records) = @_; 169 170 confess "Unequal number of values in \$biblionums and \$records." if (@$biblionums != @$records); 171 172 my $c = @$biblionums; 173 for (my $i=0; $i<$c; $i++) { 174 my $bibnum = $biblionums->[$i]; 175 my $rec = $records->[$i]; 176 # I've seen things you people wouldn't believe. Attack ships on fire 177 # off the shoulder of Orion. I watched C-beams glitter in the dark near 178 # the Tannhauser gate. MARC records where 999$c doesn't match the 179 # biblionumber column. All those moments will be lost in time... like 180 # tears in rain... 181 $rec->delete_fields($rec->field('999')); 182 $rec->append_fields(MARC::Field->new('999','','','c' => $bibnum, 'd' => $bibnum)); 183 } 184 } The biblionumber is stored in 001, isn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:29:35 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Chetan Panchal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chetanpanchal888 at hotmail.co | |m --- Comment #9 from Chetan Panchal --- Hi Everyone, I am new in this. I want to solve this bug. Please suggest me what is the actual requirement. Is it that when we pay fine in admin then it shows only payment thanks but you need that it should show item details also (i.e - Item Barcode or Item Title). Please help me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 13:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 12:44:16 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #189 from Magnus Enger --- (In reply to Jonathan Druart from comment #188) > The biblionumber is stored in 001, isn't it? No. For imported records, the 001 is not touched. For original cataloguing (starting from scratch) 001 has to be filled manually. The one place where you can find the biblionumber in our MARC records is in 999 $c and $d. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:02:33 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 --- Comment #3 from Fridolin SOMERS --- Created attachment 45133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45133&action=edit Bug 15252 - correct UT searchtype value is contain and not contains -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:02:45 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 --- Comment #4 from Fridolin SOMERS --- Created attachment 45134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45134&action=edit Bug 15252 - UT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:16:20 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|z.tajoli at cineca.it |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED --- Comment #32 from Jonathan Druart --- I will provide a counter patch to simplify this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:20:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:20:14 +0000 Subject: [Koha-bugs] [Bug 11431] Custom notification sounds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #163 from Jonathan Druart --- Created attachment 45135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45135&action=edit Bug 11431: (follow-up) Update database This patch specifies the collate for the new audio_alerts table to the updatedb entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:21:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:21:37 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11431 --- Comment #33 from Jonathan Druart --- Follow-up added on bug 11431 comment 163. There is no need to specify the collate for the columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:21:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:21:37 +0000 Subject: [Koha-bugs] [Bug 11431] Custom notification sounds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15207 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:31:26 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #190 from Katrin Fischer --- I think UNIMARC uses 001 if I am not mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:32:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:32:57 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 --- Comment #4 from Katrin Fischer --- Hi Nick, thx for the sign-off - I will try to provide a follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:33:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:33:36 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14298 --- Comment #34 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #3) > The second error is present because the update 3.21.00.027 starts so: > > dbh->do(q| > INSERT INTO permissions (module_bit, code, description) > VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It > should be used for the patron matching the AutoSelfCheckID') > |); > > But in 3.20.5 in file installer/data/mysql/en/mandatory/userpermissions.sql > I see: > > INSERT INTO permissions (module_bit, code, description) VALUES > [...] > ( 1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used > for the patron matching the AutoSelfCheckID'), > > So in 3.20.x the code 'self_checkout' could be present. Follow-up added on bug 14298. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:47:05 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #10 from Katrin Fischer --- Hi Chetan, this is not easy to solve, as one payment can be for multiple fines and can only include partial payments. This is why Kyle and others have been working on a rewrite of the accounts system. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:51:41 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:51:44 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45124|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 45137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45137&action=edit [SIGNED OFF] Bug 15242 - Missing subroutine in overdue_notices.pl This patch changes the call to parse_overdues_letter to use the full namespace to ensure the subroutine can be found. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:54:58 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:55:01 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45068|0 |1 is obsolete| | Attachment #45113|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 45138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45138&action=edit Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:55:27 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14205 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 [Bug 14205] Deleting an Item/Record does not remove link to course reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 14:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 13:55:27 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15207 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:02:25 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #79 from Bernardo Gonzalez Kriegel --- Hi Jonathan, all patches apply, last patch signeed. I have a followup to remove some tabs/spaces Do I have to upload all here? Also found some "| html | html_line_break " and "| html | url " Don't know if they need to be removed git grep "|html " koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt:20: "[% data.borrowernotes.replace('\\\\' , '\\\\') |html |html_line_break |collapse %]", koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt:29: "[% data.borrowernotes.replace('\\\\' , '\\\\') |html |html_line_break |collapse %]", koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:44: No results found for that in [% LibraryName %] catalog. Subscribe to this search koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt:88: Subscribe to this search koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt:71: Subscribe to this search [% s.query_desc %] git grep "| html " koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:111: Subscribe to this search [% s.query_desc %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:23:17 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:25:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:25:32 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to Nick Clemens from comment #2) I'll fix it up as soon as possible, Nick. Thanks for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:27:14 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:27:17 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45138|0 |1 is obsolete| | --- Comment #36 from Tom?s Cohen Arazi --- Created attachment 45140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45140&action=edit Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 15:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 14:49:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #80 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #79) > Hi Jonathan, > all patches apply, last patch signeed. > I have a followup to remove some tabs/spaces Where? > Do I have to upload all here? No, I will add your signoffs on my branch. > Also found some "| html | html_line_break " and "| html | url " > Don't know if they need to be removed I don't think they should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:01:23 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #81 from Bernardo Gonzalez Kriegel --- Created attachment 45141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45141&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:01:27 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:01:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:01:31 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45140|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer --- Created attachment 45142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45142&action=edit [PASSED QA] Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2 Bug 14205 added a new foreign key on the course_reserve table. As this dbrev has been backported to the stable version (3.20.x), the next dbrev should take care of this existing constraint to avoid warnings. Test plan: 1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be executed 2/ Make sure you have the KEY and the FK on the course_reserves table: sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE; sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`); 3/ SHOW CREATE TABLE course_reserves should show that the table is not in sync with the kohastructure.sql file 4/ Execute the dbrev 5/ SHOW CREATE TABLE course_reserves should show that the table is in sync with the kohastructure.sql file Repeat 4 and 5, confirm you don't get any error. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:01:42 +0000 Subject: [Koha-bugs] [Bug 15253] New: Add Koha::Logger based logging for SIP2 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Bug ID: 15253 Summary: Add Koha::Logger based logging for SIP2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipser to the namespace so we can allow for separate files per sip user if wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:01:47 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:02:35 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #82 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #80) > (In reply to Bernardo Gonzalez Kriegel from comment #79) > > Hi Jonathan, > > all patches apply, last patch signeed. > > I have a followup to remove some tabs/spaces > > Where? > I attached a patch with fixes needed by koha-qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:03:36 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 --- Comment #4 from Jonathan Druart --- With a debarred value set to NULL, I don't know at all how you could get this error. Could you confirm that the line 1966 of your C4/Circulation.pm is the same as the ligne 1972 of the following snippet (from 3.20.x): 1967 } elsif ( $issue->{date_due} and $borrower->{'debarred'} ) { 1968 if ( $borrower->{debarred} eq "9999-12-31") { 1969 $messages->{'ForeverDebarred'} = $borrower->{'debarred'}; 1970 } else { 1971 my $borrower_debar_dt = dt_from_string( $borrower->{debarred} ); 1972 $borrower_debar_dt->truncate(to => 'day'); 1973 my $today_dt = $today->clone()->truncate(to => 'day'); 1974 if ( DateTime->compare( $borrower_debar_dt, $today_dt ) != -1 ) { 1975 $messages->{'PrevDebarred'} = $borrower->{'debarred'}; 1976 } 1977 } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:09:45 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:09:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:09:48 +0000 Subject: [Koha-bugs] [Bug 15232] Advanced Cataloging Editor: Fix translation issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45129|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 45143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45143&action=edit Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:24:03 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart --- - $searchmember =~ s/\*/%/g; # * is replaced with % for sql + + $term =~ s/\*/%/g; # * is replaced with % for sql This changes has 2 consequences: 1/ Add a new feature: * is now a wildcard for the patron search 2/ Introduce a regression: * is not a wildcard anymore for the patron attribute search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:27:17 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- With this: my $timeout = $self->{service}->{client_timeout} || $config->{client_timeout}; what will happen after Koha upgrade if a library doesn't add the new 'client_timeout' parameter to its config file. Wouldn't it be better to have something like: my $timeout = $self->{service}->{client_timeout} || $config->{client_timeout} || $self->{service}->{timeout} || $config->{timeout}; And/or a note via updatabase.pl to notify that SIP config file has to be reviewed after upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:27:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:27:40 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:27:43 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45137|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 45144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45144&action=edit Bug 15242 - Missing subroutine in overdue_notices.pl This patch changes the call to parse_overdues_letter to use the full namespace to ensure the subroutine can be found. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:27:58 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12933 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12933 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 [Bug 12933] Add ability to print overdue slip from staff intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:27:58 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15242 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15242 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 [Bug 15242] Missing subroutine in overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:30:14 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 --- Comment #13 from Jonathan Druart --- (In reply to Martin Renvoize from comment #3) > QA Style note, we tend to import routines over adding full namespaces.. > > I'd prefer to stick to that standard unless you can come up with a > good/valid reason against doing so? And I prefer the other way :) I personally think it adds readability and eases refactoring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:30:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:30:57 +0000 Subject: [Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #38 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Zeno, Bernardo, Katrin and Jonathan :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:32:37 +0000 Subject: [Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:36:00 +0000 Subject: [Koha-bugs] [Bug 15254] New: Koha/Plack runs in endless loop if mysql is down Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15254 Bug ID: 15254 Summary: Koha/Plack runs in endless loop if mysql is down Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: wosch at freebsd.org QA Contact: testopia at bugs.koha-community.org Hi, I'm running koha-common_3.20.04 with plack enabled. I noticed that the CPU runs at 100% if the mysql service is down. Looking in the logfiles it seems that starman starts a /etc/koha/plack.psgi process, and if it fails try it again. here is the apache error log output: DBI connect('dbname=koha_koha;host=localhost;port=3306','koha_koha',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Connector.pm line 32. Error while loading /etc/koha/plack.psgi: Can't call method "do" on unblessed reference at /usr/share/koha/lib/C4/Context.pm line 793. Compilation failed in require at /usr/share/koha/lib/C4/Letters.pm line 27. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Letters.pm line 27. Compilation failed in require at /etc/koha/plack.psgi line 33. BEGIN failed--compilation aborted at /etc/koha/plack.psgi line 33. How to repeat: on a system with plack enabled and running koha: sudo /etc/init.d/koha-common stop sudo /etc/init.d/mysql stop sudo /etc/init.d/koha-common start now check the system load with top(1) -Wolfram -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:38:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:38:05 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:38:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:38:08 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45117|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45145&action=edit Bug 14349: Checkouts and Fines tab missing category description on the left When navigating the tabs in the patron account, for 2 tabs the patron category description is missing above the tabs. To test: - Go to a patron account in staff - Click through the tabs - Verify that for Checkouts and Fines the category description is missing above the tabs - Apply patch - Verify the description is now shown Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:46:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:46:21 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:46:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:46:23 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45125|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 45146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45146&action=edit Bug 14599 - Saved auth login and password are used in patron creation from If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart This is not elegant but it works. Note that the problem does not exist with Chromium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:46:25 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #22 from Kyle M Hall --- (In reply to Owen Leonard from comment #21) > Created attachment 45122 [details] > Screenshot of layout issues > > This screenshot highlights a few markup/layout issues: > > - The list which displays the patron information is missing the enclosing >
        > - The list shouldn't be centered. There is CSS at line 1225 of > staff-global.css which aligns lists which are displayed in a message div. It > should be expanded to include '.modal-body ul' I removed the ul tags to make it readable. The ul styling was 'odd'. Would you be able to style the data? My css-fu isn't all that great ; ) > - The layout of the buttons doesn't work, but I'm not sure what to do about > that. That's really odd, because they look great on my system! Are you using any styling beyond stock Koha on your test system? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:49:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:49:13 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:49:16 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #12 from Kyle M Hall --- Created attachment 45147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45147&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:49:32 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:50:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:50:16 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Even without this patch, in UNIMARC, item search by publication date does not work. It is because there is in itemsearch.tt publicationdate instead of publicationyear. May I provide a patch here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:52:31 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:52:33 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45123|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45148&action=edit Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart See the following commit for more info on this script: commit 60105bd692a07639f275543365acfca4f464c1a2 Date: Tue Jul 8 20:02:34 2008 -0500 fix for 2008: Daily reconciliation report broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:52:40 +0000 Subject: [Koha-bugs] [Bug 15230] Remove unused file circ/stats.pl from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 16:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 15:52:40 +0000 Subject: [Koha-bugs] [Bug 2008] Daily reconciliation report broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15230 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:03:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:03:54 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:03:57 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41236|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 45149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45149&action=edit Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold Right now, if a library automatically cancels expired waiting holds, a librarian must still re-checkin an item to trap the next available hold for that item. It would be better if the next hold was automatically trapped and the librarians receive an email notification so they can make any changes to the item if need be ( hold area, hold slip in item, etc ). Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with one item 4) Place two holds on that record 5) Check in the item and set it to waiting for the first patron 6) Set ReservesMaxPickUpDelay to 1 7) Enable ExpireReservesMaxPickUpDelay 8) Enable ExpireReservesAutoFill 9) Set an email address in ExpireReservesAutoFillEmail 10) Modify the holds waitingdate to be in the past 11) Run misc/cronjobs/holds/cancel_expired_holds.pl 12) Note the hold is now waiting for the next patron 12) Note a waiting hold notification email was sent to that patron 13) Note a hold changed notification email was sent to the library Signed-off-by: Gene Miller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:04:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:04:04 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:13 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:16 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44975|0 |1 is obsolete| | Attachment #44976|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 45150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45150&action=edit Bug 15211: adding Tools section sidebar to label creator The label creator had a very sad sidebar, it needed to have the Tools area sidebar on it. To test: Click through all "New" pages, verify that the sidebar appears Click through all "Manage" pages, verify that the sidebar appears. Also verify that "Label creator" is bolded in the toolbar while the label creator is active. Signed-off-by: Hector Castro Sidebar displayed Ok. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:20 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 --- Comment #7 from Jonathan Druart --- Created attachment 45151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45151&action=edit Bug 15211: Patron card creator needs tools sidebar The patron card creator should have the Tools area sidebar on its pages. This patch adds it. To test: Go to More -> Tools -> Patron card creator The home page should have the tools sidebar Click through all of the "New" pages - they should all have the tools sidebar Click through all of the "Manage" pages - they should all have the tools sidebar Also verify that on each page, the Patron card creator link in the sidebar is bolded Signed-off-by: Hector Castro Sidebar displayed Ok. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:50 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:49 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|cnighswonger at foundations.ed |liz at catalyst.net.nz |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:05:54 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44331|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 45152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45152&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:06:50 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #8 from Fridolin SOMERS --- Created attachment 45153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45153&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:07:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:07:23 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:09:38 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:09:41 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45086|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45154&action=edit Bug 15202: Fix date display when transferring an order The date a basket was created was not displayed according to the dateformat system preference. Also fixes wording of the message shown when there are no baskets for a chosen vendor. To test: - Create an order with an order line - Click on the "Transfer" link on the basket summary page - Search for a vendor without open baskets - Verify change of message shown: "There are no open baskets for this vendor." - Choose another vendor with open baskets - Verify the creation date of the basket is displayed correctly formatted. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:10:01 +0000 Subject: [Koha-bugs] [Bug 15202] Fix date display when transferring an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org QA Contact|katrin.fischer at bsz-bw.de |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:10:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:10:56 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:10:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:10:59 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45088|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45155&action=edit Bug 15224: Label creator - fix tiny typo 'itemnunber' To test: - Go to Tools > Label creator > New > Label batch - Check text displayed in grey next to the text input field Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:11:14 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:11:16 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 --- Comment #3 from Fr?d?ric Demians --- Created attachment 45156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45156&action=edit Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Fr?d?ric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:11:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:11:33 +0000 Subject: [Koha-bugs] [Bug 15224] Typo: Leave empty to add via item search (itemnunber). In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Add several patrons to a new batch will create a new batch per patron added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:11:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:11:33 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15224 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224 [Bug 15224] Typo: Leave empty to add via item search (itemnunber). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:15:52 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:15:55 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45089|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45157&action=edit Bug 15229: Fix tiny typos in error messages of batch checkout page Patch fixes some small spelling errors on the batch checkouts page. Also switches 'reserves' to 'holds'. To test: - Read the patch and verify that the changes are correct. Signed-off-by: Hector Castro Changes are correct, patch fixes capitalization and typo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:15:59 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo:This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 --- Comment #4 from Jonathan Druart --- Created attachment 45158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45158&action=edit Bug 15229: Same fix for circulation.tt template (normal checkouts) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:19:20 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:19:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:19:23 +0000 Subject: [Koha-bugs] [Bug 15236] Better translatibility in "Connect biblio.biblionumber to a MARC subfield" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45106|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45159&action=edit Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield" This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect biblio.biblionumber to a MARC subfield") for better translatability. To test: - Apply patch - Go to Home > Administration < Koha to MARC mapping and edit a tag - Verify that text change makes sense Signed-off-by: Hector Castro Rewording Ok for translation purposes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:22:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:22:11 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Christopher Bloomfield changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c_bloomfield_ at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:23:09 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:23:11 +0000 Subject: [Koha-bugs] [Bug 15237] Quote of the day: Better translatibility for editor and help In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45107|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 45160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45160&action=edit Bug 15237: Quote of the day: Better translatibility for editor and help This patch moves html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor). To test: - Apply patch - Go to Home > Tools > Quote Editor and related Help - Verify that text changes make sense. Signed-off-by: Hector Castro Rewording Ok for translation purposes Signed-off-by: Jonathan Druart Amended patch: Make consistent space after "Note:" (inside the br tag) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:27:30 +0000 Subject: [Koha-bugs] [Bug 15229] Tiny typo: This patrons is ... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tiny typo:This patrons is |Tiny typo: This patrons is |... |... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:27:52 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Marc, I am not sure the "Note" is necessary for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:27:53 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Jesse Lambertson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding 880 Fields to |Adding 880 Fields to |index-list in order to |index-list in order to |increase Search or RTL |Increase Search for ALL |Script (Arabic) |non-latin Scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:29:29 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45153|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Created attachment 45161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45161&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:30:31 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- -

        The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.

        +

        The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.

        Why did you remove the end of the sentence? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:36:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:36:51 +0000 Subject: [Koha-bugs] [Bug 15255] New: Deleted items still visible in search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15255 Bug ID: 15255 Summary: Deleted items still visible in search results Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kabevis at ccrwest.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:41:46 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:41:49 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 --- Comment #6 from Jonathan Druart --- Created attachment 45162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45162&action=edit Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:47:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:47:19 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:47:21 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45118|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45163&action=edit Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:47:42 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45163|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45164&action=edit Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading The system preference AllowPkiAuth display under the heading CAS authentication, but is actually a separate authentication option. Patch creates a separate heading for it. To test: - Go to Administration > System preferences > Tab Administration - Verify that AllowPkiAuth is now displayed separately Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:47:47 +0000 Subject: [Koha-bugs] [Bug 15101] Don't display system preference AllowPkiAuth under heading CAS Authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15101 --- Comment #5 from Jonathan Druart --- Created attachment 45165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45165&action=edit Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:49:55 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:49:58 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45090|0 |1 is obsolete| | Attachment #45116|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 45166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45166&action=edit Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:50:02 +0000 Subject: [Koha-bugs] [Bug 15228] Patron card batches - Improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #6 from Jonathan Druart --- Created attachment 45167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45167&action=edit Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:54:12 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #68 from Jonathan Druart --- (In reply to Jonathan Druart from comment #67) > (In reply to Jonathan Druart from comment #15) > > QA comment: > > 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues > > subroutine in C4::Overdues. > > Was valid for HasOverdues too. > See bug 15135. This is still valid, please fix. returns.pl: Subroutine HasOverdues redefined at /home/koha/src/Koha/Template/Plugin/Borrowers.pm line 52 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 17:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 16:55:16 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > -

        The column Koha field shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, or a Koha interface. This link > ensures that both DB are synchronized, thus you can change from a MARC to a > Koha interface easily.

        > > +

        The column 'Koha field' shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, and a Koha interface. This link > ensures that both DB are synchronized.

        > > Why did you remove the end of the sentence? Oh, sorry, that was a mistake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:02:23 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45161|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 45168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45168&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer Thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:02:35 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #11 from Katrin Fischer --- Created attachment 45169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45169&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:08:32 +0000 Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15256 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 [Bug 15256] Items table on detail page can be broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:08:32 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15256 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 [Bug 15256] Items table on detail page can be broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:08:32 +0000 Subject: [Koha-bugs] [Bug 15256] New: Items table on detail page can be broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Bug ID: 15256 Summary: Items table on detail page can be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Cataloging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 14354, 14966 Bug 14966 fixed a bug bug introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354 [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 [Bug 14966] Table header broken at detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:08:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:08:56 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #12 from Katrin Fischer --- Hi Fridolin - thx to your testing we found 2 more bugs. I added another follow-up and retested all patches together in MARC21 and UNIMARC. Can you please test again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:11:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:11:39 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:11:41 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 --- Comment #1 from Jonathan Druart --- Created attachment 45170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45170&action=edit Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:13:01 +0000 Subject: [Koha-bugs] [Bug 15255] Deleted items still visible in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15255 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Kimberlee, can you please add some more information? - Is it items or records? - Did you withdraw or delete them? - Where are they showing up, only on the results, but not on the datail page? If it's the search results, it's most likely that your Zebra index hasn't been update with the deletion yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:15:35 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |liz at catalyst.net.nz --- Comment #2 from Jonathan Druart --- @RM 3.20: Should be backported. @RM 3.18: Should be backported with bug 14966. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:18:32 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #83 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #82) > (In reply to Jonathan Druart from comment #80) > > (In reply to Bernardo Gonzalez Kriegel from comment #79) > > > Hi Jonathan, > > > all patches apply, last patch signeed. > > > I have a followup to remove some tabs/spaces > > > > Where? > > > I attached a patch with fixes needed by koha-qa Thanks, added to the remote branch. Feel free to switch the status to Signed Off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:41:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:41:00 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #11 from bondiurbano --- This solution fixes bug#10827 "List of holds does not update correctly". If you agree I will set it as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:43:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:43:10 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #12 from Katrin Fischer --- (In reply to bondiurbano from comment #11) > This solution fixes bug#10827 "List of holds does not update correctly". If > you agree I will set it as RESOLVED. Maybe better to mark it as a duplicate. I wouldn't set it resolved until a solution has made it into master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:45:49 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #13 from bondiurbano --- Thanks Katrin. I will do it in that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:48:23 +0000 Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #40 from bondiurbano --- See bug#14364. *** This bug has been marked as a duplicate of bug 14364 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:48:23 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #14 from bondiurbano --- *** Bug 10827 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:51:55 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:51:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:51:57 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 --- Comment #1 from Katrin Fischer --- Created attachment 45171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45171&action=edit Bug 15250: Fix Perl error on acqisition stats page To test: - Go to reports -> Acquisitions statistics - Populate with the following values: Acquisitions statistics Received on. Row: checked Column: checked From: 01/01/2015 To: Un-selected Cell value Count items Output: To screen into the browser: checked - Running the report will trigger the following error: Software error: Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293. - Apply the patch and repeat test - Verify the report now works correctly Note: Patch was created from notes and suggested fix on the bug report, written by Barton Chittenden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 18:52:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 17:52:09 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:03:46 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #6 from Kyle M Hall --- Created attachment 45172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45172&action=edit Bug 15135 [QA Followup] - Switch from use to require -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:03:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:03:43 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:24:36 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:24:38 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45171|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 45173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45173&action=edit Bug 15250: Fix Perl error on acqisition stats page To test: - Go to reports -> Acquisitions statistics - Populate with the following values: Acquisitions statistics Received on. Row: checked Column: checked From: 01/01/2015 To: Un-selected Cell value Count items Output: To screen into the browser: checked - Running the report will trigger the following error: Software error: Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293. - Apply the patch and repeat test - Verify the report now works correctly Note: Patch was created from notes and suggested fix on the bug report, written by Barton Chittenden. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:25:17 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #11 from Chetan Panchal --- Thanks Kartin, I understood the problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:35:58 +0000 Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 19:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 18:42:23 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #84 from Bernardo Gonzalez Kriegel --- Checked opac and staff pages (not all), no problems found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 20:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 19:54:26 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- FOR FURTHER REFERENCE: "Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820" is also triggered if the font, mentioned in the ttf section in the koha-conf.xml file, is NOT INSTALLED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 20:56:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 19:56:36 +0000 Subject: [Koha-bugs] [Bug 15255] Deleted items still visible in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15255 Kimberlee Bevis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Kimberlee Bevis --- My apologies, this is my 1st post here & I should have been more specific. Complete bibliographic records and their items that have been deleted are remaining in the search results but not on the details page. It has never taken so long (2 days) for the deleted records to disappear. It usually happens instantly. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 21:03:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 20:03:37 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > Marc, I am not sure the "Note" is necessary for this one. Jonathan, no problem, feel free to leave it away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 21:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 20:04:15 +0000 Subject: [Koha-bugs] [Bug 15255] Deleted items still visible in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15255 --- Comment #3 from Katrin Fischer --- This looks like a problem with your indexing. A bug report is not a good place to help with that - best would be if you'd posted your question on the mailing list, including your Koha version and how it was installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 21:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 20:32:04 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca --- Comment #9 from Marjorie Barry-Vila --- (In reply to Kyle M Hall from comment #7) > Created attachment 35335 [details] [review] > [PASSED QA] Bug 13528: Use the different isbn variations on search on the > isbn index (nb) > > This enhancement adds the ability to search on all isbn variations when > searching on the isbn index. > > Test plan: > 0/ Don't apply the patch > 1/ Create or choose a notice with an isbn with dashes. > 2/ Try to search the notice using the isbn index by it isbn without > dashes. > => It does not work. > 3/ Apply the patch, enable the new pref SearchWithISBNVariations and > disable UseQueryParser. > 4/ repeat 2 and note that the record is now returned. > > Note that this only works if UseQueryParser is disabled. > It looks like QueryParser does not manage more than 1 operator. > See: > QueryParser does not manage more than 1 operator? > > http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028. > html > and > commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 > Author: Galen Charlton > Date: Mon May 5 19:31:00 2014 +0000 > Bug 10500: (follow-up) disable AggressiveMatchOnISBN if > UseQueryParser is on > > Signed-off-by: Morag Hills > > Signed-off-by: Kyle M Hall Hi Kyle, Can you tell me if your improvement also works for research in the acquisition module? acqui/histsearch.pl Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 21:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 20:33:37 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 --- Comment #7 from Liz Rea --- This was released in 3.18.12 - sorry I missed it when I was updating bugs. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 23:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 22:06:34 +0000 Subject: [Koha-bugs] [Bug 15257] New: authority records imported via z39.50 don't get authid in the 001 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15257 Bug ID: 15257 Summary: authority records imported via z39.50 don't get authid in the 001 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: rocio at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When importing an authority record via z39.50, the authid assigned to the record by Koha doesn't get put into the 001 tag. The authid *is* correctly assigned to the authority record, it just doesn't get put into the 001 in the marcxml. Using z39.50, the authority record retains whatever data was in that 001 field originally. When one of these authorities is linked, the actual authid is used in the link to the bib record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 23:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 22:45:46 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 25 23:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 22:45:48 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45162|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 45174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45174&action=edit [SIGNED OFF] Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 00:34:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 23:34:35 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 00:34:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 23:34:38 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45128|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 45175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45175&action=edit Bug 15216: Returns - Show collection description The table of returns displays the collection code instead of the description. This patch fixes that. Same as first patch: To test: - Check out some items - Return the items - Verify the changes in the table of returned items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 00:47:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 23:47:35 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 00:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Nov 2015 23:50:06 +0000 Subject: [Koha-bugs] [Bug 15097] Update MARC21 de-DE frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 02:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 01:25:18 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45073|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 45176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45176&action=edit [SIGNED-OFF]Bug 9184: Acq - Don't show authority batches when ordering from staged file When ordering from a staged file, the list of files should only include imports of bilbiographic and no authority data. To test - start without the patch: 1) Stage an authority file 2) Stage a bilbiographic file 3) Create a new basked in acquisitions 4) Create a new order line selecting "From a staged file" 5) Verify that both files are shown 6) Apply patch 7) Verify that only the bibliographc file shows in the list now Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 02:25:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 01:25:37 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:25:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:25:04 +0000 Subject: [Koha-bugs] [Bug 15258] New: Prevent unused declared variables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Bug ID: 15258 Summary: Prevent unused declared variables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: frederic at tamil.fr QA Contact: gmcharlt at gmail.com Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:25:30 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:29:38 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:29:40 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 --- Comment #1 from Fr?d?ric Demians --- Created attachment 45177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45177&action=edit Bug 15258 Fix Perl scripts declaring unused variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:30:04 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 --- Comment #2 from Fr?d?ric Demians --- Created attachment 45178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45178&action=edit Bug 15258 Fix Perl scripts declaring unused variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 08:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 07:31:03 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45178|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 45179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45179&action=edit Bug 15258 Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 09:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 08:10:46 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- Hi Katrin, I wanted to test but the patch does not apply. Could it be that there is one patch to much that is obsoleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 09:11:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 08:11:23 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45128|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 09:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 08:12:02 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 --- Comment #7 from Katrin Fischer --- I restored the first patch - thx Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 10:06:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 09:06:25 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45175|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 45180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45180&action=edit Bug 15216: Returns - Show collection description The table of returns displays the collection code instead of the description. This patch fixes that. Same as first patch: To test: - Check out some items - Return the items - Verify the changes in the table of returned items Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 10:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 09:06:52 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 11:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 10:39:01 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk --- Comment #2 from Emma Perks --- Still valid. Requested by library staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 11:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 10:49:33 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Giannis Tsakonas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |john at lis.upatras.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 11:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 10:53:25 +0000 Subject: [Koha-bugs] [Bug 15259] New: Formatting spine labels Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259 Bug ID: 15259 Summary: Formatting spine labels Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: john at lis.upatras.gr QA Contact: testopia at bugs.koha-community.org According to the manual it is possible, when creating spine labels from "Tools > Labels home > Manage label layouts > Edit Label layout", to have static text in single quote marks, such as "mytext". It seems though that when placed in the layout editor and the "Bibliographic data to print > Field list" the static text and a field/subfield name can not go in one comma delimited section, i.e. 'mytext' copy number = c. 1 (when 1 is taken by 852t). In order for static text to work it needs to be separated by another comma, which breaks the line and it is not what exactly we would be ideal to have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 15:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 14:57:37 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 15:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 14:58:29 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40843|0 |1 is obsolete| | Attachment #40844|0 |1 is obsolete| | Attachment #40845|0 |1 is obsolete| | --- Comment #16 from Charles Farmer --- Created attachment 45181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45181&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues This is a squash of the previous three patches, with capitalization of the syspref 'ClaimsBccCopy' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 15:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 14:59:45 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com Assignee|maxime.beaulieu at inlibro.com |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 18:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 17:32:31 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 18:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 17:32:44 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35264|0 |1 is obsolete| | --- Comment #12 from Charles Farmer --- Created attachment 45182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45182&action=edit Bug: 11358 - Use HTTPS Amazon images everywhere Tried to solve the conflicts. Additionnaly, edited files that were still using "http://images.amazon.com". Please test thoroughly. Using HTTPS on an HTTP page shouldn't trigger security issues. I pruned some templates to use HTTPS whenever we're fetching an image from Amazon instead of switching on the using_https variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 18:35:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 17:35:43 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 18:35:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 17:35:47 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45181|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Created attachment 45183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45183&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Signed-off-by: Fr?d?ric Demians Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:44:24 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41477|0 |1 is obsolete| | Attachment #41478|0 |1 is obsolete| | Attachment #41479|0 |1 is obsolete| | Attachment #41480|0 |1 is obsolete| | Attachment #41855|0 |1 is obsolete| | Attachment #42126|0 |1 is obsolete| | --- Comment #12 from Eivin Giske Skaaren --- Created attachment 45184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45184&action=edit Bug 12772: tmp commit rename db updatefile back to .pl for 12772 The file needs to be renamed so that the next patch can go through. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:44:41 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #13 from Eivin Giske Skaaren --- Created attachment 45185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45185&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:44:59 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #14 from Eivin Giske Skaaren --- Created attachment 45186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45186&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:45:10 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #15 from Eivin Giske Skaaren --- Created attachment 45187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45187&action=edit Bug 12772 - Reworked overdue_notices.pl script modified: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:45:26 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #16 from Eivin Giske Skaaren --- Created attachment 45188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45188&action=edit Bug 12772 - Renames atomic update file, .pl -> .perl renamed: update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:45:34 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #17 from Eivin Giske Skaaren --- Created attachment 45189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45189&action=edit Bug 12772 - Fix warnings This commit fixes a bunch of warnings for verbose messages which would clutter up the output. They should not affect normal excution. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 19:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 18:45:43 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #18 from Eivin Giske Skaaren --- Created attachment 45190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45190&action=edit Bug 12772 - Fix rule updates Overduerules ID was not sent correctly when editing rules, resulting in rule being cleared instead of updated. This patch fixes this issue, and a couple of uninitilized values as a bonus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:01:27 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45184|0 |1 is obsolete| | Attachment #45185|0 |1 is obsolete| | --- Comment #19 from Eivin Giske Skaaren --- Created attachment 45191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45191&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:01:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:01:39 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45186|0 |1 is obsolete| | --- Comment #20 from Eivin Giske Skaaren --- Created attachment 45192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45192&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:01:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:01:46 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45187|0 |1 is obsolete| | --- Comment #21 from Eivin Giske Skaaren --- Created attachment 45193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45193&action=edit Bug 12772 - Reworked overdue_notices.pl script modified: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:01:54 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45188|0 |1 is obsolete| | --- Comment #22 from Eivin Giske Skaaren --- Created attachment 45194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45194&action=edit Bug 12772 - Renames atomic update file, .pl -> .perl renamed: update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:02:01 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45189|0 |1 is obsolete| | --- Comment #23 from Eivin Giske Skaaren --- Created attachment 45195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45195&action=edit Bug 12772 - Fix warnings This commit fixes a bunch of warnings for verbose messages which would clutter up the output. They should not affect normal excution. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:02:08 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45190|0 |1 is obsolete| | --- Comment #24 from Eivin Giske Skaaren --- Created attachment 45196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45196&action=edit Bug 12772 - Fix rule updates Overduerules ID was not sent correctly when editing rules, resulting in rule being cleared instead of updated. This patch fixes this issue, and a couple of uninitilized values as a bonus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:12:36 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #25 from Eivin Giske Skaaren --- Created attachment 45197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45197&action=edit Bug 12772: Add back file so next patch does not fail This file is needed so that Update Database (Based in Bug13624) can succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:14:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:14:53 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45197|0 |1 is obsolete| | --- Comment #26 from Eivin Giske Skaaren --- Created attachment 45198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45198&action=edit Bug 12772: Add back file so next patch does not fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:14:57 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45191|0 |1 is obsolete| | --- Comment #27 from Eivin Giske Skaaren --- Created attachment 45199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45199&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:01 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45192|0 |1 is obsolete| | --- Comment #28 from Eivin Giske Skaaren --- Created attachment 45200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45200&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:05 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45193|0 |1 is obsolete| | --- Comment #29 from Eivin Giske Skaaren --- Created attachment 45201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45201&action=edit Bug 12772 - Reworked overdue_notices.pl script modified: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:09 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45194|0 |1 is obsolete| | --- Comment #30 from Eivin Giske Skaaren --- Created attachment 45202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45202&action=edit Bug 12772 - Renames atomic update file, .pl -> .perl renamed: update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:13 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45195|0 |1 is obsolete| | --- Comment #31 from Eivin Giske Skaaren --- Created attachment 45203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45203&action=edit Bug 12772 - Fix warnings This commit fixes a bunch of warnings for verbose messages which would clutter up the output. They should not affect normal excution. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:17 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45196|0 |1 is obsolete| | --- Comment #32 from Eivin Giske Skaaren --- Created attachment 45204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45204&action=edit Bug 12772 - Fix rule updates Overduerules ID was not sent correctly when editing rules, resulting in rule being cleared instead of updated. This patch fixes this issue, and a couple of uninitilized values as a bonus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:15:31 +0000 Subject: [Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 --- Comment #1 from Mirko Tietgen --- Created attachment 45205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45205&action=edit Bug 15225: Make HTML5Media work with file upload feature. Koha::Upload allows files to be attached to bibliographic records. HTML5Media streaming in Koha does not work with these files. Test plan: - apply patch - make sure OPACBaseURL is set correctly - enable HTML5MediaEnabled in OPAC and staff client - connect upload.pl to 856$u in your framework - upload a file with an extension set in HTML5MediaExtensions, make sure to set the codec correctly if you use WEBM (subfield c, eg. 'vp8, vorbis') - save record, view in staff client and browser, check if 'Play media' option is available and works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:16:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:16:46 +0000 Subject: [Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:17:35 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 --- Comment #13 from M. Tompsett --- (In reply to Charles Farmer from comment #12) > Please test thoroughly. Can't test thoroughly WITHOUT A TEST PLAN. See comment #3, comment #6, comment #11. I keep asking for one, and keep not getting one. Post a thorough test plan, and I will test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 20:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 19:18:02 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eivin at sysmystic.com --- Comment #33 from Eivin Giske Skaaren --- Sorry for the clutter of updates. This was a bit of a tricky rebase but the patch now applies again. Remember that applying 13624 is a prereq for applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 22:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 21:04:06 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 26 22:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 21:04:08 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45170|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 45206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45206&action=edit Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. Signed-off-by: Fr?d?ric Demians See the warning, and the broken table. Solved by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 00:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 23:12:20 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 00:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 23:12:23 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45206|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 45207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45207&action=edit [PASSED QA] Bug 15256: Fix items table display on the detail page Bug 14966 fixed a bug but introduced another one: With IndependentBranches set to 'prevent', if the librarian (without the superlibrarian permission) can edit items but not all, the table is broken. DataTables raises the following warning: "DataTables warning: table id=DataTables_Table_1 - Requested unknown parameter '8' for row0." And does not display correctly. Test plan: 1/ Create a biblio record with 1+ items located in different places. 2/ Create/use a patron with the permission to edit items 3/ Set the IndependentBranches pref to 'prevent' 4/ With this patron logged in, go on the record detail page. Without this patch, the display is broken (only 1 edit link and 1 td missing, DataTables raises a warning). With this patch, the display is correct. Signed-off-by: Fr?d?ric Demians See the warning, and the broken table. Solved by this patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 00:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Nov 2015 23:21:46 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #14 from Charles Farmer --- Test plan (do all these tests on HTTP) To test the changes in staff-global.css, doc-head-close.inc and amazonimages.js : 1) Go to your INTRANET 2) Under the search bar, click on "Search the catalog" 3) Enter a criteria for which you'll get more than one result 4) Documents without an amazon image should have a "No cover image available" placeholder 5) (hard part) Somehow, disable javascript in your browser 1) Under firefox, click F12 2) Click the gear icon at the top right side of the developer interface (4th item from the right) 3) Under "Advanced settings", you'll find "Disable javascript": Click it. 6) After a forced page reload, instead of a placeholder image, you should see a 1x1 image. Intranet: 1) Go to your INTRANET 2) Under the search bar, click on "Search the catalog" 3) Enter a criteria for which you'll get more than one result 4) Click on an entry with a visible image 5) The *amazon-bookcoverimg* should come from https://images-na.ssl-images-amazon.com/ OPAC: 1) Go to your OPAC 2) Search the library catalog for something 1) Images in the result page should be HTTPS 3) Click on anything with an amazon image 4) The opac-detail page should show an HTTPS image 5) On the bottom of the page, open the shelf browser 1) The image should be in HTTPS there too === 1) Go to the page http:///cgi-bin/koha/opac-showreviews.pl 2) Book images should be in HTTPS ////////// To be quite honest, I don't know where opac-results-grouped.tt is used. I will leave this as an exercise for the reader. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 02:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 01:12:02 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high --- Comment #146 from Liz Rea --- This is a must for 3.24. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 05:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 04:29:19 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #20 from Bob Birchall --- Given Mason's comments, does this still need to be in Failed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 07:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 06:52:03 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- Does this patch need to be backported to 3.20.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 08:17:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 07:17:23 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- Is this patch needed on 3.20.x branch for its test suite? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 08:40:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 07:40:59 +0000 Subject: [Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Depends on| |14676 --- Comment #5 from Fr?d?ric Demians --- Can't be backported to 3.20.x because depends on bug 14676. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 [Bug 14676] UI/UX enhancements for the patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 08:40:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 07:40:59 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15112 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112 [Bug 15112] Make greybox consistent size across label and patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 10:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 09:15:08 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- I don't understand whether this patch can/must be backported to 3.20.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:27:06 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Alex Arnaud --- (In reply to Fr?d?ric Demians from comment #6) > Code review: > > You have: > > function CalculateAge(dateofbirth) { > > Then, you don't use "dateofbirth". > > You have: > > onchange="CalculateAge(document.form.dateofbirth);" > value="[% UNLESS opduplicate %][% dateofbirth %][% END %]" /> > > You rather should use jQuery: > > $( "#dateofbirth" ).change(CalculateAge); You are right. I forgot to remove the function parameter. Using "$("#dateofbirth").datepicker( 'getDate' )" is bettre because it gives me the correct date format > > From an UI point of view, it seems awkward to have displayed firstly > "DD/MM/YYYY" under the Date of birth text box, and then having this info > replaced by the age. This way, it's not possible to see the age without > modifying the date of birth. Wouldn't it be better/simpler to display the age > on the detail page (moremember.pl), rather than on the editing page > (memberentry.pl)? The main goal is to have directly the age under the datepiker while typing the date of birth. This allows librarian, for example, to change the category consequently > > Have you seen that there is already a Perl function calculating age in Koha? > C4::Members::GetAge(). There is a risk that your javascript code and Perl > GetAge() produce a different age. So, i should make an Ajax call to a perl script to use this existing sub. But why not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:31:56 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #45017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:35:03 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #13 from Mirko Tietgen --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10407 - allow MARCXML records to be imported via Koha's GUI fatal: sha1 information is lacking or useless (C4/ImportBatch.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10407 - allow MARCXML records to be imported via Koha's GUI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:52:08 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #8 from Fr?d?ric Demians --- > The main goal is to have directly the age under the datepiker while typing > the date of birth. This allows librarian, for example, to change the > category consequently OK. Interesting for librarian, indeed. Would be great to have it also on borrower detail page. > > Have you seen that there is already a Perl function calculating age in Koha? > > C4::Members::GetAge(). There is a risk that your javascript code and Perl > > GetAge() produce a different age. > So, i should make an Ajax call to a perl script to use this existing sub. > But why not With Koha brand new REST API... Or you can alternatively do it JS but adding some tests to guaranty consistency. I even see in my crystal ball GetAge() modified to delegate to MySQL the age calculation for stability reason. For example: SELECT TIMESTAMPDIFF(YEAR,'2010-09-10',CURDATE()) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:58:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:58:53 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 11:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 10:58:57 +0000 Subject: [Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45156|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 45208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45208&action=edit [PASSED QA] Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Fr?d?ric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 12:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 11:28:11 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #103 from Katrin Fischer --- Working on this again now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 13:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 12:12:49 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Josef Moravec --- Could you please rebase and change the icon to Font Awesome icon? See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 13:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 12:15:40 +0000 Subject: [Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Fr?d?ric Demians from comment #10) > Is this patch needed on 3.20.x branch for its test suite? I don't think so. It is part of a bigger tests rewrite. If it applies, it shouldn't harm and could help make jenkins stable for 3.20. But maybe it is not worth the trouble. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 13:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 12:19:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #147 from Josef Moravec --- I agree, but rebase needed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 14:32:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 13:32:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #148 from Blou --- Will be done today. We will never surrender... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:23:50 +0000 Subject: [Koha-bugs] [Bug 15260] New: Option for extended loan with useDaysMode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Bug ID: 15260 Summary: Option for extended loan with useDaysMode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org Could an option be introduced for holiday closures where the due date is set to be the next matching open day? (Matching means Monday = Monday, Tuesday = Tuesday etc.) There are currently 3 options with holiday dates using useDaysMode syspref: 1) Circulation rules only = no change to expected due date 2) Calendar to push the due date to next open day = due date changed to next open day 3) Calendar to skip all days the library is closed = extra days - equivalent to closed days - added We use 21 days as our loan period. When a due date falls on a closed day, we would like to offer a loan on the next matching open day - e.g. a 28 day loan, not a 22 day loan. If an item is borrowed on Monday 1st June, it would ordinarily be due on Monday 22nd June (21 day loan as standard). If a library was closed on Monday 22nd June, we would like the due date to be Monday 29th June (28 day loan) - not Tuesday 23rd June (22 day loan). This isn't just a 7 day push on because of Christmas holidays. For example: Items borrowed on Friday 4th December should be due back Friday 25th December. Friday 25th December is closed. A 28 day loan would cause the items to be due back on Friday 1st January. Friday 1st January is closed. We would like the loan to be pushed to 35 days to the next Friday that the library is open = Friday 8th January, even though the library is open for business on non-matching (Monday, Tuesday, Wednesday etc) days between those dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:24:00 +0000 Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:25:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:26:07 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44323|0 |1 is obsolete| | --- Comment #149 from Charles Farmer --- Created attachment 45209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45209&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron New sign-off after testing all patches together Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:28:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44324|0 |1 is obsolete| | Attachment #44325|0 |1 is obsolete| | Attachment #44326|0 |1 is obsolete| | Attachment #44327|0 |1 is obsolete| | Attachment #44329|0 |1 is obsolete| | Attachment #44330|0 |1 is obsolete| | --- Comment #150 from Charles Farmer --- Created attachment 45210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45210&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:29:07 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #151 from Charles Farmer --- Created attachment 45211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45211&action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:29:15 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #152 from Charles Farmer --- Created attachment 45212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45212&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:29:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:29:23 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #153 from Charles Farmer --- Created attachment 45213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45213&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:29:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #154 from Charles Farmer --- Created attachment 45214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45214&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message Problems with Math/Random/Secure.pm, is solved in following patch, signing off Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:29:41 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #155 from Charles Farmer --- Created attachment 45215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45215&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:33:04 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #156 from Charles Farmer --- I had to resubmit every patches because the first one had the merge conflicts. If anybody knows how to obsolete the first patch of a queue without messing the queue order, let me know, it would be appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 15:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 14:33:54 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Fr?d?ric Demians from comment #5) > I don't understand whether this patch can/must be backported to 3.20.x. As I see it, this has been bothering the Packaging manager for a while. He did some trick on building so the process (which runs the tests in t/) doesn't break. If it applies on 3.20, it is a good thing to do (backporting it). But maybe ask Galen, the new packaging manager. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 16:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 15:16:07 +0000 Subject: [Koha-bugs] [Bug 15261] New: Verify if checkouts or reserves requests periods overlap with existing reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Bug ID: 15261 Summary: Verify if checkouts or reserves requests periods overlap with existing reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 16:16:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 15:16:22 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 16:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 15:20:46 +0000 Subject: [Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 --- Comment #7 from Fr?d?ric Demians --- (In reply to Tom?s Cohen Arazi from comment #6) > If it applies on 3.20, it is a good thing to do (backporting it). > But maybe ask Galen, the new packaging manager. This patch touches several tests that have changed (more tests). So the backporting is tricky. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 16:49:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 15:49:41 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #1 from Julian Maurice --- Created attachment 45216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45216&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 16:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 15:50:29 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 22:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 21:00:14 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41689|0 |1 is obsolete| | Attachment #42133|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 45217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45217&action=edit Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 22:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 21:00:33 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 22:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 21:10:02 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 --- Comment #6 from H?ctor Eduardo Castro Avalos --- (In reply to Aleisha Amohia from comment #4) > Created attachment 42133 [details] [review] > Bug 10468: Fix for qa tools > > Hopefully this gets rid of those complaints! Hi Aleisha I squashed the two patches and I've signed-off also patches did not apply due the changes introduced by Bug 15068, but i fixed it up. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 22:41:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 21:41:06 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39477|0 |1 is obsolete| | Attachment #39478|0 |1 is obsolete| | Attachment #39479|0 |1 is obsolete| | Attachment #40831|0 |1 is obsolete| | Attachment #41229|0 |1 is obsolete| | --- Comment #22 from Bouzid --- Created attachment 45218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45218&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 27 23:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Nov 2015 22:07:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #157 from Josef Moravec --- I think that files kohastructure.sql and sysprefs.sql, should be updated too, not only to add atomicupdate sql file... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 28 15:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Nov 2015 14:12:49 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #6 from Tom Misilo --- Did this make it into 3.22? Or was it pushed back to the next release? I didn't notice it in the release notes. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 28 15:15:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Nov 2015 14:15:34 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #85 from Bernardo Gonzalez Kriegel --- Mmm, some problems editing records and items There is a strange display on edit/add On items it can be fixed with something like --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -225,9 +225,9 @@ function confirm_deletion() { [% FOREACH ite IN item %]
      • [% ite.subfield %] - [% ite.marc_lib %] + [% ELSE %] - + [% END %] [% SET mv = ite.marc_value %] @@ -258,7 +258,7 @@ function confirm_deletion() { [% ELSE %] ... [% END %] - [%- mv.javascript -%] + [%- mv.javascript.raw -%] [% ELSIF ( mv.type == 'text' ) %] References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #15 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:20:54 +0000 Subject: [Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123 --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:22:09 +0000 Subject: [Koha-bugs] [Bug 14157] Show notices tab with EnhancedMessagingPreferences deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:23:34 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #17 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:24:41 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:25:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:25:31 +0000 Subject: [Koha-bugs] [Bug 15117] There is no translation of confirm dialog when transfering a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15117 --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:27:20 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. (1st patch but not the followup.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:28:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:28:10 +0000 Subject: [Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:35:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:35:06 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:36:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:36:03 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:36:46 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:37:28 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #18 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:43:59 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:44:54 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:47:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:47:03 +0000 Subject: [Koha-bugs] [Bug 14743] addorder.pl redirect problems under plack behind apache 2.4.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:48:20 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #16 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:49:03 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:52:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:52:07 +0000 Subject: [Koha-bugs] [Bug 14735] cache_expiry is not saved when updating a SQL report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:53:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:53:11 +0000 Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:54:09 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:54:58 +0000 Subject: [Koha-bugs] [Bug 14795] Batch record modification tool removes framework code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:56:02 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:56:57 +0000 Subject: [Koha-bugs] [Bug 15137] List email sent from staff is missing ISBN and author information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 21:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 20:57:42 +0000 Subject: [Koha-bugs] [Bug 15154] Allow correct translation for upload local cover image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:00:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:00:09 +0000 Subject: [Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:00:34 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #17 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:01:29 +0000 Subject: [Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:02:08 +0000 Subject: [Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133 --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:07:29 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #23 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:08:10 +0000 Subject: [Koha-bugs] [Bug 15109] Regression in patron search results ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:08:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:08:45 +0000 Subject: [Koha-bugs] [Bug 15189] The batch records modification tool should not close STDERR when running in background mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15189 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:09:19 +0000 Subject: [Koha-bugs] [Bug 15114] warning on purchase suggestions is inaccurate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15114 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:09:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:09:59 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:10:40 +0000 Subject: [Koha-bugs] [Bug 15175] IntranetBiblioDefaultView syspref is not respected when XSLTResultsDisplay is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15175 --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:11:24 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #41 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:11:58 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:12:29 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #32 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:13:05 +0000 Subject: [Koha-bugs] [Bug 15215] Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:13:36 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:48:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:48:29 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #54 from Barton Chittenden --- I'm wondering if this can get pushed into 3.18? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 22:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 21:50:59 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #23 from Barton Chittenden --- Is it possible to port this back to 3.18? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 23:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 22:08:27 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #45 from Leif Andersson --- Have you ever considered "exporting" some of the marc fields to a separate mysql table? What I am thinking of is those fields that most likely will be used for duplicate detection: 001, 003, 020, 022, 035 We could than do the necessary matching without involving zebra. In most cases I'd imagine. To be useful this would have to be applied on all imports, not only OAI. Such a table could also be used to save the information of the origin of a record - if that is desired. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 29 23:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 22:16:16 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 --- Comment #24 from David Cook --- Just took a look at https://github.com/alexrj and it seems that the author of Crypt::GCrypt is ignoring the issue I raised as there's no response but he's still pushing commits to other repositories... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 00:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 23:22:03 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #46 from David Cook --- (In reply to Leif Andersson from comment #45) > Have you ever considered "exporting" some of the marc fields to a separate > mysql table? What I am thinking of is those fields that most likely will be > used for duplicate detection: 001, 003, 020, 022, 035 > We could than do the necessary matching without involving zebra. In most > cases I'd imagine. > Yes, I've thought about this a bit. The 020 and 022 can already be found in biblioitems.isbn and biblioitems.issn respectively. Unfortunately, they store multiple values in the same field which is suboptimal in this case although not impossible to use... For a while, I've been thinking that it would be nice to store the 001 somewhere and perhaps the 035. I think the problem with that is we're in a place where we actually want to be moving away from MARC... not entrenching it further. So I don't think we should really add to the biblio or biblioitems tables. Of course, there could be a way around that by making a generic "metadata" table. Something like... metadata.id, metadata.record_id, metadata.scheme, metadata.qualifier, metadata.value. So that would look like: 1, 1, marc21, 001, 123456789 I think that's actually very similar to what they do in DSpace, and I've seen other library systems store their MARC records in a similar way. > To be useful this would have to be applied on all imports, not only OAI. > Well, it would actually need to be applied to _all records_ rather than _all imports_. You'd need that data filled for all records if you were going to match properly. > Such a table could also be used to save the information of the origin of a > record - if that is desired. Actually, that's a good point. We could do something like: metadata.id, metadata.record_id, metadata.scheme, metadata.qualifier, metadata.value. 2, 1, koha, record_origin, oai-pmh Actually, in retrospect, it would be wise to add another field like "metadata.record_type" for biblio, authority, and item. -- I think there are some potential obstacles to this approach though: 1) Ideally, it would be discussed with the Koha community and Release Manager to see if this table could be used by other existing parts of Koha and new features 2) It would need to be added to the existing record Add/Mod/Del functions. This isn't necessarily a huge obstacle... 3) The table would need to be populated initially... for databases with millions of records, this would be a very time-consuming process. Since it would be an intensive process, I think perhaps it would need to be run at the discretion of a system administrator. I think the "touch_all_biblios.pl" script would actually take care of this process, since we'd be updating the Add/Mod/Del functions, so the "metadata" table would be populated by running that script. 4) How to decide which fields should be "exported" into this table? While we could provide configuration for this, configuration changes would require "touch_all_biblios.pl" to be run again for the "metadata" fields to be generated correctly. Perhaps having a backend configuration file would be the best in this case, as the person editing it would also be someone who could re-generate the "metadata" table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 00:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Nov 2015 23:41:13 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #47 from David Cook --- Leif and Andreas: If I understand correctly, your main use case for matching would be to make sure that records previously imported from the union catalogue aren't duplicated when you start using OAI-PMH, yes? In that case, would matching on the 001 be suitable? You could configure your OAI-PMH importer module to look for "metadata.value == incoming record 001" and update the matching record. That would prevent duplication in this situation. I think in that situation it would also be good to add a "metadata.value" for the unique OAI-PMH Identifier... and only update a record if it has no OAI-PMH identifier or if it has a OAI-PMH Identifier that matches the incoming record. That way, you might prevent different OAI-PMH repositories from updating each other's records if you're matching using 020 instead of 001. Since I want the OAI-PMH importer to be plugin based, the rules will be customizable. But if we're not going to use Zebra or some other third-party index, I think Leif's suggestion of a new "exported" metadata table might be necessary. Failing that "metadata" table... there is the "import_biblios", "import_items", and "import_auths" tables which might be re-purposed. "import_biblios" and "import_auths" both have a "control_number" field which I think may be unused... but that won't work in the case that you already have records in Koha which need to expose data for matching. In an effort to move this matching discussion along, I'm going to submit a message to the koha-devel listserv as well to discuss the "metadata" table idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 01:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 00:43:13 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #48 from David Cook --- Of course, adding a "metadata" table might not be a great idea, because it would be "yet another place" that we store metadata. There's already biblioitems.marcxml (and the soon to be removed biblioitems.marc), Zebra, biblio/biblioitems/items relational fields. I think "metadata" might be a good idea as a long-term shift, but it might be met with resistance in the short-term. That said, if we're going to move away from MARC, surely we need to start transitioning to infrastructure which is independent of MARC. But that's why I think we need community discussion and a decision (not necessarily consensus) on the best way to proceed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 09:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 08:28:07 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 10:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 09:33:48 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15240 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 [Bug 15240] Performance issue running overdue_notices.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 10:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 09:33:48 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12529 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 [Bug 12529] Overdue notices do not respect holidays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 11:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 10:09:18 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #1 from oliver.bock at aei.mpg.de --- Thinking about this: this is NOT a harmless error since the whole update fails in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 11:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 10:53:36 +0000 Subject: [Koha-bugs] [Bug 15262] New: Run Koha Run. Koha search should be fast again. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Bug ID: 15262 Summary: Run Koha Run. Koha search should be fast again. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org Koha search got considerably slower between 3.16 and 3.18. With 3.22 we got Plack support out of the box for packages. Time to look into the speed issues and get the fastest Koha ever. This bug will be used as an umbrella bug to gather all related information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 11:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 10:59:53 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 --- Comment #1 from Mirko Tietgen --- Bug 11842 introduced problematic cache flushing behaviour. The cache is deleted all the time, eg. the framework structure is fetched again and again for every single result in a search (related to 2. below) Reverting the patch leads to a significant increase in search speed (building the results page really), supposedly because the MARC structure is not fetched for every single result anymore. The MARC structure needs to be deleted from cache only after a framework is changed, not while searching the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:02:10 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 --- Comment #2 from Mirko Tietgen --- Search without XSLT is much faster than without. Search with a single Result is faster now than search with multiple results. A lot of time is lost when building the results page with XSLT For every single result in a search, a lot of things are repeated all over again. A huge bunch of sysprefs is fetched every time, even though it is not likely they will change while fetching all results of one search query. GetMarcStructure seems to be a problem (see 1. above) but others may be too. Bug 11051 seems related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:03:12 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 --- Comment #3 from Mirko Tietgen --- "Benchmarks for 3.22" in the Koha wiki: http://wiki.koha-community.org/wiki/Benchmark_for_3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:03:53 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://wiki.koha-community. | |org/wiki/Benchmark_for_3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:13:04 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:14:10 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #48 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 12:14:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 11:14:45 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 13:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 12:02:16 +0000 Subject: [Koha-bugs] [Bug 15263] New: XSLT display fetches sysprefs for every result processed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Bug ID: 15263 Summary: XSLT display fetches sysprefs for every result processed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org On search, every single result goes through some XSLT processing. This includes fetching the relevant sysprefs every single time. We should do it only once per search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 13:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 12:02:34 +0000 Subject: [Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15262 Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 13:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 12:02:34 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 13:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 12:07:55 +0000 Subject: [Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #1 from Mirko Tietgen --- Created attachment 45221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45221&action=edit Bug 15263 XSLT display fetches sysprefs for every result processed On search, every single result goes through some XSLT processing. This includes fetching the relevant sysprefs every single time. We should do it only once per search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:00:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:00:19 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #2 from oliver.bock at aei.mpg.de --- Created attachment 45222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45222&action=edit Proposed patch Attached a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:04:30 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 oliver.bock at aei.mpg.de changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #3 from oliver.bock at aei.mpg.de --- Raising severity to "normal" (for us it's actually "major") because of the above reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:20:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:20:30 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anthony.laquerre at ccsr.qc.ca | |, eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com Priority|P5 - low |P2 --- Comment #4 from Blou --- Allow me to go on a limb here, and dare to raise the importance of this generic "feature". At this moment, hardware requirements to make a search feel "instantaneous" are unrealistic to most libraries. It shoudn't be and I think it would be a worthy goal to improve on the current benchmarks by x10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:24:44 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #49 from Katrin Fischer --- I am not sure about this one in 3.20 - it's listed as one of the 'new features' for 3.22 and usually new features should not be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:26:42 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:31:24 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #50 from Paul Poulain --- I think it's a/a good idea and b/safe to backport this new feature. Why is it safe ? because it's not interlaced with the rest of Koha. So no risk of side-effect. I'm adding that the RMaint is also the sitemap writer, so he'll endorse god-fire in case of death of any kitten anywhere in the world (good luck Fred ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:37:36 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #51 from Tom?s Cohen Arazi --- (In reply to Paul Poulain from comment #50) > I think it's a/a good idea and b/safe to backport this new feature. > Why is it safe ? because it's not interlaced with the rest of Koha. So no > risk of side-effect. > > I'm adding that the RMaint is also the sitemap writer, so he'll endorse > god-fire in case of death of any kitten anywhere in the world > (good luck Fred ;-) ) The only problem are the dependencies, that should be updated for it to work, and will force the users to do a dist-upgrade in order to jump to the minor update. It is uncomfortable, but has been done before, and it is Frederic's call as RMaint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 14:58:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 13:58:41 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #52 from Fr?d?ric Demians --- > The only problem are the dependencies, that should be updated for it to > work, and will force the users to do a dist-upgrade in order to jump to the > minor update. The 2 new dependencies (XML::Writer & Moo) are not mandatory. So their installation isn't necessary until the new script is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:17:07 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15263 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15263 | Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net --- Comment #5 from Mirko Tietgen --- With the patch on bug 15263 and reverting bug 11842, I can reduce search time on a Raspberry Pi from 30 to 18 seconds for 1000 hits. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 [Bug 15263] XSLT display fetches sysprefs for every result processed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:17:07 +0000 Subject: [Koha-bugs] [Bug 15263] XSLT display fetches sysprefs for every result processed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15262 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:21:30 +0000 Subject: [Koha-bugs] [Bug 15264] New: Performance loss in OPAC search introduced by bug 11842 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15264 Bug ID: 15264 Summary: Performance loss in OPAC search introduced by bug 11842 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org Bug 11842 introduced a performance loss for OPAC search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:21:58 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15264 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15264 [Bug 15264] Performance loss in OPAC search introduced by bug 11842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:21:58 +0000 Subject: [Koha-bugs] [Bug 15264] Performance loss in OPAC search introduced by bug 11842 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15264 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:24:17 +0000 Subject: [Koha-bugs] [Bug 15265] New: Instagram and pintrest Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265 Bug ID: 15265 Summary: Instagram and pintrest Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Can Instagram and Pintrest be added to the social media links. It is nice that each link has an identifying css tag so that would need to be added to the new links. Also it might be nice if they were attached to a sys pref where you could choose which to show rather than relying on css/jQuery. Ed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:26:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:26:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45209|0 |1 is obsolete| | --- Comment #158 from Charles Farmer --- Created attachment 45223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45223&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron New sign-off after testing all patches together Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:26:58 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45210|0 |1 is obsolete| | --- Comment #159 from Charles Farmer --- Created attachment 45224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45224&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:07 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45211|0 |1 is obsolete| | --- Comment #160 from Charles Farmer --- Created attachment 45225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45225&action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:16 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45212|0 |1 is obsolete| | --- Comment #161 from Charles Farmer --- Created attachment 45226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45226&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:24 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45213|0 |1 is obsolete| | --- Comment #162 from Charles Farmer --- Created attachment 45227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45227&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45214|0 |1 is obsolete| | --- Comment #163 from Charles Farmer --- Created attachment 45228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45228&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message Problems with Math/Random/Secure.pm, is solved in following patch, signing off Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:39 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45215|0 |1 is obsolete| | --- Comment #164 from Charles Farmer --- Created attachment 45229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45229&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:27:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #165 from Charles Farmer --- Created attachment 45230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45230&action=edit Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:30:28 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #166 from Charles Farmer --- (In reply to Josef Moravec from comment #157) > I think that files kohastructure.sql and sysprefs.sql, should be updated > too, not only to add atomicupdate sql file... The changes brought by the atomicupdate file are now visible in the kohastructure and sysprefs files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 15:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 14:46:02 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 --- Comment #6 from Mirko Tietgen --- In the long run, we probably should change things more deeply. Related part of a dicussion from IRC: (13:51:58) tcohen: drojf: my plan with https://github.com/tomascohen/koha/tree/xslt_filtering was to avoid useless filtering of the retrieved records (13:52:14) tcohen: so, put search results in Koha::MetadataRecord object (13:52:42) tcohen: and pass them through a pipe of Koha::Filter-s using the Koha::RecordProcessor thing (13:53:09) tcohen: that's from a perspective in which we re-organize the code (13:53:29) tcohen: and start abstracting things a bit for a future multi-metadata schema support (13:54:10) tcohen: regarding zebra, in 3.16 we made DOM setups exchange XML between Perl and Zebra (13:54:15) tcohen: both for indexing (which is OK) (13:54:34) tcohen: and for retrieval (which is OK, but seems really under performant in the current state of the way we do things) (13:55:20) tcohen: so my opinion regarding the syspref retrieval for each record is that we should optimize that in a short term (13:55:35) tcohen: but move to Koha::Fitler ofr the mid/long-term (13:55:58) tcohen: if you think about it, we are serializing/deserializing things more than 3 times (13:56:17) tcohen: and this might get worse with JSON data from ES (13:56:36) tcohen: get JSON data => have filters for JSON data => period (13:56:39) drojf: that sounds very good to me (13:56:51) tcohen: get MARC(XML) data => have filters for MARC(XML) data => period (13:57:26) tcohen: also, with the current indexer, we shouldn't re-calculate loan status, etc for rendering (13:57:33) tcohen: that information is already in zebra (13:57:35) tcohen: or it should (13:58:13) tcohen: it is cheaper to prepare the data so zebra has it, than calculate it on rendering (13:58:31) tcohen: because de indexing process is asynchronous (13:58:40) tcohen: and is queued, etc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 16:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 15:03:03 +0000 Subject: [Koha-bugs] [Bug 15251] Request for addition of ISO-8859-7 encoding support in Z39.50 searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15251 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 16:41:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 15:41:27 +0000 Subject: [Koha-bugs] [Bug 15266] New: stage-marc-import.pl does not show warning messages on marc error. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15266 Bug ID: 15266 Summary: stage-marc-import.pl does not show warning messages on marc error. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a marc file is imported which contains a MARC syntax error, the only message displayed is '1 records not staged because of MARC error'. There is no indication of where the error occurred, or what type of error occurred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 16:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 15:52:18 +0000 Subject: [Koha-bugs] [Bug 15266] stage-marc-import.pl does not show warning messages on marc error. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15266 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden --- Created attachment 45231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45231&action=edit Example data -- a marc-utf8 file with errors The attached file throws the following message in intranet-error.log: stage-marc-import.pl: Argument "1 15" isn't numeric in integer addition (+) at /usr/share/perl5/MARC/File/USMARC.pm line 166. Inspecting that code, I see 156 # Check directory validity 157 ($tagno =~ /^[0-9A-Za-z]{3}$/) 158 or $marc->_warn( "Invalid tag in directory $location: \"$tagno\"" ); 159 160 ($len =~ /^\d{4}$/) 161 or $marc->_warn( "Invalid length in directory $location tag $tagno: \"$len\"" ); 162 163 ($offset =~ /^\d{5}$/) 164 or $marc->_warn( "Invalid offset in directory $location tag $tagno: \"$offset\"" ); 165 166 ($offset + $len <= $reclen) 167 or $marc->_warn( "Directory entry $location runs off the end of the record tag $tagno" ); The two elements in the addition in line 166 are $offset and $len. The argument "1 15" doesn't match the regular expression for either $len (^\d{4}$) nor $offset (^\d{5}$), so it should have triggered one of the $marc->_warn methods, but these warnings are not sent to intranet-error.log nor to the screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 17:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 16:57:21 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45179|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 45232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45232&action=edit [SIGNED-OFF]Bug 15258: Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. Signed-off-by: Hector Castro All tests pass successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 17:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 16:57:55 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Assignee|maxime.beaulieu at inlibro.com |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:00:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:00:41 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45177|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 45233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45233&action=edit Bug 15258 Fix Perl scripts declaring unused variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:01:22 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:06:02 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45232|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 45234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45234&action=edit [SIGNED-OFF]Bug 15258: Fix Perl scripts declaring unused variables Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:08:55 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45233|0 |1 is obsolete| | Attachment #45234|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 45235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45235&action=edit [SIGNED-OFF]Bug 15258: Fix Perl scripts declaring unused variables Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:09:31 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 45236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45236&action=edit [SIGNED-OFF]Bug 15258: Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. Signed-off-by: Hector Castro All tests pass successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 18:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 17:23:37 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #55 from Katrin Fischer --- If we want to revive this, it will need a bit work. I have taken a quick look at the patches and identified 2 things already: - take into account that every day can be first day of the week now (pref) - remove all use of C4::Dates, as this no longer exists What's the best way to move forward? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 19:39:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 18:39:09 +0000 Subject: [Koha-bugs] [Bug 7397] Patron search from Checkout tab does 'contains' instead of 'starts_with' search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7397 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #5 from Barton Chittenden --- "Bug 5730" is concerned with the members search page; this bug has to do with the search on the check-out tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 19:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 18:40:26 +0000 Subject: [Koha-bugs] [Bug 15267] New: Current checkouts and existing checkouts. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15267 Bug ID: 15267 Summary: Current checkouts and existing checkouts. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Can current session checkouts be broken down to a separate tab than the existing checkouts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 19:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 18:41:28 +0000 Subject: [Koha-bugs] [Bug 15267] Separate tabs for current and existing checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Current checkouts and |Separate tabs for current |existing checkouts. |and existing checkouts CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 19:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 18:45:42 +0000 Subject: [Koha-bugs] [Bug 9537] Add a list of the patches that have been applied to a koha installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9537 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|egpetridis at yahoo.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 20:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 19:21:31 +0000 Subject: [Koha-bugs] [Bug 15268] New: Patron search differs between 'Check out' search and 'Patron' search on two-word surnames like 'St. Claire' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15268 Bug ID: 15268 Summary: Patron search differs between 'Check out' search and 'Patron' search on two-word surnames like 'St. Claire' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Given Patrons with the following names: SURNAME , FIRSTNAME ST CLAIRE , JAKE ST. AUBIN , SHELLEY P ST. CLAIRE , AUSTIN B ST. CLAIRE , BRADLEY ST. CLAIRE , CHYENNA M ST. CLAIRE , CODY R. ST. CLAIRE , HENRY ST. CLAIRE , SKYANN M. ST. JOHN , CHRISTA ST. JOHN , EMERSON D STEINBERG , CLAIRE The patron search and checkout search behave differently: Searching for st. claire Patron search returns ST. CLAIRE , AUSTIN B ST. CLAIRE , BRADLEY ST. CLAIRE , CHYENNA M ST. CLAIRE , CODY R. ST. CLAIRE , HENRY ST. CLAIRE , SKYANN M. check-out search returns nothing. --- Searching for st claire Patron search returns results for both ST CLAIRE and ST. CLAIRE: ST CLAIRE , JAKE ST. CLAIRE , AUSTIN B ST. CLAIRE , BRADLEY ST. CLAIRE , CHYENNA M ST. CLAIRE , CODY R. ST. CLAIRE , HENRY ST. CLAIRE , SKYANN M. check-out search returns STEINBERG , CLAIRE --- Searching for st. Both searches return ST. AUBIN , SHELLEY P ST. CLAIRE , AUSTIN B ST. CLAIRE , BRADLEY ST. CLAIRE , CHYENNA M ST. CLAIRE , CODY R. ST. CLAIRE , HENRY ST. CLAIRE , SKYANN M. ST. JOHN , CHRISTA ST. JOHN , EMERSON D This may be related to Bug 7397 - Patron search from Checkout tab does 'contains' instead of 'starts_with' search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 20:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 19:44:40 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |gmc at esilibrary.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 20:45:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 19:45:52 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #53 from Katrin Fischer --- If I understand Tomas correctly it's still a problem for the packages, even tho the dependencies are non-mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 21:07:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 20:07:01 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45220|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 45237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45237&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 21:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 20:07:26 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:32:29 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Nick Clemens --- I can't get SMS provider to save upon edit, and changing it through DB I didn't get the email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:41:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:41:23 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #26 from Nicole C. Engard --- (In reply to H?ctor Eduardo Castro Avalos from comment #11) > I was looking that there no info about this in documentation > , > section Advanced constraints or I don't know if this exist in another page. > > I added here Documentation Manager. I removed it from the manual when I found that it no longer worked. I'll add it in to the recent manual. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:45:10 +0000 Subject: [Koha-bugs] [Bug 14718] Documentation/screenshot update for label creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Nicole C. Engard --- Manual updated. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:49:10 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #104 from Katrin Fischer --- Created attachment 45238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45238&action=edit [PASSED QA] Bug 7683: Cataloguing statistics wizard improvements - Add 3 options for cells value - Titles count "COUNT (biblionumber)" - Items count "COUNT (itemnumber)" (current behavior) - Deleted items count "COUNT (deleteditems.itemnumber)" - Add to selectable rows, colums and filters: - items.notforloan - items.materials For each of these fields, retrieve the label in the default cataloging framework. If no MARC field is mapped to the field in question, it does not show this line in the wizard. If the MARC field is associated with a list of authorized values, it displays a dropdown list for the filter, otherwise it displays a text field. - Add to selectable rows, columns and filters: - items.dateaccessioned (creation date) - deleteditems.timestamp (deletion date) (Only if the third option (eg count deleted items) is selected) - Add unit tests for GetMarcSubfieldStructureFromKohaField Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:49:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:49:18 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #105 from Katrin Fischer --- Created attachment 45239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45239&action=edit [PASSED QA] Bug 7683: Remove dead code about dewey and lccn filters $hasdewey and $haslccn were hardcoded to 0 Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:49:40 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #106 from Katrin Fischer --- Created attachment 45240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45240&action=edit [PASSED QA] Bug 7683: Fix a shift in date filter indexes Date filter indexes are 13, 14, 15, 16, not 14, 15, 16, 17 Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors (some message for the deleted file) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:49:45 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #107 from Katrin Fischer --- Created attachment 45241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45241&action=edit [PASSED QA] Bug 7683: Catalog statistics wizard: QA fixes 1/ Do not allow invalid date ranges (from > to) (datepicker only) 2/ Relabel "From:" to "From" for consistency 3/ Fix MIME type for CSV 4/ Use Koha::DateUtils instead of C4::Dates 5/ Use placeholders in SQL query Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:49:53 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #108 from Katrin Fischer --- Created attachment 45242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45242&action=edit [PASSED QA] Bug 7683: Relabel "acquired date" and "removed date" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:50:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:50:40 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:50:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:50:44 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:50:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:50:48 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:50:53 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:50:59 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:51:04 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 22:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 21:52:06 +0000 Subject: [Koha-bugs] [Bug 14718] Documentation/screenshot update for label creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 --- Comment #4 from Liz Rea --- Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:00:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:00:11 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #52 from Katrin Fischer --- Please rebase - there are several conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:06:53 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #24 from Bouzid --- Created attachment 45243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45243&action=edit Bug 11371 - Correct right data in each column and correct format date and tidying up in template file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:11:49 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #25 from Bouzid --- Created attachment 45244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45244&action=edit Bug 11371 - Correct right data in each column and correct format date and tidying up in template file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:12:32 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45243|0 |1 is obsolete| | Attachment #45244|0 |1 is obsolete| | --- Comment #26 from Bouzid --- Created attachment 45245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45245&action=edit Bug 11371 - fix problem with right data in each column in csv file fix problem with right data in each column correct format date tidying up in template file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:22:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:22:40 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 30 23:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 22:22:49 +0000 Subject: [Koha-bugs] [Bug 12268] Subject Broader Narrower Related terms and Query Parser and Exploded Terms issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12268 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.