[Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103

--- Comment #2 from cnorthcott.work at gmail.com ---
Created attachment 44443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44443&action=edit
Bug 15103: Import Borrowers Performance Improvement

Improves the performance of importing borrowers in batches from file
by by switching out resultset calls for more direct SQL queries and
using hash lookups instead of repeated DB lookups.

Test Plan:
1) Prepare NTYprof
(http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf)
   or procure a stopwatch (stopwatch will be simpler but less accurate).
2) Download the PatronDataCSV1.csv and PatronDataCSV2.csv attachements from
   the bug page or organise your own csv's with data for 1000 or more
   patrons to import.
3) Navigate to Home > Tools > Import Patrons in the Koha Intranet
   (http://demo-intra.mykoha.co.nz/cgi-bin/koha/tools/import_borrowers.pl)
4) Click the "Browse..." button and select PatronDataCSV1.csv or your
equilient.
5) If you are using a stopwatch, prepare your stopwatch so that you will
   start counting seconds from the point you click the button in the next
   step.
6) Scroll to the bottom of the page and click the "Import" button
(simultaneously
   start your stopwatch if using one)
7) When the page appears showing completion of the import, stop your stopwatch
   and check the time or navigate to the folder you have set NYTProf to output.
8) Record the runtime. This is the pre-optimisation time.
9) Apply this patch.
9) Repeat steps 2-7 of this testplan with the patch applied and use the
   PatronDataCSV2.csv this time around. This will yield the post-optimisation
   time.
10) Compare the pre-optimisation time and post optimisation time. The second
    post-optimisation time should be faster.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.