[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm in agreement with Jonathan that adding subs needlessly is a bad thing and
therefore I do tend towards the transaction idea.

More and more I'm of the opinion that data integrity lies firmly within the
remit of the database. We really aught to get the constraints correct there
first and not rely on lots of additional code logic all over the place doing it
instead :|

It's a hard thing to say, but I would prefer to have some of the foundations
cleaned up rather than just adding yet more code to koha to compensate for your
poor foundations.  Sorry if this sounds really negative, but it's something
I've felt for a while and I totally understand the want to get new and exciting
features in quicker and quicker but I feel this is really leading to
obfuscation and code bloat that becoming unmanageable.. where do we drawer the
line?

I won't complain if this is pushed.. but I don't think it's the most forward
thinking solution I'm afraid.

Also, as we've missed feature slush now it may be worth mentioning a few other
queries:

1) Why use a dbh over using the dbic objects? (By using C4::Context to get your
handle, you are already going through the pain of instantiating all the dbic
class objects I believe anyway, so I don't see that using the handle directly
here is of any benefit - Jonathan let me know if this is wrong?)

2) Line 928 in the final patch.. appears to have a double $$
(C4/ImportBatch.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.