[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 44533
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44533
y# Attachment to Bug 12748 - Serials - two issues with status of

Review of attachment 44533:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12748&attachment=44533)
-----------------------------------------------------------------

8) Validate that there are no new serials created by instruction 7 and that the
serial was deleted

Would be good to have a test for this step too.

::: C4/Serials.pm
@@ +1172,5 @@
>          }
>      }
>  
> +    # create new expected entry if needed (ie : was "expected" and has changed)
> +    # BUG 12748: Check if there are no other expected issues.

No need to set the bug# in the code, we use git.

@@ +2810,5 @@
> +=head2 findSerialByStatus
> +
> +    @serials = findSerialByStatus($status, $subscriptionid);
> +
> +    Returns an array of serials matching a given status and subscription id.

findSerialsByStatus sounds more appropriate, do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.