[Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 13 15:39:09 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 44842
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44842&action=edit
Bug 15182: Continue to consider Crypt::GCrypt optional

Caused by commit f25fe6ddb4a340f12613784dc841ab5bfd672d6b
Date:   Fri Nov 6 11:21:56 2015 -0300
    Bug 15151: Avoid DB access to load C4::Members

Make Koha::NorwegianPatronDB requires on loading C4::Members.
But Koha::NorwegianPatronDB uses Crypt::GCrypt which is marked as
optional in the deps list.
This patch suggest to load the module only if it can be loaded and does
not explode otherwise.

Another solution would be to surround the require with an eval, to avoid
to load Module::Load when C4::Members is used.

Test plan:
uninstall Crypt::GCrypt and try to access the staff interface.
Without this patch, you will get a software error.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list