[Koha-bugs] [Bug 15242] Missing subroutine in overdue_notices.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 24 11:28:19 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oh man we're inconsistent in this script :(.

Well spotted Marc, reading C4::Overdues I note it's using EXPORT instead of
EXPORT_OK too :(.

Personally, I believe if a routine is intended to be used in another module it
should appears in the EXPORT_OK block not the EXPORT block, and that it should
be explicitly imported into the using module with a use statement.

So.. if I were being picky I'd say.. convert the EXPORT to EXPORT_OK (but this
may break modules that expect to have access to the routines without explicitly
importing them :( ), add the routine your found to the EXPORT_OK block also,
and then clean up here to match. 

Perhaps split the work into two bugs.. one clean up and one just fixing the
initial bug.. thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list