From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:20:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:20:26 +0000
Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |hector.hecaxmmx at gmail.com
--- Comment #2 from H?ctor Eduardo Castro Avalos ---
Before applying the patch I search and found the followin lines:
169 if ($duedatespec =~ C4::Dates->regexp('syspref')) {
178 our $todaysdate = C4::Dates->new->output('iso');
I do not know if there should be these lines!
If the intention in bug 14870 is to delete C4::Dates, this will launch an error
or warning when the script will executed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:21:22 +0000
Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records
in basket summary page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:21:26 +0000
Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records
in basket summary page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42721|0 |1
is obsolete| |
Attachment #42722|0 |1
is obsolete| |
--- Comment #10 from Katrin Fischer ---
Created attachment 42985
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42985&action=edit
[PASSED QA] Bug 10181: Make string translatable
Signed-off-by: Joonas Kylm?l?
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:21:39 +0000
Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records
in basket summary page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181
--- Comment #11 from Katrin Fischer ---
Created attachment 42986
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42986&action=edit
[PASSED QA] Bug 10181: Acq - Improve message for deleted records
There are some issues here:
1/ Message not translatable (set in the pl file)
2/ ' by 'displayed even if no author defined
3/ Message not the same every where
4/ Nothing displayed on the invoice page
Test plan:
1/ Create a basket
2/ Add 4 orders A, B, C, D
3/ On the basket, you see "$title by $author", or "$title" if no author
defined
4/ Delete order A, B
5/ Close the basket
6/ Receive B, C
7/ Delete record created for A, C
8/ Go on the basket page, you should see the title and "Deleted
bibliographic record, can't find title" for the deleted record
9/ Go on the invoice page, you should see the title and "Deleted
bibliographic record, can't find title" for the deleted record
Signed-off-by: Joonas Kylm?l?
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:28:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:28:51 +0000
Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903
--- Comment #3 from H?ctor Eduardo Castro Avalos ---
(In reply to H?ctor Eduardo Castro Avalos from comment #2)
> Before applying the patch I search and found the followin lines:
>
> 169 if ($duedatespec =~ C4::Dates->regexp('syspref')) {
> 178 our $todaysdate = C4::Dates->new->output('iso');
>
> I do not know if there should be these lines!
>
> If the intention in bug 14870 is to delete C4::Dates, this will launch an
> error or warning when the script will executed.
After applying the patch these lines continued there. The patch doesn't touch
it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:35:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 22:35:36 +0000
Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears
inappropriately
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
Same here about 4-8. New sequence looks good to me, but is there a reason we
don't display all reasons why a hold can not be placed?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:09:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 23:09:11 +0000
Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42973|0 |1
is obsolete| |
--- Comment #5 from H?ctor Eduardo Castro Avalos ---
Created attachment 42987
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42987&action=edit
[SIGNED-OFF]Bug 14922 - Remove C4::Dates from cataloguing/additem.pl
This patch removes C4::Dates from cataloguing/additem.pl
To test:
- In MARC bibliographic framework, define a default value
for one of the in Tag 952 Subfield struture, e.g. for
subfield x Non-public note. You can define it under
'Advancde constraints'. Define the value similar to the following:
Year:YYYY Month:MM Day:DD
- Create a new item for a biblio and verify that YYYY, MM and DD are
replaced with today's values.
- Apply patch and repeat that previous step behaves as before.
- Verify that the overall functionality of the form is the same
as before applying the patch.
Signed-off-by: Hector Castro
Works as advertised. With the last script not accept more than YYYYMMDD
If you enter something else, the script sends to the end of line.
This patch follow up the pattern in constraint default value
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:09:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Sep 2015 23:09:53 +0000
Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 01:11:06 +0000
Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861
--- Comment #17 from David Cook ---
I don't think we needed to change "1=32" to "1=Date-of-acquisition", but it's a
trivial difference, so no worries.
Sign off to follow...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 01:11:27 +0000
Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42980|0 |1
is obsolete| |
--- Comment #18 from David Cook ---
Created attachment 42988
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42988&action=edit
Bug 14861: Change acqdate to allow date ranges.
Use 'r=o' to in ccl.properties enable acqudate date range searches
of the form
YYYY-MM-DD - yyyy-mm-dd
Signed-off-by: David Cook
Used the test plan from Bugzilla, and it works as described.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 01:11:42 +0000
Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:55:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 02:55:17 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #116 from Robin Sheat ---
(In reply to Robin Sheat from comment #115)
> I have a rebase done, though it's untested.
Now it's had a quick test and some things have been fixed. It appears on the
surface to be working again.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 08:12:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 06:12:52 +0000
Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 08:34:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 06:34:23 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:42:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 07:42:31 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
--- Comment #5 from Magnus Enger ---
Colin: What do you think of the proposal from Jonathan?
Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like a
good idea.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:48:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 07:48:34 +0000
Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to
SC but fails to checkin item on Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|3.12 |3.18
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
We are seeing this behaviour as well it seems in a 3.18.8 installation.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:58:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 07:58:41 +0000
Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42895|0 |1
is obsolete| |
--- Comment #4 from Marc V?ron ---
Created attachment 42989
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989&action=edit
Bug 14903 - Remove C4::Dates from circ/circulation.pl
Patch to remove deprectated C4::Dates from circ/circulation.pl
To test:
- Apply patch
- Go to the checkout site (Home > Circulation > Checkouts)
- Verify that data displays properly (including for users with a card
that expires in the near future, see syspref 'NotifyBorrowerDeparture')
- Verify that due date works as before (with syspref 'SpecifyDueDate' on and
off
(Amended following comment #3)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:00:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:00:15 +0000
Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:16:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:16:35 +0000
Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in
advanced search
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #19 from Jonathan Druart ---
I am not familiar with ccl.properties, but there is a
st-numeric 4=109 r=o
Does
- st-date-normalized 4=5
+ st-date-normalized 4=5 r=o
could do the trick for all date indexes?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:20:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:20:24 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de,
| |ulrich.kleiber at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:26:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:26:31 +0000
Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #6 from Jonathan Druart ---
Marc,
What about using Koha::DateUtils to replace ->today?
Something like
my $today = dt_from_string;
my $month = $today->month;
my $day = $today->day;
do what you want.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:32:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:32:11 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #3 from Jonathan Druart ---
Comment on attachment 42964
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42964
[SIGNED-OFF]Bug 14924 - Remove C4::Dates from members/memberentry.pl
Review of attachment 42964:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14924&attachment=42964)
-----------------------------------------------------------------
::: members/memberentry.pl
@@ +170,5 @@
> foreach (qw(dateenrolled dateexpiry dateofbirth)) {
> next unless exists $newdata{$_};
> my $userdate = $newdata{$_} or next;
> + if ( $userdate ) {
> + $newdata{$_} = output_pref({ dt => dt_from_string( $userdate ), dateformat => 'iso', dateonly => 1 });
You have to care of bad formatted dates, otherwise the user will get a software
error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:32:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:32:17 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:42:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:42:00 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #4 from Marc V?ron ---
Hi Jonathan,
I tried to enter an invalid date, but we have the date picker for this date -
it seems no longer to be possible to enter invalid dates for the due date.
Or do I miss a way to enter an invalid date?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:44:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:44:29 +0000
Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from
labels/label-item-search.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--- Comment #3 from Jonathan Druart ---
Marc, sorry but I get a software error if the date is not correctly formatted.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:57:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:57:51 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
--- Comment #3 from Marc V?ron ---
Created attachment 42990
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42990&action=edit
Bug 14929 - Fix missing display of help page in contract management
This patch renames / moves the file
koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt
to
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt
To test:
- Go to Home > Acquisition > [Vendor] > Contracts
(/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX)
- Verify that Help displays as appropriate.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:59:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:59:10 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
|ity.org |
Patch complexity|--- |Trivial patch
Blocks|14870 |
Status|NEW |Needs Signoff
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:59:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 08:59:10 +0000
Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|14929 |
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
[Bug 14929] Fix missing display of help page in contract management
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:02:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:02:16 +0000
Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height
scaling editable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149
Theodoros Theodoropoulos changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |theod at lib.auth.gr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:13:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:13:35 +0000
Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files
acqui/pdfformat/layout*.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42975|0 |1
is obsolete| |
--- Comment #2 from Jonathan Druart ---
Created attachment 42991
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42991&action=edit
[COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl
This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.
Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:14:03 +0000
Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files
acqui/pdfformat/layout*.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Attachment #42975|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:14:08 +0000
Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files
acqui/pdfformat/layout*.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42991|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:14:18 +0000
Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files
acqui/pdfformat/layout*.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928
--- Comment #3 from Jonathan Druart ---
Wrong bug report, sorry about that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:14:39 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:14:42 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42959|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 42992
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42992&action=edit
Bug 14918: Remove C4::Dates from circ/pendingreserves.pl
This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.
Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:16:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:16:00 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #4 from Jonathan Druart ---
I suggest this counter-patch, the badly formatted dates are caught and don't
make Koha explodes with a software error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:24:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:24:54 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:24:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:24:57 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42816|0 |1
is obsolete| |
Attachment #42817|0 |1
is obsolete| |
Attachment #42818|0 |1
is obsolete| |
Attachment #42819|0 |1
is obsolete| |
Attachment #42820|0 |1
is obsolete| |
--- Comment #30 from Jonathan Druart ---
Created attachment 42993
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42993&action=edit
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm
http://bugs.koha-community.org/show_bug.cgi?id=14402
Signed-off-by: Nancy Keener
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:25:03 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
--- Comment #31 from Jonathan Druart ---
Created attachment 42994
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42994&action=edit
Bug 14402: Add unit tests for purge_zero_balance_fees()
The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:
* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
The accountlines row should not be deleted. This is merely a sanity check,
because difference between today's date and the fee date cannot be
greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
days ago. the accountlines row should not be deleted, because
the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
(3 tests). The accountlines row will never be deleted, because
amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
(3 testes) This tests credits. Again, the accountlines row will never
be deleted, because amountoutstanding is not 0.
http://bugs.koha-community.org/show_bug.cgi?id=14402
Signed-off-by: Nancy Keener
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:25:10 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
--- Comment #33 from Jonathan Druart ---
Created attachment 42996
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42996&action=edit
Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.
Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.
Signed-off-by: Nancy Keener
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:25:06 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
--- Comment #32 from Jonathan Druart ---
Created attachment 42995
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42995&action=edit
Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl
This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.
Test plan:
Run: t/db_dependent/Accounts.t
If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().
http://bugs.koha-community.org/show_bug.cgi?id=14402
Signed-off-by: Nancy Keener
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:25:14 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
purge all 0 balance fees and payments older than the given number of days
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402
--- Comment #34 from Jonathan Druart ---
Created attachment 42997
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42997&action=edit
Bug 14402: - QA Followup
Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:29:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:29:22 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #28 from Jonathan Druart ---
Everything is signed off here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:40:29 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:40:37 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42990|0 |1
is obsolete| |
--- Comment #4 from Magnus Enger ---
Created attachment 42998
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42998&action=edit
Bug 14929 - Fix missing display of help page in contract management
This patch renames / moves the file
koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt
to
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt
To test:
- Go to Home > Acquisition > [Vendor] > Contracts
(/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX)
- Verify that Help displays as appropriate.
Signed-off-by: Magnus Enger
Works as advertised. All the tabs similar to "Contracts" have
working help pages.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:46:33 +0000
Subject: [Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=12770,
| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=14666
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:46:33 +0000
Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=13816
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:46:33 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=13816
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:48:01 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:48:03 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42937|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 42999
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42999&action=edit
Bug 14910: Redirect to the circulation module after a renew
iIf a patron is renewed from the circulation module, the librarian
should be redirected to the circulation module.
This works correctly if the renew is done from the patron module
(members).
This is caused by a typo in the template: desintation vs destination.
This patch also removes the cardnumber parameter to the setstatus.pl
script, it is not needed given that borrowernumber is always passed.
This has a good side-effect, it will fix bug 14691. The cardnumber does
not exist anymore, so no need to escape it :)
Test plan:
0/ Do not apply this patch
1/ Create a patron with a cardnumber with a quote (rm'me) and another
one without a quote (rmme)
2/ Go on the checkouts page (circ/circulation.pl)
3/ Renew the 2 patrons
=> With rm'me you are redirected to the circ module - ok
=> With rmme you are redirected to the member module - nok
4/ Go on the patron detail page (members/moremember.pl)
5/ Renew the 2 patrons
=> you are redirected to the member module - ok
6/ Delete the patrons
=> Nothing happend with rm'me, there is a JS error on the page - nok
=> rmme is deleted - ok
7/ Apply the patch and recreate rmme
8/ Repeat 2, 3, 4, 5
=> You are redirected to the correct module
9/ Delete the patrons
=> They are successfully deleted
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:48:23 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
--- Comment #6 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #4)
> I think there is a bug hiding in this patch - I try renewing a patron from
> the sample database:
>
> localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=41
> Gloria Odom (23529000054503)
>
> it works ok without this patch, but with the patch I get redirected to:
> http://localhost:8080/cgi-bin/koha/members/moremember.pl?41&was_renewed=1
> With the message: This patron does not exist.
> Looks like we are missing the borrowernumber part in the URL?
Erk, last minute change! Thanks for catching that!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:51:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:51:47 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #5 from Jonathan Druart ---
(In reply to Marc V?ron from comment #4)
> Hi Jonathan,
>
> I tried to enter an invalid date, but we have the date picker for this date
> - it seems no longer to be possible to enter invalid dates for the due date.
>
> Or do I miss a way to enter an invalid date?
I have tried with the date of birth on creating/updating a patron.
You get a JS alert box but are able to submit the form.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:53:08 +0000
Subject: [Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix
for Contributors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=14917
Status|Failed QA |RESOLVED
Depends on|13382 |
--- Comment #7 from Jonathan Druart ---
*** This bug has been marked as a duplicate of bug 13382 ***
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382
[Bug 13382] RDA: 700/710/711 display in XSLT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:53:08 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|14359 |
--- Comment #50 from Jonathan Druart ---
*** Bug 14359 has been marked as a duplicate of this bug. ***
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359
[Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:53:08 +0000
Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=14359
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:53:31 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:53:34 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42573|0 |1
is obsolete| |
--- Comment #4 from Magnus Enger ---
Created attachment 43000
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43000&action=edit
Bug 14832: Fix encoding issues when exporting in RIS
Test plan:
1/ Make sure you have non ASCII chars in the title and the authors.
2/ Export the record in RIS
You should not see any encoding problems.
Signed-off-by: Magnus Enger
Before patch: RIS file has wrongly encoded chars
After patch: RIS file has no endcoding problems
Tested on a NORMARC setup.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:58:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 09:58:46 +0000
Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height
scaling editable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149
--- Comment #3 from Theodoros Theodoropoulos ---
This proposed addition to have the user define the size of the barcode is very
useful indeed!
But until then, with the current situation, we realized that the hardcoded
relative values in Label.pm were very conservative for 'normal'-sized labels
For our needs, we found out that a default value of 20% of the label height and
90% of the label width (compared to the original values of 10% and 80%
respectably) produce taller barcodes that are easier to read.
In case it helps anyone, the relevant patch to achieve this is:
--- ./src/C4/Labels/Label.pm 2015-10-01 10:35:54.414837999 +0300
+++ ./src/C4/Labels/Label.pm.orig 2015-10-01 10:34:38.470837999 +0300
@@ -282,8 +282,8 @@
my $self = shift;
my $barcode_llx = $self->{'llx'} + $self->{'left_text_margin'}; # this
places the bottom left of the barcode the left text margin distance to right of
the left edge of the label ($llx)
my $barcode_lly = $self->{'lly'} + $self->{'top_text_margin'}; # this
places the bottom left of the barcode the top text margin distance above the
bottom of the label ($lly)
- my $barcode_width = 0.8 * $self->{'width'}; # this
scales the barcode width to 80% of the label width
- my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # this
scales the barcode height to 10% of the label height
+ my $barcode_width = 0.9 * $self->{'width'}; # this
scales the barcode width to 90% of the label width
+ my $barcode_y_scale_factor = 0.02 * $self->{'height'}; # this
scales the barcode height to 20% of the label height
return 0, 0, 0, $barcode_llx, $barcode_lly, $barcode_width,
$barcode_y_scale_factor;
}
(Needless to say again that the best approach would be to make it selectable by
the user in the template screen!)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:02:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:02:34 +0000
Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct
language
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42509|0 |1
is obsolete| |
--- Comment #2 from Magnus Enger ---
Created attachment 43001
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43001&action=edit
Bug 14812: Display the help in the correct language
If opaclanguages != language, the language of the help page is the
default one (en).
Test plan:
1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR
2/ Translate the fr-FR and ar-Arab templates.
3/ Go on the mainpage, switch to ar-Arab, go to the help page.
The help page content should be in Arabian, not English.
Signed-off-by: Magnus Enger
Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO
Went to the intranet main page, selected Swedish and clicked on help
Without the patch, help was displayed in English
With the patch, help was displayed in Swedish. Yay!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:02:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:02:31 +0000
Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct
language
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:23:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:23:57 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #22 from Jonathan Druart ---
(In reply to Josef Moravec from comment #21)
> I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try
> it on another machine with MySQL tomorow...
Using MariaDB I don't get the issue you have described.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:31:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:31:50 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |magnus at libriotech.no
--- Comment #7 from Magnus Enger ---
(In reply to Jonathan Druart from comment #5)
> Test plan:
> 0/ Do not apply this patch
> 1/ Create a patron with a cardnumber with a quote (rm'me) and another
> one without a quote (rmme)
> 2/ Go on the checkouts page (circ/circulation.pl)
> 3/ Renew the 2 patrons
> => With rm'me you are redirected to the circ module - ok
> => With rmme you are redirected to the member module - nok
I can reproduce this without the patch.
But after I apply the patch, I get this:
rm'me: No JS popup confirmation, but redirected to the circ module
rmme: JS popup confirmation, but redirected to the member module
For rmme I get this error in the Firebug Console:
SyntaxError: expected expression, got ','
firstDay: ,
For rm'me I get two errors:
SyntaxError: expected expression, got ','
firstDay: ,
SyntaxError: missing ; before statement
...owernumber=6450&cardnumber=rm'me&desintation=circ&reregistration=y'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:36:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:36:33 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #23 from Josef Moravec ---
Hm, on another machine everything works perfect... So probably some problem
with my specific data, or something on that one VM. So please, ignore me ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:47:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:47:00 +0000
Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101
--- Comment #24 from Jonathan Druart ---
Comment on attachment 39800
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800
Bug 14101: Automatic renewals exactly on due date
Review of attachment 39800:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14101&attachment=39800)
-----------------------------------------------------------------
::: C4/Circulation.pm
@@ +2737,4 @@
> return ( 0, "too_many" )
> if $issuingrule->{renewalsallowed} <= $itemissue->{renewals};
>
> + if ( defined $issuingrule->{norenewalbefore} ) {
What about the empty string? I am not sure it's relevant, but I would like to
be sure.
@@ +2751,5 @@
> return ( 0, "too_soon" );
> }
> + else {
> + return ( 0, "auto_renew" ) if $itemissue->{auto_renew};
> + return ( 1, undef );
This last return is not needed, the process should continue I think.
Imagine someone else adds a new check in the futur.
@@ +2759,5 @@
> + # Fallback for automatic renewals:
> + # If norenewalbefore is undef, don't renew before due date.
> + elsif ( $itemissue->{auto_renew} ) {
> + return ( 0, "auto_renew" )
> + if DateTime->now( time_zone => C4::Context->tz() ) >=
Prefer dt_from_string to get a DateTime object.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:49:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:49:13 +0000
Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal
before' (days or hours)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395
--- Comment #29 from Jonathan Druart ---
Comment on attachment 41054
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054
Bug 14395: Code changes
Review of attachment 41054:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14395&attachment=41054)
-----------------------------------------------------------------
Please provide a better commit description.
::: C4/Circulation.pm
@@ +2772,5 @@
> + {
> + $soonestrenewal->truncate( to => 'day' );
> + }
> +
> + if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) )
Prefer dt_from_string to get a DateTime object (yes this already existed before
your patch, but it's worth to make things consistent).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:59:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 10:59:35 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
--- Comment #21 from Jonathan Druart ---
Created attachment 43002
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43002&action=edit
Bug 5371: (follow-up) Force no caching for private pages at the OPAC
Same as previous patch for opac-messaging.pl and opac-readingrecord.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:03:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:03:06 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
--- Comment #22 from Jonathan Druart ---
Marc,
Thanks for testing.
I have added the trick on the messaging and circulation history page.
I have not changed the lists/shelves page, the module and script are going to
be rewritten on another bug (bug 14544) and I don't want to introduce
conflicts.
I am not sure we should add the no-store value for the cache policy on other
pages.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:04:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:04:58 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
--- Comment #6 from Jonathan Druart ---
(In reply to Magnus Enger from comment #5)
> Colin: What do you think of the proposal from Jonathan?
> Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like
> a good idea.
No, I would like to keep my QA token.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:09:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:09:04 +0000
Subject: [Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in
circ/returns.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842
--- Comment #4 from Jonathan Druart ---
If I remember correctly you must use an itemtype with a return policy.
Whatever the value of the policy, the return branch will always be the
homebranch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:11:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:11:25 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
--- Comment #8 from Jonathan Druart ---
Magnus, could you confirm you have correctly cleared your browser cache?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:14:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:14:43 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #24 from Jonathan Druart ---
Josef, if you are still able to reproduce the issue, with the last patches
against master, I think we should try to understand what is the problem :)
Could you confirm you got the issue even with a non-empty creator_batches
table? I have not tried with en empty table.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:18:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:18:57 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
--- Comment #5 from Marc V?ron ---
Created attachment 43003
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43003&action=edit
[Signed-off] Bug 14918: Remove C4::Dates from circ/pendingreserves.pl
This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.
Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error
Counter patch works as expected and is a much cleaner solution.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:19:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:19:51 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:27:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:27:47 +0000
Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for
the staff intranet
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #4 from Jonathan Druart ---
I think this needs small tweaks.
For instance, compare the "+" icon on /cgi-bin/koha/serials/serials-home.pl
Before this patch, it was correctly aligned, now it's not.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:39:32 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
--- Comment #23 from Marc V?ron ---
Created attachment 43004
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43004&action=edit
[Signed-off] Bug 5371: Force no caching for private pages at the OPAC
In order no to slow too much the browsing, it is certainly not a good
idea to add this cache-control value for all pages at the OPAC.
This patch just adds where the author found it could be useful.
Test plan:
1/ Login at the OPAC
2/ Go on the account page (opac/opac-account.pl)
3/ Click log out
4/ Use the back button of your browser
Without this patch you will see the previous page.
With this patch, the previous page will be reloaded and you will be
redirected to the login form.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:39:42 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
--- Comment #9 from Magnus Enger ---
(In reply to Jonathan Druart from comment #8)
> Magnus, could you confirm you have correctly cleared your browser cache?
Ah, not necessarily. I'll have another go.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:39:50 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42911|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:40:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:40:57 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
--- Comment #24 from Marc V?ron ---
Created attachment 43005
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43005&action=edit
[Signed-off] Bug 5371: (follow-up) Force no caching for private pages at the
OPAC
Same as previous patch for opac-messaging.pl and opac-readingrecord.pl
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:41:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:41:12 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #43002|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:41:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:41:23 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
details, after LOGOUT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:42:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:42:56 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #25 from Josef Moravec ---
I tried it on non-empty table, but have the same issue... I am not able to
figure out where is the problem....
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:50:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:50:30 +0000
Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from
circ/pendingreserves.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42992|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:56:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 11:56:53 +0000
Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include
deleted items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #26 from Jonathan Druart ---
I was afraid of the complexity in the call stack, so did some tests:
$ more bug_8483.pl
use Modern::Perl;
use C4::Members;
my $borrowernumber=42;
my $issues = GetAllIssues( $borrowernumber, 'date_due desc' );
> select count(*) from old_issues where borrowernumber=42;
43
> select count(*) from issues where borrowernumber=42;
7
$ git checkout master; git reset --hard origin/master
$ git checkout -b bug_8483; git bz apply 8483
$ git checkout master; time perl bug_8483.pl
perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total
$ git checkout bug_8483; time perl bug_8483.pl
perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total
# => Ok we get the old_issues in addition of
# Adding some issues to the patron
> select count(*) from issues where borrowernumber=42;
49
# master
perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total
# bug_8483
perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total
210
# master
perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total
# bug_8483
perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total
600
# master
perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total
# bug_8483
perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:02:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:02:54 +0000
Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include
item data when using a resumption token
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927
Christophe Brocquet changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |christophe.brocquet at obspm.f
| |r
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:04:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:04:17 +0000
Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include
deleted items
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|3.8 |master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:04:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:04:54 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:05:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:05:01 +0000
Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the
correct module
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42999|0 |1
is obsolete| |
--- Comment #10 from Magnus Enger ---
Created attachment 43006
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43006&action=edit
Bug 14910: Redirect to the circulation module after a renew
iIf a patron is renewed from the circulation module, the librarian
should be redirected to the circulation module.
This works correctly if the renew is done from the patron module
(members).
This is caused by a typo in the template: desintation vs destination.
This patch also removes the cardnumber parameter to the setstatus.pl
script, it is not needed given that borrowernumber is always passed.
This has a good side-effect, it will fix bug 14691. The cardnumber does
not exist anymore, so no need to escape it :)
Test plan:
0/ Do not apply this patch
1/ Create a patron with a cardnumber with a quote (rm'me) and another
one without a quote (rmme)
2/ Go on the checkouts page (circ/circulation.pl)
3/ Renew the 2 patrons
=> With rm'me you are redirected to the circ module - ok
=> With rmme you are redirected to the member module - nok
4/ Go on the patron detail page (members/moremember.pl)
5/ Renew the 2 patrons
=> you are redirected to the member module - ok
6/ Delete the patrons
=> Nothing happend with rm'me, there is a JS error on the page - nok
=> rmme is deleted - ok
7/ Apply the patch and recreate rmme
8/ Repeat 2, 3, 4, 5
=> You are redirected to the correct module
9/ Delete the patrons
=> They are successfully deleted
Signed-off-by: Magnus Enger
Followed the test plan, works as advertised. (I did have some problems
initially, but that was caused by me not using the interface in
English...)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:09:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:09:12 +0000
Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:33:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:33:27 +0000
Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Medium patch
Keywords|rel_3_16_candidate |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:42:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:42:44 +0000
Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added
serials' items from serial receive/edit page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895
Olli-Antti Kivilahti changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |olli-antti.kivilahti at jns.fi
Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:56:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:56:33 +0000
Subject: [Koha-bugs] [Bug 14932] New: serials/serials-collection.pl-page is
very slow. GetFullSubscription* checks permission for each serial!
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932
Bug ID: 14932
Summary: serials/serials-collection.pl-page is very slow.
GetFullSubscription* checks permission for each
serial!
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: olli-antti.kivilahti at jns.fi
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
Currently we have subscriptions with 300+ serials received.
It takes a lot of time to show serials-collection.pl (~20s).
This is especially troublesome when receiving serials, since after receival we
get redirected to that page.
We no longer can receive daily serials in the allotted timeframe.
This quick and dirty fix prevents checking the subscription editing for each
serial, but instead checks it for the first serial only.
This reduced page load time by ~18s
TEST PLAN:
1. Receive ~300 serials (or just a bunch :) )
2. Observe the gradual slowing of the receival action.
AFTER THIS PATCH:
1. Receive ~300 serials more (or just a bunch)
2. Observe a significant performance improvement.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:57:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:57:20 +0000
Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very
slow. GetFullSubscription* checks permission for each serial!
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932
--- Comment #1 from Olli-Antti Kivilahti ---
Created attachment 43007
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43007&action=edit
Bug 14932 - serials/serials-collection.pl-page is very slow.
GetFullSubscription* checks permission for each serial!
Currently we have subscriptions with 300+ serials received.
It takes a lot of time to show serials-collection.pl (~20s).
This is especially troublesome when receiving serials, since after receival we
get redirected to that page.
We no longer can receive daily serials in the allotted timeframe.
This quick and dirty fix prevents checking the subscription editing for each
serial, but instead checks it for the first serial only.
This reduced page load time by ~18s
TEST PLAN:
1. Receive ~300 serials (or just a bunch :) )
2. Observe the gradual slowing of the receival action.
AFTER THIS PATCH:
1. Receive ~300 serials more (or just a bunch)
2. Observe a significant performance improvement.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:57:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 12:57:39 +0000
Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very
slow. GetFullSubscription* checks permission for each serial!
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932
Olli-Antti Kivilahti changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:08:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:08:25 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
--- Comment #7 from Colin Campbell ---
(In reply to Magnus Enger from comment #5)
> Colin: What do you think of the proposal from Jonathan?
> Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like
> a good idea.
(In reply to Jonathan Druart from comment #6)
> (In reply to Magnus Enger from comment #5)
> > Colin: What do you think of the proposal from Jonathan?
> > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like
> > a good idea.
>
> No, I would like to keep my QA token.
Its not really a transaction method but a utility but will attempt to test that
solution
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:13:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:13:29 +0000
Subject: [Koha-bugs] [Bug 14933] New: SIPserver should not use warn or die
to log errors
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933
Bug ID: 14933
Summary: SIPserver should not use warn or die to log errors
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: colin.campbell at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
warn and die are used in various places in the SIPServer but the messages are
lost as STDERR is closed by Net::Server in these cases the error message should
be logged to syslog as with other error and debug messages and exit should be
used
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:16:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:16:09 +0000
Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in
C4/Reserves.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--- Comment #4 from Jonathan Druart ---
Barton, to be consistent we should display the biblioitems fields when
creating/editing a letter from the "reserves" module.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:18:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:18:27 +0000
Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756
--- Comment #3 from Katrin Fischer ---
Hm, there is also the other way around - if we make Koha-to-MARC-Mappings 1:n,
we also need to change the procedures that are used for creating a record from
a non-marc format, for example in acquisitions.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:18:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:18:34 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Patch doesn't apply
--- Comment #29 from Jonathan Druart ---
To test bug 13918 I need to apply this patch set before but it does not apply
anymore.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:31:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:31:58 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
items based on lost/withdrawn statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504
--- Comment #5 from Jonathan Druart ---
Comment on attachment 42978
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42978
[SIGNED-OFF] Bug 14504: Add delete_items.pl: a command line batch deletion tool
Review of attachment 42978:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14504&attachment=42978)
-----------------------------------------------------------------
FAIL misc/cronjobs/delete_items.pl
FAIL pod
*** WARNING: Verbatim paragraph in NAME section in file
misc/cronjobs/delete_items.pl
::: misc/cronjobs/delete_items.pl
@@ +1,4 @@
> +#! /usr/bin/perl
> +
> +use warnings;
> +use strict;
warnings and strict are useless when Modern::Perl is already used.
@@ +8,5 @@
> +use C4::Circulation;
> +use Modern::Perl;
> +use Pod::Usage;
> +
> +my $VERSION='1.0';
How this is useful? We usually don't use it in scripts.
@@ +30,5 @@
> + , help => ''
> + , manual => ''
> + , version => ''
> + }
> +};
I am not really in favor of these 2 variables.
IMO it is preferable to stick to the structure of the already existing scripts
in misc/*
@@ +39,5 @@
> + , 'V|version' => sub { $OPTIONS->{flags}->{version} = 1 }
> + , 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 }
> + , 'm|manual' => sub { $OPTIONS->{flags}->{manual} = 1 }
> + , 'c|commit' => sub { $OPTIONS->{flags}->{commit} = 1 } # aka DO-EET!
> + , 'dry-run' => sub { $OPTIONS->{flags}->{commit} = 0;
I don't think dry-run is useful, it's in dry-run mode if commit is not given.
@@ +51,5 @@
> + exit;
> +}
> +
> +pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual};
> +pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 );
The script should not return 1 if help is specified.
It would be good to display on error for the @criteria==0 case (see msg option
of pod2usage).
@@ +65,5 @@
> +my $where_clause = ' where ' . join ( " and ", @criteria );
> +
> +verbose "Where statement: $where_clause";
> +
> +$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} . $where_clause );
typo tiems vs items, I suppose.
@@ +71,5 @@
> +
> +DELITEM: while ( my $item = $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) {
> + my $issue = GetOpenIssue( $item->{itemnumber} );
> + if( defined $issue ) {
> + verbose "Cannot delete '$item->{itemnumber}' -- item is checked out."
Shouldn't we also search for holds?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:32:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:32:05 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
items based on lost/withdrawn statuses
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:33:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:33:38 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
--- Comment #11 from Julian Maurice ---
Bug 14788 fixes the ccode problem, but not the "multiple values" problem.
So here is a patch that try to fix it (depends on 14788):
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:33:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:33:52 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
--- Comment #12 from Julian Maurice ---
Created attachment 43008
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43008&action=edit
Bug 11139: Add support for multiple values in AdvancedSearchTypes
AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl
have to support that.
AdvancedSearchTypes can have one or more of the following values:
'itemtypes', 'ccode', 'loc'. But this patch adds support only for
itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it
will change nothing to the behaviour of opac-topissues.pl.
This patch also removes duplicate code in template (the "Refine your
search" form was written in two different places)
This introduces a small behaviour change: when there is no results,
instead of having the form in the center of the page, it remains in the
left sidebar and we have a "No results" message in the main area.
Depends on bug 14788
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:34:07 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |14788
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788
[Bug 14788] Move opac-topissues.pl code into C4::Circulation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:34:07 +0000
Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into
C4::Circulation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |11139
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
[Bug 11139] opac-topissues does not work with CCODE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:34:20 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25956|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:34:34 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:38:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:38:50 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #6 from Marc V?ron ---
Ok, I can make it explode if I enter 0000-00-00 for date of birth:
---
Can't locate object method "ymd" via package "dateformat" (perhaps you forgot
to load "dateformat"?) at /usr/share/kohaclone/Koha/DateUtils.pm line 206.
---
I think we need a generic function in Koha::DateUtils to test a date string
against the 'dateformat' syspref.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:40:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:40:58 +0000
Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include
item data when using a resumption token
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:41:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:41:01 +0000
Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include
item data when using a resumption token
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42974|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 43009
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43009&action=edit
Bug 14927 Returns item info when resumptionToken is used
To test:
- activate OAI-PMH with the inclusion of items as explained on bug 12252
- set the OAI-PMH:MaxCount to a low number, 50 for instance
- go to the OAI-PMH page to get the records : [your koha
catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml
- check that item data is included
- get the resumptionToken at the end of the xml
- got to the next page of records [your koha
catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&resumptionToken=[your
resumption token]
- check that item data is now missing
Apply the patch, and repeat previous steps: item data is back.
Signed-off-by: Gaetan Boisson
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:44:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:44:43 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:44:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:44:46 +0000
Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in
contract management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42998|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 43010
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43010&action=edit
Bug 14929 - Fix missing display of help page in contract management
This patch renames / moves the file
koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt
to
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt
To test:
- Go to Home > Acquisition > [Vendor] > Contracts
(/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX)
- Verify that Help displays as appropriate.
Signed-off-by: Magnus Enger
Works as advertised. All the tabs similar to "Contracts" have
working help pages.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:45:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:45:10 +0000
Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include
item data when using a resumption token
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr
|ity.org |
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:52:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:52:48 +0000
Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from
circulation screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:52:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:52:51 +0000
Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from
circulation screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42893|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 43011
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43011&action=edit
Bug 14900: Add ability to pay all fees at once from circulation screen
Test plan:
1) Go to circulation screen for patron which has some not-payed charges (or
make same if needed)
2) You should see infromation about fees and charges with ability to pay it.
Note there is new link for paying all charges at once
3) Try the new link, you should be redirected to members/paycollect.pl, check
if there is right amount and try to pay charges
4) try the old link to make sure it works still well after this patch
Works as expected.
Signed-off-by: Marc V?ron
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:53:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:53:16 +0000
Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from
circulation screen
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:54:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 13:54:26 +0000
Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay
tab instead of account tab
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |ASSIGNED
--- Comment #7 from Jonathan Druart ---
Marc's suggestion sounds like a good compromise :)
Josef, do you agree?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:05:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:05:53 +0000
Subject: [Koha-bugs] [Bug 14934] New: Add the barcode number in the
description of all account lines both in the "Account" tab as in "Pay
fines" tab.
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934
Bug ID: 14934
Summary: Add the barcode number in the description of all
account lines both in the "Account" tab as in "Pay
fines" tab.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: costalc at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
It would be very helpful to add the barcode number in the description of all
account lines both in the "Account" tab as in "Pay fines" tab. Thus, it will be
possible to print the barcode in the fine invoice.
Please see PDF attached
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:08:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:08:15 +0000
Subject: [Koha-bugs] [Bug 14934] Add the barcode number in the description
of all account lines both in the "Account" tab as in "Pay fines" tab.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934
--- Comment #1 from bondiurbano ---
Created attachment 43012
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43012&action=edit
Add the barcode number in the description of all account lines both in the
"Account" tab as in "Pay fines" tab.
Fines view
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:09:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:09:48 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|z.tajoli at cineca.it |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:10:19 +0000
Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard
coded record length limit of 99999 bytes.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:10:22 +0000
Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard
coded record length limit of 99999 bytes.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42942|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 43013
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43013&action=edit
Bug 14858: removed record length limit test
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:10:52 +0000
Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard
coded record length limit of 99999 bytes.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=11399
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:10:52 +0000
Subject: [Koha-bugs] [Bug 11399] batch rebuild items tables
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |http://bugs.koha-community.
| |org/bugzilla3/show_bug.cgi?
| |id=14858
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:11:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:11:14 +0000
Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard
coded record length limit of 99999 bytes.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858
--- Comment #6 from Jonathan Druart ---
Thanks for the test plan Nick!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:22:00 +0000
Subject: [Koha-bugs] [Bug 14935] New: waiting and in transit items cannot be
reserved
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935
Bug ID: 14935
Summary: waiting and in transit items cannot be reserved
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: koha at univ-lyon3.fr
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
There's an issue with the possibility to place a hold on items waiting to be
pick-up or in transit when you choose that on shelf holds are not allowed.
In this case, items are not checked-out so there are considered to be
available.
But, they aren't, they are not on a shelf ready to be chosen by a patron but
stored aside.
So, other patrons should place a hold on it as they couldn't go on shelves to
take it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:22:48 +0000
Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Koha Team Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|REOPENED |RESOLVED
--- Comment #25 from Koha Team Lyon 3 ---
*** This bug has been marked as a duplicate of bug 14935 ***
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:22:48 +0000
Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be
reserved
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935
Koha Team Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nahuel.angelinetti at biblibre
| |.com
--- Comment #1 from Koha Team Lyon 3 ---
*** Bug 4319 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:22:56 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42355|0 |1
is obsolete| |
--- Comment #8 from Colin Campbell ---
Created attachment 43014
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43014&action=edit
Revised patch
Revised to remove duplication of method
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:24:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:24:22 +0000
Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be
reserved
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935
Koha Team Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anthony.laquerre at ccsr.qc.ca
| |, chris at bigballofwax.co.nz,
| |fridolin.somers at biblibre.co
| |m,
| |jesse at bywatersolutions.com,
| |katrin.fischer at bsz-bw.de,
| |koha-bugs at lists.koha-commun
| |ity.org,
| |koha at univ-lyon3.fr,
| |marjorie.barry-vila at ccsr.qc
| |.ca, nengard at gmail.com,
| |Susanne.Jerger at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:24:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:24:42 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673
Colin Campbell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #9 from Colin Campbell ---
Revised patch to inherit method from base class - works for me with Checkin and
Renewal requests - please test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:57:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:57:48 +0000
Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42853|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 43015
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43015&action=edit
Bug 14888: Add Koha::Cit[y|ies] classes
Tested both patches together, works as expected
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:59:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 14:59:39 +0000
Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888
--- Comment #6 from Jonathan Druart ---
Last patch just removes +use C4::Members::Messaging;
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:17:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:17:03 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #7 from Jonathan Druart ---
You can try with: 32/01/1970
Actually it will explode if the date is not correct.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:27:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:27:33 +0000
Subject: [Koha-bugs] [Bug 14934] Add the barcode number in the description
of all account lines both in the "Account" tab as in "Pay fines" tab.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934
bondiurbano changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #43012|0 |1
is obsolete| |
--- Comment #2 from bondiurbano ---
Created attachment 43016
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43016&action=edit
Add the barcode number in the description of all account lines both in the
"Account" tab as in "Pay fines" tab.
Fines view
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:36:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:36:47 +0000
Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks
back button after placing hold
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144
--- Comment #33 from Jonathan Druart ---
Kyle, I don't understand how the changes you introduced in the tests for
AddReserve highlight your changes in the subroutine.
It would be better to first submit a patch to fix the issue then to clean some
stuffs (indentation, replacement with Koha::Objects, etc.)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:57:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:57:10 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753
Charles Farmer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:58:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:58:11 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753
--- Comment #125 from Charles Farmer ---
Created attachment 43017
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43017&action=edit
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy,
Passwordrecovery.t
This is a collection of changes taken from different comments (but mostly
comment 21 and comment 122).
Passes qa and prove, on my machine at least.
There's also a new test file, Passwordrecovery.t, which covers every method of
C4::Passwordrecovery.
To test:
All normal checks plus :
1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ You should immediately get an error message
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:59:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 15:59:27 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753
Charles Farmer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|maxime.beaulieu at inlibro.com |charles.farmer at inlibro.com
CC| |charles.farmer at inlibro.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:01:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:01:56 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
accessible by UPC as well as ISBN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607
Jesse Weaver changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42253|0 |1
is obsolete| |
--- Comment #8 from Jesse Weaver ---
Created attachment 43018
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43018&action=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc
Signed-off-by: Alexis Rodegerdts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:01:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:01:54 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
accessible by UPC as well as ISBN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607
Jesse Weaver changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:02:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:02:11 +0000
Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks
back button after placing hold
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144
Zeno Tajoli changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|z.tajoli at cineca.it |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:02:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:02:52 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
accessible by UPC as well as ISBN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607
Jesse Weaver changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42547|0 |1
is obsolete| |
--- Comment #9 from Jesse Weaver ---
Created attachment 43019
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43019&action=edit
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to
GetNormalizedUPC
Signed-off-by: Alexis Rodegerdts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:06:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:06:08 +0000
Subject: [Koha-bugs] [Bug 14936] New: Add validation for date strings to
Koha::DateUtils
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Bug ID: 14936
Summary: Add validation for date strings to Koha::DateUtils
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcharlt at gmail.com
Reporter: veron at veron.ch
QA Contact: testopia at bugs.koha-community.org
Patch to add a generic function in Koha::DateUtils to test a date string
against the 'dateformat' syspref.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:13:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:13:22 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
--- Comment #1 from Marc V?ron ---
Created attachment 43020
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43020&action=edit
Bug 14936 - Add validation for date strings to Koha::DateUtils
To test:
- Apply patch
- prove t/DateUtils.t
Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug
and test as appropriate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:16:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:16:58 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #43020|0 |1
is obsolete| |
--- Comment #2 from Marc V?ron ---
Created attachment 43021
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43021&action=edit
Bug 14936 - Add validation for date strings to Koha::DateUtils
To test:
- Apply patch
- prove t/DateUtils.t
Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug
and test as appropriate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:18:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:18:47 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |14924
Patch complexity|--- |Small patch
Assignee|gmcharlt at gmail.com |veron at veron.ch
Status|NEW |Needs Signoff
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
[Bug 14924] Remove C4::Dates from members/memberentry.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:18:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:18:47 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |14936
Referenced Bugs:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
[Bug 14936] Add validation for date strings to Koha::DateUtils
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:25:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:25:45 +0000
Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42968|0 |1
is obsolete| |
--- Comment #4 from H?ctor Eduardo Castro Avalos ---
Created attachment 43022
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43022&action=edit
[SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme
and materialTypeLabel parameters back into showAuthor template call for 7xx
display in OPAC display.
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac record
details
3) Find or create a record with MARC tags 700,710,711
5) Click title to review record details.
6) Link to icon following contributor names should appear.
Signed-off-by: Hector Castro
Works as expected. Magnifying glass icon corrected
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:27:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:27:57 +0000
Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #43022|0 |1
is obsolete| |
--- Comment #5 from H?ctor Eduardo Castro Avalos ---
Created attachment 43023
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43023&action=edit
[SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT.
Added theme and materialTypeLabel parameters back into showAuthor
template call for 7xx display in OPAC display.
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and
opac record details
3) Find or create a record with MARC tags 700,710,711
5) Click title to review record details.
6) Link to icon following contributor names should appear.
Signed-off-by: Hector Castro
Works as expected. Magnifying glass icon corrected
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:28:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:28:31 +0000
Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hector.hecaxmmx at gmail.com
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:46:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:46:58 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #26 from Barton Chittenden ---
Getting
Software error:
Can't call method "get_attr" without a package or object reference at
/home/barton/kohaclone/patroncards/edit-batch.pl line 125.
To re-create:
1/ go to Home ? Tools ? Patron card creator ? Manage card Batches
(cgi-bin/koha/patroncards/manage.pl?card_element=batch)
2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new)
3/ click 'Add items' (opens new window --
cgi-bin/koha/patroncards/add_user_search.pl)
4/ click 'Search' to show all patrons (I don't have that many)
5/ click 'Add' on first patron -> Software error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:48:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:48:49 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
waiting holds to fill the next hold
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:48:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:48:58 +0000
Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to
SC but fails to checkin item on Koha
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ulrich.kleiber at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:58:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 16:58:43 +0000
Subject: [Koha-bugs] [Bug 14937] New: Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937
Bug ID: 14937
Summary: Expiration date for holds based
onReservesMaxPickUpDelay should not require
ExpireReservesMaxPickUpDelay
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle.m.hall at gmail.com
QA Contact: testopia at bugs.koha-community.org
C4::Letters::_parseletter will replace reserves.expirationdate with the date a
hold will be marked as problematic ( holds over ) if both
ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is
no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there
are many libraries that would like to send the last day to pick up a hold in
notices, but would rather deal with the expired waiting holds manually rather
than have Koha cancel them automatically.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:01:38 +0000
Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:01:40 +0000
Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937
--- Comment #1 from Kyle M Hall ---
Created attachment 43024
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43024&action=edit
Bug 14937 - Expiration date for holds based onReservesMaxPickUpDelay should not
require ExpireReservesMaxPickUpDelay
C4::Letters::_parseletter will replace reserves.expirationdate with the
date a hold will be marked as problematic ( holds over ) if both
ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled.
There is no reason this feature needs to rely on
ExpireReservesMaxPickUpDelay as there are many libraries that would like
to send the last day to pick up a hold in notices, but would rather deal
with the expired waiting holds manually rather than have Koha cancel
them automatically.
Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Disable ExpireReservesMaxPickUpDelay
4) Add reserves.expirationdate to your HOLD notice
5) Fill a hold for a patron
6) View the message, not that reserves.expirationdate is replaced
with the date the hold will be marked as problematic
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:01:51 +0000
Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:01:57 +0000
Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Change sponsored?|--- |Sponsored
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:37:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:37:13 +0000
Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS
authentication
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #41442|0 |1
is obsolete| |
--- Comment #2 from H?ctor Eduardo Castro Avalos ---
Created attachment 43025
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43025&action=edit
[SIGNED-OFF]Bug 14671 - Allow correct translation of CAS authentication
In authentication pages with CAS, the use of acronym or abbr tags does not
allow a correct translation of the text.
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7
It does not help a lot end users to know that CAS is Central Authentication
Service, I think. Now one can custom the login page with NoLoginInstructions
syspref to describe how to use the authentication.
This patch removes the use of acronym and abbr is authentication pages.
Test plan (example with fr-FR locale) :
- Without patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a "
- Is is translated in : msgstr "Si vous avez un compte "
- Apply patch
- Update translation files : cd misc/translator ; perl translate update fr-FR
- You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s
please "
- You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez "
- Same test for intranet authentication page
- Install the translation : cd misc/translator ; perl translate install fr-FR
- Look at the result
Signed-off-by: Hector Castro
Works as advertised. Tranlated OK, tested in spanish es-ES
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:39:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:39:14 +0000
Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS
authentication
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671
H?ctor Eduardo Castro Avalos changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hector.hecaxmmx at gmail.com
Status|Needs Signoff |Signed Off
--- Comment #3 from H?ctor Eduardo Castro Avalos ---
Hi Fridolin.
Just one question, how the users will know the meaning of the acronym?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:52:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:52:03 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
staff client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
Winona Salesky changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42424|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:52:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 17:52:40 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
staff client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
Winona Salesky changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42436|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:00:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 18:00:56 +0000
Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay
tab instead of account tab
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898
--- Comment #8 from Josef Moravec ---
I absolutely agree. I'll try to go this way.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:29:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 18:29:02 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
staff client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:29:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 18:29:05 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
staff client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42709|0 |1
is obsolete| |
--- Comment #7 from Nick Clemens ---
Created attachment 43026
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43026&action=edit
Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1.
Includes class="suppressed_opac" for library specific styles.
Suggested css: .suppressed_opac { color:red; font-size:1.25em;
font-weight:bold; float:right; margin-right:2em; clear:none; }
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:30:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 18:30:35 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
staff client
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
--- Comment #8 from Nick Clemens ---
Works as expected.
Style note: Without recommended CSS the 'Suppressed in Opac' in search results
is next to result number and above title/author. I think the default location
should be below these two if possible
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:44:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 18:44:05 +0000
Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y,
022$z => ISSN
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617
--- Comment #7 from Barton Chittenden ---
Just to be clear, this is ready for QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:20:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 19:20:21 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:31:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 19:31:01 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769
--- Comment #29 from Charles Farmer ---
Since June, did the BibLibre team had any chance to test/review/give their
opinion on the matter?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:37:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 19:37:28 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #43021|0 |1
is obsolete| |
--- Comment #3 from Marc V?ron ---
Created attachment 43027
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43027&action=edit
Bug 14936 - Add validation for date strings to Koha::DateUtils
To test:
- Apply patch
- prove t/DateUtils.t
Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug
and test as appropriate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:09:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 20:09:26 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #8 from Marc V?ron ---
Created attachment 43028
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43028&action=edit
Bug 14924 - (follow-up) Add date validation
This patch adds a date validation (see comment #3).
To test:
- Make sure that you test on top of
Bug 14936 (Add validation for date strings to Koha::DateUtils
- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as 0000-00-00 or 32/01/1970. You can can
copy/paste such strings to the date field, ignore the warning
message and submit. Verify that after submit you get a message
"Date of birth is invalid"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:10:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 20:10:03 +0000
Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to
Koha::DateUtils
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:10:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 20:10:34 +0000
Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:32:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 20:32:02 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
create a new batch per patron added
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
--- Comment #27 from Barton Chittenden ---
(In reply to Barton Chittenden from comment #26)
> Getting
>
> Software error:
>
> Can't call method "get_attr" without a package or object reference at
> /home/barton/kohaclone/patroncards/edit-batch.pl line 125.
>
> To re-create:
>
> 1/ go to Home ? Tools ? Patron card creator ? Manage card Batches
> (cgi-bin/koha/patroncards/manage.pl?card_element=batch)
> 2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new)
> 3/ click 'Add items' (opens new window --
> cgi-bin/koha/patroncards/add_user_search.pl)
> 4/ click 'Search' to show all patrons (I don't have that many)
> 5/ click 'Add' on first patron -> Software error.
This was user error on my part.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:35:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Oct 2015 20:35:37 +0000
Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS
authentication
In-Reply-To: