[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 1 12:49:13 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 41054
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054
Bug 14395: Code changes

Review of attachment 41054:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14395&attachment=41054)
-----------------------------------------------------------------

Please provide a better commit description.

::: C4/Circulation.pm
@@ +2772,5 @@
> +        {
> +            $soonestrenewal->truncate( to => 'day' );
> +        }
> +
> +        if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) )

Prefer dt_from_string to get a DateTime object (yes this already existed before
your patch, but it's worth to make things consistent).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list