[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12072

--- Comment #6 from Marc Véron <veron at veron.ch> ---
Hi Jonathan,

Propositon 1/ changes the behaviour of dt_from_string. This function is spread
all over the system, and we do not know what side effects it will have if we
change the behavior regarding the return value. That's why I decided not to
touch it at the moment.

Proposition 2/ Catch a croak: Is that done by surrounding dt_from_string with
an eval? (I simply do not know)

My opinion is that it is much better to have a dedicated function to validate a
date string. It works fine afak and it has tests. I know that it duplicates
code, but that can easily be streamlined later, after we finally have added the
long outstandig DD.MM.YYYY date format (Bug 12072).


(In reply to Jonathan Druart from comment #5)
> Marc,
> This is not the way to go, for several reasons.
> The main reason is that you c/p dt_from_string to create the new subroutine,
> which is bad.
> Then, if you have a look at dt_from_string, you will note 1 eval around the
> first DateTime->new (l. 156), but not around the second one (l. 164).
> So I think there are at least 2 better ways to know if a date is not
> correctly formatted:
> 1/ add an eval around the second DateTime->new call, the subroutine will
> return undef and the caller will have to check if something has been
> returned ;
> 2/ or catch the croak raised by the DateTime in the callers
> 
> I don't know what I would prefer (a bit early and not drank enough tea yet).

-- 
You are receiving this mail because:
You are watching all bug changes.