[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

--- Comment #37 from Kyle M Hall <kyle.m.hall at gmail.com> ---
The updates to the unit tests in the first patch do not actually test the new
functionality. Those changes were necessary to keep the tests from failing not
that the patron hold limit of one per record is enforced by AddReserve. I've
attached a new follow up that adds a unit test to specifically test this.

I have reworked the patches to split the unit tests into a separate patch for
easier testing.

(In reply to Jonathan Druart from comment #33)
> Kyle, I don't understand how the changes you introduced in the tests for
> AddReserve highlight your changes in the subroutine.
> 
> It would be better to first submit a patch to fix the issue then to clean
> some stuffs (indentation, replacement with Koha::Objects, etc.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.