[Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc Véron <veron at veron.ch> ---
Testing:

- Check with mysql: I did not have branchcode = NULL in the suggestions table.
- I tried to have one by removing syspref AnonymousPatron and then submit a
suggestion from OPAC, it resulted in an software error on Suggestions.pm line
108 (Column 'suggestedby' canot be null). 
- I set the branchcode of one of the suggestions to NULL usimg mysql
- I could reproduce the issue (the one with NULL branchcode did not show up)
- With patch, the NULL-suggestion shows up, that is OK so far.


More testing:
- In the mysgl table I have following branchcodes: FFL, FFL, FFL, MPL, NULL,
all with status ASKED

- On the home page, I have "Suggestions pending approval: 5" 

- But not all suggestions show up when managing suggestions, only the ones with
the same branchcode as the staff user (branch code FFL, all rights set,
superlibrarian), plus the NULL one if the patch is applied.

That is not consistent. 

The question is:
Should the librarian be able to manage the suggestions for all branches?

- If yes, all sggestions should display on Home > Acquisitions > Suggestions
management (I think including the NULL branchcode ones). 
  I would expect that for IndependentBranches = 'Don't prevent...' and
superlibrarians. (That's the behaviour of this syspref for other things).

- If no, the counter on the home page needs some adjustement to show the count
of pending suggestions that are manageable for the staff users branch
  I would expect that for IndependentBranches = 'Don't prevent...' current
staff user is not a superlibrarian.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.