[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 36875
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 36875:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11373&attachment=36875)
-----------------------------------------------------------------

Changing the sign of what was there before would need something done during
upgrade to change it to a new way of processing. This wasn't done, so frankly,
I think the logic I highlighted is broken. Though, admittedly, I did not run
this code yet.

::: C4/Accounts.pm
@@ +722,5 @@
>      my $insert = 'INSERT INTO accountlines (borrowernumber, accountno, date, amount, '
>      .  'description, accounttype, amountoutstanding, itemnumber, manager_id, note) '
>      . ' VALUES (?, ?, now(), ?, ?, ?, 0, ?, ?, ?)';
>  
> +    $dbh->do(  $insert, undef, $borrowernumber, $nextaccntno, $payment,

0-$amount is the negative of $amount. This is a vast change! Is this correct?

@@ +728,5 @@
>  
>      UpdateStats({
>                  branch => $user,
>                  type => 'payment',
> +                amount => $payment,

This is 0-$amount which is the negative of what was put here before.

@@ +739,4 @@
>              action            => 'create_payment',
>              borrowernumber    => $user,
>              accountno         => $nextaccntno,
> +            amount            => $payment,

On a positive note, by putting $payment earlier, it can be used nicely here.

@@ +820,4 @@
>      UpdateStats({
>                  branch => $branch,
>                  type => 'writeoff',
> +                amount => $payment,

Again, 0-$amount is negative of what was there before.

-- 
You are receiving this mail because:
You are watching all bug changes.