[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #209 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #206)
> QA Comment [Continuation]:
> 
> Thanks again for your hard work.
> 
> >> OPAC - Share a list - Enter email address - Return to your lists: This list
> >> does not exist ??  op=view && category=1. Adjust the URL? 
> > Fixed!
> > Yes, the op is 'list', not 'view".
> Fixed?? This is still a problem. Did you test it? (No blocker for such a
> large patch, but ... Do you miss the shelf number?) 

Hum no, I have tested the link just before the form submit!
The last patch fixes that.

> > Fixed! But... This is a bad one.
> > In opac-shelves.pl and shelves.pl, the join was only done on biblio.
> > But itemcallnumber is in the items table.
> > I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table
> > (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent 
> > without declared primary key).
> But this is not completely solved.
> View a private list in opac or staff: Bang.
> DBIx::Class::ResultSet::next(): Operation requires a primary key to be
> declared on 'Virtualshelfcontent' via set_primary_key
> How did you test this? :) Apparently, you forgot to include this added PK in
> your patches.
> Fixed by a hack now: added set_primary_key in Virtualshelfcontent in the
> local section.
> Please adjust this by defining the PK on the table and regenerating the DBIx
> file. 
> Note also that I removed the belongs_to from Biblioitem to Item. This is not
> a FK but a PK.

With my previous branch (so without your follow-ups), I have regenerated the
schema and I don't get an error viewing a private list.
That's why I have added the belongs_to rs.

-- 
You are receiving this mail because:
You are watching all bug changes.