[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
For both 11625 and 11747 (I have squashed the patch, I don't which patch is
guilty):

1)
 FAIL   installer/data/mysql/updatedatabase.pl
   FAIL   forbidden patterns
                forbidden pattern: Use INSERT IGNORE INTO on inserting a new
syspref (see bug 9071) (line 11101)
                forbidden pattern: Use INSERT IGNORE INTO on inserting a new
syspref (see bug 9071) (line 11116)

and

11109     print "Upgrade to $DBversion done (Bug 13379 - Modify
authorised_values.category to varchar(32))\n";
11120     print "Upgrade to $DBversion done (Bug 13379 - Modify
authorised_values.category to varchar(32))\n";

Wrong c/p.

Please prefer to amend the original patch than submit another follow-up (to
prevent future conflicts).

Otherwise the code looks good. I am redoing some UI tests.

-- 
You are receiving this mail because:
You are watching all bug changes.