[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 19 13:02:35 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 42597
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42597
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - Unit Test

Review of attachment 42597:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7560&attachment=42597)
-----------------------------------------------------------------

You are using 3 different ways to insert data in your tests: Test::Builder,
Koha::Object->store and directly the INSERT statement.
It would make sense to use Test::Builder for all of them.

::: t/db_dependent/Accounts.t
@@ +291,4 @@
>      }
>  };
>  
> +subtest "makepartialpayment() tests" => sub {

Wrong c/p.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list