[Koha-bugs] [Bug 14778] DBIC should create/own the DB handler

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, robin at catalyst.net.nz

--- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The only (and not minor) issue I see is: tests relying on Test::DBIx::Class
only make sense in t/* (i.e. the point of db_dependent tests is that they are
integration tests, using the DB for real). So the problem is that if we don't
have Test::DBIx::Class packaged, then the .deb packages cannot build (they need
prove t/ pass clean).

So we need to either:
(a) have Test::DBIx::Class and friends packaged (Robin?)
(b) have those tests conditional to its availability:

use Module::Load::Conditional qw/check_install/;

BEGIN {
    if ( check_install( module => 'Test::DBIx::Class' ) ) {
        plan tests => 11;
    } else {
        plan skip_all => "Need Test::DBIx::Class"
    }
}


(b) is sub optimal. We want to run the tests. But (a) needs Robin's
intervention I think, so I have no clue. Help!

-- 
You are receiving this mail because:
You are watching all bug changes.