[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 21 15:44:20 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

--- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
(In reply to Kyle M Hall from comment #6)
> Thanks Olli! I do like your version ( except for the odd default value ; ).
Heh, you should see the odd default values in acquisitions.module.
(if don't know what to do order, order one piece of this Biblio)

> However it does break from the standard way of doing things in
> cleanup_database.
Erm... The cleanup_database is from the 1990's based on the programming
patterns. Why do you need to follow such a standard? Is it too much to ask to
expose business logic inside the core API rather than access DB directly from
the Controller/script?
This is the root of many issues in Koha and we need to break that crappy cycle
of untestable/automatable features.

> That being said, if you *were* to add a unit test I'd say
> that would be a worthwhile improvement and I'd be more than happy to
> deprecate my version and sign off on yours!

Well now nobody can test it, unless they refactor the feature by moving the
business logic inside the API.
This modification would need to pass yet another community process.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list