[Koha-bugs] [Bug 14247] System preference for news author display

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is something wrong here - the 3 patches, even with the one I put back
lack the logic in the template/pl files for the display. 

bumblebee:~/kohaclone (14247-newsauthor) $ git diff --stat HEAD~3
 installer/data/mysql/atomicupdate/bug_14247-add_news_prefs.sql       |  2 ++
 installer/data/mysql/sysprefs.sql                                    |  1 +
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref | 10
++++++++++
 t/db_dependent/NewsChannels.t                                        | 45
++++++++++++++++++++++++++++++++++++++++++++-
 4 files changed, 57 insertions(+), 1 deletion(-)

Also, the tests are not passing - I think because we are missing a dependency -
"newsauthor" or bug 14246. We need this to be signed off please asap and this
to be put in order.

bumblebee:~/kohaclone (14247-newsauthor) $ perl t/db_dependent/NewsChannels.t
1..11
ok 1 - use C4::NewsChannels;
# Category CAT1 not found, inserting
# Borrower BRWR1 not found, inserting
ok 2
ok 3 - Correctly failed on no parameter!
ok 4 - Successfully added the first dummy news item!
DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list'
at /home/katrin/kohaclone/C4/NewsChannels.pm line 69.
DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list'
at /home/katrin/kohaclone/C4/NewsChannels.pm line 69.
# Looks like you planned 11 tests but ran 4.
# Looks like your test exited with 255 just after 4.

Please check asap - feature slush is close!)

-- 
You are receiving this mail because:
You are watching all bug changes.