[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 22 10:21:22 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43653|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 43742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43742&action=edit
Bug 15039 - Move top language menu to include and streamline logic

The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is
used at other places as well (see Bug 14776).

This patch moves it to a file masthead-langmenu.inc to make it re-usable.

Additionally it streamlines the logic (not all combinations of Opac sysprefs
that should display the menu did so).

To test:
- Apply patch
- Verify, that the language menu displays / does not display with combinations
of:
  - opaclanguagedisplay (Allow)
  - opaclanguages ( > 1 language selected)
  - OpacLangSelectorMode (top or both)
- Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not
interfere
  with the lenguage menu (before, at least one of them had to be on to display
the menu)
- Verify that language switching works as before.

Signed-off-by:  Chris Kirby <christopherlawrencekirby at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list