[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 43752
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43752
Bug 14694 [QA Followup] - Fix unit tests

Review of attachment 43752:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14694&attachment=43752)
-----------------------------------------------------------------

::: t/db_dependent/DecreaseLoanHighHolds.t
@@ +92,5 @@
>  my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' };
>  
>  my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
> +is( $data->{exceeded},        1,          "Static mode should exceed threshold" );
> +is( $data->{outstanding},     6,          "Should have 5 outstanding holds" );

6 vs 5

@@ +123,5 @@
>  $unholdable->damaged(-1);
>  $unholdable->store();
>  
>  $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
> +is( $data->{exceeded}, 1, "Should exceed threshold with one damanged item" );

typo damaged

@@ +137,5 @@
>  $unholdable->notforloan(-1);
>  $unholdable->store();
>  
>  $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
> +is( $data->{exceeded}, 1, "Should exceed threshold wiht one notforloan item" );

typo with vs with

-- 
You are receiving this mail because:
You are watching all bug changes.