[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #17)
> > 6 vs 5
> 
> That is a purposeful change. The issue was that the logic of the unit test
> was off by one. The assumption was that the number of holds must greater
> than or equal to, but as per the code and sys pref definition, the number of
> holds must be simply greater than. Thus adding one more hold fixes all the
> tests.

(In reply to Jonathan Druart from comment #14)
> > +            if ( $holds->count() <= $threshold ) {
> 
> And an inclusive here.

So should this be < also?

> ::: Koha/Biblio.pm
> @@ +41,5 @@
> > +or list of Koha::Item objects in list context.
> > +
> > +=cut
> > +
> > +sub items {
> 
> Wouldn't be better to use a DBIx::Class relation?
> Something like bug 14819.
> 
> ::: installer/data/mysql/sysprefs.sql
> @@ +103,3 @@
> >  ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'),
> >  ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'),
> > +('decreaseLoanHighHoldsIgnoreStatuses', '', 'damaged|itemlost|notforloan|withdrawn', "Ignore items with these statuses for dynamic high holds checking", 'Choice'),
> 
> Wrongly placed.

What about these 2 comments?

-- 
You are receiving this mail because:
You are watching all bug changes.