[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Kyle M Hall <kyle.m.hall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #4 from Kyle M Hall <kyle.m.hall at gmail.com> ---
(In reply to Nick Clemens from comment #3)
> Test plan worked as expected with one question: if they are hours overdue on
> an hourly loan, and not a day overdue, it seems to not suspend them.  Should
> it?

I suppose the question is, should hourly loans suspend in days the number of
hours overdue? If an hourly loan is 3 hours late, should the patron be
suspended for 3 days? If so, changes are needed.

This patch makes it so that hourly loans are suspended based on the number of
*days* the item is overdue. Anything less than 24 hours rounds down to 0 days.
Should hourly loans suspend for a minimum of 1 day if they are overdue by less
than 24 hours?

I think the logic of how hourly loan suspension should work needs to be decided
before it can be decided if this patch is correct, or if it needs additional
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.