[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |In Discussion

--- Comment #9 from Mirko Tietgen <mirko at abunchofthings.net> ---
Hi Marc,

it works mostly well for me. Among other things I tried changing the date
format in between and using wrong preset dates in the URL like
circulation.pl?borrowernumber=51&duedatespec=10%2F30%2F2015+23%3A59

While the old version shows warnings or even breaks ("30" in the "month"
position leads to a software error because it is not between 1 and 12), with
your patch the wrong format passed by URL is displayed in the calendar, but no
warnings or errors appear and the correct date is used when checking out. 

(In reply to Marc Véron from comment #6)

> - Verify that data displays properly (including for users with a card
>   that expires in the  near future, see syspref 'NotifyBorrowerDeparture')

That breaks it for me:

> Template process failed: undef error - KohaDates: filter not found at /home/mirko/koha/C4/Templates.pm line 121.

As you seem to have tested this, is that taken care of by one of the other
patches by any chance? I would sign off if it has a "depends on" that works.

-- 
You are receiving this mail because:
You are watching all bug changes.