[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Kyle, this currently doesn't apply. I read through the code and noted some
things to fix and have some suggestions:

0) AR_PRINT
I'd like to rename the letter code to AR_SLIP or ARSLIP to be consistent with
the other slips we have.

+('circulation', 'AR_PRINT', '', 'Article Request - Print Slip', 0, 'Test'
Test?

1) circ/request-article.pl
Copyright statements are a bit odd for a new file :)
@@ -0,0 +1,53 @@
+#!/usr/bin/perl
+
+# Copyright 2015 ByWater Solutions
+# Copyright 2000-2002 Katipo Communications
+# Copyright 2011 Catalyst IT

2) installer/data/mysql/atomicupdate/bug_14610.sql
Please amend to use AFTER... to make sure the column always ends up in the same
spot.
+ALTER TABLE  `issuingrules` ADD  `article_requests` ENUM(  'no',  'yes', 
'bib_only',  'item_only' ) NOT NULL DEFAULT  'no';

3) kohastructure.sql 
Can you please add database documentation comments for the new table?

4) Please include the new notices in all translated sample_notices.sql as well.
xt/sample_notice.t is your friend :)
Small typo in one of the subjects: Article Request _Recieved_

5) circ/article-requests.tt
- notes = prompt("Reason for cancelation:"); is not translatable
- [% ar.borrower.surname %], [% ar.borrower.firstname %] please fix display for
the case, that a firstname is not given (organisations for example).

6) request-article.tt
- var c = confirm("Are you sure you want to change the pickup library from " +
previo... is not translatable - Additionally there is this new 'format' syntax
that you can use to fill in the placeholders nicely and that allows for good
translation. If you don't know what I am talking about I can probably dig up an
example :)

7) opac/opac-article-request-cancel.pl
+        authnotrequired => 0,
Please account for the OpacPublic system preference!
Same for the other 2 opac/ .pl files.

8) Terminology - instead of 'open' maybe 'pending' would be better? This is
what we use for suggestions and I think holds. Sometimes you are using 'open'
and other times 'pending' (intranet-main.tt)

-- 
You are receiving this mail because:
You are watching all bug changes.