[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have added a follow-up - but there are 2 things:

1) Please add some unit tests.
2) When you add a new framework with the same frameworkcode than an existing
framework, I think it should display the appropriate message, but instead, it
updates the existing framework description. On current master, you have a
silent SQL erorr in the logs, but the existing framework is left unchanged.
(not ideal either...)

Otherwise this works quite well, so almost there!

-- 
You are receiving this mail because:
You are watching all bug changes.