[Koha-bugs] [Bug 12395] Save order line's creator

Sun Oct 25 12:37:41 CET 2015

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #69 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) xt/tt_valid.t was failing, I fixed it in my follo-up, please check.
1..3
ok 1 - TT syntax: not using TT directive within HTML tag
not ok 2 - <body> tag with id and class attributes
#   Failed test '<body> tag with id and class attributes'
#   at xt/tt_valid.t line 91.
# Files list: 
# intranet-tmpl/prog/en/modules/acqui/showorder.tt: 12
ok 3 - Token received same as original put on stack
# Looks like you failed 1 test of 3.

2) Some of the title="MARC" should be title="Card" - fixed in my follow-up,
please check.

3) t/db_dependent/Acquisition/NewOrder.t fails, please fix (blocker) :(
I think it's not only the test - in my testing the creator is not saved for
newly created orders. Only the 'migrated' orders have created_by set in the
database.
1..8
ok 1 - Inserting an order with no params returns undef and croaks
ok 2 - Inserting an order with no budget_id returns undef and croaks with
expected error message
ok 3 - Inserting an order with no biblionumber returns undef and croaks with
expected error message
ok 4 - Inserting an order with no basketno returns undef and croaks with
expected error message
ok 5 - Inserting an order with no quantity returns undef and croaks with
expected error message
ok 6 - Koha::Acquisition::Order->insert set quantityreceivedto 0 if undef is
given
ok 7 - Koha::Acquisition::Order->insert set entrydate to today
not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if
not given
#   Failed test 'Koha::Acquisition::Order->insert set created_by to logged in
user if not given'
#   at t/db_dependent/Acquisition/NewOrder.t line 93.
#          got: undef
#     expected: '42'
# Looks like you failed 1 test of 8.

4) The 'look' of the new modal for order information is slightly off,
especially font and font-size are unusual. Would be nice to be 
more consistent with Koha's look and feel here.

-- 
You are receiving this mail because:
You are watching all bug changes.