[Koha-bugs] [Bug 14980] Add a page showing one news

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 43404
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404
Bug 14980 - Add a page showing one news

Review of attachment 43404:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14980&attachment=43404)
-----------------------------------------------------------------

Some small issues, noted below, and 2 other things:

1) You can access internal news (staff interface) via guessing ids. (blocker)
2) The feature is too hidden for my taste as we don't even show the id
internally. A link 'Show in OPAC' or similar could be helpful.

I'd also like to encourage you to talk to Viktor Sarge - I know he has been
working on adding a 'Mini-CMS' feature to Koha and I think there are already
some patches for small steps in that direction available on bugzilla.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt
@@ +29,5 @@
> +
> +                    <div id="page-main">
> +                        <h4 class="newsheader">[% data.title | html %]</h4>
> +                        <div class="newsbody">[% data.new %]</div>
> +                        <div class="newsfooter">(published on [% data.expirationdate %])</div>

Please take a look at bugs 14246-14246 - it's a new feature that just passed QA
that will allow to also display the author of a news.

::: opac/opac-page.pl
@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

Please always use Modern::Perl;

@@ +31,5 @@
> +    {
> +        template_name   => "opac-page.tt",
> +        query           => $query,
> +        type            => "opac",
> +        authnotrequired => 1,

Please check if this should be:
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),

-- 
You are receiving this mail because:
You are watching all bug changes.