[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some comments about this:

- It looks like the patch assumed that the file names from Glyphicons and Font
Awesome would match. They do not. This led to a bit of silliness in QA
follow-ups... (7).

- Not always there is an equivalent icon available in Font Awesome. I have
tried to pick an icon close to our original one or come up with a good
alternative suggestion - the ones that changed most would be (Glyphicon name):
hdd, zoom-in, zoom-out, hold.

- Especially hold is a hard one - the best I could come up with was
sticky-note-o. But then I learned that this was only added in Font Awesome 4.4,
while bug bug 13696 adds 4.3. The patch is marked - the result is the same with
and without the patch currently - no icon shown.

- The git grep ... statements given in the first patch now come back
'non-empty' - as we have added more icons with some of the new features being
pushed. Most of the files seem to belong to the label creators. It would be
good to follow-up on those and others before release.

I like that the Font Awesome Icons look nicer - less pixelated than our current
ones, especially if you zoom in. But there are some catches like that we have
to replace some of the icons. Leaving to RM for final decision and
review/pushing back to QA :)

My recommendation would be to update to 4.4 (makes sense to start with the
newest set) and to do follow-ups once the new features have been pushed to fix
the remaining or newly introduced icons.

-- 
You are receiving this mail because:
You are watching all bug changes.