[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 44072
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44072
Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more)

Review of attachment 44072:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14903&attachment=44072)
-----------------------------------------------------------------

::: circ/circulation.pl
@@ +174,4 @@
>  
>  my $stickyduedate  = $query->param('stickyduedate') || $session->param('stickyduedate');
>  my $duedatespec    = $query->param('duedatespec')   || $session->param('stickyduedate');
> +$duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); };

No, only if duedatespec if given. Otherwise "Automatic due date" is always
filled with now.

@@ +203,4 @@
>      $datedue = output_pref({ dt => dt_from_string, dateonly => 1, dateformat => 'iso' });
>      $datedue .= ' 23:59:00';
>  } elsif( $duedatespec_allow ) {
> +    if ($datedue) {

That's not the same code as before ($dateduespec vs $datedue), please double
check.

-- 
You are receiving this mail because:
You are watching all bug changes.