[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #109 from Frédéric Demians <frederic at tamil.fr> ---
> Have you tested the patch?

Yes. My questions are not related to your patch WUI and result, but to your
implementation, your goals.

Somehwhere in the process, I take a look at the code, spend time on it, trying
to figure out how it works, how it has been done. Testing and QAing is all
about that.

I have mixed feeling, when I find duplicated code (for example). In opac/opac-
export.pl and catalog/export.pl:

SWITCH:
    for ($recommendation) {
        if (/^simple-dc-rdf/) {
            ($error,$marc) = marc2dcxml($marc, $recommendation, 0,
            1, undef, undef, $resource_url , $formats);
            $format = "dublin-core." . $formats;
            last SWITCH; }
        if (/^dc-rdf/) {
            ($error,$marc) = marc2dcxml($marc, $recommendation, 1,
            1, undef, undef, $resource_url, $formats);
            $format = "dublin-core." . $formats;
            last SWITCH; }
        if (/^dc-xml/) {
            ($error,$marc) = marc2dcxml($marc, $recommendation, $qualifier,
            1, $root_element, $xsischemalocation, undef, undef);
            $format = "dublin-core.xml";
            last SWITCH; }
        if (/^oai-dc/) {
            ($error,$marc) = marc2dcxml($marc, $recommendation);
            $format = "dublin-core.xml";
            last SWITCH; }
        if (/^srw_dc/) {
            ($error,$marc) = marc2dcxml($marc, $recommendation);
            $format = "dublin-core.xml";
            last SWITCH; }
    }


Or in Koha::Crosswalk::DublinCore.pm, line 242, you get:

if ( exists $self->{xsi_schemaLocation} ) {
    $dataxml{'xsi_schemaLocation'} = $self->{xsi_schemaLocation};
}
if ( exists $self->{xsi_schemaLocation} ) {
    $dataxml{'opt_namespace'} = $self->{opt_namespace};
}
if ( exists $self->{xsi_schemaLocation} ) {
    $dataxml{'opt_namespace_url'} = $self->{opt_namespace_url};
}

Is it valid?

> With this module (Koha::Crosswalk::DublinCore) I can support more metada
> than the simple 15 DC elements (Element Set Version 1.1). This Simple DC is
> used for OAI and SRW in xml format. But also i can reproduce this other
> guidelines/recommendations:

How will you extend the semantic of the produced metadata with
MARC::Crosswalk::Dublincore? If you want more than the 15 DC elements, doesn't
it mean that you need a mean to improve, granularize the way Koha MARC record
is transformed. The current DC exported from Koha is not that good because (1)
it doesn't work for Unimarc, (2) it doesn't allow each library to tweak the
transformation from MARC to DC (the way it's done by OAI server).

> And RDF::Trine can serialize multiple rdf formats (rdf-json, rdf-xml,
> nquads, nquads-canonical, turtle) also give us the opportunity of storing
> the triples in databases; with RDF::Query we can perform queries with SPARQL

It's far beyond the scope of this patch. Open a new bug if you want, and name
it Semantic-Koha, or Sekoa.

-- 
You are receiving this mail because:
You are watching all bug changes.