[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

--- Comment #15 from Marc Véron <veron at veron.ch> ---
(In reply to Bernardo Gonzalez Kriegel from comment #14)
> Sorry, but my test was bad, only tried with superlibrarian.
> 
> Marc, are you sure that needed permission check is
> 
> CAN_user_parameters_parameters_remaining_permissions
> 
> Can't found another instance of that.

Bernardo,

I wanted the link not to display if the user is not able to edit the currencies
table.

Who should be able to display and edit the currencies table:

When I go through the permissions, I think the following should be able to
display and edit the table:

- superlibrarian (yes)
- paramters (yes)
  - manage_circ_rules (no, but see remark below)
  - parameters_remaining_permissions (yes)

Strange enough, with manage_circ_rules I can not only edit the circulation
rules (what I would expect), but it seems that it allows to edit ALL of the
parameters. I think this is a bug, what is yout opinion about?

My implementation tests for parameters_remaining_permissions (i.e. 
CAN_user_parameters_parameters_remaining_permissions internally as I figured
out). This triggers the 'mother'-permission for parameters as well.

I tested with two browsers, one as superlibrarian for setting the permission
and one on an other computer with the non-superlibrarian. It worked well for
me.

But anyway, it is not really a very important enhancement. I'd rather like to
see the C4:Dates sign-offs for Bug 14870 'Delete C4/Dates.pm from System' and
Bug 12072 'New dateformat dd.mm.yyyy' move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.