From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:13:08 +0000 Subject: [Koha-bugs] [Bug 14764] New: Add OPAC News branch selector Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Bug ID: 14764 Summary: Add OPAC News branch selector Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org When branch-specific news are added users can only view entries from their home branch and global ones. These patches adds a syspref, 'OPACNewsBranchSelect' that allows a list of branches to be displayed above the left OpacNav field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:34:14 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #1 from Martin Persson --- Created attachment 42129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42129&action=edit Bug 14764: OPAC news selector - URL parameter This patch adds an URL-based override for the homebranch variable in opac-main.pl. Allows viewing of arbitrary branches. Possible security issue: The user changes branch parameter to perform SQL or XSS injection. This would not be possible via the database, as the foreign key constraint would block arbitrary code. However, the News retrieval function is using prepared statements which are immune to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:34:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:34:40 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #2 from Martin Persson --- Created attachment 42130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42130&action=edit Bug 14764: OPAC news selector - Template tags Adds tags to the template files to inject branch list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:35:13 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #3 from Martin Persson --- Created attachment 42131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42131&action=edit Bug 14764: OPAC news selector - Add syspref Adds the new system preference to the pref and SQL files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:35:39 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #4 from Martin Persson --- Created attachment 42132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42132&action=edit Bug 14764: OPAC news selector - Atomic update SQL Adds an SQL file to perform the database upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 23:52:40 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #12 from Jesse Weaver --- (In reply to Jonathan Druart from comment #11) > Yes it was a UNIMARC install. > > But same on a MARC21 fresh install. > > Check "cn_source is hidden by default". > Refresh cataloguing/additem.pl?biblionumber=109 > > The third column is hidden (damaged status). This is very bizarre; I can't duplicate this issue. Could I ask you to post a link to a sandbox where this issue occurs, so I can poke around? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 00:27:26 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 --- Comment #9 from Mason James --- (In reply to Liz Rea from comment #8) > I think this is different, I get this issue in my vagrant and/or gitify > installs as well. Something to do with the fact that it can't write a temp > file, but I didn't have time to try and fix it. yep, thats all correct ^ :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 03:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 01:23:55 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #12 from Robin Sheat --- (In reply to Heather from comment #9) > One of the main purposes of a complete alphabetical browse for the library > user is exactly what you mentioned: when the user is unsure of the spelling, > but has most of it, e.g., "Stephens" or "Stevens," or something like > "Ralphs," or "Rolphs." Right, and that is handled here by allowing fuzzier searching. Having everything there doesn't seem like it'd make that particularly easy, as things might be separated quite widely visually even if there's only a one character difference. Y'know what'd be interesting, incorporating "sounds like" searching to it. I'll leave that for another time though. I also shudder to think how that'd be internationalised :) > The alphabetic browse is also invaluable for the catalogers on the staff > side doing authority control--it's the easiest way to spot heading > variations. Certainly, but I'm consciously not focussing on that side of things, or stuff will get too big too fast :) > (BTW, the Authority Search in the demo catalog has a problem--do an > authority search with default options & the term "Birds" & you get: > Software error: > Can't call method "each" on unblessed reference at > /opt/kohaclones/browse/Koha/SearchEngine/Elasticsearch/Search.pm line 265. > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error.") That doesn't surprise me just because this code is new and largely unstressed, though I'll look into it, it shouldn't be happening. > Do a similar authority search in our catalog for ships: > http://keys.bywatersolutions.com/cgi-bin/koha/opac-authorities-home. > pl?op=do_search&type=opac&operator=contains&value=ships&marclist=any&and_or=a > nd&orderby=HeadingAsc > > And you get close to a subject heading browse result--the only problem is > that it returns only main headings, not an alphabetic list of the terms > *with subdivisions* as used in the records, which would be very useful to > the user. I bring this up because, IMO, as it is, authority > control/authority search is not an alternative to a true alphabetical > catalog browse for the public opac user, of subject terms with subdivisions > as used in the catalog. Just FYI, this isn't using the authority database, it's using the actual search indices. I may swap out the database some time soon with one that has a more "properly" catalogued catalogue, to see how that looks. (In reply to Katrin Fischer from comment #10) > I was thinking this morning, maybe a 'starts with' search option could help > to bring the result list a little closer to an alphabetic index. Could this > be an option? This is exactly what is there right now, or I misunderstand you :) > Example: Exact, Author: Miller > The first result shown is "Millard, Annie". > I didn't expect that for the exact search option, but only with fuzzy > activated. Hmm. That must be a bug. That shouldn't be happening. > Another issue could be related to ISBD punctuation in the fields. Often > there are 2 entries which what seems to be the same author, only different > by a . at the end: > > Example: Exact, Author: Smith > Smith, Alexander Gordon. > Smith, Alexander Gordon > Smith, Jim > Smith, Jim. > > Would be good if those could be merged for display and search. I've been thinking about this. It's a bit problematic, due to way the MARC->ES conversion works. However, I want to figure out how to tap into this for some other things too, if I can attach bits of Perl to certain points in the conversion, it might be doable. We're still going to get other weird results though, e.g. Rowling, J. K. Rowling, J.K. fixing that in a way that doesn't cause false positives, or make the results inaccurate, may be hard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 03:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 01:35:02 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #92 from Peter Zhao --- I'v install a ES Koha. Index works well and ES server can search records, but the Opac cannot search. "No results found! You did not specify any search criteria. Error: Unable to perform your search. Please try again. " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 03:41:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 01:41:05 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #93 from Robin Sheat --- (In reply to Peter Zhao from comment #92) > I'v install a ES Koha. > Index works well and ES server can search records, but the Opac cannot > search. Can you provide more detail? Comment #80, at the bottom, shows how to debug the traces between ES and Koha. This will tell you what search request is actually being made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 04:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 02:06:55 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #94 from Peter Zhao --- (In reply to Robin Sheat from comment #93) > (In reply to Peter Zhao from comment #92) > > I'v install a ES Koha. > > Index works well and ES server can search records, but the Opac cannot > > search. > > Can you provide more detail? Comment #80, at the bottom, shows how to debug > the traces between ES and Koha. This will tell you what search request is > actually being made. koha-opac-error_log shows: [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] # Request to: http://localhost:9200, referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] curl -XHEAD 'http://localhost:9200/koha_biblios?pretty=1', referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] , referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] # Response: 200, Took: 14 ms, referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] # 1, referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 2015] opac-search.pl: [Serializer] ** encountered object '1', but neither allow_blessed nor convert_blessed settings are enabled at /usr/local/share/perl/5.14.2/Search/Elasticsearch/Role/Serializer/JSON.pm line 24., referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 2015] opac-search.pl: , called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch/Bag.pm line 127. With vars: {'var' => {'from' => 0,'query' => {'query_string' => {'fuzziness' => 'auto','default_field' => '_all','query' => '(title:best)','default_operator' => 'AND','lenient' => bless( do{\\(my $o = 1)}, 'JSON::PP::Boolean' )}},'size' => 20,'facets' => {'subject' => {'terms' => {'field' => 'subject__facet'}},'author' => {'terms' => {'field' => 'author__facet'}},'itype' => {'terms' => {'field' => 'itype__facet'}}}}}, referer: http://127.0.1.1/ [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 2015] opac-search.pl: Use of uninitialized value $error in concatenation (.) or string at /home/koha/kohaes/opac/opac-search.pl line 578., referer: http://127.0.1.1/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 05:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 03:54:25 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 --- Comment #3 from Aleisha Amohia --- (In reply to Martin Stenberg from comment #2) > Can no longer reproduce. Perhaps already fixed? I still get the uninitialized value in split warn, but not the extra warns triggered by the 'Childrens Fiction' option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 06:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 04:19:48 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 --- Comment #4 from Aleisha Amohia --- Created attachment 42133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42133&action=edit Bug 10468: Fix for qa tools Hopefully this gets rid of those complaints! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 06:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 04:50:55 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:07:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:07:23 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #95 from Robin Sheat --- (In reply to Peter Zhao from comment #94) > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > 2015] opac-search.pl: [Serializer] ** encountered object '1', but neither > allow_blessed nor convert_blessed settings are enabled at > /usr/local/share/perl/5.14.2/Search/Elasticsearch/Role/Serializer/JSON.pm > line 24., referer: http://127.0.1.1/ > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > 2015] opac-search.pl: , called from sub > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch/Bag.pm line 127. > With vars: {'var' => {'from' => 0,'query' => {'query_string' => {'fuzziness' > => 'auto','default_field' => '_all','query' => > '(title:best)','default_operator' => 'AND','lenient' => bless( do{\\(my $o = > 1)}, 'JSON::PP::Boolean' )}},'size' => 20,'facets' => {'subject' => {'terms' > => {'field' => 'subject__facet'}},'author' => {'terms' => {'field' => > 'author__facet'}},'itype' => {'terms' => {'field' => 'itype__facet'}}}}}, > referer: http://127.0.1.1/ Interesting. What do you get as the output of: $ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' Also, what about: perl -MJSON::XS::Boolean -e '' Thirdly, does installing libjson-xs-perl make things work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:08:34 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14755 --- Comment #2 from Joonas Kylm?l? --- Steps to reproduce the problem: 1. Have an imported biblio record (from maybe some other version of koha / with some other library's details) which you haven't edited yet but only created a new item for it. 2. Go to the biblio records detail view 3. Save the record by clicking Save->MARCXML 4. Click Edit->Record 5. Click Save 6. Save the record by clicking Save->MARCXML 7. Compare the output of the two files, for example with diff -u . 8. Notice that the latter file has changed its info / there is more info. So the above info adding doesn't happen in the stage-marc-import.pl script and it is wasted time to go each and one thousand records by hand and just click save on them (you need to add this info or otherwise the bug 14755 appears). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:08:34 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:13:21 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14762 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 [Bug 14762] Importing records doesn't add missing subelements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:13:21 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14755 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 [Bug 14755] Checking in gives error 500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:32:41 +0000 Subject: [Koha-bugs] [Bug 14765] New: newHolidays.pl doesn't handle unexpected input very well Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14765 Bug ID: 14765 Summary: newHolidays.pl doesn't handle unexpected input very well Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org If I call new holidays without any parameters I get the error: "No branchcode argument to new. Should be C4::Calendar->new(branchcode => $branchcode) at /home/putti/kohaclone/tools/newHolidays.pl line 87." and also if there is malformed date in the input I get "Date::Calc::Day_of_Week(): not a valid date at /home/putti/kohaclone/C4/Calendar.pm line 609." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:33:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:33:10 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #96 from Peter Zhao --- (In reply to Robin Sheat from comment #95) > (In reply to Peter Zhao from comment #94) > > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > > 2015] opac-search.pl: [Serializer] ** encountered object '1', but neither > > allow_blessed nor convert_blessed settings are enabled at > > /usr/local/share/perl/5.14.2/Search/Elasticsearch/Role/Serializer/JSON.pm > > line 24., referer: http://127.0.1.1/ > > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > > 2015] opac-search.pl: , called from sub > > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > > /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch/Bag.pm line 127. > > With vars: {'var' => {'from' => 0,'query' => {'query_string' => {'fuzziness' > > => 'auto','default_field' => '_all','query' => > > '(title:best)','default_operator' => 'AND','lenient' => bless( do{\\(my $o = > > 1)}, 'JSON::PP::Boolean' )}},'size' => 20,'facets' => {'subject' => {'terms' > > => {'field' => 'subject__facet'}},'author' => {'terms' => {'field' => > > 'author__facet'}},'itype' => {'terms' => {'field' => 'itype__facet'}}}}}, > > referer: http://127.0.1.1/ > > Interesting. What do you get as the output of: > > $ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' > > Also, what about: > > perl -MJSON::XS::Boolean -e '' > > Thirdly, does installing libjson-xs-perl make things work? koha at koha:~$ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' $VAR1 = bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ); koha at koha:~$ perl -MJSON::XS::Boolean -e '' koha at koha:~$ koha at koha:~$ sudo apt-get install libjson-xs-perl [sudo] password for koha: ?????????... ?? ????????????? ????????... ?? libjson-xs-perl ?????????? libjson-xs-perl ????????? ??? 0 ????????? 0 ???????? 0 ?????? 0 ????????? (In reply to Robin Sheat from comment #95) > (In reply to Peter Zhao from comment #94) > > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > > 2015] opac-search.pl: [Serializer] ** encountered object '1', but neither > > allow_blessed nor convert_blessed settings are enabled at > > /usr/local/share/perl/5.14.2/Search/Elasticsearch/Role/Serializer/JSON.pm > > line 24., referer: http://127.0.1.1/ > > [Tue Sep 01 10:03:30 2015] [error] [client 127.0.0.1] [Tue Sep 1 10:03:30 > > 2015] opac-search.pl: , called from sub > > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > > /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch/Bag.pm line 127. > > With vars: {'var' => {'from' => 0,'query' => {'query_string' => {'fuzziness' > > => 'auto','default_field' => '_all','query' => > > '(title:best)','default_operator' => 'AND','lenient' => bless( do{\\(my $o = > > 1)}, 'JSON::PP::Boolean' )}},'size' => 20,'facets' => {'subject' => {'terms' > > => {'field' => 'subject__facet'}},'author' => {'terms' => {'field' => > > 'author__facet'}},'itype' => {'terms' => {'field' => 'itype__facet'}}}}}, > > referer: http://127.0.1.1/ > > Interesting. What do you get as the output of: > > $ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' > > Also, what about: > > perl -MJSON::XS::Boolean -e '' > > Thirdly, does installing libjson-xs-perl make things work? koha at koha:~$ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' $VAR1 = bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ); koha at koha:~$ perl -MJSON::XS::Boolean -e '' koha at koha:~$ koha at koha:~$ sudo cpanm JSON::XS After "JSON::XS" was installed, Opac works well. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:43:01 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #97 from Robin Sheat --- (In reply to Peter Zhao from comment #96) > koha at koha:~$ perl -MData::Dumper -MJSON -e 'print Dumper JSON::true;' > $VAR1 = bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ); > koha at koha:~$ perl -MJSON::XS::Boolean -e '' > koha at koha:~$ > koha at koha:~$ sudo cpanm JSON::XS > > After "JSON::XS" was installed, Opac works well. Thanks a lot! Cool. I suspect that your setup is particularly non-standard. I tried to uninstall JSON::XS to test, but I couldn't as it would have cause other critical things to uninstall also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:49:53 +0000 Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952 --- Comment #5 from Srdjan Jankovic --- > - chown "$username:$username" "/var/log/koha/$name" > + chown "$username:adm" "/var/log/koha/$name" > > The last line should not have the group adm but $username instead. This is because in case of a multi-site installation we may want to have an external process to be able to access all individual site logs. Without a common group it makes it hard to manage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 05:59:28 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 --- Comment #3 from Katrin Fischer --- Joonas, this is rather confusing me :) We use the staged imports a lot and have never run into problems like you describe. Could you show which elements were missing in your record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:16:10 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? --- (In reply to Mason James from comment #1) >1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday >rows) Could you give some example table? It would be easier to test. >2/ add a loong circ rule for an itemtype (my rule has 140 days) Do you mean loan period? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:17:40 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | CC| |julian.maurice at biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:24:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:24:32 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 --- Comment #4 from Joonas Kylm?l? --- (In reply to Katrin Fischer from comment #3) > Joonas, this is rather confusing me :) We use the staged imports a lot and > have never run into problems like you describe. Could you show which > elements were missing in your record? Output from diff of MARCXML files: ... - 00977cam a22003374a 4500 + 00961cam a22003374a 4500 ... - 20150831135648.0 + 20150831142850.0 ... - KI - 2013-08-26 00:00:00 + BK + ddc After those changes were made the bug 14755 didn't show up anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:24:59 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #140 from Julian Maurice --- The 'borrowers' permission is required for both /borrowers and /borrowers/XXXX except if XXXX is the borrowernumber of the loggedinuser Test plan for authentication: 1/ Log in to staff interface with a borrower that have 'borrowers' permission 2/ Go to http://INTRANET/api/v1/borrowers and http://INTRANET/api/v1/borrowers/XXXX (where XXXX is a valid borrowernumber). You should see borrowers data 3/ Remove the 'borrowers' permission 4/ Go to http://INTRANET/api/v1/borrowers. You should see an error (and HTTP code 403) 5/ Go to http://INTRANET/api/v1/borrowers/XXXX (where XXXX is a valid borrowernumber different from the logged-in user's borrowernumber). You should see an error (and HTTP code 403) 6/ Go to http://INTRANET/api/v1/borrowers/XXXX (where XXXX is the logged-in user's borrowernumber). You should see borrower's data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:30:21 +0000 Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952 --- Comment #6 from Joonas Kylm?l? --- (In reply to Srdjan Jankovic from comment #5) > > - chown "$username:$username" "/var/log/koha/$name" > > + chown "$username:adm" "/var/log/koha/$name" > > > > The last line should not have the group adm but $username instead. > > This is because in case of a multi-site installation we may want to have an > external process to be able to access all individual site logs. Without a > common group it makes it hard to manage. But do we have some script to change the group (during installation)? Hmm.. I'm not so sure about this. Maybe there could be some config file (not sure if there is one already for this kind of things) where it could be changed to one that the user wants or if not specified it would default to $username. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 06:58:29 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 --- Comment #5 from Katrin Fischer --- Hm, this looks to me like the bug is not so much in the staged import, but in the data - it looks like you might be importing with an itemtype code that is not defined in your database (942$c). Once you open and save the record again, the itemtype will probably be set to the first in the pull down of available codes... and that's why the checkout works after. Could this be possible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:09:35 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #15 from David Cook --- I think I've nearly arrived at a first draft. On Friday, I'll look at writing out test plans/instructions, and doing some last minute changes. I still need to fix the POD, add unit tests, and add help pages, but I figure that can wait until some initial testing is finished, since the first round of testing might bring more changes to make... I'm excited though! This is probably the closest the OAI-PMH harvester code has ever come to actually being usable for other people than just myself :p -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:13:54 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 --- Comment #6 from Joonas Kylm?l? --- (In reply to Katrin Fischer from comment #5) > Hm, this looks to me like the bug is not so much in the staged import, but > in the data - it looks like you might be importing with an itemtype code > that is not defined in your database (942$c). Once you open and save the > record again, the itemtype will probably be set to the first in the pull > down of available codes... and that's why the checkout works after. Could > this be possible? Adding an item type entry in Koha for code KI solved the problem indeed. But I think the feature Edit biblio adds still some other data. So why not do that already in import stage, because some data might be vital(?). - 00977cam a22003374a 4500 + 00961cam a22003374a 4500 For example, should the line above be like that or is it enough that there is the old line / is this some info which we really don't need but we just happen to have? And I got the picture from that Edit record feature, by quickly looking at the code, that it also adds some missing subfields. So what if these imported records don't have those subfields and it will cause some problems... (and then the only fix would be go one by one through the imported records or fixing the data some how) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:20:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:20:03 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 Ketan Kulkarni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ketan at carvingit.com --- Comment #4 from Ketan Kulkarni --- I am also facing the same issue in koha 3.20.3. Not sure if any part of the code will need an update to work with CGI::Param. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:25:03 +0000 Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? --- I get this error when running the script after the patch: Global symbol "$no_create" requires explicit package name at ./misc/stage_file.pl line 57. Global symbol "$no_create" requires explicit package name at ./misc/stage_file.pl line 123. Execution of ./misc/stage_file.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:27:37 +0000 Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 --- Comment #4 from Joonas Kylm?l? --- Created attachment 42134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42134&action=edit Bug 12289: (follow-up) fix the compilation error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:28:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:28:22 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 --- Comment #7 from Katrin Fischer --- 005 is a timestamp of the last change and the first positions of the leader that change are the record length - this change being caused by the other changes. So I think Koha's current behaviour is correct and nothing needs to be changed on import. I think what we could do is catch an invalid itemtype code better, so it's easier to locate the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:29:21 +0000 Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 --- Comment #5 from Joonas Kylm?l? --- Now it looks to me that this is working as it should. Someone, sign-off this please! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:37:15 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #22 from Jonathan Druart --- "For a while" meant " I didn't find any versions where it works. If you check out the commit before "Bug 5917 : Swapping templates over" (d4cd05126da3accef83144d8322fcd455d7eba9b), you will see the same structure in the TT: 128
  • Waiting
    • But no track of a atdestination variable passed to the template. So if this is correct, I am sure nobody will care if we remove this tab :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2015 07:40:14 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 --- Comment #1 from Julian Maurice --- In master, due to bug 3206, a biblio without marcxml is considered deleted and thus there is no error. However, something can be done for stable versions. In 3.18.x and 3.20.x, oai.pl fails with the following error: 
    Empty String at /home/koha/src/opac/oai.pl line 228

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 09:48:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 07:48:31 +0000
Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without
	marcxml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

--- Comment #2 from Julian Maurice  ---
Created attachment 42135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42135&action=edit
Bug 14363: OAI-PMH: Handle records without marcxml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 09:48:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 07:48:56 +0000
Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without
	marcxml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |3.20
             Status|ASSIGNED                    |Needs Signoff

--- Comment #3 from Julian Maurice  ---
Patch is for 3.20.x but should apply well on 3.18.x as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 09:49:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 07:49:42 +0000
Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without
	marcxml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 09:57:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 07:57:30 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #73 from Jonathan Druart  ---
(In reply to Joonas Kylm?l? from comment #68)
> (In reply to Jonathan Druart from comment #28)
> > Created attachment 41347 [details] [review] [review]
> > Bug 13618: Remove html filters at the OPAC
> > 
> > This patch removes the html filters at the OPAC, if necessary.
> > 
> > Generated with:
> >   perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc
> 
> @@ -85,7 +85,7 @@
>                                  [% END %]
>                              ).
>                          [% END %]
> -                         %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url
> %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~
>                      [% END # / IF total %]
>                      
    
>                  [% END # / IF searchdesc %]
> 
> Shouldn't that one also be removed?

I don't think so, I think I have tested them.

(In reply to Joonas Kylm?l? from comment #71)
> Why not have also raw SCOUserCSS if we let the user have OPACUserCSS as raw?

Done in another patch.

(In reply to Joonas Kylm?l? from comment #72)
> The front page in Staff side doesn't render html under News->What's Next.

New patch pushed to the remote branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:00:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:00:52 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42111|0                           |1
        is obsolete|                            |

--- Comment #15 from Olli-Antti Kivilahti  ---
Created attachment 42136
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42136&action=edit
Bug 14536 - PageObject squashable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:04:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:04:29 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #16 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:05:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:05:50 +0000
Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of
	nomatch options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:06:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:06:25 +0000
Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:06:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:06:38 +0000
Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of
	nomatch options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:07:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:07:17 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #141 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:07:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:07:52 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:08:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:08:48 +0000
Subject: [Koha-bugs] [Bug 10468] patron print summary should show more
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:09:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:09:25 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:09:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:09:46 +0000
Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:10:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:10:28 +0000
Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options
 to longoverdue.pl to include or exclude borrower categories.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:11:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:11:07 +0000
Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:12:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:12:09 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:12:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:12:48 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #3 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:13:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:13:04 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #16 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:13:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:13:46 +0000
Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays
 when calculating a holds last pickup date.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:14:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:14:21 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Large patch

--- Comment #12 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:15:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:15:00 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
	authentication.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:15:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:15:37 +0000
Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:16:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:16:17 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:16:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:16:43 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:17:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:17:12 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:18:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:18:07 +0000
Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to
 'sip' or 'commandline'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:18:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:18:42 +0000
Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:19:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:19:50 +0000
Subject: [Koha-bugs] [Bug 14748] REST API Testing framework
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:20:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:20:13 +0000
Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(),
 aka. make a Koha::Object from various input types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Large patch

--- Comment #7 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:20:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:20:45 +0000
Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:21:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:21:00 +0000
Subject: [Koha-bugs] [Bug 14746] Set up logging and configuration file
 reading for Mojolicious
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Large patch

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:21:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:21:25 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:21:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:21:55 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:22:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:22:40 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:23:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:23:03 +0000
Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears
	inappropriately
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:23:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:23:29 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:24:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:24:07 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:24:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:24:45 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:25:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:25:39 +0000
Subject: [Koha-bugs] [Bug 14722] Refactor the export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:27:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:27:00 +0000
Subject: [Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:27:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:27:39 +0000
Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth
	Enabled
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:28:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:28:24 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:28:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:28:33 +0000
Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:28:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:28:48 +0000
Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:29:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:29:33 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:29:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:29:59 +0000
Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in
	cardnumber
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:30:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:30:35 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:30:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:30:46 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/withdrawn statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:31:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:31:01 +0000
Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |z.tajoli at cineca.it

--- Comment #14 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:31:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:31:13 +0000
Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:31:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:31:49 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:32:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:32:02 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #13 from Jonathan Druart  ---
On sandbox 13 (reminder: the DB is erased every day).

http://pro.test13.biblibre.com/cgi-bin/koha/admin/columns_settings.pl :
barcode, dateaccessioned and homebranch are hidden by default.

http://pro.test13.biblibre.com/cgi-bin/koha/cataloguing/additem.pl?biblionumber=9
"Propri?taire", "D?positaire" and "Code barres" are hidden

Propri?taire: homebranch
D?positaire: holdingbranch
Code barres: barcode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:32:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:32:06 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:33:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:33:25 +0000
Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP,
 any 'reserve' field is not being expanded correctly.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:33:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:33:46 +0000
Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:34:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:34:09 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:34:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:34:27 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #14 from Jonathan Druart  ---
Ok, I found why it does not work: dateaccessioned is not mapped.

Same with my previous example, barcode is not mapped on my local install.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:34:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:34:34 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:35:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:35:00 +0000
Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks
 back button after placing hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:37:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:37:24 +0000
Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do
 not use print template
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:38:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:38:16 +0000
Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:38:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:38:30 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:49:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:49:46 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:49:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:49:48 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41971|0                           |1
        is obsolete|                            |
  Attachment #42088|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart  ---
Created attachment 42137
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42137&action=edit
Bug 11247: Fix calls of TransformHtmlToXml

The ind_tag of TransformHtmlToXml is unused.
Some calls to this function incorrectly revert indicator and ind_tag (which
is not a problem when both are empty..)

Patch of Srdjan Jankovic, amended and signed off by Marcel de Rooy.

The following calls are fixed:
call in acqui/addorder.pl: switched indicator with ind_tag
call in acqui/addorderiso2709.pl replaced too
acqui/finishreceive.pl replaced too

These calls are fine:
two calls in cataloguing/additem.pl are fine
call in serials/serials-edit.pl is fine
call in tools/batchMod.pl is fine

The folllow-up patch adds a simple unit test.

Signed-off-by: Marcel de Rooy 
With AcqCreateItem=='placing an order', tested if adding an order still
worked (covered both addorder.pl and addorderiso2709.pl).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 10:49:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 08:49:54 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

--- Comment #20 from Jonathan Druart  ---
Created attachment 42138
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42138&action=edit
Bug 11247: Add a simple unit test for TransformHtmlToXml

The unit test is db dependent (as Jonathan correctly remarked),
since the sub checks a preference.

Test plan:
Run t/db_dependent/Biblio/TransformHtmlToXml.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:04:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:04:28 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #5 from Martin Persson  ---
Created attachment 42139
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42139&action=edit
Bug 14764: OPAC news selector - Fix RSS feed

Update opac-main RSS feed to match current branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:19:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:19:31 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Martin Persson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from Martin Persson  ---
Test plan:

1) Add more libraries, at least two in total is needed. Make note of whoich is
your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) On the left side all branches should be listed as links. Select one, you
should now see global news and the news for the selected branch, regardless of
whether logged in or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:20:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:20:43 +0000
Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print
 routing list window to not appear
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42106|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart  ---
Created attachment 42140
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42140&action=edit
Bug 14505: single quotes in journal number cause print routing list window to
not appear

Escapes single quotes from serial.serialseq string.

Test plan:

1. Have a serial with a number which has single quote in it.
2. Go to Serials -> Find some serial subscription -> Serial collection.
3. Set up a routing list for this serial.
4. Click on Print list under the column Routing.
5. Notice that the print window doesn't open.
6. Apply patch.
7. Notice that the print window opens.

Sponsored-by: Vaara-kirjastot

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:20:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:20:41 +0000
Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print
 routing list window to not appear
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:50:03 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

--- Comment #14 from Lari Taskula  ---
Created attachment 42141
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42141&action=edit
Bug 13906: (follow-up) - MessageQueueFactory for adding messages to
message_queue

This follow-up adds MessageQueue factory for generating messages into
message_queue. The default 
hash key is field "from_address". MessageQueueFactory sets the newly generated
messages into
'pending' status via C4::Letters to await further processing from your tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:51:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:51:02 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:53:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:53:57 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #98 from Peter Zhao  ---
ES Opac cannot support Chinese language? I try to search Chinese word in
http://elasticsearch.koha.catalystdemo.net.nz/ and my ES, they also show
"Software error".

Software error:

Can't escape \x{57FA}, try uri_escape_utf8() instead at
/opt/kohaclones/elasticsearch/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
line 217.

For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error. 

Software error:

Can't escape \x{57FA}, try uri_escape_utf8() instead at
/home/koha/kohaes/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 217.

For help, please send mail to the webmaster (webmaster at koha), giving this error
message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 11:57:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 09:57:16 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

paxed  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at pttk.fi

--- Comment #8 from paxed  ---
(In reply to Joonas Kylm?l? from comment #6)
> 
> -  00977cam a22003374a 4500
> +  00961cam a22003374a 4500
> 
> For example, should the line above be like that or is it enough that there
> is the old line / is this some info which we really don't need but we just
> happen to have?
> 

vink vink, Kansalliskirjastolta l?ytyy MARC21 suomeksi:
http://www.kansalliskirjasto.fi/extra/marc21/bib/000.htm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:13:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:13:17 +0000
Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out
 confirmation does not cancel the hold when item is checked out.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:13:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:13:20 +0000
Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out
 confirmation does not cancel the hold when item is checked out.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42103|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 42142
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42142&action=edit
Bug 14640: Add tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:13:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:13:28 +0000
Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out
 confirmation does not cancel the hold when item is checked out.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

--- Comment #5 from Jonathan Druart  ---
Created attachment 42143
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42143&action=edit
Bug 14640 - 'Cancel Hold' check box on check-out confirmation does not cancel
the hold when item is checked out.

This bug is dealing with the situation where an item is checked out to a
patron that is not the next in line hold-wise for an item. In this case,
Koha will warn the librarian that there are holds on the item and
show the first person in line. Again, I want to stress that this
is the case where the item *is not waiting* for a patron. The
hold for the patron listed will just have a priority of 1.

The only situation where the "Cancel hold" checkbox will function
is when the priority 1 hold is an item level hold. This is due to
the fact that CancelReserve is being passed the trio of
biblionumber, borrowernumber, and itemnumber rather than the
singular reserve_id.

1) place biblio level hold on a book to borrower A.
2) check out an item of the book to borrower B.
3) When confirming checkout, check the 'Cancel hold' check-box, and
   click the "Yes, check out" button.
4) Note the hold was not canceled
5) Apply this patch
6) Repeat steps 1 through 3
7) Note the hold was indeed canceled

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:21:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:21:12 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart  ---
The same line should be affected at the intranet too (members/memberentry.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:27:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:27:01 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #153 from Marcel de Rooy  ---
(In reply to Marc V?ron from comment #152)
> Hi Marcel,
> 
> Thanks a lot for QAing. I really appreciate.
> 
> Question: 
> Can we remove the 'problematic' patches from this huge patch set and then do
> a second round (maybe with a new bug number) after the 'unproblematic'
> patches have been pushed?
> 
> Marc

It seems to that your corrections should not be that hard or time consuming.
I would favor to reduce the number of patches here. There is no particular need
to add a patch for each module or script.

But of course, I have no objection if you move some patches elsewhere.

Please set back to SO if you are ready..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:27:12 +0000
Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP,
 any 'reserve' field is not being expanded correctly.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

--- Comment #5 from Jonathan Druart  ---
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> (In reply to Jonathan Druart from comment #1)
> > Test plan:
> > 1/ Define RESERVESLIP with, at least,
> >     Hold until: <>
> 
> On current master RESERVESLIP belongs to 'circulation' module,
> on edit there is no access to 'reserves' values.
> 
> If you change first to 'Holds' module, and save, 
> then you can access 'reserves' values.
> 
> Could be this the cause of the problem?

No, the value is not retrieved from the DB.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:27:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:27:58 +0000
Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP,
 any 'reserve' field is not being expanded correctly.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:28:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:28:25 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:28:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:28:41 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:28:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:28:50 +0000
Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:13 +0000
Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:25 +0000
Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete
 items based on lost/withdrawn statuses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:31 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:40 +0000
Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in
	cardnumber
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:48 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:49 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #99 from Jonathan Druart  ---
(In reply to Peter Zhao from comment #98)
> ES Opac cannot support Chinese language? I try to search Chinese word in
> http://elasticsearch.koha.catalystdemo.net.nz/ and my ES, they also show
> "Software error".
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /opt/kohaclones/elasticsearch/Koha/SearchEngine/Elasticsearch/QueryBuilder.
> pm line 217.
> 
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error. 
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /home/koha/kohaes/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 217.
> 
> For help, please send mail to the webmaster (webmaster at koha), giving this
> error message and the time and date of the error.

This is fixed by
  Bug 12478: Fix encoding issue on facets
Try to add the last 8 patches from this bug report.
The Robin's branch does not contain these fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:29:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:29:58 +0000
Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:30:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:30:05 +0000
Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:30:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:30:20 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:34:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:34:31 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #3 from Jonathan Druart  ---
Comment on attachment 41633
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as
ISBN

Review of attachment 41633:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14607&attachment=41633)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
@@ +58,4 @@
>                                    
    
>                                  [% END %]
>                                  [% IF ( BakerTaylorEnabled ) %]
> +                                    [% bt_id = ( item.browser_normalized_upc || item.browser_normalized_upc ) %]

This does not make any sense :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:34:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:34:38 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:35:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:35:05 +0000
Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search
 in staff client and opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:40:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:40:17 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42100|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy  ---
Created attachment 42144
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42144&action=edit
Bug 14526: (follow-up) add a space before equals sign

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:42:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:42:05 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

--- Comment #15 from Marcel de Rooy  ---
Thx Joonas for signing off.
I have moved your patch to the third position in the list to prevent problems
applying them.
Please take care to keep patches on a report in the right order. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 12:50:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 10:50:02 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #61 from Marcel de Rooy  ---
Repeated on fresh master:
Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 bug_11213: C4::VirtualShelves::Page::shelf_contents()

Since our git version may be different, please apply them again with your git
version and resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:09:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:09:24 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #29 from Jonathan Druart  ---
Marcel,
Can I suggest to make easier the readability of GetReserveFee?
$cntX are not good variable names.

Moreover, we could restrict the number of queries executed in some cases.
For instance if there are no reserves, no need to execute the count on items
and issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:20:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:20:07 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

--- Comment #11 from Jonathan Druart  ---
Comment on attachment 42029
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42029
Bug 14297 - Holds Queue building ignoring holds where pickup & home branch
don't match and item is not from least cost branch

Review of attachment 42029:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14297&attachment=42029)
-----------------------------------------------------------------

::: C4/HoldsQueue.pm
@@ +492,5 @@
> +                foreach my $branch (@$pull_branches) {
> +                    my $holding_branch_items = $items_by_branch{$branch}
> +                      or next;
> +
> +                    $holdingbranch ||= $branch;

I am not sure to understand this line, in which case it's needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:20:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:20:39 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

--- Comment #12 from Jonathan Druart  ---
Shouldn't you change the version to master (instead of 3.18)?;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:28:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:28:04 +0000
Subject: [Koha-bugs] [Bug 14658] Split
 PatronSelfRegistrationBorrowerUnwantedField into two preferences for
 creating and editing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:42:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:42:13 +0000
Subject: [Koha-bugs] [Bug 14658] Split
 PatronSelfRegistrationBorrowerUnwantedField into two preferences for
 creating and editing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41643|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 42145
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42145&action=edit
Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two
preferences for creating and editing

Tested and signed off, still needs sign-off from non-ByWater community member.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:43:01 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #100 from Jonathan Druart  ---
(In reply to Robin Sheat from comment #91)
> (In reply to Jonathan Druart from comment #81)
> > Note the following:
> > MariaDB [koha_es_unimarc]>  insert into search_field (name, type) select
> > distinct mapping, type from elasticsearch_mapping;
> > Query OK, 73 rows affected, 57 warnings (0.05 sec)
> > Records: 73  Duplicates: 0  Warnings: 57
> > 
> > MariaDB [koha_es_unimarc]> show warnings;
> > +---------+------+--------------------------------------------+
> > | Level   | Code | Message                                    |
> > +---------+------+--------------------------------------------+
> > | Warning | 1265 | Data truncated for column 'type' at row 1  |
> 
> Hmm, I remember that, but I'm not 100% sure it mattered. Could be wrong
> though.

It's caused by the fact that you insert a an empty string into an enum field.
I am not sure about the consequences.

> Here it is:
> 
> http://elasticsearch.koha.catalystdemo.net.nz/files/koha_es_marc21.sql.bz2
> 
> it's not the best data, but it's good enough for messing about with.

Great, thanks. Another set of data :)

> > It comes from the 008
> > > "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty)
> > 008 090409|||||||||xx |||||||||||||| ||und||
> > > The Korean Go Association's learn to play go  "pubdate":"uuuu"
> > 008 971030muuuu9999nyua          000 0 eng 
> > 
> > But the index should not contain an invalid date.
> 
> Hmm. I don't know if we can put validation into the fixer rules. I'll have
> to explore that some further. Possibly also telling ES that this must be a
> number could cause bad data to get rejected, but it may reject the whole
> record, not sure.
> 
> Do you happen to know how zebra handles that?

Absolutely no idea.

> > For Solr (you can find the code on the BibLibre repo at
> > https://git.biblibre.com/biblibre/koha_biblibre/commits/dev/solr Browse
> > C4/Search/), we used a system of plugins. And there is a Date plugin
> > (https://git.biblibre.com/biblibre/koha_biblibre/blob/
> > bd38ce1811289fcfbd75a37ec99fc4cd3c5d37f4/C4/Search/Plugins/Date.pm) which
> > does this job.
> > A plugin can be linked to a mapping.
> 
> We probably can't directly reuse that, at present we're using Catmandu do do
> the data conversion and interfacing with ES for the most part. But it's
> possible I can hook something in somewhere.

We will have to do some data pre-processing before indexing the records.
I need to learn more about ES, but with Solr we had to process the date values
for date type mappings.
Otherwise it is not possible to correctly request on this index (for instance
dates range, or sort by, etc.).
By the way, the date type is only used on acqdate and copydate, why not on
other dates (at least pubdate)?

> (In reply to Jonathan Druart from comment #90)
> > Something else, there is a sort issue in the facets:
> > 
> > [Some entries]
> >  Zeitoun, Ariel,
> >  ? Cadhain, M?irt?n.
> >  ?lez, Ts..
> > 
> > ? should be after O, not after Z.
> 
> Line 573 of opac/opac-search.pl does a sort with cmp, which isn't very
> unicode aware. I'm putting that in the not-my-problem bin as it's in
> upstream :)

Yes, and, IMO, there is a design issue here.
We should not reuse the pl and tt files.
How do you plan to add features that Zebra cannot provide? :)
Not sure it will be maintainable to add conditions (if SE == 'ES') in the TT.
For instance, for the facets, we would like to display them as ES retrieve them
(order by most used), and add the number of occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:51:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:51:07 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #101 from Jonathan Druart  ---
 95 # TODO implement in the future - I don't know the best way of doing this
yet.
 96 # If fork: make sure process group is changed so apache doesn't wait for
us.
 97 
 98 =cut
 99 
100 sub update_index_background {

FWIW: I have developed an "index queue" for Solr. It's inconceivable to index
on the fly one by one in a real world.
Koha just added a recordid in a file and the index queue watches the file and
indexes a batch when needed (x minutes passed or y records in the file).
I can provide you more information if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 13:58:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 11:58:07 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #102 from Jonathan Druart  ---
Ok, just saw the comment about the date format:

Koha/ElasticSearch.pm
185             # TODO be aware of date formats, but this requires pre-parsing
186             # as ES will simply reject anything with an invalid date.

We would pre-process the data at this point, if a "plugin is linked to" (to
define) this field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:18:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:18:42 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Martin Persson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:27:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:27:37 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Martin Persson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42129|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Persson  ---
Created attachment 42146
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42146&action=edit
Bug 14764: OPAC news selector - URL parameter

This patch adds an URL-based override for the homebranch
variable in opac-main.pl. Allows viewing of arbitrary branches.

Possible security issue: The user changes branch parameter to
perform SQL or XSS injection. This would not be possible via
the database, as the foreign key constraint would block arbitrary
code. However, the News retrieval function is using prepared
statements which are immune to this.

Changes: Parameter 'branch' renamed 'branchcode'

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:28:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:28:26 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Martin Persson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42130|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Persson  ---
Created attachment 42147
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42147&action=edit
Bug 14764: OPAC news selector - Template tags

Adds tags to the template files to inject branch list.

Changes: Fixed pref name, renamed branch to branchcode

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:48:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:48:27 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #12 from Tom?s Cohen Arazi  ---
Mark, the fix looks good, but Test::More provides a convenient syntax for
- skipping tests
- providing a convenient warning (thus no need for the diag)

Take a look here:

http://search.cpan.org/~exodist/Test-Simple-1.001014/lib/Test/More.pm#Conditional_tests

Look at t/Calendar.t for an example.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:49:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:49:25 +0000
Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:51:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:51:29 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:51:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:51:42 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:51:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:51:51 +0000
Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears
	inappropriately
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:51:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:51:59 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:06 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:14 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:23 +0000
Subject: [Koha-bugs] [Bug 14746] Set up logging and configuration file
 reading for Mojolicious
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:30 +0000
Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:37 +0000
Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(),
 aka. make a Koha::Object from various input types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:44 +0000
Subject: [Koha-bugs] [Bug 14748] REST API Testing framework
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:51 +0000
Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:52:57 +0000
Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to
 'sip' or 'commandline'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:08 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:03 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:22 +0000
Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:15 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:29 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
	authentication.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:35 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:42 +0000
Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays
 when calculating a holds last pickup date.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:55 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:53:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:53:49 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:01 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:12 +0000
Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:27 +0000
Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:20 +0000
Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options
 to longoverdue.pl to include or exclude borrower categories.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:34 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:39 +0000
Subject: [Koha-bugs] [Bug 14766] New: Complete cataloguing plugin
	unimarc_field_4XX
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

            Bug ID: 14766
           Summary: Complete cataloguing plugin unimarc_field_4XX
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Add subfields l, n and o for better UNIMARC compliance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:41 +0000
Subject: [Koha-bugs] [Bug 10468] patron print summary should show more
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:54:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:54:47 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:55:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:55:13 +0000
Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of
	nomatch options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:55:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:55:20 +0000
Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:55:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:55:29 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

--- Comment #1 from Julian Maurice  ---
Created attachment 42148
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42148&action=edit
Bug 14766: Complete cataloguing plugin unimarc_field_4XX

Add subfields l, n and o for better UNIMARC compliance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:55:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:55:27 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 14:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 12:59:31 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42148|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian Maurice  ---
Created attachment 42149
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42149&action=edit
Bug 14766: Complete cataloguing plugin unimarc_field_4XX

Add subfields l, n and o for better UNIMARC compliance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:00:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:00:35 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:00:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:00:42 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:00:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:00:46 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42101|0                           |1
        is obsolete|                            |
  Attachment #42102|0                           |1
        is obsolete|                            |
  Attachment #42144|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart  ---
Created attachment 42150
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42150&action=edit
Bug 14526: MoveReserve should look at future holds too

At checkout a hold for the same borrower is considered to be filled.
It is consistent to do the same for holds of the same borrower within
[ConfirmFutureHolds] days (if non-zero).

This goal is achieved by adjusting the CheckReserves call within
MoveReserve, adding the lookahead parameter.
I used this occasion to revisit other calls of CheckReserves:
- transferbook: no need to add lookahead; a future hold should not block
  a transfer;
- CanBookBeIssued: no lookahead; future hold does not block an issue;
- CanBookBeRenewed: idem.
- GetOtherReserves (only used in circ/returns): this call might be a
  candidate for lookahead too, but I leave that for another report. It is
  in the context of checkin and transfer, not checkout.

Test plan:
[1] Set ConfirmFutureHolds to zero days. (You may also need to enable
    AllowHoldDateInFuture.)
[2] Place a hold with borrower A on biblio X for tomorrow. Also place a hold
    with borrower B on X for today. (Use biblio level holds.)
[3] Check out item Y of X to borrower A. Ignore the warning for borrower B
    and do not cancel the hold of B (so: confirm checkout).
    Verify that X has still two holds.
[4] Check in Y (without confirming a hold).
[5] Enable ConfirmFutureHolds, say 2 days.
[6] Check out Y to A again. Ignore the warning for B (no cancel). Verify that
    X now only has one hold for borrower B (the hold for A was filled).

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:00:50 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

--- Comment #17 from Jonathan Druart  ---
Created attachment 42151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42151&action=edit
Bug 14526: Add some unit tests for MoveReserve

The change in MoveReserve from the previous patch begs for a test.
Here we add some to Reserves.t.
In all six tests we place a hold, move it and check the reserves again.
Depending on the status of ConfirmFutureHolds, and the reservedate the
hold should be moved or not.

Test plan:
Run the unit test.
Bonus: If you run Reserves.t by applying this patch but without the first
patch that changed MoveReserve, tests 60 and 61 should fail:
    not ok 60 - MoveReserve filled future hold now
    not ok 61 - MoveReserve filled future waiting hold now
This may further illustrate the need of the first patch.

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:00:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:00:56 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

--- Comment #18 from Jonathan Druart  ---
Created attachment 42152
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42152&action=edit
Bug 14526: (follow-up) add a space before equals sign

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:04:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:04:57 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #30 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #29)
> Marcel,
> Can I suggest to make easier the readability of GetReserveFee?
> $cntX are not good variable names.

The previous version was quite readable indeed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:54:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:54:51 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42017|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy  ---
Created attachment 42153
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42153&action=edit
Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee

Test plan:
Run the test: t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Joonas Kylm?l? 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:54:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:54:48 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:54:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:54:56 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #32 from Marcel de Rooy  ---
Created attachment 42154
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42154&action=edit
Bug 14702: [QA Follow-up] More readable variable names, less queries

The names are much better now :)
Combined the queries for items and issues.
Only check the number of holds when needed.

Test plan:
Verify the changes here by running the unit test again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:56:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:56:32 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42153|0                           |1
        is obsolete|                            |

--- Comment #33 from Marcel de Rooy  ---
Created attachment 42155
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42155&action=edit
Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee

Test plan:
Run the test: t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Joonas Kylmala 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 15:56:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 13:56:36 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42154|0                           |1
        is obsolete|                            |

--- Comment #34 from Marcel de Rooy  ---
Created attachment 42156
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42156&action=edit
Bug 14702: [QA Follow-up] More readable variable names, less queries

The names are much better now :)
Combined the queries for items and issues.
Only check the number of holds when needed.

Test plan:
Verify the changes here by running the unit test again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:12:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:12:30 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #36 from Jonathan Druart  ---
Created attachment 42157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42157&action=edit
Bug 12768: qa follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:12:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:12:35 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #37 from Jonathan Druart  ---
Created attachment 42158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42158&action=edit
Bug 12768: Use the Price TT plugin to display prices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:14:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:14:18 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #38 from Jonathan Druart  ---
It does not seem to work if item-level_itypes  is set to biblio.
You should also provide tests for C4::Circulation::LostItem (I suspect that the
problem comes from the query executed in this subroutine).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:15:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:15:35 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42053|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula  ---
Created attachment 42159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42159&action=edit
Bug 14723 - Additional delivery notes to messages

Test plan:
1. Find a borrower with notices at members/notices.pl
2. Observe that there is no column for Delivery notes
3. Apply patch and run the given database update
4. Repeat step 1.
5. Observe that there is now a column for Delivery notes

Includes PageObject Selenium test for delivery failures in C4::Letters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:18:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:18:35 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42118|0                           |1
        is obsolete|                            |

--- Comment #17 from Lari Taskula  ---
Created attachment 42160
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42160&action=edit
Bug 14536: (follow-up) Add PageObject for members/notices.pl

Forgot to call polling in navigateToNotices at LeftNavigation.pm. Here is a fix
for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:19:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:19:02 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #39 from Peggy Thrasher  ---
It may be out of scope for this bug, but it would be great if this could be set
on a per branch basis.  My consortium includes a public library (which does
charge a processing fee, and school libraries (who do not).

Thanks for considering this
Peggy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:20:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:20:06 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42141|0                           |1
        is obsolete|                            |

--- Comment #15 from Lari Taskula  ---
Created attachment 42161
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42161&action=edit
Bug 13906: (follow-up) - MessageQueueFactory for adding messages to
message_queue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:21:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:21:37 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:21:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:21:40 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #6 from Marcel de Rooy  ---
Created attachment 42162
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42162&action=edit
Bug 14683: [QA Follow-up] Similar change for staff

Script memberentry.pl contained a similar line.
Solution is simpler here.

Test plan:
[1] Add, change or clear the sms number at staff side.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:27:12 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40325|0                           |1
        is obsolete|                            |

--- Comment #13 from M. Tompsett  ---
Created attachment 42163
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42163&action=edit
Bug 14362: PEGI15 Circulation/AgeRestrictionMarkers test fails

It is best to test when UTC date is a date in the future compared
to your timezone. I'm in Eastern, so right now, I expect this
test to fail for another 2.5 hours.

TEST PLAN
---------
1) prove t/Circulation/AgeRestrictionMarkers.t
   -- fails for PEGI 15.
2) Apply patch
3) prove t/Circulation/AgeRestrictionMarkers.t
   -- works.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:27:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:27:18 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40326|0                           |1
        is obsolete|                            |

--- Comment #14 from M. Tompsett  ---
Created attachment 42164
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42164&action=edit
Bug 14362: Regression tests

This should trigger the error. Attempts to shift system time
zones did not make sense as to the number of failures.

Added Time::Fake dependency, if it isn't installed these extra
tests don't run. There is a nice skip message about it.

TEST PLAN
---------
 1) apply test patch
 2) sudo dpkg-reconfigure tzdata
    -- set your system time to GMT
 3) prove t/Circulation/AgeRestrictionMarkers.t
    -- should not fail, even if you change system
       time to any time.
 4) sudo dpkg-reconfigure tzdata
    -- set your timezone to Eastern
 5) sudo date -s"2015-06-18 21:15:00"
 6) date
    -- should be past 9pm Eastern timezone
 7) prove t/Circulation/AgeRestrictionMarkers.t
    -- kaboom!
 8) sudo date -s"2015-06-18 12:00:00"
 9) date
    -- should be noon Eastern timezone
10) prove t/Circulation/AgeRestrictionMarkers.t
    -- success?! Time sensitive tests are bad tests.
11) sudo apt-get install libtime-fake-perl
12) prove t/Circulation/AgeRestrictionMarkers.t
    -- kaboom!
    -- changing timezone to anything other than GMT
       should trigger a kaboom.
13) apply fix patch
14) prove t/Circulation/AgeRestrictionMarkers.t
    -- should work all the time.
15) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:31:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:31:17 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42015|0                           |1
        is obsolete|                            |
  Attachment #42155|0                           |1
        is obsolete|                            |
  Attachment #42156|0                           |1
        is obsolete|                            |

--- Comment #35 from Jonathan Druart  ---
Created attachment 42165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42165&action=edit
Bug 14702: Refactor GetReserveFee

The code of GetReserveFee was not very clear.
What it did was: check if there are some items not issued. If so and there
are no holds, calculate no fee.

While doing so, I moved the code to charge the fee (in AddReserve) to a small
new sub ChargeReserveFee.

There is no change in behavior.
The follow-up patch adds unit tests.

Test plan:
[1] Make sure that a patron category (X) includes a hold fee.
[2] Select a biblio with 2 items.
[3] Issue one item to another patron.
[4] Place a hold on this biblio by patron with category X. No charge?
[5] Cancel the hold from the previous step.
[6] Use another patron to place another hold on this biblio.
[7] Place hold again by patron with category X. Is it charged?
[8] Cancel that hold again. Issue the second item to another patron.
[9] Place hold again by patron with category X. Is it charged again?

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:31:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:31:13 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:31:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:31:26 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #37 from Jonathan Druart  ---
Created attachment 42167
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42167&action=edit
Bug 14702: [QA Follow-up] More readable variable names, less queries

The names are much better now :)
Combined the queries for items and issues.
Only check the number of holds when needed.

Test plan:
Verify the changes here by running the unit test again.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:31:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:31:23 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #36 from Jonathan Druart  ---
Created attachment 42166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42166&action=edit
Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee

Test plan:
Run the test: t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Joonas Kylmala 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:42:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:42:20 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40787|0                           |1
        is obsolete|                            |

--- Comment #76 from H?ctor Eduardo Castro Avalos  ---
Created attachment 42168
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42168&action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata

When Koha export a bibliographic record to DC, makes it in XML format. This XML
not follows the DC-XML recommendations as should be: elements in uppercase eg.
dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property
names for the 15 DC elements should be all lower-case." eg. dc:date,
dc:creator" and section "4.3 Example - a simple DC record",
xsi:schemaLocation="http://example.org/myapp/
http://example.org/myapp/schema.xsd" schema does not exist.
The recommendation can be consulted at
.
This new feature, adds an ability to export Dublin Core metadata to XML and RDF
(including rdfxml, rdfjson, ntriples, turtle, etc.)

Test plan
---------------
1) Download Dublin Core file. Open up the file, and make sure that the document
not follows the DC-XML recommendations as should be.
2) Apply patches.
3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core.
A modal will display, prove all options.
4) Change the system preference 'Opac ExportOptions' by enabling and disabling
Dublin Core and try to download a record in the OPAC.
5) Try several bibliographic records in any format (book, magazine, DVD, etc.)
to confirm that properly exported.
6) RDF/XML can be validated per RDF Validator W3C.
7) DC-XML cannot valid if not exist a valid XSD schema.
8) OAI-DC can be validated using
 and the proper schema
 typed in text field for URL.
9) Since unit test fail last time, test with prove t/db_dependent/Record.t

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro 
XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated
from patch, use instead C4::Record::_entity_encode, RDF::Helper has been
eliminated too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:47:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:47:16 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #77 from H?ctor Eduardo Castro Avalos  ---
(In reply to H?ctor Eduardo Castro Avalos from comment #76)
> Created attachment 42168 [details] [review]
> Bug 13642 [ENH] Adding new features for Dublin Core metadata

New attach since CONFLICT MERGE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:48:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:48:36 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42161|0                           |1
        is obsolete|                            |

--- Comment #16 from Lari Taskula  ---
Created attachment 42169
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42169&action=edit
Bug 13906: (follow-up) - MessageQueueFactory for adding messages to
message_queue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:55:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:55:49 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42074|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:56:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:56:19 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:56:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:56:23 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42159|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula  ---
Created attachment 42170
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42170&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 16:56:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 14:56:25 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41637|0                           |1
        is obsolete|                            |

--- Comment #21 from Tom?s Cohen Arazi  ---
Created attachment 42171
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42171&action=edit
Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows

This patch introduces an updatedatabase.pl entry that takes care of
updating existing statistics rows.

It does so by looping on the statistics rows, collecting itemnumber occurences
that are have NULL itemtypes.
It then chooses the right itemtype following what is proposed on bug 14651, and
then updates the rows in statistics using the calculated itemtype.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:04:23 +0000
Subject: [Koha-bugs] [Bug 7174] Authentication rewriting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14723


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:04:23 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13799, 14536                |7174


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
[Bug 7174] Authentication rewriting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536
[Bug 14536] PageObject-pattern base implementation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:04:23 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14723                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:04:23 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14723                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:05:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:05:47 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:07:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:07:24 +0000
Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do
 not use print template
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:07:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:07:34 +0000
Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:07:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:07:43 +0000
Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage
 statistics in Administration page and Web installer
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:08:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:08:20 +0000
Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra
 search patron options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:09:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:09:10 +0000
Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items'
 order after paying fines.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:09:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:09:10 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42163|0                           |1
        is obsolete|                            |

--- Comment #15 from M. Tompsett  ---
Created attachment 42172
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42172&action=edit
Bug 14362: PEGI15 Circulation/AgeRestrictionMarkers test fails

It is best to test when UTC date is a date in the future compared
to your timezone. I'm in Eastern, so right now, I expect this
test to fail for another 2.5 hours.

TEST PLAN
---------
1) prove t/Circulation/AgeRestrictionMarkers.t
   -- fails for PEGI 15 after 9pm.
2) Apply patch
3) prove t/Circulation/AgeRestrictionMarkers.t
   -- works.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:09:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:09:22 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42164|0                           |1
        is obsolete|                            |

--- Comment #16 from M. Tompsett  ---
Created attachment 42173
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42173&action=edit
Bug 14362: Regression tests

This should trigger the error. Attempts to shift system time
zones did not make sense as to the number of failures.

Added Time::Fake dependency, if it isn't installed these extra
tests don't run. There is a nice skip message about it.

Added License text.

TEST PLAN
---------
 1) apply test patch
 2) sudo dpkg-reconfigure tzdata
    -- set your system time to GMT (Africa/Abidjan)
 3) prove t/Circulation/AgeRestrictionMarkers.t
    -- should not fail, even if you change system
       time to any time.
 4) sudo dpkg-reconfigure tzdata
    -- set your timezone to Eastern
 5) sudo date -s"2015-06-18 21:15:00"
 6) date
    -- should be past 9pm Eastern timezone
 7) prove t/Circulation/AgeRestrictionMarkers.t
    -- kaboom!
 8) sudo date -s"2015-06-18 12:00:00"
 9) date
    -- should be noon Eastern timezone
10) prove t/Circulation/AgeRestrictionMarkers.t
    -- success?! Time sensitive tests are bad tests.
11) sudo apt-get install libtime-fake-perl
12) prove t/Circulation/AgeRestrictionMarkers.t
    -- kaboom!
    -- changing timezone to anything other than GMT
       should trigger a kaboom.
13) apply fix patch
14) prove t/Circulation/AgeRestrictionMarkers.t
    -- should work all the time.
15) less t/Circulation/AgeRestrictionMarkers.t
    -- the license text should be similar to
       http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
16) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:09:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:09:47 +0000
Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup
	list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:10:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:10:34 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:10:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:10:59 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
 authority records to a biblio record during edition. (AJAX)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:11:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:11:39 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:12:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:12:33 +0000
Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of
	"Expected"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:12:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:12:51 +0000
Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers
	test fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362

--- Comment #17 from M. Tompsett  ---
Created attachment 42174
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42174&action=edit
My test script

Just to test all 24 hours.
Makes more comprehensive testing easier. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:13:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:13:01 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37853|0                           |1
        is obsolete|                            |

--- Comment #154 from Marc V?ron  ---
Comment on attachment 37853
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37853
Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl

Removed - Will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:13:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:13:19 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:14:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:14:17 +0000
Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy
 generation of Web testing UserAgents.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:14:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:14:53 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37887|0                           |1
        is obsolete|                            |

--- Comment #155 from Marc V?ron  ---
Comment on attachment 37887
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887
Bug 13813 - Remove C4::Dates from members/printfeercpt.pl

Removed  - will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:15:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:15:15 +0000
Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:15:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:15:57 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37881|0                           |1
        is obsolete|                            |

--- Comment #156 from Marc V?ron  ---
Comment on attachment 37881
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37881
Bug 13813 - Remove C4::Dates from members/moremember.pl

Removed - will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:16:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:16:13 +0000
Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only
 result returned by patron datatables search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:17:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:17:02 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:17:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:17:50 +0000
Subject: [Koha-bugs] [Bug 14767] New: Message delivery notes from SMS
 Gateway provider reports
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

            Bug ID: 14767
           Summary: Message delivery notes from SMS Gateway provider
                    reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

This feature is dependent on Bug 14723.

Since Bug 14723 introduces database a new column, 'delivery_note', we can now
take better use of it if our SMS Gateway provider supports status reports.

Our local SMS Gateway provider sends us a HTTP request containing information
about the status of delivery. If the delivery was failed, they will let us know
the reason for failure. We should use the 'delivery_note' column for this data.
I propose taking REST API way to accept reports from provider and change the
status of messages accordingly in the database.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:18:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:18:00 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37864|0                           |1
        is obsolete|                            |

--- Comment #157 from Marc V?ron  ---
Comment on attachment 37864
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37864
Bug 13813 - Remove C4::Dates from circ/bookcount.pl

Removed - will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:18:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:18:16 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14767


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767
[Bug 14767] Message delivery notes from SMS Gateway provider reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:18:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:18:16 +0000
Subject: [Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway
	provider reports
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14723
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:18:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:18:29 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37890|0                           |1
        is obsolete|                            |

--- Comment #158 from Marc V?ron  ---
Comment on attachment 37890
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37890
Bug 13813 - (follow-up) Remove C4::Dates from circ/bookcount.pl

Removed - will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:18:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:18:45 +0000
Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y,
	022$z => ISSN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:19:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:19:35 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37863|0                           |1
        is obsolete|                            |

--- Comment #159 from Marc V?ron  ---
Comment on attachment 37863
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37863
Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm

Removed - Will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:20:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:20:50 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #6 from Lari Taskula  ---
Selenium tests are using PageObjects and Authentication rewrite (therefore
dependencey on Bug 7174).

The patch only covers delivery notes at failure cases in C4::Letters. If you
wish to see how delivery notes can be taken further with custom SMS::Send
driver and SMS Gateway reports, please see Bug 14767.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:20:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:20:54 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37877|0                           |1
        is obsolete|                            |

--- Comment #160 from Marc V?ron  ---
Comment on attachment 37877
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37877
Bug 13813 - Remove C4::Dates from C4/Members.pm

Removed - Will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:21:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:21:26 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37889|0                           |1
        is obsolete|                            |

--- Comment #161 from Marc V?ron  ---
Comment on attachment 37889
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889
Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm

Removed - will be done in "second round"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:29:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:29:24 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #162 from Marc V?ron  ---
Created attachment 42175
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42175&action=edit
[Follow-up]  Bug 13813 - Remove C4::Dates from C4/Items.pm

Fixed missing character (see comment #150)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:33:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:33:33 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:33:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:33:37 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41024|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi  ---
Created attachment 42176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42176&action=edit
[SIGNED OFF] Bug 13585: Add a cronjob which send UsageStats monthly.

This patch introduces entries for monthly running the
share_usage_with_koha_community.pl
script to the packages and also the crontab.example file for manual
installs use.

Edit: I fixed the Copyright line

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:33:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:33:46 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:44:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:44:04 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #13 from Heather  ---
> Just FYI, this isn't using the authority database, it's using the actual
> search indices.

Oh, right!  I'm sorry, I think I wasn't very clear--I was trying to say that
there's no way right now for a user to ever see the subject headings with
subdivisions as used in the records.  Maybe this new browse feature, when
browsing subjects, could return an alphabetic list of subject headings *with*
subdivisions from the records.  I hope this is clearer!

> I may swap out the database some time soon with one that has a more
> "properly" catalogued catalogue, to see how that looks.

Our catalog is not the cleanest (I haven't done all our authority work &
headings clean up), but it's pretty good--if there's any way our records, a
subset of our records, or even we can help with this, we'd be very, very happy
to help.  Our catalog is here, http://keys.bywatersolutions.com/ supported by
ByWater, so perhaps if y'all working on this bug contact Brendan at ByWater,
there's a way that we can help test with our catalog?  Or perhaps even ByWater
could make our records or a subset of our records available so y'all have a
more "cataloged catalog" for testing?

--h2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 17:47:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 15:47:16 +0000
Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery /
 article requests in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 18:30:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 16:30:13 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 18:30:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 16:30:15 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42171|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall  ---
Created attachment 42177
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42177&action=edit
[SIGNED-OFF] Bug 14598: (DB update) fix NULL itemtypes in statistics on
'return' rows

This patch introduces an updatedatabase.pl entry that takes care of
updating existing statistics rows.

It does so by looping on the statistics rows, collecting itemnumber occurences
that are have NULL itemtypes.
It then chooses the right itemtype following what is proposed on bug 14651, and
then updates the rows in statistics using the calculated itemtype.

Regards

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 19:05:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 17:05:12 +0000
Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to
 reflect Zebra indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

--- Comment #1 from H?ctor Eduardo Castro Avalos  ---
Created attachment 42178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42178&action=edit
Bug 14304 - RDA: Display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra
indexing.

Test plan
1) Follow test plan for bug 14198
2) Apply the bug 14198
3) Do a search by pv: or pb:
4) Look that there no display link for 264 field.
5) Apply the patch
6) In a like maner of step 3 and 4, check out the new link for 264 field.
7) Check out the display link in OPAC and staff clint

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 19:05:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 17:05:40 +0000
Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to
 reflect Zebra indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 19:08:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 17:08:12 +0000
Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to
 reflect Zebra indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14198


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198
[Bug 14198] RDA: Indexing 264 field (Zebra)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 19:08:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 17:08:12 +0000
Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14304


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304
[Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:17:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:17:22 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #2 from Gaetan Boisson  ---
Created attachment 42179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42179&action=edit
[SIGNED-OFF] bug 14476 : Caching C4::XSLT::transformMARCXML4XSLT

This patch is improving the opac-search performances by
caching the results of C4::XSLT::transformMARCXML4XSLT

My tests (with Devel::NYTProf) showed a gain of about
65% on C4::XSLT::transformMARCXML4XSLT and
35% on C4::XSLT::XSLTParse4Display.

The gain of performances is increasing with the numbers
of results.

Signed-off-by: Gaetan Boisson 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:18:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:18:05 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Gaetan Boisson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaetan.boisson at biblibre.com
  Attachment #40740|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:18:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:18:44 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #3 from Gaetan Boisson  ---
Works for me, although the performance gain was not as big as expected. I will
test it again on a larger data set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:19:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:19:01 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Gaetan Boisson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:21:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:21:08 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #62 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #61)
> Repeated on fresh master:
> Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
> fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 bug_11213: C4::VirtualShelves::Page::shelf_contents()
> 
> Since our git version may be different, please apply them again with your
> git version and resubmit.

mtompset at debian:~/kohaclone$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
mtompset at debian:~/kohaclone$ git branch -D bug_11213_restart
Deleted branch bug_11213_restart (was 113c548).
mtompset at debian:~/kohaclone$ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
mtompset at debian:~/kohaclone$ git pull
Already up-to-date.
mtompset at debian:~/kohaclone$ git remote update -p
Fetching origin
mtompset at debian:~/kohaclone$ git checkout -b bug_11213_restart origin/master
Branch bug_11213_restart set up to track remote branch master from origin.
Switched to a new branch 'bug_11213_restart'
mtompset at debian:~/kohaclone$ git bz apply 11213
Bug 11213 - GetItemsInfo() called twice

39023 - bug_11213: Changed XSLTParse4Display() interface
39024 - bug_11213: whitespace correction
39025 - bug_11213: Include XSLT processing for searchResults() test
39026 - bug_11213: C4::VirtualShelves::Page::shelf_contents()
39027 - bug_11213: GetItemsInfo() test
39028 - bug_11213: Added XSLTParse4Display() to Items test
39029 - bug_11213: Check for $item->{itype} presence to avoid warning

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: bug_11213: Changed XSLTParse4Display() interface
Applying: bug_11213: whitespace correction
Applying: bug_11213: Include XSLT processing for searchResults() test
Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
Using index info to reconstruct a base tree...
M       C4/VirtualShelves/Page.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/VirtualShelves/Page.pm
Applying: bug_11213: GetItemsInfo() test
Applying: bug_11213: Added XSLTParse4Display() to Items test
Using index info to reconstruct a base tree...
M       t/db_dependent/Items.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Items.t
Applying: bug_11213: Check for $item->{itype} presence to avoid warning
mtompset at debian:~/kohaclone$

It works fine for me with Debian Jessie.
Did you check if your 'git bz' is up to date?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 20:21:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 18:21:35 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi  ---
I have a concern: if we cache the record to be displayed, then the item
statuses won't be up-to-date. If the tradeoff is not enough, maybe this is just
not worth. Because people expect to see updated information on the records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 21:40:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 19:40:48 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hm, UsageStatsLibraryType already is a drop down, without this patch for me? 
I am also a bit worried about the country, because how complete of a list can
we get and where?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 22:38:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 20:38:02 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #9 from Martin Persson  ---
Apply the RSS fix last to avoid conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 22:47:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 20:47:48 +0000
Subject: [Koha-bugs] [Bug 13924] LocalHoldsPriority needs dateaccessioned
	limits.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13924

Joel Sasse  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsasse at plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 22:55:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 20:55:37 +0000
Subject: [Koha-bugs] [Bug 8073] Sound cue when checking in items on hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:17:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:17:05 +0000
Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817

Christopher Brannon  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #13 from Christopher Brannon  ---
Would love to see this feature.  Interested in the GoodReads content enhancing
Koha.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:29:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:29:26 +0000
Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
One small thing - I think the pop up window is not wide enough now. It forces
you to make it bigger to be able to actually add the patron. Would be good to
adjust that as a follow up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:29:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:29:35 +0000
Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

--- Comment #8 from Katrin Fischer  ---
... or separately :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:30:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:30:02 +0000
Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:30:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:30:05 +0000
Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41640|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer  ---
Created attachment 42180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42180&action=edit
[PASSED QA] Bug 14685: Fix set guarantor for a child or professional accounts

Bug 13970 removed some useful code to automatically set the guarantor
when creating a child.

But finally there is a better way to do the job, we just need to assume
that only children or professional can have a guarantor.

Test plan:
1/ Create an adult patron and add a child.
2/ The guarantor info should be retrieved and set on the child creation
page.
3/ Create an organization and add a child
4/ The guarantor info should be retrieved and set on the adult creation
page.

Signed-off-by: Liz Rea 
This patch catches both cases, thanks Jonathan!

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:36:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:36:56 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
There is something going wrong here:

1) Go to patron search home page
2) Launch a search (I used "d")
3) Check one patron, say [New list] from pull down
4) Name the list, hit the save button behind it
5) Check another patron, pull down list still shows newly created list - hit
save again
6) Another list with the same name is added

It will always create a new list - even if you switch the pull down to another
preexisting list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:38:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:38:45 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #7 from Katrin Fischer  ---
Hm interesting: It doesn't really add a new list, but it adds another entry to
the drop down every time you hit 'save'. Once you reload the page the double
ups in the pull down are gone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:46:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:46:50 +0000
Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:46:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:46:53 +0000
Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41456|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer  ---
Created attachment 42181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42181&action=edit
[PASSED QA] Bug 12965: Prevent to erase an existing item type

On creating an item type, if it already exists, it will replace the
existing one.
This patch prevent that and display a message to the interface.

Note: The fields are lost.

Test plan:
1/ Create an item type 'AAA', description 'AAA'
2/ Edit it, update the description with 'BBB'
3/ Create an item type 'AAA' with a description 'CCC' => you should get
a warning "already exists".

Works well, no errors

Signed-off-by: Amit Gupta 
Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Katrin Fischer 
Warning message is triggered.
Adding, editing and deleting item types still works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:51:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:51:59 +0000
Subject: [Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media
 is enabled and url has plus (+) charcters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:52:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:52:02 +0000
Subject: [Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media
 is enabled and url has plus (+) charcters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41523|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer  ---
Created attachment 42182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42182&action=edit
[PASSED QA] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled

The special regex chars are not escaped in C4::HTML5Media.

Test plan:
1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley
2/ Enable the pref HTML5Media
3/ Go on the detail page
It should not explode.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:52:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:52:11 +0000
Subject: [Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media
 is enabled and url has plus (+) characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Search fails with errors    |Search fails with errors
                   |when HTML5 Media is enabled |when HTML5 Media is enabled
                   |and url has plus (+)        |and url has plus (+)
                   |charcters                   |characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:55:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:55:43 +0000
Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  1 23:55:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 21:55:46 +0000
Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41641|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer  ---
Created attachment 42183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42183&action=edit
[PASSED QA] Bug 14584: Encoding broken with system preferences

The pref are double encoded.

>From bug 12411:
"This will fix the encoding issues existing in 3.14 and 3.16.
The issue still appear in master but is fixed by bug 11944."

They should not have been pushed together.

Test plan:
1) You need an accentuated language installed.
2) Go to NoLoginInstructions pref, and add some accentuated message like
"H?lo m?dames ? m?cie?x"
3) refresh opac home page, message should be gibberish
4) apply patch.  Message should be ok now.

Signed-off-by: Tomas Cohen Arazi 
Works as expected.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:01:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:01:34 +0000
Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item
 deletes item anyway
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:01:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:01:38 +0000
Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item
 deletes item anyway
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41091|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer  ---
Created attachment 42184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42184&action=edit
[PASSED QA] Bug 13943: Prevent the deletion of items if the user cancels

On the edit items page, there is some weird JS code: if the user clicks
on the delete link and then cancel, the item is deleted anyway.

It's caused by the following JS code in browser.js
  $('a[href*="biblionumber="]').click(function (ev) {
      ev.preventDefault();
      window.location = $(this).attr('href') + '&searchid=' + me.searchid;
  });

Test plan:
- Do a search with multiple results
- Go to the detail page (make sure results browser shows up!)
- Use the "Edit items" link from the toolbar
- Delete an item (try both way)
- Choose "cancel"
- Delete an item (try both way) and confirm the deletion
You should see the browser after the deletion and the item should have
been deleted correctly.
- Edit an item (try both way)
You should see the browser (did not work before this patch)

Note: Before this patch, the 2 first columns didn't contain the
edit/delete item links, now it's only the 1st one.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 
Much better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:06:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:06:45 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #10 from Katrin Fischer  ---
Maybe it could be a good enh to add something like: "Your password hasn't been
changed." to the message in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:10:32 +0000
Subject: [Koha-bugs] [Bug 8291] patron import should show error names
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291

Danielle Elder  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danielle at bywatersolutions.c
                   |                            |om

--- Comment #2 from Danielle Elder  ---
Agreed, borrower specific feedback would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:11:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:11:58 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Katrin Fischer  ---
Opac works great, but I can't trigger the message changing my password from the
'Change password' page in staff
(http://localhost:8080/cgi-bin/koha/members/member-password.pl?member=1)
It seems to work alright without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:15:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:15:07 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #16 from Katrin Fischer  ---
Patch doesn't apply due to a conflict in Circulation.t - can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:25:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:25:34 +0000
Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the
	command line
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:25:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:25:37 +0000
Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the
	command line
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41847|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer  ---
Created attachment 42185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42185&action=edit
[PASSED QA] Bug 14709: Do not access to C4::Context->userenv from the
commandline

The script dies with
  Can't use an undefined value as a HASH reference at tools/export.pl
line 149.
if it is called from the command line.

This is introduced by bug 13040.

The C4::Context->userenv is not defined in this case.

Test plan:
Execute the script using the command line.
With the patch applies you should not get the error.

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:35:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:35:33 +0000
Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in
	catalogue/search.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:35:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:35:36 +0000
Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in
	catalogue/search.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41699|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer  ---
Created attachment 42186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42186&action=edit
[PASSED QA] Bug 14696: useless use of String::Random in catalogue/search.pl

Bug 10404 adds the use of String::Random to catalogue/search.pl but bug
11369 removes it without removing the import line.

Test plan:
  git grep String::Random catalogue/search.pl
should not return anything

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:37:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:37:04 +0000
Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in
	catalogue/search.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

--- Comment #4 from Katrin Fischer  ---
It looks like this had been added as part of 762c3304 (Bug 10404 - add
previous/next browsing to staff client), but the code has since changed and I
couldn't spot a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 00:59:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 22:59:49 +0000
Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log
	in page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

Liz Rea  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #8 from Liz Rea  ---
This patch moved the help menu from the top right, next to the login menu to
inside the dropdown. I don't think we want to hide it like that.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:02:07 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #7 from Katrin Fischer  ---
Created attachment 42187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42187&action=edit
[PASSED QA] Bug 14683: Unable to clear SMS number

Enables to clear SMS number.

To test:
1. Go to opac-messaging.pl
2. Insert SMS number and submit
3. Clear SMS number and submit
4. Observe that the sms number did not change
5. Apply patch
6. Clear SMS number and submit
7. Observe that the sms number changes

Sponsored-by: Vaara-kirjastot

Signed-off-by: Marcel de Rooy 
Adding a follow-up.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:02:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:02:13 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #9 from Katrin Fischer  ---
Created attachment 42189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42189&action=edit
[PASSED QA] Bug 14683: [QA Follow-up] Similar change for staff

Script memberentry.pl contained a similar line.
Solution is simpler here.

Test plan:
[1] Add, change or clear the sms number at staff side.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:02:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:02:10 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #8 from Katrin Fischer  ---
Created attachment 42188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42188&action=edit
[PASSED QA] Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber

This is an issue discussed on older reports already in the past.
Column mobile in borrowers is actually 'Other phone', not necessary a
mobile number. The name of the field is confusing. (Renaming it is
outside the scope of this report.)
The field that we are editing here is smsalertnumber. It should not be
compared with mobile at all.

What could be the side-effect of this correction?
===
First, the change is only relevant for libraries with pref SMSSendDriver
enabled.
In the past patrons editing their message preferences saw mobile (read:
other phone) in their smsalertnumber field (if the latter was still empty).
If they saved it, it was copied to smsalertnumber.
This change does not affect these patrons. They just have the same number
in two columns. No big deal.
What if a patron does not yet have a smsalertnumber? In that case no sms
is sent in Letters.pm. So no change in behavior. If he submits
opac-messaging now, he will no longer copy his other phone to smsalert [we
cannot assume that it was mobile anyway!]. If he enters a mobile number,
it will be saved correctly in the right field.

Conclusion: this change will not break things or hurt anyone. It only
prevents unwanted copying other phone to smsalertnumber.

Also modified the compare to prevent uninitialized warnings.
And removed a commented warn.

Test plan:
[1] Add, edit or delete the SMS number on opac-messaging regardless of
    the value of Other Phone (in the badly named mobile field).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:03:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:03:24 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:03:26 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42050|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:03:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:03:28 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42051|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:03:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:03:30 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42162|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:04:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:04:04 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #10 from Katrin Fischer  ---
I feel a bit like Marcel kidnapped the bug ;)... but the changes make sense to
me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:07:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:07:13 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
Can I get a test plan please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 01:58:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Sep 2015 23:58:22 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

--- Comment #13 from Katrin Fischer  ---
What I am missing here a bit is an idea about what this code was actually used
for in the past. 

According to my research it seems like you used to be able to store the results
of a report in that table - which got broken at some point. We have a newer bug
report asking for such a feature:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 02:02:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 00:02:03 +0000
Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

--- Comment #7 from Srdjan Jankovic  ---
(In reply to Joonas Kylm?l? from comment #6)

> But do we have some script to change the group (during installation)? Hmm..
> I'm not so sure about this. Maybe there could be some config file (not sure
> if there is one already for this kind of things) where it could be changed
> to one that the user wants or if not specified it would default to $username.

That is an interesting idea, and I could even implement it in the debian
config. Although I must say that adm group sounds good enough for me (you don't
give adm to everyone). Another possibility is to create a koha group and put
all sites to that group. How do we go about making decisions like that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 02:56:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 00:56:26 +0000
Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

--- Comment #8 from Robin Sheat  ---
I think Srdjan is right here. As a rule of thumb, logs are group-owned by adm
so that any user in the adm group can view them. This applies to things like
syslog, mysql logs, mail logs, etc. 

I had a quick look and couldn't find a policy about it, but it seems to be the
de facto thing to do.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 05:07:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 03:07:34 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #14 from Robin Sheat  ---
(In reply to Heather from comment #13)
> Oh, right!  I'm sorry, I think I wasn't very clear--I was trying to say that
> there's no way right now for a user to ever see the subject headings with
> subdivisions as used in the records.  Maybe this new browse feature, when
> browsing subjects, could return an alphabetic list of subject headings
> *with* subdivisions from the records.  I hope this is clearer!

Ah, this will do that. You just can't see it because this catalogue doesn't
handle subjects like that.

> Our catalog is not the cleanest (I haven't done all our authority work &
> headings clean up), but it's pretty good--if there's any way our records, a
> subset of our records, or even we can help with this, we'd be very, very
> happy to help.  Our catalog is here, http://keys.bywatersolutions.com/
> supported by ByWater, so perhaps if y'all working on this bug contact
> Brendan at ByWater, there's a way that we can help test with our catalog? 
> Or perhaps even ByWater could make our records or a subset of our records
> available so y'all have a more "cataloged catalog" for testing?

More test data is good, I've pinged Brendan to have a look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 08:17:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 06:17:44 +0000
Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove
 link to course reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41390|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer  ---
Created attachment 42190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42190&action=edit
[PASSED QA] Bug 14205: Deleting an Item/Record does not remove link to course
reserve

A constraint is missing on the course_reserves.ci_id field.
This patch adds it and removes orphan rows.

Test plan:
0/ Don't apply the patch
1/ Login to Staff Site.
2/ Go to Course Reserves
3/ Create Course
4/ Add Reserve
5/ Go to item added (delete item/record)
6/ Refresh Course (see no items attached)
7/ Delete Course
8/ See course still listed in the courses (Not deleted)
9/ Apply the patch and execute the updatedatabase entry.
10/ Delete the Course
Note that the course has correctly been removed.

NOTE: Make sure to set the UseCourseReserves system preference to test.
      Tested before (problem existed) and after (problem solved) update.
      Dropped DB, web installed, and put in dummy data and retested.
      Problem solved.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 08:17:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 06:17:41 +0000
Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove
 link to course reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 08:43:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 06:43:00 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

--- Comment #5 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #4)
> Hm, UsageStatsLibraryType already is a drop down, without this patch for me?

Probably an error in the commit message, the patch only adds en empty choice
for UsageStatsLibraryType

> I am also a bit worried about the country, because how complete of a list
> can we get and where?

Even if we can't be sure we have the exhaustive list of countries, I think it
is still better than having all possible forms of USA counted as different
countries, not to mention spelling mistakes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 09:18:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 07:18:07 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

--- Comment #6 from Katrin Fischer  ---
I have to admit... I don't see a better solution :) Translating all those
countries is a bit of a scary thought tho...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 09:29:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 07:29:32 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #9 from Joonas Kylm?l?  ---
(In reply to Katrin Fischer from comment #7)
> 005 is a timestamp of the last change and the first positions of the leader
> that change are the record length - this change being caused by the other
> changes. 
> So I think Koha's current behaviour is correct and nothing needs to be
> changed on import. I think what we could do is catch an invalid itemtype
> code better, so it's easier to locate the problem.

What about the missing subfields/something? I don't know how much they will
have effect on how things work but I'll try to look into the code of the Edit
record feature and see if we should add those kind of things to this import
tool, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 09:31:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 07:31:14 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

--- Comment #14 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #13)
> Can I get a test plan please?

Katrin:
Run the test from the third patch with and without the two patches.
Compare the results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 09:45:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 07:45:51 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42167|0                           |1
        is obsolete|                            |

--- Comment #38 from Joonas Kylm?l?  ---
Created attachment 42191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42191&action=edit
Bug 14702: [QA Follow-up] More readable variable names, less queries

The names are much better now :)
Combined the queries for items and issues.
Only check the number of holds when needed.

Test plan:
Verify the changes here by running the unit test again.

Signed-off-by: Jonathan Druart 
Signed-off-by: Joonas Kylm?l? 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 09:56:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 07:56:54 +0000
Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log
	in page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

--- Comment #9 from Jonathan Druart  ---
Liz, it's the same place as when you are logged in. What do you suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:04:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:04:58 +0000
Subject: [Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow
 placing holds on staff side
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |j.kylmala at gmail.com
                 CC|                            |j.kylmala at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:07:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:07:04 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #10 from Katrin Fischer  ---
Which missing subfields? 999 information with bilbionumber/biblioitemnumber
etc. is added correctly (or nothing would work). I can't think of any other
fields right now that the import would change in the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:11:43 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #117 from Alex Arnaud  ---
Created attachment 42192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42192&action=edit
Bug 14544 - Handle database error when creating a shelf with DB admin account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:18:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:18:20 +0000
Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the
 Fines & Charges Tab in the Patron Details of Staff Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14497

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:18:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:18:20 +0000
Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if
 patron's fines exceed noissuescharge
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6508
                 CC|                            |j.kylmala at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:21:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:21:54 +0000
Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the
 Fines & Charges Tab in the Patron Details of Staff Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=3153

--- Comment #2 from Joonas Kylm?l?  ---
Please, see also the bug 3153. Maybe we could refactor the code so that we
could  have the alert

Attention:
     Fees & Charges: Patron has Outstanding fees & charges of 2.00. 

in many places shown easily.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:21:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:21:54 +0000
Subject: [Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow
 placing holds on staff side
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6508

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:26:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:26:27 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #11 from Joonas Kylm?l?  ---
(In reply to Katrin Fischer from comment #10)
> etc. is added correctly (or nothing would work). I can't think of any other
> fields right now that the import would change in the record.

Not change, but add. But I will look into the code soon.. and then we can be
sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:33:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:33:17 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:33:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:33:19 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41085|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 42193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42193&action=edit
Bug 12525: Prevent adding several patron lists with the same name

If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.

To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created

Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:34:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:34:10 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #9 from Jonathan Druart  ---
Katrin, thanks for the catch! Weird, I was sure I had tested this one
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:38:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:38:24 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:45:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:45:28 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:45:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:45:30 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #12 from Jonathan Druart  ---
Created attachment 42194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42194&action=edit
Bug 14509: (follow-up) Reject invalid passwords

The members.js was not included in member-password.tt
And it cannot, there are specific code which cannot be used outside of
memberentry.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:48:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:48:06 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #118 from Jonathan Druart  ---
(In reply to Alex Arnaud from comment #117)
> Created attachment 42192 [details] [review]
> Bug 14544 - Handle database error when creating a shelf with DB admin account

I think this is not useful, the DB admin account should not be used for
anything else than create a first superlibrarian user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:56:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:56:32 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:56:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:56:35 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41444|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart  ---
Created attachment 42195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42195&action=edit
Bug 14470: Do not allow renew for on-site checkouts

At the opac, the renew checkbox should not be displayed if it's an
on-site checkout (same on the intranet).

On the way, this patch adds a specific message to the intranet if the
librarian try to renew an on-site checkout.
Indeed before this patch a renew was allowed if the barcode was scanned.

Test plan:
1/ Create an on-site checkout for a patron
2/ Confirm that the checkbox 'renew' is not displayed on the checkout
list tables
3/ At the OPAC, the renew should not be allowed (no checkbox)
4/ Try to check the item out to the same patron, confirm that you get a
specifig message to inform you the renew is not allowed for on-site
checkouts.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 10:59:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 08:59:13 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #12 from Joonas Kylm?l?  ---
(In reply to Joonas Kylm?l? from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > etc. is added correctly (or nothing would work). I can't think of any other
> > fields right now that the import would change in the record.
> 
> Not change, but add. But I will look into the code soon.. and then we can be
> sure.

Ok. authorities.pl and addbiblio.pl does the missing subfield adding as I
understood by reading the code quickly. The code starts at line 590 in
addbiblio.pl. Katrin, do you know by that info if that is something we need?
(if not, why do we have it in addbiblio.pl and authorities.pl?).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:00:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:00:23 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

--- Comment #119 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #118)
> I think this is not useful, the DB admin account should not be used for
> anything else than create a first superlibrarian user.
It was the behavior before this patches. And, isn't it better to have a message
that says we can't created a shelf using db admin account instead of a
MySql/DBIX error ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:03:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:03:20 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #7 from Lari Taskula  ---
(In reply to Lari Taskula from comment #3)
> Created attachment 42074 [details] [review]
> Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports
> 
Patch moved to bug 14767.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:06:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:06:44 +0000
Subject: [Koha-bugs] [Bug 14763] show patron's age
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com

--- Comment #1 from Joonas Kylm?l?  ---
I agree with you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:08:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:08:26 +0000
Subject: [Koha-bugs] [Bug 14756] The format you asked for ('') is
	unrecognized.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14756

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Joonas Kylm?l?  ---
There was a little typo in the master branch, bug fix is already in master.
Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:14:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:14:47 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:22:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:22:38 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #13 from Katrin Fischer  ---
To me the code looks to be mostly about building the cataloguing form correctly
- I can't spot any elements being added. I feel a bit like we are hunting
'ghosts' here, as there is no known problem to work from and reading all the
code will always turn up some/lots of question marks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:25:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:25:41 +0000
Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com
           Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:29:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:29:36 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 11:58:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 09:58:09 +0000
Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card
	creator
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:40:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:40:24 +0000
Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755
Bug 14755 depends on bug 14762, which changed state.

Bug 14762 Summary: Importing records doesn't add missing subelements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:40:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:40:24 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #14 from Joonas Kylm?l?  ---
Looks like this is then resolved. I'll open a new report for the invalid item
type thingie.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:44:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:44:50 +0000
Subject: [Koha-bugs] [Bug 8080] login and password no longer pre-filled by
 the browser when creating a new patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8080

Dinesh Kumar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |slsn-koha.informindia.co.in
                 CC|                            |dkumar9616 at gmail.com
           Severity|enhancement                 |new feature
  Change sponsored?|---                         |Seeking cosponsors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:57:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:57:26 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40796|0                           |1
        is obsolete|                            |
  Attachment #40797|0                           |1
        is obsolete|                            |
  Attachment #40929|0                           |1
        is obsolete|                            |
  Attachment #40930|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart  ---
Created attachment 42196
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42196&action=edit
Bug 14435: Add the ability to store result's report

At one time it was possible to store the results of a report into the
saved_reports table.
This allowed the librarians to compare different results, from the Koha
interface.

This patch is a proof of concept and is not very polished (understood:
it cannot be pushed like that).

Test plan:
Execute the runreport.pl cronjob script with the new --store-results
option.
This will serialize into json the results and put it into the
saved_reports table.

On the "Saved report" list, the "Saved results" column is now populated
with a date (note that you can have several date for a given report).
If you click on this link, the data will be displayed in a simple table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:58:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:58:09 +0000
Subject: [Koha-bugs] [Bug 14768] New: When importing records,
 alert if there is wrong information in the records.
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14768

            Bug ID: 14768
           Summary: When importing records, alert if there is wrong
                    information in the records.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When importing with manage-marc-import.pl it doesn't tell if some information
in the records which it is processing is missing some info / or the info is
invalid.

In bug 14762 there was the problem with invalid itemtype code. We should give
at least some warning if the user tries to import data to Koha which is not
compatible with the preferences the user has set in Koha (for example, the data
to be imported has an itemtype code of X but the system doesn't have that
code). 

It would be even better if we could put there some suggestion that says, for
example, that "The itemtype code used in your imported data doesn't exists in
the system, do you want to create it / do you want to change the itemtype codes
of the data you're importing"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:58:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:58:21 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion
           Severity|normal                      |enhancement

--- Comment #15 from Jonathan Druart  ---
I propose to reintroduce the broken feature.
Have a look and test this last patch and tell me what you think about it, to
know if it's useful to continue in this direction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:59:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:59:21 +0000
Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing
	subelements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #15 from Tom?s Cohen Arazi  ---
(In reply to Joonas Kylm?l? from comment #2)
> So the above info adding doesn't happen in the stage-marc-import.pl script
> and it is wasted time to go each and one thousand records by hand and just
> click save on them

Just for yupi to notice, Joonas, that's what touch_all_biblios.pl is for ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:59:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:59:59 +0000
Subject: [Koha-bugs] [Bug 10627] history of reports run/results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14435

--- Comment #5 from Jonathan Druart  ---
I have proposed, on bug 14435, to reintroduce a broken feature.
It is a simpler version of what you suggest, but it heads in the same
direction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 12:59:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 10:59:59 +0000
Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10627

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:08:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:08:08 +0000
Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755

--- Comment #2 from Joonas Kylm?l?  ---
Ok. I found now a more specific reason why this bug happens:

This bug happens when the biblio record which is being processed misses some
info / or the info is invalid (see bug 14768 for more info).

I suggest as a fix that we would add an alert / some info text which would tell
what went wrong really. For example, "The biblio record you're trying to
process is missing some info, please check the compatibility of the biblio
record's data with your system."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:12:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:12:45 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |claire.hernandez at biblibre.c
                   |ommunity.org                |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:14:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:14:22 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #120 from Jonathan Druart  ---
We cannot track all the places this check should be done.
It's a waste of time.
But I am not against your patch, except that the Exception shouldn't be
VirtualShelves specific (should be Koha::Exceptions::UseDbAdminAccount IMO).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:19:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:19:32 +0000
Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart  ---
The itemtype of the record is not defined in the itemtypes table, that's it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:46:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:46:13 +0000
Subject: [Koha-bugs] [Bug 14769] New: Authorities merge: Set correct
 indicators in biblio field
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

            Bug ID: 14769
           Summary: Authorities merge: Set correct indicators in biblio
                    field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Biblio field indicators should be the same indicators as the linked authority's
main field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:46:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:46:45 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #1 from Julian Maurice  ---
Created attachment 42197
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42197&action=edit
Bug 14769: Authorities merge: Set correct indicators in biblio field

Biblio field indicators should be the same indicators as the linked
authority's main field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:46:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:46:58 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:48:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:48:09 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:48:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:48:19 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:52:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:52:46 +0000
Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755

--- Comment #4 from Joonas Kylm?l?  ---
(In reply to Jonathan Druart from comment #3)
> The itemtype of the record is not defined in the itemtypes table, that's it?

That is it. But I guess there could be some other info missing also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:54:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:54:21 +0000
Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats
 and other reports
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11387

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:54:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:54:21 +0000
Subject: [Koha-bugs] [Bug 11387] "Hold waiting too long" is untranslatable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11668

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:56:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:56:43 +0000
Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 13:56:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 11:56:45 +0000
Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

--- Comment #1 from Joonas Kylm?l?  ---
Created attachment 42198
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42198&action=edit
Bug 14711: We do no longer need bibitems in AddReserve

Removes the unnecessary bibitems parameter from all the calls to
AddReserve function and also from the function itself.

Test plan:

1. Try some (if not all) of the pages' functionalities where the code
   was changed.
2. Make sure they work like before and there is no errors in
   the koha-error log.
3. If you didn't try all the pages make sure the code changes in the
   other pages are exactly like they were in the pages you tested.
4. Run all the test and look if they pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:34:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:34:18 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41953|0                           |1
        is obsolete|                            |

--- Comment #121 from Alex Arnaud  ---
Created attachment 42199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42199&action=edit
Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves

The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly
coded and buggy.
It became complicated to fix and enhance them.
This rewrite will make the code more robust and the list feature will be easier
to change.

Some new modules are added to the Koha namespace (Koha::Virtualshelf,
Koha::Virtualshelves, Koha::Virtualshelfshare[s] and
Koha::Virtualshelfcontent[s])
to take advantage of Dbix::Class.

The patchset fixes some bugs:
1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC
2/ The owner of a list should not need any permission to remove content from
his lists.
3/ No feedback messages when actions are done

Test plan:
A) Intranet and OPAC
1/ Create more than 20 private and public lists with different users
2/ Edit some and confirm that the changes are taken into account
3/ Share some lists with other users
4/ Add / remove contents
Be sure you have some lists with more than 20 items (to test the pagination)
5/ Play with permissions and confirm it works as expected.
For private lists:
They should not be viewed by anyone else, if they are not shared
If they are shared (OPAC only):
a. "Allow anyone else to add entries"
  Should allow the user with whom the list is shared to add entries.
b. "Allow anyone to remove his own contributed entries."
  Should allow the user with whom the list is shared to remove his own entries.
c. "Allow anyone to remove other contributed entries."
  Should allow the user with whom the list is shared to remove any entries.

For public lists:
They should be viewed by anyone else.
a. "Allow anyone else to add entries"
  Should allow any user to add entries.
b. "Allow anyone to remove his own contributed entries."
  Should allow any user to remove his own entries.
c. "Allow anyone to remove other contributed entries."
  Should allow any user to remove any entries.

6/ Download and sent lists.

7/ Confirm that the "Add to" feature works as expected.

8/ Confirm that the "Add an item to" works as expected.

9/ Delete some lists.

10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than
20 items).

11/ Use the remove "Remove share" links.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:34:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:34:32 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41954|0                           |1
        is obsolete|                            |

--- Comment #122 from Alex Arnaud  ---
Created attachment 42200
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42200&action=edit
Bug 14544: Get rid of GetShelf

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:34:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:34:41 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41955|0                           |1
        is obsolete|                            |

--- Comment #123 from Alex Arnaud  ---
Created attachment 42201
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42201&action=edit
Bug 14544: Get rid of AddShelf

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:34:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:34:56 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41956|0                           |1
        is obsolete|                            |

--- Comment #124 from Alex Arnaud  ---
Created attachment 42202
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42202&action=edit
Bug 14544: Get rid of DelShelf

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:04 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41957|0                           |1
        is obsolete|                            |

--- Comment #125 from Alex Arnaud  ---
Created attachment 42203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42203&action=edit
Bug 14544: Get rid of ModShelf

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:10 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41958|0                           |1
        is obsolete|                            |

--- Comment #126 from Alex Arnaud  ---
Created attachment 42204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42204&action=edit
Bug 14544: Move share routines to Koha::Virtualshelfshare and
Koha::Virtualshelfshares

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:17 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41959|0                           |1
        is obsolete|                            |

--- Comment #127 from Alex Arnaud  ---
Created attachment 42205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42205&action=edit
Bug 14544: Get rid of GetAllShelves

Signed-off-by: Koha Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:27 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41960|0                           |1
        is obsolete|                            |

--- Comment #128 from Alex Arnaud  ---
Created attachment 42206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42206&action=edit
Bug 14544: Koha::Virtualshelfcontent[s]

Get rid of AddToShelf and DelFromShelf

Bug 14544: Allow a user to delete his own contents

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:37 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41973|0                           |1
        is obsolete|                            |

--- Comment #129 from Alex Arnaud  ---
Created attachment 42207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42207&action=edit
Bug 14544: Make the intranet side independent of Page.pm

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:43 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41974|0                           |1
        is obsolete|                            |

--- Comment #130 from Alex Arnaud  ---
Created attachment 42208
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42208&action=edit
Bug 14544: Get rid of GetBibliosShelves

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:50 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41975|0                           |1
        is obsolete|                            |

--- Comment #131 from Alex Arnaud  ---
Created attachment 42209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42209&action=edit
Bug 14544: Get rid of GetShelves

This does not work for now, see later.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:35:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:35:56 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41976|0                           |1
        is obsolete|                            |

--- Comment #132 from Alex Arnaud  ---
Created attachment 42210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42210&action=edit
Bug 14544: Make the OPAC side independent of Page.pm

Bug 14544: Fix redirect on editing a list

If you edit a list from the list view, after saving the form, you are
not redirected to the list view (but on the edit form).

Bug 14544: Cosmetic: › should be a class divider

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:02 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41977|0                           |1
        is obsolete|                            |

--- Comment #133 from Alex Arnaud  ---
Created attachment 42211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42211&action=edit
Bug 14544: Get rid of ShelfPossibleAction

Bug 14544: (follow-up) Get rid of ShelfPossibleAction

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:11 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41978|0                           |1
        is obsolete|                            |

--- Comment #134 from Alex Arnaud  ---
Created attachment 42212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42212&action=edit
Bug 14544: Get rid of GetShelfContent

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:17 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41979|0                           |1
        is obsolete|                            |

--- Comment #135 from Alex Arnaud  ---
Created attachment 42213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42213&action=edit
Bug 14544: Get rid of GetSomeShelfNames

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:24 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41980|0                           |1
        is obsolete|                            |

--- Comment #136 from Alex Arnaud  ---
Created attachment 42214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42214&action=edit
Bug 14544: Move HandleDelBorrower to C4::Members

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:32 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41981|0                           |1
        is obsolete|                            |

--- Comment #137 from Alex Arnaud  ---
Created attachment 42215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42215&action=edit
Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:38 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41982|0                           |1
        is obsolete|                            |

--- Comment #138 from Alex Arnaud  ---
Created attachment 42216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42216&action=edit
Bug 14544: Remove wrong tips about permissions

The owner of a list should not need any permission to remove contents.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:45 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41986|0                           |1
        is obsolete|                            |

--- Comment #139 from Alex Arnaud  ---
Created attachment 42217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42217&action=edit
Bug 14544: Fix regression on adding a new list

The user should not be allowed to create a new list and get a friendly
error message if he tries.

The "New list" links are removed.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:52 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41988|0                           |1
        is obsolete|                            |

--- Comment #140 from Alex Arnaud  ---
Created attachment 42218
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42218&action=edit
Bug 14544: DB Changes: Set a default value for sortfield

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:36:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:36:58 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42192|0                           |1
        is obsolete|                            |

--- Comment #141 from Alex Arnaud  ---
Created attachment 42219
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42219&action=edit
Bug 14544 - Handle database error when creating a shelf with DB admin account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:42:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:42:26 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #142 from Alex Arnaud  ---
Didn't see any *new* bugs/issues so i signed off all the patches (except mine). 

But Why don't use this BZ to fix existing problems on virtualshelves system
(Like the one shown by Fridolin)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:42:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:42:29 +0000
Subject: [Koha-bugs] [Bug 14770] New: Use $9 in GetMarcSeries to build
	search link
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

            Bug ID: 14770
           Summary: Use $9 in GetMarcSeries to build search link
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Use $9 in GetMarcSeries to build search link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:44:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:44:30 +0000
Subject: [Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

--- Comment #1 from Julian Maurice  ---
Created attachment 42220
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42220&action=edit
Bug 14770: Use $9 in GetMarcSeries to build search link

The behaviour is the same as in GetMarcAuthors.
Also skip $3 subfields if UNIMARC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:45:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:45:31 +0000
Subject: [Koha-bugs] [Bug 14544] Move the list related code to
	Koha::Virtualshelves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #143 from Jonathan Druart  ---
(In reply to Alex Arnaud from comment #142)
> Didn't see any *new* bugs/issues so i signed off all the patches (except
> mine). 
> 
> But Why don't use this BZ to fix existing problems on virtualshelves system
> (Like the one shown by Fridolin)?

Because it's a huge change enough :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:45:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:45:47 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com

--- Comment #10 from Joonas Kylm?l?  ---
I cannot even test this because in the latest master it doesn't show any lists
which I have created. But if I click the button "Patron lists" there it shows
the lists I have created.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:48:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:48:39 +0000
Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal
 before' (days or hours)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

--- Comment #25 from bondiurbano  ---
(In reply to Holger Mei?ner from comment #23)
> Sorry, I forgot about the unit tests. Note that two test cases (related to
> bug 11634) still fail and I think they are not affected by anything I did.
> I'm not sure how to fix them and it probably should be done in another bug.
> 
> Thanks for looking at this, Kyle! Setting back to Signed Off.

Holger, sorry for this comment: this patch is waiting to be fixed and  sent to
QA for testing. You have made a great job and it would be nice to have it in
next release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:50:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:50:10 +0000
Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove
 link to course reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

--- Comment #7 from Tom?s Cohen Arazi  ---
Created attachment 42221
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42221&action=edit
Bug 14205: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:50:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:50:33 +0000
Subject: [Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #2 from Julian Maurice  ---
Test plan:

1/ In your MARC framework configure the field 225 (440..490 for MARC21/NORMARC)
like this:
1.1/ Add a subfield $9
1.2/ Set an authority link on subfield $a
2/ Create biblio and use the authority plugin to fill field 225 (440..490 for
MARC21/NORMARC)
3/ Check on staff and opac detail pages that the series link is like
"search.pl?q=an:XXXXX" where XXXXX is the id of the linked authority
4/ Remove the $9 and check the link is like "search.pl?q=se:ABCDEF" where
ABCDEF is the value of $a

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 14:55:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 12:55:08 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #11 from Jonathan Druart  ---
(In reply to Joonas Kylm?l? from comment #10)
> I cannot even test this because in the latest master it doesn't show any
> lists which I have created. But if I click the button "Patron lists" there
> it shows the lists I have created.

This is fixed by the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:01:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:01:30 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #63 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #62)
> It works fine for me with Debian Jessie.
> Did you check if your 'git bz' is up to date?

If you submit what you applied here, we probably tackled it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:07:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:07:54 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Zeno Tajoli  ---
Hi Julian,

this statement 'Biblio field indicators should be the same indicators as the
linked authority's main field' is not correct, at least in MARC21.
>From LOC Manual:
Bib tag 600 is connect with Auth tag 100
Bib ind 1 == Auth ind 1
Bib ind 2 is different from Auth ind 2

Bib tag 240 is connect with Auth tag 130
Bib ind 1 is different from Auth ind 1
Bib ind 2 == Auth ind 2

Bib tag 630 is connect with Auth tag 130
Bib ind 1 == Auth ind 2
Bib ind 2 is different from Auth ind 1

If fact it is true also for Unimarc.
>From IFLA Manual:
Bib tag 500 is connect with Auth tag 230
Bib ind 1 is different from Auth ind 1
Bib ind 2 is different from Auth ind 2

I think that the idea is good but need to manage those cases with specific
routines for MARC21 and Unimarc. For NORMARC we need to ask to Magnus Enger, we
can start with a copy of MARC21 routine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:42:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:42:30 +0000
Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators
 in biblio field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

--- Comment #3 from Julian Maurice  ---
Hi Zeno,

It seems to be true for all UNIMARC 7XX, and I assumed (hoped?) it was true for
all authority links...
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:47:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:47:51 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:47:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:47:54 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #3 from Jonathan Druart  ---
Created attachment 42222
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42222&action=edit
Bug 7634: Make the tests pass

This patch just fixed a master bug, if your database already has some
items.homebranch set to CPL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:47:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:47:57 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #4 from Jonathan Druart  ---
Created attachment 42223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42223&action=edit
Bug 7634: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:48:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:48:07 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #5 from Jonathan Druart  ---
Created attachment 42224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42224&action=edit
Bug 7634: Prevent permanent_location to be set to NULL if not defined

The permanent_location is correctly filled when an item is added from
the cataloguing module (routine set_item_default_location from
cataloguing/additem.pl).
But when records are imported, this filled is not managed. It's only on
editing (_do_column_fixes_for_mod called from ModItem).

This patch set the permanent_location item fields to the location value for all
items created, even the imported ones.

Test plan:
0/ Do not apply this patch
1/ Import a record with items using the "Stage MARC for import" tool
2/ Check the values for the permanent_location in the items table.
They are set to NULL
3/ Apply this patch
4/ Repeat 2 and confirm that now the permanent_location values are set
to the location values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:48:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:48:19 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 15:58:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 13:58:15 +0000
Subject: [Koha-bugs] [Bug 9844] Add a barcode queue to checkout / return
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9844

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:02:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:02:51 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13026

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:02:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:02:51 +0000
Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7634
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:04:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:04:13 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

--- Comment #1 from Blou  ---
Created attachment 42225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42225&action=edit
Bug 14726 - Checkout summary doesn't show title

Right after checking out, a small box appear with "Checkout out: Some Title
(32154001669305). Due on 24/09/2015".
The title doesn't appear anymore (since the move to db schemas).  This fixes
it.

Test:
1) checkout ANY item, for ANY user
2) Look at summary right below the checkout input box.  The title doesn't show
up.
3) apply patch, reproduce same steps (after checkin if same item).  Title
appears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:04:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:04:26 +0000
Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026

--- Comment #1 from Jonathan Druart  ---
Any idea how this could happen?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:04:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:04:59 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:07:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:07:56 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

--- Comment #21 from Jonathan Druart  ---
Created attachment 42226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42226&action=edit
Bug 11247: Improve tests

This patch makes the tests non dependent on the DB and test the 3 marc
flavours.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:08:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:08:31 +0000
Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:09:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:09:26 +0000
Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove
 link to course reserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #8 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:09:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:09:59 +0000
Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the
	command line
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:10:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:10:33 +0000
Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in
	catalogue/search.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:10:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:10:57 +0000
Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:11:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:11:10 +0000
Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:13:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:13:31 +0000
Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via
	plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Jonathan Druart  ---
Should we set 148 as mandatory for the CHRON_TERM auth type?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:21:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:21:32 +0000
Subject: [Koha-bugs] [Bug 14771] New: all patrons to pick a username
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771

            Bug ID: 14771
           Summary: all patrons to pick a username
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be nice if patrons could pick their own username when registering for
a card and/or edit their username via the patron account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:22:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:22:20 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_New=3A__Remove_or_clarify_c?=
 =?utf-8?q?heckbox_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?=
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772

            Bug ID: 14772
           Summary: Remove or clarify checkbox ?flagged? on subfield
                    visibility frameworks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It seems no one know what is the utility of setting the subfield visibility to
"flagged". Manual say nothing about: (2.4.1.4. Edit Framework Subfields >
Advanced constraint values > Visibility) and related bug #9894 neither.

If this feature is only a historic vestiges should be removed, else the manual
should say what it is.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 16:57:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 14:57:29 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42170|0                           |1
        is obsolete|                            |

--- Comment #8 from Lari Taskula  ---
Created attachment 42227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42227&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 17:00:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 15:00:14 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42227|0                           |1
        is obsolete|                            |

--- Comment #9 from Lari Taskula  ---
Created attachment 42228
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42228&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 17:47:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 15:47:03 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #7 from Barton Chittenden  ---
(In reply to Kyle M Hall from comment #3)
> (In reply to Katrin Fischer from comment #1)
> > Hm, this would need good testing. I think you also need to make sure there
> > is no problem with the way credits work. But it would be good to have!
> 
> Credits have a negative amount and amountoutstanding, so the query would
> definitely not affect credits.

Payments and credits have a negative amount and a *0* amountoutstanding.

As I understand accountlines, the account balance is calculated by summing the
amountoutstanding... so removing the records for credits and payments won't
affect the balance, but I'm concerned about partial payments: consider the case
of partial payments:

+-----------------+----------------+-----------+-------------------+------------+------------------------+
| accountlines_id | borrowernumber | amount    | amountoutstanding | date      
| description            |
+-----------------+----------------+-----------+-------------------+------------+------------------------+
|              10 |              1 |  6.000000 |          3.000000 | 2015-08-03
| test 5                 |
|              11 |              1 |  3.000000 |          0.000000 | 2015-08-03
|  partial payment       |
+-----------------+----------------+-----------+-------------------+------------+------------------------+

If we run cleanup_database.pl with a --fees 20, accountlines_id 11 will be
removed (0.000000 amountoutstanding, date < 2015-08-13). but accountlines_id 10
won't be removed, because 3.000000 amountoutstanding > 0. The borrower's
balance will remain at 3.00, (rather than the original 6.00), but the payment
record won't be there.

There's no way around this -- accountlines doesn't provide a way to determine
what a credit or debit was applied to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:04:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:04:34 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Fiona Borthwick  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:24:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:24:36 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39023|0                           |1
        is obsolete|                            |

--- Comment #64 from M. Tompsett  ---
Created attachment 42234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42234&action=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
  with GetItemsInfo() call, passing order_by "cn_sort"

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:24:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:24:42 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39024|0                           |1
        is obsolete|                            |

--- Comment #65 from M. Tompsett  ---
Created attachment 42235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42235&action=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:24:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:24:49 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39025|0                           |1
        is obsolete|                            |

--- Comment #66 from M. Tompsett  ---
Created attachment 42236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42236&action=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:24:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:24:55 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39026|0                           |1
        is obsolete|                            |

--- Comment #67 from M. Tompsett  ---
Created attachment 42237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42237&action=edit
bug_11213: C4::VirtualShelves::Page::shelf_contents()

* Extracted shelf items processing from shelfpage() into a separate sub
  shelf_contents() in order to be able to test it
* Added tests for shelf_contents() with XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:25:02 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39027|0                           |1
        is obsolete|                            |

--- Comment #68 from M. Tompsett  ---
Created attachment 42238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42238&action=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:25:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:25:08 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39028|0                           |1
        is obsolete|                            |

--- Comment #69 from M. Tompsett  ---
Created attachment 42239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42239&action=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:25:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:25:16 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39029|0                           |1
        is obsolete|                            |

--- Comment #70 from M. Tompsett  ---
Created attachment 42240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42240&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:28:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:28:38 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #71 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #63)
> If you submit what you applied here, we probably tackled it..

Hope this helps. I left the status as is, since you were the one to change it
last.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:32:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:32:07 +0000
Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron
	attributes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Vitor Fernandes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:33:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:33:54 +0000
Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron
	attributes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |vfernandes at keep.pt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:42:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:42:55 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 18:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 16:43:01 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40523|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall  ---
Created attachment 42241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42241&action=edit
[SIGNED-OFF] Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
    preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:39:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:39:00 +0000
Subject: [Koha-bugs] [Bug 12824] Create a general purpose koha-config script?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:47:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:47:20 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks guys!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:47:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:47:45 +0000
Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item
 deletes item anyway
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #18 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:48:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:48:08 +0000
Subject: [Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media
 is enabled and url has plus (+) characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:48:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:48:33 +0000
Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 19:49:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 17:49:06 +0000
Subject: [Koha-bugs] [Bug 13972] Include fields from subscription and serial
 table in serial notification email
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 20:35:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 18:35:27 +0000
Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for
	patron import
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601

--- Comment #7 from Danielle Elder  ---
(In reply to Jonathan Druart from comment #6)
> CCing St?phane,
> I would like to get your opinion on this point.
> Do you have the same problem when you migrate/import patrons to Koha?

This is a real problem as the library wants to update several times a semester.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 20:43:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 18:43:07 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

techservspec at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |techservspec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 20:44:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 18:44:32 +0000
Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for
	patron import
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601

--- Comment #8 from Danielle Elder  ---
Katrin I read the bugs mentioned about missing cardnumber or empty string and
that would not be the case here. That patrons have cardnumbers already, we just
don't want to overwrite the existing cardnumber when importing/overwriting
based on a unique attribute (university ID) and want to leave out the
cardnumber column.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 21:44:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 19:44:22 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #8 from Barton Chittenden  ---
Created attachment 42242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42242&action=edit
Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:47:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:47:22 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:47:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:47:24 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41086|0                           |1
        is obsolete|                            |
  Attachment #41087|0                           |1
        is obsolete|                            |
  Attachment #41088|0                           |1
        is obsolete|                            |
  Attachment #42242|0                           |1
        is obsolete|                            |

--- Comment #9 from Barton Chittenden  ---
Created attachment 42243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42243&action=edit
[SIGNED-OFF] Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:47:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:47:50 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #10 from Barton Chittenden  ---
Created attachment 42244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42244&action=edit
[SIGNED-OFF] Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
    * accountlines.amountoutstanding is 0, and date is set to $days - 1
      days ago. The accountlines row should not be deleted.
    * accountlines.amountoutstanding is 0, and date is set to $days
      days ago.  the accountlines row should not be deleted, because
      the difference must be *greater* than $days.
    * accountlines.amountoutstanding is 0, and date is set to $days + 1
      days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:47:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:47:55 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #11 from Barton Chittenden  ---
Created attachment 42245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42245&action=edit
[SIGNED-OFF] Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:47:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:47:57 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #12 from Barton Chittenden  ---
Created attachment 42246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42246&action=edit
[SIGNED-OFF] Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 22:50:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 20:50:57 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nkeener at washoecounty.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 23:13:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 21:13:50 +0000
Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via
	plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

--- Comment #6 from Katrin Fischer  ---
Hm, sounds good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  2 23:16:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 21:16:17 +0000
Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log
	in page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

--- Comment #10 from Liz Rea  ---
I'll make a different bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 00:39:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 22:39:35 +0000
Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with
 duplicate priorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
This works, but it does have the side effect that in the staff interface where
it shows the priority when placing a reserve.

It will say Priority 1 for example

Then you save it, and now its priority 2 ... I think this will prompt bug
reports from Librarians. Do we care about that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 00:40:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 22:40:51 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #2 from Chris Cormack  ---
Ohh look an easily testable patch that fixes a major bug .. just waiting for
Global bug squash day :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 00:58:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 22:58:55 +0000
Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and
 patron category on OPAC registration page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659

--- Comment #1 from Jesse Weaver  ---
Created attachment 42252
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42252&action=edit
Bug 14659: Allow patrons to enter card number and patron category on OPAC
registration page

Test plan:
  1. Open OPAC self-registration page while logged out.
  2. Note that cardnumber and categorycode are not shown.
  3. Remove cardnumber and categorycode from
     PatronSelfRegistrationBorrowerUnwantedField.
  4. Enable autoMemberNum.
  5. Reload self-registration page, note that categorycode now shows.
  6. Disable autoMemberNum.
  7. Reload self-registration page, note that cardnumber now shows.
  8. Try saving a patron with an existing cardnumber; this should fail
     and explain why.
  9. Set CardnumberLength, and verify that those length restrictions are
     enforced.
 10. Verify that patron can be created with custom categorycode and
     cardnumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 01:03:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 23:03:07 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 01:03:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 23:03:09 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #4 from Jesse Weaver  ---
Created attachment 42253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42253&action=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 01:23:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 23:23:54 +0000
Subject: [Koha-bugs] [Bug 14773] New: Move help link back out of the
	dropdown menu
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

            Bug ID: 14773
           Summary: Move help link back out of the dropdown menu
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

14579 added some things to the login menu, but also moved the help link into
the dropdown which is an undesirable change. We shouldn't hide the help links
for the intranet, it should always be one click to get there. Right now it
takes two.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 01:23:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 23:23:54 +0000
Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log
	in page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

Liz Rea  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14773

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 01:57:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Sep 2015 23:57:13 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to be visible
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #2 from Jesse Weaver  ---
Created attachment 42254
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42254&action=edit
Bug 13757 - Make patron attributes editable in the OPAC (1/2)

This patch adds an opac_editable property of borrower attribute types
that can be set in the interface.

Test plan:
  1. Repeat the following with a new and existing borrower attribute
     type:
  2. Verify that "Editable in OPAC" can only be checked if "Display in
     OPAC" is checked.
  3. Verify that this new property is correctly saved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 03:50:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 01:50:27 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #3 from Mason James  ---
(In reply to Joonas Kylm?l? from comment #2)
> (In reply to Mason James from comment #1)
> >1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday >rows)
> 
> Could you give some example table? It would be easier to test.

hmm, yes i could, but...

 you can quickly create a range of special/unique holidays in a few clicks
... from '2014-01-01' to '2016-01-01', would give you 730 holidays for testing

i'll attach a pic

> 
> >2/ add a loong circ rule for an itemtype (my rule has 140 days)
> 
> Do you mean loan period?

oops yes, thats what i mean :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 03:52:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 01:52:07 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #4 from Mason James  ---
Created attachment 42255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42255&action=edit
pic: create range of holidays

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 03:54:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 01:54:47 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #5 from Mason James  ---
(In reply to Mason James from comment #3)
> (In reply to Joonas Kylm?l? from comment #2)
> > (In reply to Mason James from comment #1)
> > >1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday >rows)
> > 
> > Could you give some example table? It would be easier to test.
> 
> hmm, yes i could, but...
> 
>  you can quickly create a range of special/unique holidays in a few clicks
> ... from '2014-01-01' to '2016-01-01', would give you 730 holidays for
> testing
> 
> i'll attach a pic

mysql> select count(*)  from special_holidays where title = 'aaa' ;
+----------+
| count(*) |
+----------+
|      614 |
+----------+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 04:08:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 02:08:03 +0000
Subject: [Koha-bugs] [Bug 14774] New: Task Scheduler not working on
	Ubuntu/Apache2.4
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

            Bug ID: 14774
           Summary: Task Scheduler not working on Ubuntu/Apache2.4
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Task Scheduler
          Assignee: gmcharlt at gmail.com
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

The task scheduler uses At to schedule reports to be run later. It's doing
something weird in Ubuntu 14, Apache 2.4.

Scheduling a task on Debian/Apache 2.2 results in the job being added, and it
showing up in the web page. This doesn't happen on Ubuntu/Apache 2.4, it
returns a "Failed to add job."

It looks like Koha is asking atq for the list of current jobs (through
Schedule::At) and it's not getting a list back when run on Ubuntu/2.4. This all
works just fine in Debian/2.2.

in /var/spool/cron/atjobs we can see where jobs are added:

Failing job "Failed to add job", Ubuntu, Apache 2.4:
---------- 1 daemon daemon 2.9K Sep  2 15:19 a0004a016e87ae

Successful job displays in the web page, Debian, Apache 2.2
-rwx------ 1 library-koha daemon 2.8K Sep  2 16:15 a00014016f1f52

When we ask for the euid/gid of the user when trying to add these failed jobs,
it seems like it should be OK:

uid: 1005, euid: 1005

Which corresponds to the uid given in /etc/passwd:
library-koha:x:1005:1005

As far as I can tell, those daemon:daemon no permissions jobs aren't actually
run - how could they, they have no executable permissions.

Pretty sure this bug isn't in Koha proper (the scheduler actually works just
fine in Debian/2.2), but some interaction or security thing in Ubuntu/Apache
2.4. It might be nice to figure out why it happens, so we can end run the
problem (or decide to scrap the At reliant scheduler, which is probably a
"should do" anyway).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 04:23:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 02:23:10 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #18 from Mason James  ---
sorry, i missed some questions here...

(In reply to Kyle M Hall from comment #8)
> Pardon my being late to reply to this, but could this be solved with a a
> screen message regex?
> 
> 

^ no that wont work, the glitchy '(1)' string is created within the Overdrive
app, and external to Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 04:58:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 02:58:03 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 04:58:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 02:58:07 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40840|0                           |1
        is obsolete|                            |

--- Comment #10 from Chris Cormack  ---
Created attachment 42256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42256&action=edit
Bug 14472 - Wrong ISSN search index in record matching rules

To Test
---------
 1) Apply the patch
 2) Export some MARC bibliographic records from Koha
 3) Import those same MARC bibliographic records using the
    "ISSN(022$a)" record matching rule.
 4) The incoming records should match perfectly
 5) Check the mysql tables (marc_matchers, matchpoints,
    matcher_matchpoints, matchpoint_components,
    matchpoint_component_norms) to make sure the values were
    inserted as expected.
For new Koha installation
 1) create the koha database
 2) Go to the staff client page, and do a "fresh" install making
    sure to select lots of optional marc 21 matching rules so
    the .../marc21/optional/marc21_default_matching_rules.sql
    gets triggered.
 3) Check the mysql tables (marc_matchers, matchpoints,
    matcher_matchpoints, matchpoint_components,
    matchpoint_component_norms) to make sure the values were
    inserted as expected.

Bug 14472 - Added Atomic Update to fix wrong issn search index

    - Fix comments

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:02:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:02:50 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:02:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:02:53 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41084|0                           |1
        is obsolete|                            |

--- Comment #12 from Chris Cormack  ---
Created attachment 42257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42257&action=edit
Bug 12525: FIX patron lists dropdown is empty

On the patrons home page, the dropdown list is not populated.

Test plan:
1/ Go on the patrons home page (members/members-home.pl)
2/ Launch a search
3/ The dropdown list close to "Add selected patrons to" should contain
all your patron lists

NOTE: Initially tested with both which created lists.
      git reset --hard origin/master
      And then dropdown list was missing them.
      Applied just this one, and they were listed.

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:03:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:03:04 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42193|0                           |1
        is obsolete|                            |

--- Comment #13 from Chris Cormack  ---
Created attachment 42258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42258&action=edit
Bug 12525: Prevent adding several patron lists with the same name

If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.

To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created

Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:08:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:08:23 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #103 from Peter Zhao  ---
(In reply to Peter Zhao from comment #98)
> ES Opac cannot support Chinese language? I try to search Chinese word in
> http://elasticsearch.koha.catalystdemo.net.nz/ and my ES, they also show
> "Software error".
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /opt/kohaclones/elasticsearch/Koha/SearchEngine/Elasticsearch/QueryBuilder.
> pm line 217.
> 
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error. 
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /home/koha/kohaes/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 217.
> 
> For help, please send mail to the webmaster (webmaster at koha), giving this
> error message and the time and date of the error.

After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
search Chinese in MARC21 structure.

But it does not work in UNIMARC structure. It shows messy code.

koha at koha:~$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 
{
  "took" : 132,
  "timed_out" : false,
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "failed" : 0
  },
  "hits" : {
    "total" : 2,
    "max_score" : 1.0,
    "hits" : [ {
      "_index" : "koha_biblios",
      "_type" : "data",
      "_id" : "1",
      "_score" : 1.0,
      "_source":{"pubdate":"   
","subject":[["?????"],["?????"],["?????"]],"author__facet":[["???????"]],"_id":"1","author":[["???????"]],"subject__facet":[["?????"],["?????"],["?????"]],"record":[["LDR",null,null,"_","00261nam
 22001213 
4500"],["001",null,null,"_","1"],["005",null,null,"_","20150903102757.0"],["090","
"," ","a","1"],["100"," "," ","a","20150903d        u||y0chiy50     
ea"],["200"," ","
","a","??????????","c","Peter","f","???????"],["600"," ","
","a","?????"],["601"," "," ","a","?????"],["942"," ","
","c","BK"],["999"," ","
","c","1","d","1"]],"ta":"u","title":[["??????????"],["Peter"]],"onloan":"0","Local-number":[["1"]]}
    }, {
      "_index" : "koha_biblios",
      "_type" : "data",
      "_id" : "2",
      "_score" : 1.0,
      "_source":{"pubdate":"   
","subject":[["?????"],["?????"],["?????"]],"author__facet":[["peter"]],"_id":"2","author":[["peter"]],"subject__facet":[["?????"],["?????"],["?????"]],"record":[["LDR",null,null,"_","00257nam
 22001213 
4500"],["001",null,null,"_","2"],["005",null,null,"_","20150903105155.0"],["090","
"," ","a","2"],["100"," "," ","a","20150903d        u||y0chiy50     
ea"],["200"," "," ","a","??????????","c","Peter","f","peter"],["600","
"," ","a","?????"],["601"," "," ","a","?????"],["942"," ","
","c","BK"],["999"," ","
","c","2","d","2"]],"ta":"u","title":[["??????????"],["Peter"]],"onloan":"0","Local-number":[["2"]]}
    } ]
  }
}
koha at koha:~$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:14:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:14:18 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:14:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:14:21 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41012|0                           |1
        is obsolete|                            |

--- Comment #24 from Chris Cormack  ---
Created attachment 42259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42259&action=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:28:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:28:06 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42222|0                           |1
        is obsolete|                            |

--- Comment #6 from Chris Cormack  ---
Created attachment 42260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42260&action=edit
Bug 7634: Make the tests pass

This patch just fixed a master bug, if your database already has some
items.homebranch set to CPL

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:28:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:28:22 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42223|0                           |1
        is obsolete|                            |

--- Comment #7 from Chris Cormack  ---
Created attachment 42261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42261&action=edit
\# Attachment to Bug 7634 - Permanent Location (shelving location) is NULL when
Import MARC records tool is used

Bug 7634: Add tests

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:28:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:28:39 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:28:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:28:41 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42224|0                           |1
        is obsolete|                            |

--- Comment #8 from Chris Cormack  ---
Created attachment 42262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42262&action=edit
Bug 7634: Prevent permanent_location to be set to NULL if not defined

The permanent_location is correctly filled when an item is added from
the cataloguing module (routine set_item_default_location from
cataloguing/additem.pl).
But when records are imported, this filled is not managed. It's only on
editing (_do_column_fixes_for_mod called from ModItem).

This patch set the permanent_location item fields to the location value for all
items created, even the imported ones.

Test plan:
0/ Do not apply this patch
1/ Import a record with items using the "Stage MARC for import" tool
2/ Check the values for the permanent_location in the items table.
They are set to NULL
3/ Apply this patch
4/ Repeat 2 and confirm that now the permanent_location values are set
to the location values.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:39:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:39:11 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:39:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:39:14 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42149|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack  ---
Created attachment 42263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42263&action=edit
Bug 14766: Complete cataloguing plugin unimarc_field_4XX

Add subfields l, n and o for better UNIMARC compliance

Signed-off-by: Chris Cormack 

Note: I just did a code audit here, as I don't know enough about
UNIMARC to know if the 4XX fields should have these subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:46:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:46:07 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:46:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:46:10 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42083|0                           |1
        is obsolete|                            |

--- Comment #6 from Chris Cormack  ---
Created attachment 42264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42264&action=edit
Bug 14651: (regression test) fallback to bib-level if itype is undef

Koha::Item->effective_itemtype should fallback to biblio-level itemtype
even if item-level item types are set, in the case the item has no itemtype
set (bad migration, bad old code).

To test:
- Run
  $ prove t/db_dependent/Items.t
=> FAIL: Koha::Item->effective_itemtype doesn't work properly

Edit: Added a test for a warning when falling back as per QA request
and because it made a lot of sense :-D

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 05:46:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 03:46:20 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42084|0                           |1
        is obsolete|                            |

--- Comment #7 from Chris Cormack  ---
Created attachment 42265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42265&action=edit
Bug 14651: Koha::Item->effective_itemtype fallback to bib-level

In some situations (bad migrations, old bugs that introduced bad data,
people having bib-level itypes for ages and switching to item level...)
the user ends with undex itype values for items.

The current code, if the user has item_level-itype set, just returns
undef. It should fallback to bib-level. In order to avoid hiding the problem
a warning is raised.

To test:
- Run the regression tets:
  $ prove t/db_dependent/Items.t
=> FAIL: tests fail.
- Apply the patch
- Run the tests again
=> SUCCESS: The tests now pass.
- Sign off :-D

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:17:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:17:15 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:17:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:17:18 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41494|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack  ---
Created attachment 42266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42266&action=edit
Bug 14621 - Messaging preferences table needs to be sorted

I have been working with messaging preferences and I noticed a weird issue in
Firefox on Ubuntu.

On messaging preferences page, the table is unsorted and the content in rows
are generated randomly
on every page refresh. When you select/deselect checkboxes and refresh the page
(without posting the changes),
Firefox will remember your choices. Now the issue is that when the table is
unsorted and the rows keep
changing on page refresh, Firefox has trouble remembering your choices. This
makes it appear as if the
checkboxes are magically changing values on each page refresh.

Here is a patch that prevents this problem by sorting the messaging settings.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:24:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:24:54 +0000
Subject: [Koha-bugs] [Bug 444] Manual Credits does not support authorised
 values (Manual invoices do)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=444

Irma Birchall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Seeking developer
                 CC|                            |irma at calyx.net.au

--- Comment #2 from Irma Birchall  ---
Hi Paul and others, 

Now that Manual Credit is available with two options of Credit Type : Credit or
Forgiven, I wonder if the support of Authorised Values is likely to be useful
for some libraries. 

It is a missing improvement but would it ever be used?

If you think that the answer is "rarely" should this bug/enhancement be closed?

Cheers, 
Irma

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:31:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:31:18 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #104 from Robin Sheat  ---
(In reply to Peter Zhao from comment #103)
> After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
> search Chinese in MARC21 structure.
> 
> But it does not work in UNIMARC structure. It shows messy code.

The code paths between MARC21 and UNIMARC shouldn't differ in ways that would
make a difference here. The only place where it comes up is determining that
XXXy goes into "author" or whatever.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:49:24 +0000
Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678

James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jb.australian at gmail.com

--- Comment #1 from James  ---
Not all ISO 639.2 Language Codes are recognised by Koha, causing many languages
to not be searchable using the language filter.
FKA Children's Services in Melbourne, Australia provided multilingual resources
and currently can't search for over a third of the languages in their
collection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 06:54:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 04:54:26 +0000
Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678

--- Comment #2 from Irma Birchall  ---
http://library.fka.com.au/cgi-bin/koha/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 07:03:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 05:03:38 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #105 from Peter Zhao  ---
(In reply to Robin Sheat from comment #104)
> (In reply to Peter Zhao from comment #103)
> > After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
> > search Chinese in MARC21 structure.
> > 
> > But it does not work in UNIMARC structure. It shows messy code.
> 
> The code paths between MARC21 and UNIMARC shouldn't differ in ways that
> would make a difference here. The only place where it comes up is
> determining that XXXy goes into "author" or whatever.

The following are 3 records, Chinese words show messy code, English words show
correct, but they cannot search through Opac.

koha at koha:~$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 
{
  "took" : 3,
  "timed_out" : false,
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "failed" : 0
  },
  "hits" : {
    "total" : 3,
    "max_score" : 1.0,
    "hits" : [ {
      "_index" : "koha_biblios",
      "_type" : "data",
      "_id" : "1",
      "_score" : 1.0,
      "_source":{"pubdate":"   
","subject":[["?????"],["?????"],["?????"]],"author__facet":[["???????"]],"_id":"1","author":[["???????"]],"subject__facet":[["?????"],["?????"],["?????"]],"record":[["LDR",null,null,"_","00261nam
 22001213 
4500"],["001",null,null,"_","1"],["005",null,null,"_","20150903102757.0"],["090","
"," ","a","1"],["100"," "," ","a","20150903d        u||y0chiy50     
ea"],["200"," ","
","a","??????????","c","Peter","f","???????"],["600"," ","
","a","?????"],["601"," "," ","a","?????"],["942"," ","
","c","BK"],["999"," ","
","c","1","d","1"]],"ta":"u","title":[["??????????"],["Peter"]],"onloan":"0","Local-number":[["1"]]}
    }, {
      "_index" : "koha_biblios",
      "_type" : "data",
      "_id" : "2",
      "_score" : 1.0,
      "_source":{"pubdate":"   
","subject":[["?????"],["?????"],["?????"]],"author__facet":[["peter"]],"_id":"2","author":[["peter"]],"subject__facet":[["?????"],["?????"],["?????"]],"record":[["LDR",null,null,"_","00257nam
 22001213 
4500"],["001",null,null,"_","2"],["005",null,null,"_","20150903105155.0"],["090","
"," ","a","2"],["100"," "," ","a","20150903d        u||y0chiy50     
ea"],["200"," "," ","a","??????????","c","Peter","f","peter"],["600","
"," ","a","?????"],["601"," "," ","a","?????"],["942"," ","
","c","BK"],["999"," ","
","c","2","d","2"]],"ta":"u","title":[["??????????"],["Peter"]],"onloan":"0","Local-number":[["2"]]}
    }, {
      "_index" : "koha_biblios",
      "_type" : "data",
      "_id" : "3",
      "_score" : 1.0,
      "_source":{"pubdate":"   
","subject":[["History"],["History"],["Christianity"]],"author__facet":[["Peter"]],"_id":"3","author":[["Peter"]],"subject__facet":[["History"],["History"],["Christianity"]],"record":[["LDR",null,null,"_","00259nam
 22001213 
4500"],["001",null,null,"_","3"],["005",null,null,"_","20150903125354.0"],["090","
"," ","a","3"],["100"," "," ","a","20150903d        u||y0frey50     
ba"],["200"," "," ","a","History of Christianity","f","Peter"],["600"," ","
","a","History"],["601"," "," ","a","Christianity"],["942"," ","
","c","BK"],["999"," "," ","c","3","d","3"]],"ta":"u","title":[["History of
Christianity"]],"onloan":"0","Local-number":[["3"]]}
    } ]
  }
}
koha at koha:~$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 07:57:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 05:57:57 +0000
Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing
	single_holidays()
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jb.australian at gmail.com

--- Comment #6 from James  ---
Problem in testing, when trying to create holidays using patch the date format
is being read incorrectly resulting in the following message for a holiday
range ending on 26th November:

Software error:

The 'month' parameter ("26") to DateTime::new did not pass the 'an integer
between 1 and 12' callback
 at /usr/lib/perl5/DateTime.pm line 199
        DateTime::new(undef, 'year', 2015, 'month', 26, 'day', 11) called at
/home/koha/src/tools/newHolidays.pl line 67

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:17:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:17:47 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28618|0                           |1
        is obsolete|                            |

--- Comment #25 from Mason James  ---
Created attachment 42267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42267&action=edit
Bug 10554: Add more options to 'AllowSelfCheckReturns' syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:20:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:20:08 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #26 from Mason James  ---
(In reply to Jonathan Druart from comment #18)
> Comment on attachment 28618 [details] [review]
> Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref
> 
> Review of attachment 28618 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: installer/data/mysql/updatedatabase.pl
> @@ +8555,5 @@
> > +if ( CheckVersion($DBversion) ) {
> > +
> > +    #get current value
> > +    my $sth = $dbh->prepare("SELECT * from systempreferences where variable = 'AllowSelfCheckReturns'");
> > +    $sth->execute;
> 
> Should be replaced with $dbh->selectcol_arrayref

this is done

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:21:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:21:23 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41397|0                           |1
        is obsolete|                            |

--- Comment #10 from Chris Cormack  ---
Created attachment 42268
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42268&action=edit
Bug 14649: Fix regression - display fund name on budget planning

A patch from bug 11714 removes 'budget_name_indent', which was useless.
The script and the template should use the budget_name value.

Note that this patch impacts the CSV export, which does not work, so it cannot
be
tested.

Test plan:
Edit a fund and click on one of the Planning value (by months, etc.)
The "Fund name" column should be correctly populated with the fund
names.

Signed-off-by: Fridolin Somers 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:21:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:21:39 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:21:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:21:42 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41703|0                           |1
        is obsolete|                            |

--- Comment #11 from Chris Cormack  ---
Created attachment 42269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42269&action=edit
Bug 14649: Followup - correct budget_period_id in fund name link

Now that fund name is displayed in the table as a link, you see that arg
budget_period_id is never defined in this link.

This is because the template var is [% budget_line.budget_period_id %] instead
of [% budget_period_id %].
This looks like a mistake when converting from tmpl to tt.

Test plan :
- Without patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> You see in URL that budget_period_id is empty :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=
- Apply patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> you see in URL that budget_period_id is defined like in planning page :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:27:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:27:18 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:27:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:27:55 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #27 from Mason James  ---
(In reply to Mason James from comment #20)
> (In reply to M. Tompsett from comment #13)
> > Comment on attachment 21221 [details] [review] [review]
> > Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref
> > 
> > Review of attachment 21221 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: installer/data/mysql/sysprefs.sql
> > @@ +419,5 @@
> > >  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> > >  ('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo')
> > >  ;
> > > +
> > > +installer/data/mysql/sysprefs.sql
> > 
> > I think this is a mistake.
> 
> yes, the addition of those two lines is a mistake

this mistake has been corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:32:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:32:31 +0000
Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Olli-Antti Kivilahti  ---
This was fixed by Bug 7817.

permanent_location was set when the Item was created, but it was lost when the
Item was under the influence of cart_to_shelf.pl-cronjob and manually edited,
before the cronjob updated the location to the original location. :)

Because we have a custom call number prefix mapping feature, we managed to
rebuild the correct locations based on the call number prefix,
eg:
Prefix => Branch, location
PKA => CPL, Bookshelf
PKL => CPL, Serials shelf
PKM => CPL, Musics shelf

Other cart_to_shelf.pl-users might not have been so lucky.
I think we have had over 3000 Items lose their shelving locations due to this
bug, but luckily all automatically corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:32:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:32:56 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #28 from Mason James  ---
(In reply to Katrin Fischer from comment #24)
> It looks to me like some changes need to be made to the patch for this to
> continue - especially comment#18 and some things from comment#20.

comments have been answered

i've left Mark's syntactic suggestions, as they are non-critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:33:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:33:20 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42264|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy  ---
Created attachment 42270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42270&action=edit
Bug 14651: (regression test) fallback to bib-level if itype is undef

Koha::Item->effective_itemtype should fallback to biblio-level itemtype
even if item-level item types are set, in the case the item has no itemtype
set (bad migration, bad old code).

To test:
- Run
  $ prove t/db_dependent/Items.t
=> FAIL: Koha::Item->effective_itemtype doesn't work properly

Edit: Added a test for a warning when falling back as per QA request
and because it made a lot of sense :-D

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:33:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:33:24 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42265|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy  ---
Created attachment 42271
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42271&action=edit
Bug 14651: Koha::Item->effective_itemtype fallback to bib-level

In some situations (bad migrations, old bugs that introduced bad data,
people having bib-level itypes for ages and switching to item level...)
the user ends with undex itype values for items.

The current code, if the user has item_level-itype set, just returns
undef. It should fallback to bib-level. In order to avoid hiding the problem
a warning is raised.

To test:
- Run the regression tets:
  $ prove t/db_dependent/Items.t
=> FAIL: tests fail.
- Apply the patch
- Run the tests again
=> SUCCESS: The tests now pass.
- Sign off :-D

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:34:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:34:27 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:36:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:36:31 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #29 from Mason James  ---
(In reply to Jonathan Druart from comment #17)
> Mason,
> 
> Could you please answer to Mark's comment please?
> 
> Marked as Failed QA.

..setting patch back to 'ready for QA' again, (hope thats OK)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:37:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:37:06 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #20 from Marcel de Rooy  ---
QA: Looking at this one now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:42:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:42:51 +0000
Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

--- Comment #23 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #21)
> This patch makes the tests non dependent on the DB and test the 3 marc
> flavours.
Thx for doing so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:43:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:43:24 +0000
Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart  ---
Joonas, could you provide a fix for this one please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:52:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:52:30 +0000
Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax
 for slips and notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12404

--- Comment #1 from Jonathan Druart  ---
Kyle,
This sounds like a big work.
How do you plan to implement that?
Did you have a look at bug 12404?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:52:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:52:30 +0000
Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations,
 substrings, conditions...)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14757

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:55:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:55:30 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42267|0                           |1
        is obsolete|                            |

--- Comment #30 from Mason James  ---
Created attachment 42272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42272&action=edit
Bug 10554: Add more options to 'AllowSelfCheckReturns' syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 09:56:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 07:56:56 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|fridolin.somers at biblibre.co |jonathan.druart at bugs.koha-c
                   |m                           |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:00:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:00:49 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:01:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:01:56 +0000
Subject: [Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:02:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:02:45 +0000
Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:03:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:03:28 +0000
Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:04:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:04:01 +0000
Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:04:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:04:31 +0000
Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to
 reflect Zebra indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:05:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:05:23 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:06:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:06:09 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:06:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:06:42 +0000
Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time
	into account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:11:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:11:25 +0000
Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item
	in batch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:11:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:11:45 +0000
Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item
	in batch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:13:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:13:14 +0000
Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:14:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:14:09 +0000
Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority
 and biblio frameworks
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:15:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:15:17 +0000
Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:15:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:15:41 +0000
Subject: [Koha-bugs] [Bug 14518] Deleting records with reservations (and no
 item) does not work
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:16:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:16:23 +0000
Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item)
	does not work
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deleting records with       |Deleting records with a
                   |reservations (and no item)  |hold (and no item) does not
                   |does not work               |work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:16:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:16:50 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:17:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:17:17 +0000
Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections
 doesn't work in some situations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:17:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:17:29 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Marcel de Rooy  ---
I first made a rule copy 245a to 300a. That added another 300a in the same 300
field.
Then I changed this rule to replace 245a to 300a. This did NOTHING!
I checked the record in the table: the action field is EMPTY.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:17:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:17:51 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Jonathan Druart  ---
I don't understand the changes at all and after a few test I understood why.
It does not work as expected.
For instance:
Current behavior:
1/ Staff side: Check item I out to patron P1
2/ Sco: Try to check the item out to patron P2
you will get "Item cannot be checked out." with a button "Return to account".

With your patch and the pref set to "all", you get 2 buttons:
"Return this item" and "Return to account"

Which does not make any sense.

Next time, please set the status back to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:18:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:18:02 +0000
Subject: [Koha-bugs] [Bug 14553] Warns when clearing a rating on an item on
	OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:18:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:18:34 +0000
Subject: [Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so
 they make more sense
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:18:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:18:51 +0000
Subject: [Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so
 they make more sense
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:19:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:19:25 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:20:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:20:07 +0000
Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:20:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:20:47 +0000
Subject: [Koha-bugs] [Bug 14551] Warns when sending a list via email on OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:22:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:22:13 +0000
Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample
	files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:22:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:22:54 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:23:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:23:40 +0000
Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC
	using HTTPS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:24:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:24:07 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
All other fields replace some chars (', ", \n, \r), I am sure you should do it
for these 3 ones too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:24:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:24:21 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:24:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:24:45 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:25:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:25:41 +0000
Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of
 tag 245 (MARC21 only)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:27:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:27:10 +0000
Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in
	C4/Reserves.pm
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:28:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:28:02 +0000
Subject: [Koha-bugs] [Bug 14388] add sorting to funds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:28:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:28:38 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:28:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:28:41 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42266|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42273
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42273&action=edit
Bug 14621 - Messaging preferences table needs to be sorted

I have been working with messaging preferences and I noticed a weird issue in
Firefox on Ubuntu.

On messaging preferences page, the table is unsorted and the content in rows
are generated randomly
on every page refresh. When you select/deselect checkboxes and refresh the page
(without posting the changes),
Firefox will remember your choices. Now the issue is that when the table is
unsorted and the rows keep
changing on page refresh, Firefox has trouble remembering your choices. This
makes it appear as if the
checkboxes are magically changing values on each page refresh.

Here is a patch that prevents this problem by sorting the messaging settings.

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:28:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:28:53 +0000
Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is
	ignored
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:28:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:28:53 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
Very useful patch, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:29:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:29:15 +0000
Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and
	clamissues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:30:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:30:20 +0000
Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with
 the CSV profile doesn't set the issue claimed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:34:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:34:15 +0000
Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:35:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:35:01 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #25 from Jonathan Druart  ---
Please resubmit the same patch but without the code cleaning:

-my $stickyduedate  = $query->param('stickyduedate') || 
+my $stickyduedate       = $query->param('stickyduedate') ||
$session->param('stickyduedate');

This make 1/ the patch hard to read and 2/ all the other patches in the queue
in conflict and won't apply anymore (13 at the moment).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:35:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:35:45 +0000
Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Zeno Tajoli  ---
The avaible patch doesn't modify code in opac-search.pl or opac-search.tt.
So in fact doesn't operate.
Probalby same line missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:37:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:37:17 +0000
Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:37:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:37:48 +0000
Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl
	results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:37:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:37:59 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37888|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:02 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37891|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:05 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39666|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:07 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40894|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:10 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42175|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:13 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42052|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:15 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37854|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:18 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37855|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:20 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37856|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:23 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37857|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:26 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37858|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:28 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37859|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:31 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37860|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:33 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37861|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:36 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37862|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:39 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37865|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:41 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37866|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:44 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37867|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:47 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37869|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:49 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37870|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:55 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37872|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:52 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37871|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:38:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:38:58 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37874|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:00 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37875|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:03 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37876|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:06 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37878|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:09 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37879|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:11 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37880|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:14 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37882|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:17 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37885|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:39:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:39:19 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37886|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:40:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:40:07 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Large patch                 |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:40:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:40:11 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #163 from Marcel de Rooy  ---
Created attachment 42274
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42274&action=edit
Bug 13813: Remove deprecated module C4::Dates from system

Test plan: See Bugzilla.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:40:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:40:27 +0000
Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does
 only work in English
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:40:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:40:56 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:43:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:43:26 +0000
Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch
 from institution_id field AO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:44:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:44:01 +0000
Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in
	barcodes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Zeno Tajoli  ---
I don't the patch for SIPConfig.xml.
So probabli there is ame problem with code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:44:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:44:04 +0000
Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #12 from Katrin Fischer  ---
Hm does it need to? It uses the "did you mean" plugin structure. did you test?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:44:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:44:18 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:44:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:44:51 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37810|0                           |1
        is obsolete|                            |

--- Comment #164 from Marcel de Rooy  ---
Comment on attachment 37810
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37810
temporary tests

I ran this test, but it failed.
Illegal date specified (year = 2014, month = 31, day = 01) at dates_compare.t
line 17
The 'month' parameter ("31") to DateTime::new did not pass the 'an integer
between 1 and 12' callback

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:44:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:44:52 +0000
Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant
 objects on an as needed basis
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:45:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:45:13 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:45:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:45:34 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:45:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:45:47 +0000
Subject: [Koha-bugs] [Bug 12017] Move language description out of database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:46:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:46:37 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #165 from Marcel de Rooy  ---
Second QA round:

circ/transferstoreceive.pl
-    show_date    => format_date(C4::Dates->today('iso')),
+    show_date    => output_pref({ dt => dt_from_string, dateonly => 1 }),
No iso? Probably I did not catch this one in the first round :)

circ/waitingreserves.pl
-    show_date   => format_date(C4::Dates->today('iso')),
+    show_date   => output_pref({ dt => dt_from_string, dateonly => 1 }),
Same.

members/printinvoice.pl
You did still include this line, as marked in the "first round".

FQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:46:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:46:45 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
 exempt borrower categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:47:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:47:22 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:48:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:48:14 +0000
Subject: [Koha-bugs] [Bug 13706] Deduping authorities script
	(dedup_authorities.pl)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:50:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:50:26 +0000
Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in
	barcodes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:50:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:50:53 +0000
Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in
	barcodes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482

--- Comment #3 from Zeno Tajoli  ---
(In reply to Zeno Tajoli from comment #2)
> I don't the patch for SIPConfig.xml.
> So probabli there is ame problem with code

Wring comment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:51:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:51:11 +0000
Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in
	barcodes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:52:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:52:03 +0000
Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:52:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:52:56 +0000
Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and
 GetAllPendingTransfers functions to ease testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:53:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:53:32 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:00 +0000
Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and
 overduerules_transport_types-tables.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:31 +0000
Subject: [Koha-bugs] [Bug 14153] Noisy warns in
	admin/transport-cost-matrix.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:40 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:43 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42256|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart  ---
Created attachment 42275
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42275&action=edit
Bug 14472 - Wrong ISSN search index in record matching rules

To Test
---------
 1) Apply the patch
 2) Export some MARC bibliographic records from Koha
 3) Import those same MARC bibliographic records using the
    "ISSN(022$a)" record matching rule.
 4) The incoming records should match perfectly
 5) Check the mysql tables (marc_matchers, matchpoints,
    matcher_matchpoints, matchpoint_components,
    matchpoint_component_norms) to make sure the values were
    inserted as expected.
For new Koha installation
 1) create the koha database
 2) Go to the staff client page, and do a "fresh" install making
    sure to select lots of optional marc 21 matching rules so
    the .../marc21/optional/marc21_default_matching_rules.sql
    gets triggered.
 3) Check the mysql tables (marc_matchers, matchpoints,
    matcher_matchpoints, matchpoint_components,
    matchpoint_component_norms) to make sure the values were
    inserted as expected.

Bug 14472 - Added Atomic Update to fix wrong issn search index

    - Fix comments

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:48 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

--- Comment #12 from Jonathan Druart  ---
Created attachment 42276
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42276&action=edit
Bug 14472: (follow-up) Wrong ISSN search index in record matching rules

Follow-up for
- it-IT unimarc
- ru-RU unimarc
- uk-UA unimarc

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:54:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:54:56 +0000
Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to
	SMS::Send drivers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:55:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:55:14 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:55:25 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaetan.boisson at biblibre.com

--- Comment #13 from Jonathan Druart  ---
Note that this file does not exist for fr-FR unimarc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:55:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:55:29 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:56:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:56:03 +0000
Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record
	details page.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:56:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:56:34 +0000
Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to
 be used without ExpireReservesMaxPickUpDelay
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:56:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:56:55 +0000
Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring
 tomorrow if ExpireReservesMaxPickUpDelay is set
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:57:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:57:36 +0000
Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to
 provide the userid
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:58:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:58:30 +0000
Subject: [Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends
 print mails even if it doesn't.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:58:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:58:58 +0000
Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:59:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:59:12 +0000
Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 10:59:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 08:59:43 +0000
Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to
 items being receipted, to be identified during the receipting process.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:00:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:00:09 +0000
Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds
	queue
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:00:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:00:35 +0000
Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up
 the related invoice to see when the item was receipted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:00:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:00:57 +0000
Subject: [Koha-bugs] [Bug 13935] Add API route to list borrower's
	accountlines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13935

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:03:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:03:04 +0000
Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes
 when importing borrowers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:03:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:03:34 +0000
Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the
 intranet, also try to search for it on the LDAP server if one is configured.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:04:23 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:04:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:04:49 +0000
Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for
 closed connections reliably
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:05:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:05:57 +0000
Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items
 and biblioitems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:06:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:06:08 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #22 from Marcel de Rooy  ---
did you execute the atomicupdate for bug 14098?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:06:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:06:35 +0000
Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export
 phase and use existing exported MARCXML.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:07:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:07:57 +0000
Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting
 the parent from detailed-view
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:08:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:08:17 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:08:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:08:40 +0000
Subject: [Koha-bugs] [Bug 12923] Improve error logging for
 advance_notices.pl;
 Show borrowernumber when no letter of type is found and force utf8 output.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:09:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:09:05 +0000
Subject: [Koha-bugs] [Bug 12902] Cronjob monitoring script,
	nagios3 compatible
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:09:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:09:46 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn't work with MARCXML
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:11:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:11:31 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #23 from Marcel de Rooy  ---
Back to SO.. Continue QA session

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:11:43 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:12:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:12:46 +0000
Subject: [Koha-bugs] [Bug 14775] New: Plack::Middleware::ReverseProxy should
 not be required
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

            Bug ID: 14775
           Summary: Plack::Middleware::ReverseProxy should not be required
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:13:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:13:27 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:13:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:13:30 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

--- Comment #1 from Jonathan Druart  ---
Created attachment 42277
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42277&action=edit
Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:13:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:13:52 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13791
                 CC|                            |tomascohen at gmail.com


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791
[Bug 13791] Plack - Out of the box support on packages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:13:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:13:52 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14775


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775
[Bug 14775] Plack::Middleware::ReverseProxy should not be required
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:14:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:14:04 +0000
Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:15:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:15:21 +0000
Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #13 from Zeno Tajoli  ---
I do a an error on reading the code.
I reset 'Needs Signoff'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:15:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:15:26 +0000
Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting
 the parent from detailed-view
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

--- Comment #2 from Jonathan Druart  ---
Blocked by 12625

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:15:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:15:37 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:15:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:15:41 +0000
Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting
 the parent from detailed-view
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625

--- Comment #3 from Jonathan Druart  ---
11175 :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:15:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:15:40 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42277|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy  ---
Created attachment 42278
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42278&action=edit
Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:20:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:20:51 +0000
Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:20:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:20:54 +0000
Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

--- Comment #1 from Mason James  ---
Created attachment 42279
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42279&action=edit
Bug 12120: Add --tempdir arg to rebuild_zebra.pl

Sometimes zebra indexing will fail when the filesystem of the /tmp dir is too
small for the indexing temp file
ie: a 20 gig temp file is needed, and /tmp is only 1 gig :(

in this situation, it is necessary to tell rebuild_zebra.pl to use a different
filesystem with the required space.

Test plan...
run 3 zebra indexing tests, with different args

1/ test an index, with no args
 $ sudo koha-shell -c '
/home/mason/git/koha/master/misc/migration_tools/rebuild_zebra.pl -b -v -z' 
koha1  |  grep 'export directory'
 the export directory /tmp/jp1d1RmCzL has been deleted.

2/ test an index, with a --tempdir arg
 $ sudo koha-shell -c '
/home/mason/git/koha/master/misc/migration_tools/rebuild_zebra.pl -b -v -z
--tempdir /tmp1/aa1'  koha1 |  grep 'export directory'
 the export directory /tmp1/aa1/FEOKJIzPcA has been deleted.

3/ test an index, with both --tempdir and -d (directory) args
 $ sudo koha-shell -c '
/home/mason/git/koha/master/misc/migration_tools/rebuild_zebra.pl -b -v -z
--tempdir /tmp1/aa1 -d  bb1' koha1 | grep 'export directory'
 the export directory /tmp1/aa1/bb1 has been deleted.

Note that the 'export directory' path is as expected, for each test run

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:23:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:23:06 +0000
Subject: [Koha-bugs] [Bug 14722] Refactor the export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41889|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack  ---
Created attachment 42280
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42280&action=edit
Bug 14722: Add Koha::Biblioitem[s]

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:23:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:23:27 +0000
Subject: [Koha-bugs] [Bug 14722] Refactor the export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:23:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:23:30 +0000
Subject: [Koha-bugs] [Bug 14722] Refactor the export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41890|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack  ---
Created attachment 42281
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42281&action=edit
Bug 14722: Refactor the export tool

Why a refactoring was need for this script?
The export tool (tools/export.pl) can be called from the command line
and some parts of code were unnecessarity complicated (just look at the
code, you will understand).

Worse still, the script does not provide the same options for both
interface. For instance you cannot export records given a range of
biblionumbers, authids, callnumbers, etc. from the commandline.

What does this patch?
1/ Important: The script tools/export.pl does not work anymore if called from
the command line (should be in the release notes).
2/ The code used to generated a file (csv, iso2709 or xml) has been moved to a
new
module (Koha::Exporter::Record) and tests have been provided.
3/ No change is done on the web interface
4/ Some new options have been added to the commandline script
(misc/export.pl):
    - starting_authid
    - ending_authid
    - authtype
    - starting_biblionumber
    - ending_biblionumber
    - itemtype
    - starting_callnumber
    - ending_callnumber
    - start_accession
    - end_accession
5/ There is a change in the behavior if an error occurs:
Can't call method "as_usmarc" on an undefined value at Koha/Exporter/Record.pm
line 114.
record (number 5530) is invalid and therefore not exported because its
reopening generates warnings above at Koha/Exporter/Record.pm line 117.

Before this patch, they were not displayed (using the command line).

What does not do this patch?
It does not provide the 'clean', 'timestamp' and 'deleted_barcodes' options to
the web interface (same as before).

What about the perfs?
With a DB with ~800 biblios (MARC21)
Before: perl tools/export.pl 14.79s user 0.83s system 71% cpu 21.905 total
After:  perl misc/export.pl  17.19s user 0.84s system 75% cpu 24.018 total

With a DB with ~6400 biblios (UNIMARC)
Before: perl tools/export.pl 26.55s user 0.76s system 76% cpu 35.498 total
After:  perl misc/export.pl  26.78s user 0.84s system 80% cpu 34.494 total

How to test this patch?
Test plan:
A. Web interface:
1/ On the current master, export some records, biblios and authorities (with
the 3 differents exports) playing with the different filters (item type,
libraries, callnumber, accession date, don't export items, remove
non-local items, don't export fields, etc.).
2/ Apply this patch, export again the same records, and compare the
generated files. They must be identical!
3/ Confirm that the export features on the checkout list
(circ/circulation.pl) works as before this patch.

B. The command line
1/ On the current master, export some records, biblios and authorities (with
the 2 differents exports) playing with the different options (date,
deleted_barcodes, clean).
2/ Apply this patch, export again the same records, and compare the
generated files. They must be identical!

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:23:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:23:37 +0000
Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:24:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:24:45 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #14 from Jonathan Druart  ---
(In reply to Galen Charlton from comment #5)
> Comment on attachment 24754 [details] [review]
> Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> 
> Review of attachment 24754 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: opac/opac-account-pay-paypal-return.pl
> @@ +20,5 @@
> > +
> > +use strict;
> > +use warnings;
> > +use utf8;
> > +

> Modern::Perl
> I see no non-ASCII characters in the source.

Still exists.

> ::: opac/opac-account-pay.pl
> @@ +19,5 @@
> > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > +
> > +use strict;
> > +use warnings;
> > +use utf8;

> Modern::Perl
> I see no non-ASCII characters in the source.

Still exists.

> @@ +94,5 @@
> > +        'PAYMENTREQUEST_0_PAYMENTACTION'        => 'Sale',
> > +        'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly',
> > +        'PAYMENTREQUEST_0_DESC' =>
> > +          C4::Context->preference('PayPalChargeDescription'),
> > +    };
> 
> It seems like using Business::PayPal::API might offer some protection
> against API changes.

Answer needed.


+use CGI;

Should be replaced by CGI qw( -utf8 ) unless you have a good reason.


> 3) Create a paypal developer account

How? Should I need a paypal account to do so?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:25:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:25:12 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:35:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:35:04 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #24 from Marcel de Rooy  ---
Created attachment 42282
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42282&action=edit
Bug 14098: FIX Copy a subfield should not update the original field

There is an inconsistency in the copy action:

Given the following control sample:

  245    _aThe art of computer programming
         _cDonald E. Knuth.
  300    _aA_exists
         _bB_exists

If we apply action (a) Copy the whole field 245 to 300, we get:

  245    _aThe art of computer programming
         _cDonald E. Knuth.
  300    _aA_exists
         _bB_exists
  300    _aThe art of computer programming
         _cDonald E. Knuth.

If we apply action (b) Copy the subfield 245$a to 300$a, we get:

  245    _aThe art of computer programming
         _cDonald E. Knuth.
  300    _aThe art of computer programming
         _bB_exists

In (a) the field is copied but in (b) the subfield is erased.

We should be consistent and don't erase the destination field.

Signed-off-by: Kyle M Hall 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:35:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:35:09 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #25 from Marcel de Rooy  ---
Created attachment 42283
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42283&action=edit
Bug 14098: Remove unedeed subroutines

Just some cleaning before to continue, _copy_field and _copy_subfield did not
do anything useful.

Signed-off-by: Kyle M Hall 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:35:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:35:13 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #26 from Marcel de Rooy  ---
Created attachment 42284
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42284&action=edit
Bug 14098: Add copy_and_replace action to MMT

This patch add the new value for the MTT action.
It updates the marc_modification_template_actions.action DB field to
allow 'copy_and_replace_field'.

Signed-off-by: Kyle M Hall 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:35:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:35:18 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #27 from Marcel de Rooy  ---
Created attachment 42285
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42285&action=edit
Bug 14098: Implement the copy_and_replace action for MTT

This patch implements the copy and replace action for the marc
modification templates.
Instead of copying a field/subfield, it will erase the destination
fields/subfields.

Test plan:
Find it yourself.
Compare the differences between the copy and the copy_and_replace
actions.
The easier way to test is to 1/ create a complete record, 2/create some
modification templates and 3/ use the batch record modification with the
"preview" function.

QA note: I kept the same tests as "copy" and, if no change were
expected, I noted them "(same as copy)", to be sure this new action won't
introduce regression on these tests.

Signed-off-by: Kyle M Hall 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:35:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:35:58 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:36:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:36:00 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39610|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:36:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:36:02 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39611|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:36:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:36:04 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39612|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:36:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:36:06 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39613|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:40:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:40:50 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #28 from Marcel de Rooy  ---
QA Comment:
Code looks good to me. Pass qa test.
Tried several combinations in web interface. The copy/replace whole field
erases destination subfields which are not in the source. This is expected
behavior, but should be noted somewhere in help text perhaps.
Impressive test coverage.
Only question: Does the name SimpleMarc still cover these growing files? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:42:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:42:43 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #19 from Mason James  ---
(In reply to Kyle M Hall from comment #11)
> I see. I hadn't looked deeply enough to realize 1 was the card number. In
> that case my solution won't work.
> 
> (In reply to Katrin Fischer from comment #10)
> > ... and 1 being the cardnumber.

just to confirm, (1) appears to be random string from within the Overdrive app
..it's not related to any 'id' within Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:43:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:43:29 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #72 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #71)
> (In reply to Marcel de Rooy from comment #63)
> > If you submit what you applied here, we probably tackled it..
> 
> Hope this helps. I left the status as is, since you were the one to change
> it last.

Yes it does. Applies like a train now. (Converted expression..)
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:47:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:47:35 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #5 from Jonathan Druart  ---
Jesse,
I cannot test this patch, I don't have a B&T account.
But looking at the code I am wondering if there is not another occurrence to
update:

opac-user.tt l.414
    See Baker & Taylor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:50:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:50:01 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #8 from Jonathan Druart  ---
Comment 6 needs an answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:53:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:53:41 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #166 from Marc V?ron  ---
Created attachment 42286
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42286&action=edit
[Follow-up] Bug 13813 - Remove deprecated module C4::Dates from system

Changes for QA comment #165

circ/transferstoreceive.pl
'iso' added

circ/waitingreserves.pl
'iso' added

members/printinvoice.pl
'iso' removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 11:55:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 09:55:50 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:02:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:02:23 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #23 from Jonathan Druart  ---
Tom?s, you have marked this bug as a duplicate of bug 9351 but you don't take
care of the CanBookBeIssued subroutine.
Do you plan to update it as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:04:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:04:07 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #73 from Marcel de Rooy  ---
ok 5 - GetItemsInfo tests
    1..2
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339.
DBIx::Class::ResultSet::create(): DBD::mysql::db begin_work failed: Already in
a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. at
t/db_dependent/Items.t line 222
    # Child (Test Koha::Database->schema()->resultset('Item')->itemtype())
exited without calling finalize()
not ok 6 - Test Koha::Database->schema()->resultset('Item')->itemtype()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:08:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:08:59 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart  ---
CONFLICT (content): Merge conflict in t/db_dependent/Accounts.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:21:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:21:03 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40012|0                           |1
        is obsolete|                            |

--- Comment #50 from Alex Arnaud  ---
Created attachment 42287
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42287&action=edit
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions

Suggestion form uses C4::Koha::GetSupportList to get a list of supports that
can come from itemtypes or authoritized values LOC or CCODE.
C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one
value. But this syspref can contain several values separated by a pipe.

This patch introduces a new syspref SupportsAuthorizedValues to select wich
authorized values category that represents the physical support (itemtypes by
default, loc or ccode). These authorized values will be used in suggestion
management, known as 'document type'.
(Note that database field is still 'itemtype').

Test plan :
-----------
- Set SupportsAuthorizedValues with itemtypes or loc or ccode
- Get to suggestion form (OPAC or intranet)
- Look at "Document type" combobox, it must contains descriptions of selected
authorized values
- Save the suggestion
- Get to intranet suggestions management
- Organize suggestions by document type
=> your suggestion must appear in a tab with its document type description

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:21:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:21:09 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40013|0                           |1
        is obsolete|                            |

--- Comment #51 from Alex Arnaud  ---
Created attachment 42288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42288&action=edit
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:21:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:21:20 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40014|0                           |1
        is obsolete|                            |

--- Comment #52 from Alex Arnaud  ---
Created attachment 42289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42289&action=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

Signed-off-by: Olli-Antti Kivilahti 

  Tested the TEST PLAN. With ccode, itype, none, loc.
  On both OPAC and SC.
  Making a code review, but it is hard during the hackfest.
  Morbid lack of any kind of unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:21:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:21:25 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40015|0                           |1
        is obsolete|                            |

--- Comment #53 from Alex Arnaud  ---
Created attachment 42290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42290&action=edit
Bug 9223 [Follow-up] change the way syspref SuggestionsUseValues is added: Use
the new worflow (atomic update)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:21:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:21:32 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40016|0                           |1
        is obsolete|                            |

--- Comment #54 from Alex Arnaud  ---
Created attachment 42291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42291&action=edit
Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName
subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:23:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:23:21 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #55 from Alex Arnaud  ---
Patch rebased again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:24:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:24:14 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:31:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:31:17 +0000
Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions
	on indexes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart  ---
I haven't tested yet, but looking at the code I am wondering if there is not a
way to add a flag 'index_it!' instead of c/p the 2 foreach marc::subfield
loops?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:35:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:35:38 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #23 from Jonathan Druart  ---
(In reply to Kyle M Hall from comment #18)
> Thanks, I understand what you were asking now.
> > > t/db_dependent/BiblioObject.t
> > 
> > I would prefer a better filename, but nothing in mind to suggest.
> 
> I feel the same way, but have nothing better to suggest either.
> 
> > > +my $field_mappings = Koha::Database->new()->schema()->resultset('Fieldmapping');
> > 
> > Could be better to have a Koha::Fieldmapping[s]
> 
> I can do this if you'd like. It was just a quick way to create a field
> mapping, so I went with dbic directly. Just let me know if you want me to go
> ahead an add a followup to add and use Koha::Fieldmapping[s]

As you like.

> > > -    waiting_count      => $wcount,
> > 
> > This variable is still used in the template.
> > 
> > > +    WAITING        => $reserves->waiting()
> > 
> > Why not remove this one and access to the waiting holds using
> > RESERVES.waiting in the template?
> 
> I'm working on these ones right now.

So setting the status accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:37:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:37:06 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:40:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:40:13 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:40:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:40:17 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42274|0                           |1
        is obsolete|                            |

--- Comment #167 from Marcel de Rooy  ---
Created attachment 42292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42292&action=edit
Bug 13813: Remove deprecated module C4::Dates from system

Test plan: See Bugzilla.

Signed-off-by: Jonathan Druart 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:40:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:40:31 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42286|0                           |1
        is obsolete|                            |

--- Comment #168 from Marcel de Rooy  ---
Created attachment 42293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42293&action=edit
Bug 13813 - Remove deprecated module C4::Dates from system

Changes for QA comment #165

circ/transferstoreceive.pl
'iso' added

circ/waitingreserves.pl
'iso' added

members/printinvoice.pl
'iso' removed

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:40:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:40:36 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #169 from Marcel de Rooy  ---
Created attachment 42294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42294&action=edit
Bug 13813: [QA Follow-up] Fix some tabs for qa tools

FAIL   C4/Barcodes/annual.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 86)
                forbidden pattern: tab char (line 51)

FAIL   C4/Barcodes/hbyymmincr.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 108)
                forbidden pattern: tab char (line 78)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:40:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:40:55 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #170 from Marcel de Rooy  ---
Looks good to me now.
Did a full code review twice: found some small issues in both rounds.
Tested only some locations in the interface with all three settings of
dateformat.
Added a follow-up to satisfy qa tools (trivial tabs).
This kind of change needs some broader exposure by an early push.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:41:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:41:42 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #24 from Tom?s Cohen Arazi  ---
(In reply to Jonathan Druart from comment #23)
> Tom?s, you have marked this bug as a duplicate of bug 9351 but you don't
> take care of the CanBookBeIssued subroutine.
> Do you plan to update it as well?

It is GBSD, I will probably fill a new bug and take care of that too, yeah. ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:45:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:45:06 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart  ---
Ok, so just one thing prevents to pass QA I think.
The default value for schema should be C4::Context->preference('marcflavour').
And all calls where the pref is passed can be removed.
Don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:45:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:45:21 +0000
Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:48:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:48:55 +0000
Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions
	on indexes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217

--- Comment #10 from Tom?s Cohen Arazi  ---
(In reply to Jonathan Druart from comment #9)
> I haven't tested yet, but looking at the code I am wondering if there is not
> a way to add a flag 'index_it!' instead of c/p the 2 foreach marc::subfield
> loops?

Maybe elaborate a bit more? Remember the current syntax lets you choose what
subfields to include for indexing, so you need to loop.
Anyway, I just hooked the extra 'condition' attribute and then test for it to
skip if condition is not met.

If you propose a major XSLT refactoring it should probably belong to it's own
bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:49:24 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14651                       |

--- Comment #25 from Jonathan Druart  ---
It does not look to depend on bug 14651


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651
[Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if
no item-level itemtype
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:49:24 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14598                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 12:55:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 10:55:21 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #26 from Jonathan Druart  ---
The thing is that the update queries can take ages on a big DB, and we will
have to loop again if everything is not fixed at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:01:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:01:35 +0000
Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions
	on indexes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217

--- Comment #11 from Jonathan Druart  ---
If I am not wrong, the algorithm is:

if conditions exist:
  if the condition is satisfied:
    do a big loop on subfield
else:
  do the same big loop on subfield

You have c/p the "big loop"

I suggest to change with something like

need_to_loop = 1
if conditions exist:
  need_to_loop = 0
  if the condition is satisfied:
    need_to_loop = 1

if need_to_loop:
  do the same big loop on subfield

Just to avoid the code duplication.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:11:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:11:03 +0000
Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #86 from Jonathan Druart  ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
CONFLICT (content): Merge conflict in Koha/Template/Plugin/Koha.pm


(In reply to Jonathan Druart from comment #81)
> 2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts
> moved somewhere else

Still needs an answer.
Are not you afraid that this plugin become a holdall?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:28:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:28:09 +0000
Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from
	staff intranet
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #41 from Jonathan Druart  ---
There is something wrong in the second patch:

installer/data/mysql/updatedatabase.pl             | 1157 +-------------------

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:29:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:29:55 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Who signed the|                            |Jonathan Druart
          patch off|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:48:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:48:15 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #14 from Koha Team Lyon 3  ---
Tested in cataloguing (edit and new record/item) and also in batch
modification.
I had a filter where I can type a part of the authorized value : it works as
expected. I can also use the dropdown to select a value and this one is
highlighted when I'm on it.
When choosing a value in the list, I can see the full description but after
have chose, long descriptions are cut (We can have full description when
passing mouse over).

When using keybord, I have to use enter to select a value.

For what I see, this feature works only in cataloguing (I haven't understand at
the beginning because I didn't see it in the description). It would be
wonderful if we can also have it in acquisitions or patrons)

For me, it works functionnaly so I will sign it off but I can't answer to
Owen's questions about regresion.
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:49:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:49:54 +0000
Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be
 called once in authorities merge
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762

--- Comment #2 from Marcel de Rooy  ---
Testing this one..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 13:54:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 11:54:18 +0000
Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be
 called once in authorities merge
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Marcel de Rooy  ---
Merged two authority records (A and B; B removed).
Had a biblio with 100 linked to auth A and 700 to auth B.
After merge and reindex still auth B in the biblio record.
(dontmerge=Do)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:03:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:03:01 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #1 from Lari Taskula  ---
Created attachment 42295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42295&action=edit
Bug 12426: Allow resending of messages from the notices tab in the patron
account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=XXXXX" where XXXXX is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::_set_message_status() to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:03:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:03:40 +0000
Subject: [Koha-bugs] [Bug 10598] self check shouldn't link out to catalog
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
          Component|Templates                   |Self checkout
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:04:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:04:59 +0000
Subject: [Koha-bugs] [Bug 10598] self check shouldn't link out to catalog
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598

--- Comment #1 from Mason James  ---
switching bug component to SCO/selfcheck

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:05:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:05:10 +0000
Subject: [Koha-bugs] [Bug 14054] 246 XSLT Improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |wsalesky at gmail.com
                 CC|                            |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:05:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:05:48 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #225 from Julian Maurice  ---
Created attachment 42296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42296&action=edit
Bug 10855: Remove additional field values when subscription is removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:06:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:06:06 +0000
Subject: [Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix
 for Contributors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |wsalesky at gmail.com
   Patch complexity|---                         |Small patch
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:06:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:06:52 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:07:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:07:53 +0000
Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |ASSIGNED

--- Comment #8 from Marcel de Rooy  ---
Still no attachments
Back to Assigned

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:11:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:11:56 +0000
Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA

--- Comment #5 from Marcel de Rooy  ---
Looks good to me. Just some minor textual changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:12:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:12:14 +0000
Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585

--- Comment #6 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Letting the QA step to a English native speaker.

:-) Saw that later..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:13:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:13:33 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38549|0                           |1
        is obsolete|                            |

--- Comment #226 from Julian Maurice  ---
Created attachment 42297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42297&action=edit
Bug 10855: Add the new package Koha::AdditionalField

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:13:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:13:51 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38550|0                           |1
        is obsolete|                            |

--- Comment #227 from Julian Maurice  ---
Created attachment 42298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42298&action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:14:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:14:05 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38551|0                           |1
        is obsolete|                            |

--- Comment #228 from Julian Maurice  ---
Created attachment 42299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42299&action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:14:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:14:19 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38552|0                           |1
        is obsolete|                            |

--- Comment #229 from Julian Maurice  ---
Created attachment 42300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42300&action=edit
Bug 10855: New fields on adding/updating a subscription

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:14:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:14:34 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38553|0                           |1
        is obsolete|                            |

--- Comment #230 from Julian Maurice  ---
Created attachment 42301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42301&action=edit
Bug 10855: Search subscriptions by additional fields

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:14:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:14:47 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38554|0                           |1
        is obsolete|                            |

--- Comment #231 from Julian Maurice  ---
Created attachment 42302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42302&action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:15:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:15:05 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38555|0                           |1
        is obsolete|                            |

--- Comment #232 from Julian Maurice  ---
Created attachment 42303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42303&action=edit
Bug 10855: Squash several fixes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:15:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:15:18 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38556|0                           |1
        is obsolete|                            |

--- Comment #233 from Julian Maurice  ---
Created attachment 42304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42304&action=edit
Bug 10855: Fix QA issues

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:15:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:15:29 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38557|0                           |1
        is obsolete|                            |

--- Comment #234 from Julian Maurice  ---
Created attachment 42305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42305&action=edit
Bug 10855: search with exact match if linked to an AV

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:15:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:15:42 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38558|0                           |1
        is obsolete|                            |

--- Comment #235 from Julian Maurice  ---
Created attachment 42306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42306&action=edit
Bug 10855: Additional marc fields are not inserted

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:15:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:15:57 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38559|0                           |1
        is obsolete|                            |

--- Comment #236 from Julian Maurice  ---
Created attachment 42307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42307&action=edit
Bug 10855: Make tests to pass

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:16:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:16:10 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38560|0                           |1
        is obsolete|                            |

--- Comment #237 from Julian Maurice  ---
Created attachment 42308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42308&action=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:16:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:16:22 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38561|0                           |1
        is obsolete|                            |

--- Comment #238 from Julian Maurice  ---
Created attachment 42309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42309&action=edit
Bug 10855: Update database entry

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:16:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:16:35 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42296|0                           |1
        is obsolete|                            |

--- Comment #239 from Julian Maurice  ---
Created attachment 42310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42310&action=edit
Bug 10855: Remove additional field values when subscription is removed

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:21:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:21:15 +0000
Subject: [Koha-bugs] [Bug 14776] New: SCO/shelfcheck 'log out' option
 redirects to OPAC, not back to SCO
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

            Bug ID: 14776
           Summary: SCO/shelfcheck 'log out' option redirects to OPAC, not
                    back to SCO
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Self checkout
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 42311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42311&action=edit
pic

SCO 'log out' option redirects to OPAC, not back to SCO

pic attached

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:21:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:21:43 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:21:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:21:46 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41386|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy  ---
Created attachment 42312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42312&action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema => 'marc21'
  format => 'MARC'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
->new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply this test patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
=> FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

Edit: made serialization format be upper-case to match what is used on
Koha::Filter's

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:21:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:21:50 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41387|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy  ---
Created attachment 42313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42313&action=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

The description of this changes is on the regression tests commit
message.

To test:
- Apply the test patch
- Run
  $ prove t/Koha_MetadataRecord.t
=> FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
=> SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
=> SUCCESS: it still passes
- Sign off :-D

NOTE: Tested as above. Read code. Seems to cover all cases.

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:22:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:22:06 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Small patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:29:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:29:26 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

--- Comment #1 from Mason James  ---
3 urls redirect to the OPAC, in...
  koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc

thus, it is possible for a user to accidentally 'log out' of the SCO
completely,  requiring staff to fix the SCO

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:29:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:29:42 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10598

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:29:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:29:42 +0000
Subject: [Koha-bugs] [Bug 10598] self check shouldn't link out to catalog
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14776

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:39:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:39:21 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #14 from Jonathan Druart  ---
Marcel, I have let a comment 11, please don't ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:39:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:39:24 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #13 from Marcel de Rooy  ---
member-password and member-entry are not consistent: member-password does not
allow trailing space, but member-entry does ...

member-entry:
1234 becomes
$2a$08$se1EC5tmOPHRh2NKoHlVVu4UWzq.SBTh1zY/qjQ94qzZPOd20HcW2
1234 becomes $2a$08$0nW80AYBaRFf5MEVoesp0uzMAGYlTZiZDlpTl4bjQNx7bhIGGS6FW

FQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:39:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:39:38 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #27 from Tom?s Cohen Arazi  ---
(In reply to Jonathan Druart from comment #25)
> It does not look to depend on bug 14651

That's your fault; it originally depended on it :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:40:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:40:26 +0000
Subject: [Koha-bugs] [Bug 9601] ccsr opac no results found ugly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9601

ktmsulaim  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktmsulaim at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:41:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:41:16 +0000
Subject: [Koha-bugs] [Bug 14777] New: OPAC shows no result found
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14777

            Bug ID: 14777
           Summary: OPAC shows no result found
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ktmsulaim at gmail.com
        QA Contact: testopia at bugs.koha-community.org

OPAC shows  No results found!

You did not specify any search criteria.

Error:
Could not find opac-search.xml in /usr/share/koha/opac/cgi-bin/opac/ at
/usr/share/koha/lib/C4/Search.pm line 857

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:44:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:44:19 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:44:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:44:45 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Gaetan Boisson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42024|0                           |1
        is obsolete|                            |

--- Comment #83 from Gaetan Boisson  ---
Created attachment 42314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42314&action=edit
[SIGNED-OFF] Bug 12252: (follow-up) Fix error raised on comment 69
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252#c69

Signed-off-by: Gaetan Boisson 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:46:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:46:44 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Gaetan Boisson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #84 from Gaetan Boisson  ---
Checked all the OAI verbs presented on this page : http://re.cs.uct.ac.za/
everything went smoothly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:47:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:47:06 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #11 from Marc V?ron  ---
Wanted to test but patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 14:52:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 12:52:33 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

--- Comment #19 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #18)
> Patches look ok to me on first glance, thx Indranil!

They have a double signoff. What's holding you back?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:01:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:01:02 +0000
Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test,
	when using koha-shell
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:01:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:01:05 +0000
Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test,
	when using koha-shell
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41303|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy  ---
Created attachment 42315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42315&action=edit
Bug 14602 - Fix failing t/Creators.t test

to test..

1/ run t/Creators.t test from git repo, get a FAIL

2/ apply patch

3/ repeat step 1, get a PASS

mason at xen1:~/g/k/3.16.x$ sudo  koha-shell -c 'export
PERL5LIB=/home/mason/g/k/3.16.x ; cd /home/mason/g/k/3.16.x ;  prove -v 
t/Creators.t' k316x1
t/Creators.t ..
1..16
ok 1 - use C4::Creators;
ok 2 - use C4::Creators::PDF;
ok 3 - testing new() works
ok 4 - testing pdf file created
ok 5 - testing Add() works
ok 6 - testing Bookmark() works
ok 7 - testing Compress() works
ok 8 - testing Font() works
ok 9 - testing FontSize() is set to 12 by default
ok 10 - testing FontSize() can be set to a different value
ok 11 - testing Page() works
ok 12 - testing StrWidth() returns correct point width
ok 13 - testing Text() writes from a given x-value
ok 14 - testing Text() writes to the correct x-value
ok 15 - testing End() works
ok 16 - test file /tmp/4YjPQDExeS created OK
ok
All tests successful.
Files=1, Tests=16,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.48 cusr  0.05
csys =  0.57 CPU)
Result: PASS

Signed-off-by: Liz Rea 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:01:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:01:17 +0000
Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test,
	when using koha-shell
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:01:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:01:43 +0000
Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test,
	when using koha-shell
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

--- Comment #11 from Marcel de Rooy  ---
(In reply to Mason James from comment #9)
> (In reply to Liz Rea from comment #8)
> > I think this is different, I get this issue in my vagrant and/or gitify
> > installs as well. Something to do with the fact that it can't write a temp
> > file, but I didn't have time to try and fix it.
> 
> yep, thats all correct ^ :)

It wrote in the current directory..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:09:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:09:06 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:09:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:09:34 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:11:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:11:21 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Patch doesn't apply

--- Comment #21 from Marcel de Rooy  ---
 Merge conflict in t/db_dependent/Circulation_Branch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:12:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:12:56 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #24 from Kyle M Hall  ---
Excellent! Thanks for looking into that Jonathan. I'll pull that code out and
get everything fixed up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:19:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:19:37 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #15 from Tom?s Cohen Arazi  ---
Created attachment 42316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42316&action=edit
Bug 14639: (QA followup) make schema mandatory

This patch makes the 'schema' param mandatory. It is passed in every
call on the current codebase, so it makes no harm now, but makes
the code less error-prone.

Tests for this situation are added to t/Koha_MetadataRecord.t (schema
param is omitted and new() returns undef and a carped warning).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:21 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:24 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39574|0                           |1
        is obsolete|                            |
  Attachment #39575|0                           |1
        is obsolete|                            |
  Attachment #39576|0                           |1
        is obsolete|                            |
  Attachment #39577|0                           |1
        is obsolete|                            |
  Attachment #39578|0                           |1
        is obsolete|                            |
  Attachment #39579|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart  ---
Created attachment 42317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42317&action=edit
Bug 14045: Add specific quotas to on-site checkouts

This patch set adds the ability to defined independent quotas for on-site
checkouts.
This will be done using the circulation rules matrix where a new column
?Current on-site checkouts allow? will be added.

This feature is going to use the same method as the existing fields maxissueqty
("Current checkouts allowed"), the new fields will be added to the
different tables (see the "DB changes" patch) and will be named
maxonsiteissueqty (for consistency).

In order to keep the existing behavior and to let more flexibility,
a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts).
This syspref will let the liberty to the library to decide if an on-site
checkout should be considered as a "normal" checkout or not.

To keep the existing behavior, the syspref will be disabled (i.e. an on-site
checkout is considered as a normal checkout) and the number of on-site
checkouts will be the same as the number of checkout (maxissueqty ==
maxonsiteissueqty).

Technically:
There are only very few tests for the Circulation module, and the 2
subroutines impacted by this patch set were not tested at all.
It is necessary to introduce non-regression tests for this area.
The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule
and C4::Circulation::TooMany (only called by
C4::Circulation::CanBookBeIssued, so we will take the liberty to change
the prototype to raise a better warning to the end user).

Test plan:
I. Confirm there is no regression and the existing behavior is kept
 0/ Let the syspref disabled
 1/ Set a rule to limit to 2 the number of checkouts allowed
 2/ Do a normal checkout
 3/ Do an on-site checkout
 4/ Try to checkout (on-site or normal) an item again.
 You should not be allowed.

II. Test the new feature - pref disabled
 0/ Let the syspref disabled
 1/ Set a rule to limit to 2 the number of checkouts allowed and to 1
 the number of on-site checkouts allowed.
 2/ Do an on-site checkout
 3/ Try to do another one, you should not be allowed to do it.
 4/ A normal checkout should pass successfully
Note that it does not make sense to have the number of on-site checkouts
alowed > number of checkouts allowed.

III. Test the new feature - pref enabled
 0/ Enable the syspref
Now an on-site checkout is *not* counted as a normal checkout.
This means you can have the number of on-site checkouts > number of
checkouts allowed.
 1/ Set the values you want for the 2 types of checkouts (normal vs
on-site).
 2/ Even if a patron has reached the maximum of checkouts allowed, he
 will be allowed to do a on-site checkout (vice versa).

IV. Stress the developper
 Using the different configurations available in the circulation matrix,
 try to find one where the checkout is allowed and not should be.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:35 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #23 from Jonathan Druart  ---
Created attachment 42318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42318&action=edit
Bug 14045: Change prototype of TooMany to raise a better warning

With this patch, the user will know why the checkout is refused.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:39 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #24 from Jonathan Druart  ---
Created attachment 42319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42319&action=edit
Bug 14045: Introduce the maxonsiteissueqty field as a copy of maxissueqty

This patch adds the new fields maxonsiteissueqty as a copy of the
existing maxissueqty field.

There is no brainy code here, it only adds the ability to fill the new
field from the admin interface (admin/smart-rules.pl).

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:42 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #25 from Jonathan Druart  ---
Created attachment 42320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42320&action=edit
Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty

GetBranchBorrowerCircRule should return the value for maxissueqty and
maxonsiteissueqty. It's what this patch does.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:49 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #26 from Jonathan Druart  ---
Created attachment 42321
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42321&action=edit
Bug 14045: DB Changes

This patch is the DB changes for the feature.
It adds 5 new columns named 'maxonsiteissueqty' to the following tables:
- branch_borrower_circ_rules
- default_borrower_circ_rules
- default_branch_circ_rules
- default_circ_rules
- issuingrules

It also adds the pref ConsiderOnSiteCheckoutsAsNormalCheckouts.

See main patch for more details.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:24:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:24:52 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #27 from Jonathan Druart  ---
Created attachment 42322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42322&action=edit
Bug 14045: DBIC Changes

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:27:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:27:48 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #14 from Jonathan Druart  ---
Marcel, you should get the JS alert preventing the form to be submitted.
Are you sure you have correctly refreshed the cache?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:35:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:35:57 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to be visible
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #3 from Marc V?ron  ---
Hi Jesse,

I tested this first patch because I'm looking forward for this enhancement.

After applying I can no longer create new attributes. 
This is what I get in intranet-error.log after I hit "Save":

[Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep  3 15:24:22
2015] patron-attr-types.pl: DBD::mysql::st bind_param failed: Illegal parameter
number at /usr/share/kohaclone/C4/Members/AttributeTypes.pm line 243., referer:
http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
[Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep  3 15:24:22
2015] patron-attr-types.pl: DBD::mysql::st execute failed: Column count doesn't
match value count at row 1 at /usr/share/kohaclone/C4/Members/AttributeTypes.pm
line 244., referer:
http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
[Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep  3 15:24:22
2015] patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
line 336., referer:
http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
[Thu Sep 03 15:24:22 2015] [error] [client 10.0.0.85] [Thu Sep  3 15:24:22
2015] patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
line 336., referer:
http://10.0.0.31:8080/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type

However, I can set and save the value "Display in OPAC" on existing entries
(and I see them in the table borrower_attribute_types).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:36:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:36:46 +0000
Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:39:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:39:44 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #64 from Genevieve  ---
Created attachment 42323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42323&action=edit
Bug 10937 - Fix Seach Type in Advanced Search

In order to see the checkboxes of the Collection and Shelving location of the
advanced search, the if changed so that only the Itemtypes will go through the
previous if

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 15:51:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 13:51:02 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

jmbroust  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr
             Status|Needs Signoff               |Failed QA

--- Comment #23 from jmbroust  ---
Everything seems ok except the csv file where some columns don't have the right
datas : 
column "basket by" contains the name of the basket
column "biblionumber" contains librarian id
column title contains biblionumber
currency contains Title
Vendor price contains Currency
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:07:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:07:09 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:07:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:07:12 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #15 from Marcel de Rooy  ---
Created attachment 42324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42324&action=edit
Bug 14509: Reject invalid passwords

Bug 10177 rejects password with leading or trailing whitespaces, but
only on the member-password page.
It's not consistent to only do this check on 1 place.
This patch adds the check for the 2 other places: memberentry and at the
OPAC.

Test plan:
1/ Edit a patron and set a password with leading and/or trailing
whitespaces. You should not be allowed to do it (no server side check).
2/ Same at the OPAC ("Change you password" tab). Here there is a server
side check.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:07:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:07:22 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42194|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy  ---
Created attachment 42325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42325&action=edit
Bug 14509: (follow-up) Reject invalid passwords

The members.js was not included in member-password.tt
And it cannot, there are specific code which cannot be used outside of
memberentry.tt

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:07:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:07:47 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41295|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:07:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:07:45 +0000
Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end,
 beginning or as your password
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:11:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:11:04 +0000
Subject: [Koha-bugs] [Bug 14778] New: Get rid of DBIx::Connector
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

            Bug ID: 14778
           Summary: Get rid of DBIx::Connector
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We should get rid of DBI::Connector and use the DB connection created by
DBIx::Class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:11:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:11:14 +0000
Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in
 C4::Context instead of dbh
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14778

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:11:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:11:14 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14375

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:11:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:11:49 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #1 from Jonathan Druart  ---
Created attachment 42326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42326&action=edit
Bug 14778: Get rid of DBIx::Connector

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:03 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:11 +0000
Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41544|0                           |1
        is obsolete|                            |

--- Comment #9 from Olli-Antti Kivilahti  ---
Created attachment 42327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42327&action=edit
Bug 14458: 5. Add SwaggerUI documentation for RESTful API

Changed API endpoint to /api/v1/...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:36 +0000
Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in
 C4::Context instead of dbh
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

--- Comment #17 from Jonathan Druart  ---
Fridolin, Could you have a look at the patch I have just submitted on bug
14778?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:35 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

--- Comment #2 from Marc V?ron  ---
Created attachment 42328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42328&action=edit
[Signed-off] Bug 14760 - Disabled courses display in the course reserves list
for items

If an item is on reserve for two courses but one of those courses is
disabled, both courses are still listed on opac-detail.pl!

Test Plan:
1) Enable course reserves
2) Create two courses
3) Place one item on reserve for both courses
4) Disable one of the two courses
5) View the record details for that record/item
6) You should see both courses listed in the course reserves column
7) Apply this patch
8) Reload the page
9) You should now only see the active course in the course reseves column

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:53 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42121|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:12:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:12:58 +0000
Subject: [Koha-bugs] [Bug 14656] Delete Bibliographic Records REST API route
	& permission
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42115|0                           |1
        is obsolete|                            |

--- Comment #3 from Olli-Antti Kivilahti  ---
Created attachment 42329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42329&action=edit
Bug 14656 - Delete Bibliographic Records REST API route & permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:13:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:13:02 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:13:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:13:49 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |fridolin.somers at biblibre.co
                   |                            |m,
                   |                            |olli-antti.kivilahti at jns.fi
                   |                            |, pianohacker at gmail.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:14:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:14:02 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #2 from Jonathan Druart  ---
What about this patch guys?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:21:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:21:35 +0000
Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

--- Comment #4 from Nicole C. Engard  ---
After I apply this patch I can't click 'Show More' at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:24:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:24:07 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #2 from Marc V?ron  ---
Created attachment 42330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42330&action=edit
[Signed-off] Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:24:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:24:23 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #41734|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:24:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:24:35 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:31:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:31:06 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Eugene Espinoza  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |eugenegf at yahoo.com

--- Comment #3 from Eugene Espinoza  ---
I tested this during GBSD together with Kyle. And the patch works!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:36:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:36:32 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41871|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 42331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42331&action=edit
[SIGNED-OFF] Bug 14717: Invalid dates in debarred column

To test
1/ Import a patron using the patron import tool, make sure they have
no debarred column in the file
2/ Check the database, notice the debarred column is 0000-00-00
3/ For bonus points, checkout an item to that borrower, then check it in
notice Koha errors
4/ Apply patch
5/ Import a new patron
6/ Notice column is now NULL and that checkins work

Signed-off-by: Eugene Espinoza 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:39:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:39:41 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42310|0                           |1
        is obsolete|                            |

--- Comment #240 from Jonathan Druart  ---
Created attachment 42332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42332&action=edit
Bug 10855: Remove additional field values when subscription is removed

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:39:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:39:49 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #241 from Jonathan Druart  ---
Created attachment 42333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42333&action=edit
Bug 10855: (follow-up) Bug 10855: Remove additional field values when
subscription is removed

The subscriptionid should not be escaped and placeholders used.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:39:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:39:57 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Jerwyn  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |os.jerwynfernandez at gmail.co
                   |                            |m

--- Comment #32 from Jerwyn  ---
If were not mistaken, nothing happen with the patch.

Kind regards,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:40:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:40:14 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:40:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:40:25 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #242 from Jonathan Druart  ---
Back in the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:42:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:42:41 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

--- Comment #2 from Marc V?ron  ---
Created attachment 42334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42334&action=edit
[Signed-off] Bug 14354: Prevent edition of items from other branches if
IndependentBranches is on

If IdependentBranches is ON, to edit/delete items from other branches
you need to be superlibrarian.
Currently a "simple" staff user cannot edit them from the edit item page
but from the catalogue detail page.

The edit links should not be displayed on this table.

Test plan:
O/ Set IndependentBranches to "Prevent".
Create a record and add 2 items:
   Set homebranch to L1 for item I1.
   Set homebranch to L2 for item I2.
1/ With a superlibrarian user, you should be able to edit both items.
2/ With a "simple" user attached to L1, you should only be able to edit
I1. The edit links should not be displayed for I2.

Note that the checkbox is displayed on the catalogue detail page (item
list), but on the batch tools, it won't be possible to select non-modifiable
items.

TODO: Add a server-side check. Indeed it is still possible to edit an
item if the user know the url.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:43:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:43:06 +0000
Subject: [Koha-bugs] [Bug 14779] New: reviewswaiting.pl paging is not working
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

            Bug ID: 14779
           Summary: reviewswaiting.pl paging is not working
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1, the paging at the
bottom only offset by 1 entry, instead of moving a full page (20 entries)
ahead.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:43:11 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #41003|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:43:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:43:28 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:47:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:47:35 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

--- Comment #1 from Blou  ---
Created attachment 42335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42335&action=edit
Bug 14779 - Cannot paginate reviews

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1,
the paging at the bottom only offset by 1 entry, instead of moving a full page
(20 entries) ahead.

The simple fix uses 'page' instead of 'offset'.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

Apply patch, redo step 4-5.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:48:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:48:10 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:48:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:48:34 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Blou  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |philippe.blouin at inlibro.com
                 CC|                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:49:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:49:03 +0000
Subject: [Koha-bugs] [Bug 14771] allow patrons to pick a username
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|all patrons to pick a       |allow patrons to pick a
                   |username                    |username

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:55:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:55:34 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42287|0                           |1
        is obsolete|                            |

--- Comment #56 from Alex Arnaud  ---
Created attachment 42336
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42336&action=edit
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions

Suggestion form uses C4::Koha::GetSupportList to get a list of supports that
can come from itemtypes or authoritized values LOC or CCODE.
C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one
value. But this syspref can contain several values separated by a pipe.

This patch introduces a new syspref SupportsAuthorizedValues to select wich
authorized values category that represents the physical support (itemtypes by
default, loc or ccode). These authorized values will be used in suggestion
management, known as 'document type'.
(Note that database field is still 'itemtype').

Test plan :
-----------
- Set SupportsAuthorizedValues with itemtypes or loc or ccode
- Get to suggestion form (OPAC or intranet)
- Look at "Document type" combobox, it must contains descriptions of selected
authorized values
- Save the suggestion
- Get to intranet suggestions management
- Organize suggestions by document type
=> your suggestion must appear in a tab with its document type description

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:55:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:55:42 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42288|0                           |1
        is obsolete|                            |

--- Comment #57 from Alex Arnaud  ---
Created attachment 42337
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42337&action=edit
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:55:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:55:48 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42289|0                           |1
        is obsolete|                            |

--- Comment #58 from Alex Arnaud  ---
Created attachment 42338
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42338&action=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

Signed-off-by: Olli-Antti Kivilahti 

  Tested the TEST PLAN. With ccode, itype, none, loc.
  On both OPAC and SC.
  Making a code review, but it is hard during the hackfest.
  Morbid lack of any kind of unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:55:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:55:54 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42290|0                           |1
        is obsolete|                            |

--- Comment #59 from Alex Arnaud  ---
Created attachment 42339
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42339&action=edit
Bug 9223 [Follow-up] change the way syspref SuggestionsUseValues is added: Use
the new worflow (atomic update)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:56:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:56:01 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42291|0                           |1
        is obsolete|                            |

--- Comment #60 from Alex Arnaud  ---
Created attachment 42340
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42340&action=edit
Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName
subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 16:59:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 14:59:57 +0000
Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

--- Comment #1 from Winona Salesky  ---
Reading through the LOC page on this field I see that the latest 264 fields can
be indicated by ind1=3. I would like to add ind1=3 as a filter to suppress
obsolete 264 fields. This is certainly up for discussion if users feel the
ind1=3 is not widely utilized. 

Thanks, 
-Winona

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:03:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:03:58 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

--- Comment #13 from Kyle M Hall  ---
Created attachment 42341
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42341&action=edit
Bug 14297 [QA Followup] - Remove unnecessary line

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:09:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:09:59 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42331|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 42342
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42342&action=edit
Bug 14717: Invalid dates in debarred column

To test
1/ Import a patron using the patron import tool, make sure they have
no debarred column in the file
2/ Check the database, notice the debarred column is 0000-00-00
3/ For bonus points, checkout an item to that borrower, then check it in
notice Koha errors
4/ Apply patch
5/ Import a new patron
6/ Notice column is now NULL and that checkins work

Signed-off-by: Eugene Espinoza 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:10:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:10:08 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #7 from Jonathan Druart  ---
Created attachment 42344
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42344&action=edit
Bug 14171: Update borrowers date fields

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:10:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:10:05 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #6 from Jonathan Druart  ---
Created attachment 42343
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42343&action=edit
Bug 14717: Prevent 0000-00-00 on updating a patron

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:11:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:11:22 +0000
Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with
 0000-00-00 as the debarred date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |chris at bigballofwax.co.nz
                   |ity.org                     |

--- Comment #8 from Jonathan Druart  ---
I think we should go further here.
Can I get a QA on the new patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:22:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:22:58 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Colin Campbell  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

--- Comment #2 from Colin Campbell  ---
Upping priority as this needs applying to releases from 3.18.7 to stop
communication errors on renew. The change causing the error was bug 13315

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:26:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:26:37 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Colin Campbell  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #25 from Colin Campbell  ---
Change in return causes sipserver instances to crash on renewals : see bug 
14673 for description and workaround

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:28:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:28:51 +0000
Subject: [Koha-bugs] [Bug 14780] New: Datetime format seems
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780

            Bug ID: 14780
           Summary: Datetime format seems
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: eugenegf at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 42345
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42345&action=edit
01

In Circulation module, when using the datetime picker in Checkout, I am getting
the following error:

Software error:

The 'month' parameter ("29") to DateTime::new did not pass the 'an integer
between 1 and 12' callback
 at /usr/lib/perl5/DateTime.pm line 199
        DateTime::new(undef, 'hour', 09, 'minute', 00, 'second', 0, 'month',
29, ...) called at /home/koha/src/Koha/DateUtils.pm line 164
        Koha::DateUtils::dt_from_string('09/29/2015 09:00') called at
/home/koha/src/circ/circulation.pl line 170

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:34:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:34:42 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #2 from Marc V?ron  ---
Created attachment 42346
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42346&action=edit
[Signed-off] Bug 12426: Allow resending of messages from the notices tab in the
patron account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=XXXXX" where XXXXX is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::_set_message_status() to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:35:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:35:13 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42295|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:35:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:35:24 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:35:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:35:46 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart  ---
What you describe is the expected behavior, I think.
With your patch if you filter the table and click "select all", it will select
all row, even the filtered ones.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:41:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:41:12 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:41:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:41:15 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42328|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42347&action=edit
Bug 14760 - Disabled courses display in the course reserves list for items

If an item is on reserve for two courses but one of those courses is
disabled, both courses are still listed on opac-detail.pl!

Test Plan:
1) Enable course reserves
2) Create two courses
3) Place one item on reserve for both courses
4) Disable one of the two courses
5) View the record details for that record/item
6) You should see both courses listed in the course reserves column
7) Apply this patch
8) Reload the page
9) You should now only see the active course in the course reseves column

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:41:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:41:44 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
Note that this already works at the intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 17:43:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 15:43:00 +0000
Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on
	Ubuntu/Apache2.4
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:12:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:12:08 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:12:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:12:12 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42028|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart  ---
Created attachment 42348
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42348&action=edit
Bug 14297 - Unit Tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:12:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:12:15 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42029|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart  ---
Created attachment 42349
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42349&action=edit
Bug 14297 - Holds Queue building ignoring holds where pickup & home branch
don't match and item is not from least cost branch

If a record has a hold on it where the pickup and home branch do not
match, the holds queue builder will only look at items from the least
cost branch ( as defined by the transport cost matrix or the sys pref
StaticHoldsQueueWeight.

Test Plan:
1) Create a record with two items, one for library A and one for library B
2) Set your circulation rules such that the book from library A is
   holdable by all and the book from library B is holdable only by library
   B patrons
3) Create a hold for a Library C patron for pickup at library C
4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A,
   Library C in that order
5) Rebuild the holds queue
6) Note the hold wasn't picked up even though the item from library A
   could have filled the hold
7) Apply this patch
8) Rebuild the holds queue
9) View the holds queue again
10) Note the hold now displays

Signed-off-by: Nora Blake 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:12:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:12:19 +0000
Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where
 pickup & home branch don't match and item is not from least cost branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42341|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart  ---
Created attachment 42350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42350&action=edit
Bug 14297 [QA Followup] - Remove unnecessary line

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:18:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:18:32 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart  ---
Lari,
I really would prefer to see a new subroutine added to C4::Letters covered by
tests.
Something like C4::Letters::ResendMessage($message_id).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:57:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:57:24 +0000
Subject: [Koha-bugs] [Bug 14781] New: Creation of barcode types 2of5 not
	functional
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

            Bug ID: 14781
           Summary: Creation of barcode types 2of5 not functional
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: mik at adminkuhn.ch
        QA Contact: testopia at bugs.koha-community.org

Koha menu "Tools > Labels home > Manage label

After setting up a new label layout using barcode type "COOP2of5" or
"Industrial2of5", when trying to create some labels the layout won't render at
all for both barcode types. Thus the resulting page will be completely empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 18:59:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 16:59:08 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Label/patron card printing
           Assignee|gmcharlt at gmail.com          |cnighswonger at foundations.ed
                   |                            |u
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:00:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:00:21 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #33 from Marcel de Rooy  ---
CHECK: No results while files have been uploaded permanently? Test by drojf.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:12:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:12:26 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #61 from Koha Team Lyon 3  ---
I have tested the different values of the new syspref "suggestionsUseValues".
In each case, in pro interface or in OPAC, the authorized values match with the
choice in the syspref. And it's the description that is displayed in the
dropdown.
I tried to modify the suggestions in the pro interface and it's Ok too.

If, "hide this option" is selected, none are in the form (tested in pro and
opac too).

There's just one thing that could be much better : code are displayed in the
list of suggestions (OPAC and PRO) and it would be more useful to have the
description instead.
cf. cgi-bin/koha/suggestion/suggestion.pl and cgi-bin/koha/opac-suggestions.pl

But I don't want to block this patch for that.

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:15:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:15:42 +0000
Subject: [Koha-bugs] [Bug 14782] New: can't search by username anymore
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

            Bug ID: 14782
           Summary: can't search by username anymore
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We used to be able to search by username when doing patron searching and that
availability is gone.  I think this happened with the new patron search form in
ajax.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:19:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:19:32 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #15 from Kyle M Hall  ---
Created attachment 42351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42351&action=edit
Bug 11622 [QA Followup] - Add new module dependency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:19:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:19:50 +0000
Subject: [Koha-bugs] [Bug 14780] Datetime format picker error in Circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780

Eugene Espinoza  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Datetime format seems       |Datetime format picker
                   |                            |error in Circulation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:24:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:24:34 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:25:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:25:15 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #16 from Kyle M Hall  ---
Created attachment 42352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42352&action=edit
Bug 11622 [QA Followup] - Add utf8 flag for CGI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 19:30:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 17:30:10 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #17 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Galen Charlton from comment #5)
> > Comment on attachment 24754 [details] [review] [review]
> > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> > 
> > Review of attachment 24754 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: opac/opac-account-pay-paypal-return.pl
> > @@ +20,5 @@
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> > > +
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.
> 

I'm not sure what this means. Can you explain?


> > ::: opac/opac-account-pay.pl
> > @@ +19,5 @@
> > > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.

Same as above


> > @@ +94,5 @@
> > > +        'PAYMENTREQUEST_0_PAYMENTACTION'        => 'Sale',
> > > +        'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly',
> > > +        'PAYMENTREQUEST_0_DESC' =>
> > > +          C4::Context->preference('PayPalChargeDescription'),
> > > +    };
> > 
> > It seems like using Business::PayPal::API might offer some protection
> > against API changes.
> 
> Answer needed.

That's what I tried first when I began writing this feature. It did not go
well. PayPal doesn't change existing APIs anyway. They have an API versioning
system so that applications don't break with changes to the API.

> 
> +use CGI;
> 
> Should be replaced by CGI qw( -utf8 ) unless you have a good reason.
> 

Fixed!

> 
> > 3) Create a paypal developer account
> 
> How? Should I need a paypal account to do so?

I don't think you need a regular paypal account, but you do need an account on
https://developer.paypal.com/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 20:00:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 18:00:57 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

MetaBiblioteca Colombia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |3.20

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 20:05:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 18:05:04 +0000
Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to
 reflect Zebra indexing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 20:37:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 18:37:33 +0000
Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour
	finesCalendar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

MetaBiblioteca Colombia  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |felipe.gomez3 at gmail.com

--- Comment #7 from MetaBiblioteca Colombia  ---
Hello in Koha 3.20 Suspentions fails when loan by hours

See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

The solution:

Remove line 2157 in the /usr/share/koha/lib/C4/Circulation.pm

$finedays = $finedays * 24 if ( $unit eq 'hours' );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 20:43:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 18:43:12 +0000
Subject: [Koha-bugs] [Bug 14783] New: Allow patrons to change pickup
 location for non-waiting holds
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

            Bug ID: 14783
           Summary: Allow patrons to change pickup location for
                    non-waiting holds
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This enhancement would allow patrons to change the pickup location for any hold
that is not already waiting ( e.g. it would be allowable for in transit holds
).

For non-found holds the feature will not change much behavior. For in-transit
holds the feature would trigger a completion of the current transfer and
generate a new transfer from the previous target library to the new target
library.

The feature would be controlled via a system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 21:11:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 19:11:37 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 21:16:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 19:16:48 +0000
Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2
	Server
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 21:18:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 19:18:17 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 21:57:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 19:57:56 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #15 from Jesse Weaver  ---
Created attachment 42353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42353&action=edit
Bug 14510: (QA followup) Fix bug with unmapped columns

Fall back more smoothly when items subfields are not mapped to a
kohafield. Note, however, that this development does not allow applying
default settings to subfields that aren't mapped. A note has been added
to the columns settings page, as there is no known workaround for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 21:57:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 19:57:54 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

Jesse Weaver  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 22:05:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 20:05:21 +0000
Subject: [Koha-bugs] [Bug 14784] New: Missing checkin message for debarred
 patrons when issuing rules' fine days = 0
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

            Bug ID: 14784
           Summary: Missing checkin message for debarred patrons when
                    issuing rules' fine days = 0
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: genevieve.plantin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Context : a patron was previously debarred and has returned a overdue book.

There should be a message saying : "Check in message - Reminder: Patron was
earlier restricted until ..."

However, when the column finedays in the table issuingrules equals 0, no
message is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 22:05:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 20:05:43 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Missing checkin message for |Missing checkin message for
                   |debarred patrons when       |debarred patrons when
                   |issuing rules' fine days =  |issuing rules 'fine days =
                   |0                           |0'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 22:07:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 20:07:31 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |genevieve.plantin at inlibro.c
                   |ity.org                     |om
                 CC|                            |charles.farmer at inlibro.com,
                   |                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 22:42:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 20:42:52 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #1 from Genevieve Plantin  ---
Created attachment 42354
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42354&action=edit
CAM 2267 - Bug 14784 : Fix checkin message for debarred patrons

If there is an overdue but finedays equals 0, then we have to see if the patron
is debarred and if he was forever debarred. So we have to go through the same
code a if it was a debarred patron with no overdue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:02:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:02:28 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:03:26 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:03:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:03:29 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41452|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack  ---
Created attachment 42355
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42355&action=edit
Bug 14673 Work around change to AddIssue return

Return from AddIssue used to be due date or undef.
Now it is less straightforward returning am issue object
if an issue row is created or undef. If the issue is a renewal
undef is returned. As that case was not handled properly it
caused the server site to crash the listener causing a
communications error on the client.

Signed-off-by: Chris Cormack 

We have this patch in production, it does solve the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:08:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:08:46 +0000
Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in
 C4::Context instead of dbh
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #18 from Chris Cormack  ---
Please see 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

The Author of DBIx::Class recommends we shouldn't use DBIx::Connector and I
tend to agree

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:12:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:12:04 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Adding a new patron can end |Prevent 0000-00-00 dates in
                   |up with 0000-00-00 as the   |patron data
                   |debarred date               |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:22:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:22:02 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #9 from Katrin Fischer  ---
Created attachment 42356
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42356&action=edit
[PASSED QA] Bug 14717: Invalid dates in debarred column

To test
1/ Import a patron using the patron import tool, make sure they have
no debarred column in the file
2/ Check the database, notice the debarred column is 0000-00-00
3/ For bonus points, checkout an item to that borrower, then check it in
notice Koha errors
4/ Apply patch
5/ Import a new patron
6/ Notice column is now NULL and that checkins work

Signed-off-by: Eugene Espinoza 

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:22:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:22:08 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #11 from Katrin Fischer  ---
Created attachment 42358
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42358&action=edit
[PASSED QA] Bug 14171: Update borrowers date fields

Signed-off-by: Jonathan Druart 

http://bugs.koha-community.org/show_bug.cgi?id=14717

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:22:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:22:05 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #10 from Katrin Fischer  ---
Created attachment 42357
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42357&action=edit
[PASSED QA] Bug 14717: Prevent 0000-00-00 on updating a patron

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:22:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:22:34 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:23:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:23:47 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com

--- Comment #9 from H?ctor Eduardo Castro Avalos  ---
Hi Marcel you're right, the three perl scripts/templates do nothing or do the
same thing, but the magic of having too many plugins perhaps is for filling
different data in the frameworks. i.e., books only uses "06 - Type of record: a
- Language material" but computer files uses "m - Computer file" and videos
uses "g - Projected medium"

With this you save time for experimented catalogers. The data in the leader is
predefined and she or he doesn't need to fill at all. Just by the fact to
choose the proper framework is enough.

Maybe you can do a trick in your plugin to catch the framework code and
redefine the leader for the type of resource/material.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:32:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:32:37 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #10 from H?ctor Eduardo Castro Avalos  ---
Created attachment 42359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42359&action=edit
[SIGNED-OFF]Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
    leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
    irrelevant. Some updates to leader have not been incorporated into
    the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
    it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
    PO files in misc/translator.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:32:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:32:52 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #11 from H?ctor Eduardo Castro Avalos  ---
Created attachment 42360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42360&action=edit
[SIGNED-OFF]Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:33:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:33:06 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #12 from H?ctor Eduardo Castro Avalos  ---
Created attachment 42361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42361&action=edit
[SIGNED-OFF]Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
    In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:33:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:33:52 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41000|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:34:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:34:20 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41001|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:34:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:34:34 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41002|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:34:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:34:51 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

H?ctor Eduardo Castro Avalos  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:43:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:43:07 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:43:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:43:10 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42334|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer  ---
Created attachment 42362
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42362&action=edit
[PASSED QA] Bug 14354: Prevent edition of items from other branches if
IndependentBranches is on

If IdependentBranches is ON, to edit/delete items from other branches
you need to be superlibrarian.
Currently a "simple" staff user cannot edit them from the edit item page
but from the catalogue detail page.

The edit links should not be displayed on this table.

Test plan:
O/ Set IndependentBranches to "Prevent".
Create a record and add 2 items:
   Set homebranch to L1 for item I1.
   Set homebranch to L2 for item I2.
1/ With a superlibrarian user, you should be able to edit both items.
2/ With a "simple" user attached to L1, you should only be able to edit
I1. The edit links should not be displayed for I2.

Note that the checkbox is displayed on the catalogue detail page (item
list), but on the batch tools, it won't be possible to select non-modifiable
items.

TODO: Add a server-side check. Indeed it is still possible to edit an
item if the user know the url.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:48:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:48:37 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  3 23:48:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 21:48:40 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42278|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer  ---
Created attachment 42363
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42363&action=edit
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:03:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:03:27 +0000
Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:03:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:03:29 +0000
Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40941|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens  ---
Created attachment 42364
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42364&action=edit
[SIGNED OFF]Bug 14198: RDA: Indexing 264 field (Zebra)

This patch add zebra indexes to RDA 264 field.
The new Provider index is added too.
QA comments corrected.

To test:
1) Download RDA records with 264 fields from this attachment
. Import the
file and re-index/rebuild zebra. These records contain 260 and 264 fields per
record.
2) Do a search with pb:Bethany two records will appear with title The guardian.
Search with pl:Minneapolis too, the two records will appear.
3) Select one record of both records and delete the 260 field keeping the 264
field and save, rebuild your zebra.
4) Search again with pb:Bethany and just one record will appear. Thats mean 264
is not indexed.
5) Apply patches.
6) Rebuild your zebra but this time all biblio records.
7) Search again with pv:Bethany or Provider:Bethany, this time will appear the
two records, 264 is indexed. Note that if you search again with pb only one
record appear. This is because the suggestion of LOC.
10) Search with copydate:2013 only launch records with 260 fields and pv:2013
show both fields, i.e., 260 and 264.
11) Apply QA Test Tools

Sponsored-by: Universidad de El Salvador
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:10:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:10:37 +0000
Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:22:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:22:52 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:22:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:22:55 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42195|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer  ---
Created attachment 42365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42365&action=edit
[PASSED QA] Bug 14470: Do not allow renew for on-site checkouts

At the opac, the renew checkbox should not be displayed if it's an
on-site checkout (same on the intranet).

On the way, this patch adds a specific message to the intranet if the
librarian try to renew an on-site checkout.
Indeed before this patch a renew was allowed if the barcode was scanned.

Test plan:
1/ Create an on-site checkout for a patron
2/ Confirm that the checkbox 'renew' is not displayed on the checkout
list tables
3/ At the OPAC, the renew should not be allowed (no checkbox)
4/ Try to check the item out to the same patron, confirm that you get a
specifig message to inform you the renew is not allowed for on-site
checkouts.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Katrin Fischer 
Changed 'issue' to 'item' in the error message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:24:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:24:47 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

--- Comment #19 from Katrin Fischer  ---
This is good - but I agree with bondiurbano - we should really mark the on-site
checkouts in the checkouts list, maybe similar to how it is in the staff
client. It's visible in the reading history only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:26:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:26:03 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42365|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer  ---
Created attachment 42366
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42366&action=edit
[PASSED QA] Bug 14470: Do not allow renew for on-site checkouts

At the opac, the renew checkbox should not be displayed if it's an
on-site checkout (same on the intranet).

On the way, this patch adds a specific message to the intranet if the
librarian try to renew an on-site checkout.
Indeed before this patch a renew was allowed if the barcode was scanned.

Test plan:
1/ Create an on-site checkout for a patron
2/ Confirm that the checkbox 'renew' is not displayed on the checkout
list tables
3/ At the OPAC, the renew should not be allowed (no checkbox)
4/ Try to check the item out to the same patron, confirm that you get a
specifig message to inform you the renew is not allowed for on-site
checkouts.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Katrin Fischer 
Changed 'issue' to 'item' in the error message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:33:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:33:41 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

--- Comment #12 from Katrin Fischer  ---
Created attachment 42367
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42367&action=edit
[PASSED QA] Bug 14649: Followup - correct budget_period_id in fund name link

Now that fund name is displayed in the table as a link, you see that arg
budget_period_id is never defined in this link.

This is because the template var is [% budget_line.budget_period_id %] instead
of [% budget_period_id %].
This looks like a mistake when converting from tmpl to tt.

Test plan :
- Without patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> You see in URL that budget_period_id is empty :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=
- Apply patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> you see in URL that budget_period_id is defined like in planning page :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:34:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:34:07 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:34:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:34:10 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42268|0                           |1
        is obsolete|                            |
  Attachment #42269|0                           |1
        is obsolete|                            |
  Attachment #42367|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer  ---
Created attachment 42368
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42368&action=edit
[PASSED QA] Bug 14649: Fix regression - display fund name on budget planning

A patch from bug 11714 removes 'budget_name_indent', which was useless.
The script and the template should use the budget_name value.

Note that this patch impacts the CSV export, which does not work, so it cannot
be
tested.

Test plan:
Edit a fund and click on one of the Planning value (by months, etc.)
The "Fund name" column should be correctly populated with the fund
names.

Signed-off-by: Fridolin Somers 
Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:34:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:34:44 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

--- Comment #14 from Katrin Fischer  ---
Created attachment 42369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42369&action=edit
[PASSED QA] Bug 14649: Followup - correct budget_period_id in fund name link

Now that fund name is displayed in the table as a link, you see that arg
budget_period_id is never defined in this link.

This is because the template var is [% budget_line.budget_period_id %] instead
of [% budget_period_id %].
This looks like a mistake when converting from tmpl to tt.

Test plan :
- Without patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> You see in URL that budget_period_id is empty :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=
- Apply patch
- Look for a planning with funds :
    /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> you see in URL that budget_period_id is defined like in planning page :
    /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:48:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:48:57 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:49:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:49:00 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42257|0                           |1
        is obsolete|                            |
  Attachment #42258|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer  ---
Created attachment 42370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42370&action=edit
[PASSED QA] Bug 12525: FIX patron lists dropdown is empty

On the patrons home page, the dropdown list is not populated.

Test plan:
1/ Go on the patrons home page (members/members-home.pl)
2/ Launch a search
3/ The dropdown list close to "Add selected patrons to" should contain
all your patron lists

NOTE: Initially tested with both which created lists.
      git reset --hard origin/master
      And then dropdown list was missing them.
      Applied just this one, and they were listed.

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:49:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:49:41 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #15 from Katrin Fischer  ---
Created attachment 42371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42371&action=edit
[PASSED QA] Bug 12525: Prevent adding several patron lists with the same name

If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.

To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created

Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:55:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:55:05 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

--- Comment #10 from Katrin Fischer  ---
This improves the situation, but there is still a problem when you are creating
more than one item - the plugin will always create the same barcode for each.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:55:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:55:49 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 00:55:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 22:55:52 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42104|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer  ---
Created attachment 42372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42372&action=edit
[PASSED QA] Bug 11273: FIX barcode generation in acquisition if hbyymmincr

When AutoBarcode is activated and you have set AcqCreateItem to 'on
order' there is a Javascript error when you try to generate a barcode
for the item:

TypeError: document.f is undefined
http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js
Line 11

Test plan:
0/ a. Set AutoBarcode to hbyymmincr
   b. Set AcqCreateItem to 'on ordering'
   c. Set the plugin barcode.pl to the barcode field for the default
   and the ACQ frameworks
1/ Go on the add items page (cataloguing/additem.pl) and confirm that
the plugin works as expected.
2/ Go on the New order page (acqui/neworderempty.pl) and confirm that
the plugin works as expected.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 01:04:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 23:04:49 +0000
Subject: [Koha-bugs] [Bug 9047] show hold info on self check out
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9047

jdemuth at roseville.ca.us  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 01:10:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 23:10:22 +0000
Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

Liz Rea  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #9 from Liz Rea  ---
Erm, I was looking for a sign off from Brendan on the website work, and there
will be no attachments, ever, because this work isn't Koha work proper. 

You'll notice that this is in the "Websites" component, which is where we keep
bugs regarding the koha-community.org website.

What I do need, is more information from someone involved with the fund about
what the money is going to be used for, what the rules are, who the people in
charge are, and so on, to put on the website somewhere. I don't think people
will be super keen to donate without knowing where the money is going.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 01:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Sep 2015 23:52:57 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

--- Comment #9 from Liz Rea  ---
Regarding the admin getting an email monthly - I think that might be alright,
and here is why: we want to encourage people to contribute their stats. They
might install a new version, and not realise that this is a feature they now
have. It might take an independent Koha admin several months to "get around" to
enabling the sysprefs for "reasons" - in that case the reminder might be nice.
An experienced admin will say "that's running a cron, I bet I can remove it
from the jobs and this message will go away" which also seems reasonable to me.
Instructions on what to do might be nice in the error message, but I don't
think the fact that it generates output with the syspref off, in itself, is
reason to deny this patch.

A followup that makes the falure output more informative (maybe) would be good.

I see this as very much like the message you get when
EnhancedMessagingPreferences is off. As an admin you go "ah right, yeah that's
off and I mean it to be" or, if you mean for it to be on "ah right, yeah, I
want that on actually!" and you go take care of it.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 02:12:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 00:12:59 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #125 from Jesse Weaver  ---
Created attachment 42373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42373&action=edit
Bug 11559: (followup) Prevent saving item tags, fix other issues

This fixes the following issues:
  * Spaces are now allowed in indicators
  * Shift-Enter is available to insert a newline if needed
  * Item tags, if present, will prevent saving (as they are not correctly
    processed by the backend)
  * biblionumber tags (999 in MARC21) will be stripped before the record
    is saved to Koha, to prevent their modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 03:00:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 01:00:42 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

--- Comment #10 from Tom?s Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> Comment on attachment 41024 [details] [review]
> Bug 13585 : Add a cronjob which send UsageStats monthly.
> 
> Review of attachment 41024 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: debian/koha-common.cron.monthly
> @@ +15,5 @@
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program.  If not, see .
> > +
> > +
> > +koha-foreach --enabled /usr/share/koha/bin/cronjobs/share_usage_with_koha_community.pl
> 
> The problem is that the share_usage_with_koha_community.pl considers it's an
> error to launch it if the pref is not enabled.
> There is a warning message and an exit 1 in this case.

I agree with all of you actually:
- Having a cronjob error email might not be that useful.
- A new bug should be filled. In that case I would propose a --quiet switch and
could provide the patch.
- We should at least show a message on the about page about this. And encourage
people to check that page regularly on update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 04:25:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 02:25:55 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

--- Comment #4 from Tom?s Cohen Arazi  ---
I think this patch breaks a functionality without a clear reason. Maybe I'm
missing something else, as it is shipped in all supported platforms. In case we
move on with this, we need a follow-up for koha-plack checking the absence of
the lib. And probably patching plack.psgi so it works without it.
But I repeat, I'm not sure why we need this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 06:21:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 04:21:25 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #106 from Robin Sheat  ---
Just a headsup that I'll be out of touch until about the 17th of September, so
that's why there'll be radio silence for a while :)

Jonathan, I was hoping to pull your patches in on top of my sorting fixes,
unfortunately I didn't quite get them finished in time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 07:52:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 05:52:51 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #12 from M. Tompsett  ---
Comment on attachment 39744
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39744
bug 12446 - Enable adult patrons to have a guarantor

Review of attachment 39744:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12446&attachment=39744)
-----------------------------------------------------------------

I just skimmed the patches. The linking guarantor to a specific category code
is bad. I like the notion of a canbeguaranteed code field. Some code changes
aren't obvious to me.

::: C4/Utils/DataTables/Members.pm
@@ +38,5 @@
> +        @columns = grep { ! $seen{ $_ }++ } ( @columns, @guarantor_attributes );
> +    };
> +    $_ = "borrowers.".$dbh->quote_identifier($_) for (@columns);
> +
> +    my $select = "SELECT ${ \join(',', @columns) },

This code is horrible to read!

::: installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql
@@ +9,5 @@
> +-- ********* --
> +ALTER TABLE categories ADD COLUMN `canbeguarantee` tinyint(1) NOT NULL default '0';
> +
> +-- Set defaults for new column
> +UPDATE categories set canbeguarantee = 1 WHERE category_type IN ('C', 'P');
\ No newline at end of file

Default behaviour should NOT activate new functionality.

::: installer/data/mysql/sysprefs.sql
@@ +481,4 @@
>  ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over details page display on intranet','Free'),
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),

Why was , added at the end?

::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
@@ +148,4 @@
>  
>      [% IF ( CAN_user_borrowers ) %]
>          [% IF ( adultborrower AND activeBorrowerRelationship ) %]
> +             Add guarantiee

Is that spelt correctly?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
@@ +25,5 @@
>          $("#branches option:first").attr("selected", "selected");
>      }
> +    $("#category_type").change(function(){
> +        var selected = $(this).val();
> +        $("#canbeguarantee").val( (selected == 'C' || selected == 'P') ? "1" : "0" );

Hardcoded category codes is a bad thing.
Is there a better way to do this?

::: members/memberentry.pl
@@ +251,4 @@
>  }
>  
>    #recover all data from guarantor address phone ,fax... 
> +if ( $guarantorid and ( $category_type eq 'C' || $category_type eq 'P')) {

Why remove the space?

@@ -259,5 @@
>          if ( $op eq 'add' ) {
>  	        foreach (qw(streetnumber address streettype address2
> -                        zipcode country city state phone phonepro mobile fax email emailpro branchcode
> -                        B_streetnumber B_streettype B_address B_address2
> -                        B_city B_state B_zipcode B_country B_email B_phone)) {

Why were these removed?

::: members/moremember.pl
@@ +204,2 @@
>  	if ($category_type eq 'C'){
>  		$template->param('C' => 1);

Is this used anymore in the template file? I saw you removed one C condition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 08:27:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 06:27:44 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #126 from Katrin Fischer  ---
Comment on attachment 42373
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42373
Bug 11559: (followup) Prevent saving item tags, fix other issues

I feel like removing the whole 999 in case of MARC21 is too generious - I'd
feel better if only the subfields for biblionumber and biblioitemnumber would
be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 08:36:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 06:36:56 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #4 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #3)
> What you describe is the expected behavior, I think.
> With your patch if you filter the table and click "select all", it will
> select all row, even the filtered ones.

Then maybe "select/clear all" should be reworded to something like
"select/clear all visible rows" to remove ambuiguity. Or maybe we should make a
difference between invisible rows due to pagination and invisible rows due to
filtering ?
But I believe "Delete" should work on all checked checkboxes, not only the
visible ones (and even the filtered ones).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 08:39:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 06:39:13 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 08:57:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 06:57:46 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

--- Comment #5 from Julian Maurice  ---
Created attachment 42374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42374&action=edit
Bug 14766: unimarc_field_4XX: escape ', ", \n, \r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 08:58:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 06:58:10 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:34:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:34:37 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

--- Comment #12 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #10)
> This improves the situation, but there is still a problem when you are
> creating more than one item - the plugin will always create the same barcode
> for each.

Is it a regression?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:37:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:37:37 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:37:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:37:40 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42176|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart  ---
Created attachment 42375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42375&action=edit
Bug 13585: Add a cronjob which send UsageStats monthly.

This patch introduces entries for monthly running the
share_usage_with_koha_community.pl
script to the packages and also the crontab.example file for manual
installs use.

Edit: I fixed the Copyright line

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:40:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:40:39 +0000
Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not
	be required
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |gmcharlt at gmail.com
                   |ommunity.org                |
             Status|Passed QA                   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:40:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:40:54 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

--- Comment #13 from Katrin Fischer  ---
Nope - it's as before with the other - just annoying. That's why this passed QA
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:41:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:41:30 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #34 from Marcel de Rooy  ---
Rearranging..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:44:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:44:10 +0000
Subject: [Koha-bugs] [Bug 14785] New: Allow On Shelf Holds is not Available
	in 3.20
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14785

            Bug ID: 14785
           Summary: Allow On Shelf Holds is not Available in 3.20
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: os.jerwynfernandez at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Greetings!

I have noticed that in version 3.20 under Global Preferences > Circulation >
Holds Policy

the AllowOnShelfHolds (hold requests to be placed on items that are not checked
out.) is not Available where as you can see this options in the previews
versions.

Did the community intentionally remove this or its a bug?

When you search in OPAC you may see in the search result that you can place
hold the item. However when you select one of the result to see it in normal
view. The place on hold is not available.

Kind regards,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:44:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:44:13 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |master
                 OS|Linux                       |All
           Hardware|PC                          |All

--- Comment #1 from Marc V?ron  ---
intranet-error.log says:
label-create-pdf.pl: Barcode generation failed for item 11 with this error:
Invalid Characters


Lines 539 (for COOP2of5 ) and 557 (for INDUSTRIAL2OF5) of C4/Labels/Label.pm
surround the value with asterisks, however only digits are allowed. After
removing the asterisks the barcodes are generated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:45:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:45:59 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:46:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:46:02 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42263|0                           |1
        is obsolete|                            |
  Attachment #42374|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart  ---
Created attachment 42376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42376&action=edit
Bug 14766: Complete cataloguing plugin unimarc_field_4XX

Add subfields l, n and o for better UNIMARC compliance

Signed-off-by: Chris Cormack 

Note: I just did a code audit here, as I don't know enough about
UNIMARC to know if the 4XX fields should have these subfields.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:46:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:46:29 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

--- Comment #7 from Jonathan Druart  ---
Created attachment 42377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42377&action=edit
Bug 14766: unimarc_field_4XX: escape ', ", \n, \r

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:46:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:46:48 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 09:55:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 07:55:15 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

--- Comment #14 from Jonathan Druart  ---
Yes but I meant: This has already worked before? in 3.18 for instance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:03:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:03:28 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |veron at veron.ch
                   |u                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:04:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:04:22 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #2 from Marc V?ron  ---
Created attachment 42378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42378&action=edit
Bug 14781 - Creation of barcode types 2of5 not functional

This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in
the label creator module.

To test:
- Create a label layout with COOP2of5 barcode type
- Create labels (make sure that the items's barcode values are numeric only!)
- Export batch and download PDF.

Without patch:
- No barcodes rendered
With patch
- Barcodes should render as expected. Test for both barcode types.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:04:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:04:51 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:12:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:12:56 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #85 from Alex Arnaud  ---
apologies for my last commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:15:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:15:44 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #16 from Jonathan Druart  ---
Created attachment 42379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42379&action=edit
Bug 14510: Redirect to the items' fields mapped

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:16:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:16:52 +0000
Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be
	customized
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Jonathan Druart  ---
Jesse,
Great, it works perfectly, for the items editor table...
Not the others :)
Try the late orders table for instance, the ft is broken on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:28:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:28:04 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Andreas Hedstr?m Mace  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:33:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:33:44 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

--- Comment #2 from Andreas Hedstr?m Mace  ---
Created attachment 42380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42380&action=edit
Bug 14726 - Checkout summary doesn't show title Right after checking out, a
small box appear with "Checkout out: Some Title (32154001669305). Due on
24/09/2015". The title doesn't appear anymore (since the move to db schemas). 
This fixes it.

Test:
1) checkout ANY item, for ANY user
2) Look at summary right below the checkout input box.  The title doesn't show
up.
3) apply patch, reproduce same steps (after checkin if same item).  Title
appears.

Signed-off-by: Andreas Hedstr?m Mace 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:35:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:35:38 +0000
Subject: [Koha-bugs] [Bug 10890] Autobarcode "yymm00001" Fails in
 Acquisitions When Receiving Item
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11273

--- Comment #6 from Jonathan Druart  ---
This is certainly a duplicate of bug 11273

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:35:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:35:38 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10890

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:35:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:35:50 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #3 from Michael Kuhn  ---
When removing the asterisks the layout actually renders. Though the resulting
barcodes don't really look like barcode type Industrial2of5 or COOP2of5 (see
the attachment).

To me it looks like the resulting barcodes are formatted like barcode type Code
39 (they apparently have the same length), so I doubt if an ordinary barcode
reader would accept these codes. Correct me if I'm wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:36:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:36:48 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #42225|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:37:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:37:19 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #4 from Michael Kuhn  ---
Created attachment 42381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42381&action=edit
Examples of resultinng barcodes (2015-09-03)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:38:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:38:36 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #5 from Michael Kuhn  ---
Created attachment 42382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42382&action=edit
Examples of resulting barcodes (2015-09-03 COOP2of5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:40:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:40:27 +0000
Subject: [Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes
 with AcqCreateItems = on order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|ASSIGNED                    |NEW

--- Comment #12 from Jonathan Druart  ---
The problem is that the items are not inserted in the DB when you click on the
"Add item" button. So the item form generated just after does not know an item
is on the road.
Hopefully, there is now a check when you submit the complete order "Duplicate
values detected. Please correct the errors and resubmit."
The form is not submitted, there are identical barcodes.

It seems quite tricky to fix this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:41:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:41:24 +0000
Subject: [Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes
 with AcqCreateItems = on order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11273

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:41:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:41:24 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8425

--- Comment #15 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #14)
> Yes but I meant: This has already worked before? in 3.18 for instance

Known bug, see bug 8425.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:45:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:45:35 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:45:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:45:39 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42380|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42383&action=edit
Bug 14726 - Checkout summary doesn't show title

Right after checking out, a small box appear with "Checkout out: Some Title
(32154001669305). Due on 24/09/2015".
The title doesn't appear anymore (since the move to db schemas). This fixes it.

Test:
1) checkout ANY item, for ANY user
2) Look at summary right below the checkout input box.  The title doesn't show
up.
3) apply patch, reproduce same steps (after checkin if same item).  Title
appears.

Signed-off-by: Andreas Hedstr?m Mace 
Signed-off-by: Jonathan Druart 
Todo: You need to track what are the queries generated here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 10:47:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 08:47:56 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 11:09:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 09:09:25 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Koha Team Rennes 2  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at listes.univ-rennes2.fr
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Koha Team Rennes 2  ---
Hi,

This patch applies on 3.16 but there is a two page gap between the result
numbers and the pages actually displayed (for example, clicking on number 10
will lead to page 8). Don't know if this problem has already been reported
somewhere else.

Koha Team Rennes 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 11:20:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 09:20:37 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42228|0                           |1
        is obsolete|                            |

--- Comment #10 from Lari Taskula  ---
Created attachment 42384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42384&action=edit
Bug 14723 - Additional delivery notes to messages

Fixed PageObject test by enabling EnhancedMessagingPreferences
system preference via SystemPreferenceFactory. Without this
preference, the Notices tab will not be shown in left navigation 
menu.

Test plan:

1. Enable EnhancedMessagingPreferences syspref
2. Find a borrower with notices at members/notices.pl
3. Observe that there is no column for Delivery notes
4. Apply patch and run the given database update
5. Repeat step 1.
6. Observe that there is now a column for Delivery notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 11:24:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 09:24:38 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 11:35:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 09:35:33 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42112|0                           |1
        is obsolete|                            |

--- Comment #4 from Olli-Antti Kivilahti  ---
Created attachment 42385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42385&action=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

...
Also the order in which the atomicupdates need to be applied is important.
This _updateorder is automatically generatable from the original Git
repository.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 11:42:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 09:42:43 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42385|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti  ---
Created attachment 42386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42386&action=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:02:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:02:24 +0000
Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height
	scaling editable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14781

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:02:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:02:24 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14149

--- Comment #6 from Marc V?ron  ---
Michael, did you print out the PDF and test?

BTW there is a Bug regarding the barcode dimensions: Bug 14149

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:02:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:02:56 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:02:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:02:58 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

--- Comment #1 from Jonathan Druart  ---
Created attachment 42387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42387&action=edit
Bug 14293: The suspension should be calculated in days

There was a mismatch between bug 13909 and bug 5549.
The get_chargeable_units call from _debar_user_on_return should specify
that we want a suspension in days.

However I don't understand the comment let by the author of bug 5549
f61a9617184ec4b24100c1d99150bfd4ebf13336

1/
> finedays is in days, so hourly loans must multiply by 24
Yes but the suspension is in days, so no need to * 24

2/ And we should have a look on this one too:
> grace period is measured in the same units as the loan
But the grace period is always in days. On the circ rules the column is
"Fine grace period (day)".
I think we should replace
  DateTime::Duration->new( $unit => $issuingrule->{firstremind} );
with
  DateTime::Duration->new( days => $issuingrule->{firstremind} );

Anyway, we definitelly need more tests in this area!

Test plan:
1/ Define an issuing rule with a unit=hour
2/ Set a suspension in days
3/ Check an item out and specify a past due date.
4/ Check the item in
5/ The patron should be debarred correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:03:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:03:16 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:19:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:19:45 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #3 from Jonathan Druart  ---
I confirm that this patch fixes bug 14375.

% sudo echo 'wait_timeout = 10' >> /etc/mysql/conf.d/koha.cnf
% more test.pl
use Modern::Perl;
use C4::Context;
my $dbh = C4::Context->dbh;
$dbh->{RaiseError} = 1;
$dbh->{PrintError} = 1;

say $dbh->do('SELECT * FROM systempreferences');

sleep 11;

$dbh = C4::Context->dbh;
say $dbh->do('SELECT * FROM systempreferences');

% git checkout master
% perl test.pl
518
DBD::mysql::db do failed: MySQL server has gone away [for Statement "SELECT *
FROM systempreferences"] at test.pl line 12.
DBD::mysql::db do failed: MySQL server has gone away [for Statement "SELECT *
FROM systempreferences"] at test.pl line 12.

% git checkout -b bug_14726; git bz apply 14726
perl test.pl
518
518

(518 prefs, really???)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:32:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:32:53 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #4 from Jonathan Druart  ---
% git checkout -b bug_14726; git bz apply 14726

read bug 14778

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:42:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:42:22 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #5 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #3)
> I confirm that this patch fixes bug 14375.

Well actually I am not sure.
I have tried again and now it passes on master and not on bug_14778.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:51:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:51:11 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #7 from Michael Kuhn  ---
Yes, I have printed the resulting barcodes.

But no, I have no barcode reader at hand, so I couldn't test if the printed
barcodes are really COOP2of5 resp. Industrial2of5. They sure look like barcodes
but to me they just don't look like I would expect the correct barcode type
2of5 to look like... The barcode numbers have just 8 digits and I think the
resulting barcode is far too long...

However, I think these barcodes should be tested with an barcode reader. I will
try to actually test them on 15 September when I'm at a library which owns an
appropriate barcode reader.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 12:54:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 10:54:23 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #6 from Jonathan Druart  ---
MariaDB [koha]> delete from aqbooksellers;

% more benchmark_bookseller.pl
#!/usr/bin/perl
use Modern::Perl;
use C4::Bookseller;
use Koha::Acquisition::Bookseller;


for my $i ( 1 .. 1000 ) {
    C4::Bookseller::AddBookseller({
        name => "name$i",
    });
}

my $booksellers = Koha::Acquisition::Bookseller->search;
Koha::Acquisition::Bookseller->search;

% git checkout master
% time perl benchmark_bookseller.pl
perl benchmark_bookseller.pl  4.89s user 0.14s system 8% cpu 1:00.42 total

MariaDB [koha]> delete from aqbooksellers;
% git checkout bug_14778
% time perl benchmark_bookseller.plt
perl benchmark_bookseller.pl  5.02s user 0.17s system 8% cpu 1:00.64 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:23:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:23:56 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #7 from Jonathan Druart  ---
Created attachment 42388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42388&action=edit
Bug 14778: Make sure the dbh returned is checked by DBIC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:24:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:24:11 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #8 from Jonathan Druart  ---
% git checkout bug_14788 # With the 2 patches
% time perl benchmark_bookseller.pl
perl benchmark_bookseller.pl  5.68s user 0.29s system 9% cpu 1:00.04 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:27:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:27:25 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #9 from Jonathan Druart  ---
I have also tried

diff --git a/Koha/Database.pm b/Koha/Database.pm
index 014554f..619ba6e 100644
--- a/Koha/Database.pm
+++ b/Koha/Database.pm
@@ -118,7 +118,10 @@ sub schema {
     my $params = shift;

     unless ( $params->{new} ) {
-        return $database->{schema} if defined $database->{schema};
+        if ( defined $database->{schema} ) {
+            $database->{schema}->storage->ensure_connected
+                and return $database->{schema};
+        }
     }

     $database->{schema} = &_new_schema();

But
% time perl benchmark_bookseller.pl
perl benchmark_bookseller.pl  7.14s user 0.18s system 11% cpu 1:03.67 total

I am not sure it is useful, DBIC certainly checks it on its side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:30:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:30:10 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #10 from Jonathan Druart  ---
Note: Encoding looks good (read/write).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:32:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:32:22 +0000
Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41887|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen  ---
Created attachment 42389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42389&action=edit
Bug 14721 - OAI-PMH must return error when no results

When getting records from OAI-PMH, an error must be returned if there is no
results.

See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions

Test plan :
- Enable OAI webservice
- Perform a query that will return no results. ie :
/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31
=> Without patch you get a response with :
   
=> With patch you get a response with error code :
   No records match the given criteria
- Check a good query returns still results
- Same test with ListIdentifiers verb

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:32:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:32:31 +0000
Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:35:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:35:45 +0000
Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without
	marcxml
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #4 from Mirko Tietgen  ---
Needs a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 13:52:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 11:52:39 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

--- Comment #17 from Olli-Antti Kivilahti  ---
Created attachment 42390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42390&action=edit
Bug 14540 - PermissionManager - Followup fix sample_patrons.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:00:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:00:39 +0000
Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items
 and biblioitems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35967|0                           |1
        is obsolete|                            |

--- Comment #14 from Olli-Antti Kivilahti  ---
Created attachment 42391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42391&action=edit
Bug 13707 - 3. Adding a new column datereceived for items and biblioitems. New
sortable Zebra index.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:19:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:19:48 +0000
Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:21:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:21:29 +0000
Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:21:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:21:45 +0000
Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:22:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:22:08 +0000
Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:37:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:37:03 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #107 from Jonathan Druart  ---
Created attachment 42392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42392&action=edit
Bug 12478: Fix error on indexing a specific record

% perl misc/search_tools/rebuild_elastic_search.pl -bn 42
Can't locate object method "idnumber" via package "MARC::Record" at
misc/search_tools/rebuild_elastic_search.pl line 171.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:37:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:37:09 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #108 from Jonathan Druart  ---
Created attachment 42393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42393&action=edit
Bug 12478: Fix encoding issues on indexing

There were encoding issues on indexing, the way to build a marc record
was the old way (retrieved from the noxml style from rebuild_zebra).

Here we should either c/p the code from C4::Biblio::GetMarcBiblio or
call it directly (what this patch does).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:37:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:37:29 +0000
Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicole at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:37:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:37:34 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Chris Nighswonger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cnighswonger at foundations.ed
                   |                            |u

--- Comment #8 from Chris Nighswonger  ---
FTR, many of the less commonly used barcode types were simply brought over from
the (very) old label code and not were not tested much at all. IIRC some of
them may have even been left in a semi-complete state, so checking to be sure
the resulting barcodes a) are actually the format they claim to be, and b)
actually produce successful scans is imperative.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:38:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:38:13 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #109 from Jonathan Druart  ---
Peter, the last patch should fix your issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:39:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:39:31 +0000
Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on
 a given record per patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 14:47:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 12:47:47 +0000
Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items
 and biblioitems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35944|0                           |1
        is obsolete|                            |

--- Comment #15 from Olli-Antti Kivilahti  ---
Created attachment 42394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42394&action=edit
Bug 13707 - 1. Adding a new column datereceived for items and biblioitems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:03:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:03:19 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #9 from Marc V?ron  ---
(In reply to Chris Nighswonger from comment #8)
> FTR, many of the less commonly used barcode types were simply brought over
> from the (very) old label code and not were not tested much at all. IIRC
> some of them may have even been left in a semi-complete state, so checking
> to be sure the resulting barcodes a) are actually the format they claim to
> be, and b) actually produce successful scans is imperative.

Chris, using this patch and changing the label dimensions (height) I could
produce barcodes that look OK for me (I compared with same barcode values found
in the internet). I suppose the problem Michael encounters is due to the hard
coded barcode height (0.01 * label height), see related Bug 14149.

That said, I would appreciate if somebody could sign off on this patch.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:09:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:09:55 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |genevieve.plantin at inlibro.c
                   |ity.org                     |om
             Status|NEW                         |Needs Signoff
                 CC|                            |charles.farmer at inlibro.com,
                   |                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |genevieve.plantin at inlibro.c
                   |                            |om,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:12:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:12:15 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42386|0                           |1
        is obsolete|                            |

--- Comment #6 from Olli-Antti Kivilahti  ---
Created attachment 42395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42395&action=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:17:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:17:08 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #1 from Genevieve Plantin  ---
Created attachment 42396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42396&action=edit
CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns

There was two missing heading columns (location and fine) and one hidden
heading missing column (this hidden column is needing for sorting the table) it
was taking the due_date column for the hidden column, so I added them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:17:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:17:13 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

Pablo AB  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

--- Comment #5 from Pablo AB  ---
Hi Jonathan!
The bug is still there in master. Now I'm using 3.20.03.000 and the I can see
the record looks good on Koha, but exporting the problem is still there. You
can look at it with the procedure of comment 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:18:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:18:56 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:21:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:21:29 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

--- Comment #2 from Marc V?ron  ---
Created attachment 42397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42397&action=edit
[Signed-off] Bug 14779 - Cannot paginate reviews

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1,
the paging at the bottom only offset by 1 entry, instead of moving a full page
(20 entries) ahead.

The simple fix uses 'page' instead of 'offset'.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

Apply patch, redo step 4-5.

With patch, paging works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:22:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:22:29 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42335|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:22:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:22:39 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:33:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:33:31 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42395|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti  ---
Created attachment 42398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42398&action=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:34:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:34:13 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:36:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:36:03 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #6 from Jonathan Druart  ---
I don't understand how you export your records.
I don't manage to get a file with a .iso2709 extension.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:43:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:43:37 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:43:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:43:39 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42397|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42399&action=edit
Bug 14779 - Cannot paginate reviews

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1,
the paging at the bottom only offset by 1 entry, instead of moving a full page
(20 entries) ahead.

The simple fix uses 'page' instead of 'offset'.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

Apply patch, redo step 4-5.

With patch, paging works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:47:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:47:50 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

--- Comment #2 from Marc V?ron  ---
Created attachment 42400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42400&action=edit
[Signed-off] Bug 14575 - OPACURLOpenInNewWindow should apply to item-level urls
too

This patch applies the OPACURLOpenInNewWindow system preference
to item-level urls (in addition to the pre-existing bib-level url
handling).

_TEST PLAN_

Before applying:

1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
2) Note that the current tab changes to that url
3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
4) Note that the current tab changes to that url

Apply the patch.

After applying:

5) Click on an item-level url
6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
should be set to "do")
7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
url
8) Note that the url opens in the current tab

9) Repeat the above steps 5-8 alternating
"TrackClicks" between "Don't track" and either "Track" or
"Track anonymously".

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:47:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:47:52 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #7 from Pablo AB  ---
- Search for books on intranet.
- Clic on Add to and save them on a list.
- Go to Home ? Lists ? Your lists 
- Clic on the list you just create
- Clic on Download list and select "iso2709"
- Save the "shelf.iso2709" file.
- On terminal, follow steps on comment 3

NOTE: An ISO2709 is *almost* the same as a "MARC file". A mrc is an iso2709
that also have some other properties, like always subfields on tags>010. To
avoid confusions maybe here template should say "MARC file" and filename should
be: ?list-.mrc?.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:50:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:50:11 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #41104|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:50:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:50:21 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:51:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:51:48 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #4 from Lari Taskula  ---
Created attachment 42401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42401&action=edit
Bug 12426: Allow resending of messages from the notices tab in the patron
account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=XXXXX" where XXXXX is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::ResendMessage(123) to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:52:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:52:19 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:54:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:54:20 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:54:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:54:22 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39910|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 42402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42402&action=edit
Bug 14343 Incorrect links to results pages in Receive Shipment List

Numbered links have incorrect url. Links to result pages
don't work in Receive Shipment List (but fortunately, Next
and Previous buttons work) It's because the booksellerid is
not furnished in the url.

Test Plan :
1) Go to Acquisitions module, enter a bookseller name that you
   know you can get many page of invoices for and search for it.

2) click on Receive shipment button.

3) On bottom of the first results page, click on page number 2
   link. (cf joined screencast)

You'll see that the results include invoices from other
booksellerid. Indeed, I suppose that you get results from all booksellerid.

Intall patch and redo 3 steps.

NOTE: I did not follow this test plan.
      I read the acqui/parcels.pl code.
      The template parameter numbers is assigned in a function which has
      no reference to booksellerid at all!
      Additionally, the booksellerid is set directly elsewhere.
      It is also strange that the booksellerid references before and after
      this loop do not use the numbers.booksellerid, but just booksellerid.
      The change from numbers.booksellerid to booksellerid is correct!

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:54:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:54:25 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

--- Comment #9 from Jonathan Druart  ---
Created attachment 42403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42403&action=edit
Bug 14343: Remove the DT pagination

It does not make sense to have 2 paginations here.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:54:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:54:46 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:57:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:57:22 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_14786=5D_New=3A__Use_text_=C2=ABMARC?=
 =?utf-8?q?_file=C2=BB_instead_of_=C2=ABISO2709=C2=BB_everywhere?=
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786

            Bug ID: 14786
           Summary: Use text ?MARC file? instead of ?ISO2709? everywhere
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

An ISO2709 is *almost* the same as a "MARC file". A mrc is an iso2709 that also
have some other properties, like always subfields on tags>010. To avoid
confusions on lists template should say "MARC file" and filename should be:
?list-.mrc?, instead of shelf.iso2709.

Notice that everywhere in Koha we use MARC instead of ISO2709. For eg, on
Home?Tools?MARC export or in ?Home?Tools?Stage MARC records for import?.

Related bugs: 2172, 11997.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:58:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:58:05 +0000
Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:58:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:58:08 +0000
Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42389|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42404&action=edit
Bug 14721 - OAI-PMH must return error when no results

When getting records from OAI-PMH, an error must be returned if there is no
results.

See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions

Test plan :
- Enable OAI webservice
- Perform a query that will return no results. ie :
/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31
=> Without patch you get a response with :
   
=> With patch you get a response with error code :
   No records match the given criteria
- Check a good query returns still results
- Same test with ListIdentifiers verb

Signed-off-by: Mirko Tietgen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 15:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 13:59:34 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #8 from Pablo AB  ---
Just created bug 14786 about this terminological issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:02:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:02:01 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:02:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:02:19 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42400|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 42405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42405&action=edit
Bug 14575 - OPACURLOpenInNewWindow should apply to item-level urls too

This patch applies the OPACURLOpenInNewWindow system preference
to item-level urls (in addition to the pre-existing bib-level url
handling).

_TEST PLAN_

Before applying:

1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
2) Note that the current tab changes to that url
3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
4) Note that the current tab changes to that url

Apply the patch.

After applying:

5) Click on an item-level url
6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
should be set to "do")
7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
url
8) Note that the url opens in the current tab

9) Repeat the above steps 5-8 alternating
"TrackClicks" between "Don't track" and either "Track" or
"Track anonymously".

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:02:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:02:17 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:05:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:05:08 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #5 from Marc V?ron  ---
Lari, is the first patch obsolete?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:05:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:05:56 +0000
Subject: [Koha-bugs] [Bug 14787] New: Allow confirm/continue option to circ
 warnings at checkout
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

            Bug ID: 14787
           Summary: Allow confirm/continue option to circ warnings at
                    checkout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be great if we offered an option to say 'yes' or 'confirm' to warnings
at checkout (like patron owes too much are you sure) and then have it remember
for the session so you don't have to click that every item you check out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:06:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:06:37 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #110 from Peter Zhao  ---
(In reply to Jonathan Druart from comment #109)
> Peter, the last patch should fix your issue.

Jonathan, it works well. Thanks a lot.  ES indexing and Opac works wonderful.

But in staff interface when I input non-latin words  (e.g. Chinese) to search
(search the catalog), it shows "Software error:Cannot decode string with wide
characters at /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215. For help,
please send mail to the webmaster (webmaster at koha), giving this error message
and the time and date of the error. "


If I input English words, it can show results, but when I click the record, it
shows "The record you requested does not exist ()."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:07:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:07:08 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42346|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:10:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:10:26 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #6 from Lari Taskula  ---
Marc, yes! Sorry, I forgot to do that. I made some modifications by Jonathan's
wish.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:22:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:22:33 +0000
Subject: [Koha-bugs] [Bug 14788] New: Move opac-topissues.pl code into
	C4::Circulation
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

            Bug ID: 14788
           Summary: Move opac-topissues.pl code into C4::Circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Move opac-topissues.pl code into C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:23:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:23:27 +0000
Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into
	C4::Circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

--- Comment #1 from Julian Maurice  ---
Created attachment 42406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42406&action=edit
Bug 14788: Move opac-topissues.pl code into C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:23:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:23:28 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:23:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:23:31 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

--- Comment #4 from Jonathan Druart  ---
Created attachment 42407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42407&action=edit
Bug 14575: Fix OPACURLOpenInNewWindow

There are some type fixed with this patch.

This patch creates a TT var "target" to avoid c/p links.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:23:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:23:35 +0000
Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into
	C4::Circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:23:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:23:53 +0000
Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42047|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice  ---
Created attachment 42408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42408&action=edit
Bug 14749: Add API route /v1/topissues

See Swagger specification for documentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:24:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:24:47 +0000
Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to
 item-level urls too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart  ---
Well, I am stealing this bug report. I have found bugs on opac-detail, some
links don't open in a new tab/window.
It was caused by a typo in the pref name.

Please add a signoff on this second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:25:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:25:16 +0000
Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into
	C4::Circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14749


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749
[Bug 14749] Add API route to get top issues
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:25:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:25:16 +0000
Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14788

--- Comment #4 from Julian Maurice  ---
Bug split to separate the refactoring of opac-topissues.pl (bug 14788) from the
new API route


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788
[Bug 14788] Move opac-topissues.pl code into C4::Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:28:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:28:13 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #9 from Jonathan Druart  ---
Looks good here:

200 1  $a Une F?te? ? ? ? ? ? ? monstre  test3 $f St?phanie Laslett $g
ill. Nigel MacMullen $b LIVR $? ?????????????????????????? $?
??????????????????????????

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:29:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:29:36 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #10 from Jonathan Druart  ---
% yaz-iconv -f latin1 -t utf8 shelf.iso2709 > shelf.iso2709-utf
% yaz-marcdump shelf.iso2709-utf | grep 200
200 1  $a Une F??te?? ?? ?? ?? ?? ?? ?? monstre  test3 $f St??phanie
Laslett $g ill. Nigel MacMullen $b LIVR $?
?????????????????????????????????????????

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:30:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:30:54 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #111 from Jonathan Druart  ---
I haven't focused on the intranet side yet :)
I have found an error this morning: you cannot access the detail page from the
result page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:36:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:36:49 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #11 from Jonathan Druart  ---
tested on master and 3.20.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:38:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:38:08 +0000
Subject: [Koha-bugs] [Bug 14789] New: TemaTres integration
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14789

            Bug ID: 14789
           Summary: TemaTres integration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

TemaTres is an open source vocabulary server, web application to manage and
exploit vocabularies, thesauri, taxonomies and formal representations of
knowledge. The main goal is to add some of the TemaTres features into Koha.

RFC already created:
http://wiki.koha-community.org/wiki/TemaTres_integration_RFC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:38:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:38:11 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 16:52:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 14:52:17 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42401|0                           |1
        is obsolete|                            |

--- Comment #7 from Lari Taskula  ---
Created attachment 42409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42409&action=edit
Bug 12426: Allow resending of messages from the notices tab in the patron
account

Changed return value of ResendMessage() to 1 on success, otherwise 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:23:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:23:03 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41535|0                           |1
        is obsolete|                            |
  Attachment #42390|0                           |1
        is obsolete|                            |

--- Comment #18 from Olli-Antti Kivilahti  ---
Created attachment 42410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42410&action=edit
Bug 14540 - Move member-flags.pl to PermissionsManager to better manage
permissions for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:48 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:49 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41873|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:51 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41874|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:55 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41876|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:53 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41875|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:56 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41877|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:42:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:42:58 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41878|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:00 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41879|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:02 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41880|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:03 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41881|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:23 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #35 from Marcel de Rooy  ---
Created attachment 42411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42411&action=edit
Bug 14321: Add two columns to uploaded_files

This patch adds uploaded_files.public and permanent.
Public will be used later to mark uploaded files as available via OPAC.
Permanent will be used to make the distinction between temporary and
permanent storage.

The db rev sets both flags for all current records (uploaded via the
plugin from BZ 6874).

Test plan:
[1] If you tested this before, drop the column public first.
[1] Run the dbrev.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:34 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #37 from Marcel de Rooy  ---
Created attachment 42413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42413&action=edit
Bug 14321: Integrate Upload.pm into Koha

This patch makes the following changes to achieve that:
[1] Use Upload.pm in stage-marc-import.pl, upload-cover-image.pl,
    offline_circ/process_koc.pl and enqueue_koc.pl.
[2] A new file-upload.js replaces file-upload.inc in the associated template.
    We now use ajax to get progress figures instead of launching perl script
    upload-file-progress.
    The js changes now also allow for aborting a file upload.
[3] Adds a tools/upload script and template. It allows to upload multiple
    files at once.
[4] Makes upload-file return error messages in JSON. For a multiple upload,
    we could have some files with errors and others without errors.
    The upload is now marked as Failed only if there was no upload at all.
[5] The upload plugin is converted to use tools/upload with plugin param.
    Deleting an upload is now presented via the search results form.

NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was
hidden and no longer used (with associated code in process_koc.pl). When a
file has been uploaded, I display the form again (with the Apply directly
button). The code still works.

NOTE: We fix an error in upload-file from one of the patches of bug 6874.
The userid of the Koha admin user is passed to haspermission, but we
should pick the userid from the session.

NOTE: Bug 14686 will add a specific permission for tools/upload.pl, and
will add the tools/upload script to the Tools menu.
For now, you need edit_catalogue to start upload.pl and you will
additionally need a permission like upload_local_cover_images
to successfully upload a new file.

Test plan:
[1] Upload a marc file in stage-marc-import. (This is temp storage.)
[2] Check new entry in table uploaded_files. Look for the file in your
    temporary directory (/tmp ?), subfolder koha_upload.
    Bonus: Remove permissions on this subfolder. Retry, check error and
    restore permissions again.
[3] Upload another (larger) file and abort the upload. Check table and
    directory again. You should have a partial file, but no record.
[4] Verify that Stage for import still works as expected.
[5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can
    test an individual image or a zip file including images and a file
    called datalink.txt (with lines biblionumber,filename).
[6] Test uploading a offline circulation file:
    Enable AllowOfflineCirculation, and create a koc file (plain text):
    Line1: Version=1.0\tA=1\tB=2
    Line2: 2015-08-06 08:00:00 345\treturn\t[barcode]
    Note: Replace tabs and barcode. The number of tabs is essential!
    Checkout the item with your barcode.
    Go to Offline circulation file upload. Upload and click Apply directly.
    Checkout again. Upload again, click Add to offline circulation queue.
[7] Upload three files via tools/upload.pl with a category and marked as
    public. Check the results in the table.
    Verify that you can download the file in OPAC without being logged in.
[8] Pick one new file and one of the files of step 7. Upload them in the
    same category. One upload should succeed. Check for reported error.
[9] Connect upload.pl to field 856$u.
    Goto Cataloguing editor.
    In an empty 856$u, click the tag editor. Upload a file and click Choose.
    Save the record. Open the record in the OPAC and click the link.
    Copy this link to your clipboard for next step.
[A] Go back to editor. Click the tag editor on the same 856 field.
    Choose for Delete.
    Open the link in your clipboard again. Error message?
[B] Check the process of upload, search, download and delete of an upload
    with some diacritical characters in the filename. (Bonus points for
    adding special chars in the category code.)
    Note: You can add categories via authorized values, UPLOAD key.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:30 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #36 from Marcel de Rooy  ---
Created attachment 42412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42412&action=edit
Bug 14321: Introduce Koha::Upload

This patch introduces Koha::Upload. It will replace the modules
C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874).
It also includes a new unit test.

NOTE: This unit test will replace the test for UploadedFiles.pm. It will no
longer use dependency Test::CGI::Multipart. We are now mocking CGI and its
hook to achieve the same result.

Test plan:
[1] Run t/db_dependent/Upload.t.
    Note that if you see a WARNING, you will still need to add an entry
    upload_path to your koha-conf.xml. Or you need to give write
    permission to your Koha instance user for that folder.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:38 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #38 from Marcel de Rooy  ---
Created attachment 42414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42414&action=edit
Bug 14321: Final cleanup, removing obsolete files

The new Upload.pm, unit test and file-upload.js obsolete a number of
files, including an older jQuery plugin.
The test files progressbar.pl and progressbarsubmit.pl are outdated and
do not serve any purpose in this form. (Actually, we could argue if they
should be here or just be part of a debugging phase.)

Test plan:
[1] Git grep on file-progress, file-upload.inc, UploadedFile,
    ajaxfileupload, ajaxFileUpload
    UploadedFile: Only a reference to DBIx file is found
    ajaxfileupload: Only release notes
[2] Upload a file with tools/upload and stage-marc-import.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:43:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:43:51 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:44:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:44:33 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko.tietgen at student.hu-be
                   |                            |rlin.de,
                   |                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 17:54:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 15:54:08 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Zeno Tajoli  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 18:04:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 16:04:42 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #39 from Marcel de Rooy  ---
Mirko: I rearranged the patches and as you will see, the test plan on the third
patch is the crux now (you will recognize it).
Apart from reorganizing, I added a permanent column to make life easier in
relation to public and category. Also added an extra test for search results
(get).
HTH

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 18:48:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 16:48:29 +0000
Subject: [Koha-bugs] [Bug 14790] New: Link to OPAC view from within
 subscriptions, search and item editor
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790

            Bug ID: 14790
           Summary: Link to OPAC view from within subscriptions, search
                    and item editor
 Change sponsored?: Sponsored
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: jweaver at bywatersolutions.com
          Reporter: jweaver at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nicole at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 19:04:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 17:04:56 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

--- Comment #17 from Olli-Antti Kivilahti  ---
Created attachment 42415
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42415&action=edit
Comparing two Exception::Class approaches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 20:35:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 18:35:34 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #127 from Jesse Weaver  ---
(In reply to Katrin Fischer from comment #126)
> Comment on attachment 42373 [details] [review]
> Bug 11559: (followup) Prevent saving item tags, fix other issues
> 
> I feel like removing the whole 999 in case of MARC21 is too generious - I'd
> feel better if only the subfields for biblionumber and biblioitemnumber
> would be removed.

This is how Add/ModBiblio work regardless; I have it remove all of the 999s
because _koha_marc_update_bib_ids, the function they both use, assumes there's
0 or 1 and doesn't correctly update any others if there's 2 or more. (That's a
bug of its own, but anyway...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 20:57:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 18:57:21 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #12 from Pablo AB  ---
Well, not in my case. I tried on different Kohas, all using MARC 21. Maybe (I
don't think so) have something to do with the fact that my records have
newlines in it. Bug 11388.
More tests: First on MySQL directly:
 
  Qu?mica : 

$ yaz-marcdump bib-2087.utf8 bib-13459.utf8 | grep "^245"
245 00 $a Qui?mica :  $b una ciencia experimental /  [...]
245 00 $a Estudio experimental de dispersio?n de [...]

$ yaz-marcdump shelf.iso2709 | grep "^245"
245 00 $a Qu?mica :  $b una ciencia experimental /  [...]

[Notice here second record is missing. If my list have only one record above
command throw no output.]

$ yaz-iconv -f latin1 -t utf8 shelf.iso2709 > shelf.iso2709-utf

$ yaz-marcdump shelf.iso2709-utf | grep "^245"
245 00 $a Qu?mica :  $b una ciencia experimental /  [...]
245 00 $a Estudio experimental de dispersi?n de [...]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 21:53:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 19:53:00 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #128 from H?ctor Eduardo Castro Avalos  ---
(In reply to Christopher Davis from comment #120)
> Anyone care to reply to comment 115? I think that step 15 of the test plan
> is referring to Koha authorized values (Home>Administration>Authorized
> values) and not authorized access points from the authority file. Your
> thoughts?
> 
> Thanks

Yep there aren't a modal, pop-up, or, single-dropdown widgets to get
authorities linked to bib record.

Maybe when typing $9 or $0, in theory, should appear something to link our
authorities in 1XX, 6XX, 7XX, and, 8XX fields

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 22:44:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 20:44:11 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

--- Comment #2 from Genevieve Plantin  ---
Created attachment 42416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42416&action=edit
CAM 2145 - Bug 14744 - Fix select guarantor when quote in one of the fields

The quote was wrapping the onclick attribute of the select, so i have replaced
all of the quotes in borrower data (only for this section) by ' (single
quote for html)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 22:53:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 20:53:51 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

--- Comment #3 from Genevieve Plantin  ---
Created attachment 42417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42417&action=edit
CAM 2145 - Bug 14744 - Fix window closing when selecting a guarantor

After slecting a guarantor, the window was not closing.

Some parts of the form in the user_select function are not defined yet, so the
JavaScript was crashing when it encounters the undefined form fields preventing
it from closing the window. I only had if conditions to prevent the script form
bugging and to close the window.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 22:54:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 20:54:40 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |genevieve.plantin at inlibro.c
                   |                            |om
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 23:05:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 21:05:20 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #31 from Tom?s Cohen Arazi  ---
(In reply to M. Tompsett from comment #30)
> (In reply to Kyle M Hall from comment #29)
> > Shouldn't 10589 be a dependency rather than a blocker?
> 
> It's kind of both. These are the tests for 10589, but right now, 10589 and
> potentially this bug may need restructuring, because I'm going to take out
> the one offending line of code in 10589 and change the GetHiddenItems call
> to take a hash parameter.
> 
> I'll move this to In Discussion, since 10589 and this are so related. If it
> ends up unchanged, I'll switch it back to PassedQA. If, however, it changes,
> I'll post the change, and change it to Needs Signoff.

?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  4 23:17:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Sep 2015 21:17:03 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #32 from M. Tompsett  ---
Haven't gotten back to this and bug 10589. Given the nature of the fix required
for 10589, I may end up moving this to 10589, and closing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 08:19:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 06:19:29 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #8 from Marc V?ron  ---
Created attachment 42418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42418&action=edit
[Signed-off] Bug 12426: Allow resending of messages from the notices tab in the
patron account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=XXXXX" where XXXXX is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::ResendMessage(123) to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 08:19:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 06:19:50 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42409|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 08:19:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 06:19:58 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 09:05:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 07:05:41 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

--- Comment #4 from Marc V?ron  ---
Created attachment 42419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42419&action=edit
Quotes from guarantor fields show up encoded in patrons address fields

If I select a gaurantor displayed encoded with quotes in the address fields,
the patron's address fields are populated with encoded values.

---
BTW: Is it a feature or a bug that the patron main address is changed to the
guarantor's main address? (That happens already before applying the patches).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 16:41:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 14:41:42 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master
                 CC|                            |veron at veron.ch

--- Comment #1 from Marc V?ron  ---
Same on current master, I can not search after username (userid).

Switching version from 1.18 to master (hope that is OK).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 16:58:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 14:58:34 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

--- Comment #2 from Marc V?ron  ---
Created attachment 42420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42420&action=edit
Bug 14782 - Add possibility to search patrons using the username (userid)

This patch makes it possible to search for users using the username (userid /
login name).

To test:

- Apply patch
- Do searches from Home > Patrons
- Search after a full username or parts of a username with Search fields =
Standard and Search fields = Userid
- Perform the searches from the top bar (expand with [+]) and from the
"Filters" part at the left
- Make sure that other searches behave as before

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 17:00:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 15:00:33 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 18:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 16:25:02 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #6 from Nick Clemens  ---
Created attachment 42421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42421&action=edit
Obsoleted patch copied from bug 12911

I tried my best to find a workaround on top of my patches, but couldn't make
anything work.  Requiring items to be added before assigning a batch number
meant I would have needed to create a placeholder item to get an id.  Thomas'
patches on 12911 did just that.  You can push up the batch number by creating a
new batch and never adding to it, but that seems okay

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 19:23:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 17:23:56 +0000
Subject: [Koha-bugs] [Bug 14379] Batch item modification tool - Can't change
 custom subfields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379

bondiurbano  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costalc at gmail.com

--- Comment #2 from bondiurbano  ---
It also can not be changed the subfield $1 (lost status) which is a standard
Koha subfield. See image attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  5 19:25:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Sep 2015 17:25:18 +0000
Subject: [Koha-bugs] [Bug 14379] Batch item modification tool - Can't change
 custom subfields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379

--- Comment #3 from bondiurbano  ---
Created attachment 42422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42422&action=edit
Subfield $1 is missing in Batch Item Modification process

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 17:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 15:27:12 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron  ---
Additionally, there is a link to the "selfcheck" user's account ("Welcome,
selfcheck"), as defined in syspref AutoSelfCheckID. It makes no sense that the
user can access this information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 18:47:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 16:47:37 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

--- Comment #3 from Marc V?ron  ---
...and the language menu is missing if syspref OpacLangSelectorMode is set to
'top' or to 'both'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:08:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:08:21 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:09:03 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

--- Comment #4 from Marc V?ron  ---
Created attachment 42423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42423&action=edit
Bug 14776 - Remove 'selfcheck' patron related links from and add language
selector to SCO header

The SCO screen displays patron related menu items in it's header (Link to the
account and "Logout").
This makes no sense since the patron that is logged in is the 'selfcheck' user
as defined in syspref AutoSelfCheckId.
Additionally, the language menue is missing when the syspref
OpacLangSelectorMode is set to 'top' or to 'both'.

To test:
- Set AutoSelfCheck sysprefs as appropriate
- Set OpacLangSelectorMode to 'top' or 'both'
- Go to SCO page
- Verify that the language menue does not display in the header
- Enter a card number to check out (this logs in the SCO user)
- Verify that you get text similar to "Welcome, checkout" with a link to the
sco user's account in the OPAC and a 'Logout' link
- Apply patch
- Verify that the language menu appears and the SCO user's information
disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:09:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:09:45 +0000
Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects
 to OPAC, not back to SCO
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:21:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:21:55 +0000
Subject: [Koha-bugs] [Bug 10598] self check shouldn't link out to catalog
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron  ---
I can not reproduce the issue on current master (3.21.00.022)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:48:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:48:18 +0000
Subject: [Koha-bugs] [Bug 2688] Z39.50 should report connection failures
 even if some succeeded
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2688

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron  ---
Is this bug still valid?

I tried a search with two invalid servers and a valid one. The results
reported:


Connection failed to fjk?fasjfjksa
Connection failed to sfdfsdfsd

...plus the results from the valid server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 19:57:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 17:57:11 +0000
Subject: [Koha-bugs] [Bug 3716] Sorting Labels for printing by barcode.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3716

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
            Version|rel_3_0                     |master

--- Comment #1 from Marc V?ron  ---
Still valid on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 20:02:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 18:02:14 +0000
Subject: [Koha-bugs] [Bug 8754] Cardnumber/accession number range when
 creating print batches in tools
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
          Component|Tools                       |Label/patron card printing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 20:05:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 18:05:01 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?=
 =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?=
 =?utf-8?q?youts?=
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #1 from Marc V?ron  ---
Still valid on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 20:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 18:07:35 +0000
Subject: [Koha-bugs] [Bug 12020] label-edit-batch has hardcoded error
	messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 20:09:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 18:09:34 +0000
Subject: [Koha-bugs] [Bug 14369] don't allow labels on staged records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 23:30:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 21:30:33 +0000
Subject: [Koha-bugs] [Bug 14777] OPAC shows no result found
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14777

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer  ---
Please try asking on the mailing list as this is most likely a problem specific
to your installation. Please include information about the version you
installed how you installed it and what you tried in order to get the search
working.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  6 23:57:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Sep 2015 21:57:06 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer  ---
This basically works, but 2 small glitches:

- When returning the item without the proper configuration, the warning message
is shown, but the item still appears in the table below, even tho it was not
checked in. It shows as: Not checked out. I think it should show an error and
not appear in the table, as it has not been checked in.

- The error message is not ideal - I think you can't say 'a privacy':
Error: This patron has requested a privacy on returning item but the
AnonymousPatron pref is not set correctly.

Suggestion:
This patron has requested their circulation history be anonymized on check-in,
but the AnonymousPatron system preference is not set correctly.

It's also showing on checkout, so would have to be changed in 2 places.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 03:44:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 01:44:27 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

--- Comment #1 from Winona Salesky  ---
Created attachment 42424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42424&action=edit
Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set
to 1.

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff view.
3) Find or create a record with MARC tags 942$n=1
4) Check for ?Suppressed in OPAC? at the top of the results div and at the top
of the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 03:46:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 01:46:13 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

--- Comment #2 from Winona Salesky  ---
942 is wrapped with id="suppressed_opac" to make individual styling possible. 


(In reply to Winona Salesky from comment #1)
> Created attachment 42424 [details] [review]
> Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is
> set to 1.
> 
> Test Plan:
> 1) Apply this patch
> 2) Ensure you are using the default XSLT setting for the staff view.
> 3) Find or create a record with MARC tags 942$n=1
> 4) Check for ?Suppressed in OPAC? at the top of the results div and at the
> top of the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 07:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 05:55:25 +0000
Subject: [Koha-bugs] [Bug 14789] TemaTres integration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14789

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 08:15:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 06:15:57 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #74 from Srdjan Jankovic  ---
Created attachment 42425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42425&action=edit
Bug 11213: Fix mixing Koha::Database and C4::Context->dbh in test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 08:25:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 06:25:51 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #75 from Srdjan Jankovic  ---
I believe it is very wrong to mix KOha::Database and C4::Context->dbh based
tests. Those should be separated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 09:24:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 07:24:05 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Comment on attachment 42424
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42424
Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set
to 1.

Hi Winona,

can you please use a class instead of an id for the result lists as the element
can show up there repeatedly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 10:08:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 08:08:55 +0000
Subject: [Koha-bugs] [Bug 14012] Koha::FTP,
 a happy FTP-library to supercharge FTP operations.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 10:33:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 08:33:05 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42398|0                           |1
        is obsolete|                            |

--- Comment #8 from Olli-Antti Kivilahti  ---
Created attachment 42426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42426&action=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

Fixed a missing PerlDependency.

TEST PLAN:

1. Run "perl installer/data/mysql/atomicupdate.pl --help"
2. Read the code.
3. git bz apply some bugs which introduce atomicupdates, or cook your own
4. Deploy the atomicupdates using the atomicupdate.pl-script.
5. Repeat steps 3-4 to your heart's content.
6+. Understand the code and come up with improvement ideas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 10:40:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 08:40:43 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 10:40:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 08:40:43 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14698


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698
[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a
database
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:14:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:14:24 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41762|0                           |1
        is obsolete|                            |

--- Comment #50 from Julian Maurice  ---
Created attachment 42427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42427&action=edit
Bug 7957: Routing lists enhancements

Rebased on master
Call to AddReserve updated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:14:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:14:34 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41763|0                           |1
        is obsolete|                            |

--- Comment #51 from Julian Maurice  ---
Created attachment 42428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42428&action=edit
Bug 7957: Add unit tests for new subroutines

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:14:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:14:48 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41764|0                           |1
        is obsolete|                            |

--- Comment #52 from Julian Maurice  ---
Created attachment 42429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42429&action=edit
Bug 7957: Redirect after creating a new routing list

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:15:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:15:30 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14539


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539
[Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from
various input types
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:15:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:15:30 +0000
Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(),
 aka. make a Koha::Object from various input types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14698


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698
[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a
database
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:15:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:15:30 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:39:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:39:25 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #79 from Koha Team Lyon 3  ---
Sorry to be very late, I missed your question in comment 75.
The isocode had to furnished in currencies table in order the whole thing to
work whenever the prices string includes the isocode form.
If you are sure that all your prices will only use the symbol form, it's ok but
I doubt it could be always true. So I had made it required when entering data
in table currencies.
It could be left optionnal, but at least 2 things would have to be added :
1) Resetting an isocode column in the currencies table : now, you have to click
the edit button to be aware of the existence of an isocode parameter, I think
this column must appear anyway.
2) Indicating clearly in the legend that the isocode data is required for
prices string that include it.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:39:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:39:26 +0000
Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample
	files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146
Bug 12146 depends on bug 9593, which changed state.

Bug 9593 Summary: Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:55:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:55:16 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #80 from Katrin Fischer  ---
I think it would be better to discuss any changes on a new bug report - as this
is already in released versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 11:55:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 09:55:17 +0000
Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample
	files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146
Bug 12146 depends on bug 9593, which changed state.

Bug 9593 Summary: Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 12:51:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 10:51:57 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42108|0                           |1
        is obsolete|                            |

--- Comment #17 from Lari Taskula  ---
Created attachment 42430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42430&action=edit
Bug 13906 - TestObjectFactoreis squashables

Fixed File::Fu::File version from PerlDependencies, 0.08 => 0.0.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:17:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:17:37 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #76 from M. Tompsett  ---
I'm wondering if perhaps it should be something more like:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334#c0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:39:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:39:20 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:42:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:42:52 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:42:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:42:56 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36706|0                           |1
        is obsolete|                            |

--- Comment #11 from Tom?s Cohen Arazi  ---
Created attachment 42431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42431&action=edit
[SIGNED OFF] Bug 13805: Disable syspref cache - Plack

When going to the installer (without the DB structure), you have to log
twice before starting the installation.

Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
Without this patch, you will get the login form again.
With this patch, you can start the installation

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:44:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:44:54 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |julian.fiol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:45:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:45:07 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:48:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:48:43 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
  Attachment #42342|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:48:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:48:51 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42343|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 15:49:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 13:49:00 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42344|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:28:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:28:01 +0000
Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #19 from Tom?s Cohen Arazi  ---
Patches pusehd to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:28:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:28:40 +0000
Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links
 for other branches' items in staff detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:29:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:29:12 +0000
Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:29:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:29:33 +0000
Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode)
 in acquisitions is broken
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #16 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:29:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:29:59 +0000
Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Good catch Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:30:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:30:24 +0000
Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should
 fallback to biblio-level if no item-level itemtype
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Tom?s Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:31:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:31:24 +0000
Subject: [Koha-bugs] [Bug 14766] Complete cataloguing plugin
	unimarc_field_4XX
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #8 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Paul!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:31:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:31:49 +0000
Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Goood job Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:32:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:32:26 +0000
Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #29 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Good job Jonathan!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:34:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:34:36 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #13 from Tom?s Cohen Arazi  ---
I see problems with this patch:

- It forgets to add to queryparser.yml
- It adds to the QueryParser test code, but the numbers look weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:50:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:50:51 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #21 from Tom?s Cohen Arazi  ---
Barton, there is no need to touch record.abs (not blocker) but you are missing
the queryparser.yaml file in your patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:57:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:57:26 +0000
Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching
	rules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Amit!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:57:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:57:50 +0000
Subject: [Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Blou!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:58:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:58:38 +0000
Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test,
	when using koha-shell
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Mason!

Note: I didn't reproduce the problem, but I agree with the change and it
doesn't break tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:59:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:59:02 +0000
Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Blou!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 16:59:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 14:59:29 +0000
Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Good catch Jonathan and Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:00:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:00:00 +0000
Subject: [Koha-bugs] [Bug 14343] Links to results pages don't work in
 Receive Shipment list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Lyon3 Team!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:00:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:00:24 +0000
Subject: [Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown
 when created from Patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #16 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:04:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:04:00 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:11:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:11:44 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by
	branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #32 from Tom?s Cohen Arazi  ---
Could you please rebase and fix the small conflict ASAP?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:12:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:12:47 +0000
Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #39 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:13:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:13:08 +0000
Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle
 serialization format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #16 from Tom?s Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:13:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:13:30 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:14:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:14:01 +0000
Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course
 reserves list for items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:15:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:15:50 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

--- Comment #19 from Olli-Antti Kivilahti  ---
Created attachment 42432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42432&action=edit
Bug 14540 - Followup regression test for bad login

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:16:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:16:38 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42136|0                           |1
        is obsolete|                            |

--- Comment #18 from Olli-Antti Kivilahti  ---
Created attachment 42433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42433&action=edit
Bug 14536 - PageObject squashable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:27:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:27:02 +0000
Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be
	sorted
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi  ---
Patch pushed to master.

Thanks Lari! And congratulations for your commit!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:27:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:27:26 +0000
Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #11 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Joonas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:28:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:28:18 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42432|0                           |1
        is obsolete|                            |

--- Comment #20 from Olli-Antti Kivilahti  ---
Created attachment 42434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42434&action=edit
Bug 14540 - Followup regression test for bad login

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:28:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:28:40 +0000
Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42433|0                           |1
        is obsolete|                            |

--- Comment #19 from Olli-Antti Kivilahti  ---
Created attachment 42435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42435&action=edit
Bug 14536 - PageObject squashable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:33:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:33:07 +0000
Subject: [Koha-bugs] [Bug 14791] New: Automatically attempt to resend failed
	notices
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

            Bug ID: 14791
           Summary: Automatically attempt to resend failed notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larit at student.uef.fi
        QA Contact: testopia at bugs.koha-community.org

Sometimes notices keep failing due to problems in network and they should be
resent. Last week in my local library we experienced some network trouble and
plenty of messages went into failed status. This can also be somewhat risky by
manual SQL queries in production environment. 

Bug 12426 introduces a subroutine C4::Letters::ResendMessage($message_id) for
resending failed messages.

Problem is that if we run this kind of feature as cronjob, we can end up in an
infinite loop of sending the same messages over and over again and they will
never be sent because of missing/invalid to_address or smsalertnumber. However,
Bug 14590 focuses on setting valid messaging preferences for all users. With
the feature presented in Bug 14590 we can assume that all notifications will
have proper messaging preferences. 

If we do not want to rely on Bug 14590:

Another option would be to track messages that we already attempted to resend.
We could try to resend each failed message for lets say 5 times each time
increasing the time between last attempt. Once the message has been attempted
to send 5 times, we will stop our attempts to resend it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 17:36:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 15:36:36 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

--- Comment #4 from Winona Salesky  ---
Created attachment 42436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42436&action=edit
Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set
to 1. Changed id="suppressed_opac" to class="suppressed_opac".

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff view.
3) Find or create a record with MARC tags 942$n=1
4) Check for ?Suppressed in OPAC? at the top of the results div and at the top
of the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 18:46:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 16:46:50 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42259|0                           |1
        is obsolete|                            |

--- Comment #26 from Eivin Giske Skaaren  ---
Created attachment 42437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42437&action=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 18:48:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 16:48:49 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42437|0                           |1
        is obsolete|                            |

--- Comment #27 from Eivin Giske Skaaren  ---
Created attachment 42438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42438&action=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

Remove one more code whitespace cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 18:51:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 16:51:13 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #28 from Eivin Giske Skaaren  ---
I think the readability is not better when it is very inconsistent but I have
restored the original inconsistencies :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 18:55:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 16:55:07 +0000
Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are
 referred to an on-site checkout
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

--- Comment #22 from bondiurbano  ---
Thanks to all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 19:13:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 17:13:27 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #81 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Good job Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 19:13:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 17:13:59 +0000
Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #50 from Tom?s Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 19:27:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 17:27:04 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tom?s Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #11 from Tom?s Cohen Arazi  ---
Jonathan. Everything looks good to me. Can we mark it "Needs signoff"? I added
Galen and Kyle to the CC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 20:44:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 18:44:35 +0000
Subject: [Koha-bugs] [Bug 12530] Remove "reserves" column from
 "items"/"deleteditems" tables if no longer used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12530

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 21:36:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 19:36:36 +0000
Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on
 Issues (Print Page) (Print Slip)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 21:46:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 19:46:40 +0000
Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing and Circulation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:07:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:07:52 +0000
Subject: [Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when
 decreaseLoanHighHoldsValue is set to 0.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548

Eivin Giske Skaaren  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |eivin at sysmystic.com
                   |ity.org                     |
                 CC|                            |eivin at sysmystic.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:14:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:14:28 +0000
Subject: [Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:25:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:25:11 +0000
Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #18 from Katrin Fischer  ---
I confirmed the linktracker update works correctly, to test:
- Activate TrackClicks
- Catalog an URL each in 856 and in 952$u
- Open each link in the OPAC
- Move item
- Check linktracker table: item link will have moved, record level link did not

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:26:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:26:02 +0000
Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:26:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:26:05 +0000
Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41078|0                           |1
        is obsolete|                            |
  Attachment #41079|0                           |1
        is obsolete|                            |
  Attachment #41080|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer  ---
Created attachment 42439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42439&action=edit
[PASSED QA] Bug 8723: Cover the existing behavior

This patch cover the MoveItemFromBiblio subroutine

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:26:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:26:12 +0000
Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #20 from Katrin Fischer  ---
Created attachment 42440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42440&action=edit
[PASSED QA] Bug 8723: Update the reserves table for item-level holds

If an item is moved from a biblio to another, the holds should be
updated too.

See discussion on the bug report for more information.

Test plan:
1/ Place a item-level hold on biblio1
2/ Move the item to biblio2
3/ Confirm that the hold still exists and point to the biblio2

This patch should not change the existing behavior for bib-level holds.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:26:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:26:16 +0000
Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #21 from Katrin Fischer  ---
Created attachment 42441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42441&action=edit
[PASSED QA] Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker
tables

Same as previous patch for 3 other tables.

Test plan:
Same as before but the hold should exist to the 3 tables before the
move.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 22:38:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 20:38:21 +0000
Subject: [Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when
 decreaseLoanHighHoldsValue is set to 0.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548

--- Comment #1 from Eivin Giske Skaaren  ---
Created attachment 42442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42442&action=edit
Bug 13548: "High Holds" does not behave correctly when
decreaseLoanHighHoldsValue is set to 0.

This solves the problem since there was a boolean check that evaluated to false
because of the 0.

To test:

1. Apply patch.
2. Enable decreaseLoanHighHolds and set decreaseLoanHighHoldsValue to 0.
3. Check out an item without holds and see that the behaviour is now correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:08:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:08:21 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to 'editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make patron attributes      |Make patron attributes
                   |editable in the opac if set |editable in the opac if set
                   |to be visible               |to 'editable in OPAC'
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:08:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:08:46 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to 'editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:09:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:09:02 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to 'editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:18:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:18:01 +0000
Subject: [Koha-bugs] [Bug 14785] Allow On Shelf Holds is not Available in
	3.20
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14785

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Hi Jerwyn - it's not been removed, but improved :) Instead of one global
setting it's now part of the circulation conditions as a new options there that
you can set differently for each rule.

The visibility of the "place hold" button in the result list has been affected,
but will hopefully be restored at some point (see bug 5786)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:20:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:20:15 +0000
Subject: [Koha-bugs] [Bug 14792] New: Fix visibility check for 'place holds'
 link in OPAC result list
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

            Bug ID: 14792
           Summary: Fix visibility check for 'place holds' link in OPAC
                    result list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, srdjan at catalyst.net.nz,
                    tomascohen at gmail.com

The 'place hold' link shows, even when no items are holdable. 
This is a side effect of the changes from 5786 and should be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:20:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:20:29 +0000
Subject: [Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link
 in OPAC result list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |5786


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786
[Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the
Circulation Matrix
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:20:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:20:29 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14792


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792
[Bug 14792] Fix visibility check for 'place holds' link in OPAC result list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:21:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:21:48 +0000
Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:26:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:26:51 +0000
Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

--- Comment #6 from Katrin Fischer  ---
I've added a missing .
The patch would be a little nicer, if there was a nice message for 'already on
loan' - but this works, as it no longer checks the item in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:30:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:30:25 +0000
Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:30:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:30:28 +0000
Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41435|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer  ---
Created attachment 42443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42443&action=edit
[PASSED QA] Bug 10005: Inventory - Add an option to not check in items

The inventory tools automatically check in items, this patch adds it as
an option.

Test plan:
1/ Check an item out, fill a file with its barcode, and use this file in
the inventory tools.
2/ Check the new checkbox and confirm that the item is not checked in
3/ Repeat again and don't check it, the behavior should be the same as before
this patch.

Signed-off-by: Jason Robb 
Signed-off-by: Katrin Fischer 
Added a missing .
Patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:33:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:33:33 +0000
Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
I have some problems with the conflict in the test files - can you please take
a look? If I just fix the number of tests, I get some output like this:

bumblebee:~/kohaclone (14155-ilsdi|AM 1/1) $ perl t/db_dependent/Reserves.t 
1..71
ok 1 - use C4::Reserves;
"my" variable $title masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 85.
"my" variable $title masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 98.
"my" variable $bibitemnum masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 98.
...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  7 23:36:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 21:36:19 +0000
Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid
 is now deleted record will fail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 01:32:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 23:32:59 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #77 from Srdjan Jankovic  ---
(In reply to M. Tompsett from comment #76)
> I'm wondering if perhaps it should be something more like:
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334#c0

In general I second the idea. I would have done it in a slightly different way
(global $schema and only one txn_begin), but that's not important. Would that
guarantee safe mixing with modules that use Koha::Database?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 01:46:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 23:46:18 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

bondiurbano  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costalc at gmail.com

--- Comment #7 from bondiurbano  ---
Also "Select", "Select all", "Select none" checkbox and links are missing. See
attached image.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 01:47:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 23:47:23 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

bondiurbano  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costalc at gmail.com

--- Comment #10 from bondiurbano  ---
Created attachment 42444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42444&action=edit
Selection links are missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 01:49:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Sep 2015 23:49:28 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #8 from bondiurbano  ---
Created attachment 42445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42445&action=edit
Selection links are missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:13:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:13:26 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|Medium patch                |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:13:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:13:32 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #16 from David Cook  ---
Created attachment 42446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42446&action=edit
Bug 10662 - Build OAI-PMH Harvesting Client

This patch set adds an OAI-PMH harvesting client to Koha.

It provides a user interface (UI) for defining external
servers from which to harvest records using the OAI-PMH
protocol.

After it downloads records, it checks the harvest database
to see if it needs to add a new record, update an
existing record, or delete a record in Koha.

_TEST PLAN_

1) Apply all patches
2) Run updatedatabase.pl (to apply the atomic update)

3) Go to Administration > OAI-PMH servers
4) Click "New OAI-PMH server target"
5) At a minimum, include a valid "Base URL" and a valid "Metadata prefix".
6) Click "Test HTTP and OAI-PMH parameters"
7) If successful, continue with this plan. If unsuccessful, address
the warning messages displayed in red before testing the parameters
again.

8) At this point, you might want to choose a preferred granularity.
All OAI-PMH servers must support YYYY-MM-DD according to the spec,
but in practice this isn't always the case, so you may need to choose
a more particular granularity (note that this support isn't tested
using the "Test" button).
9) You may also want to choose a "From" and "Until" range, at least
for the purposes of testing, so that you don't accidentally try
downloading thousands or millions of records. (You may also
want to download by "Set".)

10) You must set the "Active" parameter to "Active" from "Inactive"
for the harvester to work on this server target.
11) Optionally, you may provide a path to a XSLT to transform
the incoming data. There is a parameter called "identifier"
which is passed to the XSLT engine. This contains the unique
OAI-PMH identifier for a record. You may wish to add this to the
MARC, especially for the sake of provenance. (You may also
want to strip 952, 942, and 999 fields, as well as $9 subfields
from incoming records. You may also try the magic "default" keyword
here which uses a XSLT I've already written and linked in the
backend.)

12) Choose the MARC framework you would like to use (although
Default is fine as well).

13) Optionally, you may wish to include a "Original system field".
At this time, this has no real purpose. However, in the future,
it may be used for linking downloaded holdings records with
their original parent record. (e.g. the 004 of a holdings record
would link to the 001 of the bibliographic record). This field
uses the format of 001 or 999$c with the dollar sign as a subfield
delimiter.

14) Click Save
15) You will now see a table containing your entry; click "View".
16) All the numbers on the following screen should be 0.

--

17) Set your environmental variables for KOHA_CONF and PERL5LIB
18) Run "perl /misc/cronjobs/oai/oai_harvester.pl -d -v" to download
your records (NOTE: This downloader will run as long as it needs to,
so try to only download a few records. Ctrl+C will stop the harvest
if it gets out of control.)
19) Revisit the web app as per step #15
20) It should now say "Harvested records waiting to be imported: X"
with X being higher than 0.
21) Run "perl /misc/cronjobs/oai/oai_harvester.pl -i -v" to import
these records into Koha.
22) The terminal output should indicate the result of the import.
This should also be reflected by the webapp as per step #15
(e.g. "Koha records created from harvested records: X").

--

Now, there are a few different scenarios to try:

If you control the OAI-PMH repository, try editing a record you've
downloaded, and try downloading records again (it might be necessary to
change your "From" entry as this should be auto-updated after each
harvest), and seeing if your Koha record is updated. If your repository
also supports deleted records, try deleting a record that you've
already imported into Koha. Koha should get a deletion notice
and delete the record from Koha (unless it has items attached).

If you delete a record from Koha, but that record still exists
upstream, you'll still download updates for that record,
but an error will be generated when trying to import into Koha.
Each record in this "error" state will be recorded in the "View"
section of the UI as "Harvested records in an error state: X".
(In the future, I might make it so that the record gets re-added,
or add more configuration options to control this behaviour.)

If you want to reset the respository harvest (ie delete all
your existing harvested records and re-harvest a repository),
click "Reset repository harvest" in the "View" screen of
the OAI-PMH server target. If errors are encountered while
deleting an existing harvest, it should display hyperlinks
to the problem records for manual intervention.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:15:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:15:30 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42446|0                           |1
        is obsolete|                            |

--- Comment #17 from David Cook  ---
Created attachment 42447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42447&action=edit
Bug 10662 - Build OAI-PMH Harvesting Client

This patch set adds an OAI-PMH harvesting client to Koha.

It provides a user interface (UI) for defining external
servers from which to harvest records using the OAI-PMH
protocol.

After it downloads records, it checks the harvest database
to see if it needs to add a new record, update an
existing record, or delete a record in Koha.

_TEST PLAN_

1) Apply all patches
2) Run updatedatabase.pl (to apply the atomic update)

3) Go to Administration > OAI-PMH servers
4) Click "New OAI-PMH server target"
5) At a minimum, include a valid "Base URL" and a valid "Metadata prefix".
6) Click "Test HTTP and OAI-PMH parameters"
7) If successful, continue with this plan. If unsuccessful, address
the warning messages displayed in red before testing the parameters
again.

8) At this point, you might want to choose a preferred granularity.
All OAI-PMH servers must support YYYY-MM-DD according to the spec,
but in practice this isn't always the case, so you may need to choose
a more particular granularity (note that this support isn't tested
using the "Test" button).
9) You may also want to choose a "From" and "Until" range, at least
for the purposes of testing, so that you don't accidentally try
downloading thousands or millions of records. (You may also
want to download by "Set".)

10) You must set the "Active" parameter to "Active" from "Inactive"
for the harvester to work on this server target.
11) Optionally, you may provide a path to a XSLT to transform
the incoming data. There is a parameter called "identifier"
which is passed to the XSLT engine. This contains the unique
OAI-PMH identifier for a record. You may wish to add this to the
MARC, especially for the sake of provenance. (You may also
want to strip 952, 942, and 999 fields, as well as $9 subfields
from incoming records. You may also try the magic "default" keyword
here which uses a XSLT I've already written and linked in the
backend.)

12) Choose the MARC framework you would like to use (although
Default is fine as well).

13) Optionally, you may wish to include a "Original system field".
At this time, this has no real purpose. However, in the future,
it may be used for linking downloaded holdings records with
their original parent record. (e.g. the 004 of a holdings record
would link to the 001 of the bibliographic record). This field
uses the format of 001 or 999$c with the dollar sign as a subfield
delimiter.

14) Click Save
15) You will now see a table containing your entry; click "View".
16) All the numbers on the following screen should be 0.

--

17) Set your environmental variables for KOHA_CONF and PERL5LIB
18) Run "perl /misc/cronjobs/oai/oai_harvester.pl -d -v" to download
your records (NOTE: This downloader will run as long as it needs to,
so try to only download a few records. Ctrl+C will stop the harvest
if it gets out of control.)
19) Revisit the web app as per step #15
20) It should now say "Harvested records waiting to be imported: X"
with X being higher than 0.
21) Run "perl /misc/cronjobs/oai/oai_harvester.pl -i -v" to import
these records into Koha.
22) The terminal output should indicate the result of the import.
This should also be reflected by the webapp as per step #15
(e.g. "Koha records created from harvested records: X").

--

Now, there are a few different scenarios to try:

If you control the OAI-PMH repository, try editing a record you've
downloaded, and try downloading records again (it might be necessary to
change your "From" entry as this should be auto-updated after each
harvest), and seeing if your Koha record is updated. If your repository
also supports deleted records, try deleting a record that you've
already imported into Koha. Koha should get a deletion notice
and delete the record from Koha (unless it has items attached).

If you delete a record from Koha, but that record still exists
upstream, you'll still download updates for that record,
but an error will be generated when trying to import into Koha.
Each record in this "error" state will be recorded in the "View"
section of the UI as "Harvested records in an error state: X".
(In the future, I might make it so that the record gets re-added,
or add more configuration options to control this behaviour.)

If you want to reset the respository harvest (ie delete all
your existing harvested records and re-harvest a repository),
click "Reset repository harvest" in the "View" screen of
the OAI-PMH server target. If errors are encountered while
deleting an existing harvest, it should display hyperlinks
to the problem records for manual intervention.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:15:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:15:37 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #18 from David Cook  ---
Created attachment 42448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42448&action=edit
Bug 10662 - DBIx::Class ResultSets for Testing

This patch adds the DBIx::Class ResultSets for testing. These are
necessary in order for the main OAI-PMH harvester patch to work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:42:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:42:15 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #19 from David Cook  ---
Hi all!

I've finally got something up for testing, so please everyone take some time to
test it out. So much has changed since I first started working on this back in
2013, but hopefully it should provide all the functionality that you need.

I'm sure that the user interface could use more attention, so I'd love to
receive feedback on that.

I'd also love to hear back about how the feature works. The key component is
the "oai_harvester.pl" cronjob, which will be set up by a system administrator.
I don't think there's much that a web user can do to affect that, although I
have seen other bugs talking about giving web users control over scheduling
tasks. I think web users controlling scheduling would be outside the scope of
this bug.

Unlike the "Staged MARC Management", there is currently no way of un-importing
and re-importing. You can only "reset repository harvest", which will delete
all currently harvested records and allow you to schedule a new re-harvest.
While I originally was going to leverage the "Staged MARC Management" code, I
decided that giving web users control over selectively un-importing and
re-importing batches of records harvested via OAI-PMH could be really
problematic. That is, you might un-import a batch which deletes 10 records,
import a new batch which contains those 10 records, then try to re-import an
earlier batch of those 10 records. Even if the (optional) record matching rules
were set up perfectly, your Koha records would be wrong; they'd be for an older
version of the upstream record. I decided that once a record was added to Koha
- all further updates and deletions should be automatic. And if a record was
deleted from Koha (other than by "resetting the harvest"), then it could not be
re-added; it will instead generate an error (since you can't currently
"undelete" a bibliographic record or re-add it with the same biblionumber).
However, I'm happy to discuss options for handling records that have been
deleted from Koha. There is code that checks if the record has been deleted in
Koha, so it would be trivial to add a new record with a new biblionumber,
although I'd have to update some other code which expects a unique OAI-PMH
identifier to be tied to only 1 Koha biblionumber whereas in this case it would
have 2 or more.

In fact, I'm happy to discuss every part of this code. 

Some of you might be interested in improving performance. At the moment, the
"oai_harvester.pl" runs synchronously, which means that first all the records
need to be downloaded into the database, and then all the records need to be
processed and imported into Koha. For initial imports or large imports, this
takes hours. However, I've recently gained a lot of experience using POE (Perl
Object Environment). Using POE, I could presumably write an asynchronous
program which could import records as they're received, rather than waiting for
the entire harvest to complete. Unfortunately, POE was removed from Koha's
dependencies in the past year or so, but I don't think it would be problematic
to add it to the dependencies once again. 

--

Despite me posting these patches, the work isn't done yet. 

A keen observer will note that there is a lack of consistency in naming. I
sometimes say "oai_client", "oai_server", "oai_target", "oai repository". It's
not always exactly clear what I mean, even though I know what I mean. I want to
be clear in differentiating this feature from Koha's OAI-PMH server as well. I
would be receptive to comments about preferred terminology in both the backend
and the web app.

Additionally, I also need to do the following:

1) Add unit tests
2) Revise the embedded POD in the code
3) Add help pages (and possibly hints/tips in the templates for web users)

I'm going to hold off on these 3 tasks for the moment until we get further into
the testing. Otherwise they'll just need to be revised again after more code
iterations. (That said, it would have been smart to have written unit tests
from the beginning as I built up the code. Alas. Next time.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 05:58:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 03:58:29 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #11 from Marc V?ron  ---
(In reply to bondiurbano from comment #10)
> Created attachment 42444 [details]
> Selection links are missing

Thanks for testing, bondiurbano.

I suppose you wanted to create pateron cards, not labels?

This problem is already described in: 
Bug 14123 - Patroncard: Patron search for batch no longer has Select / Select
All / Add selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123

See attachment 14123: 
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38773

However, our bug 14781 is about creating labels, not patron cards:
Tools > Labels home > Manage label

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 06:07:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 04:07:42 +0000
Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no
 longer has Select / Select All / Add selected
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14744

--- Comment #6 from Marc V?ron  ---
(In reply to Shane Sammons from comment #4)
(...)
> Another thing I wanted to add, as it might be related to this bug, is when
> we do edit batch and tried adding anyone with an apostrophe (like O'Leary)
> in the name would not add at all. 
(...)
For the apostrophe (quote) problem, see Bug 14744 as well, it could be related.
(it's about picking a patron from a datatable).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 06:07:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 04:07:42 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14123

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 06:22:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 04:22:02 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1 - high                   |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 09:27:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 07:27:11 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #5 from Julian Maurice  ---
Created attachment 42449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42449&action=edit
Bug 14699: Show number of selected searches in search history

With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 09:27:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 07:27:40 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 09:39:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 07:39:25 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41782|0                           |1
        is obsolete|                            |

--- Comment #12 from Julian Maurice  ---
Created attachment 42450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42450&action=edit
Bug 12460: Allow to start a new search from multiple search history lines

Rebased on top of bug 14699

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 09:56:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 07:56:40 +0000
Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of
	"Expected"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Janet McGowan  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 09:58:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 07:58:10 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Janet McGowan  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 11:42:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 09:42:07 +0000
Subject: [Koha-bugs] [Bug 14793] New: New cataloguing plugin
	unimarc_field_225a_bis
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793

            Bug ID: 14793
           Summary: New cataloguing plugin unimarc_field_225a_bis
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: new feature
          Priority: P5 - low
         Component: Cataloging
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

New cataloguing plugin unimarc_field_225a_bis

It is similar to unimarc_field_210c_bis, but searches in
biblioitems.collectiontitle instead of biblioitems.publishercode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 11:42:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 09:42:33 +0000
Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin
	unimarc_field_225a_bis
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793

--- Comment #1 from Julian Maurice  ---
Created attachment 42451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42451&action=edit
Bug 14793: New cataloguing plugin unimarc_field_225a_bis

It is similar to unimarc_field_210c_bis, but searches in
biblioitems.collectiontitle instead of biblioitems.publishercode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 11:42:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 09:42:46 +0000
Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin
	unimarc_field_225a_bis
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 11:53:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 09:53:16 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

claire.hernandez at biblibre.com  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 12:08:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 10:08:47 +0000
Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 12:26:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 10:26:42 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

--- Comment #1 from Lari Taskula  ---
(In reply to Lari Taskula from comment #0)
> Last week in my local library we experienced some network trouble
> and plenty of messages went into failed status. This can also be somewhat
> risky by manual SQL queries in production environment. 

Long day. What I meant to say was that currently the only way to resend failed
messages without Bug 12426 is via manual database UPDATE queries to set them
back into "pending" status, and this leaves some chance for it to go horribly
wrong.

Anyway, I also though of a third option. We could use Koha::Exceptions
introduced in Bug 13995 to throw an exception to C4::Letters in case of a
connection failure. C4::Letters would catch this exception and leave the
message in the queue untouched. In other words, the message would stay in
pending status and would be attempted to send again by
process_message_queue.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 12:29:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 10:29:16 +0000
Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 12:29:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 10:29:18 +0000
Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

--- Comment #2 from Joonas Kylm?l?  ---
Created attachment 42452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42452&action=edit
Bug 14773: Move help link back out of the dropdown menu

This moves the help link back out of the dropdown menu
like it used to be.

To test:

1. Notice that in intra the help link is inside the dropdown
   menu.
2. Apply the patch
3. Notice that the help link is now clearly visible in the
   top right corner of the page.

Sponsored-by: Vaara-kirjastot

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:02:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:02:54 +0000
Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not
	functional
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #12 from bondiurbano  ---
Sorry Marc, yesterday I was testing bug 14739 and it seems I've made a mistake.
Really do not know how I could did it. I beg you discard my comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:05:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:05:44 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
	status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Tom Misilo  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:34:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:34:10 +0000
Subject: [Koha-bugs] [Bug 14794] New: Searching patron by birthday is slow /
 never gives a result
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

            Bug ID: 14794
           Summary: Searching patron by birthday is slow / never gives a
                    result
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When searching patrons by patrons' birthday in staff side (Home ? Patrons &
choose search field Date of Birth), it seems like the web page gives never an
answer to the user. It just keeps showing that "Processing..." thingie.

So this happened when I gave only the day and month of the full birth day / or
if I gave only the year of the birthday. With the full xx/xx/xxxx form it
works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:38:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:38:38 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42384|0                           |1
        is obsolete|                            |

--- Comment #11 from Lari Taskula  ---
Created attachment 42453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42453&action=edit
Bug 14723 - Additional delivery notes to messages

Added unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:41:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:41:03 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 13:41:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 11:41:06 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42420|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylm?l?  ---
Created attachment 42454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42454&action=edit
Bug 14782 - Add possibility to search patrons using the username (userid)

This patch makes it possible to search for users using the username (userid /
login name).

To test:

- Apply patch
- Do searches from Home > Patrons
- Search after a full username or parts of a username with Search fields =
Standard and Search fields = Userid
- Perform the searches from the top bar (expand with [+]) and from the
"Filters" part at the left
- Make sure that other searches behave as before

Signed-off-by: Joonas Kylm?l? 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:09:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:09:06 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com

--- Comment #5 from Joonas Kylm?l?  ---
Not sure if I'm right but I think there has been at least 2 similar bug reports
to this but I couldn't find them now... Anyways, there has been already
discussion about some general fix for this (and If I remember right there is
already some work done). The fix where the work has been done was not that far
away from coming to master (maybe couple of months) but there was also another
idea to wait ~2 years until template toolkit's newer version comes to different
GNU/Linux distros (and it fixes the problem).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:12:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:12:04 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42453|0                           |1
        is obsolete|                            |

--- Comment #12 from Lari Taskula  ---
Created attachment 42455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42455&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:18:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:18:47 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14505

--- Comment #6 from Joonas Kylm?l?  ---
It was Bug 14505 where there was discussion about this kind of bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:18:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:18:47 +0000
Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print
 routing list window to not appear
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14744

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:25:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:25:39 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14691

--- Comment #7 from Marc V?ron  ---
...and Bug 14691 - Can't delete patron with ' character in cardnumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:25:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:25:39 +0000
Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in
	cardnumber
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14744

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:48:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:48:57 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #142 from Olli-Antti Kivilahti  ---
Hi there!

We cannot push this bug to master without also pushing Bugs 13920 and Bug
14748.
Bug 14748 doesn't need to be implemented like I implemented it, but we must
have a established and formal way of doing the complete authentication,
permission checking and formal enforced testing, before unleashing this monster
to master.

If we push just this Bug, people will start creating features on top of this
one, and then we will lose the opportunity to integrate automatic documentation
driven permission checking and a formal testing framework (which simplifies
test writing a lot).
It will be much harder to include them later on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 14:56:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 12:56:10 +0000
Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 15:09:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 13:09:21 +0000
Subject: [Koha-bugs] [Bug 14795] New: Batch record modification tool removes
 framework code
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795

            Bug ID: 14795
           Summary: Batch record modification tool removes framework code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Steps:
- Create any template on Tools > Manage MARC modification templates
- Go to Tools > Batch record modification
- Apply modification to any biblionumber you choose.

Result: The process removes frameworkcode, so Default framework is use. On
MySQL table the column  for eg changes from frameworkcode="BKS" to
frameworkcode="".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 15:32:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 13:32:47 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42107|0                           |1
        is obsolete|                            |

--- Comment #13 from Lari Taskula  ---
Created attachment 42456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42456&action=edit
Bug 14620 - Contact information validations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 15:47:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 13:47:56 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41991|0                           |1
        is obsolete|                            |

--- Comment #10 from Lari Taskula  ---
Created attachment 42457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42457&action=edit
Bug 14590 - Checkboxes should be disabled without valid contact information in
messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 18:27:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 16:27:05 +0000
Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one
	of the fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 18:27:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 16:27:22 +0000
Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print
 routing list window to not appear
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 18:48:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 16:48:30 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           Severity|enhancement                 |minor

--- Comment #1 from Marc V?ron  ---
I did following tests:

Set datefomat syspref to dd/mm/yyy

Do a search from the header section on Home  > Patrons
Expand search option with [+]
Select "Date of birth"
A small hint appears explaining that dates should be entered as DD/MM/YYYY
Select "Contains"
Search for 16/09/1946  (I have one patron with this birth date)
Result OK

Do the same with "Starts with"
Result OK

Do the same with 16/09
Do the same with 16.09.1946
Result (for both): 
Software error: The given date (16.09.1946) does not match the date format
(metric) at /usr/share/kohaclone/Koha/DateUtils.pm line 144.

Repeat search in the filter section at the left:
Select "Date of birth" (No hint about format appears)
Search for 16/09/1946
Result OK

Do the same with 16/09 or 16.09.1946
Result: Data table appears with endless "Processing..." as described by Joonas

Setting importance to "Minor" (The component mostly works, but causes some
irritation to users.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 19:09:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 17:09:16 +0000
Subject: [Koha-bugs] [Bug 14796] New: zebra returns error code 114
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14796

            Bug ID: 14796
           Summary: zebra returns error code 114
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: wwwretive at yahoo.fr
        QA Contact: testopia at bugs.koha-community.org

Created attachment 42458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42458&action=edit
koha-rebuild-zebra output

Search did not work anymore with recently acquired items but
it was OK for old ones; i updated koha from version 3.18.9 to version 3.18.10,
but now the search doesn't work for any of the items.

It doesn't work for a general search neither for a particular
search (title, author, etc)

The format of the database is unimarc.

When i look at the zebrasrv logs it says 

zebrasrv(1) e0489cb5 [request] Search biblios ERROR 114 1 1+0 RPN @attrset
Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 social

I tried the yaz client directly, it says :

# yaz-client -c /etc/koha/zebradb/ccl.properties 
unix:/var/run/koha/laretive/bibliosocket
Connecting...OK.
Sent initrequest.
Connection accepted by v3 target.
ID     : 81
Name   : Zebra Information Server/GFS/YAZ
Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031
Options: search present delSet triggerResourceCtrl scan sort extendedServices
namedResultSets
Elapsed: 0.004361
Z> base biblios
Z> f social
Sent searchRequest.
Received SearchResponse.
Search was a bloomin' failure.
Number of hits: 0, setno 1
Result Set Status: none
records returned: 0
Diagnostic message(s) from database:
    [114] Unsupported Use attribute -- v2 addinfo 'any'

I did koha-rebuild-zebra but that didn't help (output is attached)

Any help will be appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 20:13:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 18:13:29 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #2 from Genevieve Plantin  ---
Created attachment 42459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42459&action=edit
CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts
table in check out patron page

Theres was two missing heading columns Location and Fines in the Check out
section of a Patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 20:54:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 18:54:23 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14794

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 20:54:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 18:54:23 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13601

--- Comment #2 from Marc V?ron  ---
For the case of the search at the left (endless 'Processing'):

It dies inside a call to dt_from_string($searchmember) in
svc/members/search, line 51

For the search from the header, it dies dies inside a call to
dt_from_string($searchmember) in
members/member.pl , line 70

dt_from_string  dies in Koha/DateUtils.pm at line 144 if it does not get a
valid date string (in the current syspref format or in the iso format).

I think that this part of dt_from_string should go to a separate sub.
See 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601#c27

It could then be used for pre-testing date strings from user inputs like the
ones in this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 20:55:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 18:55:20 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14794

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 20:55:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 18:55:20 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12072

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  8 21:37:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 19:37:31 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
	status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 00:09:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Sep 2015 22:09:18 +0000
Subject: [Koha-bugs] [Bug 14796] zebra returns error code 114
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14796

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Phiippe, 
I think this could be a configuration issue. I recommend asking your question
on the mailing list as not a lot of people are checking on the newly filed bug
reports and you will probably receive more help there.

A good place to start looking is the About > System information tab in your
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 06:14:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 04:14:48 +0000
Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and
 UsageStatsLibraryType from free text to a dropdown list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #7 from M. Tompsett  ---
There is no atomic update perl script which attempts to match the list to
ensure it is in the drop down data set, because an upgrade won't necessarily be
in the list. Isn't this a problem?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 08:00:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 06:00:34 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42396|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron  ---
Created attachment 42460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42460&action=edit
CAM 2146 - Bug 13781 - Fix relatives's checkouts missing heading columns

There was two missing heading columns (location and fine) and one hidden
heading missing column (this hidden column is needing for sorting the table) it
was taking the due_date column for the hidden column, so I added them

Both patches tested together. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 08:02:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 06:02:53 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 08:03:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 06:03:09 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42459|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc V?ron  ---
Created attachment 42461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42461&action=edit
CAM 2146 - Bug 13781 - Fix missing heading columns for relative's checkouts
table in check out patron page

Theres was two missing heading columns Location and Fines in the Check out
section of a Patron

Tested both patches together. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 11:19:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 09:19:12 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #143 from Julian Maurice  ---
Yes, we can, and we should, as we agreed on that during the previous dev
meeting.
It's better to have a tiny patch in master than a big, full-featured patch that
will never be pushed because of its complexity.
And the API key authentication system needs some discussion, as some people
disagree with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 11:53:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 09:53:44 +0000
Subject: [Koha-bugs] [Bug 5837] Change installer to use
 DBIx::Class::Schema::Versioned instead of updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5837

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #6 from Olli-Antti Kivilahti  ---
Hi there!
Can you share the code you have been working on here as commits?
I am not asking for anything "git bz apply":able, just something to read your
thoughts from.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 11:53:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 09:53:53 +0000
Subject: [Koha-bugs] [Bug 11390] DBIx::Class schema deployment script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #12 from Olli-Antti Kivilahti  ---
Hi there!
Can you share the code you have been working on here as commits?
I am not asking for anything "git bz apply":able, just something to read your
thoughts from.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 14:40:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 12:40:46 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #14 from Marc V?ron  ---
Created attachment 42462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42462&action=edit
[Signed-off] Bug 14620 - Contact information validations

I'm thinking we should centralize all patron's contact information validators
into one module. Currently we only have validations for e-mail addresses, using
the Email::Valid module. In our local library we also want to validate phone
numbers with a regex that only recognizes phone numbers from my country. So I
suggest we create a phone number validation as well, with an option to easily
create custom regex for your local use.

If a library does not wish to use validations, we should give them an option to
turn them off. If more local validators are implemented, we should also give
the library an option to select which validator they wish to use.

With this method we could implement phone number validators from around the
world and add them into our module. Then we would make the validations simply
by calling our validator. The validator would know by system preference which
one of the implemented phone number validators it should use.

Validations should be both client and server side.

Test plan:
1. Apply the patches (and run updatedatabase.pl).
2. Set system preferences ValidateEmailAddress to "Enable" and
ValidatePhoneNumber to "International Phone Numbers".
3. Make sure JavaScript is enabled.
4. Navigate to edit user contact informations in Staff client and OPAC.
5. Clear email and phone fields.
6. Insert whitespaces to email and phone fields and submit the form.
7. Edit patron.
8. Observe that there are no longer whitespaces in email and phone fields.
9. Insert invalid email (e.g. "invalid") and invalid phone number
("+123invalid") and send the form.
10. Confirm that form will not be submitted and errors will be given.
11. Disable JavaScript.
12. Insert invalid email and invalid phone number
13. Try sending the form again.
14. Confirm that form will be submitted but errors will be given on top of the
form.
15. Observe that none of the changes are accepted.
16. Set system preferences ValidateEmailAddress to "Disable" and
ValidatePhoneNumber to "none".
17. Repeat step 3-9 but observe that errors will not be given and changes will
be submitted and saved.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 14:41:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 12:41:10 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42456|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:04:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:04:18 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:04:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:04:18 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:09:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:09:28 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

--- Comment #2 from Lari Taskula  ---
Created attachment 42463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42463&action=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Sometimes notices keep failing due to various reasons. One common problem
is network connection failures. Because of this, the notices go into
'failed' status without another attempt for sending. This is very problematic,
because we have to not only monitor the failed messages but also resend
them manually. The purpose of this patch is to move us into more automated
way of handling delivery failures.

This patch enables us to handle exceptions in SMS messaging. The main idea
is to throw an exception from SMS::Send driver in case of a failure.
The exception will be caught by C4::SMS and from here it will be forwarded
to C4::Letters where instead of automatically setting the message into
'failed' status, we now can do as we wish with various exceptions.

As an example I have caught Koha::Exception::ConnectionFailed in
C4::Letters::_send_message_by_sms(). When we catch the said exception,
we simply leave the message in 'pending' status.  This way it will be resent
whenever process_message_queue.pl is executed again.

There are multiple other reasons of failure where Exceptions will come
in handy. For example the SMS Gateway provider may return some errors
at request, and with this patch we will be able to handle them better.

Below is a short example for making your SMS::Send driver throw an
exception in case of a connection failure in SMS/Send/MyDriver/Driver.pm.

_______________________________________________________________
use Koha::Exception::ConnectionFailed;

sub send_sms {
    #.....your implementation.....

    # Throw an exception in case of a connection error
    # $connError can be for example: ($curl->{'retcode'} == 6)
    # cURL code 6: CURLE_COULDNT_RESOLVE_HOST
    if ($connError){
        Koha::Exception::ConnectionFailed->throw(error => "Connection failed");
    }

    #.....your implementation.....
}
_______________________________________________________________

prerequisites:
-2. Set system preference SMSSendDriver to Example::ExceptionExample
-1. Enable system preference EnhancedMessagingPreferences

To test:
1. Have/create some pending sms messages into message_queue
2. Go to Patrons -> Notices
3. Observe that the your message is in pending status
4. Apply patch
5. Run misc/cronjob/process_message_queue.pl
6. Observe that your message is still in pending status

You can also test it with your own implementation of SMSSendDriver.
What you need to do is follow the example mentioned earlier to make
send_sms() subroutine throw Koha::Exception::ConnectionFailed
in case of a connection failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:11:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:11:22 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:11:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:11:35 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

--- Comment #11 from Marc V?ron  ---
Created attachment 42464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42464&action=edit
[Signed-off] Bug 14590 - Checkboxes should be disabled without valid contact
information in messaging preferences

This patch makes both client and server side validations, both in OPAC and
Staff client.

Followed test plan (comment #9), works as expected
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:12:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:12:05 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:12:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:12:35 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42457|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:13:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:13:14 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:21:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:21:36 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:21:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:21:38 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42463|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula  ---
Created attachment 42465
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42465&action=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:22:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:22:45 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14723,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:22:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:22:45 +0000
Subject: [Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway
	provider reports
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:22:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:22:45 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:23:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:23:19 +0000
Subject: [Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway
	provider reports
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14723

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:23:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:23:19 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:36:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:36:51 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14767


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767
[Bug 14767] Message delivery notes from SMS Gateway provider reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 15:36:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 13:36:51 +0000
Subject: [Koha-bugs] [Bug 14767] Message delivery notes from SMS Gateway
	provider reports
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14791

--- Comment #1 from Lari Taskula  ---
A more detailed explanation for the reports and delivery notes.

Our SMS Gateway provider has a two-step delivery success response. When sending
the HTTP request from our SMS::Send driver, our SMS Gateway provider will
immediately respond if the message is placed for delivery OR the following
error messages:
 - unknown error
 - invalid recipient (phone# syntax is invalid)
 - duplicate recipient (same phone# is given multiple times)
 - unallowed recipient (non-mobile/foreign phone#)

This is the first step to gather delivery notes from SMS Gateway provider. With
Bug 14791 we are able to throw Exceptions from SMS::Send driver. I propose we
throw an exception (e.g. Koha::Exception::SMSDeliveryFailure) with an accurate
description of the error. The exception will be forwarded all the way to
C4::Letters::_send_message_by_sms() where we can set the status of the message
to 'failed' and add the delivery note accordingly.

However, if the initial request was successful and the provider has accepted it
for delivery, we will move to the second phase of the delivery.

Second phase occurs after the delivery is complete on the provider's end. They
will send us a request with appropriate information of the state of the
delivery and an error message if the delivery was failed. For the second phase
we should use REST API.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:01:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:01:53 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42455|0                           |1
        is obsolete|                            |

--- Comment #13 from Lari Taskula  ---
Created attachment 42466
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42466&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:02 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14791                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:02 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13995                       |14723


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:02 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:05 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42465|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula  ---
Created attachment 42467
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42467&action=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:20 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:25:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:25:20 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14791


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 16:36:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 14:36:24 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
	notices
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42467|0                           |1
        is obsolete|                            |

--- Comment #5 from Lari Taskula  ---
Created attachment 42468
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42468&action=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Added 1 more test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 17:40:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 15:40:27 +0000
Subject: [Koha-bugs] [Bug 14797] New: Cancelling orders with no alert to
	existing holds
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

            Bug ID: 14797
           Summary: Cancelling orders with no alert to existing holds
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fiona.borthwick at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When AcqCreateItem is set to create an item when placing an order, this allows
holds to be placed on on-order items.  When an order is then cancelled, there
is no alert to existing holds.

When the order is cancelled, there is still a link to the hold against the bib
record but the Holds screen in the bib record states that you cannot place
holds as no item exists.  As a result, you cannot cancel the hold from this
screen nor can library staff see the patron details to inform them.

As a workaround, they can add a new temporary item to allow them to delete the
hold but it would be good to have an alert appearing on screen at the point of
cancelling the order (via the Delete Order link in the Basket) so that the link
to the hold record could be broken first.

Workflow to reproduce:

- Set AcqCreateItem to 'placing an order'.
- From the Acquisitions screen, select a vendor, create a new basket and add an
order to this basket.
- As the system preference is set to add the item, fill out all the relevant -
item information as well as other acq info.
- Once saved, create a hold for a patron
- Confirm that hold is present and can be seen from the bib record
- From the open basket (so reopen if already closed), select the 'Delete Order'
link against the correct orderline.
- Enter cancellation reason and click Yes.

Order is then cancelled but there was no alert about the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 17:40:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 15:40:32 +0000
Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing
	holds
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797

Fiona Borthwick  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 17:40:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 15:40:57 +0000
Subject: [Koha-bugs] [Bug 14796] zebra returns error code 114
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14796

philippe michel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from philippe michel  ---
thanks for the tip, i found out that i had to switch from grs to dom indexing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 19:07:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 17:07:34 +0000
Subject: [Koha-bugs] [Bug 14798] New: Renew and checkin do not update parts
 of checkout page
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798

            Bug ID: 14798
           Summary: Renew and checkin do not update parts of checkout page
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: arm at hanover.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When the checkout table is updated by renewing or checking in a selected item,
the page does not refresh. 
This leaves the message "Patron has ITEMS OVERDUE" in red at the top right of
the screen when actually no items are overdue.
If the item is checked in, it leave the item visible in the Checked Out items
table - with the message "checked in"

Some of this may be an intended feature, so - comments welcome!

My request is that a modification is made so that at least the ITEMS OVERDUE
message is removed once the renewals are completed.
I think in earlier versions the whole page was refreshed - checked in items
disappeared, and the Items Overdue message disappeared once the "Renew or check
in selected items" button was clicked.
Now that the table is Ajaxed, simply refreshing the entire page might have
possible unforeseen consequences that developers may need to address.

Note that you can see this effect also - if a barcode is typed into the "Enter
item barcode" box, but check out is not completed, and then you renew or
check-in an item in the checkout table, the barcode remains in the box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 20:51:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 18:51:17 +0000
Subject: [Koha-bugs] [Bug 7403] CataloguingLog warning incorrect
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 20:55:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 18:55:44 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED
                 CC|                            |nengard at gmail.com,
                   |                            |nicole at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:39:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:39:39 +0000
Subject: [Koha-bugs] [Bug 14799] New: patron catalog security
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14799

            Bug ID: 14799
           Summary: patron catalog security
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: jesse at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When a patron logs in to their account on the KOHA opac , then logs out, then
uses the back button to go back, their account information is still available.
This seems like a security issue. When a patron logs out, their information
should not be still available for anyone to see by using the back button (or
any other way).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:43:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:43:27 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
 details, after LOGOUT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #10 from Katrin Fischer  ---
*** Bug 14799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:43:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:43:27 +0000
Subject: [Koha-bugs] [Bug 14799] patron catalog security
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14799

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 5371 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:45:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:45:16 +0000
Subject: [Koha-bugs] [Bug 13466] Changing language does not work
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13466

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Mirko, are you still seeing this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:47:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:47:36 +0000
Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:49:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:49:10 +0000
Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

--- Comment #2 from Heather Braum  ---
I'm glad to see someone working on this; I was about to file a bug that records
with a 260 field returns with a Publisher: line but records with 264 fields do
not return with a Publisher: line in the staff xslt search results. 

It looks your work goes even further. Great, and good luck!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:50:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:50:48 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39744|0                           |1
        is obsolete|                            |

--- Comment #13 from Genevieve Plantin  ---
Created attachment 42469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42469&action=edit
bug 12446 - Enable adult patrons to have a guarantor

I have rebased Simith's patch.
This includes all the features from the previous patch.

On the patron category page, there is a new field to specify whether patrons
can be guarantee or not.
The atomic update SQL script adds this new field and sets it to true for
categories of type "C" and "P".

1) Apply the patch
2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and
canbeguarantee to categories.
3) Go to patron category administration, edit a category and change the value
of Can Be Guarantee to yes (for Child and Professional mostly to set it by
default)
4) See below to test various scenarios

- Enable an adult to have a guarantor:
0.0) Create or edit a patron category of type 'A'.
0.1) Set the "Can be guarantee" field to "Yes" and save.
1) Select an adult patron -> details tab;
2) Click edit button;
3) validate "guarantor information" fieldset;

- Shows guarantees' fines in the guarantor's page:
4) Click Set to patron button and select a guarantor;
5) Generate a fine;
6) Select guarantor patron -> details tab;
7) Validate guarantee's fine information.

- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer some guarantor's information to the guarantee while creating a new
patron
0) Select an adult patron;
1) Insert all information;
2) Add a new adult patron;
3) Click "Set to patron" button;
4) Select the adult patron from 0);
5) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;

- Transfer guarantor's alternate address/contact to the guarantee while
creating a new patron:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
2) Select an adult patron;
3) Insert all information;
4) Add a new adult patron;
5) Click "Set to patron" button;
6) Select the adult patron from 0);
7) Validade Garantor information/Main address/Contact fieldsets filled;
8) Validade Garantor additional alternate address/contact filled;

- Transfer guarantor's alternate address/contact to the guarantee while adding
a guarantiee:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
3) Select an adult patron;
4) Insert all information;
5) Click Add guarantiee bouton;
6) Validade Garantor information/Main address/Contact fieldsets filled;
7) Validade Garantor additional alternate address/contact filled;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 21:51:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 19:51:01 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #14 from Genevieve Plantin  ---
Created attachment 42470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42470&action=edit
Bug 12446 - Clean code according to Comment 12

For the first recommendation, I tried to be more explicit, I don't know if you
would prefer it because it is slower.

For the second point, I've got rid of the UPDATE line so we don't activate a
new functionnality.

For the third point, I was told that the coma was there in case of new
addition.

Fourth, I corrected the mistake.

For the fifth recommendation, I tried to separate the hardcode categories, but
it is simple for the display (it only changes a the choice in the select for
yes, but the user can still change it aftewards). However, I modified it so, if
someone wants to add a new category to be displayed as guarantee by default, he
only has to add the category code in the array instead of writting another
select == 'new category'.

For the sixth point, I replaced the space.

Lastly, I deleted these lines because, as you said it, it wasn't used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 23:06:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 21:06:46 +0000
Subject: [Koha-bugs] [Bug 14800] New: Adding Patrons to new Batch increments
 batchno instead of adding patron to list
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

            Bug ID: 14800
           Summary: Adding Patrons to new Batch increments batchno instead
                    of adding patron to list
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: Heinrich.Hartl at email.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 42471
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42471&action=edit
manage batch - after once new batch and add items  adding three patrons

I observed the following malfunction in 3.20:

In pataron card creator after choosing new batch:
By Add Item(s) I am offered a pop up window to search for patrons. In each row
of all the patrons found for this search there is a button to add this patron
to the (new) batch. After pressing this button the patron is really added to
the new batch which now comprises just this one. If I want to add more patrons
to the list and therefore continue  e.g. with another search and pressing add
for further patrons to be included in the batch the chosen patrons are not
added to the just created batch but instead new batches are crated and I end
with several new batches each one with exactly one patron in it!


Apparently this is not so if  i chose to edit an existing batch. Add item(s)
and adding several patrons results correctly in extending the current batch.
This is also my bypass for the problem. I created a batch with the first patron
in it, returned to manage batches, chose again the just created batch for
editing an could complement it with the other wanted patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 23:14:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 21:14:16 +0000
Subject: [Koha-bugs] [Bug 14800] Adding Patrons to new Batch increments
 batchno instead of adding patron to list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

--- Comment #1 from Heinrich Hartl  ---
Unfortunately I had created about 20 batches when trying to print patron cards
for 20 new patrons. Deleting these was no fun - After selecting these batches
for deletion I was told that I can delete only one batch at a time, SO what for
is the possibility to select more batches?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  9 23:17:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 21:17:11 +0000
Subject: [Koha-bugs] [Bug 14800] Adding Patrons to new Batch increments
 batchno instead of adding patron to list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

--- Comment #2 from Heinrich Hartl  ---
Created attachment 42472
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42472&action=edit
pop up message after trying  delete with several batches selected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 00:02:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Sep 2015 22:02:58 +0000
Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for
 the same patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 02:06:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 00:06:10 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #16 from Jesse Weaver  ---
(In reply to Katrin Fischer from comment #15)
> This basically works, but 2 small glitches:
> 
> - When returning the item without the proper configuration, the warning
> message is shown, but the item still appears in the table below, even tho it
> was not checked in. It shows as: Not checked out. I think it should show an
> error and not appear in the table, as it has not been checked in.
> 

Agreed; this quirk was very confusing to us and our partners before we figured
out the issue.

> - The error message is not ideal - I think you can't say 'a privacy':
> Error: This patron has requested a privacy on returning item but the
> AnonymousPatron pref is not set correctly.
> 
> Suggestion:
> This patron has requested their circulation history be anonymized on
> check-in, but the AnonymousPatron system preference is not set correctly.
> 
> It's also showing on checkout, so would have to be changed in 2 places.

May I make the small suggestion of "... the AnonymousPatron system preference
is empty or incorrect."? Tiny quibble, but either is an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 11:59:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 09:59:27 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
 details, after LOGOUT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #11 from Marc V?ron  ---
After a logout, there could be a message similar to the following:

"Logout privacy warning: Please close this browser window if other persons have
access to this computer."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 12:45:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 10:45:32 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 12:45:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 10:45:35 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42421|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens  ---
Created attachment 42473
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42473&action=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron searhc, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popupo
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items hsoul;d be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:07:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:07:41 +0000
Subject: [Koha-bugs] [Bug 14800] Adding Patrons to new Batch increments
 batchno instead of adding patron to list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14800

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 14739 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:07:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:07:41 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Heinrich.Hartl at email.de

--- Comment #10 from Nick Clemens  ---
*** Bug 14800 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:09:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:09:13 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12911
           Priority|P5 - low                    |P3
         Depends on|12911                       |
            Version|unspecified                 |master


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911
[Bug 12911] batch_id for new label batches can be assigned to several batches
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:09:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:09:13 +0000
Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be
 assigned to several batches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14739                       |
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14739


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
[Bug 14739] Add several patrons to a new batch will create a new batch per
patron added
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:50:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:50:36 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #11 from Marc V?ron  ---
Created attachment 42474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42474&action=edit
[Signed-off] Bug 14739 - Add several patrons to a new batch will create a new
batch per patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron searhc, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popupo
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items hsoul;d be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above

Followed test plan, works as expected.
Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:50:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:50:51 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42473|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:58:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:58:05 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14739

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 13:58:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 11:58:05 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14131

--- Comment #12 from Marc V?ron  ---
BTW: A couple of months ago, I implemented a possibility to print patron cards
from patronlists. Patron lists are easier to create and to handle.

See Bug 14131 (Needs sign-off)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 14:00:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 12:00:28 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at jsense.co.uk

--- Comment #7 from Marc V?ron  ---
*** Bug 12471 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 14:00:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 12:00:28 +0000
Subject: [Koha-bugs] [Bug 12471] Create patron card batch from from patron
 list or patron search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12471

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Marc V?ron  ---


*** This bug has been marked as a duplicate of bug 14131 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 14:02:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 12:02:32 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:11:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:11:55 +0000
Subject: [Koha-bugs] [Bug 11121] Patron Card Creator batch export cannot
 handle special characters (usually)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           Assignee|gmcharlt at gmail.com          |cnighswonger at foundations.ed
                   |                            |u
          Component|Tools                       |Label/patron card printing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:13:16 +0000
Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the
 "Download as PDF" I always get an empty fields and iam getting patron image
 , barcode correctly in PDF FILE.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
          Component|Tools                       |Label/patron card printing
           Assignee|gmcharlt at gmail.com          |cnighswonger at foundations.ed
                   |                            |u

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:14:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:14:04 +0000
Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card
	creator
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Label/patron card printing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:17:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:17:00 +0000
Subject: [Koha-bugs] [Bug 2246] Label printing doesn't work with Unicode
	characters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246

Chris Nighswonger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11121

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:17:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:17:00 +0000
Subject: [Koha-bugs] [Bug 11121] Patron Card Creator batch export cannot
 handle special characters (usually)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

Chris Nighswonger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=2246,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8375

--- Comment #1 from Chris Nighswonger  ---
Possibly related to Bug 2246

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:17:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:17:00 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Chris Nighswonger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11121

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:17:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:17:40 +0000
Subject: [Koha-bugs] [Bug 11121] Patron Card Creator batch export cannot
 handle special characters (usually)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

--- Comment #2 from Chris Nighswonger  ---
And Bug 8375

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:17:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:17:49 +0000
Subject: [Koha-bugs] [Bug 14635] Sort branches in
	patroncards/add_user_search.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14635

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |Label/patron card printing
                 CC|                            |veron at veron.ch

--- Comment #1 from Marc V?ron  ---
I suppose this is about patron card printing, changed module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:19:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:19:25 +0000
Subject: [Koha-bugs] [Bug 11121] Patron Card Creator batch export cannot
 handle special characters (usually)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

--- Comment #3 from Chris Nighswonger  ---
Someone might want to check the current validity of this bug as the fixes for
Bug 8375 most likely corrected this problem as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:20:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:20:51 +0000
Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Templates                   |Label/patron card printing
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron  ---
I hope it's OK to change module to Label/patroncard printing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:21:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:21:10 +0000
Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the
 "Download as PDF" I always get an empty fields and iam getting patron image
 , barcode correctly in PDF FILE.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951

Chris Nighswonger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #4 from Chris Nighswonger  ---
Marking this resolved as it appears to work fine for me. Feel free to reopen if
this is still and issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:23:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:23:33 +0000
Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between
 table names creator_templates and club_template_enrollment_fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |Label/patron card printing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 15:47:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 13:47:36 +0000
Subject: [Koha-bugs] [Bug 9083] <> in checkin/checkout
 notices does nothing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #1)
> items.content only works with overdue and advanced notices.

This is exactly right, and furthermore, items.content relies on the
'itemscontent' option of those scripts if any modifications are to be made to
what <> displays, so it doesn't make sense to use it anywhere
else.

At this point,
http://wiki.koha-community.org/wiki/Customising_Notices_and_Slips is the best
documentation that we have for the expansion of variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 16:06:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 14:06:31 +0000
Subject: [Koha-bugs] [Bug 12741] Can not create customized slips for branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12741

--- Comment #1 from Marc V?ron  ---
The problem moved: I can now create a customized slip, but it does not print as
expected.

To reproduce:

Home > Tools > Notices & Slips

I marked the Quick slip ISSUEQSLIP for all libraries with a text "ALL
LIBRARIES"

Then I created a copy for the branch FFL and marked the copy with "FFL"
I double checked by filtering Notices and slips by FFL, the text was saved as
expected.

Then I checked out to a patron with an other home library (not FFL)
Result: Slip prints as expected marked with ALL LIBRARIES"

The I checked out to a patron with FFL as home library
Result: It still prints the slip for ALL LIBRARIES (wrong)
Expected: Print the slip marked with "FFL"

Table 'letter' has two entries for the code ISSUEQSLIP:
One with branchcode ''
One with branchcode 'FFL'

It seems that the branchcoude is not taken in account for printing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 16:39:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 14:39:38 +0000
Subject: [Koha-bugs] [Bug 14801] New: Fix Reserves.t
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

            Bug ID: 14801
           Summary: Fix Reserves.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Fix this:

ok 58 - OnShelfHoldsAllowed() disallowed
not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 62 - Bug 14464 - 2nd reserve correctly created
not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge
desired

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 16:41:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 14:41:14 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 16:41:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 14:41:16 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #1 from Marcel de Rooy  ---
Created attachment 42475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42475&action=edit
Bug 14801: Fix Reserves.t

Fix the following errors:
not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 62 - Bug 14464 - 2nd reserve correctly created
not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge
desired

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 16:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 14:43:01 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|enhancement                 |minor
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:00:50 +0000
Subject: [Koha-bugs] [Bug 12741] Can not create customized slips for branch
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12741

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #2 from Marc V?ron  ---
OK, found, my mistake:

The branchcode is taken from the staff member's home branch (not the patron's
home branch). That makes sense.

If I create a slip for the staff member's branch it works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:07:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:07:34 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:11:43 +0000
Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl
 gets wrong parameters
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:53:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:53:44 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #2 from Marc V?ron  ---
Created attachment 42476
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42476&action=edit
[Signed-off] Bug 14801: Fix Reserves.t

Fix the following errors:
not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 62 - Bug 14464 - 2nd reserve correctly created
not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge
desired

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc V?ron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:54:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:54:06 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #42475|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 17:54:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 15:54:17 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 18:00:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 16:00:20 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #13 from Marc V?ron  ---
*** Bug 14123 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 18:00:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 16:00:20 +0000
Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no
 longer has Select / Select All / Add selected
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #7 from Marc V?ron  ---
This is resolved by bug 14739

*** This bug has been marked as a duplicate of bug 14739 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 18:10:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 16:10:23 +0000
Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #17 from Marc V?ron  ---
First patch does not apply:

CONFLICT (content): Merge conflict in admin/itemtypes.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 10 22:17:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 20:17:37 +0000
Subject: [Koha-bugs] [Bug 14802] New: About page (about.pl) throwing errors
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14802

            Bug ID: 14802
           Summary: About page (about.pl) throwing errors
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: About
          Assignee: nengard at gmail.com
          Reporter: gary.bortel at sos.wa.gov
        QA Contact: testopia at bugs.koha-community.org

Most likely related to Bug 13486/14278

Overview: 

Ubuntu 14.04.3, Apache/2.4.7 (Ubuntu), Koha 3.18.10 (package install),
Multi-site installation

Going to the "About Koha" page generates the following errors in
/var/log/koha/[site]/intranet-error.log


[Thu Sep 10 12:45:45.980905 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.980780 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_LOCK_DIR} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.981032 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.980961 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_PID_FILE} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.981202 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.981057 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_RUN_USER} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.981301 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.981229 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_RUN_GROUP} is not defined,
referer: http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.981391 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.981323 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_LOG_DIR} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.984145 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.984070 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_LOG_DIR} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.984400 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.984327 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_LOG_DIR} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.984493 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: [Thu Sep 10 12:45:45.984424 2015] [core:warn]
[pid 3489] AH00111: Config variable ${APACHE_LOG_DIR} is not defined, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl
[Thu Sep 10 12:45:45.984636 2015] [cgi:error] [pid 3477] [client
198.238.185.151:49639] AH01215: apache2: Syntax error on line 219 of
/etc/apache2/apache2.conf: Could not open configuration file
/etc/apache2/sites-enabled/cathlamet.conf: Permission denied, referer:
http://opac.odessa.lib.wa.us:8180/cgi-bin/koha/about.pl


The last line in this snippet has Apache2 attempting to read an unrelated
configuration file from another Koha instance. Similar errors are thrown in all
site specific intranet-error.log when trying to display the "About" page for
that site. (e.g. cathlamet vs. odessa, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 00:54:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 22:54:21 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42243|0                           |1
        is obsolete|                            |

--- Comment #14 from Barton Chittenden  ---
Created attachment 42477
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42477&action=edit
Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 00:54:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 22:54:42 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42244|0                           |1
        is obsolete|                            |

--- Comment #15 from Barton Chittenden  ---
Created attachment 42478
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42478&action=edit
Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
    * accountlines.amountoutstanding is 0, and date is set to $days - 1
      days ago. The accountlines row should not be deleted.
    * accountlines.amountoutstanding is 0, and date is set to $days
      days ago.  the accountlines row should not be deleted, because
      the difference must be *greater* than $days.
    * accountlines.amountoutstanding is 0, and date is set to $days + 1
      days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 00:55:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 22:55:03 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42245|0                           |1
        is obsolete|                            |

--- Comment #16 from Barton Chittenden  ---
Created attachment 42479
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42479&action=edit
Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 00:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 22:55:25 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42246|0                           |1
        is obsolete|                            |

--- Comment #17 from Barton Chittenden  ---
Created attachment 42480
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42480&action=edit
[SIGNED-OFF] bug 14402: Make purge_zero_balance_fees() delete fees with NULL
balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 00:57:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 22:57:25 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #18 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #13)
> CONFLICT (content): Merge conflict in t/db_dependent/Account

Fixed conflicts. Please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 01:19:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Sep 2015 23:19:10 +0000
Subject: [Koha-bugs] [Bug 14803] New: Rental and fine fees are not updating
 on circulation screen
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

            Bug ID: 14803
           Summary: Rental and fine fees are not updating on circulation
                    screen
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dpriceewen at waitaki.govt.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To replicate:
 - From circulation screen attempt to renew an item with a rental fee
 - Note that fees and charges aren't updating: e.g. 
  the circulation screen should read under 
Attention:
Fees & Charges: Patron has Outstanding fees & charges of "x" amount. Make
payment.
- Note "x" amount has not increase
- All fees/fines appear not to be updating

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 06:54:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 04:54:47 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Irma Birchall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irma at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 08:12:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 06:12:38 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
 details, after LOGOUT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #12 from Mason James  ---
(In reply to Marc V?ron from comment #11)
> After a logout, there could be a message similar to the following:
> 
> "Logout privacy warning: Please close this browser window if other persons
> have access to this computer."

Marc, this is a pretty good idea :)

silly me for only considering a technical solution

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 09:52:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 07:52:23 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

--- Comment #3 from Joonas Kylm?l?  ---
(In reply to Marc V?ron from comment #2)
> For the case of the search at the left (endless 'Processing'):
> 
> It dies inside a call to dt_from_string($searchmember) in
> svc/members/search, line 51
> 
> For the search from the header, it dies dies inside a call to
> dt_from_string($searchmember) in
> members/member.pl , line 70
> 
> dt_from_string  dies in Koha/DateUtils.pm at line 144 if it does not get a
> valid date string (in the current syspref format or in the iso format).
> 
> I think that this part of dt_from_string should go to a separate sub.
> See 
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601#c27
> 
> It could then be used for pre-testing date strings from user inputs like the
> ones in this bug.

I can agree with you that we should move it to another sub and then we could
test it. 

However, I think the user should be able to do a search with just a year / day
/ month set, not all of them.. We could do it so that if the user wants to
search by year the input could be, for example, 1990/??/?? or maybe just 1990.
With days and months it is hard to separate them from each other, so that's why
I used the marking ?. So if someone wants to search patrons by birthday day it
would be ????/??/20 (yyyy/mm/dd).

If we want to do my proposal we would need to add a new argument (flag) in the
testing subroutine's arguments to indicate that this is a date string in
????/??/?? format, where some ? can be digits.

But if we now just focus on solving the endless processing text showing, lets
fix that first, and maybe I'll do another bug report for my proposal!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 09:58:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 07:58:11 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 10:17:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 08:17:01 +0000
Subject: [Koha-bugs] [Bug 14804] New: Software error while removing
	duplicates
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14804

            Bug ID: 14804
           Summary: Software error while removing duplicates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Software error:

Can't locate object method "remove_duplicates" via package "-2" (perhaps you
forgot to load "-2"?) at /home/putti/kohaclone/patroncards/edit-batch.pl line
100.

comes when in Home ? Tools ? Patron card creator ? Manage card Batches you
first create a new batch and then add a new item and then click Remove
duplicates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 10:24:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 08:24:57 +0000
Subject: [Koha-bugs] [Bug 14805] New: No idea to disallow the deletion of
 multiple patron card batches
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

            Bug ID: 14805
           Summary: No idea to disallow the deletion of multiple patron
                    card batches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In koha/patroncards/manage.pl?card_element=batch you cannot select multiple
batches for deletion. We don't want the user to go through them one by one if
the user wants to delete all the batches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 10:25:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 08:25:05 +0000
Subject: [Koha-bugs] [Bug 14805] No idea to disallow the deletion of
 multiple patron card batches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |j.kylmala at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 13:55:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 11:55:57 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|claire.hernandez at biblibre.c |julian.maurice at biblibre.com
                   |om                          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 14:20:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 12:20:05 +0000
Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber
 instead of item number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Isabela Terra  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
                 CC|                            |isabelaterra at cp2.g12.br
         Resolution|FIXED                       |---

--- Comment #50 from Isabela Terra  ---
I am having the same problem in 3.18.05.
How fix it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 14:29:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 12:29:35 +0000
Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber
 instead of item number
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

--- Comment #51 from Katrin Fischer  ---
Hi Isabela,

can you please create a new bug report with a step by step description on how
to reproduce the problem? And link to this one? This has already been pushed a
long time ago, so it might be a slight variation of the original problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 14:57:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 12:57:12 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23185|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice  ---
Created attachment 42481
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42481&action=edit
Bug 11311: Browse selected authorities

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 14:57:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 12:57:41 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:20:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:20:56 +0000
Subject: [Koha-bugs] [Bug 14806] New: Action Log for Modifying
	message_transport_types
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

            Bug ID: 14806
           Summary: Action Log for Modifying message_transport_types
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This bug enables logging modifications to the
koha.borrower_messaging_preferences-table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:24:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:24:24 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 42482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42482&action=edit
Bug 14806 - Action Log for Modifying message_transport_types

This is a crude fix.
koha.action_logs-entries are generated when Borrower has been modified using
C4::Form::MessagingPreferences

log entries look like this:

| MEMBERS | MOD MTT | All message_transports removed
| MEMBERS | MOD MTT | [{'_name' => 'Advance_Notice','da' => '4','dig' =>
1,'mtt' => ['email']},{'_name' => 'Item_Check_in','mtt' => ['email']},{'_name'
=> 'Item_Checkout','mtt' => ['email']}]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:24:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:24:39 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:31:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:31:16 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42482|0                           |1
        is obsolete|                            |

--- Comment #2 from Olli-Antti Kivilahti  ---
Created attachment 42483
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42483&action=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:36:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:36:11 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42483|0                           |1
        is obsolete|                            |

--- Comment #3 from Olli-Antti Kivilahti  ---
Created attachment 42484
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42484&action=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:42:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:42:33 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42484|0                           |1
        is obsolete|                            |

--- Comment #4 from Olli-Antti Kivilahti  ---
Created attachment 42485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42485&action=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 16:54:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 14:54:36 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
	message_transport_types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42485|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti  ---
Created attachment 42486
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42486&action=edit
Bug 14806 - Action Log for Modifying message_transport_types

TEST PLAN:

0. Activate system preference "BorrowersLog".
1. In intra, edit a Borrowers messaging preferences.
2. In OPAC remove your messaging preferences.
3. SELECT * FROM action_logs ORDER BY timestamp DESC LIMIT 5;
3.1. You should see your new action logs entries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 17:24:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 15:24:50 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #121 from Colin Campbell  ---
I've put the latest code up on my github repo git at github.com:colinsc/koha.git
as the branch edifact_snapshot_150911 If anyone wants to look at this. I'm
hoping to get order responses working end to end then will generate a patch
from this

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 17:30:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 15:30:25 +0000
Subject: [Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when
 decreaseLoanHighHoldsValue is set to 0.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548

Eivin Giske Skaaren  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 18:07:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 16:07:36 +0000
Subject: [Koha-bugs] [Bug 14807] New: Incorrect logs
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14807

            Bug ID: 14807
           Summary: Incorrect logs
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: isabelaterra at cp2.g12.br
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Issue log and and circulation logs are incorrectly recording biblionumber
instead of item number, creating incorrect logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 18:08:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 16:08:11 +0000
Subject: [Koha-bugs] [Bug 14807] Incorrect logs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14807

--- Comment #1 from Isabela Terra  ---
Bug 7241

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 20:58:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 18:58:41 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36510|0                           |1
        is obsolete|                            |

--- Comment #33 from Genevieve Plantin  ---
Created attachment 42487
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42487&action=edit
Small improvements for the availability informations in the search results list
on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
    display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
    display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 20:58:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 18:58:55 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #34 from Genevieve Plantin  ---
Created attachment 42488
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42488&action=edit
Bug 11881 - Small improvements for Items available for reference

As said on comment #31, Items available for reference weren't displayed like
Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks
class and LabelCallNumber class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 21:00:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 19:00:40 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |genevieve.plantin at inlibro.c
                   |                            |om
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:36:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:36:04 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:36:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:36:07 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42487|0                           |1
        is obsolete|                            |

--- Comment #35 from Nick Clemens  ---
Created attachment 42489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42489&action=edit
Small improvements for the availability informations in the search results list
on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
    display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
    display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

http://bugs.koha-community.org/show_bug.cgi?id=11881

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:36:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:36:31 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42488|0                           |1
        is obsolete|                            |

--- Comment #36 from Nick Clemens  ---
Created attachment 42490
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42490&action=edit
Bug 11881 - Small improvements for Items available for reference

As said on comment #31, Items available for reference weren't displayed like
Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks
class and LabelCallNumber class

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:37:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:37:43 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #37 from Nick Clemens  ---
One small thing I noticed was an extra line between the available items list
and the Checked Out(1) line after I had applied the CSS snippet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:53:08 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 11 22:53:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 20:53:10 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38792|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens  ---
Created attachment 42491
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42491&action=edit
Bug 14131 - Patroncard: Add possibility to print from patron lists

This patch adds the possibility to print patron cards from patron lists.

To test:

- Go to Home > Tools > Patron card creator
- Prepare a patron card and create some cards using the batch functionality
- Apply patch
- Prepare a patron list e.g. from patron search
- Go to Home > Tools > Patron card creator > Manage batches
- Below the list of batches you have a dropdown to select a patron list
- Select your list and hit "Export from patron list"
- Select template and layout as you would do with batches
- Hit "Export"
- Download PDF

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 01:06:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 23:06:49 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 01:06:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 23:06:52 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42387|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens  ---
Created attachment 42492
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42492&action=edit
Bug 14293: The suspension should be calculated in days

There was a mismatch between bug 13909 and bug 5549.
The get_chargeable_units call from _debar_user_on_return should specify
that we want a suspension in days.

However I don't understand the comment let by the author of bug 5549
f61a9617184ec4b24100c1d99150bfd4ebf13336

1/
> finedays is in days, so hourly loans must multiply by 24
Yes but the suspension is in days, so no need to * 24

2/ And we should have a look on this one too:
> grace period is measured in the same units as the loan
But the grace period is always in days. On the circ rules the column is
"Fine grace period (day)".
I think we should replace
  DateTime::Duration->new( $unit => $issuingrule->{firstremind} );
with
  DateTime::Duration->new( days => $issuingrule->{firstremind} );

Anyway, we definitelly need more tests in this area!

Test plan:
1/ Define an issuing rule with a unit=hour
2/ Set a suspension in days
3/ Check an item out and specify a past due date.
4/ Check the item in
5/ The patron should be debarred correctly

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 01:08:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Sep 2015 23:08:12 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
 of users per day
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

--- Comment #3 from Nick Clemens  ---
Test plan worked as expected with one question: if they are hours overdue on an
hourly loan, and not a day overdue, it seems to not suspend them.  Should it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 10:57:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Sep 2015 08:57:08 +0000
Subject: [Koha-bugs] [Bug 14808] New: Koha 3.20.3 UTF-8 Problems
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14808

            Bug ID: 14808
           Summary: Koha 3.20.3 UTF-8 Problems
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ayousef at kwareict.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hello All,

Koha 3.20.3 suffers from UTF-8 Problems in some pages such as, When trying to 

1- Editing help in Arabic interface it shows garbage like this:

        ? ?????????? ????? ? ?? ???i?????

        ?????? ???????? ?????? ???? ????? ???? ????????????        
???????????? ????? ?????????? ? ?? ??????????????.

Although it shows help good in Arabic when reading help.

               ==============================================

2- When trying to import borrowers form tools > Import patrons

Default values like (Salutation:, Surname, ...etc) looks like (????????:) in
Arabic interface, Although these terms are ok in Arabic columns.def file.

               ==============================================

3- Also the same thing when trying to build new Guided reports from Guided
reports wizard.

Note: Koha 3.18.06 doesn't suffer from this problem, I mean Arabic terms appear
in a good way.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 18:40:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Sep 2015 16:40:49 +0000
Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to
 DataTables pagination
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org
             Status|Needs Signoff               |In Discussion

--- Comment #6 from Nick Clemens  ---
Moving this to in discussion.

I think the expected behavior is somewhere between the original and that with
the patches applied.  I would expect either:

1 - Preserve current behavior and change just the labels to "Select all visible
/ clear all visible"

2 - Select all searches but respect filters.  If I filter down to 8 searches it
should select only those.  If my filter finds 21 searches (default 20 visible)
it should select all 21, but not searches limited by filter.  Labels would say
"With ## selected searches: delete"

A couple other things from testing:

1 - On master selecting any search past 20 doesn't change the look of the
delete button, though it is enabled.  It does only function on the visible
searches either way 
i.e. select search 21, button no visibly enabled, but clickable. Select #1 and
#21 (with 20 visible) button is enabled, only #1 is deleted.
With the patches the link still isn't visibly enabled but will delete all
selected regardless of visibility

2 - The phrasing "With selected searches: Delete" is awkward.  I think it
should be "Delete selected searches" and button can simply be grayed out when
none are selected With these patches phrasing would then be "Delete ## selected
searches"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 20:51:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Sep 2015 18:51:07 +0000
Subject: [Koha-bugs] [Bug 14809] New: INSTALL.debian refers has references
 to 'squeeze' and 'lenny'
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14809

            Bug ID: 14809
           Summary: INSTALL.debian refers has references to 'squeeze' and
                    'lenny'
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

INSTALL.debian makes reference to 'squeeze', even though jessie and wheezy are
Debian current and oldcurrent respectively.

grep -n -i -B4 squeeze INSTALL.debian
30-At the time of writing, you need to create
31-/etc/apt/sources.list.d/indexdata.list containing the following:
32-
33-    # Index Data
34:    deb http://ftp.indexdata.dk/debian squeeze main
35:    deb-src http://ftp.indexdata.dk/debian squeeze main
--
375-
376-Tested on the following operating environments
377-==============================================
378-- Debian Lenny 5.0
379:- Debian Squeeze 6.0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 12 22:02:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Sep 2015 20:02:52 +0000
Subject: [Koha-bugs] [Bug 14809] INSTALL.debian needs to be updated for
	wheezy and jessie
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14809

Barton Chittenden  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|INSTALL.debian refers has   |INSTALL.debian needs to be
                   |references to 'squeeze' and |updated for wheezy and
                   |'lenny'                     |jessie

--- Comment #1 from Barton Chittenden  ---
Under squeeze,

sudo dpkg --set-selections < install_misc/debian.packages

results in each line line in install_misc/debian.packages generating an error
similar to the following:

dpkg: warning: package not in database at line XX: 

To avoid this, the following lines must be added to the documentation, before
'sudo dpkg --set-selections ...'

    Run the following:

    $ sudo apt-get install dselect
    $ sudo dselect

    Select [U]pdate and [I]nstall from the dselect menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 12:28:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 10:28:20 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #129 from Katrin Fischer  ---
Hi Jesse, which is the branch to start with a code review? rancor-submit?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 13:43:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 11:43:00 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #96 from Katrin Fischer  ---
I am not sure about the current state of this - are the current patches still
valid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 15:17:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 13:17:42 +0000
Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice
 duplicates the notice instead of updating it
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Katrin Fischer  ---
This doesn't work for me:

1) Copy an 'all libraries' notice to another branch
2) Try to save it:
   A letter with the code 'DUE' already exists for 'undefined'.

Can you check? I had to resolve a conflict, maybe I got that wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:06:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:06:08 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

--- Comment #8 from Katrin Fischer  ---
This works as described, but maybe we could improve some of the messages at
some point:

"All patrons with checkouts older than 18/04/2015 have been anonymized"

We are not anonymizing the patrons, but only their checkouts :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:06:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:06:43 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:06:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:06:46 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41184|0                           |1
        is obsolete|                            |
  Attachment #41185|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer  ---
Created attachment 42493
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42493&action=edit
[PASSED QA] Bug 6756: Fix bad behaviors if AnonymousPatron is not defined

There are at least 2 wrong behaviors if the AnonymousPatron pref is not
defined (0 or empty string).
1/ If you use the clean borrower tools, you will get a successful
message when the nothing happened (the history has not been anonymised).
2/ At the OPAC, if a patron ask for delete his reading history, he will
get an error message "The deletion of your reading history failed,
because there is a problem with the configuration of this feature.
Please help to fix the system by informing your libr    ary of this
error". IMO this should not happen, the history should be anonymised.

With this patch, the old_issues.borrowernumber field will be set to NULL
if the AnonymousPatron pref if not defined.

Test plan:
1/ Fill the pref with "" or 0
2/ At the OPAC, go on the privacy tab and click on the "Immedia deletion"
button.
You should get a green and friendly message. Confirm that the history
has been anonymised.
3/ Use the "Batch patron anonymization" tools (tools/cleanborrowers.pl)
to anonymize the checkout history.
Confirm that a) it works and b) you get a message.

Try again with AnonymousPatron set to a valid patron. You should not see
any changes with the current behaviors.

NOTE: This patch tweaks C4/Circulation.pm and provides tests.
      applying just this, and running prove success. Reverting just
      C4/Circulation.pm fails, as expected.
      Tested OPAC stuff with both patches applied.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:07:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:07:03 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

--- Comment #10 from Katrin Fischer  ---
Created attachment 42494
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42494&action=edit
[PASSED QA] Bug 6756: Add info messages

NOTE: Before patch "./misc/cronjobs/batch_anonymise.pl --help" had no
      message, and neither did the anonymizing tool in the staff client.
      After the patch, both had informative messages.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:08:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:08:29 +0000
Subject: [Koha-bugs] [Bug 14810] New: Improve messages in patron anonymizing
	tool
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810

            Bug ID: 14810
           Summary: Improve messages in patron anonymizing tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When successfully anonymizing circulation histories up to a specific date, the
tool reports:

"All patrons with checkouts older than 18/04/2015 have been anonymized"

But... we are not anonymizing the patrons, but only their checkouts :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:09:03 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14810

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:09:03 +0000
Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6756

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:17:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:17:43 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Question: should we provide an update database to fix the proble on existing
databases? Something like:

If the location is not empty or CART or PROC, copy to permanent_location.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:08 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #10 from Katrin Fischer  ---
Created attachment 42495
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42495&action=edit
[PASSED QA] Bug 7634: Make the tests pass

This patch just fixed a master bug, if your database already has some
items.homebranch set to CPL

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:11 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #11 from Katrin Fischer  ---
Created attachment 42496
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42496&action=edit
[PASSED QA] Bug 7634: Add tests

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:14 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

--- Comment #12 from Katrin Fischer  ---
Created attachment 42497
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42497&action=edit
[PASSED QA] Bug 7634: Prevent permanent_location to be set to NULL if not
defined

The permanent_location is correctly filled when an item is added from
the cataloguing module (routine set_item_default_location from
cataloguing/additem.pl).
But when records are imported, this filled is not managed. It's only on
editing (_do_column_fixes_for_mod called from ModItem).

This patch set the permanent_location item fields to the location value for all
items created, even the imported ones.

Test plan:
0/ Do not apply this patch
1/ Import a record with items using the "Stage MARC for import" tool
2/ Check the values for the permanent_location in the items table.
They are set to NULL
3/ Apply this patch
4/ Repeat 2 and confirm that now the permanent_location values are set
to the location values.

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:35 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:36 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42260|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:38 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42261|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:34:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:34:40 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42262|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:36:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:36:37 +0000
Subject: [Koha-bugs] [Bug 14811] New: Don't set permanent_location to CART
	or PROC
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

            Bug ID: 14811
           Summary: Don't set permanent_location to CART or PROC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If a library is using the ReturnToShelvingCart feature, items returned are set
to the location = CART and the permanend_location is used to store the normal
location, that it will be reset to later via a cronjob.

But: If you edit the item while it's still CART, the 'normal location' in
permanent location will ber overwritten with CART.  :(

So: When the location is CART, don't update permanent location!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:37:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:37:09 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14811

--- Comment #13 from Katrin Fischer  ---
I filed bug 14811 to deal with a related problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:37:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:37:09 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7634

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 17:49:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 15:49:37 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I am in favor of this change, but it would be good to have a test to back it
up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:12:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:12:43 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42454|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer  ---
Created attachment 42498
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42498&action=edit
Bug 14782: Add tests

Run:
perl t/db_dependent/Utils/Datatables_Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:12:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:12:41 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:13:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:13:20 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

--- Comment #6 from Katrin Fischer  ---
Created attachment 42499
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42499&action=edit
[PASSED QA] Bug 14782 - Add possibility to search patrons using the username
(userid)

This patch makes it possible to search for users using the username (userid /
login name).

To test:

- Apply patch
- Do searches from Home > Patrons
- Search after a full username or parts of a username with Search fields =
Standard and Search fields = Userid
- Perform the searches from the top bar (expand with [+]) and from the
"Filters" part at the left
- Make sure that other searches behave as before

Signed-off-by: Joonas Kylm?l? 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:14:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:14:18 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

--- Comment #7 from Katrin Fischer  ---
Tried my hand at writing some... hopefully they are useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:14:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:14:49 +0000
Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is
 NULL when Import MARC records tool is used
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:29:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:29:03 +0000
Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from
	checkin screen
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14801

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:29:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:29:03 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14464

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:30:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:30:31 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42476|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer  ---
Created attachment 42500
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42500&action=edit
[PASSED QA] Bug 14801: Fix Reserves.t

Fix the following errors:
not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 62 - Bug 14464 - 2nd reserve correctly created
not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge
desired

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:30:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:30:29 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:35:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:35:28 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #5 from Katrin Fischer  ---
Please make sure to include a test plan in your commit messages in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:42:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:42:39 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #6 from Katrin Fischer  ---
There are also 2 other small things to keep an eye on next time:
1) Please start your commit messages with Bug xxxxx: - that will help our
release scripts and other tools pick them up correctly.

2) Please be careful - Koha standardized to using 4 spaces and no tabs. The QA
tool pointed out some issues there that I have fixed when reviewing your
patches:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 896)
                forbidden pattern: tab char (line 900)
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 451)
                forbidden pattern: tab char (line 447)
                forbidden pattern: tab char (line 456)
   OK     spelling
   OK     tt_valid
   OK     valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:43:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:43:08 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:43:11 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42460|0                           |1
        is obsolete|                            |
  Attachment #42461|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer  ---
Created attachment 42501
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42501&action=edit
[PASSED QA] Bug 13781: Fix relatives's checkouts missing heading columns

There was two missing heading columns (location and fine) and one hidden
heading missing column (this hidden column is needing for sorting the table) it
was taking the due_date column for the hidden column, so I added them

Both patches tested together. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:43:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:43:22 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #8 from Katrin Fischer  ---
Created attachment 42502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42502&action=edit
[PASSED QA] Bug 13781: Fix missing heading columns for relative's checkouts
table in check out patron page

Theres was two missing heading columns Location and Fines in the Check out
section of a Patron

Tested both patches together. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 13 18:43:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 16:43:37 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #9 from Katrin Fischer  ---
Thx for fixing this :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 01:30:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 23:30:37 +0000
Subject: [Koha-bugs] [Bug 5837] Change installer to use
 DBIx::Class::Schema::Versioned instead of updatedatabase.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5837

--- Comment #7 from David Cook  ---
(In reply to Olli-Antti Kivilahti from comment #6)
> Hi there!
> Can you share the code you have been working on here as commits?
> I am not asking for anything "git bz apply":able, just something to read
> your thoughts from.

I don't have any code for this, but I'll post something to bug 11390 in a
minute.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 01:35:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Sep 2015 23:35:23 +0000
Subject: [Koha-bugs] [Bug 11390] DBIx::Class schema deployment script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

--- Comment #13 from David Cook  ---
If you want to reproduce the issues I was having exactly, I suggest checking
out commit 85c25c619f8684f99c80fe6cf6a5c4885e903b5a (Bug 9165: (Followup)
Tidied code slightly), but it'll probably work on master too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 02:07:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 00:07:48 +0000
Subject: [Koha-bugs] [Bug 11390] DBIx::Class schema deployment script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

--- Comment #14 from David Cook  ---
Created attachment 42503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42503&action=edit
Wind this back... these are experiments for using DBIC schema control

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 02:07:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 00:07:54 +0000
Subject: [Koha-bugs] [Bug 11390] DBIx::Class schema deployment script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390

--- Comment #15 from David Cook  ---
Created attachment 42504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42504&action=edit
Latest work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 06:00:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 04:00:23 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Bob Birchall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 07:58:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 05:58:20 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #42 from Katrin Fischer  ---
- Add 4 patrons to a patron list, one has a checkout
- Select patron list in batch tool
- Reports: 4 patrons will be deleted (misleading, only 3 should)
- Choose test run:
  4 patrons would have been removed (if it wasn't a test run)

In my eyes, if a test run doesn't reflect what would be happening, it's
useless.

- Go back, change to "move to trash"
  4 patrons have been successfully moved to trash
- The user with the checkout has NOT been deleted (thankfully)

Now the next strange thing:

- Checking the deletedborrowers table - there is my user with the checkout.
So it actually moved all the borrowers to deletedborrowers and I have ended up
with the same borrowernumber in borrowers and deletedborrowers.

I know this is not related directly to the feature, but this tool gives me a
headache as it is. I don't trust it at all. In my opinion it's very buggy and
shouldn't be promoted before fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 08:18:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 06:18:17 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:49:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:49:19 +0000
Subject: [Koha-bugs] [Bug 14794] Searching patron by birthday is slow /
 never gives a result
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
I think we need a patch to fix the software error (maybe JS side).
We could imagine to accept a year also (YYYY), but something like ????/??/20
looks to me a bit too much.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:52:57 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|7174                        |14698


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
[Bug 7174] Authentication rewriting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698
[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a
database
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:52:57 +0000
Subject: [Koha-bugs] [Bug 7174] Authentication rewriting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14723                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:52:57 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14723


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:53:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:53:00 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42466|0                           |1
        is obsolete|                            |

--- Comment #14 from Lari Taskula  ---
Created attachment 42505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42505&action=edit
Bug 14723 - Additional delivery notes to messages

Database updates are now using the AtomicUpdater (Bug 14698)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:54:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:54:41 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #12 from Jonathan Druart  ---
Yep, this needs to be tested widely.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:54:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:54:57 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7174


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
[Bug 7174] Authentication rewriting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 09:54:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 07:54:57 +0000
Subject: [Koha-bugs] [Bug 7174] Authentication rewriting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14723


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
[Bug 14723] Additional delivery notes to messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 10:49:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 08:49:58 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #4 from Marcel de Rooy  ---
Still looking a little bit at this one.
Will probably add a tiny follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:22:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:22:21 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #5 from Marcel de Rooy  ---
Created attachment 42506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42506&action=edit
Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee

The problem making some tests fail, actually was the unneeded addition
of zero accountline records by ChargeReserveFee, called by AddReserve.
The balance is still zero, but a test like !$var responds differently
when var is 0.00 instead of 0 or undef.

This patch adjusts the test in ChargeReserveFee in order to prevent
adding these records with 0.00.
The first patch that adjusts the tests in Reserves.t is not strictly
needed anymore, but can stay.

Test plan:
[1] Run t/db_dependent/Reserves.t
[2] Run t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:25:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:25:07 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #6 from Marcel de Rooy  ---
Tomas:
I added a followup that resolves the deeper cause of the failing test.
It is fairly trivial :)
But if you want another signoff or so, please change the status accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:32:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:32:42 +0000
Subject: [Koha-bugs] [Bug 14812] New: Help could not be displayed in the
	correct language
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812

            Bug ID: 14812
           Summary: Help could not be displayed in the correct language
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

If opaclanguages != language, the language of the help page is the default one
(en).

To reproduce:
Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR

Translate the fr-FR and ar-Arab templates.
Go on the mainpage, switch to ar-Arab, go to the help page.
The page is displayed in English (fallback).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:34:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:34:32 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42500|0                           |1
        is obsolete|                            |
  Attachment #42506|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy  ---
Created attachment 42507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42507&action=edit
Bug 14801: Fix Reserves.t

Fix the following errors:
not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 62 - Bug 14464 - 2nd reserve correctly created
not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge
desired

Signed-off-by: Marcel de Rooy 
Signed-off-by: Marc Veron 
Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 
Amended the x==0 test with !x || x==0 to include 0.00 and prevent warn.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:34:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:34:36 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

--- Comment #8 from Marcel de Rooy  ---
Created attachment 42508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42508&action=edit
Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee

The problem making some tests fail, actually was the unneeded addition
of zero accountline records by ChargeReserveFee, called by AddReserve.
The balance is still zero, but a test like !$var responds differently
when var is 0.00 instead of 0 or undef.

This patch adjusts the test in ChargeReserveFee in order to prevent
adding these records with 0.00.
The first patch that adjusts the tests in Reserves.t is not strictly
needed anymore, but can stay.

Test plan:
[1] Run t/db_dependent/Reserves.t
[2] Run t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:34:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:34:55 +0000
Subject: [Koha-bugs] [Bug 14813] New: Encoding issues when editing the help
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

            Bug ID: 14813
           Summary: Encoding issues when editing the help
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Documentation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
Install and set the fr-FR language (or ar-Arab).
Go on the help page and edit it.
The textarea will contain encoding issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:35:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:35:15 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11944

--- Comment #1 from Jonathan Druart  ---
Seems to be introduced by 11944.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:35:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:35:15 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14813


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813
[Bug 14813] Encoding issues when editing the help
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:37:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:37:39 +0000
Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct
	language
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:37:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:37:42 +0000
Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct
	language
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812

--- Comment #1 from Jonathan Druart  ---
Created attachment 42509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42509&action=edit
Bug 14812: Display the help in the correct language

If opaclanguages != language, the language of the help page is the
default one (en).

Test plan:
1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR
2/ Translate the fr-FR and ar-Arab templates.
3/ Go on the mainpage, switch to ar-Arab, go to the help page.
The help page content should be in Arabian, not English.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:39:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:39:22 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:39:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:39:24 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

--- Comment #2 from Jonathan Druart  ---
Created attachment 42510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42510&action=edit
Bug 14813: Fix encoding issues on editing help pages

It has been introduced by bug 11944.

Test plan:
1/ Install and set the fr-FR language (or ar-Arab).
2/ Go on the help page and edit it.
3/ The textarea should not contain encoding issues with this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:39:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:39:35 +0000
Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct
	language
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:39:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:39:35 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14812

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 11:56:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 09:56:09 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #13 from Jonathan Druart  ---
Could you attach the file here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 12:32:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 10:32:28 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Alex Arnaud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 12:35:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 10:35:19 +0000
Subject: [Koha-bugs] [Bug 14814] New: Suggestions improvements
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14814

            Bug ID: 14814
           Summary: Suggestions improvements
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: vfernandes at keep.pt
        QA Contact: testopia at bugs.koha-community.org

Improvements to suggestions management:

1) When adding a new suggestion in the staff client, we should be able to
associate the suggestion to one patron. These patron should receive the
suggestion updates by email.

2) When adding a new suggestion in the staff client, we should be able to
choose the supplier next to choose the fund.

3) Add a new email template to send to the supplier with the order. These email
allows to do an order to the supplier automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 12:39:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 10:39:01 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 12:39:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 10:39:04 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #9 from Jonathan Druart  ---
Created attachment 42512
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42512&action=edit
Bug 12426: Simplify the code adding a new subroutine GetMessage

The C4::Letters module does not have a GetMessage subroutine, which
could be quite useful.
This patch adds it and simplifies the code added by the previous patch.
It also adds a few tests and fixes POD typos.

Note that ResendNotice only resends failed messages. This will avoid to
resend already sent messages (using an url from the browser history for
instance).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 12:39:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 10:39:41 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #10 from Jonathan Druart  ---
Lari, can I get your opinion on the second patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:10:32 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to 'editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Janet McGowan  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:10:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:10:55 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to 'editable in OPAC'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Jeremy Evans  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Jeremy.evans at nibsc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:29:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:29:26 +0000
Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40944|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy  ---
Created attachment 42513
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42513&action=edit
Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin

This patch updates the sql installer files for new installations.
Occurrences to the three plugins marc21_field_003, 040c and 040d are
replaced by marc21_orgcode.pl.
This has been generated by one sed statement.

Test plan:
[1] Run a new installation or run some of the changed sql files manually.
[2] Verify that marc21_orgcode is linked to fields previously linked to
    the three old plugins.
[3] Do a git grep on the three plugin file names. No occurrences expected.

Signed-off-by: Marcel de Rooy 
Have tested the three english sql files:
authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a
for 9 auth codes)
marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch
does not add them to 040c or 040d; no behavior change..
marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:29:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:29:31 +0000
Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40945|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy  ---
Created attachment 42514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42514&action=edit
Bug 14199: Database revision for marc21_orgcode.pl

This patch adds the dbrev in atomicupdate, updating the marc structure
for existing installations. (New installation in previous patch.)
And it removes the obsolete plugin files.

Test plan:
Run upgrade. Verify that new plugin is linked (for bib and auth).
Check plugin in editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:30:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:30:48 +0000
Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #6 from Marcel de Rooy  ---
Rebased. File marc21_simple_bib_frameworks.sql is no longer touched.
Hope this attracts some more attention than thus far ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:42:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:42:33 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:42:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:42:59 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42510|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec  ---
Created attachment 42515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42515&action=edit
Bug 14813: Fix encoding issues on editing help pages

It has been introduced by bug 11944.

Test plan:
1/ Install and set the fr-FR language (or ar-Arab).
2/ Go on the help page and edit it.
3/ The textarea should not contain encoding issues with this patch.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:43:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:43:22 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:48:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:48:57 +0000
Subject: [Koha-bugs] [Bug 14815] New: Different leader values per framework
	code
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815

            Bug ID: 14815
           Summary: Different leader values per framework code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

This is a follow up of report 14201 removing some dead code for leader plugins.
Based on the framework code, we could define some different leader values in a
preference (or so) and enhance the leader plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:50:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:50:14 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14815

--- Comment #13 from Marcel de Rooy  ---
(In reply to H?ctor Eduardo Castro Avalos from comment #9)
> Hi Marcel you're right, the three perl scripts/templates do nothing or do
> the same thing, but the magic of having too many plugins perhaps is for
> filling different data in the frameworks. i.e., books only uses "06 - Type
> of record: a - Language material" but computer files uses "m - Computer
> file" and videos uses "g - Projected medium"
> 
> With this you save time for experimented catalogers. The data in the leader
> is predefined and she or he doesn't need to fill at all. Just by the fact to
> choose the proper framework is enough.
> 
> Maybe you can do a trick in your plugin to catch the framework code and
> redefine the leader for the type of resource/material.

Yes, you are right that this would be handy. And it probably was the idea when
these files came up. But it did not work.
Note that this report does not change behavior.
So I am opening a new report to collect some ideas how to improve the default
leader. Since we have the framework code already, we could pass that one to the
plugin. When we add a preference, we could add leaders there per framework
code. I would not favor hardcoding BKS BOOKS etc. in the plugin..

See bug 14815.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:50:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:50:14 +0000
Subject: [Koha-bugs] [Bug 14815] Different leader values per framework code
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14201

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:52:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:52:46 +0000
Subject: [Koha-bugs] [Bug 14815] Different leader values per framework code
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 13:56:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 11:56:03 +0000
Subject: [Koha-bugs] [Bug 14815] Different leader values per framework code
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815

--- Comment #1 from Marcel de Rooy  ---
document.forms['f'].Frameworks.value

>      
> +    

Duplicated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:02:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:02:50 +0000
Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify
	due date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:17:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:17:41 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #38 from Genevieve Plantin  ---
(In reply to Nick Clemens from comment #37)
> One small thing I noticed was an extra line between the available items list
> and the Checked Out(1) line after I had applied the CSS snippet

Is 'Checked out' supposed to be on the same line as an [Call number : 320] ? I
just want to be sure I correct it the good way. I was thinking about it because
there's other unavailable classes like Withdrawn, Lost, Damaged, etc. Are they
supposed to be on the same line too ? Wouldn't it weird if it was only in the
same line as one Call Number even if there is three Call Number ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:22:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:22:36 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #17 from Jonathan Druart  ---
Created attachment 42517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42517&action=edit
Bug 14655: Fix wording

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:24:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:24:08 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #18 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #15)
> This basically works, but 2 small glitches:
> 
> - When returning the item without the proper configuration, the warning
> message is shown, but the item still appears in the table below, even tho it
> was not checked in. It shows as: Not checked out. I think it should show an
> error and not appear in the table, as it has not been checked in.

Well, I consider this completely out of the scope of this bug fix.
The error/warning messages are not correctly handled at all in this area.
I would prefer to try and fix globally this issue considering it as an enh.

> - The error message is not ideal - I think you can't say 'a privacy':
> Error: This patron has requested a privacy on returning item but the
> AnonymousPatron pref is not set correctly.
> 
> Suggestion:
> This patron has requested their circulation history be anonymized on
> check-in, but the AnonymousPatron system preference is not set correctly.
> 
> It's also showing on checkout, so would have to be changed in 2 places.

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:29:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:29:21 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #12 from Katrin Fischer  ---
I think it could be very useful for a library to be able to resent messages
that don't have a "failed" status - for example: the library has typoed in the
email address. In this cases the email is sent, but bounced back to the
library's email address (email account doesn't exist at this provider etc.) and
it's up to the library to correct the email address. But the status will be
sent.
I have been asked a lot if there is a way to trigger a notice again - which is
why I filed this bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:31:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:31:06 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Janet McGowan  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:36:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:36:12 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #19 from Katrin Fischer  ---
I think you are right - fixing the first bit is more urgent. I think we should
handle the 'not checked in but shows as checked in' case on a separate bug (bug
not enh). Compromise? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:36:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:36:35 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #144 from Olli-Antti Kivilahti  ---
Created attachment 42518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42518&action=edit
Bug 13799 - Swagger2-driven Permission checking

A hasty downgrade from 13920, utilizing new features implemented by the
Mojolicious::Plugin::Swagger2-author, to make it possible to implement more
complex authentication/authorization scenarios with the Plugin.

Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.

This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 14:39:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 12:39:50 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #145 from Olli-Antti Kivilahti  ---
Hi!

Had a discussion in IRC with jajm and ashimema about REST API permission
checking. And since the author of Mojolicious:Plugin::Swagger2 has kindly
improved the plugin per the discussions I have had with him.
I decided to utilize the new around-action -hook of the Swagger2-plugin to
implement Swagger2-driven permission checking for the REST API authentication
mechanism.

I really need to start migrating another legacy ILS to Koha, but it would be a
real shame to let this great improvement pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:09:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:09:49 +0000
Subject: [Koha-bugs] [Bug 14816] New: Item search returns no results with
 multiple values selected for one field
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816

            Bug ID: 14816
           Summary: Item search returns no results with multiple values
                    selected for one field
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If you select multiple values from the pulldown for a give field ( e.g. home
library ), the search will never return results. I believe this issue is due to
the fact that the query is using IN but is treating the entire list of values
for the IN as a single string to be quoted, instead of a list of comma
separated string to be quoted individually.

'str' => '(homebranch IN (?))'
'args' => 'CPL,FFL,FPL,FRL,IPT,LPL,MPL,MY,PVL,RPL,SPL,TPL,UPL'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:10:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:10:05 +0000
Subject: [Koha-bugs] [Bug 14816] Item search returns no results with
 multiple values selected for one field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:11:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:11:39 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40794|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy  ---
Created attachment 42519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42519&action=edit
Bug 13622: Display a datetime without time in a notice

For some needs, a librarian would like to display a datetime or
timestamp field without the time.

This patch adds filter logic in the notice/letter parsing process.

Test plan:
1/ Defined a notice using a datetime or timestamp DB field
(biblio.timestamp for instance).
2/ Generate the notice
3/ Verify that the letter is generated with the time
4/ Use the "dateonly" filter like:
  <>
  <>
5/ Generate the notice
6/ Confirm the the letter is generated without the time for this field.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

Updated the count of tests to 64 for t/db_dependent/Letters.t to pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:11:43 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40795|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy  ---
Created attachment 42520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42520&action=edit
Bug 13622: [QA Follow-up] Add unit test descriptions

This report adds a few unit tests for datonly flag in notices.
This patch adds (very trivial) unit test descriptions.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:17:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:17:58 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #22 from Marcel de Rooy  ---
QA Comment:
I am taking the liberty to pass qa on this report. Since Indranil signed off on
both patches, I gain my QA token again..
Works as described.
QA tests pass.
The feature is kind of undocumented now. It should be described somewhere (help
page, manual, on the form??)
The code in Letters.pm is already less maintainable and this fix will not
improve the situation. But it is a global solution and it is in written in a
way that could[..] be extended with similar filters.
The three added tests are testing the same thing. Seems to be overkill. I could
better understand your testing the same report with dateonly flag and without
it to show the difference. But no big deal.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:30:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:30:13 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

--- Comment #9 from Olli-Antti Kivilahti  ---
Created attachment 42521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42521&action=edit
Bug 14698 - AtomicUpdater - Followup, add single atomicupdate-script execution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:34:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:34:17 +0000
Subject: [Koha-bugs] [Bug 14805] No idea to disallow the deletion of
 multiple patron card batches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:34:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:34:19 +0000
Subject: [Koha-bugs] [Bug 14805] No idea to disallow the deletion of
 multiple patron card batches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #1 from Joonas Kylm?l?  ---
Created attachment 42522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42522&action=edit
Bug 14805: Allow the user to delete multiple batches

Allows the user to delete multiple patron card batches.

Test plan:

1. Add first some 20 batches
2. Go to the edit page of some X batch by first selecting from the
   batch list the batch you want to edit and then after that by clicking
   edit.
3. Delete one batch by selecting one batch and then clicking delete.
4. Select 0 batches and click delete, notice you cannot delete.
5. Select 0 batches and click edit, notice you cannot edit.
6. Select 2 batches and click edit, notice you cannot edit.
7. Apply patch
8. Check that steps from 2-6 work like they worked before.
   (and add more batches so that you have ~20 of them)
9. Select 2 batches and click delete. Make sure they are deleted.
10. Try to figure out some anomalies this patch might have caused.

Sponsored-by: Vaara-kirjastot

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:39:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:39:56 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

--- Comment #23 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #22)
> The three added tests are testing the same thing. Seems to be overkill.

No, they test different patterns:
table.field | filter
field | filter
field|filter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:41:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:41:26 +0000
Subject: [Koha-bugs] [Bug 14816] Item search returns no results with
 multiple values selected for one field
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |julian.maurice at biblibre.com
                   |ommunity.org                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:44:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:44:46 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #20 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #19)
> I think you are right - fixing the first bit is more urgent. I think we
> should handle the 'not checked in but shows as checked in' case on a
> separate bug (bug not enh). Compromise? :)

I had a quick look at the code this morning, it looks a bit more complicated.
Different errors should also be caught.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:47:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:47:29 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #21 from Katrin Fischer  ---
Not sure I understand - should this move on to QA and the other problems be
dealt with on another bug - or does this patch need more work?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:53:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:53:32 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Joonas Kylm?l?  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.kylmala at gmail.com

--- Comment #146 from Joonas Kylm?l?  ---
Commit "RESTful API with Mojolicious and Swagger2" is missing license notices
from the start of some files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:54:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:54:53 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Tom Misilo  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 15:57:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 13:57:02 +0000
Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which
 updates have been applied to a database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42521|0                           |1
        is obsolete|                            |

--- Comment #10 from Olli-Antti Kivilahti  ---
Created attachment 42523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42523&action=edit
Bug 14698 - AtomicUpdater - Followup, add single atomicupdate-script execution.
Add dry-run mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:02:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:02:40 +0000
Subject: [Koha-bugs] [Bug 14817] New: Encoding issues in columns.def
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

            Bug ID: 14817
           Summary: Encoding issues in columns.def
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

The columns.def file is not opened using the utf-8 encoding.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:02:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:02:44 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11944


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:02:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:02:44 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14817


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817
[Bug 14817] Encoding issues in columns.def
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:04:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:04:05 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:04:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:04:07 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

--- Comment #1 from Jonathan Druart  ---
Created attachment 42524
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42524&action=edit
Bug 14817: Fix encoding issues in columns.def

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the tools/import_patrons.pl page
3/ The field names in the "default values" block should be correctly
encoded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:05:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:05:17 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14808

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:05:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:05:17 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14808

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:05:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:05:17 +0000
Subject: [Koha-bugs] [Bug 14808] Koha 3.20.3 UTF-8 Problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14808

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14813,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14817
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.20                        |master

--- Comment #1 from Jonathan Druart  ---
(In reply to Abdou Yousuf from comment #0)
> Hello All,
> 
> Koha 3.20.3 suffers from UTF-8 Problems in some pages such as, When trying
> to 
> 
> 1- Editing help in Arabic interface it shows garbage like this:
> 
>         ? ?????????? ????? ? ?? ???i?????
> 
>         ?????? ???????? ?????? ???? ????? ???? ????????????        
> ???????????? ????? ?????????? ? ?? ??????????????.
> 
> Although it shows help good in Arabic when reading help.

See bug 14813.

> 2- When trying to import borrowers form tools > Import patrons
> 
> Default values like (Salutation:, Surname, ...etc) looks like (????????:) in
> Arabic interface, Although these terms are ok in Arabic columns.def file.
> 
>                ==============================================
> 
> 3- Also the same thing when trying to build new Guided reports from Guided
> reports wizard.

See bug 14817.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:08:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:08:44 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #22 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #21)
> Not sure I understand - should this move on to QA and the other problems be
> dealt with on another bug - or does this patch need more work?

What you described already exists before this patch set.
The errors handling in this area is really bad and won't be trivial to
implement.
If we don't want to block this one, it should be pushed as it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:24:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:24:19 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #14 from Jonathan Druart  ---
Why do you use "barcode" when manipulating "borrowernumber"?

Did you note that the same issue appears for labels?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:27:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:27:31 +0000
Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41659|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart  ---
Created attachment 42525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42525&action=edit
Bug 14100: Generic solution for language overlay - Item types

Test plan:
1/ update the Schema (misc/devel/update_dbix_class_files.pl)
2/ Translate templates for some languages (es-DE, de-DE for instance)
3/ Enable them in the pref (search for 'lang') for the staff interface
4/ Go on the item type admin page (admin/itemtypes.pl)
5/ Edit one
6/ Click on the 'translate for other languages' link
7/ You are now on the interface to translate the item type's description
in the languages you want. So translate some :)
8/ Go back on the item type list view (admin/itemtypes.pl)
9/ You should see the original description (non translated)
10/ Switch the language
11/ You should see the translated description in the correct language.
If the description is non translated, the original description is
displayed.

12/ On the different page where the item type is displayed, confirm that
the translated description appears.

Think further / Todo:
1/ Update all occurrences of the item type's description (DONE)
2/ Implement for authorised values
3/ Implement for syspref value (at least textarea)
4/ Implement for branch names
5/ Centralize all the translation on a single page in the admin area
...
N/ Implement a webservice to centralize all the translations and give
the ability to sync the item types/authorised values description with
the rest of the world (push and pull).

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:27:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:27:57 +0000
Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41660|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart  ---
Created attachment 42526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42526&action=edit
Bug 14100: (follow-up) Language overlay for item types

Display the translated description for item types in the following pages:
> admin/smart-rules.pl
> catalogue/detail.pl
> catalogue/itemsearch.pl
> catalogue/moredetail.pl
> reports/acquisitions_stats.pl
> reports/bor_issues_top.pl
> reports/cat_issues_top.pl
> reports/catalogue_out.pl
> reports/catalogue_stats.pl
> reports/issues_avg_stats.pl
> reports/issues_stats.pl
> reports/itemslost.pl
> reports/manager.pl
> reports/reserves_stats.pl
> suggestion/suggestion.pl
> tools/export.pl

> Opac:
> opac-detail.pl
> opac-MARCdetail.pl
> opac-search.pl

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:33:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:33:59 +0000
Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include
	deleted items
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Kyle M Hall  ---
I'm unable to reproduce your test failure:

prove t/db_dependent/Members/GetAllIssues.t
t/db_dependent/Members/GetAllIssues.t .. ok
All tests successful.
Files=1, Tests=16,  5 wallclock secs ( 0.02 usr  0.01 sys +  1.06 cusr  0.08
csys =  1.17 CPU)
Result: PASS

(In reply to Aleisha Amohia from comment #16)
> DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting
> transaction at ../t/db_dependent/Members/GetAllIssues.t line 20.
> # Looks like your test exited with 255 before it could output anything.
> ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255
> (wstat 65280, 0xff00)
> Failed 16/16 subtests 
> 
> Test Summary Report
> -------------------
> ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0)
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 16 tests but ran 0.
> Files=1, Tests=0, 56 wallclock secs ( 0.01 usr  0.03 sys +  1.19 cusr  0.22
> csys =  1.45 CPU)
> Result: FAIL
> 
> Setting to Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:35:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:35:30 +0000
Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from
	patron lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

--- Comment #9 from Pete Edwards  ---
This is a really useful improvement - thanks. I have 2 comments:

There is a small typo in the patch. See line 54 in print.tt.
  [% IF ( borrower_count == 1 ) %]Exporting [% borrower_count %] patroncard[%
ELSE %]Exporting [% borrower_count %] patroncards[% END %]a
The "a" at the end is incorrect.

The feature has been added to the Patron Card Creator tool which is where cards
are normally created but the functionality is very oriented towards batches and
in this case there is no batch. This may be a little quirky for the user. They
have to go to "Manage batches" in order to export a list. Can I suggest a few
options? 
  - Describe this feature in the home page of the module
  - Add a link on the left, e.g."Export list"
  - In the Patron Lists module, add an "Export cards" button in the table of
Patron Lists and then, in the list itself allow the user to select some
borrowers and "Export cards" for those selected.

The Export button on the patron list table could be done with the following
changes to patron_lists/lists.tt:
Add: [% INCLUDE 'greybox.inc' %]
Modify the table sorting: { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false,
"bSearchable": false },
Add export column:
  
    
       Export cards
    
  
I know this is not the complete solution as the grey box does not have a Done
button.

I will investigate how to become a contributor to Koha but wanted to make this
suggestion while I work on that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:40:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:40:27 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:40:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:40:30 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

--- Comment #1 from Jonathan Druart  ---
Created attachment 42527
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42527&action=edit
Bug 14811: Do not update permanent_location if location is CART or PROC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:41:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:41:50 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart  ---
Just a quick try to know if it is something like that you expected.
I am not sure to understand the NewItemsDefaultLocation pref, should it affect
item when it's edited?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:42:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:42:24 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

--- Comment #3 from Jonathan Druart  ---
Ok forget that, I've read too quickly the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 16:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 14:42:32 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42527|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:00:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:00:27 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #14 from Pablo AB  ---
Created attachment 42528
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42528&action=edit
Exported list to buggy ISO2709 (~MARC file)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:03:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:03:03 +0000
Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |DUPLICATE

--- Comment #3 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 14811 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:03:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:03:03 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #4 from Jonathan Druart  ---
*** Bug 13026 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:03:26 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Tom Misilo  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:06:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:06:39 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

--- Comment #5 from Jonathan Druart  ---
Created attachment 42529
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42529&action=edit
Bug 14811: Don't update permanent_location with CART or PROC

The permanent_location should not be set to CART or PROC when the item
is edited.
Otherwise we lost an important info.

Test plan:
0/ Set the ReturnToShelvingCart pref
1/ Create an item with location "on_my_shelf"
2/ Check the item in and out
3/ Look at the DB values, location should be "CART" and
permanent_location unchanged (on_my_shelf)
4/ Edit the item, add a note for instance
5/ Without this patch, the permanent_location is erased with 'CART' and
you have definitely lost the info.
With this patch, the permanent_location is unchanged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:07:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:07:08 +0000
Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
           Severity|normal                      |major

--- Comment #6 from Jonathan Druart  ---
At least major!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:12:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:12:26 +0000
Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

--- Comment #5 from Jonathan Druart  ---
So it's a configuration issue, not a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:15:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:15:17 +0000
Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks
 back button after placing hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40824|0                           |1
        is obsolete|                            |

--- Comment #27 from Kyle M Hall  ---
Created attachment 42530
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42530&action=edit
Bug 5144 - Duplicate holds allowed if patron clicks back button after placing
hold

Koha is currently not engineered to handle multiple holds per record.
Until such time that is does, we should not allow them to be created.

Test Plan:
1) Apply this patch
2) Log in to the opac
3) Place a hold
4) Hit the back button on your browser
5) Place the hold again
6) Note the new message

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:17:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:17:12 +0000
Subject: [Koha-bugs] [Bug 14801] Fix Reserves.t
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:17:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:17:51 +0000
Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks
 back button after placing hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #28 from Kyle M Hall  ---
Patch updated!

(In reply to Jonathan Druart from comment #26)
> Be care, AddReserve prototype changed by bug 9809 (contrainst param removed).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:27:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:27:11 +0000
Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding
 and format errors
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997

--- Comment #15 from Jonathan Druart  ---
I got several
  (Separator but not at end of field length=96)
Not sure it's normal.


% yaz-marcdump shelf.iso | grep "^245"
245 00 $a F?sica /  $c Paul A. Tipler $n [volumen 2]

Where does the record come from? Manually cataloged into Koha? z3950 import?

How does look the record using the MARC preview (detail page, link MARC
Preview: Show)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 17:59:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 15:59:54 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #23 from Katrin Fischer  ---
That's ok, I was just not sure what you meant with your last comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:04:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:04:29 +0000
Subject: [Koha-bugs] [Bug 14818] New: Add missing DBIx::Class relationships
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818

            Bug ID: 14818
           Summary: Add missing DBIx::Class relationships
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:05:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:05:32 +0000
Subject: [Koha-bugs] [Bug 14819] New: Add missing DBIx::Class relationships
 - biblio<->biblioitem<->item
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819

            Bug ID: 14819
           Summary: Add missing DBIx::Class relationships -
                    biblio<->biblioitem<->item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:08:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:08:29 +0000
Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships -
 biblio<->biblioitem<->item
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:08:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:08:32 +0000
Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships -
 biblio<->biblioitem<->item
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819

--- Comment #1 from Jonathan Druart  ---
Created attachment 42531
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42531&action=edit
Bug 14819: Add missing DBIx::Class relationships - biblio<->biblioitem<->item

To access the biblio from an item, we should not use the
biblioitemnumber relationship autogenerated by
DBIx::Class::Schema::Loader but create our own one.

Test plan:
Confirm the tests pass and that there is no regression on bug 14726.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:08:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:08:51 +0000
Subject: [Koha-bugs] [Bug 14818] Add missing DBIx::Class relationships
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14819


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819
[Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:08:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:08:51 +0000
Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships -
 biblio<->biblioitem<->item
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14818


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818
[Bug 14818] Add missing DBIx::Class relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 18:29:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 16:29:01 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #130 from Jesse Weaver  ---
(In reply to Katrin Fischer from comment #129)
> Hi Jesse, which is the branch to start with a code review? rancor-submit?

Glad you asked, I've moved it to bz11559:
https://github.com/pianohacker/koha/tree/bz11559

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 19:15:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 17:15:38 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #43 from Katrin Fischer  ---
Hm, it seems I tested the same as you but with very different results... what
could be the difference? My results look worrysome, especially the double
existance of borrower data in borrowers and deletedborrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 19:25:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 17:25:31 +0000
Subject: [Koha-bugs] [Bug 14820] New: SMSSendUsername and SMSSendPassword
 are not listed in the system preferences
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820

            Bug ID: 14820
           Summary: SMSSendUsername and SMSSendPassword are not listed in
                    the system preferences
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Although SMSSendDriver is listed in the system preferences, neither
SMSSendUsername not SMSSendPassword are even though they are used to pass the
username and password to the driver!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 19:42:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 17:42:57 +0000
Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with
 duplicate priorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733

--- Comment #5 from Kyle M Hall  ---
(In reply to Chris Cormack from comment #4)
> This works, but it does have the side effect that in the staff interface
> where it shows the priority when placing a reserve.
> 
> It will say Priority 1 for example
> 
> Then you save it, and now its priority 2 ... I think this will prompt bug
> reports from Librarians. Do we care about that?

That thought had occurred to me, but I didn't take any action on it. We could
change the "Priority" label to "Estimated priority", or just do away with the
field altogether. I'm not sure I see the advantage of having it at all.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 20:04:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 18:04:26 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41226|0                           |1
        is obsolete|                            |

--- Comment #18 from Genevieve Plantin  ---
Created attachment 42532
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42532&action=edit
Bug 8612 - System preference to have custom fields in export csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home ? Tools ? CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

Signed-off-by: Josef Moravec 

Works as expected for me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 20:04:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 18:04:38 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41227|0                           |1
        is obsolete|                            |

--- Comment #19 from Genevieve Plantin  ---
Created attachment 42533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42533&action=edit
Bug 8612 - Cleans basket.tt by using TT blocks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 20:04:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 18:04:48 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #20 from Genevieve Plantin  ---
Created attachment 42534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42534&action=edit
Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use
GetBasketAsCSV instead

GetBasketAsCSV now has a new argument the profile_csv_id, when this param is
defined, it loads the profile_content, searches the value of the predefined
fields and assembles the data to create the output of the csv file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:17:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:17:05 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #15 from Genevieve Plantin  ---
Created attachment 42535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42535&action=edit
Bug 12446 - Displayed button Add guarantee in Details section

The button Add guarantee wasn't in the toolbar section in Details. It is now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:40:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:40:59 +0000
Subject: [Koha-bugs] [Bug 14821] New: Don't show item in checked in list,
 when it wasn't checked in
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

            Bug ID: 14821
           Summary: Don't show item in checked in list, when it wasn't
                    checked in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This is what currently happens:

- Unset AnonymousPatron
- Set a patrons history to "never"
- Check in an item from this patron's account
- It should show an error message, but the item will still be listed in the
  list of checked-in items

We should only show an error message or at least a helpful note that the item
has not really been returned in the table below.

There might be other cases where this happens - so could be a more general fix
is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:41:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:41:27 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14821

--- Comment #24 from Katrin Fischer  ---
I have filed a separate bug for the 'check-in list' issue: Bug 14821

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:41:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:41:27 +0000
Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list,
 when it wasn't checked in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14655

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:46:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:46:56 +0000
Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not
 listed in the system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10784,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13029
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Kyle, I found 2 related bugs: bug 10784 and 13029.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:46:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:46:56 +0000
Subject: [Koha-bugs] [Bug 10784] SMS-related code needs improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14820

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 21:46:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 19:46:56 +0000
Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to
	SMS::Send drivers
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14820

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:22 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #25 from Katrin Fischer  ---
Created attachment 42540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42540&action=edit
[PASSED QA] Bug 14655: Add a warning if the checkin will fail

On the checkin and checkout page, the checkin will fail if the patron
has requested the privacy and the AnonymousPatron is not correctly set.

This patch adds a warning message on both pages.

Test plan:
0/ Be sure you don't have any patron with privacy=2 (Never)
1/ Set OPACPrivacy, not AnonymousPatron
2/ Go on the checkin, you should a warning (same as before this patch).
3/ Set the privacy=2 for a patron
4/ Go on the circulation page, a warning should appear (for this
specific patron)
5/ Check an item out to this patron
6/ Check the item in on the checkin page.
The item is not checked in and you get a specific message for this
patron.

Confirm other/correct situations don't trigger the messages.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:25 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #26 from Katrin Fischer  ---
Created attachment 42541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42541&action=edit
[PASSED QA] Bug 14655: Add a warning on the about page if patrons have
requested privacy

New warning on the about page if at least a patron has requested a
privacy on checkin but the AnonymousPatron is not set to a valid patron.

Works as expected.
Signed-off-by: Marc V?ron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:58 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42517|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:29 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

--- Comment #27 from Katrin Fischer  ---
Created attachment 42542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42542&action=edit
[PASSED QA] Bug 14655: Fix wording

Signed-off-by: Katrin Fischer 
Fixed a missing space after Error: :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:56 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42049|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:54 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42048|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:00:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:00:52 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:16:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:16:26 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

--- Comment #10 from Genevieve Plantin  ---
Ok I'm sorry and thank you, I'll be careful next time ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:26:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:26:40 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:26:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:26:43 +0000
Subject: [Koha-bugs] [Bug 14813] Encoding issues when editing the help
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42515|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer  ---
Created attachment 42543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42543&action=edit
[PASSED QA] Bug 14813: Fix encoding issues on editing help pages

It has been introduced by bug 11944.

Test plan:
1/ Install and set the fr-FR language (or ar-Arab).
2/ Go on the help page and edit it.
3/ The textarea should not contain encoding issues with this patch.

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:38:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:38:16 +0000
Subject: [Koha-bugs] [Bug 14822] New: Fine totals on circulation.pl are
	confusing
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822

            Bug ID: 14822
           Summary: Fine totals on circulation.pl are confusing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The Totals column showing fine totals of checked out items does not display
manually invoiced items -- this causes confusion when librarians compare the
total on the circulation page with the total on the fines page -- could we add
a note on the circulation page which says 'Manual invoices not included'?.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:39:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:39:15 +0000
Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:39:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:39:18 +0000
Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41944|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer  ---
Created attachment 42544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42544&action=edit
[PASSED QA] Bug 14710: Make the export checkout list export only the checked
out item infos

This has been introduced by bug 11703.

Bug 13190 should have been fixed it.

If the pref ExportWithCsvProfile is defined with a MARC CSV profile and
it contains item infos to display, only info from the checked out item
should be displayed.

Test plan:
0/ Don't apply this patch
1/ Create a biblio with 1+ items
2/ Check one of the item out to a patron
3/ Define a CSV profile which contains item fields ("245$a|952$p" for instance)
4/ Export the item (from circ/circulation/pl) using the CSV option
Note that the csv contains the barcode from all items
5/ Apply this patch and repeat 4.
6/ Note that the csv contains only the barcode from the checked out
item.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:42:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:42:33 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

--- Comment #15 from Katrin Fischer  ---
Created attachment 42545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42545&action=edit
[PASSED QA] Bug 14197: Remove the warning on destroying TestBuilder objects

This module will be called by db_dependent tests, which already create a
transaction.
TestBuilder creates a new one (which is certainly useless) and the
rollback does not do anything.

To see the warning see patches on bug 14045.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:42:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:42:36 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

--- Comment #16 from Katrin Fischer  ---
Created attachment 42546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42546&action=edit
[PASSED QA] Bug 14197: TestBuilder - Remove the error on starting the
transaction

DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560.
DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not
match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway
at t/lib/TestBuilder.pm line 363

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:43:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:43:34 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42057|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:43:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:43:43 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42058|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 22:43:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 20:43:50 +0000
Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 23:04:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 21:04:07 +0000
Subject: [Koha-bugs] [Bug 10478] Do we need a sequential number generator?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 23:12:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 21:12:30 +0000
Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 23:19:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 21:19:16 +0000
Subject: [Koha-bugs] [Bug 14822] Fine totals on circulation.pl don't include
 manually added fees
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Fine totals on              |Fine totals on
                   |circulation.pl are          |circulation.pl don't
                   |confusing                   |include manually added fees

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 23:32:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 21:32:22 +0000
Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will
 create a new batch per patron added
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 14 23:35:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 21:35:40 +0000
Subject: [Koha-bugs] [Bug 14823] New: Item search publication year search
 appears to be broken for MARC21
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14823

            Bug ID: 14823
           Summary: Item search publication year search appears to be
                    broken for MARC21
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When using the 'publication date' search option in the item search in a MARC21
installation, the search seems to return all items instead of limiting to the
searched year. The years shown in the results table don't match the search
term.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 00:22:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Sep 2015 22:22:32 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #6 from Jesse Weaver  ---
Created attachment 42547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42547&action=edit
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to
GetNormalizedUPC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 02:00:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 00:00:38 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

kholt at roseville.ca.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholt at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 02:31:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 00:31:30 +0000
Subject: [Koha-bugs] [Bug 14818] Add missing DBIx::Class relationships
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 02:31:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 00:31:46 +0000
Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships -
 biblio<->biblioitem<->item
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819

David Cook  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:08:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:08:35 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #147 from Julian Maurice  ---
I have a few concerns using x-mojo-around feature of Swagger2:
1/ It is marked as experimental (from the POD: "This feature is EXPERIMENTAL
and can change without notice.")
2/ It is introduced only in Swagger2 0.45 and thus we'll need to repackage it
for Debian (packaged version in debian.koha-community.org is only 0.31)

I think these two points will block integration, so I'm wondering if it's not
better to include the patch in a new bug. What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:11:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:11:33 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #44 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #43)
> Hm, it seems I tested the same as you but with very different results...
> what could be the difference? My results look worrysome, especially the
> double existance of borrower data in borrowers and deletedborrowers.

Tested again right now, and it works for me.
Nothing in the logs?
What happen if you use the tool using the 2 other criteria (not borrowed since,
expiration date)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:35:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:35:23 +0000
Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list,
 when it wasn't checked in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:35:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:35:25 +0000
Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list,
 when it wasn't checked in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

--- Comment #1 from Jonathan Druart  ---
Created attachment 42548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42548&action=edit
Bug 14821: Do not list not returned items

On the checkin page, the table is always filled with info of the scanned
barcode, even if the checkin has failed.
When the checkin fails, there is already an error displayed, so there is
no need to keep a row for fails.

Test plan:
Confirm that the failed checkins don't appear anymore in the checkin
table.
- checkin an item which is not issued;
- BlockReturnOfWithdrawnItems is set and item is withdrawn;
- Not returned at the right place;
- privacy=2 and AnonymousPatron not correctly set;

Before this patch this behavior existed only for bad barcode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:37:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:37:05 +0000
Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list,
 when it wasn't checked in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|http://bugs.koha-community. |
                   |org/bugzilla3/show_bug.cgi? |
                   |id=14655                    |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |14655


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655
[Bug 14655] Cannot checkin without Anonymous Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:37:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:37:05 +0000
Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14821
           See Also|http://bugs.koha-community. |
                   |org/bugzilla3/show_bug.cgi? |
                   |id=14821                    |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821
[Bug 14821] Don't show item in checked in list, when it wasn't checked in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:37:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:37:40 +0000
Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list,
 when it wasn't checked in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:42:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:42:29 +0000
Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be
 accessible by UPC as well as ISBN
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #7 from Jonathan Druart  ---
Jesse, since I cannot test the patch, I would like to get a signoff on the 2
last patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:52:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:52:50 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #62 from Jonathan Druart  ---
Please remove tabs and fix the author in the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 09:54:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 07:54:11 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #28 from Jonathan Druart  ---
What about comments 23&26?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:00:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:00:42 +0000
Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC
	via PayPal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #18 from Jonathan Druart  ---
(In reply to Kyle M Hall from comment #17)
> (In reply to Jonathan Druart from comment #14)
> > (In reply to Galen Charlton from comment #5)
> > > Comment on attachment 24754 [details] [review] [review] [review]
> > > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> > > 
> > > Review of attachment 24754 [details] [review] [review] [review]:
> > > -----------------------------------------------------------------
> > > 
> > > ::: opac/opac-account-pay-paypal-return.pl
> > > @@ +20,5 @@
> > > > +
> > > > +use strict;
> > > > +use warnings;
> > > > +use utf8;
> > > > +
> > 
> > > Modern::Perl
> > > I see no non-ASCII characters in the source.
> > 
> > Still exists.
> > 
> 
> I'm not sure what this means. Can you explain?

1/ use strict;use warnings; should be replaced with use Modern::Perl;
2/ You are using the utf8 pragma but there is no need of it, you don't have
non-ASCII characters in the file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:05:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:05:28 +0000
Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver  to crash
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
Colin,
Wouldn't it possible to move the duedatefromissue subroutine to a method in
C4::SIP::ILS::Transaction?
It'd avoid c/p code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:14:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:14:34 +0000
Subject: [Koha-bugs] [Bug 14824] New: Fix sorting of Norwegian vowels
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

            Bug ID: 14824
           Summary: Fix sorting of Norwegian vowels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: magnus at libriotech.no
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

Currently, if you sort bibliographic search results by title, the Norwegian
wovels ??? will not be sorted correctly. Specifically, with a result list
containing 4 results, I was getting this for an A-Z (or A-?) sort: 

?...
?...
H...
?...

Which is just about as incorrect as it gets. 

As documented here: http://www.indexdata.com/zebra/doc/character-map-files.html
sorting in Zebra is governed by the "lowercase" and "uppercase" setting in
sort-string-utf.chr. That page suggests this for scandinavian languages: 

lowercase {0-9}{a-y}?z?????
uppercase {0-9}{A-Y}?Z?????

But with that config I got warnings during rebuild zebra: 

10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'
10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'
10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'
10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'
10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'
10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from '?'

I assume this is because these characters are already mapped to other chars. 

So I will propose a patch that uses this simplified setting:

lowercase {0-9}{a-z}???
uppercase {0-9}{A-Z}???

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:18:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:18:38 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #86 from Jonathan Druart  ---
One question: How librarians will know this feature exists (No, they don't read
release notes)?
There is no way to know about it.


Gaetan: Please don't add the "[SIGNED-OFF]" string in the commit messages :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:22:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:22:01 +0000
Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid
 is now deleted record will fail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart  ---
IMO this is really not a good idea.
I would prefer to see this logger question moved somewhere else and let this
patch continues this way without it.

(Just to say, my logger proposal allowed you to display a "caller", which
permit to know where we are).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:23:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:23:03 +0000
Subject: [Koha-bugs] [Bug 14620] Contact information validations
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #15 from Jonathan Druart  ---
Blocked by bug 7174.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:23:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:23:44 +0000
Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid
 contact information in messaging preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart  ---
Blocked by bug 14620 which is blocked by bug 7174.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:41:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:41:14 +0000
Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some
 MARC21 leader plugins
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #14 from Jonathan Druart  ---
Are we sure they are useless?
Maybe there is a bug (the plugin_name parameter could be wrong) in them.

The differences are, for marc21_leader_computerfile vs marc21_leader:
  my $f2023 = substr( $result, 20, 4 );
  "f2023"   => $f2023,
These 2 lines exist in marc21_leader, no in marc21_leader_computerfile.

Could we ask for a functional point of view, to know if we should remove them
or fix them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:42:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:42:43 +0000
Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 10:42:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 08:42:46 +0000
Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

--- Comment #1 from Magnus Enger  ---
Created attachment 42549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42549&action=edit
Bug 14824 - Fix sorting of Norwegian vowels

Currently, Norwegian vowels are not sorted correctly, even when
you have chosen "nb" as the ZEBRA_LANGUAGE during installation.

To test:
- Make sure you have three records with titles that begin with ???
  respectively
- Do a search that turns up those three records and some others, and
  sort the results by title, bot ascending and descending.
- Verify that ??? is shown in some weird order.
- Edit your sort-string-utf.chr* so it is in line with the current
  patch. It should include these two lines:
  lowercase {0-9}{a-z}???
  uppercase {0-9}{A-Z}???
- Restart Zebra and reindex all the records, e.g.:
  $?sudo koha-restart-zebra 
  $?sudo koha-rebuild-zebra -f -v 
- Do the search again, make sure you order by title and check that
  ??? are sorted in the order of 1. ? 2. ? 3. ?, and after all other
  characters

* = If you are on a gitified install, you need to edit this file:
/etc/koha/zebradb/lang_defs//sort-string-utf.chr
NOT the file in your git clone (yeah, i wasted some time there...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:14:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:14:15 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #19 from Jonathan Druart  ---
 FAIL   misc/cronjobs/cleanup_database.pl
   FAIL   valid
                Global symbol "$zebraqueue_days" requires explicit package name 
                Global symbol "$allDebarments" requires explicit package name 
                Global symbol "$verbose" requires explicit package name 
                Global symbol "$pDebarments" requires explicit package name 
                Global symbol "$pZ3950" requires explicit package name 
                Global symbol "$pUnvSelfReg" requires explicit package name 
                Global symbol "$fees_days" requires explicit package name 
                Global symbol "$sess_days" requires explicit package name 
                    $help"
                Global symbol "$pExpSelfReg" requires explicit package name 
                Global symbol "$pListShareInvites" requires explicit package
name 
                Global symbol "$purge_merged" requires explicit package name 
                Global symbol "$sessions" requires explicit package name 
                Global symbol "$help" requires explicit package name 
                syntax error 
                Scalar found where operator expected 
                Global symbol "$pLogs" requires explicit package name 
                Global symbol "$pSearchhistory" requires explicit package name 
                        (Missing operator before $help?)
                Global symbol "$mail" requires explicit package name 
                misc/cronjobs/cleanup_database.pl had compilation errors.
                Global symbol "$pImport" requires explicit package name 

 FAIL   t/db_dependent/Accounts.t
   FAIL   spelling
                 postive  ==> positive
   FAIL   valid
                Global symbol "$sth" requires explicit package name 
                t/db_dependent/Accounts.t had compilation errors.
                Global symbol "$borrower" requires explicit package name 

And add the "Bug XXXXX" in the commit messages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:14:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:14:47 +0000
Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager
 to better manage permissions for testing.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

--- Comment #21 from Olli-Antti Kivilahti  ---
Created attachment 42550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42550&action=edit
Bug 14540 - PermissionManager - Hotfix check_api_auth, remove flags.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:29:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:29:24 +0000
Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in
 C4::Context instead of dbh
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

--- Comment #19 from Fridolin SOMERS  ---
(In reply to Chris Cormack from comment #18)
> Please see 
> 
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778
> 
> The Author of DBIx::Class recommends we shouldn't use DBIx::Connector and I
> tend to agree

Oki, this is even better than this patch, great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:29:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:29:56 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:33:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:33:51 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #13 from Fridolin SOMERS  ---
Great patch, but in this case C4::Context depends on C4::Database and
C4::Database depends on C4::Context :(
Should we move database handler method to C4::Database ?
I know it will change a lot of code but isn't it more logical ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:38:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:38:31 +0000
Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not
 listed in the system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:38:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:38:34 +0000
Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not
 listed in the system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820

--- Comment #2 from Jonathan Druart  ---
Created attachment 42551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42551&action=edit
Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword

These 2 system preferences are missing from the sysprefs.sql file.

Test plan:
Execute the updatedatabase script and confirm that the 2 prefs are now
in the systempreferences table.
Search for "sms" in the system preferences search box, you should see
the 3 prefs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:38:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:38:39 +0000
Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not
 listed in the system preferences
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:40:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:40:03 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #14 from Jonathan Druart  ---
(In reply to Fridolin SOMERS from comment #13)
> Great patch, but in this case C4::Context depends on C4::Database and
> C4::Database depends on C4::Context :(
> Should we move database handler method to C4::Database ?
> I know it will change a lot of code but isn't it more logical ?

Yes of course it is.
But I would like to get this one into master and then provide a huge change to
correct all occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:43:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:43:41 +0000
Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost
 items checks them in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

--- Comment #4 from Jonathan Druart  ---
ping?
Is this really critical?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:44:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:44:47 +0000
Subject: [Koha-bugs] [Bug 13073] Search in Russian and in Armenian
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13073

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 11:49:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 09:49:51 +0000
Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost
 items checks them in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

--- Comment #5 from Katrin Fischer  ---
I think yes. If it's true it unexpectedly checks items in, then that's really
bad.

I think the problem might be that Koha ususally wants to return an item if it's
set to lost... and only the longoverdue script manages to avoid this?

What about: only trigger the check in, if the lost status is changed in the
batch edit?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:06:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:06:35 +0000
Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via
	plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

--- Comment #7 from Jonathan Druart  ---
I can make the change, globally.
Someone should tell me which fields should be mandatory for each authority
type.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:08:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:08:41 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42169|0                           |1
        is obsolete|                            |

--- Comment #18 from Lari Taskula  ---
Created attachment 42552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42552&action=edit
Bug 13906: (follow-up) - MessageQueueFactory for adding messages to
message_queue

C4::Letters has inconsistent hash key naming in some of the subroutines
(EnqueueLetter vs. GetQueuedMessages). Modified the
naming to match the database format so that hopefully it won't make our hair so
grey with the factory at least.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:09:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:09:50 +0000
Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14803


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
[Bug 14803] Rental and fine fees are not updating on circulation screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:09:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:09:50 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
 circulation screen
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |11703

--- Comment #1 from Jonathan Druart  ---
Kyle,
Have you any idea how we could fix that? Looks tricky.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703
[Bug 11703] Convert checkouts table to ajax datatable
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:10:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:10:24 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42505|0                           |1
        is obsolete|                            |

--- Comment #15 from Lari Taskula  ---
Created attachment 42553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42553&action=edit
Bug 14723 - Additional delivery notes to messages

Fixes MessageQueueFactory parameters to match database format.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:29:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:29:31 +0000
Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's
 details, after LOGOUT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart  ---
I have tried to set force_no_caching to output_html_with_http_headers, but I
always get a "Document Expired" message from my browser (iceweasel), which is
not really kind for users.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:32:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:32:39 +0000
Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of
 lists in the OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |3.20

--- Comment #31 from Jonathan Druart  ---
A fix could be submitted on top of 3.20, in hopes that big 14544 will be into
3.22.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:48:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:48:07 +0000
Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost
 items checks them in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:48:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:48:10 +0000
Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost
 items checks them in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

--- Comment #6 from Jonathan Druart  ---
Created attachment 42554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42554&action=edit
Bug 12311: Do not return a lost item if modified in a batch

If a item is lost and issued, and you modify it in a batch, the item
will be marked as returned. It should only be returned if the item is
marked as lost.

Test plan:
1/ Check an item out and mark it as lost
2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for
instance)
3/ The item should still be issued to the patron
4/ Edit it in a batch and edit the lost value, marked it as not lost
5/ The item should still be issued to the patron
6/ Edit it in a batch and edit the lost value, marked it as lost
7/ The item should have been returned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:48:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:48:24 +0000
Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost
 items checks them in
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 12:49:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 10:49:21 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

--- Comment #28 from Olli-Antti Kivilahti  ---
Created attachment 42555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42555&action=edit
Bug 13920: 5.1. API authentication system - Swagtenticator authentication -
Replace Swagtenticator with x-around-action -hook.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 14:46:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 12:46:35 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #20 from Kyle M Hall  ---
Created attachment 42556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42556&action=edit
Bug 14402 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 14:47:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 12:47:07 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Viktor Sarge  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

--- Comment #26 from Viktor Sarge  ---
I love this patch a lot, but am I the only one who seems to get nothing in the 
[% issue.item.biblio.title %]? I only get the barcode and due date (both
production server and my dev-install). Since I seem to remember this one
working fine I'd just like to hear from others before I do any really extensive
testing on my setup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 14:50:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 12:50:07 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 14:50:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 12:50:10 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42556|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall  ---
Created attachment 42557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42557&action=edit
Bug 14402 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:03:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:03:31 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:03:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:03:35 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42411|0                           |1
        is obsolete|                            |

--- Comment #40 from Mirko Tietgen  ---
Created attachment 42558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42558&action=edit
Bug 14321: Add two columns to uploaded_files

This patch adds uploaded_files.public and permanent.
Public will be used later to mark uploaded files as available via OPAC.
Permanent will be used to make the distinction between temporary and
permanent storage.

The db rev sets both flags for all current records (uploaded via the
plugin from BZ 6874).

Test plan:
[1] If you tested this before, drop the column public first.
[1] Run the dbrev.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:05:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:05:08 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42412|0                           |1
        is obsolete|                            |

--- Comment #41 from Mirko Tietgen  ---
Created attachment 42559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42559&action=edit
Bug 14321: Introduce Koha::Upload

This patch introduces Koha::Upload. It will replace the modules
C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874).
It also includes a new unit test.

NOTE: This unit test will replace the test for UploadedFiles.pm. It will no
longer use dependency Test::CGI::Multipart. We are now mocking CGI and its
hook to achieve the same result.

Test plan:
[1] Run t/db_dependent/Upload.t.
    Note that if you see a WARNING, you will still need to add an entry
    upload_path to your koha-conf.xml. Or you need to give write
    permission to your Koha instance user for that folder.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:08:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:08:55 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42413|0                           |1
        is obsolete|                            |

--- Comment #42 from Mirko Tietgen  ---
Created attachment 42560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42560&action=edit
Bug 14321: Integrate Upload.pm into Koha

This patch makes the following changes to achieve that:
[1] Use Upload.pm in stage-marc-import.pl, upload-cover-image.pl,
    offline_circ/process_koc.pl and enqueue_koc.pl.
[2] A new file-upload.js replaces file-upload.inc in the associated template.
    We now use ajax to get progress figures instead of launching perl script
    upload-file-progress.
    The js changes now also allow for aborting a file upload.
[3] Adds a tools/upload script and template. It allows to upload multiple
    files at once.
[4] Makes upload-file return error messages in JSON. For a multiple upload,
    we could have some files with errors and others without errors.
    The upload is now marked as Failed only if there was no upload at all.
[5] The upload plugin is converted to use tools/upload with plugin param.
    Deleting an upload is now presented via the search results form.

NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was
hidden and no longer used (with associated code in process_koc.pl). When a
file has been uploaded, I display the form again (with the Apply directly
button). The code still works.

NOTE: We fix an error in upload-file from one of the patches of bug 6874.
The userid of the Koha admin user is passed to haspermission, but we
should pick the userid from the session.

NOTE: Bug 14686 will add a specific permission for tools/upload.pl, and
will add the tools/upload script to the Tools menu.
For now, you need edit_catalogue to start upload.pl and you will
additionally need a permission like upload_local_cover_images
to successfully upload a new file.

Test plan:
[1] Upload a marc file in stage-marc-import. (This is temp storage.)
[2] Check new entry in table uploaded_files. Look for the file in your
    temporary directory (/tmp ?), subfolder koha_upload.
    Bonus: Remove permissions on this subfolder. Retry, check error and
    restore permissions again.
[3] Upload another (larger) file and abort the upload. Check table and
    directory again. You should have a partial file, but no record.
[4] Verify that Stage for import still works as expected.
[5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can
    test an individual image or a zip file including images and a file
    called datalink.txt (with lines biblionumber,filename).
[6] Test uploading a offline circulation file:
    Enable AllowOfflineCirculation, and create a koc file (plain text):
    Line1: Version=1.0\tA=1\tB=2
    Line2: 2015-08-06 08:00:00 345\treturn\t[barcode]
    Note: Replace tabs and barcode. The number of tabs is essential!
    Checkout the item with your barcode.
    Go to Offline circulation file upload. Upload and click Apply directly.
    Checkout again. Upload again, click Add to offline circulation queue.
[7] Upload three files via tools/upload.pl with a category and marked as
    public. Check the results in the table.
    Verify that you can download the file in OPAC without being logged in.
[8] Pick one new file and one of the files of step 7. Upload them in the
    same category. One upload should succeed. Check for reported error.
[9] Connect upload.pl to field 856$u.
    Goto Cataloguing editor.
    In an empty 856$u, click the tag editor. Upload a file and click Choose.
    Save the record. Open the record in the OPAC and click the link.
    Copy this link to your clipboard for next step.
[A] Go back to editor. Click the tag editor on the same 856 field.
    Choose for Delete.
    Open the link in your clipboard again. Error message?
[B] Check the process of upload, search, download and delete of an upload
    with some diacritical characters in the filename. (Bonus points for
    adding special chars in the category code.)
    Note: You can add categories via authorized values, UPLOAD key.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:09:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:09:12 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Mirko Tietgen  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42414|0                           |1
        is obsolete|                            |

--- Comment #43 from Mirko Tietgen  ---
Created attachment 42561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42561&action=edit
Bug 14321: Final cleanup, removing obsolete files

The new Upload.pm, unit test and file-upload.js obsolete a number of
files, including an older jQuery plugin.
The test files progressbar.pl and progressbarsubmit.pl are outdated and
do not serve any purpose in this form. (Actually, we could argue if they
should be here or just be part of a debugging phase.)

Test plan:
[1] Git grep on file-progress, file-upload.inc, UploadedFile,
    ajaxfileupload, ajaxFileUpload
    UploadedFile: Only a reference to DBIx file is found
    ajaxfileupload: Only release notes
[2] Upload a file with tools/upload and stage-marc-import.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:20:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:20:07 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #44 from Mirko Tietgen  ---
Works for me. One thing I noticed is that in the cataloguing editor, having the
plugin and add/remove field options next to each other looks a little off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:40:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:40:02 +0000
Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 15:59:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 13:59:41 +0000
Subject: [Koha-bugs] [Bug 14748] REST API Testing framework
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

--- Comment #3 from Lari Taskula  ---
Created attachment 42562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42562&action=edit
Bug 14748: (follow-up) Fix $testPackageName

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 16:03:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 14:03:53 +0000
Subject: [Koha-bugs] [Bug 14748] REST API Testing framework
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |larit at student.uef.fi

--- Comment #4 from Lari Taskula  ---
Above patch fixes the following errors in testREST.pl: 

No test package defined for API route ... You must define it in
t::db_dependent::Api::Apiv1::Borrowers-> ....

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:07:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:07:21 +0000
Subject: [Koha-bugs] [Bug 14825] New: Accounts Rewrite Omnibus
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

            Bug ID: 14825
           Summary: Accounts Rewrite Omnibus
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This bug is meant to be an omnibus to encompass the different features of the
Accounts Rewrite, but to break them down into smaller more easily testable
parts that do not radically alter all at once.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:09:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:09:04 +0000
Subject: [Koha-bugs] [Bug 14826] New: Resurrect account offsets table
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

            Bug ID: 14826
           Summary: Resurrect account offsets table
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The account offsets table should be used to track increments and decrements of
fines via payments and credits, as well as fine accruals. It should be able to
match fees to payments and visa versa, so we can know which fee was paid by a
given payment, and which payments applied to a given fee.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:09:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:09:11 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:09:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:09:11 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14826


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:11:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:11:24 +0000
Subject: [Koha-bugs] [Bug 14827] New: Merge various subroutines for paying
	fees into one
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

            Bug ID: 14827
           Summary: Merge various subroutines for paying fees into one
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle.m.hall at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Right now there are a number of subroutines used to make payments in Koha, all
of which have slightly varying behavior. It would be good to merge these into a
single all singing all dancing sub.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:11:43 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825, 14826


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:11:43 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14827


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:11:43 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14827


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:11:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:11:48 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:34 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:34 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14826, 14827                |
           Assignee|gmcharlt at gmail.com          |kyle.m.hall at gmail.com


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:34 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:47 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14826


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:47 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14827                       |
             Blocks|                            |14825
           Assignee|gmcharlt at gmail.com          |kyle.m.hall at gmail.com


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:12:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:12:47 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14826                       |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:13:16 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825, 14826


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:13:16 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14827


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:13:16 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14827


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827
[Bug 14827] Merge various subroutines for paying fees into one
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:14:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:14:07 +0000
Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|6427                        |14826
                 CC|                            |kyle.m.hall at gmail.com


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427
[Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:14:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:14:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2696                        |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
[Bug 2696] Fine Payments Should Show What Was Paid For
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:14:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:14:07 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2696


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
[Bug 2696] Fine Payments Should Show What Was Paid For
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:14:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:14:19 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6427

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:14:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:14:19 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14825

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:15:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:15:00 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:17:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:17:52 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:18:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:18:10 +0000
Subject: [Koha-bugs] [Bug 14373] Disallow payment of accruing fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:18:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:18:24 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42552|0                           |1
        is obsolete|                            |

--- Comment #19 from Lari Taskula  ---
Created attachment 42563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42563&action=edit
Bug 13906: (follow-up) - MessageQueueFactory for adding messages to
message_queue

Fixes MessageQueue stash name to lower case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:18:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:18:47 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
 circulation screen
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Heather Braum  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:20:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:20:37 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #24 from Genevieve Plantin  ---
Created attachment 42564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42564&action=edit
Bug 6934 New report Cash Register Statistics

This patch creates a new report that outputs cash register stats for a specific
period.

Changes:

koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc               - Added
cash register report link
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt  - new
file
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt         - Added
cash register report link
reports/cash-register_stats.pl                                          - new
file

Testing:

I Apply the patch

0) Go to reports home page (Home ? Reports);
1) Validate link << Cash Register >> under Statistics wizards;
2) Click link;
3) Validate page with three fieldsets;
4) Chose a date interval, a transaction type, a library and an output;
5) Validade the result.

Signed-off-by: Nicole 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:20:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:20:49 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #25 from Genevieve Plantin  ---
Created attachment 42565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42565&action=edit
Bug 6934 - Fix code in CashRegisterStats (dataTables pagination, more accurate
descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils)

I cleaned up the code according to comment #23. I got rid of
DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt.
C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are
changed and the pagination for the dataTables is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:25:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:25:11 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Genevieve Plantin  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |genevieve.plantin at inlibro.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:47:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:47:26 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #45 from Marcel de Rooy  ---
(In reply to Mirko Tietgen from comment #44)
> Works for me. One thing I noticed is that in the cataloguing editor, having
> the plugin and add/remove field options next to each other looks a little
> off.

Great. Thanks for signing off. Yes, the popup form could still be further
improved in terms of styling. We can do that on a new report..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 17:52:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 15:52:51 +0000
Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

--- Comment #58 from Jonathan Druart  ---
Comment on attachment 39848
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39848
Bug 7981 - Remove HomeOrHoldingBranchReturn syspref

Review of attachment 39848:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=39848)
-----------------------------------------------------------------

::: circ/returns.pl
@@ +265,5 @@
>          );
>      }
>  
> +    # make sure return branch respects home branch circulation rules, default to homebranch
> +    my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype)->{'returnbranch'} || "homebranch";

I think there is a problem here.
$itemtype is a hashref returned by C4::ItemType->get, but GetBranchItemRule
expects a string.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:31:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:31:57 +0000
Subject: [Koha-bugs] [Bug 14828] New: Move the item types related code to
	Koha::ItemTypes
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

            Bug ID: 14828
           Summary: Move the item types related code to Koha::ItemTypes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:40:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:40:34 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

--- Comment #1 from Jonathan Druart  ---
Created attachment 42566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42566&action=edit
Bug 14828: Add Koha::ItemType[s] classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:40:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:40:37 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

--- Comment #2 from Jonathan Druart  ---
Created attachment 42567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42567&action=edit
Bug 14828: use Koha::ItemType[s] in admin/itemtypes

Test plan:
Add/edit/remove item types from the administration module
(admin/itemtypes.pl).
You should get message feedback after each action.
Don't forget to play with the image and try to remove an item type
linked to records (you should not be able to remove it).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:40:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:40:40 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

--- Comment #3 from Jonathan Druart  ---
Created attachment 42568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42568&action=edit
Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used

This patch mainly replaces C4::ItemType->all with
Koha::ItemTypes->search.

Test plan:
At the places where the C4::ItemType module was used, confirm there is
no regression:
- acqui/neworderempty.pl
- catalogue/itemsearch.pl
- admin/item_circulation_alerts.pl
and the 2 cataloguing plugins:
- marc21_linking_section.pl
- unimarc_field_4XX.pl

QA step:
prove t/db_dependent/HoldsQueue.t should return green
Note that the tests were buggy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:40:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:40:43 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

--- Comment #4 from Jonathan Druart  ---
Created attachment 42569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42569&action=edit
Bug 14828: Remove old package and tests

C4::ItemType can be now removed safely, there is no use of this module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:41:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:41:05 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
         Depends on|                            |14100
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10363


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100
[Bug 14100] Generic solution for language overlay
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:41:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:41:05 +0000
Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14828


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828
[Bug 14828] Move the item types related code to Koha::ItemTypes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:41:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:41:05 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14828

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:44:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:44:50 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

--- Comment #5 from Jonathan Druart  ---
The next step will be to replace C4::ItemTypes calls with
Koha::ItemTypes->search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 18:51:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 16:51:31 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart  ---
Victor, any chance to get your signoff on this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:06:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:06:07 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

jvr  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from jvr  ---
I already tested it and it works OK!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:11:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:11:45 +0000
Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of
 the page you are viewing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:26:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:26:38 +0000
Subject: [Koha-bugs] [Bug 14827] Merge various subroutines for paying fees
	into one
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:26:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:26:49 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:27:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:27:05 +0000
Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 19:46:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 17:46:42 +0000
Subject: [Koha-bugs] [Bug 14828] Move the item types related code to
	Koha::ItemTypes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 21:03:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 19:03:34 +0000
Subject: [Koha-bugs] [Bug 14782] can't search by username anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 21:44:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 19:44:06 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

J Schmidt  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 22:11:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 20:11:41 +0000
Subject: [Koha-bugs] [Bug 13972] Include fields from subscription and serial
 table in serial notification email
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 15 23:54:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 21:54:33 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #87 from Gaetan Boisson  ---
I think it should go in the manual, in the section that documents the
OAI-PMH:ConfFile syspref. (Somewhere in this section :
http://translate.koha-community.org/manual/master/en/html-desktop/#webserviceprefs
)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 00:50:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Sep 2015 22:50:58 +0000
Subject: [Koha-bugs] [Bug 14829] New: Wrong shortcuts in module "cataloging"
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

            Bug ID: 14829
           Summary: Wrong shortcuts in module "cataloging"
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mik at adminkuhn.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

There are three shortcuts or hotkeys in the Koha staff client:

* Alt + U = Check out
* Alt + R = Check in
* Alt + Q = Search the catalog

As I understand these shortcuts should work all over the staff client, and
mostly they do. In Koha 3.20 though when going to Koha menu "Cataloging" they
don't work as expected. Instead here the mapping is:

* Alt + U = Search the catalog
* Alt + R = Cataloging search
* Alt + Q = Check out

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 02:48:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 00:48:11 +0000
Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937

NML  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |meteolib at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 04:28:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 02:28:28 +0000
Subject: [Koha-bugs] [Bug 14830] New: anonymous purchase suggestions are
 invisible/inaccessible in staff interface
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830

            Bug ID: 14830
           Summary: anonymous purchase suggestions are
                    invisible/inaccessible in staff interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

this seems to be due to anon. suggestions being created with a NULL branchcode

more info to come...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 08:36:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 06:36:58 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec  ---
The patch works as expected for me, but there is another place to fix: 

https://github.com/Koha-Community/Koha/blob/master/C4/Reports/Guided.pm#L875

And there is used this routine from Reports::Guided

https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L37
https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L374

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 09:03:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 07:03:47 +0000
Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #15 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Fridolin SOMERS from comment #13)
> > Great patch, but in this case C4::Context depends on C4::Database and
> > C4::Database depends on C4::Context :(
> > Should we move database handler method to C4::Database ?
> > I know it will change a lot of code but isn't it more logical ?
> 
> Yes of course it is.
> But I would like to get this one into master and then provide a huge change
> to correct all occurrences.

Oki, we are on the same page then.
I'll try it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 09:06:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 07:06:54 +0000
Subject: [Koha-bugs] [Bug 4990] reintegrate overdues email in overdue list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4990

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 09:13:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 07:13:36 +0000
Subject: [Koha-bugs] [Bug 10128] Encoding problem when Search for an
 Authority to add to a bib record with non-latin characters the data re
 filled in form looks bad but the results good
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10128

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
                 CC|                            |josef.moravec at gmail.com
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 09:15:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 07:15:59 +0000
Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via
	Koha's GUI
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:04:55 +0000
Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:04:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:04:58 +0000
Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

--- Comment #1 from Jonathan Druart  ---
Created attachment 42570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42570&action=edit
Bug 14829: Fix shortcuts in the cataloging and patron modules

In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as
in other modules.
The tab are not "built" in the correct order and the id returned to
select the correct tab is wrong.

Test plan:
Go on the circ home page (circ/circulation-home.pl), the patron home
page (members/members-home.pl) and the cataloging home page
(cataloguing/addbooks.pl).
On these 3 pages, without this patch, the shortcuts select different
tabs.
With this patch, the issue is fixed for all of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:05:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:05:11 +0000
Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
   Patch complexity|---                         |Trivial patch
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|3.20                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:14:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:14:34 +0000
Subject: [Koha-bugs] [Bug 14831] New: How to link the Koha catalog into our
	website
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14831

            Bug ID: 14831
           Summary: How to link the Koha catalog into our website
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mr.bnikhil at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi 


SEVERITY :  CRITICAL / URGENT / HIGH PRIORITY

Subject : Linking of the Koha catalog to the public webpage. 


       We have installed KOHA in our LAN and now we want to link the catalog to
the public webpage. So please guide us , how to link the catalogs to our public
webpage where users can see the available information using catalogs but they
shouldn't be able to edit the information.


We will be waiting for the support from you.


Thank you & Regards
Nikhilesh Reddy
9030064642

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:15:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:15:03 +0000
Subject: [Koha-bugs] [Bug 14831] How to link the Koha catalog into our
	website
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14831

mr.bnikhil at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:27:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:27:15 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

--- Comment #3 from Jonathan Druart  ---
Created attachment 42571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42571&action=edit
Bug 14817: (follow-up) Fix encoding issues in columns.def

Follow-up for reports.

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the report guided page, step 3
3/ The field names should be correctly encoded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:28:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:28:00 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

--- Comment #4 from Jonathan Druart  ---
Thanks for the catch Josef, I haven't checked this area I thought it called the
same subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:38:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:38:50 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:38:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:38:53 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39366|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 42572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42572&action=edit
Bug 14245: Problems with RIS export in unimarc

Variable $itype is used an all C4/Ris.pm to switch
between marc falvors, but is local and not passed along
as argument.

As a quick solution, is defined as global

To test:
1) On UNIMARC setup, export a record as RIS,
check that author (and other fields) are displayed
incorrectly

2) Apply the patch

3) Export again, improved results

4) Run t/Ris.t

There are other problems in this script, needs maintenance
(e.g. no Modern::Perl friendly)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:41:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:41:37 +0000
Subject: [Koha-bugs] [Bug 14832] New: Encoding issues when exporting in RIS
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

            Bug ID: 14832
           Summary: Encoding issues when exporting in RIS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

I have found this issue when testing bug 14245.

To reproduce:
Make sure you have non ASCII chars in the title and the authors.
Export the record in RIS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:41:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:41:37 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=14832

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:43:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:43:02 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:43:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:43:04 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #1 from Jonathan Druart  ---
Created attachment 42573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42573&action=edit
Bug 14832: Fix encoding issues when exporting in RIS

Test plan:
1/ Make sure you have non ASCII chars in the title and the authors.
2/ Export the record in RIS
You should not see any encoding problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 10:48:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 08:48:19 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #2 from Jonathan Druart  ---
Does not seem to have been introduced by bug 11944, this affect 3.18.x also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:01:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:01:50 +0000
Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #3 from Jonathan Druart  ---
Note: I don't get the issue on a MARC21 DB.
But the patch does not seem to break the RIS export for this DB.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:21:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:21:05 +0000
Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to
 purge all 0 balance fees and payments older than the given number of days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #22 from Jonathan Druart  ---
The script does not accept --fees 0, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:27:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:27:00 +0000
Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items
 added before or after a specific date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527

--- Comment #26 from Pedro Ferreira  ---
any news how to solve the problem...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:27:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:27:50 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #13 from Lari Taskula  ---
(In reply to Katrin Fischer from comment #12)
> I think it could be very useful for a library to be able to resent messages
> that don't have a "failed" status - for example: the library has typoed in
> the email address. In this cases the email is sent, but bounced back to the
> library's email address (email account doesn't exist at this provider etc.)
> and it's up to the library to correct the email address. But the status will
> be sent.
> I have been asked a lot if there is a way to trigger a notice again - which
> is why I filed this bug :)

That's a very good point. For some reason I had been ignoring this :) With the
current patch it is a bit risky, however. As Jonathan mentioned problems with
browser history,

(In reply to Jonathan Druart from comment #9)
> Note that ResendNotice only resends failed messages. This will avoid to
> resend already sent messages (using an url from the browser history for
> instance).

I suggest we change the method of request from GET and make it via AJAX calls
to avoid problems caused by browser history. I have been working on REST API
for Notices and have done all basic operations including resend. It would be
nice to see this feature use the REST API via AJAX calls. Any support for this
idea?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:39:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:39:31 +0000
Subject: [Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO
 e-books links?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528

Charles Quain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |csq at interleaf.ie

--- Comment #4 from Charles Quain  ---
EBSCO have given me this temporary link to create test urls:
http://search.ebscohost.com/login.aspx?authtype=uid&user=koha15&password=test2015&profile=ehost&defaultdb=e000muk

Click on a thumbnail and go to the full display for the record. Then click on
the "permalink" option at the right of the screen to get an url that you can
put into an 856 tag for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:40:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:40:52 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42553|0                           |1
        is obsolete|                            |

--- Comment #16 from Lari Taskula  ---
Created attachment 42574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42574&action=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:50:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:50:54 +0000
Subject: [Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO
 e-books links?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528

--- Comment #5 from Katrin Fischer  ---
Could the problem be bug 14441? I think there is a problem with links
containing ampersands (&).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:02 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42018|0                           |1
        is obsolete|                            |
  Attachment #42019|0                           |1
        is obsolete|                            |
  Attachment #42020|0                           |1
        is obsolete|                            |
  Attachment #42021|0                           |1
        is obsolete|                            |
  Attachment #42022|0                           |1
        is obsolete|                            |
  Attachment #42023|0                           |1
        is obsolete|                            |
  Attachment #42314|0                           |1
        is obsolete|                            |

--- Comment #88 from Jonathan Druart  ---
Created attachment 42575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42575&action=edit
Bug 12252 - OAI-PMH result includes item data

GetRecord for OAI-PMH was pulling the MARCXML directly from the
database. Now it uses GetMarcBiblio and includes the item data with it,
making it more generally useful.

Test plan:
* Run an OAI-PMH query, for example:
http://koha/cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:52&metadataPrefix=marcxml
  to fetch biblionumber 52
* Note that it doesn't include the 952 data
* Apply the patch
* Do the same thing, but this time see that the 952 data is at the
  bottom of the MARCXML.

Note:
* This patch also includes a small tidy-up in C4::Biblios to group
  things semantically a bit better, so I don't spend ages looking for a
  function that was staring me in the face all along again.

Signed-off-by: David Cook 

Works as described. Simple yet useful patch.

Signed-off-by: Jonathan Druart 

Signed-off-by: Frederic Demians 

952/995 item fields are back in response to GetRecord OAI verb.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:07 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #89 from Jonathan Druart  ---
Created attachment 42576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42576&action=edit
Bug 12252 - OAI-PMH items respect OpacHiddenItems

This allows the OAI-PMH service to not provide item information when
there is a rule that would supress it in OpacHiddenItems.

Test plan:
* Find an OAI-PMH URL that shows you some items.
* Add an entry to OpacHiddenItems that would block that.
* Check that it's blocked.

Signed-off-by: Frederic Demians 

Tested, playing with OpacHiddenItems. GetRecord OAI verb returns a record
complying with OpacHiddenItems rules, for example without items from a specific
library.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:11 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #90 from Jonathan Druart  ---
Created attachment 42577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42577&action=edit
Bug 12252 - include item data in OAI-PMH ListRecords result

Same in spirit to the other patch, this also includes the item detail in
ListRecords.

Test plan:
* Fetch a URL like:
http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml
* Verify that there are 952 entries in the returned records where
  appropriate.

Signed-off-by: Frederic Demians 

ListRecords OAI verb returns a list of records including items in 952/995 which
are not hidden based on OpacHiddenItems syspref.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:15 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #91 from Jonathan Druart  ---
Created attachment 42578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42578&action=edit
Bug 12252: Add tests for EmbedItemsInMarcBiblio

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:19 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #92 from Jonathan Druart  ---
Created attachment 42579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42579&action=edit
Bug 12252: (qa-follow-up) Remove perlcritic error

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:24 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #93 from Jonathan Druart  ---
Created attachment 42580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42580&action=edit
Bug 12252 Include item data only in extended mode

Previous patches attached to this bug have been refactored to merge bug
3206 and bug 13568 features. So OAI server must be carrefully tested to
ensure that there is no regression in this area: deleted records and
resumption token.

This last patch fixed the way items are returned. They are returned only
if OAI server operates in extended mode, and specifically for format
having the parameter include_item set to 1 (true). For example this
configuration file set via OAI-PMH:ConfFile syspref will return items:

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:28 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #94 from Jonathan Druart  ---
Created attachment 42581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42581&action=edit
Bug 12252: (follow-up) Include item data only in extended mode

Fix perlcritic error.

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:53:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:53:48 +0000
Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include
	item data
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Small patch                 |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:54:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:54:31 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #14 from Katrin Fischer  ---
Hm not sure if I understand the browser history problem. Why would a link in
the notices table to resend (with old fashioned reload or Ajax) not work?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 11:55:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 09:55:40 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
 C4::Circulation::AddReturn
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:00:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:00:37 +0000
Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid
 is now deleted record will fail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |robin at catalyst.net.nz,
                   |                            |srdjan at catalyst.net.nz,
                   |                            |tomascohen at gmail.com

--- Comment #9 from Jonathan Druart  ---
Ccing people involved in the Logger discussion to get their opinions, please
see comments 6-8.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:04:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:04:20 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #15 from Katrin Fischer  ---
Mostly asking because the REST API is not there yet - it would be nice if this
small but great improvement would not be blocked by the bigger development.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:06:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:06:25 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #16 from Jonathan Druart  ---
(In reply to Lari Taskula from comment #13)

> I suggest we change the method of request from GET and make it via AJAX
> calls to avoid problems caused by browser history. I have been working on
> REST API for Notices and have done all basic operations including resend. It
> would be nice to see this feature use the REST API via AJAX calls. Any
> support for this idea?

(In reply to Katrin Fischer from comment #15)
> Mostly asking because the REST API is not there yet - it would be nice if
> this small but great improvement would not be blocked by the bigger
> development.

Exactly what I was going to answer :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:08:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:08:04 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #17 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #14)
> Hm not sure if I understand the browser history problem. Why would a link in
> the notices table to resend (with old fashioned reload or Ajax) not work?

Clicking on the resend link, will call
/cgi-bin/koha/script.pl?op=resend&message_id=42 (or equivalent).
If you don't limit the resend to fail messages, a user could unexpectedly
recall this url, and resend again the message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:08:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:08:32 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #18 from Jonathan Druart  ---
So AJAX call or via POST could solved the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:31:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:31:34 +0000
Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Michael Kuhn  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Michael Kuhn  ---
I applied the patch manually in the files "cataloging-search.inc" and
"patron-search.inc" of directory
"/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/de-DE/includes" and the
patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:32:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:32:54 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42524|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec  ---
Created attachment 42582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42582&action=edit
Bug 14817: Fix encoding issues in columns.def

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the tools/import_patrons.pl page
3/ The field names in the "default values" block should be correctly
encoded.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:32:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:32:59 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42571|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec  ---
Created attachment 42583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42583&action=edit
Bug 14817: (follow-up) Fix encoding issues in columns.def

Follow-up for reports.

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the report guided page, step 3
3/ The field names should be correctly encoded.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:33:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:33:20 +0000
Subject: [Koha-bugs] [Bug 14817] Encoding issues in columns.def
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:34:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:34:21 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #19 from Lari Taskula  ---
Katrin,

As Jonathan mentioned, AJAX would work fine but (with current patch) the
following link 

    cgi-bin/koha/members/notices.pl?borrowernumber=1&resendnotice=4

would stay in your browser history. Let's imagine we clicked the link and the
message was resent perfectly fine and we want to forget about it. But since
it's in the browser history, a staff member can accidentally get back on this
page by using the address bar, without realizing that this will resend the
message once again.

And yes, I understand your concern - it is very problematic that it would be
blocked by the REST API since it's not there yet. So what would be the point to
use it for such a small feature?

But here we are very optimistic and excited about the REST API. I think it is a
great opportunity to keep pushing it forward by making features already
dependant on it. To use this nice feature you would need to use the REST API -
great way to encourage other people to check it out and learn about it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:38:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:38:18 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #20 from Katrin Fischer  ---
Everyone is very excited - but woudl be good to have at least the base patches
in Koha first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:38:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:38:20 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #46 from Jonathan Druart  ---
Comment on attachment 42559
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42559
Bug 14321: Introduce Koha::Upload

Review of attachment 42559:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14321&attachment=42559)
-----------------------------------------------------------------

::: Koha/Upload.pm
@@ +211,5 @@
> +    return @res;
> +}
> +
> +sub DESTROY {
> +}

This is not really useful.

@@ +213,5 @@
> +
> +sub DESTROY {
> +}
> +
> +# **************  HELPER ROUTINES / CLASS METHODS ******************************

Should be part of POD.

@@ +260,5 @@
> +    $self->{uid} = C4::Context->userenv->{number} if C4::Context->userenv;
> +    $self->{public} = $params->{public}? 1: undef;
> +}
> +
> +sub _fh {

I don't understand the usefulness of this method.

@@ +274,5 @@
> +    if( $self->{files}->{$filename} &&
> +            $self->{files}->{$filename}->{errcode} ) {
> +        #skip
> +    } elsif( !$self->{temporary} && !$self->{rootdir} ) {
> +        $self->{files}->{$filename}->{errcode} = 3; #no rootdir

Please avoid that and use readable error code. "no_rootdir" would be perfect.

@@ +311,5 @@
> +    my $p;
> +    if( ref $rec ) {
> +        $p= $rec->{permanent}? $self->{rootdir}: $self->{tmpdir};
> +        $p.= '/';
> +        $p.= $rec->{dir}. '/'. $rec->{hashvalue}. '_'. $rec->{filename};

It would be better to use File::Spec::catfile

@@ +351,5 @@
> +        $self->{public},
> +        $self->{temporary}? 0: 1,
> +    );
> +    $dbh->do( $sql, undef, @pars );
> +    my $i = $dbh->last_insert_id(undef, undef, 'uploaded_files', undef);

last_insert_id is mysql specific.
It would have been better to create the Koha::UploadFile[s] based on
Koha::Object[s] to avoid and write sql queries.

@@ +358,5 @@
> +
> +sub _lookup {
> +    my ( $self, $params ) = @_;
> +    my $dbh = C4::Context->dbh;
> +    my $sql = qq|

Variable interpolations should not be allowed in SQL queries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:43:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:43:27 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #47 from Jonathan Druart  ---
Comment on attachment 42560
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42560
Bug 14321: Integrate Upload.pm into Koha

Review of attachment 42560:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14321&attachment=42560)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
@@ +1,1 @@
> +[% INCLUDE 'doc-head-open.inc' %]

I don't really like the structure of this file. You have to jump in the file to
know what is next.
Is it a new proposal for template files?

::: tools/upload-file.pl
@@ +82,3 @@
>  }
>  
> +sub upload_pars {

Maybe a quick comment would be useful here.

::: tools/upload.pl
@@ +1,1 @@
> +#!/usr/bin/perl

Please execute perltidy on new file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:43:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:43:58 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |julian.maurice at biblibre.com

--- Comment #48 from Jonathan Druart  ---
Julian, could I get your signoff on this one please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:45:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:45:23 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #49 from Jonathan Druart  ---
Created attachment 42584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42584&action=edit
Bug 14321: QA Fix

Remove QA errors (keys on reference is experimental).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:48:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:48:00 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6874


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
[Bug 6874] Attach files to bibliographic records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:48:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:48:00 +0000
Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14321


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
[Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 12:59:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 10:59:42 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #21 from Jonathan Druart  ---
(In reply to Lari Taskula from comment #19)
> But here we are very optimistic and excited about the REST API. I think it
> is a great opportunity to keep pushing it forward by making features already
> dependant on it. To use this nice feature you would need to use the REST API
> - great way to encourage other people to check it out and learn about it :)

I personally just mark these patches as BLOCKED since the base is not
accepted/validated/etc.
It just makes me think "this work will have to rebase for ages".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:01:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:01:33 +0000
Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42570|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec  ---
Created attachment 42585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42585&action=edit
Bug 14829: Fix shortcuts in the cataloging and patron modules

In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as
in other modules.
The tab are not "built" in the correct order and the id returned to
select the correct tab is wrong.

Test plan:
Go on the circ home page (circ/circulation-home.pl), the patron home
page (members/members-home.pl) and the cataloging home page
(cataloguing/addbooks.pl).
On these 3 pages, without this patch, the shortcuts select different
tabs.
With this patch, the issue is fixed for all of them.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:08:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:08:00 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #22 from Tom Misilo  ---
Would a possible compromise be, accept as is without using the REST API and
without being able to resend failed messages? With the understanding that a new
bug # be created that enhances this one by using the REST API? That way the
functionality libraries have been looking for more then a year is added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:08:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:08:31 +0000
Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42572|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 42586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42586&action=edit
Bug 14245: Problems with RIS export in unimarc

Variable $itype is used an all C4/Ris.pm to switch
between marc falvors, but is local and not passed along
as argument.

As a quick solution, is defined as global

To test:
1) On UNIMARC setup, export a record as RIS,
check that author (and other fields) are displayed
incorrectly

2) Apply the patch

3) Export again, improved results

4) Run t/Ris.t

There are other problems in this script, needs maintenance
(e.g. no Modern::Perl friendly)

Signed-off-by: Victor do Ros?rio 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:13:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:13:15 +0000
Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions
	on indexes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:20:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:20:44 +0000
Subject: [Koha-bugs] [Bug 14833] New: Bad encoding in table header in sql /
	guided report
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14833

            Bug ID: 14833
           Summary: Bad encoding in table header in sql / guided report
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There is bug in running reports. 

1. Create report with some uf8 characters in columns names, for example.

SELECT b.cardnumber AS "??slo pr?kazky", b.firstname AS "K?estn? jm?no",
b.surname AS "P??jmen?", bb.author AS "Autor", bb.title AS "N?zev"
FROM borrowers b JOIN issues i ON b.borrowernumber = i.borrowernumber 
JOIN items it ON i.itemnumber = it.itemnumber
JOIN biblio bb ON bb.biblionumber = it.biblionumber

(It's in Czech, I apologize ;-) )

2. Run the report and you see, that columns names are bad encoded. 

3. Try to download the report, csv and tab file has the same problem, but ODF
file is OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:38:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:38:38 +0000
Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices
 tab in the patron account
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #23 from Katrin Fischer  ---
Hi Misilo, I think failed will only cover a really small percentage. I think
making it work for all status using a POST could be a little nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:41:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:41:31 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #50 from Marcel de Rooy  ---
Jonathan: Thanks for looking into this one!

> +sub DESTROY {
> +}
> This is not really useful.
Agreed. Removing it.

> +# **************  HELPER ROUTINES / CLASS METHODS
> Should be part of POD.
Right!

> +sub _fh {
> I don't understand the usefulness of this method.
Hm. I am not sure anymore, but this routine may have had some more lines in
development. But it still contains a test if (a) then a->b, so I want to keep
it in order to not repeat this test a few times. Keeps the code more readable
at the calling spots.

> +        $self->{files}->{$filename}->{errcode} = 3; #no rootdir
> Please avoid that and use readable error code. "no_rootdir" would be perfect.
I hope that is not a blocker for you :) and prefer to leave it as-is now..

> +        $p= $rec->{permanent}? $self->{rootdir}: $self->{tmpdir};
> +        $p.= '/';
> +        $p.= $rec->{dir}. '/'. $rec->{hashvalue}. '_'. $rec->{filename};
> It would be better to use File::Spec::catfile
OK. Adjusting it.

> +    my $i = $dbh->last_insert_id(undef, undef, 'uploaded_files', undef);
> last_insert_id is mysql specific.
> It would have been better to create the Koha::UploadFile[s] based on 
> Koha::Object[s] to avoid and write sql queries.
Could be true, but that is a too large rewrite operation at this moment.
We could do that on a new report at some point in time. Some day we hope to not
have anything mysql specific anymore?

> +sub _lookup {
> +    my ( $self, $params ) = @_;
> +    my $dbh = C4::Context->dbh;
> +    my $sql = qq|
> Variable interpolations should not be allowed in SQL queries.
Which line do you exactly refer to now?
Probably the WHERE id IN ($params->{id}) line later on.
Note that the id variable is only allowed to be of the form 1,2,3,4 by the
regex directly preceding it. If you persist here, I could rebuild it in the
form ?,?,? here and first count the number of id's..

Will continue with your second comment now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 16 13:51:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Sep 2015 11:51:33 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Jonathan Druart  ---
Tested on batchMod.pl:

1/ The "required" is before the select.
2/ After selecting a value, the description is truncated (see comment 9).

3/
(In reply to Owen Leonard from comment #9)
> Old: Tab to