[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #18)
> Thanks, I understand what you were asking now.
> > > t/db_dependent/BiblioObject.t
> > 
> > I would prefer a better filename, but nothing in mind to suggest.
> 
> I feel the same way, but have nothing better to suggest either.
> 
> > > +my $field_mappings = Koha::Database->new()->schema()->resultset('Fieldmapping');
> > 
> > Could be better to have a Koha::Fieldmapping[s]
> 
> I can do this if you'd like. It was just a quick way to create a field
> mapping, so I went with dbic directly. Just let me know if you want me to go
> ahead an add a followup to add and use Koha::Fieldmapping[s]

As you like.

> > > -    waiting_count      => $wcount,
> > 
> > This variable is still used in the template.
> > 
> > > +    WAITING        => $reserves->waiting()
> > 
> > Why not remove this one and access to the waiting holds using
> > RESERVES.waiting in the template?
> 
> I'm working on these ones right now.

So setting the status accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.