[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org
             Status|Needs Signoff               |In Discussion

--- Comment #6 from Nick Clemens <nick at quecheelibrary.org> ---
Moving this to in discussion.

I think the expected behavior is somewhere between the original and that with
the patches applied.  I would expect either:

1 - Preserve current behavior and change just the labels to "Select all visible
/ clear all visible"

2 - Select all searches but respect filters.  If I filter down to 8 searches it
should select only those.  If my filter finds 21 searches (default 20 visible)
it should select all 21, but not searches limited by filter.  Labels would say
"With ## selected searches: delete"

A couple other things from testing:

1 - On master selecting any search past 20 doesn't change the look of the
delete button, though it is enabled.  It does only function on the visible
searches either way 
i.e. select search 21, button no visibly enabled, but clickable. Select #1 and
#21 (with 20 visible) button is enabled, only #1 is deleted.
With the patches the link still isn't visibly enabled but will delete all
selected regardless of visibility

2 - The phrasing "With selected searches: Delete" is awkward.  I think it
should be "Delete selected searches" and button can simply be grayed out when
none are selected With these patches phrasing would then be "Delete ## selected
searches"

-- 
You are receiving this mail because:
You are watching all bug changes.