[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 42438
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42438
Bug 10067 - decreaseLoanHighHolds messes with specify due date

Review of attachment 42438:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10067&attachment=42438)
-----------------------------------------------------------------

::: circ/circulation.pl
@@ +524,5 @@
> +
> +    if ($stickyduedate eq 'on') {
> +        $session->param( 'stickyduedate', $duedatespec );
> +    }
> +}

Without a good reason, this should be merged into the following block:

565 # save stickyduedate to session
566 if ($stickyduedate) { 
567     $session->param( 'stickyduedate', $duedatespec );                       
568 } 

Something like:
if ( $stickyduedate or $restoreduedatespec ) {
    $duedatespec = $restoreduedatespec || $duedatespec;
    if ($stickyduedate) {
        $session->param( 'stickyduedate', $duedatespec );
    }
}
(not tested)

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +388,3 @@
>      <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
>      <input type="hidden" name="duedatespec" value="[% duedatespec %]" />
> +    <input type="hidden" name="restoreduedatespec" />

Duplicated.

-- 
You are receiving this mail because:
You are watching all bug changes.