[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 42560
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42560
Bug 14321: Integrate Upload.pm into Koha

Review of attachment 42560:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14321&attachment=42560)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
@@ +1,1 @@
> +[% INCLUDE 'doc-head-open.inc' %]

I don't really like the structure of this file. You have to jump in the file to
know what is next.
Is it a new proposal for template files?

::: tools/upload-file.pl
@@ +82,3 @@
>  }
>  
> +sub upload_pars {

Maybe a quick comment would be useful here.

::: tools/upload.pl
@@ +1,1 @@
> +#!/usr/bin/perl

Please execute perltidy on new file.

-- 
You are receiving this mail because:
You are watching all bug changes.