[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
> I don't really like the structure of this file. You have to jump in the file to know what is next.
> Is it a new proposal for template files?
No, it is not a new proposal or so. This could be a matter of taste, but this
template reads much easier to me than the long blocks of text with horrible
indentation that we already have in Koha. Note that most of us prefer to use
subroutines in code instead of one large block. This is more or less the same.
It may be quite easy to copy the blocks to their corresponding places, but for
me it will not enhance readability.
Since this is just using normal TT directives, it should not be considered imo
in terms of new format, guidelines, etc.
If you still insist, I will remove the blocks.. 

::: tools/upload-file.pl
> +sub upload_pars {
> Maybe a quick comment would be useful here.
Added a small comment.

> ::: tools/upload.pl
> Please execute perltidy on new file.
OK. Will do that.

-- 
You are receiving this mail because:
You are watching all bug changes.