[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #28 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Jonathan Druart from comment #26)
> Comment on attachment 42618 [details] [review]
> Bug 12426: Allow resend for sent messages
> 
> Review of attachment 42618 [details] [review]:
> -----------------------------------------------------------------
> 
> + Your patch introduces trailing whitespaces.
> 
> ::: members/notices.pl
> @@ +58,5 @@
> >      my $message = C4::Letters::GetMessage( $message_id );
> >      if ( $message->{borrowernumber} = $borrowernumber ) {
> >          C4::Letters::ResendMessage( $message_id );
> > +        # redirect to self to avoid form submission on refresh
> > +        print $input->redirect("/cgi-bin/koha/members/notices.pl?borrowernumber=$borrowernumber");
> 
> Not sure this is useful, what will happen if the form is resubmit?
> That will change the status from pending to pending? :)

Without this, when refreshing the page, the browser will ask for resending the
form. Some staff member can click refresh to see if the resent message is now
in sent status and accidentally put it for resend once again. When we redirect
back to notices.pl, form cannot be resent again (at least this was the behavior
on my Firefox) even if he/she clicks refresh. It will simply refresh the page
without asking/sending any form data again.

> ::: t/db_dependent/Letters.t
> @@ +18,4 @@
> >  # along with Koha; if not, see <http://www.gnu.org/licenses>.
> >  
> >  use Modern::Perl;
> > +use Test::More tests => 68;
> 
> I'd say we can keep the test you have removed, and adapt it.
> So we check a message can be resend independently of its status.

Okay, I'll update it.

-- 
You are receiving this mail because:
You are watching all bug changes.