[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #69)
Thanks for looking further !

> 1/ DB structure:
> a. It would have been better not to choose "categorycode", already used
> everywhere into Koha for another use.
OK I am renaming it ;)

> b. owner should be a fk.
I will move this to a new report: Bug 14849

> c. public and permanent are tinyint(4) but actually are boolean, so
> tinyint(1) is more appropriated.
tinyint is always one byte: the 4 has to do with display just like int(11)

> 2/ How can I access tools/upload.pl? I don't find any links.
That is correct. As mentioned in the commit message:
NOTE: Bug 14686 will add a specific permission for tools/upload.pl, and
will add the tools/upload script to the Tools menu.

> 3/ There is no confirmation message on deleting a file "Are you sure you
> want to delete?"
Will add that too.

> 4/ The navmenu from the tools module is not displayed on this page.
I was thinking for some future extension when Patron images, Local covers, etc.
would come together on this page to have some room there.
Note also that not all tools include that menu.

> 5/ click on "Allow public downloads" should enable/disable the checkbox
> (label)
Will adjust.

> 6/ How can I see all files? I have to fill something in the search box.
By design :) If you would have many files, you may not want that.

> 7/ Would be great to have DT on the table (with sort, pagination and filters)
I agree. But want to postpone that to a new report now.

> 8/ From the result list, I cannot go back to search for something else.
Breadcrumbs? Added a back button (if not called as plugin). 

> 9/ I cannot choose "Allow public downloads" from the upload plugin, does it
> mean it's always|never public?
The thought here was: If I add a link in a biblio record, it [normally]
displays in the OPAC and you should make it public to make sense.

> 10/
>     [3] Use File::Spec->catfile in sub _full_fname.
>     [4] Remove variable interpolation from a sql query.
> Well, it was a general comment, for everywhere :)
> Anyway, we can live with them.
Adjusted a few other double quotes around queries.
Did not find any other useful candidates for catfile.

> Conclusion: Either I missed something and I did not understand at all the
> goal of this feature (I have not really looked into bug 6874), or there are
> several stuffs to fix to improve the ergonomic.
Main goal was merge two modules.. Hope to have improved this again somewhat
with your feedback. You probably don't miss that much :)

Patch forthcoming.

-- 
You are receiving this mail because:
You are watching all bug changes.