[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

--- Comment #18 from Kyle M Hall <kyle.m.hall at gmail.com> ---
That's good enough for me! I have added a followup to make the logger package
level. I will also amend my wiki guidelines to reflect the fact that
subroutine/method level loggers should only be used only when specifically
needed for some reason.


(In reply to Robin Sheat from comment #17)
> (In reply to Kyle M Hall from comment #16)
> > I decided to run some tests, and over 1000 runs of a script with an
> > instantiation of the logger vs no instantiation of the logger ( with both
> > having 'use Koha::Logger' to measure just the instantiation ), the average
> > time cost for the logger instantiation was 0.003304 seconds.
> 
> That's 3.3 seconds of cost if it gets called 1,000 times, which isn't too
> far fetched inside some parts of Koha (though really, those places should be
> fixed, but that's neither here nor there.)
> 
> Though, running a script 1,000 times isn't a very reliable test. It'll
> probably have more noise than signal.

-- 
You are receiving this mail because:
You are watching all bug changes.