[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > Comment on attachment 42647 [details] [review] [review]
> > Bug 14805: (follow-up) fix a bug in previous code and change msg string
> > 
> > Review of attachment 42647 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
> > @@ +21,4 @@
> > >  
> > >                  var msg;
> > >                  if (element_ids.length > 1) {
> > > +                    msg = _("Are you sure you want to delete %s items?").format(element_ids.length, element_ids.length);
> > 
> > Is not possible to call translate_card_element here?
> 
> One way would be by adding if statements for all the different
> translate_card_elements. I don't know how we could otherwise conjugate the
> words. Any better ideas than the if statements (or case statements)?

Have a look at my last patch and please sign it off if it works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.