[Koha-bugs] [Bug 14895] New: We shouldn't be able to edit already added serials' items from serial receive/edit page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895

            Bug ID: 14895
           Summary: We shouldn't be able to edit already added serials'
                    items from serial receive/edit page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When you receive some serials you go to the serials/serials-edit.pl page. You
change there the status to 'Arrived' and add a new item (if it has been chosen
so in the subscription creation step). Now if after that someone goes and
changes the status to, for example, 'Expected' then the system automatically
overrides the item's info which is already in the system. This happens because
the serial-edit.pl don't retrieve any information from the items which are
already in the system.

Well, I guess nobody will change an arrived item to expected usually, only in
the cases when it has been a misclick or something. So the real problem is that
if you just go to the serials-edit.pl page and don't change anything, and click
save, the existing item will have some of its info deleted (barcode as one
example).

I have a patch for this problem (will add soon here). Instead of retrieving the
already added items' data I choosed to disable the "ability" to change the
already added items' info from serials-edit.pl (one can change item information
from cataloguing -> something, if needed).

I guess my explanation is not so clear, so I will provide you the steps how to
reproduce this bug:

1. In serials create a new subscription with the option "create an item record
when receiving this serial" selected. You can choose the other properties.
2. Find the newly created serial subscription by using the top bar's search.
3. Click from the 'Actions' drop-down menu 'Serial receive'.
4. Change the status to 'Arrived'. Add something to the barcode field. Save.
4.1 (Optional step) Open a new tab in your browser and go see that there is in
the catalogue the item you just added and it has a barcode.
5. Now you should have arrived to the page serials-collection.pl. Here, select
the very same serial item you just edited and click 'Edit serials' 
6. Now click just save button without doing any changes.
7. Go to find that item from the biblio record. Notice its barcode is missing
now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.