From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 22:35:09 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Jesse Weaver --- Pushed to master, will be in the May 2016 release. Thanks for your work! I had to manually apply this using git apply --reject, please make sure everything is okay. Passed tests and QA tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:45:11 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42234|0 |1 is obsolete| | --- Comment #78 from Srdjan Jankovic --- Created attachment 49750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49750&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:46:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:46:51 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:46:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:46:53 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42235|0 |1 is obsolete| | --- Comment #79 from Srdjan Jankovic --- Created attachment 49751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49751&action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:47:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:47:17 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42236|0 |1 is obsolete| | --- Comment #80 from Srdjan Jankovic --- Created attachment 49752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49752&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:47:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:47:35 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42237|0 |1 is obsolete| | Attachment #42238|0 |1 is obsolete| | --- Comment #81 from Srdjan Jankovic --- Created attachment 49753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49753&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:48:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:48:04 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42239|0 |1 is obsolete| | --- Comment #82 from Srdjan Jankovic --- Created attachment 49754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49754&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:48:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Mar 2016 23:48:38 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42240|0 |1 is obsolete| | Attachment #42425|0 |1 is obsolete| | --- Comment #83 from Srdjan Jankovic --- Created attachment 49755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49755&action=edit bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 00:28:29 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #49728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:35:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 00:35:30 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 00:35:32 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49726|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 49756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49756&action=edit Bug 16176: Fix a test about OpenLibrarySearch Introduced by bug 6624: When C4::UsageStats::BuildReport is modified, the tests should be too. Test plan: prove t/db_dependent/UsageStats.t should return green Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:45:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 00:45:18 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49737|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 49757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49757&action=edit Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:19:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:19:34 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Resolution|REMIND |--- Status|CLOSED |REOPENED --- Comment #1 from Mason James --- Woah, i think just hit this bug in 2016?! I'll reopen this now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:26:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:26:34 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 --- Comment #2 from Mason James --- Created attachment 49758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49758&action=edit Bug 1750 - Report bor_issues_top erroneous and truncated results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:29:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:29:14 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 --- Comment #3 from Mason James --- Created attachment 49759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49759&action=edit before/after pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:30:57 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #4 from Mason James --- sorry, no test plan provided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:34:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:34:34 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 --- Comment #5 from Mason James --- FYI: the way this bug can be revealed is to have a borrower in the report with either a NULL 'surname' or 'firstname' value If this occurs, CONCAT() makes the borrower.name value NULL (bad!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 02:58:29 +0000 Subject: [Koha-bugs] [Bug 16184] New: Bug 1750 - Report bor_issues_top shows incorrect number of rows Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Bug ID: 16184 Summary: Bug 1750 - Report bor_issues_top shows incorrect number of rows Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org Bug 1750 - Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:00:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:00:04 +0000 Subject: [Koha-bugs] [Bug 16184] Bug 1750 - Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 --- Comment #1 from Mason James --- This report always returns double the number of rows requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:00:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:00:58 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 1750 - Report |Report bor_issues_top shows |bor_issues_top shows |incorrect number of rows |incorrect number of rows | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:01:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:01:51 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 --- Comment #2 from Mason James --- Created attachment 49760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49760&action=edit Bug 16184 - Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:03:03 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 --- Comment #3 from Mason James --- Created attachment 49761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49761&action=edit before/after pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:04:51 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 --- Comment #4 from Mason James --- A report with a LIMIT of 5 rows, will incorrectly return 10 rows (bad!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:05:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:05:31 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:13:39 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49758|0 |1 is obsolete| | --- Comment #6 from Mason James --- Created attachment 49762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762&action=edit Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:15:03 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 [Bug 1750] Report bor_issues_top erroneous and truncated results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:15:03 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 [Bug 16184] Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:32:06 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|1750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 [Bug 1750] Report bor_issues_top erroneous and truncated results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:32:06 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16184 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 [Bug 16184] Report bor_issues_top shows incorrect number of rows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:53:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:53:06 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 --- Comment #7 from M. Tompsett --- Comment on attachment 49762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762 Bug 1750 - Report bor_issues_top erroneous and truncated results. Review of attachment 49762: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1750&attachment=49762) ----------------------------------------------------------------- ::: reports/bor_issues_top.pl @@ +279,4 @@ > my $strcalc ; > > # Processing average loanperiods > + $strcalc .= "SELECT CONCAT_WS('', borrowers.surname , \",\\t\", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; http://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_concat-ws Nice! CONCAT_WS skips NULL entries, but still concat's, while CONCAT gives up and returns NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:58:23 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 03:58:26 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49762|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 49763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49763&action=edit Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James TEST PLAN --------- 1) Ensure you have some checkouts 2) Home -> Reports -> Patrons with the most checkouts 3) Click 'Submit' -- you get a list 4) Click a patron name. 5) Note the borrower number. 6) In MySQL run something like: > UPDATE borrower SET firstname=NULL WHERE borrowernumber=#### 7) Refresh the report page -- name goes totally blank 8) apply patch 9) Refresh the report page -- only first name is lost 10) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:00:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:00:03 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com URL|http://staff-atz.dev.kohali | |brary.com/cgi-bin/koha/repo | |rts/bor_issues_top.pl | --- Comment #9 from M. Tompsett --- URL deleted as it links to the WRONG location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:21:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:21:55 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- I'm not sure whether this patch is the best way to do it. The whole query issues and old_issues via Perl seems like the wrong way to handle the logic. I'm sure a better SQL query could be built with a UNION that way the LIMIT and GROUP BY would be handled by MySQL instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:32:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:32:05 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:32:08 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49760|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 49764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49764&action=edit Bug 16184 - Report bor_issues_top shows incorrect number of rows TEST PLAN --------- 1) Have at least 6 patrons with checkouts and some checkins. 2) Reports -> Patrons with the most checkouts 3) Click 'Submit' (default is 5) -- more than 5 entries listed. 4) Apply patch 5) Refresh page -- only 5 entries listed. 6) Run koha qa test tools NOTE: While this works, I'd be much happier with a refactor as it would also speed up the report. See comment #5. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:41:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:41:07 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:41:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 04:41:09 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49727|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 49765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49765&action=edit Bug 16177: Fix tests for ColumnsSsettings.t This failure has been introduced by commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files This is because the cannot_be_modified key is not always created by C4::Utils::DataTables::ColumnsSettings subroutines Test plan: prove t/db_dependent/ColumnsSettings.t should return green And you can also test a table where the feature is set and a column cannot be modified from the admin page. NOTE: Works as described. I was pondering this potential solution when I found it in bugzilla. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:00:34 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #11 from M. Tompsett --- Comment on attachment 49716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49716 Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar Review of attachment 49716: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3669&attachment=49716) ----------------------------------------------------------------- ::: circ/add_message.pl @@ +51,4 @@ > } > )->store; > > +my $url = $input->referer(); http://perldoc.perl.org/CGI.html "referer() Return the URL of the page the browser was viewing prior to fetching your script. Not available for all browsers." -- might be a good idea to // "/cgi...$borrowernumber"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:51:19 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:51:23 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49596|0 |1 is obsolete| | Attachment #49597|0 |1 is obsolete| | Attachment #49607|0 |1 is obsolete| | Attachment #49740|0 |1 is obsolete| | Attachment #49741|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer --- Created attachment 49766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49766&action=edit [PASSED QA] Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed Signed-off-by: Owen Leonard Patron batches are correctly passed to the edit and delete pages. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:51:57 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #85 from Katrin Fischer --- Created attachment 49767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767&action=edit [PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items This follow-up patch for Bug 10612 moves all list operations into one menu while (hopefully) clarifying the labels for each. Also in this patch: Changed datatables sorting configuration to use the "nosort" attribute. To test, apply the patch and go to Tools -> Patron lists. - On a patron list with no patrons, confirm that the "Actions" menu lists "Add patrons," "Edit list," and "Delete list." - On a patron list containing one or more patrons, confirm that the "Actions" menu /also/ has these options: "Print patron cards," "Batch edit patrons," and "Batch delete patrons." - Confirm that the "actions" column is not sortable. - Test logging in as a user who has various combinations of permission to batch edit and batch delete. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:52:01 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #86 from Katrin Fischer --- Created attachment 49768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768&action=edit [PASSED QA] Bug 10612: Follow-up - correcting icon to be Font Awesome - check print icon on the patron list summary page is correct Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:52:06 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #87 from Katrin Fischer --- Created attachment 49769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769&action=edit [PASSED QA] Bug 10612 - Unit tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 05:52:10 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #88 from Katrin Fischer --- Created attachment 49770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770&action=edit [PASSED QA] Bug 10612: (QA followup) Rename not_borrowered_since to not_borrowed_since Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 08:30:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 06:30:32 +0000 Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #24 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #16) > (In reply to Jacek Ablewicz from comment #14) > > I have kinda mixed feelings about flush_L1_if_needed() feature. It provides > > nice speed-up for plack setups, but - unless I'm very much mistaken, it also > > makes L2 cache expiration mechanism unreliable under plack (?). > > Regarding the benchmarks, this part will certainly be dropped. Without that part, 2nd patch (don't clone cache results for framework/authvals) would be a whole lot less risky under plack - it may still cause some (hopefully minor) issues, but at least they will be predictable & reproductible under plack as well as in the CGI setups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 08:31:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 06:31:40 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:15:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 07:15:35 +0000 Subject: [Koha-bugs] [Bug 16146] [3.22] ACQ: Previewed records in Z39.50 search results are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Passed QA |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6. Thanks everyone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 07:52:23 +0000 Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 07:52:25 +0000 Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170 --- Comment #10 from Marcel de Rooy --- Created attachment 49771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49771&action=edit Bug 16170: [QA Follow-up] Adjust Items.t Items.t inserts an item via biblioitem not correctly linked to biblio. The new foreign key constraint does not allow that. Actually, we should be choosing to either remove biblioitems from Koha or remove biblionumber from items. Note: This seems to be the only case where an item is added this way. Test plan: Run Items.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 07:52:30 +0000 Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170 --- Comment #11 from Marcel de Rooy --- Created attachment 49772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49772&action=edit Bug 16170: [QA Follow-up] Fix embeded typos Just noticed this typo three times here. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:54:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 07:54:53 +0000 Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170 --- Comment #12 from Marcel de Rooy --- Remember to adjust DBIx (for testing you could just insert is_foreign_key => 1 for biblionumber in Items.pm If you would run t/db_dependent/Barcodes_ValueBuilder.t, TestBuilder needs to see that biblionumber is a foreign key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:04:29 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:04:32 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49765|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 49773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49773&action=edit Bug 16177: Fix tests for ColumnsSsettings.t This failure has been introduced by commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files This is because the cannot_be_modified key is not always created by C4::Utils::DataTables::ColumnsSettings subroutines Test plan: prove t/db_dependent/ColumnsSettings.t should return green And you can also test a table where the feature is set and a column cannot be modified from the admin page. NOTE: Works as described. I was pondering this potential solution when I found it in bugzilla. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:04:43 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:11:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:11:59 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:12:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:12:01 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49756|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 49774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49774&action=edit Bug 16176: Fix a test about OpenLibrarySearch Introduced by bug 6624: When C4::UsageStats::BuildReport is modified, the tests should be too. Test plan: prove t/db_dependent/UsageStats.t should return green Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Note that if we maintain this list of sysprefs at two places, we will probably have this test failing regularly.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:12:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:12:12 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:15:59 +0000 Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed number of tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:16:02 +0000 Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed number of tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49705|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 49775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49775&action=edit Bug 16173: db_structure.t shouldn't have a fixed number of tests This patch makes db_structure.t more flexible regarding how many tests are run. This is important because it would fail on each db structure change, masking potential real problems. To test: - Run $ prove t/db_dependent/db_structure.t => FAIL: the number of tests ran doesn't match what is expected - Apply the patch - Run $ prove t/db_dependent/db_structure.t => SUCCESS: Tests count is not an issue [1] - Sign off [1] Right now the tests run successfuly, they might fail if a real bug is introduced on the DB structure, in the meantime. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:16:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:16:12 +0000 Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed number of tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:35:49 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:35:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:35:51 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49744|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 49776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49776&action=edit Bug 16178: Fix tests for xt/single_quotes.t Caused by commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac Bug 15206: Make strings translatable Test plan: prove xt/single_quotes.t should return green Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:37:03 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:37:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:37:46 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 --- Comment #4 from Marcel de Rooy --- Spotted another one (outside the templates) too: cataloguing/value_builder/unimarc_leader.pl: alert(_('leader has an incor But fixing that one is useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:47:16 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:47:19 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49702|0 |1 is obsolete| | Attachment #49703|0 |1 is obsolete| | Attachment #49757|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 49777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49777&action=edit Bug 16174: Warning in tt_valid.t due to bug 15527 Bug 15527 introduced a new directory (xslt) on the top level OPAC templates directory. The tt_valid.t script should include that top level dir on the list of excluded dirs so it doesn't look for themes there. To test: - Run $ prove xt/tt_valid.t => FAIL: You get the following warning: Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory at xt/tt_valid.t line 8 - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests pass and don't raise warnings. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:47:23 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #9 from Marcel de Rooy --- Created attachment 49778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49778&action=edit Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:47:27 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 --- Comment #10 from Marcel de Rooy --- Created attachment 49779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49779&action=edit Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 08:47:39 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 09:26:37 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:26:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 09:26:39 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #14 from Marcel de Rooy --- Created attachment 49780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49780&action=edit Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm As requested by QA, the sub should be moved. Test plan: See previous patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:28:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 09:28:34 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #13) > So I am not convinced that we should move it. But if you really insist, I'd > rather move it to Upload.pm or so? No reply is also an answer. Jesse: I moved it. Please finish QA now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 13:48:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 11:48:07 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #18 from Benjamin Rokseth --- Comment on attachment 44373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44373 Bug 15126: x-mojo-controller deprecation >From a1267ff354633ef7f491704f81d9ffe1590672a7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize >Date: Wed, 7 Oct 2015 14:49:17 +0000 >Subject: [PATCH] Bug 15126: x-mojo-controller deprecation > >Remove the use of soon to be deprecated x-mojo-controller from our >specification and replace with the recommended operationId format. >--- > Koha/REST/V1/{Patrons.pm => Patron.pm} | 6 +++--- > api/v1/swagger.json | 2 -- > 2 files changed, 3 insertions(+), 5 deletions(-) > rename Koha/REST/V1/{Patrons.pm => Patron.pm} (96%) > >diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patron.pm >similarity index 96% >rename from Koha/REST/V1/Patrons.pm >rename to Koha/REST/V1/Patron.pm >index 6468bba..fee6c31 100644 >--- a/Koha/REST/V1/Patrons.pm >+++ b/Koha/REST/V1/Patron.pm >@@ -1,4 +1,4 @@ >-package Koha::REST::V1::Patrons; >+package Koha::REST::V1::Patron; > > # This file is part of Koha. > # >@@ -22,7 +22,7 @@ use Mojo::Base 'Mojolicious::Controller'; > use C4::Auth qw( haspermission ); > use Koha::Patrons; > >-sub list_patrons { >+sub list { > my ($c, $args, $cb) = @_; > > my $user = $c->stash('koha.user'); >@@ -35,7 +35,7 @@ sub list_patrons { > $c->$cb($patrons->unblessed, 200); > } > >-sub get_patron { >+sub get { > my ($c, $args, $cb) = @_; > > my $user = $c->stash('koha.user'); >diff --git a/api/v1/swagger.json b/api/v1/swagger.json >index 8f32781..e821c44 100644 >--- a/api/v1/swagger.json >+++ b/api/v1/swagger.json >@@ -16,7 +16,6 @@ > "paths": { > "/patrons": { > "get": { >- "x-mojo-controller": "Koha::REST::V1::Patrons", > "operationId": "listPatrons", > "tags": ["patrons"], > "produces": [ >@@ -43,7 +42,6 @@ > }, > "/patrons/{borrowernumber}": { > "get": { >- "x-mojo-controller": "Koha::REST::V1::Patrons", > "operationId": "getPatron", > "tags": ["patrons"], > "parameters": [ >-- >1.9.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:16:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:16:13 +0000 Subject: [Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:21:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:21:30 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44372|0 |1 is obsolete| | Attachment #44373|0 |1 is obsolete| | Attachment #44374|0 |1 is obsolete| | --- Comment #19 from Benjamin Rokseth --- Created attachment 49781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49781&action=edit Bug 15126: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:21:52 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #20 from Benjamin Rokseth --- Created attachment 49782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49782&action=edit Bug 15126: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:22:02 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #21 from Benjamin Rokseth --- Created attachment 49783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49783&action=edit Bug 15126: Update dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:22:38 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:26:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:26:10 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #22 from Benjamin Rokseth --- Sorry for the spamming, I rebased the patches against master, since some changes were already pushed to master by bug #13799. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:55:05 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Bug 12772 depends on bug 16007, which changed state. Bug 16007 Summary: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:55:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 12:55:04 +0000 Subject: [Koha-bugs] [Bug 16007] Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice at biblibre.com Status|Pushed to Master |RESOLVED --- Comment #24 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:01:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:01:26 +0000 Subject: [Koha-bugs] [Bug 16151] can't place holds from lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:03:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:03:50 +0000 Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:06:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:06:39 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:10:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:10:25 +0000 Subject: [Koha-bugs] [Bug 16040] Quote deletion never ending processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16040 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:13:03 +0000 Subject: [Koha-bugs] [Bug 16082] Empty patron detail page is displayed if the patron does not exist - circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:34:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:34:03 +0000 Subject: [Koha-bugs] [Bug 16185] New: t/db_dependent/Reports_Guided.t is failing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Bug ID: 16185 Summary: t/db_dependent/Reports_Guided.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org "t_db_dependent_Reports_Guided_t.filter takes report id (661)" http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680/testReport/ prove t/db_dependent/Reports_Guided.t should run successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:37:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:37:13 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Turns out my perlcritic happiness tendency found a solution. Scalar was being used as a function. Removing function-like bracketing fixed the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:47:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:47:57 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:47:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:47:59 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 --- Comment #2 from M. Tompsett --- Created attachment 49784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49784&action=edit Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:49:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:49:03 +0000 Subject: [Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due to layout change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice at biblibre.com Status|Pushed to Master |RESOLVED --- Comment #11 from Julian Maurice --- Tests pass on 3.22.x without this patch, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:57:05 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #68 from Martin Renvoize --- Created attachment 49785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49785&action=edit Bug 10988 - Fixes for comments 57 and 58 Test Plan (remains the same): 0) Back up your database 1) Apply all these patches 2) In your mysql client use your Koha database and execute: > DELETE FROM systempreferences; > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql; -- Should be no errors. > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see 4 entries. > QUIT; 3) Restore your database 4) Run ./installer/data/mysql/updatedatabase.pl; 5) In your mysql client use your Koha database and execute: > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see the same 4 entries. 6) Log into the staff client 7) Home -> Koha administration -> Global system preferences 8) -> OPAC -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca) 9) -> Administration -- There should be a 'Google OAuth2' section with the ability to set those 4 system preferences. 10) In a new tab, go to https://console.developers.google.com/project 11) Click 'Create Project' 12) Type in a project name that won't freak users out, like your library name (e.g. South Pole Library). 13) Click the 'Create' button. 14) Click the 'APIs & auth' in the left frame. 15) Click 'Credentials' 16) Click 'Create new Client ID' 17) Select 'Web application' and click 'Configure consent screen'. 18) Select the Email Address. 19) Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) 20) Fill in the other fields as desired (or not) 21) Click 'Save' 22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://library.yourDNS.org) 23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleopenidconnect) 24) Click 'Create Client ID' 25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID system preference. 26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret system preference. 27) Change the GoogleOpenIDConnect preference to 'Use'. 28) Click 'Save all Administration preferences' 29) In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. 30) Run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:57:09 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #69 from Martin Renvoize --- Created attachment 49786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49786&action=edit Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:57:13 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #70 from Martin Renvoize --- Created attachment 49787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49787&action=edit Bug 10988: Tabs vs Spaces qa failure patch Run Koha QA Test tools and discovered this failed because of tabs. Rather than fail this and wait forever for it to get fixed, this patches it, and I'll mark it as signed off anyways. Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:57:49 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:58:00 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:58:12 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 13:58:36 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #71 from Martin Renvoize --- Looks great, works great, good enhancement.. well done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:03:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:03:55 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49271|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 49788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output Signed-off-by: Jason DeShaw Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:04:36 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Nice enhancement, should make things much more extensible.. Go forth :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:07:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:07:18 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:10:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:10:52 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46183|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 49790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49790&action=edit Bug 11807: (follow-up) remove date conversions To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : STU ... STUDENT EMPLOYEE 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:10:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:10:49 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46182|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 49789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49789&action=edit Bug 11807 : Add support for categorycode conversions when updating an user using a LDAP server. To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : STU ... STUDENT EMPLOYEE 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:11:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:11:44 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- Happy there no breaking changes here, and a worthwhile addition. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:18:56 +0000 Subject: [Koha-bugs] [Bug 16186] New: t/db_dependent/Circulation_Issuingrule.t is failing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Bug ID: 16186 Summary: t/db_dependent/Circulation_Issuingrule.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 5786 changed the query for GetIssuingRules to SELECT *, which means if columns are added to the DB, this breaks. Add missing column(s) into the issuing rules hashes in the test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:18:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:18:58 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 --- Comment #8 from Martin Renvoize --- Just to note.. I tested this for QA just after Katring passed it.. it was all good but I never gave it my stamp.. so here's a stamp :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:19:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:19:14 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:19:25 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:26:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:26:42 +0000 Subject: [Koha-bugs] [Bug 16129] Remove URL::Encode dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49743|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 49791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49791&action=edit Bug 16129: Remove URL::Encode dependency This patch makes the PayPal integration feature independent from the URL::Encode library, which is absent in some supported distributions. It uses the URI package which is already a Koha dependency. To test: - Apply the patch - Notice there are no deps for URL::Encode - Follow the steps from the original patch => SUCCESS: It works as expected - Sign-off :-D Note: I deleted the line in which $amount_to_pay was url-encoded, because that's one of the things query_form does (and the variable is only used as a parameter to it). Sponsored-by: ByWater Solutions Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:27:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:27:18 +0000 Subject: [Koha-bugs] [Bug 16129] Remove URL::Encode dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Good move Tomas, works as advertised, removes the dependency without causing any issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:31:10 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #15 from Colin Campbell --- (In reply to Kyle M Hall from comment #13) > I will try to find some time to run some tests. Here is what I will do: > > 1) Revert 13432 on master > 2) Set up a script that continuously makes sip2 calls via sip_cli_emulator.pl > 3) Let that run for a long time > 4) Note whether memory usage increases dramatically > 5) Apply this patch > 6) Repeat steps 2-4 > 6) Apply bug 15006 > 7) Repeat steps 2-4 > > If everything checks out, we should move ahead with this. > > Colin, does that seem like a reasonable test plan? Yes - Would be interested if the same test was run using Netserver::Fork, instead of Netserver::Prefork that should return resources from dead connections (although memory leak may be elsewhere) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:31:46 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49736|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 49792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49792&action=edit Bug 16138: Restart plack when rotating logfiles On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to permission issues: Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm : ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97. ...propagated at /usr/share/perl/5.20/base.pm line 106. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68. Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8. Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25. Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90. Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34. As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation gracefully[1]. I'm not sure how to reproduce it on a dev environment. [1] https://github.com/miyagawa/Starman/issues/55 Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:31:54 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:32:04 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #30 from Charles Farmer --- Created attachment 49793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49793&action=edit Bug 12446 - Enable adult patrons to have a guarantor I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:32:24 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Simple, but effective. I managed to replicated the issues, and his patch fixed them. Cheers Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:36:54 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com Attachment #46345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:37:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:37:10 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:38:56 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:38:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:38:59 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 --- Comment #1 from M. Tompsett --- Created attachment 49794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49794&action=edit Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing Went a little beyond scope and added missing fields, even though tests weren't failing. TEST PLAN --------- 1) prove t/db_dependent/Circulation_Issuingrule.t -- fails 2) apply patch 3) prove t/db_dependent/Circulation_Issuingrule.t -- pass 4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t -- notice that bug 5876 and bug 9129 combined to cause this 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:43:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:43:45 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- 16044 is pushed to master now.. presume we only need the one patch.. (in fact they look the same to me on cursory glance) Obsoleting the 'on top of bug 16044' version and qa'ing the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:43:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:43:55 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:51:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:51:59 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49168|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:53:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 14:53:30 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 --- Comment #9 from Martin Renvoize --- On second thoughts, it looks like it needs rebasing.. I've un-obsoleted the one I obsoleted. Applying the 'master' one results in a qa script error: FAIL valid Global symbol "%syspref_L1_cache" requires explicit package name Compilation failed in require BEGIN failed--compilation aborted As I'm not totally up to speed on this, I'm going to leave re-basing to someone else.. even though it looks trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:02:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:02:30 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Ian Bays changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com --- Comment #9 from Ian Bays --- I suppport what Heather says in comment 5 that it has the appearance of a bug. If you search for a user with both names from the patron search on the Koha staff home page you get a short list or no results. If you then do the same search from the Patrons page you get many more results. If you are worried about getting too many results then you may need to select something different such as "begins with". We have just installed a couple of new customers with version 3.22.03.000 and they are assuming it will be fixed soon. I hope this has not stalled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:09:23 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:09:26 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49784|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 49795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49795&action=edit Bug 16185: t/db_dependent/Reports_Guided.t is failing TEST PLAN --------- 1) prove t/db_dependent/Reports_Guided.t -- fails -- note the failure has a scalar function-like bracketing 2) apply patch 3) prove t/db_dependent/Reports_Guided.t -- passes 4) git diff origin/master -- note all scalars have been changed to not have function-like brackets which could be incorrectly parsed. 5) run koha qa test tools Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:09:47 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:11:49 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:11:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:11:52 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49794|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 49796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49796&action=edit Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing TEST PLAN --------- 1) prove t/db_dependent/Circulation_Issuingrule.t -- fails 2) apply patch 3) prove t/db_dependent/Circulation_Issuingrule.t -- pass 4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t -- notice that bug 5876 and bug 9129 combined to cause this 5) run koha qa test tools Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:13:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:13:07 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA --- Comment #3 from Tom?s Cohen Arazi --- Trivial fix for the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:20:51 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47108|0 |1 is obsolete| | --- Comment #69 from Tom?s Cohen Arazi --- Created attachment 49797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49797&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:00 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47109|0 |1 is obsolete| | --- Comment #70 from Tom?s Cohen Arazi --- Created attachment 49798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49798&action=edit Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:05 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47110|0 |1 is obsolete| | --- Comment #71 from Tom?s Cohen Arazi --- Created attachment 49799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49799&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:11 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47111|0 |1 is obsolete| | --- Comment #72 from Tom?s Cohen Arazi --- Created attachment 49800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49800&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:16 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47112|0 |1 is obsolete| | --- Comment #73 from Tom?s Cohen Arazi --- Created attachment 49801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49801&action=edit Bug 14598 - QA Followup touching CanBookBeIssued subroutine Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:25 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47113|0 |1 is obsolete| | --- Comment #74 from Tom?s Cohen Arazi --- Created attachment 49802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49802&action=edit Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:34 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47114|0 |1 is obsolete| | --- Comment #75 from Tom?s Cohen Arazi --- Created attachment 49803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49803&action=edit Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:50 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47115|0 |1 is obsolete| | --- Comment #76 from Tom?s Cohen Arazi --- Created attachment 49804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49804&action=edit Bug 14598 [QA Followup] - Make unit test pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:21:59 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47116|0 |1 is obsolete| | --- Comment #77 from Tom?s Cohen Arazi --- Created attachment 49805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49805&action=edit Bug 14598 [QA Followup] - Update localuse statistics also Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:22:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:22:29 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #78 from Tom?s Cohen Arazi --- Patches rebased so they apply on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:22:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:22:28 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 --- Comment #10 from Nick Clemens --- Created attachment 49806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49806&action=edit Bug 15008 - (QA followup) Add sysprefs.sql changes for new installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:25:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:25:27 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:26:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:26:24 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #79 from Tom?s Cohen Arazi --- Created attachment 49807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49807&action=edit Bug 14598: (followup) Remove unused and non-existent C4::ItemType include Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:31:24 +0000 Subject: [Koha-bugs] [Bug 16187] New: Add a script to cancel unfilled holds after a specified number of days Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Bug ID: 16187 Summary: Add a script to cancel unfilled holds after a specified number of days Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Work to be done: 1) Create new script cancel_unfilled_holds.pl --days DAYS 2) This script would accept a --days parameter, and trigger C4::Reserves::CancelReserve for all unfilled holds with a 'reservedate' older than the the given number of days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:31:34 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- I don't agree with Jonathan on this patch. I think tests (like Reserves.t) should create well-formed scenarios. If they are raising warnings, then they need to be fixed. And that's not the situation here. because we are explicitly creating this 'bad' scenario, to test the behaviour in that specific scenario. So, worth testing for the warning this time. I might be missing something anyway, so I'm open to discuss this. It doesn't apply BTW, because of the latest rebase of bug 14598. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:32:08 +0000 Subject: [Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:43:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 15:43:35 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49167|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:03:17 +0000 Subject: [Koha-bugs] [Bug 16188] New: SMS via email not applicable in India due to telecom regulation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Bug ID: 16188 Summary: SMS via email not applicable in India due to telecom regulation Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://lists.katipo.co.nz/pipermail/koha/2016-April/0 45114.html OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Notices Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 9021 Due to the nature of telecom regulatory framework in India, bug 9021 will not work for 99% of 500+ million cell phones in India. Details as explained in this mail with specific examples - https://lists.katipo.co.nz/pipermail/koha/2016-April/045114.html This patch adds a "note" for such exceptions like India in the provider setup screen. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:03:17 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 [Bug 16188] SMS via email not applicable in India due to telecom regulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:07:27 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 --- Comment #10 from Jacek Ablewicz --- Created attachment 49808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49808&action=edit Bug 16068: Do not cache overridden prefs These prefs do not need to be cached, a quick access to $ENV permit to get the value. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:09:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:09:57 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:14:47 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16189 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:14:47 +0000 Subject: [Koha-bugs] [Bug 16189] New: Add an exception to SMS via email documentation in the Koha manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16189 Bug ID: 16189 Summary: Add an exception to SMS via email documentation in the Koha manual Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://lists.katipo.co.nz/pipermail/koha/2016-April/0 45114.html OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Add an "exception note" that basically says "this may not work for all providers. Especially, users in India should aware of any liability - both civil and criminal, for sending unauthorised bulk SMS using this feature." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 18:16:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 16:16:26 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 19:51:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 17:51:03 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 19:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 17:51:06 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49255|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 49809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49809&action=edit Bug 15745: C4::Matcher gets CCL parsing error if term contains ? (question mark) Signed-off-by: Olli-Antti Kivilahti Also fixes ! and + Rebased to master Signed-off-by: Tomas Cohen Arazi It makes perfect sense and works as expected. This part of the code is too under-tested so no point requiring a regression test for such a simple change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:01:49 +0000 Subject: [Koha-bugs] [Bug 16056] Error when deleting MARC authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16056 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:01:52 +0000 Subject: [Koha-bugs] [Bug 16056] Error when deleting MARC authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16056 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49394|0 |1 is obsolete| | Attachment #49437|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 49810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49810&action=edit Bug 16056: Do not crash when searching for an authority if zebra's index is not up-to-date This patch fixes a regression introduced by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode This first version will reintroduce the same behavior as before bug 15381: the record will be displayed even if it's no in the DB Test plan: Search for authorities delete one The zebra's index is not updated yet and the results will contain the record you have deleted. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:39:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:39:05 +0000 Subject: [Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:39:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:39:08 +0000 Subject: [Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 49811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49811&action=edit Bug 15113: koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled This patch changes the behaviour of the koha-rebuild-zebra script in the following way: USE_INDEXER_DAEMON=no - Keeps the current behaviour USE_INDEXER_DAEMON=yes - It skips incremental indexing to avoid races. Caveats: - A --force option is introduced for useing in a specific situtation that might need it (i.e. the administrator knows what he's doing). - If --full is passed, the reindexing is not skipped. The documentation files and messages are adjusted accordingly. This patch should help users that want to use the indexing daemon, in which case they wouldn't need to change their default 5 min cronjob (it will be just skipped). Ultimately, koha-common could have USE_INDEXER_DAEMON = yes by default, but that's subject for another bug report. To test: - Play with the different option switches and USE_INDEXER_DAEMON - Things work as expected - Sign off Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:42:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:42:29 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:45:41 +0000 Subject: [Koha-bugs] [Bug 16190] New: Enable the indexer daemon by default Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 Bug ID: 16190 Summary: Enable the indexer daemon by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The indexing daemon is a really cool feature, that there's no reason to have disabled by default. It allows end-users experience almost real-time indexing (with the default 5 seconds frecquency, which could even be lowered). And we have it disabled by default. It prevents queuing too many reindexing actions, and has really low footprint (compared to the cronjob version). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:46:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:46:13 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:47:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:47:06 +0000 Subject: [Koha-bugs] [Bug 16190] Enable the indexer daemon by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Patch complexity|--- |Trivial patch Depends on| |15113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:47:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:47:06 +0000 Subject: [Koha-bugs] [Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 [Bug 16190] Enable the indexer daemon by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:47:29 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:48:45 +0000 Subject: [Koha-bugs] [Bug 16129] Remove URL::Encode dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:51:31 +0000 Subject: [Koha-bugs] [Bug 16190] Enable the indexer daemon by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:51:33 +0000 Subject: [Koha-bugs] [Bug 16190] Enable the indexer daemon by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 49812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49812&action=edit Bug 16190: Enable the indexer daemon by default This patch enables the indexer daemon by default on packages installs. It does so by setting USE_INDEXER_DAEMON=yes on the /etc/default/koha-common file. It does remove now irrelevant comments from that file. This patch is straightforward to review. If is just a matter of choosing to enable or not to enable by default. Kind regards PS: Let end users rejoice this so far hidden feature :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:54:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:54:46 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49808|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 49813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49813&action=edit Bug 16068: Do not cache overridden prefs These prefs do not need to be cached, a quick access to $ENV permit to get the value. Signed-off-by: Jacek Ablewicz Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 20:55:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 18:55:43 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- Sorted, works as advertised passing all my testing with flying colours. Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:05:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:05:25 +0000 Subject: [Koha-bugs] [Bug 16056] Error when deleting MARC authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16056 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:05:54 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:06:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:06:30 +0000 Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:09:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:09:56 +0000 Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:11:12 +0000 Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:12:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:12:16 +0000 Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and tt_valid.t due to bug 15527 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:13:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:13:23 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:14:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:14:00 +0000 Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:15:20 +0000 Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed number of tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:20:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:20:24 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #13 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:24:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:24:41 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #16 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 21:51:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 19:51:18 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #72 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 22:02:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 20:02:45 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #89 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:30:31 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #156 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks. RM note - still need to run dbix schema ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:32:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:32:38 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #11 from M. Tompsett --- There are currently a lot of itemtype things going on right now. These two test cases are rather quiet currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:36:51 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! RM note - I am now running the dbix schema update for both this and bug 7736 at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:57:57 +0000 Subject: [Koha-bugs] [Bug 16191] New: t/Ris.t is noisy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Bug ID: 16191 Summary: t/Ris.t is noisy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com While running a "prove -r t", I noticed again t/Ris.t is noisy. Fixing most of the issues are relatively easy. However, Jonathan suggests that I open a new bug as a result of commenting on this particular issue (see bug 12357). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12357 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 23:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 21:58:21 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16191 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 00:02:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 22:02:30 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 00:02:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 22:02:33 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 --- Comment #1 from M. Tompsett --- Created attachment 49814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49814&action=edit Bug 16191: t/Ris.t is noisy TEST PLAN --------- 1) prove t/Ris.t -- very noisy 2) apply patch 3) prove t/Ris.t -- just one confusing noise. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 00:02:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 22:02:53 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 00:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 22:03:26 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 01:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Apr 2016 23:15:47 +0000 Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 08:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 06:47:18 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Marc V?ron --- Sorry, I get: Undefined subroutine &main::GetGuarantees called at /usr/share/kohaclone/members/moremember.pl line 180. I think it is related to Bug 15656 Bug 15656 - Move the guarantor/guarantees code to Koha::Patron (Pushed to aster) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 09:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 07:03:26 +0000 Subject: [Koha-bugs] [Bug 16190] Enable the indexer daemon by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 09:07:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 07:07:15 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49814|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 49815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49815&action=edit Bug 16191: t/Ris.t is noisy TEST PLAN --------- 1) prove t/Ris.t -- very noisy 2) apply patch 3) prove t/Ris.t -- just one confusing noise. 4) run koha qa test tools Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 09:07:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 07:07:39 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 10:03:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 08:03:31 +0000 Subject: [Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49748|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 49816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49816&action=edit Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Tested on top of Bug 16161 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 10:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 08:03:53 +0000 Subject: [Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 10:14:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 08:14:04 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 10:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 08:14:21 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49663|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 49817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49817&action=edit Bug 16164: Making check expiration actions buttons To test: 1) Go to Serials -> Check expiration 2) Put in a date where one or more subscriptions will expire prior to this date 3) Confirm that column heading is now 'Actions' 4) Confirm that Edit and Renew now show as font awesome buttons 5) Confirm that the buttons don't wrap on narrower browsers 6) Confirm the buttons still work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 17:16:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 15:16:07 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #8 from Owen Leonard --- (In reply to Jonathan Druart from comment #7) > Would not it better to fix the atom feeds instead of removing it? Making the atom feed work would really be a new feature, since as far as I can tell they were never actually implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 17:21:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 15:21:02 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 --- Comment #1 from Owen Leonard --- The first step in diagnosing this problem is to figure out why you see a "rate me" button in the first place. The star ratings JavaScript should hide that button automatically. That you see a "rate me" button indicates that there is a JavaScript error on the page which is interrupting execution. Do you have any custom JavaScript in OPACUserJS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 2 23:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Apr 2016 21:41:58 +0000 Subject: [Koha-bugs] [Bug 16190] Enable the indexer daemon by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 13:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 11:52:03 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #90 from Katrin Fischer --- Tests are failing on Jenkins, but passing when I run them locally: http://jenkins.koha-community.org/job/Koha_master_D7/lastCompletedBuild/testReport/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:31:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:31:14 +0000 Subject: [Koha-bugs] [Bug 13136] Add documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No documentation for Home > |Add documentation for Home |Tools > Labels home > |> Tools > Labels home > |Manage label Layouts |Manage label Layouts CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:39:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:39:17 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer at bsz-bw.de Component|Tools |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:46:02 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Aleisha, I noticed that the icon used for "renew" is different on the check expiration and on the subscription detail page - can you please check (maybe other spots too)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:51:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:51:08 +0000 Subject: [Koha-bugs] [Bug 16161] Add confirm message when deleting dictionary definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:51:11 +0000 Subject: [Koha-bugs] [Bug 16161] Add confirm message when deleting dictionary definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16161 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49710|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49818&action=edit [PASSED QA] Bug 16161: Confirm message when deleting definition To test: 1) Go to Reports -> View dictionary 2) Attempt to delete definiton. Confirm that a confirm messages comes up and works as expected. Sponsored-by: Catalyst IT NOTE: confirmation message didn't exist before patch. confirmation message appeared after patch. both options worked as expected. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:52:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:52:02 +0000 Subject: [Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:52:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:52:05 +0000 Subject: [Koha-bugs] [Bug 16162] Making dictionary 'Delete' a font awesome button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49816|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 49819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49819&action=edit [PASSED QA] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Tested on top of Bug 16161 Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:56:38 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- This works and I know that those scripts are problematic up to the point of 'should be rewritten from scratch'. So I am passing it. Anyway, I think a better solution would be to get rid of the concat altogether and handle the existence of firstname and surname on template level including the ','. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:57:46 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 14:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 12:57:49 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49763|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 49820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49820&action=edit [PASSED QA] Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James TEST PLAN --------- 1) Ensure you have some checkouts 2) Home -> Reports -> Patrons with the most checkouts 3) Click 'Submit' -- you get a list 4) Click a patron name. 5) Note the borrower number. 6) In MySQL run something like: > UPDATE borrower SET firstname=NULL WHERE borrowernumber=#### 7) Refresh the report page -- name goes totally blank 8) apply patch 9) Refresh the report page -- only first name is lost 10) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:00:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:00:25 +0000 Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and truncated results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Report bor_issues_top |Report bor_issues_top |erroneous and truncated |erroneous and truncated |results. |results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:06:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:06:44 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:06:46 +0000 Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect number of rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49764|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 49821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49821&action=edit [PASSED QA] Bug 16184 - Report bor_issues_top shows incorrect number of rows TEST PLAN --------- 1) Have at least 6 patrons with checkouts and some checkins. 2) Reports -> Patrons with the most checkouts 3) Click 'Submit' (default is 5) -- more than 5 entries listed. 4) Apply patch 5) Refresh page -- only 5 entries listed. 6) Run koha qa test tools NOTE: While this works, I'd be much happier with a refactor as it would also speed up the report. See comment #5. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:09:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:09:39 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Katrin Fischer --- Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Using index info to reconstruct a base tree... M C4/Auth.pm M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Auto-merging C4/Auth.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:14:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:14:32 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #20 from Katrin Fischer --- Fixing sequence of attached patches so they apply cleanly with git-bz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:14:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:14:51 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:15:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:15:23 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #21 from Katrin Fischer --- Created attachment 49822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49822&action=edit Bug 14364: (QA followup) - Remove use of C4:Dates - Fix misnamed variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:40:04 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- I think this could be useful to some libraries as it is, but I agree, there are some catches. Some future variation could be: Cancel the old hold, inform the library, but do not send the information to the next patron yet (this would allow the library to take care of the hold, slip, etc.) before the patron appears at the circulation desk. Some notes from the initial code review: 1) The new notice template includes +Copy: <> but doesn't include the callnumber. I think it should be amended - without the callnumber it's not possible to identify the item in question. Also there are some capitalization issues: Canceled Hold Available for Different Patron 2) From the system preferene it's not clear that this feature is tied to the automatic cancellation: ExpireReservesAutoFill yes: "Do" no: "Don't" automatically fill the next hold using the item. If enabled, an email notification will be sent to either the email address defined in 3) The tests for for ModReserveAffect have been adapted, but there are no new tests the change itself. There are also no changes to the tests for the changed: CancelExpiredReserves CancelReserve Failing for 3) - please take care of adding tests for this new functionality relfecting the changes in the routines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:50:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:50:47 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- The patch attached includes a lot of changes to the code for showing waiting holds - I think this might be a mistake as nothing of it is mentioned in the test plan. Please check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 15:56:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 13:56:10 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #23 from Katrin Fischer --- Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15839: Koha::Reviews - Add Koha::Review[s] classes Applying: Bug 15839: Koha::Reviews - Remove getreviews Applying: Bug 15839: Koha::Reviews - Remove getallreviews Applying: Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview Applying: Bug 15839: Koha::Reviews - Change default value for approved to 0 Applying: Bug 15839: Koha::Reviews - Remove deletereview fatal: sha1 information is lacking or useless (C4/Review.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15839: Koha::Reviews - Remove deletereview The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:41:24 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:41:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:41:27 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #1 from Marcel de Rooy --- Created attachment 49823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49823&action=edit Bug 13438: Convert normarc framework plugins to new style Converts NORMARC plugins to new style (with builder and launcher). See also bugs 10480 and 13437. Note: Search.pm is not needed in these plugins. Tabs have been removed in the same pass. Note 2: For the 008 plugin the tag editor already seems to have some problems (js errors on e.g. f18 for Velg materialtype, etc.) This makes that pressing OK does not always work. Outside the scope of this report. Test plan: [1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/normarc*.pl. (Ignore substr and uninitialized warnings; these are not in the scope of this patch.) [2] Connect the plugin. Test focus (leader,008) and click event. (See note 2.) [3] Look for warnings in the log related(!) to this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:41:52 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:43:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:43:16 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #2 from Marcel de Rooy --- Oops Subroutine date_entered redefined at /usr/share/koha/masterclone/cataloguing/value_builder/normarc_field_008.pl line 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:48:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:48:42 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #3 from Marcel de Rooy --- Created attachment 49824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49824&action=edit Bug 13438: Follow-up for removing date_entered Defining this sub in normarc_field_008.pl is not necessary. Use the one from Koha::Util::FrameworkPlugin. Test plan: Run the 008 plugin again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:55:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:55:33 +0000 Subject: [Koha-bugs] [Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 16:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 14:55:36 +0000 Subject: [Koha-bugs] [Bug 16157] C4::Koha::GetAuthorisedValues should not handle the selected option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49672|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49825&action=edit [PASSED QA] Bug 16157: Move the selected flag from GetAuthorisedValues to the templates >From C4::Koha::GetAuthorisedValues # TODO: the "selected" feature should be replaced by a utility function # somewhere else, it doesn't belong in here. For starters it makes # caching much more complicated. Or just let the UI logic handle it, it's # what it's for. Indeed, it's not a job for a subroutine, the template should take care of that. Note that a perf gain could be won with this patch \o/ Test plan: - Edit an itemtype and check the value of the "Search category" dropdown list - Edit a patron attribute type and check the value of the "Class" dropdown list - Detail for a catalogue record, the Status column should be correctly populated if items are damaged and/or lost - Item details for a catalogue record, the lost, damaged and withdrawn value should be correctly displayed - Edit a patron, the "street type" should be correctly selected - Create a patron attribute type linked to an authorised value list. - Edit a patron, set a value for this attribute, edit it again. The correct value should be selected. - Search for subscriptions. The 'Location' dropdown list should behave correctly (select the entry you have choosen before, etc.) - Edit a subscription, the location dropdown list should select the correct value. - Edit and view a suggestion with a 'reason for suggestion' set (you should have at least 1 OPAC_SUG AV defined) Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:01:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:01:14 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:01:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:01:17 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48252|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49826&action=edit [PASSED QA] Bug 15863: Show/hide date range selection if not needed - dictionnary When creating a dictionary for a date column, there is a "date range" / "all dates" radio buttons and 2 inputs to select the date range. These inputs should be hidden if "all dates" is selected. Test plan: 1/ Create a new dictionary on reports/dictionary.pl 2/ Select a date column (borrowers.dateofbirth of instance) 3/ On step 4, the start/end of the date range inputs should be hidden/shown depending of the radio buttons. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:02:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:02:06 +0000 Subject: [Koha-bugs] [Bug 16171] Show many media (856) in html5media tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:02:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:02:37 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:07:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:07:25 +0000 Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 17:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 15:07:28 +0000 Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49325|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 49827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49827&action=edit [PASSED QA] Bug 16104: Remove warnings "used only once: possible typo" Since bug 11998, the following warnings are raised: Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. It comes from the Koha::Cache 103 if ( can_load( modules => { 'Cache::Memory' => undef } ) ) { Test plan: perl -wc C4/AuthoritiesMarc.pm should return green QA note: this may have an impact on performance but I have not found any other workarounds. NOTE: I applied 15870 to master, got the error (-v 2 -c 5), applied 16104, rebased it in front, error disappeared (still only -c 5), rebased it at the end, and signed off 16104. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 21:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 19:52:40 +0000 Subject: [Koha-bugs] [Bug 16192] New: Coverage reports missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16192 Bug ID: 16192 Summary: Coverage reports missing Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: tomascohen at gmail.com After the server move, the tests don't show the clover coverage report. They should be re-configured. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:28:40 +0000 Subject: [Koha-bugs] [Bug 16168] Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:28:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:28:43 +0000 Subject: [Koha-bugs] [Bug 16168] Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49679|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 49828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49828&action=edit [PASSED QA] Bug 16168: Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm Right now, ->dbh calls are actually quite expensive (they involve DB connection health checks, each and every time). Some speed-sensitive subroutines inside C4/Biblio.pm (GetMarcStructure, GetAuthorisedValueDesc) have this statement my $dbh = C4::Context->dbh; on top of the code, but they don't always/don't usually need DB handle - not at that stage at least. This trivial patch eliminates unneeded ->dbh calls in those subroutines. With it, average GetMarcStructure() running time goes down from 14 miliseconds to 9 miliseconds (on top of Bug 16166), it also makes catalogue search profiling a bit easier. Test plan: 1) apply patch 2) ensure that catalogue searches are still working 3) run t/*Biblio* tests Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:29:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:29:52 +0000 Subject: [Koha-bugs] [Bug 16169] TransformMarcToKoha should not take $dbh in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:29:55 +0000 Subject: [Koha-bugs] [Bug 16169] TransformMarcToKoha should not take $dbh in parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16169 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49683|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49829&action=edit [PASSED QA] Bug 16169: Change prototype for C4::Biblio::TransformMarcToKoha subroutines should not take $dbh in parameter. C4::Biblio::TransformMarcToKoha has it and does not use it. Test plan: Look at the patch and confirm that all occurrences of TransformMarcToKoha have been modified. Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:50:39 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |major --- Comment #3 from Katrin Fischer --- I am sorry, but this doesn't appear to work for me. My test: - A patron from Midway, has 1 checkout, 1 day overdue - No holidays in the calendar - Patron has neither SMS nor email - Overdue notice trigger for Midway is set to delay 1 - Koha admin email and branch email are set - Running overdue_notices.pl - no email to the library is generated - Add email address to patron - Running overdue_notices.pl - generates email notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:50:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:50:45 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 22:52:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 20:52:18 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #4 from Katrin Fischer --- I should note: without an email address no notice is generated at all. Neither the print notice as a fallback, nor the email to the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:11:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:11:24 +0000 Subject: [Koha-bugs] [Bug 16171] Show many media (856) in html5media tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:11:27 +0000 Subject: [Koha-bugs] [Bug 16171] Show many media (856) in html5media tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49738|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 49830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49830&action=edit [PASSED QA] Bug 16171 - Show many media in html5media tabs Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:33:17 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:33:20 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49817|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 49831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49831&action=edit Bug 16164: Making check expiration actions buttons EDIT: Using same font awesome icon for 'Renew' as in other places To test: 1) Go to Serials -> Check expiration 2) Put in a date where one or more subscriptions will expire prior to this date 3) Confirm that column heading is now 'Actions' 4) Confirm that Edit and Renew now show as font awesome buttons 5) Confirm that the buttons don't wrap on narrower browsers 6) Confirm the buttons still work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:34:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:34:31 +0000 Subject: [Koha-bugs] [Bug 16085] Error: Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 493 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16085 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hi Aida, the link seems to work on now. Please try on the mailing list if the problem still remains and include information about the version you are using and how it was installed (tarball, packages, git, ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:43:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:43:09 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 3 23:43:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Apr 2016 21:43:15 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:21:49 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48096|0 |1 is obsolete| | --- Comment #68 from David Cook --- Created attachment 49832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49832&action=edit Bug 10662 - Build OAI-PMH Harvesting Client _QUICK AND TENTATIVE TEST PLAN_ In the following steps replace "/home/user" with whatever your Koha dev install is _CONFIGURATION_ 1) Add something like the following to your koha-conf.xml after and before unix:/home/user/koha-dev/var/run/icarus.sock /home/user/koha-dev/var/run/icarus.pid /home/user/koha-dev/var/log/icarus.log Koha::Icarus::Task::Enqueue::OAIPMH::Biblio Koha::Icarus::Task::Dequeue::OAIPMH::Biblio Koha::Icarus::Task::Test 30 2) Apply Bugzilla patches 15555, 15541, 15745, then 10662 3) Upgrade your Koha dev install so that it uses new Zebra configuration files; try something like the following: perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make test make upgrade 4) Run upgrade database: perl installer/data/mysql/updatedatabase.pl 4) Set PERL5LIB to include /home/user/koha (i.e. path to your C4 and Koha module directories) export PERL5LIB=/home/user/koha 5) Activate Icarus using the following command: perl /home/user/koha/misc/bin/icarusd.pl -f /home/user/koha-dev/etc/koha-conf.xml NOTE: It will send output to your terminal window. To write to the log file, you can daemonize by adding the "-d" or "--daemon" options. 6) In Koha, create a record matching rule: Code = OAI Match threshold = 100 Record type = Bibliographic Search index = control-number Score = 100 Tag = 001 Search index = id-other,st-urx Score = 100 Tag = 024 Subfields = a Normalization rule = raw _USER DOWNLOAD TASK_ 7a) Go to Koha administration > Saved tasks (http://KOHA/cgi-bin/koha/admin/saved_tasks.pl) 7b) Click "New saved task" 7c) Leave it on "Koha::Icarus::Task::Enqueue::OAIPMH::Biblio" and click "Next" 7d) Choose a "Start time" in the past using the calendar pop-up 7e) Choose a "Repeat interval" of at least 30 seconds (for initial troubleshooting purposes) 7f) Choose a URL of an OAI-PMH repository that you want to harvest (also include a username, password, and realm if necessary) 7g) Fill out your OAI-PMH repositories as you like 7h) Fill out "Queue" with something like file:///home/user/koha/icarus_test 7i) Click "Save" 8a) Check that the Icarus dashboard has a "Status" of "Online" 8b) Click "Send to Icarus" next to your new saved task entry 8c) A task should now appear under "Active Icarus tasks"; click "Start" 8d) Go back to your terminal to check the Icarus server output (or 'tail -f' the log if you daemonized) 8e) You should notice activity; you can also check /home/user/koha/icarus_test to see if records are being downloaded and stored there _USER IMPORT TASK_ 9a) Go back to Koha administration > Saved tasks (http://KOHA/cgi-bin/koha/admin/saved_tasks.pl) 9b) Click "New saved task" 9c) Choose Koha::Icarus::Task::Dequeue::OAIPMH::Biblio, and click "Next" 9d) Repeat the same steps for "Start time" and "Repeat interval" as these are common to all tasks 9e) "Queue" should be the same as before, so try your path of file:///home/user/koha/icarus_test 9f) Provide a username and password for the API authentication; you should be able to use the default URL 9g) You should be able to trust the "Import target parameters" URL 9h) Write "OAI" for "Record matching rule code", if you added it earlier in the configuration steps 9i) Leave the "Action..." defaults... 9j) Change "Filter" to "file:///home/user/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/OAI2MARC21slim.xsl" 9k) Follow the same steps as above for sending the task to Icarus and telling Icarus to start it 9l) You can either watch Icarus's server output, or look at http://KOHA/cgi-bin/koha/tools/manage-marc-import.pl, or look directly at your database's "import_oai" and "biblio" tables to see how records are imported to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:33:20 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:33:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:33:23 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49716|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 49833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49833&action=edit Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:47:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:47:16 +0000 Subject: [Koha-bugs] [Bug 16193] New: Typo in Automatic item modifications by age Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Bug ID: 16193 Summary: Typo in Automatic item modifications by age Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:49:49 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 --- Comment #1 from Aleisha Amohia --- Created attachment 49834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49834&action=edit Bug 16193: Typo in Automatic item modifications by age To test: 1) Go to Tools -> Automatic item modifications by age 2) Click Edit 3) Add a rule if you have none, otherwise notice button 'Submit theses rules' and typo (theses) 4) Apply patch, refresh page 5) Confirm button now says 'Submit these rules' (typo is fixed) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:49:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:49:46 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 02:49:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 00:49:58 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 03:39:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 01:39:31 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #73 from Nicholas van Oudtshoorn --- Thanks Martin, Mark and Brendan! It feels great to have this done! ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 06:14:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 04:14:20 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using some languages (eg: korean) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #6 from Mason James --- (In reply to Jonathan Druart from comment #5) > It's a translation issue: > > 130 #. %1$s: END. > 131 #. %2$s: data.cardnumber | html. > 132 #: intranet-tmpl/prog/en/modules/members/tables/members_results.tt:12 > 133 #, c-format > 134 msgid "\", %s \"dt_cardnumber\": \"%s\", \"dt_name\": \"" > 135 msgstr "\", %s \"dt_????\": \"%s\", \"dt_??\": \"" > > > dt_cardnumber and dt_name should not have been translated. aah yes, of course! folks, what's the best way for me to correct this typo? i can't seem to correct this typo via 'pootle', is it possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 06:15:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 04:15:14 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron search fails when |Patron search fails when |using some languages (eg: |using Korean |korean) |(pootle/translate error) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:15:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 06:15:50 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- As the error is in the po file, it can be corrected via Pootle - but you might not be able to submit your change directly, depending on permissions. Maybe bring it to the koha-translate mailing list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 06:45:41 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49554|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 49835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49835&action=edit Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 06:45:47 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49780|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 49836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49836&action=edit Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm As requested by QA, the sub should be moved. Test plan: See previous patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 08:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 06:46:38 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #18 from Marcel de Rooy --- Rebased third patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:13:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:13:02 +0000 Subject: [Koha-bugs] [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041 --- Comment #5 from Jonathan Druart --- (In reply to Liz Rea from comment #4) > SUGGEST_FORMAT authorised values in the sample data come with image urls by > default, do we care about this? What do you mean? The pref will be disabled if none of the authorised_values.imageurl is set. Moreover I don't find where SUGGEST_FORMAT would be inserted with an image url -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:17:11 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #9 from Jonathan Druart --- Created attachment 49837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49837&action=edit Bug 16111: POC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:18:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:18:41 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #10 from Jonathan Druart --- (In reply to Owen Leonard from comment #8) > (In reply to Jonathan Druart from comment #7) > > Would not it better to fix the atom feeds instead of removing it? > > Making the atom feed work would really be a new feature, since as far as I > can tell they were never actually implemented. Not sure about that, looking at this POC, it seems that it has been broken by the move to Template::Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:28:00 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |translate.koha-community.or | |g Version|3.20 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:40:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:40:24 +0000 Subject: [Koha-bugs] [Bug 16167] Authorised value images may be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 --- Comment #3 from Jonathan Druart --- Created attachment 49838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49838&action=edit Bug 16167: Atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:45:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:45:31 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > I am sorry, but this doesn't appear to work for me. > > My test: > - A patron from Midway, has 1 checkout, 1 day overdue > - No holidays in the calendar > - Patron has neither SMS nor email > - Overdue notice trigger for Midway is set to delay 1 What MTT is/are checked? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 09:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 07:46:45 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #6 from Katrin Fischer --- Only e-mail was checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:05:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:05:12 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #7 from Jonathan Druart --- It seems that the test plan is wrong. The print notice is generated even without this patch. The issue is that the email generated for the library is not generated. This email starts with "These messages were not sent directly to the patrons" and should be generated if an email/sms has not been sent to a patron (but a print should have been built instead). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:07:53 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #8 from Katrin Fischer --- With and without the patch and without e-mail my message_queue remained empty - I can try to retest, but a bit out of ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:15:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:15:01 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > With and without the patch and without e-mail my message_queue remained > empty - I can try to retest, but a bit out of ideas. Define a print template for the letter you use :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:35:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:35:04 +0000 Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 --- Comment #25 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #23) > Shell test script from comment #5 does not quite work for me for some reasons > > > % for i in {1..10}; do {time perl test.t > /dev/null} 2>> /tmp/time;done; > > echo $((`perl -pe 's/.*cpu ([^s]*) total/$1/' /tmp/time| tr '\n' '+'|sed > 's/+$//'`) It's zsh. > Note that I'm measuring so-called "real" (wall clock) timings in here; I > have no idea what exactly is being measured in comment #5 - hopefully > someting similar? I have used the total CPU time (if the output looks like '1.95s user 0.05s system 68% cpu 2.920 total', I got 2.920). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:47:29 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #10 from Katrin Fischer --- I can do that, to get this bug moving, but it should not be mandatory. I just checked some of our 3.18.x installations and the notice to the library is generated without an existing print template. It seems to me like the fallback is broken/the behaviour was changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 10:47:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 08:47:37 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:25:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:25:01 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:25:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:25:04 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48399|0 |1 is obsolete| | Attachment #49806|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 49839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49839&action=edit Bug 15008 - Add custom HTML areas to circulation and reports home pages To test: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add some html to the two new prefs IntranetReportsHomeHTML and IntranetCirculationHomeHTML 4 - View the reports and circulation homepages and confirm your changes show Sponsored by Northeast Kansas Library System, NEKLS (http://nekls.org/) Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:25:08 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 --- Comment #12 from Jonathan Druart --- Created attachment 49840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49840&action=edit Bug 15008 - (QA followup) Add sysprefs.sql changes for new installations Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:25:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:25:13 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 --- Comment #13 from Jonathan Druart --- Created attachment 49841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49841&action=edit Bug 15008: Fix swap options-explanation values Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:57:39 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 11:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 09:57:44 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47882|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 49842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49842&action=edit Bug 14633 - Patch to control.ini to add or dependency to libapache2-mpm-itk The other attachment was not a patch which could be applied by 'git bz'. This corrects that. Signed-off-by: Chris Cormack debian/update-control will need to be run after this is applied, but it works well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:10:15 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #16 from Katrin Fischer --- Note: Jonathan pointed out that this changed behaviour, but I am worried the true consequence got lost. It looks like if you currently have no overdue print template defined, now there will be NO NOTICE generated to the library at all if the user has no email address, while before this worked using the email template. I'd suggest having a fallback again... if there is a print template, use it. If not, use the email one. Otherwise this behaviour change could create long unnoticed problems for libraries not receiving the emails as they are used to. The other idea would be automatically populating the print notice templates - but it seems more complicated. Should we do this only for overdue notices (looking at the triggers?) or for other notices as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:10:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:10:47 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45842|0 |1 is obsolete| | --- Comment #14 from Benjamin Rokseth --- Created attachment 49843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49843&action=edit Bug 13903: Add API routes to list, create, update, delete reserves GET /reserves?borrowernumber=X (list) POST /reserves (create) PUT /reserves/{reserve_id} (update) DELETE /reserves/{reserve_id} (delete) Unit tests in t/db_dependent/api/v1/reserves.t Test plan: 1. Apply patch 2. Run unit tests 3. Play with the API with your favorite REST client, using documentation in the swagger.json file 4. Try to make reserves until the maximum number of reserves for a user is reached (you should have a 403 error) Depends on bug 15126 Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:36:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:36:05 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no Status|Needs Signoff |Signed Off --- Comment #15 from Benjamin Rokseth --- Rebased again on top of #15126, since #15126 had to be rebased on top of changes pushed to master. Tests updated and passing. API routes working as notified. Two small comments: - edit reserve requires both priority AND branchcode to update holding branch. This is probably some issue in C4::Reserves::ModReserve rather. - it would be nice to be able to reserve from barcode as alternative, but I see this needs support in modules first Setting to signed off as it works according to plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:39:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:39:34 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #11 from Jonathan Druart --- Created attachment 49844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49844&action=edit Bug 15967: Use the email template if the print template does not exist >From commit 581759e985c170db0edb4a895cda641930e5ac11 Bug 14133: Print notices should be generated with the print template """ IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? """ Yes, it is what we want. But if the print template does not exist, the notice is not generated, we'd like to get the email template instead. Test plan: - Remove the print template for the letter you use for overdues - Define an overdue rule to send an email - Remove the email address for the patron which has overdues - Execute the overdue_notices script The staff should get an email notice and a print notice (using the email template) should be generated for the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:39:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:39:56 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:41:34 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #3 from Jonathan Druart --- Blocked by bug 14757. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:43:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:43:24 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to M. Tompsett from comment #1) > 3) prove t/Ris.t > -- just one confusing noise. Why did not you remove it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:46:32 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49781|0 |1 is obsolete| | --- Comment #23 from Benjamin Rokseth --- Created attachment 49845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49845&action=edit Bug 15126: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:46:38 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49782|0 |1 is obsolete| | --- Comment #24 from Benjamin Rokseth --- Created attachment 49846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49846&action=edit Bug 15126: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:46:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:46:44 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49783|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth --- Created attachment 49847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49847&action=edit Bug 15126: Update dependencies Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 12:49:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 10:49:06 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:00:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:00:00 +0000 Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #6 from Jonathan Druart --- (In reply to Humberto Blanco from comment #5) > Tom?s, > I have similar problem with mysql enterprise end i need to modify the > database structure.so: > > ALTER TABLE aqorders ALTER COLUMN budgetgroup_id SET DEFAULT 0; This column does not seem to be used and could be removed. In the meanwhile it would be better to set it to NULL (and remove the NOT NULL constraint) instead of set it to 0 (which does not make sense). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:00:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:00:38 +0000 Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16094 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:00:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:00:38 +0000 Subject: [Koha-bugs] [Bug 16094] error editing (borrowers, reports) with mysql enterprise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13669 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:10:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:10:57 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #26 from Olli-Antti Kivilahti --- (In reply to Julian Maurice from comment #17) > I just tested minifySwagger.pl and something bothers me : it resolves all > "$ref", meaning the "minified" file will be larger than the sum of all files > it comes from if the same "$ref" is used at least twice. > > Is it possible resolve only "$ref" that point to different files ? So we > keep the idea of a (small) single minified file and let the client resolve > the other refs. There are some issue with this approach. Firstly, if you want to have reusable reference contents, they probably must reside under the "Definitions Object", and the "Definitions Object" only accepts Schemas/Objects, so we cannot define reusable primitive data types, such as biblionumber. { type => 'String', description => 'descr' } Atleast I didn't figure out how to do it. Maybe you could add an extra level of nesting under the "Definitions Object" "x-primitive-definitions": { "biblionumber": { type => 'Integer', description => 'descr' } } but that might break any automatic Swagger2-tools. Also the way references are dereferenced is part of the core Mojolicious::Plugin::Swagger2-functionality and I am not so sure how the original author will like that change. I guess it would be nice to have and even doable, but it might be a really difficult algorithm to implement, which makes a complex system even more complex. The reason I implemented this approach is that external Swagger2-tools (like Swagger2 UI) doesn't resolve those references well, or was it that they dont reference at all (at the point of writing). I am not concerned about any repetition in the Swagger2-definition in Koha, tho you never know how it might affect us in the future. Anyway. I am currently working on implementing CORS-support for the Swagger2-API, because we need it now. This certainly is a challenge :) Also. We moved the /definitions/index.json to /definitions.json When you reference a definition, you had to write the reference like this: "$ref": "/definitions/index.json#/borrowernumber" now you can write the reference more easy: "$ref": "/definitions.json#/borrowernumber" Anyway you can find our newest Swagger2-definition from here: https://github.com/KohaSuomi/kohasuomi/tree/kohasuomi3.16/api/v1/swagger https://renki.vaarakirjastot.fi/api/v1/doc/ It took us quite some time to refactor to that model + a lot of testing :) But we are more interested in following the community model. However our API is a product of months of work and continuous self-improvement so I can say with confidence that we are taking the right route. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:11:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:11:17 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. > > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I agree with Jesse, you are adding a new way to do something where we already have one. For instance, on Koha::Virtualshelf, there are several can_* methods taking a borrowernumber in parameter. It seems that it's exactly what you are achieving here. It would be better to stick on the current form or to suggest and move everything to another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:12:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:12:13 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #20 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > (In reply to Marcel de Rooy from comment #13) > > So I am not convinced that we should move it. But if you really insist, I'd > > rather move it to Upload.pm or so? > > No reply is also an answer. > Jesse: I moved it. Please finish QA now. ok seen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:16:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:16:24 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #27 from Olli-Antti Kivilahti --- (In reply to Benjamin Rokseth from comment #24) > Created attachment 49846 [details] [review] > Bug 15126: x-mojo-controller deprecation > > Remove the use of soon to be deprecated x-mojo-controller from our > specification and replace with the recommended operationId format. > > Signed-off-by: Benjamin Rokseth Also be advised that the new model of inferring the correct controller-subroutine -pair from the operationId is not without it's problems. Tho if you are willing to accept some clunkiness with the operationId, you can get by without the x-mojo-controller. One issue I found out is that the operationId "getStory" doesn't translate to Stories::Get, but it translates to something like Storys::Get, which might be rather confusing. This is not a stopper tho Just saying, be careful. use a lot of export SWAGGER2_DEBUG=1 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:36:44 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #21 from Jonathan Druart --- Why does upload_manage is not set by default? Before this patch I was able to delete uploads, now I need the permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:45:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:45:15 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > Why does upload_manage is not set by default? > Before this patch I was able to delete uploads, now I need the permission. You should be able to delete your own uploads, not the other ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:45:17 +0000 Subject: [Koha-bugs] [Bug 15928] Show unlinked guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:45:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:45:21 +0000 Subject: [Koha-bugs] [Bug 15928] Show unlinked guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49599|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 49848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49848&action=edit Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account by typing it in but do not 'Set to patron' 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Amended-patch: Correct some indents/spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:46:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:46:17 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 13:46:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 11:46:21 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49621|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 49849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49849&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion EDIT: Making sure the messages and the buttons show the same text, as per Comment 6. To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:21:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:21:29 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > Just some first notes on this: > > 1) New "add order line fields" page > > a) Test plan calls for adding fields with AV category and MARC field, but > this always results in this error message for me: > You cannot select an authorised value category and a marcfield Yes, the test plan is wrong: you cannot define both. > b) why have the datatable search field below the table instead of above? I > know we have other places where it's like this, but it always irritates me - > the search is most useful for a big table and this will require you to > scroll all the way to the end of the table first. It's the same behaviour as for serials, so I'd say it's expected. > d) it would be nice, if the table could use the new buttons we for Edit and > Delete as introduced for a lot of other tables recently to match the new > design pattern. Could be done by bug 15774 which create a new page to configure all of these additional fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:24:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:24:51 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > (In reply to Jonathan Druart from comment #21) > > Why does upload_manage is not set by default? > > Before this patch I was able to delete uploads, now I need the permission. > > You should be able to delete your own uploads, not the other ones. Yes but it's a change in the behavior, would not it better to set it for existing installs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:26:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:26:30 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #21 from Katrin Fischer --- >> b) why have the datatable search field below the table instead of above? I >> know we have other places where it's like this, but it always irritates me - >> the search is most useful for a big table and this will require you to >> scroll all the way to the end of the table first. >It's the same behaviour as for serials, so I'd say it's expected. Still doesn't make sense :) But not a blocker. I think Jesse wanted to take a look at this - so I didn't test further. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:28:29 +0000 Subject: [Koha-bugs] [Bug 16159] guarantor section missing ID on patron add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15928 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you please detail what is the bug? Is it related to bug 15928? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:28:29 +0000 Subject: [Koha-bugs] [Bug 15928] Show unlinked guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16159 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 14:29:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 12:29:11 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #24 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #23) > Yes but it's a change in the behavior, would not it better to set it for > existing installs? We add upload_general for active existing installs. I would rather not add the manage permission because it is meant to 'protect' against such deletes. Note that someone with all tools or superlibrarians can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:00:26 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #157 from Tom?s Cohen Arazi --- Created attachment 49850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49850&action=edit Bug 7736: (QA followup) Add missing body id and class Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:00:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:00:46 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:00:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:00:48 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:00:56 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:01:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:01:06 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:01:34 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #158 from Tom?s Cohen Arazi --- Brendan, please push the last followup so xt/tt_valid.t gets fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:09:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:09:58 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |John.Seymour at nal.gov.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:22:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:22:31 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:22:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:22:35 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49552|0 |1 is obsolete| | Attachment #49553|0 |1 is obsolete| | Attachment #49835|0 |1 is obsolete| | Attachment #49836|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 49851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49851&action=edit Bug 14686: Add allows_add_by to check permissions for uploading The three permissions in tools/upload-file.pl are moved to a custom routine in DBIx's UploadedFile.pm. An additional granular permission upload_general_files is added. (The dbrev patch will contain it too.) At some point in time this could be moved to a Koha::Object class. The routine is tested in Upload.t. Test plan: [1] Run t/db_dependent/Upload.t [2] If you only apply this patch, you can also test uploading with a user that has edit_catalogue but does not have tools or circulate. Upload status should say: Denied. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:22:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:22:39 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #26 from Jonathan Druart --- Created attachment 49852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49852&action=edit Bug 14686: Add two granular permission for upload under tools [1] Upload_general_files This will allow you to access the tools/upload form via the Tools menu. And it will also allow you to add permanent uploads. [2] Upload_manage It will allow you to delete uploads from other users. Note that anyone may delete his own uploads. It is not meant to include upload_general_files. In order to not disturb existing users that now have edit_catalogue and are using the plugin (read: added at least one record to uploaded_files), we will add the first permission for them. New users will need to be authorized in the usual way thereafter. Note: If you only have one of the other permissions checked in allows_add_by, e.g. stage_marc_import, you can add temporary uploads, but not permanent uploads. Test plan: We are only testing the dbrev here, not if the perm works as advertised. [1] Run the dbrev and check that you see the perms with a description on the Patron/Set permissions page. [2] If you had records in uploaded_files and a user with edit_catalogue *only*, verify that this user now also has upload_general_files. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:22:44 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #27 from Jonathan Druart --- Created attachment 49853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49853&action=edit Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:22:49 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #28 from Jonathan Druart --- Created attachment 49854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49854&action=edit Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm As requested by QA, the sub should be moved. Test plan: See previous patches. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:23:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:23:02 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #29 from Jonathan Druart --- Created attachment 49855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49855&action=edit Bug 14686: Remove unused use Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:23:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:23:09 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:23:12 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49842|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 49856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49856&action=edit Bug 14633: Patch to control.ini to add or dependency to libapache2-mpm-itk The other attachment was not a patch which could be applied by 'git bz'. This corrects that. Signed-off-by: Chris Cormack debian/update-control will need to be run after this is applied, but it works well Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:25:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:25:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #39 from Jonathan Druart --- (In reply to Alex Arnaud from comment #37) > Hello Jonathan, > > Why should we add tests for the age restriction ? Code about checking age > restriction has not chenged and sub C4::Circulation::GetAgeRestriction() is > already tested int/Circulation/AgeRestrictionMarkers.t. The changes about the age restriction in CanBookBeReserved is not covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:27:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:27:17 +0000 Subject: [Koha-bugs] [Bug 16180] Receiving items with duplicate barcodes from import (addorderiso2709.pl) causes internal error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- It looks like tricky to fix. Do you have an idea on how to fix it correctly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:29:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:29:29 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #29) > Created attachment 49855 [details] [review] > Bug 14686: Remove unused use > > Signed-off-by: Jonathan Druart Thx for QAing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:30:34 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Are you talking about opac-tags.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:32:04 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #17 from Nick Clemens --- (In reply to Katrin Fischer from comment #16) > I'd suggest having a fallback again... if there is a print template, use it. > If not, use the email one. Maybe we could fallback to just sending the library a notice saying "No email for patron XXX - define print notice if you would like to receive printable notices instead of this message"? Or something along those lines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:33:03 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 --- Comment #2 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > Are you talking about opac-tags.pl? Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:34:17 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #18 from Katrin Fischer --- I think your idea is a good third option. Jonathan has proposed a new patch on bug 15967 with the fallback solution. Maybe we should move discussion there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:35:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:35:16 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Owen, I get the error when JS is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:47:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:47:03 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 [Bug 11213] GetItemsInfo() called twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:47:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:47:03 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:47:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:47:48 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #3 from Alex Sassmannshausen --- Created attachment 49857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49857&action=edit Revised Issue Object Patch This is a revised patch fixing minor typos that had lethal consequences to the Issues objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:48:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:48:02 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:48:10 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:48:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:48:13 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 --- Comment #3 from Jonathan Druart --- Created attachment 49858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49858&action=edit Bug 16179: Do not crash if "rate me" is clicked and not rate selected If JS is disabled and a user clicks on the "Rate me" button, Koha will crashes with: DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null at /usr/share/koha/lib/C4/Ratings.pm line 208 To avoid that, opac-ratings.pl will check if a rate has been selected. Test plan: Disable JS On a record detail page, click on the "Rate me" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:50:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:50:12 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master Severity|minor |normal Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:51:19 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49262|0 |1 is obsolete| | --- Comment #3 from Alex Sassmannshausen --- Created attachment 49859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49859&action=edit Revised Old Issue Patch Revised patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:51:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:51:58 +0000 Subject: [Koha-bugs] [Bug 16194] New: Do not consider xslt as valid theme dir in LangInstaller.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Bug ID: 16194 Summary: Do not consider xslt as valid theme dir in LangInstaller.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Bug 15527 adds a new dir 'xslt' in opac-tmpl, and it's considered as a theme dir. perl translate update es-ES /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information. /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information. /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information. /home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory. (Symbolic links are not supported at the moment) Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:52:03 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 15:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 13:52:25 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:00:19 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 49860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49860&action=edit Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir. To test: 1) Verify the problem on current master Update translation for any lang, will see errors 2) Apply the patch 3) Update again, no errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:01:16 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15527 Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:01:16 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16194 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:05:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:05:04 +0000 Subject: [Koha-bugs] [Bug 16195] New: Add Koha::Categories objects Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 Bug ID: 16195 Summary: Add Koha::Categories objects Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: alex.sassmannshausen at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This bug adds the prospect of Koha::Category and Koha::Categories objects.a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:05:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:05:50 +0000 Subject: [Koha-bugs] [Bug 16195] Add Koha::Categories objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.sassmannshausen at ptfs-e | |urope.com Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:06:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:06:40 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 --- Comment #3 from Jonathan Druart --- So you are talking about the table, not the tag cloud, that's it? With 2000 tags the page is generated in 10sec on my laptop, not so bad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:07:27 +0000 Subject: [Koha-bugs] [Bug 16195] Add Koha::Categories objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 --- Comment #1 from Alex Sassmannshausen --- Created attachment 49861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49861&action=edit Koha::Categories objects patch Add the objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:14:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:14:56 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:20:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:20:00 +0000 Subject: [Koha-bugs] [Bug 13718] Paying fines references non-existent function on submit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Jonathan Druart --- *** Bug 16135 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:20:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:20:00 +0000 Subject: [Koha-bugs] [Bug 16135] JavaScript error when paying a fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13718 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:20:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:20:27 +0000 Subject: [Koha-bugs] [Bug 13718] Paying fines references non-existent function on submit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.18 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:30:47 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:30:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:30:50 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49860|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 49862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49862&action=edit Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir. To test: 1) Verify the problem on current master Update translation for any lang, will see errors 2) Apply the patch 3) Update again, no errors Signed-off-by: Tomas Cohen Arazi Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:34:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:34:11 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 --- Comment #4 from M. Tompsett --- (In reply to Jonathan Druart from comment #3) > (In reply to M. Tompsett from comment #1) > > 3) prove t/Ris.t > > -- just one confusing noise. > > Why did not you remove it? Because I did not feel comfortable deciding that particular fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 16:51:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 14:51:03 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- Just adding this from the other bug , I think fallback to email is a fine option but wanted to mention this in case it seems worthwhile: Maybe we could fallback to just sending the library a notice saying "No email for patron XXX - define print notice if you would like to receive printable notices instead of this message"? Or something along those lines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:16:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:16:20 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 --- Comment #10 from Jonathan Druart --- Nicholas, could you confirm it is fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:17:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:17:15 +0000 Subject: [Koha-bugs] [Bug 13780] A patron without cardnumer will break searching for category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Closing, please reopen if it's not fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:25:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:25:21 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:25:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:25:23 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49844|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 49863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49863&action=edit Bug 15967: Use the email template if the print template does not exist >From commit 581759e985c170db0edb4a895cda641930e5ac11 Bug 14133: Print notices should be generated with the print template """ IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? """ Yes, it is what we want. But if the print template does not exist, the notice is not generated, we'd like to get the email template instead. Test plan: - Remove the print template for the letter you use for overdues - Define an overdue rule to send an email - Remove the email address for the patron which has overdues - Execute the overdue_notices script The staff should get an email notice and a print notice (using the email template) should be generated for the patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:29:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:29:22 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:29:24 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49602|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 49864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49864&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is set to "Don't allow" 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SCO log in page with AutoSelfCheck disabled 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Followed test plan. If I go to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl, CSS and JS trigger already on the login form, I suppose that is intended. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:29:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:29:29 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49745|0 |1 is obsolete| | --- Comment #28 from Nick Clemens --- Created attachment 49865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49865&action=edit Bug 12663: (QA followup) Insert SCOUserCSS/JS 'after' OPACUserCSS/JS rather than 'instead of' i.e. Remove IF/ELSE and use 2 IF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:46:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:46:54 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #13 from Owen Leonard --- Overall this looks great. I am curious why you created a new include file for the add message form but put the modal markup in members-toolbar.inc. Why not just put all the markup in members-toolbar.inc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:58:14 +0000 Subject: [Koha-bugs] [Bug 16195] Add Koha::Categories objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 17:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 15:58:20 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- John, try and restart memcached. It should fix your issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:03:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:03:20 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:05:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:05:13 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49834|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 49866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49866&action=edit [SIGNED-OFF] Bug 16193: Typo in Automatic item modifications by age To test: 1) Go to Tools -> Automatic item modifications by age 2) Click Edit 3) Add a rule if you have none, otherwise notice button 'Submit theses rules' and typo (theses) 4) Apply patch, refresh page 5) Confirm button now says 'Submit these rules' (typo is fixed) Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:05:10 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:15:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:15:49 +0000 Subject: [Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:15:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:15:51 +0000 Subject: [Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49749|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 49867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49867&action=edit [SIGNED-OFF] Bug 16183: Confirm message upon deleting patron messages To test: 1) Go to a patron circulation page and add a message 2) Click '[Delete]' 3) Confirm that a confirm dialog shows up and 'Cancel' and 'OK' do what is expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 18:46:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 16:46:35 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #159 from Brendan Gallagher --- (In reply to Tom?s Cohen Arazi from comment #158) > Brendan, please push the last followup so xt/tt_valid.t gets fixed. Cool I'm on it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 17:30:12 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 49868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49868&action=edit Bug 16144: Remove 'dt_*' from translation strings when possible This patch removes strings form translation files that have 'dt_*' variables besides puntuation, html constructs, etc. To test: 1) Update strings for any language 2) Check for strings with 'dt_*', eg. for es-ES msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_" 3) Apply the patch & update again 4) Compare similar strings, there are now a few less strings This does not remove all occurrences, there's no easy way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:34:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 17:34:49 +0000 Subject: [Koha-bugs] [Bug 16182] Make phone number clickable to call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Should the SMS number link use ' References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49868|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 49869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49869&action=edit Bug 16144: Remove 'dt_*' from translation strings when possible This patch removes strings form translation files that have 'dt_*' variables besides puntuation, html constructs, etc. To test: 1) Update strings for any language 2) Check for strings with 'dt_*', eg. for es-ES msgcat --no-wrap po/es-ES-staff-prog.po | egrep ^msgid | egrep "dt_" 3) Apply the patch & update again 4) Compare similar strings, there are now a few less strings This does not remove all occurrences, there's no easy way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:40:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 17:40:56 +0000 Subject: [Koha-bugs] [Bug 16144] Patron search fails when using Korean (pootle/translate error) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16144 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | --- Comment #10 from Bernardo Gonzalez Kriegel --- My patch remove some of the problematic strings, but not all. To fix this you need to edit translation file in pootle, I can help to identify those strings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 19:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 17:57:20 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #3 from Owen Leonard --- I wish we had a better icon for the "clean" button. One of the problems with using Font Awesome is that we're kinda stuck if we don't have just the right thing. I'm not sure what the rules are... Do the changes to C4/ImportBatch.pm require a test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:02:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:02:25 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Bernardo Gonzalez Kriegel --- Sorry, does not apply CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:11:57 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:12:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:12:00 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49682|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 49870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49870&action=edit [SIGNED-OFF] Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:29:30 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #5 from Agnes Rivers-Moore --- Hi Jonathan John Yorio submitted this one on our behalf - we found it when fist upgraded to 3.20.02.000. Might have been fixed along the way since then. I can confirm it still happens in our live system. I hope this will clarify the symptoms: It is a mismatch between the show/hide column names in Administration and those that appear in circulation. Koha admin - Columns settings - Circulation Set Charge and Price to Hidden by default Expected result: For checkout display not to show Charge or Price. This is what ACTUALLY happened: Checkout still shows Price. Fine disappears! Drop-drown to show/hide that is in the checkout screen - does not list hide Price at all. Seems the programmers mixed up the Price and Fine fields. In the Admin module - hiding Price actually hides Fine, and Fine is not listed in the Columns Settings table at all. In the checkout screen drop-down - the fields seem to be correctly named, and hide Price is simply not an option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:31:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:31:13 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #6 from Agnes Rivers-Moore --- Created attachment 49871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49871&action=edit Admin show/hide settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:32:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:32:41 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #7 from Agnes Rivers-Moore --- Created attachment 49872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49872&action=edit Show/hide setting in Checkout Compare with my other attachment & Note the different columns listed, and the result in the checkout display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:34:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:34:46 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #32 from Owen Leonard --- Created attachment 49873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49873&action=edit [SIGNED-OFF] Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:34:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:34:58 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48295|0 |1 is obsolete| | --- Comment #33 from Owen Leonard --- Created attachment 49874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49874&action=edit [SIGNED-OFF] Bug 5979 - Follow up: Change ISBD syspref description and fix warning in t/Biblio/Isbd.t Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:35:15 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44211|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:35:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:35:24 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #8 from Agnes Rivers-Moore --- Oh - I should say that we would like to hide "Price" - the one column that we are not able to turn off! Thanks, Agnes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:35:26 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:38:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:38:50 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:39:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:39:34 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Based on comment 2 and comment 3 I think this should be 'Failed QA' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:40:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:40:41 +0000 Subject: [Koha-bugs] [Bug 16196] New: Acquisitions Module Not Showing Subtotals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16196 Bug ID: 16196 Summary: Acquisitions Module Not Showing Subtotals Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Partner reports that when receiving books in the Acquisitions module, subtotals are not identifying which fund they are for. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:50:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:50:26 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Owen Leonard --- I think based on this bug's history that it should be "Signed off" at this stage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 20:53:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 18:53:25 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:04:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:04:11 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #8 from Bernardo Gonzalez Kriegel --- Hi, new errors FAIL C4/ZebraIndex.pm OK critic OK forbidden patterns OK pod OK spelling 0 FAIL valid Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo Name "Tie::Hash::FIELDS" used only once: possible typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:13:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:13:29 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|oleonard at myacpl.org |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:18:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:18:02 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Bernardo Gonzalez Kriegel --- Applying: Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:25:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:25:38 +0000 Subject: [Koha-bugs] [Bug 16197] New: Searching for user in reserve/request.pl is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Bug ID: 16197 Summary: Searching for user in reserve/request.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. This used to work before 13894. Vile RecordSet broke it... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:28:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:28:07 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:28:25 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:28:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:28:41 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:28:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:28:41 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13894 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:39:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:39:32 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 --- Comment #1 from Blou --- Actually, problem seems with C4/Utils/DataTables/Members.pm 's search method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 21:49:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 19:49:07 +0000 Subject: [Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Failed QA --- Comment #7 from Bernardo Gonzalez Kriegel --- There is a small conflict Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt Failed to merge in the changes. Solving that we got: Software error: Template process failed: file error - searchbox-keep-text.inc: not found at /home/bgkriegel/kohaclone/C4/Templates.pm line 119 Where is 'searchbox-keep-text.inc'? BTW, have you an agreement on file names, i.e. jquery-ver vs. old/older? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:39:36 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I think you can continue - this should be fixed by another patch that passed QA recently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:43:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:43:53 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #160 from Brendan Gallagher --- Last patch Pushed to Master - Should be in the May 2016 release. Thanks and good eye! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:51:06 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:51:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:51:10 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48654|0 |1 is obsolete| | Attachment #49863|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 49875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49875&action=edit [PASSED QA] Bug 15967: Fix regression from bug 14133 - notify the library if patron is not Regression introduced by bug 14133, see but 14133 comment 13. Test plan: Without this patch applied, if a patron cannot be notified (no email address or sms number), the print notice generated for the library was not. With this patch applied, the print notice should be generated using the print template Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:51:38 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #15 from Katrin Fischer --- Thx a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:52:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:52:13 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #16 from Katrin Fischer --- Created attachment 49876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49876&action=edit [PASSED QA] Bug 15967: Use the email template if the print template does not exist >From commit 581759e985c170db0edb4a895cda641930e5ac11 Bug 14133: Print notices should be generated with the print template """ IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? """ Yes, it is what we want. But if the print template does not exist, the notice is not generated, we'd like to get the email template instead. Test plan: - Remove the print template for the letter you use for overdues - Define an overdue rule to send an email - Remove the email address for the patron which has overdues - Execute the overdue_notices script The staff should get an email notice and a print notice (using the email template) should be generated for the patron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:54:28 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 --- Comment #2 from Blou --- Created attachment 49877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49877&action=edit Bug 16197 - Specifying both last and firstname in reserve's patrong search yields nothing. The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Test scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. 4) Apply the patch, same test now return the one matching result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:55:05 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:55:08 +0000 Subject: [Koha-bugs] [Bug 16164] Making check expiration actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49831|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 49878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49878&action=edit [PASSED QA] Bug 16164: Making check expiration actions buttons EDIT: Using same font awesome icon for 'Renew' as in other places To test: 1) Go to Serials -> Check expiration 2) Put in a date where one or more subscriptions will expire prior to this date 3) Confirm that column heading is now 'Actions' 4) Confirm that Edit and Renew now show as font awesome buttons 5) Confirm that the buttons don't wrap on narrower browsers 6) Confirm the buttons still work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 22:55:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 20:55:17 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:10:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:10:20 +0000 Subject: [Koha-bugs] [Bug 16198] New: Opac suggestions are broken if user is not logged in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Bug ID: 16198 Summary: Opac suggestions are broken if user is not logged in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org /cgi-bin/koha/opac-suggestions.pl reached from the OPAC navigation will show a Perl error when the user is not logged into the OPAC: http://localhost/cgi-bin/koha/opac-suggestions.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:10:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:10:50 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 --- Comment #1 from Katrin Fischer --- Copy and paste mistake, the error is: Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:22:16 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:22:20 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49864|0 |1 is obsolete| | Attachment #49865|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer --- Created attachment 49879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49879&action=edit [PASSED QA] Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is set to "Don't allow" 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SCO log in page with AutoSelfCheck disabled 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Followed test plan. If I go to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl, CSS and JS trigger already on the login form, I suppose that is intended. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:23:13 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #30 from Katrin Fischer --- Created attachment 49880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49880&action=edit [PASSED QA] Bug 12663: (QA followup) Insert SCOUserCSS/JS 'after' OPACUserCSS/JS rather than 'instead of' i.e. Remove IF/ELSE and use 2 IF Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:28:54 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Yes, a new routine should be unit tested. - Aleisha, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:34:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:34:12 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 4 23:34:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 21:34:15 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49862|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49881&action=edit [PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir. To test: 1) Verify the problem on current master Update translation for any lang, will see errors 2) Apply the patch 3) Update again, no errors Signed-off-by: Tomas Cohen Arazi Works as expected. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 00:26:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 22:26:42 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #33 from Katrin Fischer --- Is the status here correct? Should it be failed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:02:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:02:03 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:02:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:02:05 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #3 from M. Tompsett --- Created attachment 49882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49882&action=edit Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t Revisiting this bug, I noticed that C4::Context->config() was mocked poorly. I expanded the mock function a little and have quieted the test which seemed to be working in a broken manner before. TEST PLAN --------- 1) prove t/db_dependend/Auth_with_ldap.t -- shibboleth noise 2) apply patch 3) prove t/db_dependend/Auth_with_ldap.t -- no noise 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:02:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:02:36 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49882|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 49883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49883&action=edit Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t Revisiting this bug, I noticed that C4::Context->config() was mocked poorly. I expanded the mock function a little and have quieted the test which seemed to be working in a broken manner before. TEST PLAN --------- 1) prove t/db_dependend/Auth_with_ldap.t -- shibboleth noise 2) apply patch 3) prove t/db_dependend/Auth_with_ldap.t -- no noise 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:02:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:02:42 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #5 from M. Tompsett --- Created attachment 49884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49884&action=edit Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t A little perlcritic cleanup and perltidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:15:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:15:45 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49883|0 |1 is obsolete| | Attachment #49884|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 49885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49885&action=edit Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t Revisiting this bug, I noticed that C4::Context->config() was mocked poorly. I expanded the mock function a little and have quieted the test which seemed to be working in a broken manner before. TEST PLAN --------- 1) prove t/db_dependend/Auth_with_ldap.t -- shibboleth noise 2) apply this patch 3) prove t/db_dependend/Auth_with_ldap.t -- no noise 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:15:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:15:52 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #7 from M. Tompsett --- Created attachment 49886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49886&action=edit Bug 14144: Clean ups and refactors perltidy old new calls to new call format attrType -> attr_type (perlcritic friendlier) double quotes to single quotes '' combinations to q{} (perlcritic friendlier) refactored parameters to mock_net_ldap_search into a HASH This piece is not necessary, but I think it is nicer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:47:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:47:22 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:47:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:47:25 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49877|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 49887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49887&action=edit Bug 16197 - Specifying both last and firstname in reserve's patrong search yields nothing. The user search in reserve/request.pl got broken by bug 13894. The search using the "recordset" doesn not care for "lastname, firstname" as before, instead finding nothing. Test scenario: EASY SETUP: database with two borrowers with same last name, and one record minimu. 1) go to KOHA_SITE/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) enter the last name. You should get two results in the table 3) same site, enter "lastname, firstname" (comma optional). You get no result. 4) Apply the patch, same test now return the one matching result. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:48:10 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:48:10 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:52:15 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15252 Status|Signed Off |In Discussion --- Comment #4 from Nick Clemens --- I signed off, but am marking to in discussion as I think this is the same issue as 15930. I like this approach, but it causes issues for the patch of 15252. I think the best solution proposed is to use "quotes" to force phrase searching for two part names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 01:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Apr 2016 23:52:15 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 02:13:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 00:13:41 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from M. Tompsett --- There are three patches here. I believe that the second one is the best solution. The third one is clean up and refactors and is not necessary. All three can be applied at once. The third requires the second one first. The first can be applied alone. Testing is merely a prove t/db_dependent/Auth_with_ldap.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 03:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 01:44:16 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35883|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 49888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49888&action=edit [SIGNED_OFF] Bug 13705: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex This should allow easier indexation from scripts other than rebuild_zebra.pl Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 03:44:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 01:44:24 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35884|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 49889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49889&action=edit [SIGNED_OFF] Bug 13705: Prevent a warning in _fix_unimarc_100 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 03:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 01:44:31 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40060|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 49890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49890&action=edit [SIGNED-OFF] Bug 13705 - Update copyright and GPL Licence statement in C4/ZebraIndex.pm Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 03:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 01:44:40 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40061|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 49891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49891&action=edit [SIGNED-OFF] Bug 13705 - Fix QA comments Signed-off-by: Bernardo Gonzalez Kriegel Tested using options -v -a -b -x -r -w -z --length --offset -nosanitize No problems found, same results as before. Output slightly different: Old) ==================== exporting authority ==================== 301.................................................................................................... Records exported: 389 ==================== REINDEXING zebra ==================== New) ==================== REINDEXING zebra ==================== ....................................................................................................100 ....................................................................................................200 ....................................................................................................300 ......................................................................................... 389 records exported to /tmp/PBlyusIn1Z/exported_records ==================== REINDEXING zebra =================== No errors save for those on comment #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 03:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 01:45:26 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 07:53:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 05:53:58 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Blou, please jump into the discussion on bug 15930. I'd like to provide a global fix for this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 07:56:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 05:56:36 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #34 from Jonathan Druart --- (In reply to Katrin Fischer from comment #33) > Is the status here correct? Should it be failed QA? More or less the same, we need a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:01:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:01:48 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:02:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:02:08 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Jonathan Druart --- I forgot to obsolete the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:21:48 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |DUPLICATE --- Comment #9 from Jonathan Druart --- Indeed, bug confirmed on 3.20. See bug 14841 for a fix, I will ask the 3.20 release maintainer to backport it *** This bug has been marked as a duplicate of bug 14841 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:21:48 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jyorio at esilibrary.com --- Comment #11 from Jonathan Druart --- *** Bug 14657 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:22:59 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Bugs 9481 and 13492 are in 3.20.x, this should be backported. That bug still exists on 3.20.x (see bug 14657). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:41:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:41:35 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:41:38 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #8 from Jonathan Druart --- Created attachment 49892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49892&action=edit Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:41:42 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #9 from Jonathan Druart --- Created attachment 49893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49893&action=edit Bug 15832: Remove empty string from the filters On each cell, the split will generate a new empty entry. This patch removes that entry. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:49:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:49:41 +0000 Subject: [Koha-bugs] [Bug 16199] New: C4::Ris::charconv is one of the less useful subroutines ever written Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 Bug ID: 16199 Summary: C4::Ris::charconv is one of the less useful subroutines ever written Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org I let you admire it: sub charconv { if ($utf) { ## return unaltered if already utf-8 return @_; } elsif (my $uniout eq "t") { ## convert to utf-8 return marc8_to_utf8("@_"); } else { ## return unaltered if no utf-8 requested return @_; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:52:32 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:52:35 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49815|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 49894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49894&action=edit Bug 16191: t/Ris.t is noisy TEST PLAN --------- 1) prove t/Ris.t -- very noisy 2) apply patch 3) prove t/Ris.t -- just one confusing noise. 4) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:53:07 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16191 Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 [Bug 16191] t/Ris.t is noisy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:53:07 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:55:19 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:55:22 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 --- Comment #1 from Jonathan Druart --- Created attachment 49895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49895&action=edit Bug 16199: Remove C4::Ris::charconv This subroutine always returns what has been sent in parameter. It is unecessary and can be removed. Test plan: prove t/Ris.t should not be noisy Export a catalogue record in Ris should generate the same file with and without this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 08:56:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 06:56:03 +0000 Subject: [Koha-bugs] [Bug 16191] t/Ris.t is noisy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16191 --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #4) > (In reply to Jonathan Druart from comment #3) > > (In reply to M. Tompsett from comment #1) > > > 3) prove t/Ris.t > > > -- just one confusing noise. > > > > Why did not you remove it? > > Because I did not feel comfortable deciding that particular fix. See bug 16199. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:28:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:28:09 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #13 from Fr?d?ric Demians --- Pushed to 3.20.x. Will be in 3.20.11. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:40:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:40:47 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:40:49 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 --- Comment #2 from Jonathan Druart --- Created attachment 49896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49896&action=edit Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:41:59 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16198 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 [Bug 16198] Opac suggestions are broken if user is not logged in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:41:59 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15629 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:43:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:43:46 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 09:59:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 07:59:14 +0000 Subject: [Koha-bugs] [Bug 4158] cannot create list whose title is '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:08:20 +0000 Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #32 from Katrin Fischer --- Hi, wondering if I am missing something - but is it possible to add the longoverdues.pl to the cron files (normal and packages) and have it inactive until a library chooses to set the system preferences? It seems that the lost value is mandatory, so I have an error, when I try running the script without it being set (syspref empty, no param): ERROR: No --lost (-l) option defined at ./misc/cronjobs/longoverdue.pl line 119. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:11:56 +0000 Subject: [Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:16:02 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:16:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:16:05 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 --- Comment #1 from Jonathan Druart --- Created attachment 49897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49897&action=edit Bug 16055: Do not allow basketgroup deletion unless empty If a basketgroup has basket attached, it should not be deletable. This patch just removes the Delete button from the interface if it cannot be deleted. When editing a basketgroup, the "Delete basket group" button is no longer displayed. Test plan: 1/ Create a basketgroup 2/ Attach 1+ baskets to this basketgroup 3/ Confirm you are not able to delete it 4/ Remove the baskets from this basketgroup 5/ Confirm you are able to delete it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:16:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:16:12 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #16 from Hugo Agud --- I have been able to reproduce the error on koha 3.16.7 (I have not checked in more updated version of koha) We have verified that If you edit a serial that has already been received, koha delete the existing barcode. The test plan we suggest. 1. Create one subscription with any serial pattern and create item when receiving an issue. 2. Receive one or two serial, fill the values of the items, in our test we have filled enumchron (automatically loaded from patter), signature (automatically loaded from subscription information) and barcode (manual). 3. Check that the item has been propertly added to biblionumber 4. Go to subscription--> serial collection --> Edit Serail --> select one of the received --> modify field 'Publish on' 5. Now the barcode has been deleted Hope it helps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:17:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:17:21 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Owen Leonard from comment #0) > Keep in mind the work being done in Bug 16038 and Bug 11708 when considering > this one. One is blocked and the other one does not apply. Moreover this is a bug fix and it could be great to backport it. I think this patch should be pushed before the 2 others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:32:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:32:36 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:55:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:55:51 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:55:55 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44208|0 |1 is obsolete| | Attachment #44209|0 |1 is obsolete| | Attachment #44210|0 |1 is obsolete| | Attachment #49873|0 |1 is obsolete| | Attachment #49874|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 49898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49898&action=edit Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:56:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:56:00 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #35 from Jonathan Druart --- Created attachment 49899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49899&action=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:56:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:56:04 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #36 from Jonathan Druart --- Created attachment 49900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49900&action=edit Bug 5979 - OPAC ISBD view has its own syspref Signed-off-by: Bernardo Gonzalez Kriegel Works well, empty OPACISBD removes link. Test pass. Small koha-qa error fixed in followup Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:56:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:56:09 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #37 from Jonathan Druart --- Created attachment 49901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49901&action=edit Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:56:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:56:14 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #38 from Jonathan Druart --- Created attachment 49902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49902&action=edit Attachment to Bug 5979 - Add separate OPACISBD system preference Bug 5979 - Follow up: Change ISBD syspref description and fix warning in t/Biblio/Isbd.t Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 10:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 08:56:19 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #39 from Jonathan Druart --- Created attachment 49903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49903&action=edit Bug 5979: Update INSERT IGNORE INTO statement Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:05:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:05:24 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- There is one other exception: if you cancel the hold when returning it - this will also charge the fee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:21:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:21:40 +0000 Subject: [Koha-bugs] [Bug 16200] New: 'Hold waiting too long' fee has a translation problem Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Bug ID: 16200 Summary: 'Hold waiting too long' fee has a translation problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The fee entry for 'hold waiting too long' creates an accountlines entry containing untranslatable text and using an F fee type. It would be better to have use a unique fee type that can be used to show a translated entry in the GUI. CancelReserve(): manualinvoice($reserve->{'borrowernumber'}, $reserve->{'itemnumber'}, 'Hold waiting too long', 'F', $charge); Shows in the German GUI as: Mahngeb?hr , Hold waiting too long 130251 Medium ansehen Physik in Demonstrationsversuchen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:22:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:22:09 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- aqbooksellers.plugin has not been added to existing installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:22:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:22:24 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > aqbooksellers.plugin has not been added to existing installations vendor_edi_accounts.plugin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:38:56 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #17 from Jonathan Druart --- Everything looks good, I have only 2 concerns: 1/ It would be nice to add a big warning in the help page to warn users that they must ony use this script if they know what they are doing 2/ Could you rename the script and if possible occurrences of bookseller with vendor + perltidy the script (certainly easily by squashing the patchset) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 11:50:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 09:50:00 +0000 Subject: [Koha-bugs] [Bug 16201] New: Tie automatic cancellation of holds to a system preference to allow easier configuration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16201 Bug ID: 16201 Summary: Tie automatic cancellation of holds to a system preference to allow easier configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, if you run multiple instances on a server, you can not easily configure for some, but not others, that holds not picked up will automatically cancelled. The cronjob used is: misc/cronjobs/holds/cancel_expired_holds.pl If it's scheduled, the feature is active for all instances - or you'd have to maintain a list, change the default cron files etc. It would be nice if this feature was tied to a new system preference, so that you can easily activate/deactivate it from within Koha and without accessing the server. This might also be useful for libraries that want to wait a little longer with cancelling in some cases, for example after a holiday period or when the library has been closed for a while. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:07:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:07:08 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:07:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:07:11 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49896|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 49904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49904&action=edit [SIGNED-OFF] Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok Signed-off-by: Bernardo Gonzalez Kriegel Works ok following test plan No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:21:52 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48732|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 49905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49905&action=edit [SIGNED-OFF] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, tried adding one, one & dup, multiple and cancel multiple No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:22:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:22:00 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48733|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 49906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49906&action=edit [SIGNED-OFF] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:22:33 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 13:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 11:55:05 +0000 Subject: [Koha-bugs] [Bug 16202] New: Rental fees can be generated for fractions of a penny/cent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Bug ID: 16202 Summary: Rental fees can be generated for fractions of a penny/cent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com GetIssuingCharges includes a calculation applying any discount to the item rentalcharge the resulting charge may well include parts of a penny e.g. 1.752643 in one call of the routine the result was being rounded to two decimal places but in other calls it was not and the resulting amount was saved to the database. This caused odd behaviour down the line as amounts accrued causing extra one penny fines to occur or fines not to revert to 0 after user paid the apparent amount owing. Subroutine should do the rounding before returning the charge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:23:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:23:51 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 49907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49907&action=edit Proposed Patch Bug was observed in renewals where an item charge and discount were applied. In mysql amounts were recorded in accountlines using the decimal places undisplayed in the online. With patch applied only the first 2 decimal places can have values other than 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:25:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:25:12 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |philippe.blouin at inlibro.com --- Comment #10 from Blou --- see also bug 16197 So, this discussion is about "what should be the default behavior of the function", which brings "what is the expected behavior for the users", which could means "The users of previous versions" or "normal internet users used to certain UI behaviors", which are different. The function works. It allows for - splitting the words and looking for their usages somewhere - using the word "as-is", including the spaces/commas It does not allow for - splitting the words and using each as a start with. Not a loss, it's mostly useless My opinion is that it should be resolved in two phases: 1) Add the argument "contains" to each call that need it. Even if it's all of them, it helps readability of complex functions. 2) Add the possibility of quotes, at which points files like request.pl must NOT do their own s =~ and leave everything to the call. The 1) is very important to move fast. Right now it is a bug. However you define it, this is a regression to the users. Let's fix that in master before 3.24, and in the next patch for 3.22. Then let someone develop the quote thing. It's a nice feature and matches users expectations, which are set by big search engines, not by us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:44:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:44:54 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:44:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:44:57 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43601|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 49908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49908&action=edit Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:45:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:45:03 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43701|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 49909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49909&action=edit Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying with each new edit, losing the previous effort. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:45:08 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #19 from Nick Clemens --- Created attachment 49910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49910&action=edit Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:45:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:45:12 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45753|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 49911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49911&action=edit Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:45:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:45:59 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #21 from Nick Clemens --- (In reply to Hugo Agud from comment #16) > I have been able to reproduce the error on koha 3.16.7 (I have not checked > in more updated version of koha) > > We have verified that If you edit a serial that has already been received, > koha delete the existing barcode. > > The test plan we suggest. > > 1. Create one subscription with any serial pattern and create item when > receiving an issue. > 2. Receive one or two serial, fill the values of the items, in our test we > have filled enumchron (automatically loaded from patter), signature > (automatically loaded from subscription information) and barcode (manual). > 3. Check that the item has been propertly added to biblionumber > 4. Go to subscription--> serial collection --> Edit Serail --> select one of > the received --> modify field 'Publish on' > 5. Now the barcode has been deleted > > Hope it helps Was able to reproduce as described in this comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 14:48:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 12:48:53 +0000 Subject: [Koha-bugs] [Bug 16203] New: item plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Bug ID: 16203 Summary: item plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:02:19 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #28 from Julian Maurice --- Olli, can we move the "Newest Swagger-spec validated 100% and pushed to production yay! Includes the swaggerMinifier.pl" attachment to another bug? This way we can continue the discussion on swagger-minification, while letting the patches here pass into master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:11:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:11:23 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:11:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:11:26 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49895|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 49912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49912&action=edit Bug 16199: Remove C4::Ris::charconv This subroutine always returns what has been sent in parameter. It is unecessary and can be removed. Test plan: prove t/Ris.t should not be noisy Export a catalogue record in Ris should generate the same file with and without this patch NOTE: With/Without were identical in my testing. t/Ris.t is nicely silenced. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:12:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:12:31 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #21 from Nick Clemens --- (In reply to R?mi Mayrand-Provencher from comment #20) > Created attachment 47776 [details] [review] > Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus > > https://bugs.koha-community.org/show_bug.cgi?id=12478 Tested and works well, fails QA tools Koha qa tools problem: FAIL t/db_dependent/Serials.t "my" variable @serialsByStatus masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:20:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:20:30 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #2 from M. Tompsett --- Comment on attachment 49907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49907 Proposed Patch Review of attachment 49907: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16202&attachment=49907) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +3209,5 @@ > my $discount = _get_discount_from_rule($discount_rules, $branch, $item_type); > $charge = ( $charge * ( 100 - $discount ) ) / 100; > } > + if ($charge) { > + $charge = sprintf '%.2f', $charge; # ensure no fractions of a penny returned This is not identical to the %.02f from line 984 before. Please add the 0 back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:21:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:21:54 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- (In reply to Colin Campbell from comment #0) > GetIssuingCharges ... Subroutine should do the rounding > before returning the charge I agree. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:35:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:35:17 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #40 from Katrin Fischer --- Maybe this should be an enh? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:45:50 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #7 from M. Tompsett --- Comment on attachment 41639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41639 Bug 14305: View arbitrary branch's news, RSS fix Review of attachment 41639: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14305&attachment=41639) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ -53,2 @@ > > RSS feed for [% IF ( loggedinusername ) %][% Branches.GetName( branchcode ) %] and [% END %] system-wide library news. If a user is not logged in and passes branchcode=BranchA in the URL, line 54 isn't going to display correctly. Add '?branch={some branchcode that has specific branch news}' to your opac-main url. Notice the RSS message is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:46:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:46:35 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 15:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 13:47:08 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:03:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:03:30 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:03:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:03:47 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #41 from M. Tompsett --- (In reply to Katrin Fischer from comment #40) > Maybe this should be an enh? I agree, because it adds a new system preference. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:06:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:06:30 +0000 Subject: [Koha-bugs] [Bug 16204] New: Show friendly error message when trying to edit record which no longer exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16204 Bug ID: 16204 Summary: Show friendly error message when trying to edit record which no longer exists Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=X OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you pass a non-existent biblionumber to addbiblio.pl you will get an error message: Can't call method "title" on an undefined value at /cataloguing/addbiblio.pl line 814. This might happen if you click an edit link from search results which are out of date or if you have saved the results of a report. Koha should show a friendlier error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:13:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:13:51 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- Hi, disabling JavaScript gives an empty OPAC page (chrome/firefox), or more properly a 'hidden' page. This without patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:15:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:15:28 +0000 Subject: [Koha-bugs] [Bug 16203] item plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #1 from Marcel de Rooy --- Created attachment 49913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49913&action=edit Bug 16203: item plugins (W-I-P) -rwxr-xr-x 1 master-koha master-koha 3082 Nov 19 10:04 barcode_manual.pl -rwxr-xr-x 1 master-koha master-koha 3896 Nov 19 10:04 barcode.pl -rwxr-xr-x 1 master-koha master-koha 4292 Nov 19 10:04 callnumber-KU.pl -rwxr-xr-x 1 master-koha master-koha 3406 Nov 19 10:04 callnumber.pl -rwxr-xr-x 1 master-koha master-koha 4424 Nov 19 10:04 cn_browser.pl -rwxr-xr-x 1 master-koha master-koha 2058 Nov 19 10:04 dateaccessioned.pl -rwxr-xr-x 1 master-koha master-koha 6777 Jan 4 10:34 macles.pl -rwxr-xr-x 1 master-koha master-koha 3409 Nov 19 10:04 stocknumberam123.pl -rwxr-xr-x 1 master-koha master-koha 3525 Nov 19 10:04 stocknumberAV.pl -rwxr-xr-x 1 master-koha master-koha 1646 Nov 19 10:04 stocknumber.pl Added license statement to cn_browser.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:24:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:24:12 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:24:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:24:15 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49859|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 49914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49914&action=edit [SIGNED-OFF] Bug 16087: Add Koha::OldIssues objects. * Koha/OldIssue.pm: New file. * Koha/OldIssues.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=16087 Signed-off-by: Bernardo Gonzalez Kriegel Nothing to test, new files. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:27:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:27:54 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:27:57 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49857|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 49915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49915&action=edit [SIGNED-OFF] Bug 16086: Add Issues Koha object. * Koha/Issue.pm: New file. * Koha/Issues.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=16086 Signed-off-by: Bernardo Gonzalez Kriegel Nothing to test, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:34:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:34:57 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:34:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:34:59 +0000 Subject: [Koha-bugs] [Bug 16199] C4::Ris::charconv is one of the less useful subroutines ever written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16199 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49912|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 49916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49916&action=edit Bug 16199: Remove C4::Ris::charconv This subroutine always returns what has been sent in parameter. It is unecessary and can be removed. Test plan: prove t/Ris.t should not be noisy Export a catalogue record in Ris should generate the same file with and without this patch NOTE: With/Without were identical in my testing. t/Ris.t is nicely silenced. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 16:47:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 14:47:55 +0000 Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- These sound terrible, but taste amazing: http://realhousemoms.com/starburst-jelly-bean-cookies/ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:15:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:15:57 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:17:28 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #15 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:18:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:18:41 +0000 Subject: [Koha-bugs] [Bug 16194] Do not consider xslt as valid theme dir in LangInstaller.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16194 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:56:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:56:00 +0000 Subject: [Koha-bugs] [Bug 16205] New: MARC editor settings menu should use a Font Awesome icon Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Bug ID: 16205 Summary: MARC editor settings menu should use a Font Awesome icon Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbiblio.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: brendan at bywatersolutions.com, hector.hecaxmmx at gmail.com, m.de.rooy at rijksmuseum.nl, testopia at bugs.koha-community.org Depends on: 15859 The new MARC editor settings menu uses a Glyphicon. It should use a Font Awesome icon instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 [Bug 15859] Move some basic MARC editor controls into settings menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:56:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:56:00 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:56:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:56:00 +0000 Subject: [Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 [Bug 16205] MARC editor settings menu should use a Font Awesome icon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:56:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:56:03 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #8 from M. Tompsett --- Created attachment 49917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49917&action=edit Bug 14305: RSS message correction follow-up If a user is not logged in but requests a specific branch, the RSS feed message fails to mention the branch. TEST PLAN --------- 1) Apply first two patches 2) go to OPAC's opac-main.pl?branch={some branch with specific news} -- notice bad RSS message 3) Apply this patch 4) Repeat step 2 -- notice branch is properly shown. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:58:42 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #10 from Brendan Gallagher --- *Manually added in the missing updatedatabase.pl for .plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:59:05 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41639|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 49918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49918&action=edit Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:59:11 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45673|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 49919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49919&action=edit Bug 14305: View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * 'BRANCH1' * 'none' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14305 Changed 2015-12-14: Whitespace fix Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:59:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:59:19 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49917|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 49920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49920&action=edit Bug 14305: RSS message correction follow-up If a user is not logged in but requests a specific branch, the RSS feed message fails to mention the branch. TEST PLAN --------- 1) Apply first patch 2) go to OPAC's opac-main.pl?branch={some branch with specific news} -- notice bad RSS message 3) Apply this patch 4) Repeat step 2 -- notice branch is properly shown. 5) koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:59:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:59:40 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 17:59:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 15:59:42 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 --- Comment #1 from Owen Leonard --- Created attachment 49921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49921&action=edit Bug 16205 - MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:00:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:00:06 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #12 from M. Tompsett --- Left as Needs Signoff, because I can't sign off my own patch. Please test and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:00:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:00:49 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #13 from M. Tompsett --- (In reply to M. Tompsett from comment #11) > TEST PLAN > --------- > 1) Apply first patch -- actually the first two. > 2) go to OPAC's opac-main.pl?branch={some branch with specific news} > -- notice bad RSS message > 3) Apply this patch > 4) Repeat step 2 > -- notice branch is properly shown. > 5) koha qa test tools > > Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 16206] New: Template changes made by EDI feature should use Font Awesome icons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Bug ID: 16206 Summary: Template changes made by EDI feature should use Font Awesome icons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Acquisitions Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 7736 Blocks: 16080 Bug 7736 introduced some template changes which use Glyphicons. They should be updated to use Font Awesome icons instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 [Bug 16206] Template changes made by EDI feature should use Font Awesome icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 16080] Remove unused images from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 [Bug 16206] Template changes made by EDI feature should use Font Awesome icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:37:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:37:17 +0000 Subject: [Koha-bugs] [Bug 9853] Overdues fine cap empty in circulation rules means fines accrue forever In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9853 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:38:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:38:07 +0000 Subject: [Koha-bugs] [Bug 9853] Overdues fine cap empty in circulation rules means fines accrue forever In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9853 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:42:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:42:04 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49921|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 49922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49922&action=edit Bug 16205: MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. Signed-off-by: Hector Castro Icon changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:42:21 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:47:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:47:06 +0000 Subject: [Koha-bugs] [Bug 16207] New: Incorporate circulation and fine rules for library groups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16207 Bug ID: 16207 Summary: Incorporate circulation and fine rules for library groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I think we could simplify circulation and fine rules by incorporating library groups into the mix. For example, I have 27 libraries, and 8 of them follow the same set of rules that are different from the defaults. So, what if instead of cloning these special rules to 8 different libraries (and who knows how many other duplicated sets of rules there are), we defined a set of rules for a library group. If the library is part of that group, it goes by those rules. I don't know if we want to use the same library groups that are already defined in the libraries and groups, or if we want to create a unique Circ rule group. Because, there is always the chance that one or more of the libraries in the 8 that are grouped together by affiliation or region could have a slightly different set of rules. However, I think rules by groups would make managing rules far less complicated than managing groups of cloned rules. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:50:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:50:02 +0000 Subject: [Koha-bugs] [Bug 16207] Incorporate circulation and fine rules for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16207 --- Comment #1 from Christopher Brannon --- Also, rules for groups should also list the libraries assigned to that group. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:58:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:58:59 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 18:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 16:59:18 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:00:24 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 [Bug 16208] Can't delete a library EAN if the EAN value is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:00:24 +0000 Subject: [Koha-bugs] [Bug 16208] New: Can't delete a library EAN if the EAN value is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 Bug ID: 16208 Summary: Can't delete a library EAN if the EAN value is empty Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/edi_ean_accounts.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 7736 In testing the new EDI pages I tried adding a "Library EAN" with no fields filled out (other than the pre-filled options). The record saved successfully with empty values for EAN and description. When I went to test deletion of one of these records I got an error: Can't call method "delete" on an undefined value at /admin/edi_ean_accounts.pl line 112. I notice the link to delete passes the ean value (which is empty in my test): /admin/edi_ean_accounts.pl?op=delete_confirm&branchcode=APL&ean= I assume this is the reason for the error. If the edifact_ean table has a primary key (ee_id), why not use that for deletion? Should the EAN field be required? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:20:28 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:20:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:20:30 +0000 Subject: [Koha-bugs] [Bug 16205] MARC editor settings menu should use a Font Awesome icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 49923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49923&action=edit Bug 16205 - MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. Signed-off-by: Hector Castro Icons changed Signed-off-by: Tomas Cohen Arazi Works as expected, no qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:39:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:39:41 +0000 Subject: [Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Template changes made by |Corrections to templates |EDI feature should use Font |related new EDI feature |Awesome icons | --- Comment #1 from Owen Leonard --- I'm changing the title of this bug to reflect the wider scope of the changes I'm preparing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:52:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:52:04 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 19:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 17:53:02 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:16:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:16:35 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:16:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:16:59 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #12 from M. Tompsett --- Comment on attachment 42147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42147 Bug 14764: OPAC news selector - Template tags Review of attachment 42147: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14764&attachment=42147) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ +24,4 @@ > [% END %] > >
> + [% IF Koha.Preference( 'opacnewsbranchselect' ) == 1 %] Even though everything should work regardless of case, please match case anyways so as to confuse less people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:18:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:18:01 +0000 Subject: [Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:18:03 +0000 Subject: [Koha-bugs] [Bug 16206] Corrections to templates related new EDI feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 --- Comment #2 from Owen Leonard --- Created attachment 49924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49924&action=edit Bug 16206 - Corrections to templates related new EDI feature There are some issues with the template changes introduced by the EDI feature in Bug 7736. This patch makes the following changes: - Use Font Awesome icon on the Acquisitions basket page instead of a Glyphicon. - Use Font Awesome icon on the Acquisitions basket group page instead of a Glyphicon. - For consistency's sake, use the phrase "Library EANs" instead of "EDI EANs" in menus and the Library EANs page. - On the EDI accounts page: - Correct the markup of the title tag. - Improve the breadcrumbs to eliminate redundancy. - Use Font Awesome icon instead of Glyphicon for the "New account" button. - Change or remove "maxlength" attribute of form fields to match table structure. - Move the contents of some title attributes into a visible hint. - Use 'checked="checked"' instead of 'checked'. Koha templates use XTHML-style attributes. - Correct template variable in account deletion confirmation dialog. Before this patch the vendor name was not correctly displayed. - Show a message if there are no accounts defined rather than an empty table. - Remove use of "highlight" class from table rows (Bug 15927). - Correct parameter name in link to vendor details page (should be booksellerid instead of supplierid). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. - On the Library EANs page: - Correct the markup of the title tag. - Make capitalization of "EAN" consistent. - Use Font Awesome icon instead of Glyphicon for the "New EAN" button. - Show a message if there are no EANs defined rather than an empty table. - Change or remove "maxlength" attribute of form fields to match table structure. - Remove use of "highlight" class from table rows (Bug 15927). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. To test, apply the patch and review the affected templates. Confirm that pages look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:35:07 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:35:09 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49897|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 49925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49925&action=edit [SIGNED-OFF] Bug 16055: Do not allow basketgroup deletion unless empty If a basketgroup has basket attached, it should not be deletable. This patch just removes the Delete button from the interface if it cannot be deleted. When editing a basketgroup, the "Delete basket group" button is no longer displayed. Test plan: 1/ Create a basketgroup 2/ Attach 1+ baskets to this basketgroup 3/ Confirm you are not able to delete it 4/ Remove the baskets from this basketgroup 5/ Confirm you are able to delete it Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:42:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:42:26 +0000 Subject: [Koha-bugs] [Bug 16210] New: Bug 15111 breaks the OPAC if JavaScript is disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 Bug ID: 16210 Summary: Bug 15111 breaks the OPAC if JavaScript is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Since Bug 15111, if you have JavaScript disabled the OPAC is broken. It only displays a blank page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:48:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:48:33 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 --- Comment #5 from Owen Leonard --- (In reply to Bernardo Gonzalez Kriegel from comment #4) > Hi, > disabling JavaScript gives an empty OPAC page (chrome/firefox), > or more properly a 'hidden' page. This issue now has a bug report: Bug 16210. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:52:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:52:37 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49600|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 49926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49926&action=edit Bug 15877 - Unit tests Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:54:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:54:30 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #46 from Owen Leonard --- I'm guessing this is 'Failed QA' based on Comment 45. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 20:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 18:55:25 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49926|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 49927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49927&action=edit Bug 15877 - Unit tests Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:04:55 +0000 Subject: [Koha-bugs] [Bug 16207] Incorporate circulation and fine rules for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16207 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15522 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:04:55 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16207 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:16:36 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #7 from Christopher Brannon --- I would definitely call this a bug. We were scratching our heads trying to figure out where the 21 days came from. What would be preferable is when something like this is overridden and does not have a defined loan period it should prompt you. Something like: This item does not have a set loan period. When would you like it due? If a due date is specified already by staff, it should show that date as a suggestion, otherwise show today's date. Staff could alter the date on that prompt or just use the date shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:18:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:18:54 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #8 from Christopher Brannon --- Better yet, when asked if you want to override, it could say: Do you want to override with a due date of xx/xx/xxxx? YES / NO Again, defaulting to today, or the specified due date if set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:48:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:48:21 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49927|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 49928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49928&action=edit Bug 15877 - Unit tests Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 21:49:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 19:49:44 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 --- Comment #13 from Nick Clemens --- Edited the: $dbh->do(q|DELETE FROM items|); And replaced with: $builder->clear( { source => 'Item' } ); Same for issues, a test crash wiped my database of all items so not an ideal construction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 22:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 20:29:31 +0000 Subject: [Koha-bugs] [Bug 16207] Incorporate circulation and fine rules for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16207 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 22:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 20:59:05 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #7 from Barton Chittenden --- In 3.22, this seems to have shifted from OVERDUE to PREDUE select * from letter where code = 'PREDUE'\G *************************** 1. row *************************** module: circulation code: PREDUE branchcode: name: Hold Available for Pickup is_html: 0 title: Advance Notice of Item Due (phone notice) content: Your item is due soon message_transport_type: phone 1 row in set (0.00 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:28:03 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:28:05 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48919|0 |1 is obsolete| | --- Comment #6 from Jesse Weaver --- Created attachment 49929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49929&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:28:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:28:09 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48920|0 |1 is obsolete| | --- Comment #7 from Jesse Weaver --- Created attachment 49930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49930&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:28:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:28:13 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48921|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver --- Created attachment 49931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49931&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:44:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:44:32 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Should we have icons on those buttons? If yes... please add on another bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:45:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:45:42 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:45:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:45:45 +0000 Subject: [Koha-bugs] [Bug 16055] Deleting a basket group containing baskets fails silently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16055 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49925|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 49932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49932&action=edit [PASSED QA] Bug 16055: Do not allow basketgroup deletion unless empty If a basketgroup has basket attached, it should not be deletable. This patch just removes the Delete button from the interface if it cannot be deleted. When editing a basketgroup, the "Delete basket group" button is no longer displayed. Test plan: 1/ Create a basketgroup 2/ Attach 1+ baskets to this basketgroup 3/ Confirm you are not able to delete it 4/ Remove the baskets from this basketgroup 5/ Confirm you are able to delete it Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:51:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:51:44 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 5 23:51:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 21:51:47 +0000 Subject: [Koha-bugs] [Bug 16198] Opac suggestions are broken if user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49904|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 49933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49933&action=edit [PASSED QA] Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok Signed-off-by: Bernardo Gonzalez Kriegel Works ok following test plan No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:11:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:11:25 +0000 Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:11:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:11:25 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Depends on| |16210 --- Comment #6 from Christopher Brannon --- I find this impossible to test without bug 16210 addressed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:17:41 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- Good news first: - Can reproduce the problem! Bad news: - I think one of the patches above is doubled up, please check! - Tests are failing for me: $ perl t/db_dependent/Serials.t 1..46 ok 1 - use C4::Serials; ok 2 - NewSubscription should set notes ok 3 - NewSubscription should set internalnotes ok 4 - NewSubscription should not set subscriptionhistory opacnotes ok 5 - NewSubscription should not set subscriptionhistory librariannotes ok 6 - A reference of type 'ARRAY' isa 'ARRAY' ok 7 - A reference of type 'ARRAY' isa 'ARRAY' ok 8 - A reference of type 'ARRAY' isa 'ARRAY' ok 9 - A reference of type 'ARRAY' isa 'ARRAY' ok 10 - expiration date is not NULL ok 11 - test getting history from sub-scription ok 12 - Subscription has at least one serial ok 13 - test getting Serial Status From Serial Id Can't use an undefined value as a HASH reference at /home/katrin/kohaclone/cataloguing/value_builder/stocknumber.pl line 28. # Looks like you planned 46 tests but ran 13. # Looks like your test exited with 255 just after 13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:25:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:25:43 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:25:47 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49905|0 |1 is obsolete| | Attachment #49906|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 49934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49934&action=edit [PASSED QA] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, tried adding one, one & dup, multiple and cancel multiple No errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:27:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:27:50 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #21 from Katrin Fischer --- Created attachment 49935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49935&action=edit [PASSED QA] Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:48:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:48:53 +0000 Subject: [Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- (In reply to Nick Clemens from comment #2) > Created attachment 49606 [details] [review] > Bug 15682 - Only allow merging of 2 or more records form lsits (for > consistency) > > Test as above but on shelves.pl How do I bring up shelves.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:54:18 +0000 Subject: [Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 --- Comment #4 from Nick Clemens --- (In reply to Christopher Brannon from comment #3) > How do I bring up shelves.pl? Apologies, try merging from a list in the staff client. Lists from the home page or More-> lists Then choose any list (you can create one from any cataloguing search by checking items and using the 'Add to list' button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 00:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 22:58:16 +0000 Subject: [Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49858|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 49936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49936&action=edit Bug 16179: Do not crash if "rate me" is clicked and not rate selected If JS is disabled and a user clicks on the "Rate me" button, Koha will crashes with: DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null at /usr/share/koha/lib/C4/Ratings.pm line 208 To avoid that, opac-ratings.pl will check if a rate has been selected. Test plan: Disable JS On a record detail page, click on the "Rate me" button TESTED PLAN: 1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1 -- kaboom as above. 2) apply patch 3) refresh -- either login screen (don't know why) -- or if already logged in, detail page. 4) koha qa test tool NOTE: disabling JS breaks OPAC. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 01:32:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 23:32:47 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 --- Comment #24 from Jesse Weaver --- Created attachment 49937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49937&action=edit Bug 11565: (QA followup) add class to allow feature to be easily hidden This wraps both checkboxes (in the confirmation dialog and checkout interface) in a class of "circ-override-high-holds" so they can be easily hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 01:49:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 23:49:40 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 01:55:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Apr 2016 23:55:43 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #23 from M. Tompsett --- Nick signed off the first one, but didn't obsolete it. I did, these apply. However, now I get: mtompset at debian:~/kohaclone$ prove t/db_dependent/Serials.t t/db_dependent/Serials.t .. 1/46 No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. No method update! at /home/mtompset/kohaclone/C4/Serials.pm line 1602. t/db_dependent/Serials.t .. ok All tests successful. Files=1, Tests=46, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.13 cusr 0.02 csys = 1.17 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:32:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:32:09 +0000 Subject: [Koha-bugs] [Bug 16195] Add Koha::Categories objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Perhaps creating a test file to at least initialize and destroy them might be in order? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:37:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:37:59 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #99 from Nick Clemens --- Simple conflict in Letters.pm but then: Applying: Bug 8000 - Correct inability to know where message was sent fatal: sha1 information is lacking or useless (t/db_dependent/Letters.t). If rebased I will try to test quickly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:40:39 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #4 from M. Tompsett --- Comment on attachment 49823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49823 Bug 13438: Convert normarc framework plugins to new style Review of attachment 49823: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13438&attachment=49823) ----------------------------------------------------------------- ::: cataloguing/value_builder/normarc_field_007.pl @@ +88,1 @@ > #FIXME: There is probably a more-elegant way to do this! You mean something like: use Data::Dumper; my $str='abcdef'; my $len=22-length $str; @tmp = split //,$str; push @tmp,(undef)x($len); print Dumper(\@tmp);" And some sort of my @field_numbers = map { "f$_" } (0..21); Then use a loop to template->param it all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:44:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:44:58 +0000 Subject: [Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:45:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:45:01 +0000 Subject: [Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49717|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 49938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49938&action=edit Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:48:27 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:48:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:48:30 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49533|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 49939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49939&action=edit Bug 9543 - Show patrons messaging subscription on holds notification Display an information about a patron's messaging preferences if an item is checked in where the patron has put a hold. To test: - Apply patch - Make sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value) - Place a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verify that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:50:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:50:03 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Jonathan Druart from comment #0) > There are no needs to call this subroutine inside a loop (bug 16157 has > removed the selected flag). Agreed. The Authorized Value Name for the item fields isn't going to change, since the Biblio is the same which keeps the framework code the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:56:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:56:58 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:57:00 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #8 from Nick Clemens --- Created attachment 49940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49940&action=edit Bug 9543 - Show patrons messaging subscription on holds notification not already waiting Same plan as previous patch, but this one should show the message for a hold not already waiting but not requiring a transfer (hold-found2 alert box) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 02:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 00:57:37 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- I added a follow up to display the information on the message box before a hold is confirmed, but only if no transfer is required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:11:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:11:44 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from M. Tompsett --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:14:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:14:00 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #38 from Nick Clemens --- Created attachment 49941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49941&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:14:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:14:06 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #39 from Nick Clemens --- Created attachment 49942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49942&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:14:11 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48629|0 |1 is obsolete| | --- Comment #40 from Nick Clemens --- Created attachment 49943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49943&action=edit Bug 11317 - Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Test preparation : * Add the "accessdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:02 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:05 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49941|0 |1 is obsolete| | --- Comment #41 from Nick Clemens --- Created attachment 49944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49944&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:13 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49942|0 |1 is obsolete| | --- Comment #42 from Nick Clemens --- Created attachment 49945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49945&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:21 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49943|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 49946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49946&action=edit Bug 11317 - Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Test preparation : * Add the "accessdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:30 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48635|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 49947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49947&action=edit Bug 11317 - Allows for multiple directories to be accessible It is now possible to add as many SOMEDIR as needed to the config file. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:15:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:15:57 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Attachment #39783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:16:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:16:03 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:17:04 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Nick Clemens --- Very minor conflict from EDI cleared qa tool complains: FAIL reports/report_files.pl OK critic OK forbidden patterns OK pod OK spelling FAIL valid Name "Tie::Hash::FIELDS" used only once: possible typo Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:18:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:18:02 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 03:18:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 01:18:19 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49944|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 08:12:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 06:12:47 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #46 from Katrin Fischer --- Hi Nick, that qa test problem will be fixed by another patch soon. Is this otherwise ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 09:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 07:58:52 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 09:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 07:59:09 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 10:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 08:53:07 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 11:11:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 09:11:05 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #14 from Aleisha Amohia --- (In reply to Owen Leonard from comment #13) > Overall this looks great. I am curious why you created a new include file > for the add message form but put the modal markup in members-toolbar.inc. > Why not just put all the markup in members-toolbar.inc? It was just how I'd seen it done elsewhere so I followed that. I can move it all into members-toolbar tomorrow if you think that would be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 11:18:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 09:18:58 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #47 from Nick Clemens --- (In reply to Katrin Fischer from comment #46) > Hi Nick, that qa test problem will be fixed by another patch soon. Is this > otherwise ok? Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 11:56:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 09:56:32 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:14:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:14:40 +0000 Subject: [Koha-bugs] [Bug 16211] New: Missing tag in member.tt line 392 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16211 Bug ID: 16211 Summary: Missing tag in member.tt line 392 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: faceker at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:22:50 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #3) > Please rebase. Apply cleanly on top of bug 16157. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:26:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:26:12 +0000 Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I use NoScript and Iceweasel 38.2.1 and the OPAC displays correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:36:44 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:36:47 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #11 from Jonathan Druart --- Created attachment 49948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49948&action=edit Bug 15930: Make patron searches defaulting on 'contain' The default patron search types has changed from 'contain' to start_with. Users consider it as a bug. This patch revert the previous changes to default on 'contain'. Test plan: Search for patrons in different places (guarantor, checkout, patron module, acquisition module, etc.) and confirm that the default is always 'contain' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:37:36 +0000 Subject: [Koha-bugs] [Bug 16197] Searching for user in reserve/request.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15930 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:37:36 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #12 from Jonathan Druart --- *** Bug 16197 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:37:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:37:52 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:51:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:51:17 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #29 from Olli-Antti Kivilahti --- Sure. Tho I stress that you should replace definitions/index.json with definitions.json -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:53:53 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 --- Comment #5 from M. Tompsett --- (In reply to Jonathan Druart from comment #4) > (In reply to M. Tompsett from comment #3) > > Please rebase. > > Apply cleanly on top of bug 16157. DOH! Sorry, I missed that. It does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:58:18 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #9 from Jonathan Druart --- Christopher, would you agree with the suggestion I made on comment 3? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:58:31 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8361 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:58:31 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15757 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:59:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:59:37 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13576 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 12:59:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 10:59:37 +0000 Subject: [Koha-bugs] [Bug 13576] Add a default circulation rule to the optional sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15757 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:04:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:04:38 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:04:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:04:38 +0000 Subject: [Koha-bugs] [Bug 16212] New: Swagger specification separation and minification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Bug ID: 16212 Summary: Swagger specification separation and minification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 15126 We should discuss how to split the Swagger spec, and whether or not we should minify it (and how). For more details, see the following comments: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126#c5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126#c6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126#c26 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:05:26 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #1 from Julian Maurice --- Created attachment 49949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49949&action=edit Newest Swagger-spec validated 100% and pushed to production yay! Includes the swaggerMinifier.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:05:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:05:50 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48226|0 |1 is obsolete| | --- Comment #30 from Julian Maurice --- Comment on attachment 48226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48226 Newest Swagger-spec validated 100% and pushed to production yay! Includes the swaggerMinifier.pl Moved to bug 16212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:17:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:17:15 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #2 from Julian Maurice --- Created attachment 49950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49950&action=edit Bug 16212: Add script minifySwagger.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:31:16 +0000 Subject: [Koha-bugs] [Bug 16213] New: Allow to select hold's itemtype when using API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Bug ID: 16213 Summary: Allow to select hold's itemtype when using API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13903, 15533 Bug 15533 bring the capability to select an itemtype for a title-level hold in staff and OPAC. This should be possible through the API too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 [Bug 15533] Allow patrons and librarians to select itemtype when placing hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:31:16 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 [Bug 16213] Allow to select hold's itemtype when using API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:31:16 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 [Bug 16213] Allow to select hold's itemtype when using API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:31:54 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 --- Comment #1 from Julian Maurice --- Created attachment 49951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49951&action=edit Bug 16213: Allow to select hold's itemtype when using API Depends on bug 15533 and bug 13903 Test plan: 1/ Use your usual "REST testing" tool to place a title-level hold with an itemtype. The request should look like this: POST /api/v1/reserves { "borrowernumber": 1234, "biblionumber": 456, "branchcode": "CPL", "itemtype": "A" } 2/ Check that the hold was placed and the itemtype is correctly selected 3/ prove t/db_dependent/api/v1/reserves.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:32:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:32:20 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:32:37 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:50:34 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46504|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 49952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49952&action=edit Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:59:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:59:33 +0000 Subject: [Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 13:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 11:59:36 +0000 Subject: [Koha-bugs] [Bug 16183] Add confirm message for deleting patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49867|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 49953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49953&action=edit Bug 16183: Confirm message upon deleting patron messages To test: 1) Go to a patron circulation page and add a message 2) Click '[Delete]' 3) Confirm that a confirm dialog shows up and 'Cancel' and 'OK' do what is expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:00:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:00:18 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Julian Maurice --- (In reply to Jonathan Druart from comment #4) > Julian, > I'd suggest to simplify with something like: > > $form.find('select').not('[disabled]').find('option:selected').each(function > () { > > I have tried and it seems to work, please confirm. Yep, much better, thanks. I removed the signoffs (sorry Marc and Aleisha), so I reset status to Needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:00:56 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49866|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 49954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49954&action=edit Bug 16193: Typo in Automatic item modifications by age To test: 1) Go to Tools -> Automatic item modifications by age 2) Click Edit 3) Add a rule if you have none, otherwise notice button 'Submit theses rules' and typo (theses) 4) Apply patch, refresh page 5) Confirm button now says 'Submit these rules' (typo is fixed) Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:00:53 +0000 Subject: [Koha-bugs] [Bug 16193] Typo in Automatic item modifications by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16193 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:10:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:10:06 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49915|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 49955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49955&action=edit Bug 16086: Add Issues Koha object. * Koha/Issue.pm: New file. * Koha/Issues.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=16086 Signed-off-by: Bernardo Gonzalez Kriegel Nothing to test, no errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:10:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:10:03 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:10:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:10:12 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 --- Comment #6 from Jonathan Druart --- Created attachment 49956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49956&action=edit Bug 16086: Add tests for Koha::Issues Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:11:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:11:24 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:11:27 +0000 Subject: [Koha-bugs] [Bug 16087] Add Koha::OldIssues Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16087 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49914|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 49957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49957&action=edit Bug 16087: Add Koha::OldIssues objects. * Koha/OldIssue.pm: New file. * Koha/OldIssues.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=16087 Signed-off-by: Bernardo Gonzalez Kriegel Nothing to test, new files. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:19:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:19:31 +0000 Subject: [Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:19:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:19:34 +0000 Subject: [Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49938|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 49958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49958&action=edit Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:30:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:30:04 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:30:07 +0000 Subject: [Koha-bugs] [Bug 16158] GetAuthorisedValues should not be called inside a loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16158 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49644|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 49959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49959&action=edit Bug 16158: Move GetAuthorisedValues outside the loop In catalogue/detail.pl and catalogue/moredetail.pl, the GetAuthorisedValues subroutine is called once per item. It's not needed, only 1 call is enough. Test plan: Edit item and view a catalogue record. The withdrawn, lost and damaged values should be correctly displayed/saved. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:36:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:36:42 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 --- Comment #4 from Jonathan Druart --- Comment on attachment 49225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49225 Bug 15532: Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Review of attachment 49225: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15532&attachment=49225) ----------------------------------------------------------------- ::: t/db_dependent/Holds/HoldFulfillmentPolicy.t @@ +9,5 @@ > +use t::lib::TestBuilder; > + > +BEGIN { > + use FindBin; > + use lib $FindBin::Bin; Is this useful? @@ +49,5 @@ > +$dbh->do("DELETE FROM reserves"); > +$dbh->do("DELETE FROM issues"); > +$dbh->do("DELETE FROM items"); > +$dbh->do("DELETE FROM biblio"); > +$dbh->do("DELETE FROM biblioitems"); Why do you delete the entries from these 5 tables? ::: t/db_dependent/HoldsQueue.t @@ +443,4 @@ > is( @$holds_queue, 0, "Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled"); > # End Bug 15062 > > +# Test hold_fulfillment_policy This looks a c/p of t/db_dependent/Holds/HoldFulfillmentPolicy.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:36:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:36:53 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:50:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:50:47 +0000 Subject: [Koha-bugs] [Bug 15958] ZOOM/Zebra-connection cache flushing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 --- Comment #2 from M. Tompsett --- Comment on attachment 48549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48549 Bug 15958 - ZOOM/Zebra-connection cache flushing Review of attachment 48549: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15958&attachment=48549) ----------------------------------------------------------------- ::: C4/Context.pm @@ +788,5 @@ > + > +=cut > + > +sub flushZconns { > + my @ZconnKeys = keys%{$context->{"Zconn"}} if ref($context->{"Zconn"}) eq 'HASH'; Not sure how to trigger, but if $context->{"Zconn"} is undefined or not a HASH, then @ZconnKeys doesn't get defined, which will break the loop. Split declarations from conditional initializations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:51:38 +0000 Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 --- Comment #2 from Owen Leonard --- I tested in Iceweasel by disabling JS via the the Web Developer Toolbar (http://chrispederick.com/work/web-developer/), but it also works to use about:config and set the javascript.enabled preference to "false." In Chromium I use an extension called "Quick Javascript Switcher." I can reproduce the problem in both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:52:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:52:24 +0000 Subject: [Koha-bugs] [Bug 15958] ZOOM/Zebra-connection cache flushing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:53:11 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:54:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:54:22 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #16 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:54:49 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 14:59:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 12:59:54 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #162 from Jonathan Druart --- The patches do not apply and there is a merge marker in the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:00:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:00:51 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:02:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:02:11 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:02:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:02:13 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49952|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 49960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49960&action=edit [SIGNED-OFF] Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Signed-off-by: Owen Leonard I could not reproduce the bug when selecting multiple home libraries, but I could by selecting multiple item types or collection codes. The patch allowed those queries to complete correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:02:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:02:14 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #18 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:02:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:02:55 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #18 from Jonathan Druart --- Moreover it would make sense to execute all the moves in single transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:07:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:07:47 +0000 Subject: [Koha-bugs] [Bug 16056] Error when deleting MARC authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16056 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:13:48 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:13:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:13:51 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49198|0 |1 is obsolete| | Attachment #49928|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 49961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49961&action=edit Bug 15877 - C4::Barcodes does not correctly calculate db_max for 'annual' barcodes This patch alters the MySQL query to remove a max statement which incorrectly groups full annual barcodes with numeric values. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:13:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:13:56 +0000 Subject: [Koha-bugs] [Bug 15877] C4::Barcodes does not correctly calculate db_max for 'annual' barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15877 --- Comment #15 from Jonathan Druart --- Created attachment 49962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49962&action=edit Bug 15877 - Unit tests Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:17:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:17:45 +0000 Subject: [Koha-bugs] [Bug 16068] System preference override feature (OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:21:16 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:23:32 +0000 Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |julian.maurice at biblibre.com Resolution|--- |FIXED --- Comment #5 from Julian Maurice --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:28:42 +0000 Subject: [Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:33:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:33:54 +0000 Subject: [Koha-bugs] [Bug 13132] Adding confirm message for deleting a report from the reports toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13132 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Not needed in stable versions (no delete button in toolbar), status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:41:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:41:44 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard --- When I submit a change in the OPAC the page is redisplayed with a "No changes were made" message and the extended attribute fields have disappeared from the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:43:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:43:21 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49797|0 |1 is obsolete| | --- Comment #80 from Tom?s Cohen Arazi --- Created attachment 49963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49963&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:43:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:43:37 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49798|0 |1 is obsolete| | --- Comment #81 from Tom?s Cohen Arazi --- Created attachment 49964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49964&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:43:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:43:50 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49799|0 |1 is obsolete| | --- Comment #82 from Tom?s Cohen Arazi --- Created attachment 49965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49965&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:01 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49800|0 |1 is obsolete| | --- Comment #83 from Tom?s Cohen Arazi --- Created attachment 49966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49966&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:14 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49801|0 |1 is obsolete| | --- Comment #84 from Tom?s Cohen Arazi --- Created attachment 49967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49967&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:25 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49802|0 |1 is obsolete| | --- Comment #85 from Tom?s Cohen Arazi --- Created attachment 49968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49968&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:38 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49803|0 |1 is obsolete| | --- Comment #86 from Tom?s Cohen Arazi --- Created attachment 49969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49969&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:47 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49804|0 |1 is obsolete| | --- Comment #87 from Tom?s Cohen Arazi --- Created attachment 49970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49970&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:44:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:44:59 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49805|0 |1 is obsolete| | --- Comment #88 from Tom?s Cohen Arazi --- Created attachment 49971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49971&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:45:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:45:10 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49807|0 |1 is obsolete| | --- Comment #89 from Tom?s Cohen Arazi --- Created attachment 49972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49972&action=edit Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:49:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:49:39 +0000 Subject: [Koha-bugs] [Bug 14158] t/db_dependent/www/search_utf8.t hangs if error is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:57:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:57:17 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 15:59:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 13:59:23 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #18 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:01:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:01:58 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:02:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:02:01 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47243|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 49973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49973&action=edit Bug 15599: Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Meaningful chages to the tests. Passes qa tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:11:18 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #10 from Christopher Brannon --- (In reply to Jonathan Druart from comment #9) > Christopher, would you agree with the suggestion I made on comment 3? I can't. The code is beyond my understanding. I don't know any of Koha's internal plumbing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:11:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:11:39 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 [Bug 16214] Surname not displayed in serials patron search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:11:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:11:39 +0000 Subject: [Koha-bugs] [Bug 16214] New: Surname not displayed in serials patron search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 Bug ID: 16214 Summary: Surname not displayed in serials patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 15722 Bug 15722 introduces a regression in serials patron search results, causing the surname to not be displayed To reproduce: 1. Create a routing list for a subscription 2. Click on "Add recipients" button 3. Run a search 4. Check that surname is not displayed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:13:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:13:27 +0000 Subject: [Koha-bugs] [Bug 16214] Surname not displayed in serials patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 --- Comment #1 from Julian Maurice --- Created attachment 49974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49974&action=edit Bug 16214: Fix typo 'To.jon' -> 'To.json' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:13:37 +0000 Subject: [Koha-bugs] [Bug 16214] Surname not displayed in serials patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:14:12 +0000 Subject: [Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #7 from Owen Leonard --- I think it would be better if the OPAC-related changes could be split into their own bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:15:12 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- (In reply to Jonathan Druart from comment #1) > Is this still an issue? > Why should we refuse checkouts if no rule is defined? Because that is expected behavior. If I don't put gas in the car, I don't expect it to still drive. There are basic components that are just required. I guess we could make Koha ask questions when certain things are missing, like when the item is due. If that were the only piece missing, that would be fine. But if there are no circ rules defined, chances are there is a lot more missing in setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:16:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:16:32 +0000 Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:17:11 +0000 Subject: [Koha-bugs] [Bug 16210] Bug 15111 breaks the OPAC if JavaScript is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16210 --- Comment #3 from Jonathan Druart --- Same comment as bug 15111 comment 33: Well, we have a problem. After reading this https://www.owasp.org/images/0/0e/OWASP_AppSec_Research_2010_Busting_Frame_Busting_by_Rydstedt.pdf it seems that it is not possible not to be vulnerable to XFS and render something with JS disabled... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:17:07 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Note to myself: waiting for bug 16214 to be pushed to master, so I can push them both into 3.22.x at the same time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:18:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:18:22 +0000 Subject: [Koha-bugs] [Bug 13576] Add a default circulation rule to the optional sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Why sample data? Why not a default behavior if no rules are present? Either reject transactions until all the pieces are in place, or have a hard set rule in place in case basic rules or a "catch all" is defined by admin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:22:16 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #11 from Jonathan Druart --- (In reply to Christopher Brannon from comment #10) > (In reply to Jonathan Druart from comment #9) > > Christopher, would you agree with the suggestion I made on comment 3? > > I can't. The code is beyond my understanding. I don't know any of Koha's > internal plumbing. Basically it means that - 0 will be taken into account for 'Loan period' (issuelength) - and if not filled in the circ rules NULL will be inserted in the DB (instead of 0, which is the current behavior). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:22:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:22:31 +0000 Subject: [Koha-bugs] [Bug 10089] Prevent renewing for restricted patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #6 from Owen Leonard --- I think this has been fixed by Bug 8236. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:24:57 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 --- Comment #3 from Jonathan Druart --- (In reply to Christopher Brannon from comment #2) > (In reply to Jonathan Druart from comment #1) > > Is this still an issue? > > Why should we refuse checkouts if no rule is defined? > > Because that is expected behavior. If I don't put gas in the car, I don't > expect it to still drive. There are basic components that are just required. Yes exactly, so do not expect Koha to behave correctly if you did not configure it correctly :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:27:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:27:49 +0000 Subject: [Koha-bugs] [Bug 16214] Surname not displayed in serials patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:27:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:27:52 +0000 Subject: [Koha-bugs] [Bug 16214] Surname not displayed in serials patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49974|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 49975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49975&action=edit Bug 16214: Fix typo 'To.jon' -> 'To.json' Bug 15722 introduces a regression in serials patron search results, causing the surname to not be displayed To reproduce: 1. Create a routing list for a subscription 2. Click on "Add recipients" button 3. Run a search 4. Check that surname is not displayed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:28:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:28:23 +0000 Subject: [Koha-bugs] [Bug 16214] Surname not displayed in serials patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- AArgh, sorry about that! Skipping QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 6 16:30:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Apr 2016 14:30:11 +0000 Subject: [Koha-bugs] [Bug 16215] New: Missing closing quote in checkout template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Bug ID: 16215 Summary: Missing closing quote in checkout template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There is a missing closing quote in circulation.tt on line 411: