From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 00:35:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 22:35:09 +0000
Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889
Jesse Weaver changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jweaver at bywatersolutions.co
| |m
Status|Passed QA |Pushed to Master
--- Comment #6 from Jesse Weaver ---
Pushed to master, will be in the May 2016 release. Thanks for your work!
I had to manually apply this using git apply --reject, please make sure
everything is okay. Passed tests and QA tools.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:45:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:45:11 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42234|0 |1
is obsolete| |
--- Comment #78 from Srdjan Jankovic ---
Created attachment 49750
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49750&action=edit
bug_11213: Changed XSLTParse4Display() interface
The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.
* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
list
- changed buildKohaItemsNamespace() accordingly
* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
with GetItemsInfo() call, passing order_by "cn_sort"
* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call
* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
XSLTParse4Display() call
To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl
The display should stay the same before and after patch. The speed
should increase though.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:46:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:46:51 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:46:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:46:53 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42235|0 |1
is obsolete| |
--- Comment #79 from Srdjan Jankovic ---
Created attachment 49751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49751&action=edit
bug_11213: whitespace correction
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:47:17 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:47:17 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42236|0 |1
is obsolete| |
--- Comment #80 from Srdjan Jankovic ---
Created attachment 49752
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49752&action=edit
bug_11213: Include XSLT processing for searchResults() test
* Added template paths to temp test dir, so XSLT templates can be picked
up
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:47:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:47:35 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42237|0 |1
is obsolete| |
Attachment #42238|0 |1
is obsolete| |
--- Comment #81 from Srdjan Jankovic ---
Created attachment 49753
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49753&action=edit
bug_11213: GetItemsInfo() test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:48:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:48:04 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42239|0 |1
is obsolete| |
--- Comment #82 from Srdjan Jankovic ---
Created attachment 49754
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49754&action=edit
bug_11213: Added XSLTParse4Display() to Items test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 01:48:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Mar 2016 23:48:38 +0000
Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #42240|0 |1
is obsolete| |
Attachment #42425|0 |1
is obsolete| |
--- Comment #83 from Srdjan Jankovic ---
Created attachment 49755
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49755&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:28:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 00:28:29 +0000
Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
Attachment #49728|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:35:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 00:35:30 +0000
Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:35:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 00:35:32 +0000
Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49726|0 |1
is obsolete| |
--- Comment #2 from M. Tompsett ---
Created attachment 49756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49756&action=edit
Bug 16176: Fix a test about OpenLibrarySearch
Introduced by bug 6624: When C4::UsageStats::BuildReport is modified,
the tests should be too.
Test plan:
prove t/db_dependent/UsageStats.t
should return green
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 02:45:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 00:45:18 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49737|0 |1
is obsolete| |
--- Comment #7 from M. Tompsett ---
Created attachment 49757
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49757&action=edit
Bug 16174: (QA followup) Fix remaining tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:19:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:19:34 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
Resolution|REMIND |---
Status|CLOSED |REOPENED
--- Comment #1 from Mason James ---
Woah, i think just hit this bug in 2016?!
I'll reopen this now..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:26:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:26:34 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
--- Comment #2 from Mason James ---
Created attachment 49758
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49758&action=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:29:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:29:14 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
--- Comment #3 from Mason James ---
Created attachment 49759
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49759&action=edit
before/after pic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:30:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:30:57 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |Needs Signoff
--- Comment #4 from Mason James ---
sorry, no test plan provided
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:34:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:34:34 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
--- Comment #5 from Mason James ---
FYI: the way this bug can be revealed is to have a borrower in the report with
either a NULL 'surname' or 'firstname' value
If this occurs, CONCAT() makes the borrower.name value NULL (bad!)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 04:58:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 02:58:29 +0000
Subject: [Koha-bugs] [Bug 16184] New: Bug 1750 - Report bor_issues_top shows
incorrect number of rows
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
Bug ID: 16184
Summary: Bug 1750 - Report bor_issues_top shows incorrect
number of rows
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: gmcharlt at gmail.com
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
Bug 1750 - Report bor_issues_top shows incorrect number of rows
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:00:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:00:04 +0000
Subject: [Koha-bugs] [Bug 16184] Bug 1750 - Report bor_issues_top shows
incorrect number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
--- Comment #1 from Mason James ---
This report always returns double the number of rows requested
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:00:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:00:58 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Bug 1750 - Report |Report bor_issues_top shows
|bor_issues_top shows |incorrect number of rows
|incorrect number of rows |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:01:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:01:51 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
--- Comment #2 from Mason James ---
Created attachment 49760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49760&action=edit
Bug 16184 - Report bor_issues_top shows incorrect number of rows
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:03:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:03:03 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
--- Comment #3 from Mason James ---
Created attachment 49761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49761&action=edit
before/after pic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:04:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:04:51 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
--- Comment #4 from Mason James ---
A report with a LIMIT of 5 rows, will incorrectly return 10 rows (bad!)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:05:31 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:05:31 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:13:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:13:39 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49758|0 |1
is obsolete| |
--- Comment #6 from Mason James ---
Created attachment 49762
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762&action=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.
Signed-off-by: Mason James
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:15:03 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |1750
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
[Bug 1750] Report bor_issues_top erroneous and truncated results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:15:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:15:03 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |16184
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
[Bug 16184] Report bor_issues_top shows incorrect number of rows
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:32:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:32:06 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|1750 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
[Bug 1750] Report bor_issues_top erroneous and truncated results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:32:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:32:06 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|16184 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
[Bug 16184] Report bor_issues_top shows incorrect number of rows
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:53:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:53:06 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
--- Comment #7 from M. Tompsett ---
Comment on attachment 49762
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49762
Bug 1750 - Report bor_issues_top erroneous and truncated results.
Review of attachment 49762:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1750&attachment=49762)
-----------------------------------------------------------------
::: reports/bor_issues_top.pl
@@ +279,4 @@
> my $strcalc ;
>
> # Processing average loanperiods
> + $strcalc .= "SELECT CONCAT_WS('', borrowers.surname , \",\\t\", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID";
http://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_concat-ws
Nice! CONCAT_WS skips NULL entries, but still concat's, while CONCAT gives up
and returns NULL.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:58:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:58:23 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 05:58:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 03:58:26 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49762|0 |1
is obsolete| |
--- Comment #8 from M. Tompsett ---
Created attachment 49763
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49763&action=edit
Bug 1750 - Report bor_issues_top erroneous and truncated results.
Signed-off-by: Mason James
TEST PLAN
---------
1) Ensure you have some checkouts
2) Home -> Reports
-> Patrons with the most checkouts
3) Click 'Submit'
-- you get a list
4) Click a patron name.
5) Note the borrower number.
6) In MySQL run something like:
> UPDATE borrower SET firstname=NULL WHERE borrowernumber=####
7) Refresh the report page
-- name goes totally blank
8) apply patch
9) Refresh the report page
-- only first name is lost
10) run koha qa test tools
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:00:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:00:03 +0000
Subject: [Koha-bugs] [Bug 1750] Report bor_issues_top erroneous and
truncated results.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
URL|http://staff-atz.dev.kohali |
|brary.com/cgi-bin/koha/repo |
|rts/bor_issues_top.pl |
--- Comment #9 from M. Tompsett ---
URL deleted as it links to the WRONG location.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:21:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:21:55 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #5 from M. Tompsett ---
I'm not sure whether this patch is the best way to do it.
The whole query issues and old_issues via Perl seems like the wrong way to
handle the logic. I'm sure a better SQL query could be built with a UNION that
way the LIMIT and GROUP BY would be handled by MySQL instead.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:32:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:32:05 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:32:08 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:32:08 +0000
Subject: [Koha-bugs] [Bug 16184] Report bor_issues_top shows incorrect
number of rows
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16184
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49760|0 |1
is obsolete| |
--- Comment #6 from M. Tompsett ---
Created attachment 49764
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49764&action=edit
Bug 16184 - Report bor_issues_top shows incorrect number of rows
TEST PLAN
---------
1) Have at least 6 patrons with checkouts and some checkins.
2) Reports -> Patrons with the most checkouts
3) Click 'Submit' (default is 5)
-- more than 5 entries listed.
4) Apply patch
5) Refresh page
-- only 5 entries listed.
6) Run koha qa test tools
NOTE: While this works, I'd be much happier with a refactor
as it would also speed up the report. See comment #5.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:41:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:41:07 +0000
Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 06:41:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 04:41:09 +0000
Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49727|0 |1
is obsolete| |
--- Comment #2 from M. Tompsett ---
Created attachment 49765
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49765&action=edit
Bug 16177: Fix tests for ColumnsSsettings.t
This failure has been introduced by
commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
Bug 15285: Update common files
This is because the cannot_be_modified key is not always created by
C4::Utils::DataTables::ColumnsSettings subroutines
Test plan:
prove t/db_dependent/ColumnsSettings.t
should return green
And you can also test a table where the feature is set and a column
cannot be modified from the admin page.
NOTE: Works as described. I was pondering this potential
solution when I found it in bugzilla.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:00:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:00:34 +0000
Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669
--- Comment #11 from M. Tompsett ---
Comment on attachment 49716
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49716
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar
Review of attachment 49716:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3669&attachment=49716)
-----------------------------------------------------------------
::: circ/add_message.pl
@@ +51,4 @@
> }
> )->store;
>
> +my $url = $input->referer();
http://perldoc.perl.org/CGI.html
"referer()
Return the URL of the page the browser was viewing prior to fetching your
script. Not available for all browsers."
-- might be a good idea to // "/cgi...$borrowernumber";
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:51:19 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:51:23 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49596|0 |1
is obsolete| |
Attachment #49597|0 |1
is obsolete| |
Attachment #49607|0 |1
is obsolete| |
Attachment #49740|0 |1
is obsolete| |
Attachment #49741|0 |1
is obsolete| |
--- Comment #84 from Katrin Fischer ---
Created attachment 49766
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49766&action=edit
[PASSED QA] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool
This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.
This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.
Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed
Signed-off-by: Owen Leonard
Patron batches are correctly passed to the edit and delete pages.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:51:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:51:57 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #85 from Katrin Fischer ---
Created attachment 49767
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767&action=edit
[PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items
This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.
Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.
To test, apply the patch and go to Tools -> Patron lists.
- On a patron list with no patrons, confirm that the "Actions"
menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
"Actions" menu /also/ has these options: "Print patron cards," "Batch
edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
to batch edit and batch delete.
Signed-off-by: Nick Clemens
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:52:01 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #86 from Katrin Fischer ---
Created attachment 49768
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768&action=edit
[PASSED QA] Bug 10612: Follow-up - correcting icon to be Font Awesome
- check print icon on the patron list summary page is correct
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:06 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:52:06 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #87 from Katrin Fischer ---
Created attachment 49769
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769&action=edit
[PASSED QA] Bug 10612 - Unit tests
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 07:52:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 05:52:10 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
patron deletion tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #88 from Katrin Fischer ---
Created attachment 49770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770&action=edit
[PASSED QA] Bug 10612: (QA followup)
Rename not_borrowered_since to not_borrowed_since
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 08:30:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 06:30:32 +0000
Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140
--- Comment #24 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #16)
> (In reply to Jacek Ablewicz from comment #14)
> > I have kinda mixed feelings about flush_L1_if_needed() feature. It provides
> > nice speed-up for plack setups, but - unless I'm very much mistaken, it also
> > makes L2 cache expiration mechanism unreliable under plack (?).
>
> Regarding the benchmarks, this part will certainly be dropped.
Without that part, 2nd patch (don't clone cache results for framework/authvals)
would be a whole lot less risky under plack - it may still cause some
(hopefully minor) issues, but at least they will be predictable & reproductible
under plack as well as in the CGI setups.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 08:31:40 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 06:31:40 +0000
Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:15:35 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 07:15:35 +0000
Subject: [Koha-bugs] [Bug 16146] [3.22] ACQ: Previewed records in Z39.50
search results are wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
Status|Passed QA |Pushed to Stable
--- Comment #7 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6. Thanks everyone
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 07:52:23 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 07:52:25 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170
--- Comment #10 from Marcel de Rooy ---
Created attachment 49771
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49771&action=edit
Bug 16170: [QA Follow-up] Adjust Items.t
Items.t inserts an item via biblioitem not correctly linked to biblio.
The new foreign key constraint does not allow that.
Actually, we should be choosing to either remove biblioitems from Koha or
remove biblionumber from items.
Note: This seems to be the only case where an item is added this way.
Test plan:
Run Items.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:52:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 07:52:30 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170
--- Comment #11 from Marcel de Rooy ---
Created attachment 49772
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49772&action=edit
Bug 16170: [QA Follow-up] Fix embeded typos
Just noticed this typo three times here.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 09:54:53 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 07:54:53 +0000
Subject: [Koha-bugs] [Bug 16170] Pseudo foreign key in Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16170
--- Comment #12 from Marcel de Rooy ---
Remember to adjust DBIx (for testing you could just insert is_foreign_key => 1
for biblionumber in Items.pm
If you would run t/db_dependent/Barcodes_ValueBuilder.t, TestBuilder needs to
see that biblionumber is a foreign key.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:29 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:04:29 +0000
Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:32 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:04:32 +0000
Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49765|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 49773
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49773&action=edit
Bug 16177: Fix tests for ColumnsSsettings.t
This failure has been introduced by
commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
Bug 15285: Update common files
This is because the cannot_be_modified key is not always created by
C4::Utils::DataTables::ColumnsSettings subroutines
Test plan:
prove t/db_dependent/ColumnsSettings.t
should return green
And you can also test a table where the feature is set and a column
cannot be modified from the admin page.
NOTE: Works as described. I was pondering this potential
solution when I found it in bugzilla.
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:04:43 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:04:43 +0000
Subject: [Koha-bugs] [Bug 16177] Tests for ColumnsSettings are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:11:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:11:59 +0000
Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:12:01 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:12:01 +0000
Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49756|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 49774
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49774&action=edit
Bug 16176: Fix a test about OpenLibrarySearch
Introduced by bug 6624: When C4::UsageStats::BuildReport is modified,
the tests should be too.
Test plan:
prove t/db_dependent/UsageStats.t
should return green
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
Note that if we maintain this list of sysprefs at two places, we will
probably have this test failing regularly..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:12:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:12:12 +0000
Subject: [Koha-bugs] [Bug 16176] t/db_dependent/UsageStats.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16176
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:15:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:15:59 +0000
Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed
number of tests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:16:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:16:02 +0000
Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed
number of tests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49705|0 |1
is obsolete| |
--- Comment #4 from Marcel de Rooy ---
Created attachment 49775
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49775&action=edit
Bug 16173: db_structure.t shouldn't have a fixed number of tests
This patch makes db_structure.t more flexible regarding how many tests are run.
This is important because it would fail on each db structure change, masking
potential
real problems.
To test:
- Run
$ prove t/db_dependent/db_structure.t
=> FAIL: the number of tests ran doesn't match what is expected
- Apply the patch
- Run
$ prove t/db_dependent/db_structure.t
=> SUCCESS: Tests count is not an issue [1]
- Sign off
[1] Right now the tests run successfuly, they might fail if a real bug is
introduced
on the DB structure, in the meantime.
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:16:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:16:12 +0000
Subject: [Koha-bugs] [Bug 16173] db_structure.t shouldn't have a fixed
number of tests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16173
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:35:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:35:49 +0000
Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:35:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:35:51 +0000
Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49744|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 49776
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49776&action=edit
Bug 16178: Fix tests for xt/single_quotes.t
Caused by
commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac
Bug 15206: Make strings translatable
Test plan:
prove xt/single_quotes.t
should return green
Signed-off-by: Nick Clemens
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:37:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:37:03 +0000
Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |String patch
QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:37:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:37:46 +0000
Subject: [Koha-bugs] [Bug 16178] Tests for xt/single_quotes.t are failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16178
--- Comment #4 from Marcel de Rooy ---
Spotted another one (outside the templates) too:
cataloguing/value_builder/unimarc_leader.pl: alert(_('leader has an
incor
But fixing that one is useless.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:47:16 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:19 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:47:19 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49702|0 |1
is obsolete| |
Attachment #49703|0 |1
is obsolete| |
Attachment #49757|0 |1
is obsolete| |
--- Comment #8 from Marcel de Rooy ---
Created attachment 49777
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49777&action=edit
Bug 16174: Warning in tt_valid.t due to bug 15527
Bug 15527 introduced a new directory (xslt) on the top level OPAC templates
directory. The tt_valid.t script should include that top level dir on the list
of excluded dirs so it doesn't look for themes there.
To test:
- Run
$ prove xt/tt_valid.t
=> FAIL: You get the following warning:
Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory
at xt/tt_valid.t line 8
- Apply the patch
- Run
$ prove xt/tt_valid.t
=> SUCCESS: Tests pass and don't raise warnings.
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:47:23 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
--- Comment #9 from Marcel de Rooy ---
Created attachment 49778
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49778&action=edit
Bug 16174: icondirectories.t broken due to bug 15527
This patch fixes it.
To test:
- Run
$ prove xt/author/icondirectories.t
=> FAIL: Tests fail:
Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg
exists'
- Apply the patch
- Run
$ prove xt/author/icondirectories.t
=> SUCCESS: Tests pass and don't raise warnings.
- Sign off
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:27 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:47:27 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
--- Comment #10 from Marcel de Rooy ---
Created attachment 49779
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49779&action=edit
Bug 16174: (QA followup) Fix remaining tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 10:47:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 08:47:39 +0000
Subject: [Koha-bugs] [Bug 16174] Problems in icondirectories.t and
tt_valid.t due to bug 15527
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16174
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:26:37 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 09:26:37 +0000
Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file
uploading
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:26:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 09:26:39 +0000
Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file
uploading
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686
--- Comment #14 from Marcel de Rooy ---
Created attachment 49780
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49780&action=edit
Bug 14686: [QA Follow-up] Move allows_add_by to Upload.pm
As requested by QA, the sub should be moved.
Test plan:
See previous patches.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 11:28:34 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 09:28:34 +0000
Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file
uploading
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686
--- Comment #15 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #13)
> So I am not convinced that we should move it. But if you really insist, I'd
> rather move it to Upload.pm or so?
No reply is also an answer.
Jesse: I moved it. Please finish QA now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 13:48:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 11:48:07 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
version of Swagger2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
--- Comment #18 from Benjamin Rokseth ---
Comment on attachment 44373
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44373
Bug 15126: x-mojo-controller deprecation
>From a1267ff354633ef7f491704f81d9ffe1590672a7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize
>Date: Wed, 7 Oct 2015 14:49:17 +0000
>Subject: [PATCH] Bug 15126: x-mojo-controller deprecation
>
>Remove the use of soon to be deprecated x-mojo-controller from our
>specification and replace with the recommended operationId format.
>---
> Koha/REST/V1/{Patrons.pm => Patron.pm} | 6 +++---
> api/v1/swagger.json | 2 --
> 2 files changed, 3 insertions(+), 5 deletions(-)
> rename Koha/REST/V1/{Patrons.pm => Patron.pm} (96%)
>
>diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patron.pm
>similarity index 96%
>rename from Koha/REST/V1/Patrons.pm
>rename to Koha/REST/V1/Patron.pm
>index 6468bba..fee6c31 100644
>--- a/Koha/REST/V1/Patrons.pm
>+++ b/Koha/REST/V1/Patron.pm
>@@ -1,4 +1,4 @@
>-package Koha::REST::V1::Patrons;
>+package Koha::REST::V1::Patron;
>
> # This file is part of Koha.
> #
>@@ -22,7 +22,7 @@ use Mojo::Base 'Mojolicious::Controller';
> use C4::Auth qw( haspermission );
> use Koha::Patrons;
>
>-sub list_patrons {
>+sub list {
> my ($c, $args, $cb) = @_;
>
> my $user = $c->stash('koha.user');
>@@ -35,7 +35,7 @@ sub list_patrons {
> $c->$cb($patrons->unblessed, 200);
> }
>
>-sub get_patron {
>+sub get {
> my ($c, $args, $cb) = @_;
>
> my $user = $c->stash('koha.user');
>diff --git a/api/v1/swagger.json b/api/v1/swagger.json
>index 8f32781..e821c44 100644
>--- a/api/v1/swagger.json
>+++ b/api/v1/swagger.json
>@@ -16,7 +16,6 @@
> "paths": {
> "/patrons": {
> "get": {
>- "x-mojo-controller": "Koha::REST::V1::Patrons",
> "operationId": "listPatrons",
> "tags": ["patrons"],
> "produces": [
>@@ -43,7 +42,6 @@
> },
> "/patrons/{borrowernumber}": {
> "get": {
>- "x-mojo-controller": "Koha::REST::V1::Patrons",
> "operationId": "getPatron",
> "tags": ["patrons"],
> "parameters": [
>--
>1.9.1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:16:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:16:13 +0000
Subject: [Koha-bugs] [Bug 16084] log4perl.conf not properly set on packages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16084
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |julian.maurice at biblibre.com
--- Comment #6 from Julian Maurice ---
Patches pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:21:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:21:30 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
version of Swagger2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #44372|0 |1
is obsolete| |
Attachment #44373|0 |1
is obsolete| |
Attachment #44374|0 |1
is obsolete| |
--- Comment #19 from Benjamin Rokseth ---
Created attachment 49781
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49781&action=edit
Bug 15126: Refactor spec file
Spreading the specification over multiple files should lead to a more
manageable specification long term
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:21:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:21:52 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
version of Swagger2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
--- Comment #20 from Benjamin Rokseth ---
Created attachment 49782
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49782&action=edit
Bug 15126: x-mojo-controller deprecation
Remove the use of soon to be deprecated x-mojo-controller from our
specification and replace with the recommended operationId format.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:22:02 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:22:02 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
version of Swagger2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
--- Comment #21 from Benjamin Rokseth ---
Created attachment 49783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49783&action=edit
Bug 15126: Update dependencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:22:38 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:22:38 +0000
Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |Pushed to Stable
--- Comment #7 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:26:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:26:10 +0000
Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer
version of Swagger2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |benjamin.rokseth at kul.oslo.k
| |ommune.no
--- Comment #22 from Benjamin Rokseth ---
Sorry for the spamming, I rebased the patches against master, since some
changes were already pushed to master by bug #13799.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:55:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:55:05 +0000
Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772
Bug 12772 depends on bug 16007, which changed state.
Bug 16007 Summary: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 14:55:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 12:55:04 +0000
Subject: [Koha-bugs] [Bug 16007] Correction of 'Remove columns branchcode,
categorytype from table overduerules_transport_types'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |RESOLVED
--- Comment #24 from Julian Maurice ---
Not needed in stable versions, status changed to RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:01:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:01:26 +0000
Subject: [Koha-bugs] [Bug 16151] can't place holds from lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |julian.maurice at biblibre.com
--- Comment #6 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:03:50 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:03:50 +0000
Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are
broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |Pushed to Stable
--- Comment #10 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:06:39 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:06:39 +0000
Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |Pushed to Stable
--- Comment #6 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:10:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:10:25 +0000
Subject: [Koha-bugs] [Bug 16040] Quote deletion never ending processing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16040
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |Pushed to Stable
--- Comment #6 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:13:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:13:03 +0000
Subject: [Koha-bugs] [Bug 16082] Empty patron detail page is displayed if
the patron does not exist - circulation.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16082
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |julian.maurice at biblibre.com
--- Comment #6 from Julian Maurice ---
Patch pushed to 3.22.x, will be in 3.22.6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:34:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:34:03 +0000
Subject: [Koha-bugs] [Bug 16185] New: t/db_dependent/Reports_Guided.t is
failing
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
Bug ID: 16185
Summary: t/db_dependent/Reports_Guided.t is failing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: gmcharlt at gmail.com
Reporter: mtompset at hotmail.com
QA Contact: testopia at bugs.koha-community.org
"t_db_dependent_Reports_Guided_t.filter takes report id (661)"
http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680/testReport/
prove t/db_dependent/Reports_Guided.t should run successfully.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:37:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:37:13 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Assignee|gmcharlt at gmail.com |mtompset at hotmail.com
--- Comment #1 from M. Tompsett ---
Turns out my perlcritic happiness tendency found a solution. Scalar was being
used as a function. Removing function-like bracketing fixed the issue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:47:57 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:47:57 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:47:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:47:59 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
--- Comment #2 from M. Tompsett ---
Created attachment 49784
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49784&action=edit
Bug 16185: t/db_dependent/Reports_Guided.t is failing
TEST PLAN
---------
1) prove t/db_dependent/Reports_Guided.t
-- fails
-- note the failure has a scalar function-like bracketing
2) apply patch
3) prove t/db_dependent/Reports_Guided.t
-- passes
4) git diff origin/master
-- note all scalars have been changed to not have
function-like brackets which could be incorrectly
parsed.
5) run koha qa test tools
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:49:03 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:49:03 +0000
Subject: [Koha-bugs] [Bug 16160] t/db_dependent/www/search_utf8.t fails due
to layout change
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |julian.maurice at biblibre.com
Status|Pushed to Master |RESOLVED
--- Comment #11 from Julian Maurice ---
Tests pass on 3.22.x without this patch, status changed to RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:57:05 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
--- Comment #68 from Martin Renvoize ---
Created attachment 49785
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49785&action=edit
Bug 10988 - Fixes for comments 57 and 58
Test Plan (remains the same):
0) Back up your database
1) Apply all these patches
2) In your mysql client use your Koha database and execute:
> DELETE FROM systempreferences;
> SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
-- Should be no errors.
> SELECT * FROM systempreferences LIKE 'GoogleO%';
-- Should see 4 entries.
> QUIT;
3) Restore your database
4) Run ./installer/data/mysql/updatedatabase.pl;
5) In your mysql client use your Koha database and execute:
> SELECT * FROM systempreferences LIKE 'GoogleO%';
-- Should see the same 4 entries.
6) Log into the staff client
7) Home -> Koha administration -> Global system preferences
8) -> OPAC
-- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca)
9) -> Administration
-- There should be a 'Google OAuth2' section with the ability
to set those 4 system preferences.
10) In a new tab, go to https://console.developers.google.com/project
11) Click 'Create Project'
12) Type in a project name that won't freak users out, like your
library name (e.g. South Pole Library).
13) Click the 'Create' button.
14) Click the 'APIs & auth' in the left frame.
15) Click 'Credentials'
16) Click 'Create new Client ID'
17) Select 'Web application' and click 'Configure consent screen'.
18) Select the Email Address.
19) Put it a meaningful string into the Product Name
(e.g. South Pole Library Authentication)
20) Fill in the other fields as desired (or not)
21) Click 'Save'
22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL.
(http://library.yourDNS.org)
23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new
googleoauth2 script
(http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleopenidconnect)
24) Click 'Create Client ID'
25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID
system preference.
26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret
system preference.
27) Change the GoogleOpenIDConnect preference to 'Use'.
28) Click 'Save all Administration preferences'
29) In the OPAC, click 'Log in to your account'.
-- You should get a confirmation request, if you are
already logged in, OR a login screen if you are not.
-- You need to have the primary email address set to one
authenticated by Google in order to log in.
30) Run koha qa test tools
Signed-off-by: Mark Tompsett
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:09 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:57:09 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
--- Comment #69 from Martin Renvoize ---
Created attachment 49786
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49786&action=edit
Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect
Signed-off-by: Mark Tompsett
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:13 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:57:13 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
--- Comment #70 from Martin Renvoize ---
Created attachment 49787
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49787&action=edit
Bug 10988: Tabs vs Spaces qa failure patch
Run Koha QA Test tools and discovered this failed because of tabs.
Rather than fail this and wait forever for it to get fixed, this
patches it, and I'll mark it as signed off anyways.
Signed-off-by: Mark Tompsett
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:57:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:57:49 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47780|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:58:00 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47781|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:12 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:58:12 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47782|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 15:58:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 13:58:36 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
Connect)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #71 from Martin Renvoize ---
Looks great, works great, good enhancement.. well done!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:03:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:03:55 +0000
Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49271|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 49788
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788&action=edit
Bug 15630 - Make Edifact module pluggable
Koha's EDIFACT module works great for many European vendors,
but does not work will for US vendors, which have a much different
interpretation of 'standard'. In fact, each vendor may require
different arrangements of values in EDIFACT messages. It would be
impossible to encompass all these requirements within Koha's EDIFACT
module itself. Instead, we should allow the module to be pluggable, so
versions of the module can be developed for vendors that require EDIFACT
messages that don't conform to the standard set by Koha's EDIFACT
module.
Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable Koha plugins
4) Install the Edifact stub plugin available at
https://github.com/bywatersolutions/koha-plugin-edifact-stub
5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account
6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors
or changes to the EDIFACT message input or output
Signed-off-by: Jason DeShaw
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:04:36 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:04:36 +0000
Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #6 from Martin Renvoize ---
Nice enhancement, should make things much more extensible.. Go forth :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:07:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:07:18 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
authentication.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:10:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:10:52 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
authentication.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46183|0 |1
is obsolete| |
--- Comment #14 from Martin Renvoize ---
Created attachment 49790
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49790&action=edit
Bug 11807: (follow-up) remove date conversions
To test
1/ Apply both patches
2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful
LDAP login.
Here is an example configuration :
STU
...
STUDENT
EMPLOYEE
3/ With this configuration, LDAP users with the usertype value "EMP" on the
LDAP server should have the "EMPLOYEE" categorycode in Koha.
Signed-off-by: Chris
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:10:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:10:49 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
authentication.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46182|0 |1
is obsolete| |
--- Comment #13 from Martin Renvoize ---
Created attachment 49789
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49789&action=edit
Bug 11807 : Add support for categorycode conversions when updating an user
using a LDAP server.
To test
1/ Apply both patches
2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful
LDAP login.
Here is an example configuration :
STU
...
STUDENT
EMPLOYEE
3/ With this configuration, LDAP users with the usertype value "EMP" on the
LDAP server should have the "EMPLOYEE" categorycode in Koha.
Signed-off-by: Chris
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:11:44 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:11:44 +0000
Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP
authentication.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #15 from Martin Renvoize ---
Happy there no breaking changes here, and a worthwhile addition. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:18:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:18:56 +0000
Subject: [Koha-bugs] [Bug 16186] New:
t/db_dependent/Circulation_Issuingrule.t is failing
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
Bug ID: 16186
Summary: t/db_dependent/Circulation_Issuingrule.t is failing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: mtompset at hotmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Bug 5786 changed the query for GetIssuingRules to SELECT *, which means if
columns are added to the DB, this breaks.
Add missing column(s) into the issuing rules hashes in the test.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:18:58 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:18:58 +0000
Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889
--- Comment #8 from Martin Renvoize ---
Just to note.. I tested this for QA just after Katring passed it.. it was all
good but I never gave it my stamp.. so here's a stamp :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:19:14 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:19:14 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com
|ity.org |
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:19:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:19:25 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:26:42 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:26:42 +0000
Subject: [Koha-bugs] [Bug 16129] Remove URL::Encode dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49743|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 49791
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49791&action=edit
Bug 16129: Remove URL::Encode dependency
This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.
It uses the URI package which is already a Koha dependency.
To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D
Note: I deleted the line in which $amount_to_pay was url-encoded, because
that's
one of the things query_form does (and the variable is only used as a parameter
to it).
Sponsored-by: ByWater Solutions
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:27:18 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:27:18 +0000
Subject: [Koha-bugs] [Bug 16129] Remove URL::Encode dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #5 from Martin Renvoize ---
Good move Tomas, works as advertised, removes the dependency without causing
any issues.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:31:10 +0000
Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from
login timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006
--- Comment #15 from Colin Campbell ---
(In reply to Kyle M Hall from comment #13)
> I will try to find some time to run some tests. Here is what I will do:
>
> 1) Revert 13432 on master
> 2) Set up a script that continuously makes sip2 calls via sip_cli_emulator.pl
> 3) Let that run for a long time
> 4) Note whether memory usage increases dramatically
> 5) Apply this patch
> 6) Repeat steps 2-4
> 6) Apply bug 15006
> 7) Repeat steps 2-4
>
> If everything checks out, we should move ahead with this.
>
> Colin, does that seem like a reasonable test plan?
Yes - Would be interested if the same test was run using Netserver::Fork,
instead of Netserver::Prefork that should return resources from dead
connections (although memory leak may be elsewhere)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:46 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:31:46 +0000
Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49736|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 49792
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49792&action=edit
Bug 16138: Restart plack when rotating logfiles
On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to
permission issues:
Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't
locate Authen/CAS/Client/Response/Failure.pm
: ./Authen/CAS/Client/Response/Failure.pm: Permission denied at
/usr/share/perl/5.20/base.pm line 97.
...propagated at /usr/share/perl/5.20/base.pm line 106.
BEGIN failed--compilation aborted at
/usr/share/perl5/Authen/CAS/Client/Response.pm line 68.
Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line
8.
Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line
25.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm
line 25.
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90.
Compilation failed in require at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.
BEGIN failed--compilation aborted at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.
As we do with zebra daemons, starman should be restarted as it doesn't handle
log file rotation
gracefully[1].
I'm not sure how to reproduce it on a dev environment.
[1] https://github.com/miyagawa/Starman/issues/55
Signed-off-by: Mirko Tietgen
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:31:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:31:54 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Charles Farmer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:32:04 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:32:04 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #30 from Charles Farmer ---
Created attachment 49793
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49793&action=edit
Bug 12446 - Enable adult patrons to have a guarantor
I have rebased every patch.
This includes all the features from the previous patches.
Removed the dollar signs and stopped using C4::Category
On the patron category page, there is a new field to specify whether patrons
can be guarantee or not.
The atomic update SQL script adds this new field and sets it to true for
categories of type "C" and "P".
1) Apply the patch
2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and
canbeguarantee to categories.
3) Go to patron category administration, edit a category and change the value
of Can Be Guarantee to yes (for Child and Professional mostly to set it by
default)
4) See below to test various scenarios
- Enable an adult to have a guarantor:
0.0) Create or edit a patron category of type 'A'.
0.1) Set the "Can be guarantee" field to "Yes" and save.
1) Select an adult patron -> details tab;
2) Click edit button;
3) validate "guarantor information" fieldset;
- Shows guarantees' fines in the guarantor's page:
4) Click Set to patron button and select a guarantor;
5) Generate a fine;
6) Select guarantor patron -> details tab;
7) Validate guarantee's fine information.
- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer some guarantor's information to the guarantee while creating a new
patron
0) Select an adult patron;
1) Insert all information;
2) Add a new adult patron;
3) Click "Set to patron" button;
4) Select the adult patron from 0);
5) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer guarantor's alternate address/contact to the guarantee while
creating a new patron:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
2) Select an adult patron;
3) Insert all information;
4) Add a new adult patron;
5) Click "Set to patron" button;
6) Select the adult patron from 0);
7) Validade Garantor information/Main address/Contact fieldsets filled;
8) Validade Garantor additional alternate address/contact filled;
- Transfer guarantor's alternate address/contact to the guarantee while adding
a guarantiee:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
3) Select an adult patron;
4) Insert all information;
5) Click Add guarantiee bouton;
6) Validade Garantor information/Main address/Contact fieldsets filled;
7) Validade Garantor additional alternate address/contact filled;
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:32:24 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:32:24 +0000
Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #5 from Martin Renvoize ---
Simple, but effective. I managed to replicated the issues, and his patch fixed
them.
Cheers Tomas
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:36:54 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:36:54 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Charles Farmer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |charles.farmer at inlibro.com
Attachment #46345|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:37:10 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:37:10 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Charles Farmer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46486|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:38:56 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:38:56 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:38:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:38:59 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
--- Comment #1 from M. Tompsett ---
Created attachment 49794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49794&action=edit
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
Went a little beyond scope and added missing fields, even
though tests weren't failing.
TEST PLAN
---------
1) prove t/db_dependent/Circulation_Issuingrule.t
-- fails
2) apply patch
3) prove t/db_dependent/Circulation_Issuingrule.t
-- pass
4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t
-- notice that bug 5876 and bug 9129 combined to cause this
5) run koha qa test tools
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:43:45 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:43:45 +0000
Subject: [Koha-bugs] [Bug 16068] System preference override feature
(OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #8 from Martin Renvoize ---
16044 is pushed to master now.. presume we only need the one patch.. (in fact
they look the same to me on cursory glance)
Obsoleting the 'on top of bug 16044' version and qa'ing the other.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:43:55 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:43:55 +0000
Subject: [Koha-bugs] [Bug 16068] System preference override feature
(OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49168|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:51:59 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:51:59 +0000
Subject: [Koha-bugs] [Bug 16068] System preference override feature
(OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49168|1 |0
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 16:53:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 14:53:30 +0000
Subject: [Koha-bugs] [Bug 16068] System preference override feature
(OVERRIDE_SYSPREF_* = ) is not reliable for some cache systems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16068
--- Comment #9 from Martin Renvoize ---
On second thoughts, it looks like it needs rebasing.. I've un-obsoleted the one
I obsoleted.
Applying the 'master' one results in a qa script error:
FAIL valid
Global symbol "%syspref_L1_cache" requires explicit package
name
Compilation failed in require
BEGIN failed--compilation aborted
As I'm not totally up to speed on this, I'm going to leave re-basing to someone
else.. even though it looks trivial.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:02:30 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:02:30 +0000
Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to
'starts_with' and not getting correct parameters to parse multiple word
searches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930
Ian Bays changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ian.bays at ptfs-europe.com
--- Comment #9 from Ian Bays ---
I suppport what Heather says in comment 5 that it has the appearance of a bug.
If you search for a user with both names from the patron search on the Koha
staff home page you get a short list or no results. If you then do the same
search from the Patrons page you get many more results. If you are worried
about getting too many results then you may need to select something different
such as "begins with". We have just installed a couple of new customers with
version 3.22.03.000 and they are assuming it will be fixed soon. I hope this
has not stalled.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:23 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:09:23 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:26 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:09:26 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49784|0 |1
is obsolete| |
--- Comment #3 from Tom?s Cohen Arazi ---
Created attachment 49795
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49795&action=edit
Bug 16185: t/db_dependent/Reports_Guided.t is failing
TEST PLAN
---------
1) prove t/db_dependent/Reports_Guided.t
-- fails
-- note the failure has a scalar function-like bracketing
2) apply patch
3) prove t/db_dependent/Reports_Guided.t
-- passes
4) git diff origin/master
-- note all scalars have been changed to not have
function-like brackets which could be incorrectly
parsed.
5) run koha qa test tools
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:09:47 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:09:47 +0000
Subject: [Koha-bugs] [Bug 16185] t/db_dependent/Reports_Guided.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:11:49 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:11:49 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:11:52 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:11:52 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49794|0 |1
is obsolete| |
--- Comment #2 from Tom?s Cohen Arazi ---
Created attachment 49796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49796&action=edit
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
TEST PLAN
---------
1) prove t/db_dependent/Circulation_Issuingrule.t
-- fails
2) apply patch
3) prove t/db_dependent/Circulation_Issuingrule.t
-- pass
4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t
-- notice that bug 5876 and bug 9129 combined to cause this
5) run koha qa test tools
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:13:07 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:13:07 +0000
Subject: [Koha-bugs] [Bug 16186] t/db_dependent/Circulation_Issuingrule.t is
failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
Status|Signed Off |Passed QA
--- Comment #3 from Tom?s Cohen Arazi ---
Trivial fix for the tests.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:20:51 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:20:51 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47108|0 |1
is obsolete| |
--- Comment #69 from Tom?s Cohen Arazi ---
Created attachment 49797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49797&action=edit
Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics'
table
This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped
inside a subtest, and look for AddReturn storing the right itemtype on the
'statistics' table.
Note: It also refactors the file a bit, to avoid side effects. And uses
TestBuilder
to make it independent on already-present db data. It also removes warnings by
mocking
C4::Context::userenv
To test:
- Apply the patch
- Run the tests:
$ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail bacause AddReturn is not storing the itemtype
- Sign off :-D
Sponsored-by: Universidad Empresarial Siglo 21
Signed-off-by: Kyle M Hall
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:00 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:21:00 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47109|0 |1
is obsolete| |
--- Comment #70 from Tom?s Cohen Arazi ---
Created attachment 49798
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49798&action=edit
Bug 14598: Make C4::Circulation::AddReturn store the right itemtype
This patch makes C4::Circulation::AddReturn correctly store the itemtype
on the 'statistics' table.
To reproduce:
- Checkout master.
- Make a checkout.
- Check the 'statistics' table and notice the itemtype is correctly set
> SELECT * FROM statistics;
- Check the item in.
- Check the 'statistics' table and notice the itemtype is not set
> SELECT * FROM statistics WHERE type="return";
=> FAIL: itemtype is set to NULL
To test:
- Apply the regression tests patch
- Run the tests:
$ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail
- Apply this patch
- Run the regression tests:
$ prove t/db_dependent/Circulation/Returns.t
=> SUCCESS: Tests now pass.
- Repeat the 'To reproduce' steps
=> SUCCESS: itemtype is now correctly set (in real life)
- Happily sign off :-D
Sponsored-by: Universidad Empresarial Siglo 21
Signed-off-by: Kyle M Hall
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:05 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:21:05 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47110|0 |1
is obsolete| |
--- Comment #71 from Tom?s Cohen Arazi ---
Created attachment 49799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49799&action=edit
Bug 14598: (QA followup) Don't die on bad barcode
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Kyle M Hall
Signed-off-by: Kyle M Hall
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:11 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:21:11 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47111|0 |1
is obsolete| |
--- Comment #72 from Tom?s Cohen Arazi ---
Created attachment 49800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49800&action=edit
Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows
This patch introduces an updatedatabase.pl entry that takes care of
updating existing statistics rows.
It does so by looping on the statistics rows, collecting itemnumber occurences
that are have NULL itemtypes.
It then chooses the right itemtype following what is proposed on bug 14651, and
then updates the rows in statistics using the calculated itemtype.
Regards
Signed-off-by: Kyle M Hall
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:16 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:21:16 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47112|0 |1
is obsolete| |
--- Comment #73 from Tom?s Cohen Arazi ---
Created attachment 49801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49801&action=edit
Bug 14598 - QA Followup touching CanBookBeIssued subroutine
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Apr 1 17:21:25 2016
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Apr 2016 15:21:25 +0000
Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by
C4::Circulation::AddReturn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47113|0 |1
is obsolete| |
--- Comment #74 from Tom?s Cohen Arazi ---
Created attachment 49802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49802&action=edit
Bug 14598 [QA Followup] - Only fetch bib data if needed
Signed-off-by: Kyle M Hall
Signed-off-by: Tomas Cohen Arazi