[Koha-bugs] [Bug 16208] New: Can't delete a library EAN if the EAN value is empty

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208

            Bug ID: 16208
           Summary: Can't delete a library EAN if the EAN value is empty
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/admin/edi_ean_accounts.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 7736

In testing the new EDI pages I tried adding a "Library EAN" with no fields
filled out (other than the pre-filled options). The record saved successfully
with empty values for EAN and description.

When I went to test deletion of one of these records I got an error: 

Can't call method "delete" on an undefined value at /admin/edi_ean_accounts.pl
line 112.

I notice the link to delete passes the ean value (which is empty in my test):

/admin/edi_ean_accounts.pl?op=delete_confirm&branchcode=APL&ean=

I assume this is the reason for the error.

If the edifact_ean table has a primary key (ee_id), why not use that for
deletion?

Should the EAN field be required?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.