[Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Apr 6 00:58:16 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179
M. Tompsett <mtompset at hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49858|0 |1
is obsolete| |
--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 49936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49936&action=edit
Bug 16179: Do not crash if "rate me" is clicked and not rate selected
If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208
To avoid that, opac-ratings.pl will check if a rate has been selected.
Test plan:
Disable JS
On a record detail page, click on the "Rate me" button
TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
-- kaboom as above.
2) apply patch
3) refresh
-- either login screen (don't know why)
-- or if already logged in, detail page.
4) koha qa test tool
NOTE: disabling JS breaks OPAC.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list